From nobody Tue Jun 30 21:19:30 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EDC9C433FE for ; Sat, 8 Jan 2022 08:27:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233815AbiAHI1q (ORCPT ); Sat, 8 Jan 2022 03:27:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233789AbiAHI1p (ORCPT ); Sat, 8 Jan 2022 03:27:45 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BECD3C061574 for ; Sat, 8 Jan 2022 00:27:44 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id s1so15658734wra.6 for ; Sat, 08 Jan 2022 00:27:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2VTMSOScwZ5T0eJZE+RIoj2iFIAziaiqOLrqg1J6kPo=; b=VDyagUQnQ9G/ePVpOaXdBthLWofpAvyn6zKq4pXXZENzFU+MYPdthLPbFDeRcz1ZU3 dnDqxjEdWmNl7elZxYk2YnqSz5oX/IbczUmBe8hs0pVEFMHGzU+jU7/mdCSGLsrVKbvu Y1EcJTL/Qgdl3CK0ciwIa+r4QI/FVCkHmA96XlIddNEWW8U+ShS14k8OFvW1JuxLGjru 3sm82mPZmaJI/GF/vnrvfyOLP7dnvAIZOWHKMbqJSuNdV+6f9n2gDGYK6m9yJoip3lMx tIs+saQ+nq45UYenNPg4XzYpa9S1pkYZL/0UdP5UA5TPT+O2Iqaj2ut0+w/qSg+F4FKr prqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2VTMSOScwZ5T0eJZE+RIoj2iFIAziaiqOLrqg1J6kPo=; b=V56pYXsoPdliSZnkUT7sigNuOF2WLgHgyCx5bIV6K9GAGwEPgtIu3JCP0cQlKWn8DO zB5sGLSCaDqFygAv70CztUintyuE8j3r0XQm933a9slZRvuusRb68IS/nwpgXy0jKsxV rvh1hEAgIixfKj8SLdkjD6SwgdCl7tA8ADTauz+teoB6RSiqmb3AAJ1ylK+O6R4g2+Mu GoT9ikBf/sQtVxzwdcIkKJ1FiLL9+JjSnwJ1CUHsswFS2uXPJbBmeyKVS93tpZ3Zm1U0 puRQJY5aRVIQp9kFfOHYBfYWu6er604hNs100V7QafWxsJJxXQ2+FmyA+jzK1TmVxm3U EWgA== X-Gm-Message-State: AOAM531srMwQcAe7vmWlYrZK3+2bWQDOV1peWF8AgBWYxRcHkNeoeNiU qh3KGCnLRd+KIOJl9IgExAzPZwWLLIc= X-Google-Smtp-Source: ABdhPJwXet+ZeTuvwBc2WsufI6r47xn7p8ytBi3ECBDVsmEpsrr1ECpygzI7SLAmmr962hf/Y1D8+A== X-Received: by 2002:a05:6000:12d0:: with SMTP id l16mr55460959wrx.466.1641630463421; Sat, 08 Jan 2022 00:27:43 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::51e2]) by smtp.gmail.com with ESMTPSA id az1sm964536wrb.104.2022.01.08.00.27.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Jan 2022 00:27:43 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 1/5] staging: r8188eu: rtw_hostapd_mlme_rx() is empty Date: Sat, 8 Jan 2022 09:27:32 +0100 Message-Id: <20220108082736.16788-2-straube.linux@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220108082736.16788-1-straube.linux@gmail.com> References: <20220108082736.16788-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The function rtw_hostapd_mlme_rx() is empty. Remove it. Signed-off-by: Michael Straube --- drivers/staging/r8188eu/core/rtw_mlme_ext.c | 2 -- drivers/staging/r8188eu/include/recv_osdep.h | 1 - drivers/staging/r8188eu/os_dep/recv_linux.c | 5 ----- 3 files changed, 8 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/= r8188eu/core/rtw_mlme_ext.c index a9141ab1690e..cdd928c37a3e 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c @@ -459,8 +459,6 @@ void mgt_dispatcher(struct adapter *padapter, struct re= cv_frame *precv_frame) break; default: _mgt_dispatcher(padapter, ptable, precv_frame); - if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) - rtw_hostapd_mlme_rx(padapter, precv_frame); break; } } diff --git a/drivers/staging/r8188eu/include/recv_osdep.h b/drivers/staging= /r8188eu/include/recv_osdep.h index e87467022b39..4b5e3dde4590 100644 --- a/drivers/staging/r8188eu/include/recv_osdep.h +++ b/drivers/staging/r8188eu/include/recv_osdep.h @@ -14,7 +14,6 @@ s32 rtw_recv_entry(struct recv_frame *precv_frame); int rtw_recv_indicatepkt(struct adapter *adapter, struct recv_frame *recv_= frame); void rtw_recv_returnpacket(struct net_device *cnxt, struct sk_buff *retpk= t); =20 -void rtw_hostapd_mlme_rx(struct adapter *padapter, struct recv_frame *recv= _fr); void rtw_handle_tkip_mic_err(struct adapter *padapter, u8 bgroup); =20 int rtw_init_recv_priv(struct recv_priv *precvpriv, struct adapter *padapt= er); diff --git a/drivers/staging/r8188eu/os_dep/recv_linux.c b/drivers/staging/= r8188eu/os_dep/recv_linux.c index 5a7fb94e21c1..41c4e35d967f 100644 --- a/drivers/staging/r8188eu/os_dep/recv_linux.c +++ b/drivers/staging/r8188eu/os_dep/recv_linux.c @@ -100,11 +100,6 @@ void rtw_handle_tkip_mic_err(struct adapter *padapter,= u8 bgroup) &wrqu, (char *)&ev); } =20 -void rtw_hostapd_mlme_rx(struct adapter *padapter, - struct recv_frame *precv_frame) -{ -} - int rtw_recv_indicatepkt(struct adapter *padapter, struct recv_frame *precv_frame) { --=20 2.34.1 From nobody Tue Jun 30 21:19:30 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69D02C433F5 for ; Sat, 8 Jan 2022 08:27:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233842AbiAHI1v (ORCPT ); Sat, 8 Jan 2022 03:27:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233799AbiAHI1q (ORCPT ); Sat, 8 Jan 2022 03:27:46 -0500 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87E45C061574 for ; Sat, 8 Jan 2022 00:27:45 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id n19-20020a7bc5d3000000b003466ef16375so6686089wmk.1 for ; Sat, 08 Jan 2022 00:27:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TxNoAeeze9rEMrqirvTKwXGPuD7a3cum906IRqtGFSE=; b=OudwkM3oWhgdary6En7VLK/7ka17/mFv1TG88WtBAJ8jdBQkDn6Oy7JgyK2xIwut4c qYdVfdRaF5xUhOmRsfKEz/wsY5SEghD/wIN9fre4XlWufbeHaCM8Klh2j9Zof8/U5qzu s0e2RJ0PUBbLGMhNnPjbt4LMqgWnt/we4Zltwx6w7yXbZFIjcHI9Y5afu1/KUUhINxhS dCh36A5Z+Fzwv/An/cgTaxn5Sf01R5S1/T8c4duQbpy4QPGVmHCE7bC179lXi5zZQqFu JPmcogb1c/iLI9gJZTQyURV5qwactd6LlejpKsA9I3eVW1i6vJ1cGicJmpDaUL/ZbGIL hXcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TxNoAeeze9rEMrqirvTKwXGPuD7a3cum906IRqtGFSE=; b=lY1RWM2X2eL9Y+Mqv0OC5/dxPBwwhLEukiI1HFSABd//gp0mglarbPFMLrPK0b+VEV aScXhc6vSMITyp6uTUi43o63nyq3VOQ6DR3eNWSOGdzgO3URLDi+MMu9QKnBYxIidpco LeRImM3WYQPzJTcQISAE6nFNWVxLmrFG3Sk1FjvtMLp6FSzhnRIdBy0ZrkmiegeEmWnj U6opKv/sQD4/RdJOll1942W3ySQ1H/85wVa2j1GWsZtD6Yjf81zjv5morKkKAb34cu57 wJJTuQRyTolU+IXhCiJGjIj8v6ewQjfwVknOq9sGOIalA8InPGNSwIFoLYeWYTlKduTl VstQ== X-Gm-Message-State: AOAM5304jCpnIIiDRrmjSrc4qpK6HBCnq6Dj6HzTjQo96Xex1PlVnkKs CMwStuFMjOFO5NyQXRzRh3R3LC4BCvg= X-Google-Smtp-Source: ABdhPJxD8l8RHFO9v/JDurGVDXLLNA4PKivI9I/jMvoDQH1Zop1p7WOPJ42QHXXdXvZC2qT+PUveAA== X-Received: by 2002:a1c:9856:: with SMTP id a83mr13738246wme.157.1641630464158; Sat, 08 Jan 2022 00:27:44 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::51e2]) by smtp.gmail.com with ESMTPSA id az1sm964536wrb.104.2022.01.08.00.27.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Jan 2022 00:27:43 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 2/5] staging: r8188eu: convert switch to if statement in mgt_dispatcher() Date: Sat, 8 Jan 2022 09:27:33 +0100 Message-Id: <20220108082736.16788-3-straube.linux@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220108082736.16788-1-straube.linux@gmail.com> References: <20220108082736.16788-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The 'switch (GetFrameSubType(pframe))' in mgt_dispatcher() has only one case that does something different than the default case. Convert the switch to an if statement to improve readability. Signed-off-by: Michael Straube --- drivers/staging/r8188eu/core/rtw_mlme_ext.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/= r8188eu/core/rtw_mlme_ext.c index cdd928c37a3e..a169a7a39ebc 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c @@ -443,24 +443,13 @@ void mgt_dispatcher(struct adapter *padapter, struct = recv_frame *precv_frame) psta->RxMgmtFrameSeqNum =3D precv_frame->attrib.seq_num; } =20 - switch (GetFrameSubType(pframe)) { - case WIFI_AUTH: + if (GetFrameSubType(pframe) =3D=3D WIFI_AUTH) { if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) ptable->func =3D &OnAuth; else ptable->func =3D &OnAuthClient; - fallthrough; - case WIFI_ASSOCREQ: - case WIFI_REASSOCREQ: - case WIFI_PROBEREQ: - case WIFI_BEACON: - case WIFI_ACTION: - _mgt_dispatcher(padapter, ptable, precv_frame); - break; - default: - _mgt_dispatcher(padapter, ptable, precv_frame); - break; } + _mgt_dispatcher(padapter, ptable, precv_frame); } =20 static u32 p2p_listen_state_process(struct adapter *padapter, unsigned cha= r *da) --=20 2.34.1 From nobody Tue Jun 30 21:19:30 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A1E1C433F5 for ; Sat, 8 Jan 2022 08:27:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233884AbiAHI1x (ORCPT ); Sat, 8 Jan 2022 03:27:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233811AbiAHI1q (ORCPT ); Sat, 8 Jan 2022 03:27:46 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7505DC061574 for ; Sat, 8 Jan 2022 00:27:46 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id l10so15625820wrh.7 for ; Sat, 08 Jan 2022 00:27:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=opcJou2QKZvpZH47htaA4xNqATRUo6eWlvXfZY39el4=; b=nOQZj1onBzDYlaJN1PlgdYElMGxvr/tNW98NxsFmb3IurHk5NXNA3vMnfzXO8zHVj5 Sf/pTxk0gDNZlYbukNIjbA6dxaDuU9QLrcC/GUYUm0OxMAXTtMxHdZSIeDO05TZnvOJC e7CNpr3NMtW0aO0IA/kKrAHfaxPufZdMWo8MXch7bhJljfhTSKtdgVfL+mR5SEC0sRHW LzdlRnw+X2IZY9VRFpXVfpdjYgqVVMuyzJ0ATscpjk/tCogEj/b3mCDgBexNCBc9y7GV j/TQT7bPSlD610VwUi528RS6iLxP7kEooNXsqV019cA+ef/3WiwCuoC33T7iRy3uwsHx k+bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=opcJou2QKZvpZH47htaA4xNqATRUo6eWlvXfZY39el4=; b=qLogqC6fcFGHVQoxvBfTSFiZpQpszZ0sirndnWDJvsPBL7VcEUaL/t6pk/vGJxTLyR qINgQDK8F2hrW/6NSsvxRlGVmTgVBfhMuP0yefxZkYowh9QtKlC7dOpDAeQgJCqbS/6s m7WT9FnXHuddbPBIvKtB0hgu367AUkLK/TGDf8vT7ka09btAn/rf47ul5DAus+L+Q2Tw Z/95JJ6RrrPD2X7tWIYCOdmLM7Rsg3Q+NhhDMtoEfcHHG2u0lViz3OdI+b76PgtN2I/F sKWqnZ5E5VNmOl/sP52V1fYjiq1/ZS79VccD8pTAvTrmcoTsGir05S6Hx6bjZcTZE227 jPVQ== X-Gm-Message-State: AOAM533n2oYbqu1Geggl4A5Pptv0sTen3JK5zBK4NiC0E5dO9feKvIPe dSZRAGFnrCkLdfyVlKbz4to= X-Google-Smtp-Source: ABdhPJyPFf14zcqBjofnAyCSqwP5j6ImF0l1eXdd8vn/EQE269wYzrcAz/GNZHYi56K3XgSTlv6Bug== X-Received: by 2002:adf:f68b:: with SMTP id v11mr8735309wrp.260.1641630465164; Sat, 08 Jan 2022 00:27:45 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::51e2]) by smtp.gmail.com with ESMTPSA id az1sm964536wrb.104.2022.01.08.00.27.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Jan 2022 00:27:44 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 3/5] staging: r8188eu: rtw_os_recv_resource_free() is empty Date: Sat, 8 Jan 2022 09:27:34 +0100 Message-Id: <20220108082736.16788-4-straube.linux@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220108082736.16788-1-straube.linux@gmail.com> References: <20220108082736.16788-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The function rtw_os_recv_resource_free() is empty. Remove it. Signed-off-by: Michael Straube --- drivers/staging/r8188eu/core/rtw_recv.c | 2 -- drivers/staging/r8188eu/include/recv_osdep.h | 1 - drivers/staging/r8188eu/os_dep/recv_linux.c | 5 ----- 3 files changed, 8 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_recv.c b/drivers/staging/r818= 8eu/core/rtw_recv.c index 51a13262a226..72007952ee74 100644 --- a/drivers/staging/r8188eu/core/rtw_recv.c +++ b/drivers/staging/r8188eu/core/rtw_recv.c @@ -100,8 +100,6 @@ void _rtw_free_recv_priv(struct recv_priv *precvpriv) =20 rtw_free_uc_swdec_pending_queue(padapter); =20 - rtw_os_recv_resource_free(precvpriv); - vfree(precvpriv->pallocated_frame_buf); =20 rtl8188eu_free_recv_priv(padapter); diff --git a/drivers/staging/r8188eu/include/recv_osdep.h b/drivers/staging= /r8188eu/include/recv_osdep.h index 4b5e3dde4590..4c6cf5b1ac76 100644 --- a/drivers/staging/r8188eu/include/recv_osdep.h +++ b/drivers/staging/r8188eu/include/recv_osdep.h @@ -21,7 +21,6 @@ void rtw_free_recv_priv(struct recv_priv *precvpriv); =20 int rtw_os_recv_resource_init(struct recv_priv *recvpr, struct adapter *ad= apt); int rtw_os_recv_resource_alloc(struct adapter *adapt, struct recv_frame *r= ecvfr); -void rtw_os_recv_resource_free(struct recv_priv *precvpriv); =20 int rtw_os_recvbuf_resource_alloc(struct adapter *adapt, struct recv_buf *= buf); int rtw_os_recvbuf_resource_free(struct adapter *adapt, struct recv_buf *b= uf); diff --git a/drivers/staging/r8188eu/os_dep/recv_linux.c b/drivers/staging/= r8188eu/os_dep/recv_linux.c index 41c4e35d967f..0d3110a4c3d2 100644 --- a/drivers/staging/r8188eu/os_dep/recv_linux.c +++ b/drivers/staging/r8188eu/os_dep/recv_linux.c @@ -28,11 +28,6 @@ int rtw_os_recv_resource_alloc(struct adapter *padapter, return _SUCCESS; } =20 -/* free os related resource in struct recv_frame */ -void rtw_os_recv_resource_free(struct recv_priv *precvpriv) -{ -} - /* alloc os related resource in struct recv_buf */ int rtw_os_recvbuf_resource_alloc(struct adapter *padapter, struct recv_buf *precvbuf) --=20 2.34.1 From nobody Tue Jun 30 21:19:30 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED193C433FE for ; Sat, 8 Jan 2022 08:27:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233835AbiAHI14 (ORCPT ); Sat, 8 Jan 2022 03:27:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233820AbiAHI1s (ORCPT ); Sat, 8 Jan 2022 03:27:48 -0500 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 400DDC061574 for ; Sat, 8 Jan 2022 00:27:47 -0800 (PST) Received: by mail-wr1-x42f.google.com with SMTP id h10so5472941wrb.1 for ; Sat, 08 Jan 2022 00:27:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=avAv+SjmzSPk3oTkCTZAzHE4JzLH4DnHeEbaVJD8pf4=; b=lAOtfrSUhTIldjcpHxr7p8tG44vGhspLxjVquuuVLTlKNMLbKDENid1yNs2h5ceSOr FKd38fGV76Q59suDPEo/hXvva0fCdMdZJONnhFp6Ugj/HSIU/Po90PxYDWB10n4cRAzt wpVOgLROa2IJREYON/alDuAEYI7NsbmBpx8Re+2EfWj25pDtAGjcR4p5makvrIhWirOx n/VMuERtOMlDJTSVO/ufFvA9EekyDHNwW2hMAwzA+3jZvA7dnqy5QFmqSCcx5JPHqtFr eMSuT72FiIZWfj3RYBwc1Z+p14fUf9NMJOFP9mmF3MKy4+ouf+J6/EM+1G9uen4ESrJm MBQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=avAv+SjmzSPk3oTkCTZAzHE4JzLH4DnHeEbaVJD8pf4=; b=3YF0hRUL8eFxdp6efragiMOuWm/FUOEdS7za53DgFWFMgzankJ/VpF0rfqE2lMfhyJ kpY8qX9Z4VgLGa15zdlHacFz/y6UwcU7x8UmBbTysL8SssIChEzs8x3ncJO+OA2t5Yn8 UGJaNAfAHMMWohkVPSloRukBORNvvzpQlb2046PghKvO9HOGodCzYyU2RmfpruNpTWDB Ff/118WzS3ujAZ71vbtGBrwx+WUc5rhZUU8lHfGYjN2wfMVqIJ1Pv0L4KpRM2X2uqcbI kijgYgVa8AOOJQpwTkH8xsc5QphrQMhF5023uG7FiSJRqFs/4Y3EKmW8ld2SMvqDKDRB b5nQ== X-Gm-Message-State: AOAM5333uDHLWsq9rk1Rrp6TVbCP9PnD2LvlLiiK0uYle4thnmunNYE9 7kqCSjSpDfuTBAOoxXwA/eNCsw4FHp8= X-Google-Smtp-Source: ABdhPJzUwTCfBbq+Z6JY2QNO4VXXTtvIMXsOJshn6iiVvdXOZUX67Uf131NQOD+3zrl32D/XQAsM3w== X-Received: by 2002:a5d:4c82:: with SMTP id z2mr8270620wrs.605.1641630465879; Sat, 08 Jan 2022 00:27:45 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::51e2]) by smtp.gmail.com with ESMTPSA id az1sm964536wrb.104.2022.01.08.00.27.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Jan 2022 00:27:45 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 4/5] staging: r8188eu: rtw_os_recv_resource_init() does nothing Date: Sat, 8 Jan 2022 09:27:35 +0100 Message-Id: <20220108082736.16788-5-straube.linux@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220108082736.16788-1-straube.linux@gmail.com> References: <20220108082736.16788-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The function rtw_os_recv_resource_init() just returns _SUCCESS and the return value is not checked by the caller. Remove the function. Signed-off-by: Michael Straube --- drivers/staging/r8188eu/core/rtw_recv.c | 2 -- drivers/staging/r8188eu/include/recv_osdep.h | 1 - drivers/staging/r8188eu/os_dep/recv_linux.c | 7 ------- 3 files changed, 10 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_recv.c b/drivers/staging/r818= 8eu/core/rtw_recv.c index 72007952ee74..26893f36d1ff 100644 --- a/drivers/staging/r8188eu/core/rtw_recv.c +++ b/drivers/staging/r8188eu/core/rtw_recv.c @@ -54,8 +54,6 @@ int _rtw_init_recv_priv(struct recv_priv *precvpriv, stru= ct adapter *padapter) =20 precvpriv->free_recvframe_cnt =3D NR_RECVFRAME; =20 - rtw_os_recv_resource_init(precvpriv, padapter); - precvpriv->pallocated_frame_buf =3D vzalloc(NR_RECVFRAME * sizeof(struct = recv_frame) + RXFRAME_ALIGN_SZ); =20 if (!precvpriv->pallocated_frame_buf) { diff --git a/drivers/staging/r8188eu/include/recv_osdep.h b/drivers/staging= /r8188eu/include/recv_osdep.h index 4c6cf5b1ac76..71fe581fbc85 100644 --- a/drivers/staging/r8188eu/include/recv_osdep.h +++ b/drivers/staging/r8188eu/include/recv_osdep.h @@ -19,7 +19,6 @@ void rtw_handle_tkip_mic_err(struct adapter *padapter, u8= bgroup); int rtw_init_recv_priv(struct recv_priv *precvpriv, struct adapter *padapt= er); void rtw_free_recv_priv(struct recv_priv *precvpriv); =20 -int rtw_os_recv_resource_init(struct recv_priv *recvpr, struct adapter *ad= apt); int rtw_os_recv_resource_alloc(struct adapter *adapt, struct recv_frame *r= ecvfr); =20 int rtw_os_recvbuf_resource_alloc(struct adapter *adapt, struct recv_buf *= buf); diff --git a/drivers/staging/r8188eu/os_dep/recv_linux.c b/drivers/staging/= r8188eu/os_dep/recv_linux.c index 0d3110a4c3d2..da21490fe168 100644 --- a/drivers/staging/r8188eu/os_dep/recv_linux.c +++ b/drivers/staging/r8188eu/os_dep/recv_linux.c @@ -12,13 +12,6 @@ #include "../include/osdep_intf.h" #include "../include/usb_ops.h" =20 -/* init os related resource in struct recv_priv */ -int rtw_os_recv_resource_init(struct recv_priv *precvpriv, - struct adapter *padapter) -{ - return _SUCCESS; -} - /* alloc os related resource in struct recv_frame */ int rtw_os_recv_resource_alloc(struct adapter *padapter, struct recv_frame *precvframe) --=20 2.34.1 From nobody Tue Jun 30 21:19:30 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14BE6C433EF for ; Sat, 8 Jan 2022 08:27:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233908AbiAHI1y (ORCPT ); Sat, 8 Jan 2022 03:27:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233821AbiAHI1s (ORCPT ); Sat, 8 Jan 2022 03:27:48 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1E0BC06173E for ; Sat, 8 Jan 2022 00:27:47 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id h10so5473005wrb.1 for ; Sat, 08 Jan 2022 00:27:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=I7FR9DbSMxpW/4g1B75rGPwrRCKNQS0S40gVywwIMUw=; b=T+sGF/NfDYcaTTi3wgMAYqHpYN6+x4K4I0nVKJRl7yphjDfk1LCdLtX+Iu4of5J+zk MhyyH7jIex1ZhXHx7XyRlR0Z/puuKL1PxUMHWW3q2ywYxEyZSnWbL4v1e/IPSNGgWEtc zlM1vP3AnD3vxpO6vtQNZoO7QbFkrHDNnHzxuwUYH9iq7uetawii7GGKeBnQY4AuIjZf m2WGZjjZgomiYGkclYXB209Bq9aSMq78Or8HvTrvXXuG1S1fzkKZkwlaKWsBnplcAO1/ GNy8L0IJC+6e5GVNZ7WBAHGghreRQFJPM2BVRamMbyNSrnCc8yew2Gz2GGlDW1YUTpV0 XLyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=I7FR9DbSMxpW/4g1B75rGPwrRCKNQS0S40gVywwIMUw=; b=pEblFXUcaePHrRVGuju9HuINcWN5FwwcaZB66wM05MkoYoSpjTMWfHgBYb+uUOmc8+ QM4hKDLGh1DbnqhiCtNH40CaIT/m4y0EP7QPF13o60RZqSL2K6uzeA2ucAM0O7OUu5Zm o8hdh1TJXhwVOhV0jHHtc5uyYI5K/ZFoMLN4L1wQIqAK6aEx9UwwoyWDA3AR7JK6BthM 8Te9X1cLES91Ocph8bNh1jsMQh/2psuOJ2FHaNMvjZo1imD8+WtAYD4UQvSRYUM4qp9t /HFlRjx5KD6TPnCI5ouQdl+2sCCT08sr1z6ziEASALAbMz3PNavnZwlW8fkn4g6fZAbS Hh1Q== X-Gm-Message-State: AOAM532jTJmNcdtj0fPf7yUB1viwld8dJHS9eOmRW/XKlc4mxDNE86mr Mqbwuot08m74WYr+dS14AsI= X-Google-Smtp-Source: ABdhPJykIxcCsSxPcm7p7uNAWAZNkv/dyVHiurYnHLsC2Q63x6Piv4J4GGGSUUTLlzNVPyNniTLgMQ== X-Received: by 2002:a05:6000:16c9:: with SMTP id h9mr1704117wrf.508.1641630466600; Sat, 08 Jan 2022 00:27:46 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::51e2]) by smtp.gmail.com with ESMTPSA id az1sm964536wrb.104.2022.01.08.00.27.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Jan 2022 00:27:46 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 5/5] staging: r8188eu: remove rtw_os_recv_resource_alloc() Date: Sat, 8 Jan 2022 09:27:36 +0100 Message-Id: <20220108082736.16788-6-straube.linux@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220108082736.16788-1-straube.linux@gmail.com> References: <20220108082736.16788-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Merge rtw_os_recv_resource_alloc() into _rtw_init_recv_priv() and remove rtw_os_recv_resource_alloc(). Signed-off-by: Michael Straube --- drivers/staging/r8188eu/core/rtw_recv.c | 3 ++- drivers/staging/r8188eu/include/recv_osdep.h | 2 -- drivers/staging/r8188eu/os_dep/recv_linux.c | 9 --------- 3 files changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_recv.c b/drivers/staging/r818= 8eu/core/rtw_recv.c index 26893f36d1ff..5438a73ba06b 100644 --- a/drivers/staging/r8188eu/core/rtw_recv.c +++ b/drivers/staging/r8188eu/core/rtw_recv.c @@ -70,7 +70,8 @@ int _rtw_init_recv_priv(struct recv_priv *precvpriv, stru= ct adapter *padapter) =20 list_add_tail(&precvframe->list, &precvpriv->free_recv_queue.queue); =20 - res =3D rtw_os_recv_resource_alloc(padapter, precvframe); + precvframe->pkt_newalloc =3D NULL; + precvframe->pkt =3D NULL; =20 precvframe->len =3D 0; =20 diff --git a/drivers/staging/r8188eu/include/recv_osdep.h b/drivers/staging= /r8188eu/include/recv_osdep.h index 71fe581fbc85..ca8a613508fd 100644 --- a/drivers/staging/r8188eu/include/recv_osdep.h +++ b/drivers/staging/r8188eu/include/recv_osdep.h @@ -19,8 +19,6 @@ void rtw_handle_tkip_mic_err(struct adapter *padapter, u8= bgroup); int rtw_init_recv_priv(struct recv_priv *precvpriv, struct adapter *padapt= er); void rtw_free_recv_priv(struct recv_priv *precvpriv); =20 -int rtw_os_recv_resource_alloc(struct adapter *adapt, struct recv_frame *r= ecvfr); - int rtw_os_recvbuf_resource_alloc(struct adapter *adapt, struct recv_buf *= buf); int rtw_os_recvbuf_resource_free(struct adapter *adapt, struct recv_buf *b= uf); =20 diff --git a/drivers/staging/r8188eu/os_dep/recv_linux.c b/drivers/staging/= r8188eu/os_dep/recv_linux.c index da21490fe168..b205c50e9d75 100644 --- a/drivers/staging/r8188eu/os_dep/recv_linux.c +++ b/drivers/staging/r8188eu/os_dep/recv_linux.c @@ -12,15 +12,6 @@ #include "../include/osdep_intf.h" #include "../include/usb_ops.h" =20 -/* alloc os related resource in struct recv_frame */ -int rtw_os_recv_resource_alloc(struct adapter *padapter, - struct recv_frame *precvframe) -{ - precvframe->pkt_newalloc =3D NULL; - precvframe->pkt =3D NULL; - return _SUCCESS; -} - /* alloc os related resource in struct recv_buf */ int rtw_os_recvbuf_resource_alloc(struct adapter *padapter, struct recv_buf *precvbuf) --=20 2.34.1