From nobody Tue Jun 30 23:28:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D2B6C433FE for ; Thu, 6 Jan 2022 18:15:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242649AbiAFSPL (ORCPT ); Thu, 6 Jan 2022 13:15:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242627AbiAFSPI (ORCPT ); Thu, 6 Jan 2022 13:15:08 -0500 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C542C061212; Thu, 6 Jan 2022 10:15:08 -0800 (PST) Received: by mail-pl1-x62c.google.com with SMTP id l15so3025856pls.7; Thu, 06 Jan 2022 10:15:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9aRT+BKtfoUra9B8cP6tf0Fs3h6BVFB+BuyDyjwYyis=; b=Umg7a1l870g0diH/9R9A4xgzQInP7pCMmNMxws7RaWkbkeqIBLknKWpyw1kthFU6s3 1GJNrDSkmI1kxrbt/Y+4ettK5mu56e84+6V9mCf2cmZEt1Kn5wm7rqor9n9IkAGeksHd Y0/HcNp2EkY1YoA3VryJrjgbbriRvjrzpIpkxS2VGInWxz5lijvuxK3tK57nlCay4l6h khwcnI5k2hWNIqd1p+zuWneFmfv4EfkCbmrSyJdwBl4BHbIPMtAEwRdYPIIMaIsD0DdE wdbKI/RriL2uViUiNbIPIVWDHjFDsAL3hQ1lKC4nf7YwdF+e9yepOaiSR3RwwDktr7s3 2A7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9aRT+BKtfoUra9B8cP6tf0Fs3h6BVFB+BuyDyjwYyis=; b=sKYu+nDGl/L58Zfet3yHzmFu+o8919G9EJTWDzlDolqxUwlQl3L1uMSvbMOFFI+ieL 9h6rE5r1W0vpoKgaZlC1E7w/eeUjbIvZz6+4vfdE5ZKNxKondZQNf2p0Uzmo0Q0ZcYOz aj+WCrzXwvIjM9NJWaXzGzy9TzBD3R6XVU5KqiGbNjVyAqb8qtaJd763/ceJJIXIFiaJ as5sDyv2fw6U2p38siCxcd1stuOkV4kLZGm2KSt22CidxpTns2za610bVZiaiQw7+BZN pMTGy4O8EqumrD+8DOf9K3fDe2+bElm2p6Og6Z+VgbZqRXkAgmUZiUEVYorGlVvWJvSb 329g== X-Gm-Message-State: AOAM533IM774JkZJu8fsfxal0pezQlmUNuh+SwIW0wM4ak3OxG8lzSJe 9TzVZD8hxUFfu/d+03LPYT4= X-Google-Smtp-Source: ABdhPJw0rL4+omUtSR47k3TXWKN/FskQ6U50lGHp2Fvucua0WK/BEfsE68Leus4rIk9/IMmCJN+fBQ== X-Received: by 2002:a17:90b:4b0c:: with SMTP id lx12mr11581984pjb.146.1641492908127; Thu, 06 Jan 2022 10:15:08 -0800 (PST) Received: from localhost ([2601:1c0:5200:a6:307:a401:7b76:c6e5]) by smtp.gmail.com with ESMTPSA id i4sm3025524pjj.30.2022.01.06.10.15.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jan 2022 10:15:07 -0800 (PST) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Rob Clark , Rob Clark , Sean Paul , Abhinav Kumar , David Airlie , Daniel Vetter , AngeloGioacchino Del Regno , Jonathan Marek , Jordan Crouse , Akhil P Oommen , Vladimir Lypak , Bjorn Andersson , linux-kernel@vger.kernel.org (open list) Subject: [PATCH 1/2] drm/msm/gpu: Wait for idle before suspending Date: Thu, 6 Jan 2022 10:14:46 -0800 Message-Id: <20220106181449.696988-2-robdclark@gmail.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20220106181449.696988-1-robdclark@gmail.com> References: <20220106181449.696988-1-robdclark@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Rob Clark System suspend uses pm_runtime_force_suspend(), which cheekily bypasses the runpm reference counts. This doesn't actually work so well when the GPU is active. So add a reasonable delay waiting for the GPU to become idle. Alternatively we could just return -EBUSY in this case, but that has the disadvantage of causing system suspend to fail. Signed-off-by: Rob Clark Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/msm/adreno/adreno_device.c | 9 +++++++++ drivers/gpu/drm/msm/msm_gpu.c | 3 +++ drivers/gpu/drm/msm/msm_gpu.h | 3 +++ 3 files changed, 15 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/m= sm/adreno/adreno_device.c index 93005839b5da..b677ca3fd75e 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_device.c +++ b/drivers/gpu/drm/msm/adreno/adreno_device.c @@ -611,6 +611,15 @@ static int adreno_resume(struct device *dev) static int adreno_suspend(struct device *dev) { struct msm_gpu *gpu =3D dev_to_gpu(dev); + int ret =3D 0; + + ret =3D wait_event_timeout(gpu->retire_event, + !msm_gpu_active(gpu), + msecs_to_jiffies(1000)); + if (ret =3D=3D 0) { + dev_err(dev, "Timeout waiting for GPU to suspend\n"); + return -EBUSY; + } =20 return gpu->funcs->pm_suspend(gpu); } diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c index 0f78c2615272..2c1049c0ea14 100644 --- a/drivers/gpu/drm/msm/msm_gpu.c +++ b/drivers/gpu/drm/msm/msm_gpu.c @@ -703,6 +703,8 @@ static void retire_submits(struct msm_gpu *gpu) } } } + + wake_up_all(&gpu->retire_event); } =20 static void retire_worker(struct kthread_work *work) @@ -848,6 +850,7 @@ int msm_gpu_init(struct drm_device *drm, struct platfor= m_device *pdev, INIT_LIST_HEAD(&gpu->active_list); mutex_init(&gpu->active_lock); mutex_init(&gpu->lock); + init_waitqueue_head(&gpu->retire_event); kthread_init_work(&gpu->retire_work, retire_worker); kthread_init_work(&gpu->recover_work, recover_worker); kthread_init_work(&gpu->fault_work, fault_worker); diff --git a/drivers/gpu/drm/msm/msm_gpu.h b/drivers/gpu/drm/msm/msm_gpu.h index 445c6bfd4b6b..92aa1e9196c6 100644 --- a/drivers/gpu/drm/msm/msm_gpu.h +++ b/drivers/gpu/drm/msm/msm_gpu.h @@ -230,6 +230,9 @@ struct msm_gpu { /* work for handling GPU recovery: */ struct kthread_work recover_work; =20 + /** retire_event: notified when submits are retired: */ + wait_queue_head_t retire_event; + /* work for handling active-list retiring: */ struct kthread_work retire_work; =20 --=20 2.33.1 From nobody Tue Jun 30 23:28:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBB18C433F5 for ; Thu, 6 Jan 2022 18:15:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242646AbiAFSPN (ORCPT ); Thu, 6 Jan 2022 13:15:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242633AbiAFSPK (ORCPT ); Thu, 6 Jan 2022 13:15:10 -0500 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F7ABC061245; Thu, 6 Jan 2022 10:15:10 -0800 (PST) Received: by mail-pg1-x535.google.com with SMTP id t32so3284403pgm.7; Thu, 06 Jan 2022 10:15:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NpENl1wlwqcfbBT73rctGeiDbGEPDlZ8miqyZA+HW/A=; b=F09yhVw/miHkBPbi4ZUlYr4v+8jysbgt9gi1ewGjNnREmk2R3F7tVzYoSF1tvXfNWH unH8PPBeS0TlZp1ZTjWad/PIvqEPdCPWEcvhtXCGPZOzzqwfVq6OXC+LJa1xWijbJPqz rwunzxgZsmSP7FEWW9+2s4ldMauj+40newsjGyEzwiHXWbbFYVBBcTBlyI4d5W88lA6D O/cIXoglEpASRbpBcm4M6576cHGNv7JcqSXq/WwRYI8n1nEXxwXa/2cFUxB0AHSDKHkj 8OQIf89HIKCwH+u34JrNSIRCUv+m+DNeFxN2/N4xh6yOSUMzPK1uCcV3EnM+uD35I59y b+pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NpENl1wlwqcfbBT73rctGeiDbGEPDlZ8miqyZA+HW/A=; b=0UKw8ToX1P4EUmdfDD5mf4TZvX5uM5h8UXp+PhnTHHyjg0NeljCUQjtTSJJk/etthM PxoBTQU9d6pwcZdqcNqniIiBAHTBFcut5/RWQAtoq2PXsLPDnjar9YKI9Ug4d4viz0ST 0a0jRcYxaM5S7i7mkbeTcMMmGlKtMQEyjbeyC3a5c7WqxcH6PKd3W0UCj5XdNsUrwHxE /d/17ucKM4Y4SOrAFoltqbu1rnaQiMh5YtUry2JugDbik4Lx8nh+yeMWDuvrKuV8m+LU w9IgCjnncaLcX3YeJ8TFF9EAkNyo2g8bQ+OprnYBid9X+6s3AIQOvWg3lRfPO5qNt2Fy hJQA== X-Gm-Message-State: AOAM533V6oR3oER6QbL4bptrScLqrfmvdLfwT34JrITA8mWmYWHa5VOX E0vGcefv5zVocgdXvXAQZus= X-Google-Smtp-Source: ABdhPJwv7sVVNoZY8rfrc22AsxIsf7vwBPn1hePxXkzE5xqw9FRXjuAwrmj4inJU3E0t7U24/NgRsA== X-Received: by 2002:a65:4c81:: with SMTP id m1mr54128291pgt.427.1641492910079; Thu, 06 Jan 2022 10:15:10 -0800 (PST) Received: from localhost ([2601:1c0:5200:a6:307:a401:7b76:c6e5]) by smtp.gmail.com with ESMTPSA id c11sm3359333pfv.85.2022.01.06.10.15.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jan 2022 10:15:09 -0800 (PST) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Rob Clark , Rob Clark , Sean Paul , Abhinav Kumar , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH 2/2] drm/msm/gpu: Cancel idle/boost work on suspend Date: Thu, 6 Jan 2022 10:14:47 -0800 Message-Id: <20220106181449.696988-3-robdclark@gmail.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20220106181449.696988-1-robdclark@gmail.com> References: <20220106181449.696988-1-robdclark@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Rob Clark With system suspend using pm_runtime_force_suspend() we can't rely on the pm_runtime_get_if_in_use() trick to deal with devfreq callbacks after (or racing with) suspend. So flush any pending idle or boost work in the suspend path. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gpu_devfreq.c | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gpu_devfreq.c b/drivers/gpu/drm/msm/ms= m_gpu_devfreq.c index 62405e980925..9bf319be11f6 100644 --- a/drivers/gpu/drm/msm/msm_gpu_devfreq.c +++ b/drivers/gpu/drm/msm/msm_gpu_devfreq.c @@ -133,6 +133,18 @@ void msm_devfreq_init(struct msm_gpu *gpu) CLOCK_MONOTONIC, HRTIMER_MODE_REL); } =20 +static void cancel_idle_work(struct msm_gpu_devfreq *df) +{ + hrtimer_cancel(&df->idle_work.timer); + kthread_cancel_work_sync(&df->idle_work.work); +} + +static void cancel_boost_work(struct msm_gpu_devfreq *df) +{ + hrtimer_cancel(&df->boost_work.timer); + kthread_cancel_work_sync(&df->boost_work.work); +} + void msm_devfreq_cleanup(struct msm_gpu *gpu) { struct msm_gpu_devfreq *df =3D &gpu->devfreq; @@ -152,7 +164,12 @@ void msm_devfreq_resume(struct msm_gpu *gpu) =20 void msm_devfreq_suspend(struct msm_gpu *gpu) { - devfreq_suspend_device(gpu->devfreq.devfreq); + struct msm_gpu_devfreq *df =3D &gpu->devfreq; + + devfreq_suspend_device(df->devfreq); + + cancel_idle_work(df); + cancel_boost_work(df); } =20 static void msm_devfreq_boost_work(struct kthread_work *work) @@ -196,7 +213,7 @@ void msm_devfreq_active(struct msm_gpu *gpu) /* * Cancel any pending transition to idle frequency: */ - hrtimer_cancel(&df->idle_work.timer); + cancel_idle_work(df); =20 idle_time =3D ktime_to_ms(ktime_sub(ktime_get(), df->idle_time)); =20 --=20 2.33.1