From nobody Thu Jul 2 06:38:35 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0192C433EF for ; Sat, 1 Jan 2022 08:49:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231434AbiAAItz (ORCPT ); Sat, 1 Jan 2022 03:49:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229723AbiAAItv (ORCPT ); Sat, 1 Jan 2022 03:49:51 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 304B4C06173E for ; Sat, 1 Jan 2022 00:49:51 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id i22so59660160wrb.13 for ; Sat, 01 Jan 2022 00:49:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YbTLV5Bfca2xgmvPMQbusqJj771BWIhHOlR3Rbqv4og=; b=HxVL6urLyJ013tVQPhN0jkvV/1Z+cCKHsb2VhwP1lPo23HHH2mVEqwA4PivmGlUrrZ eaDycPhQJjn6lv8qfnm5EEAHXoTyqq2YfuoU63Q38e0yTJdWhWztx3rInDIK2ZDnkZrF Iy1d4ZBX9BBbz1O+MvU0+J+5B0lXyRGD5mD/5boEN4BAvuKrYNNFUbsZUZab/mKjOK2e Z/qy3hbT9zGNz7ZyZ2Qo381xxeSZMVxHy6rM2rfxKy8BndSjin2zI7JJBBveJljXi7Ju irdMO9KnGgai3R89XhIIs80SGlHJQSOk0yl/7WBLEvlMgpPQUKz6z3yYvtex+4Nj0QEb 5CLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YbTLV5Bfca2xgmvPMQbusqJj771BWIhHOlR3Rbqv4og=; b=1zycWhK/1TSt5bTJT+suN+JEv8sby8pwRRhzGTGmhy/ni1DkQFZuho7Wpol01cAkfR Sw+YBEygqJbfPM4cPd9SgFk+PpZleFDnfhw0VN65KYkP3Km5DwXy34rSzffSw4cnI4N/ iJDbciXMMT6l3NPHzaiQsQC9qKoUp+65/6K9F43bPAG+rDYgTpwETkaJr3wot3nncESV v9IfYEaSVEqkK0hUIGjjwt+2jK0hTvC7PGxmohYaWO/jtOJ+O+NCtBS48z5H+9t0K4rv MWHifNIGbsYC/OlCZtxzotXKpZNlPDNny6wRXDiqH6KDwqvG2c/0Z06Epbw+8WWW+bhc WIBQ== X-Gm-Message-State: AOAM533l2rdrquH1RrkCdNM7d+LFk3r3U9Q2268RR3Bah8kmLxZmFMqF bMaIcdHQj9q+Nz8h+3un1v0= X-Google-Smtp-Source: ABdhPJxbpw+qEbVexHxloGMc0GmrBwUKsBQZc/ZK+EEzC45glDJqFE52JOQhyEip1qCasDmMq1+IfQ== X-Received: by 2002:a05:6000:181b:: with SMTP id m27mr30601277wrh.43.1641026989807; Sat, 01 Jan 2022 00:49:49 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::d7e8]) by smtp.gmail.com with ESMTPSA id o9sm14806578wri.97.2022.01.01.00.49.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jan 2022 00:49:49 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH v3 1/7] staging: r8188eu: bRDGEnable is always false Date: Sat, 1 Jan 2022 09:49:31 +0100 Message-Id: <20220101084937.3411-2-straube.linux@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220101084937.3411-1-straube.linux@gmail.com> References: <20220101084937.3411-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The field bRDGEnable in struct hal_data_8188e is never set. It stays at its default value 0. Remove bRDGEnable and related dead code. Signed-off-by: Michael Straube Acked-by: Martin Kaiser --- v3: no changes v2: no changes drivers/staging/r8188eu/hal/usb_halinit.c | 10 ---------- drivers/staging/r8188eu/include/rtl8188e_hal.h | 3 --- 2 files changed, 13 deletions(-) diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8= 188eu/hal/usb_halinit.c index d5c7e8bf1f38..104705ef170e 100644 --- a/drivers/staging/r8188eu/hal/usb_halinit.c +++ b/drivers/staging/r8188eu/hal/usb_halinit.c @@ -384,13 +384,6 @@ static void _InitEDCA(struct adapter *Adapter) rtw_write32(Adapter, REG_EDCA_VO_PARAM, 0x002FA226); } =20 -static void _InitRDGSetting(struct adapter *Adapter) -{ - rtw_write8(Adapter, REG_RD_CTRL, 0xFF); - rtw_write16(Adapter, REG_RD_NAV_NXT, 0x200); - rtw_write8(Adapter, REG_RD_RESP_PKT_TH, 0x05); -} - static void _InitRetryFunction(struct adapter *Adapter) { u8 value8; @@ -712,9 +705,6 @@ u32 rtl8188eu_hal_init(struct adapter *Adapter) value16 |=3D (MACTXEN | MACRXEN); rtw_write8(Adapter, REG_CR, value16); =20 - if (haldata->bRDGEnable) - _InitRDGSetting(Adapter); - /* Enable TX Report */ /* Enable Tx Report Timer */ value8 =3D rtw_read8(Adapter, REG_TX_RPT_CTRL); diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/stagi= ng/r8188eu/include/rtl8188e_hal.h index b42af86555cd..e8cb093abb62 100644 --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h @@ -236,9 +236,6 @@ struct hal_data_8188e { =20 u32 RfRegChnlVal[2]; =20 - /* RDG enable */ - bool bRDGEnable; - /* for host message to fw */ u8 LastHMEBoxNum; =20 --=20 2.34.1 From nobody Thu Jul 2 06:38:35 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9969C433F5 for ; Sat, 1 Jan 2022 08:50:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231422AbiAAIt5 (ORCPT ); Sat, 1 Jan 2022 03:49:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230374AbiAAItw (ORCPT ); Sat, 1 Jan 2022 03:49:52 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFDC3C061574 for ; Sat, 1 Jan 2022 00:49:51 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id j18so59723993wrd.2 for ; Sat, 01 Jan 2022 00:49:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=W9/q/NrnqBEqANyC37JD6gUeY78R63lo51Y9u+z8PxE=; b=OXz9HIVqaHeShNoGYKUneSqpMx0Fc1iwbb69AUIMtTNKLVpWOLT6KpioyVruyaBfP5 oANCad/nPO3BPx5qIbKKJ4wgajhOVqdayrWLtgnaN2nCg+4BA3oToLAKPLFq16RmlarF UyEYWtss0eMJ31q8E6Drivzy8jzLnkM7SOL5vkZhz9fj6VeGhdlw8yurhEiX7qYyGL1o gAjY9S0uYNXr0gimMbXwVjsPLfh/TbYNn14KQUXx8bXuU0CSwU58qGO4ZBFk52pFYp7U rbNxwT+6rDv+x1bp7JJXzLveJjwZ5Wq/pKv4rD88QwKcDCLFTWOckU32ktx1VllJClZC PIag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=W9/q/NrnqBEqANyC37JD6gUeY78R63lo51Y9u+z8PxE=; b=SI6kczwE4Vl/9ArznAjcloo3x3SMNs01tK8bExcvr1BWsgrwgU6O+HtKkmXMuTvp5l 6CG43DCXR3O+m8VdG4L0ZtGCehAYAF++OckrkOCIUIKk9uPnfVuXbUtv9QDYfOz/pvPY O58wYHx4pPLeGSRKO8UYR1fSR1bBE729pU57rywhGKNqbK6RFFR5WHpL7PGffsHUYDGT kHBXX77zTQhmjj6izvzZ5wAfZLNAfAzLU8UUM7WnrzkhDW3bgUU4Ve1LApWmrzZaLwdF yhE87GZcU1Ienx+BxlHKgqHHggrIKS33d4yCNNS038ZFKrwDs+cnUS1MxlaJk+O44pjI B9sQ== X-Gm-Message-State: AOAM532Aa48TAOl5qyO0h6+5Cm4/XCKKdxwHKnW3rUd1GDJxBX5iSy9C 8loEBS8z7cR69ZKI9nOgFu4= X-Google-Smtp-Source: ABdhPJxPfVYNrz8QGNcH358gEHOu4NYNmhqY0/4FG8C9nVPLTfRjpkh1wHkaQrWyL6HYZ1eZZbk8Sw== X-Received: by 2002:adf:f70b:: with SMTP id r11mr32894435wrp.496.1641026990486; Sat, 01 Jan 2022 00:49:50 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::d7e8]) by smtp.gmail.com with ESMTPSA id o9sm14806578wri.97.2022.01.01.00.49.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jan 2022 00:49:50 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH v3 2/7] staging: r8188eu: UsbRxHighSpeedMode is set but never used Date: Sat, 1 Jan 2022 09:49:32 +0100 Message-Id: <20220101084937.3411-3-straube.linux@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220101084937.3411-1-straube.linux@gmail.com> References: <20220101084937.3411-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The field UsbRxHighSpeedMode of struct hal_data_8188e is set but never used. Remove it. Signed-off-by: Michael Straube Acked-by: Martin Kaiser --- v3: no changes v2: no changes drivers/staging/r8188eu/hal/usb_halinit.c | 5 ----- drivers/staging/r8188eu/include/rtl8188e_hal.h | 3 --- 2 files changed, 8 deletions(-) diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8= 188eu/hal/usb_halinit.c index 104705ef170e..96db9a8e7667 100644 --- a/drivers/staging/r8188eu/hal/usb_halinit.c +++ b/drivers/staging/r8188eu/hal/usb_halinit.c @@ -502,16 +502,11 @@ usb_AggSettingRxUpdate( =20 static void InitUsbAggregationSetting(struct adapter *Adapter) { - struct hal_data_8188e *haldata =3D &Adapter->haldata; - /* Tx aggregation setting */ usb_AggSettingTxUpdate(Adapter); =20 /* Rx aggregation setting */ usb_AggSettingRxUpdate(Adapter); - - /* 201/12/10 MH Add for USB agg mode dynamic switch. */ - haldata->UsbRxHighSpeedMode =3D false; } =20 static void _InitOperationMode(struct adapter *Adapter) diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/stagi= ng/r8188eu/include/rtl8188e_hal.h index e8cb093abb62..8b54f52f49e2 100644 --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h @@ -262,9 +262,6 @@ struct hal_data_8188e { u8 OutEpQueueSel; u8 OutEpNumber; =20 - /* Add for USB aggreation mode dynamic shceme. */ - bool UsbRxHighSpeedMode; - /* 2010/11/22 MH Add for slim combo debug mode selective. */ /* This is used for fix the drawback of CU TSMC-A/UMC-A cut. * HW auto suspend ability. Close BT clock. */ --=20 2.34.1 From nobody Thu Jul 2 06:38:35 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 053C5C433FE for ; Sat, 1 Jan 2022 08:50:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231979AbiAAIt6 (ORCPT ); Sat, 1 Jan 2022 03:49:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231237AbiAAItx (ORCPT ); Sat, 1 Jan 2022 03:49:53 -0500 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1C68C06173E for ; Sat, 1 Jan 2022 00:49:52 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id b73so18482503wmd.0 for ; Sat, 01 Jan 2022 00:49:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zNnyQKUNwC5X0HyOtAQZAQEeFLjT4A8KEQdLN65zWrc=; b=dJbOB/ZC4h3BRk/xTb5EgV5IengAUTb/1w1gKwajQF5bq860aSOeBq6DXINXKoxMuN YsPr79vrXi6u+R91TmV+DHfzyPVAmV3TfLJk9fTWg2BCuTQtiBO0gGA+Vstw9dy7kKh6 mPX6L6ThyQPYdX+m9t9MTtWCgQvpy9vHZ2hplIX2yhjXQCOjq7hHwiAEaLLGQdO18n4b iuw5nQWzfuGV16r/mtGLKFUN0WRxr+iu+o8IUFtOKqmRt6Vg1wzFAambz84MfcMnJHmI B0acv3wZiPU8MUN40DlZmHvm6xjMef05TUoUp/WuQaZ4VLVIWa+rIMFpZS19//TVkrXu nKtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zNnyQKUNwC5X0HyOtAQZAQEeFLjT4A8KEQdLN65zWrc=; b=M/illE+pLaafm60TgT0n6LDd+45HdUBk23XptTwPpfNPlh54ZpDvhwmQlHvY1LDqTr 2ILXj1rKhJR4upAG4HpK77oXCaAcUKeTbV+k2c+0OrWykoq/Zcz0RYxdG3sLYhXoa80G bgX/Z/Hg6TBrknxnKfoIGEntxZ6/YgpVkCb1sZ8aVThc5/1sVB5BU7wEFsIl3SaSVgcb Q2dPMZi66WAehIdF0yu/XXkXdyiCGhj3u9Jfn+SQjMsBBWwOyiqihZm3SSl4BrOJQb+J YmQHLxtUzPEarh3F+KSej1hUu/d0wnF6HzpStCNyL4k4r9zwHd1IREDrZ7SUv/lE+myb o3+g== X-Gm-Message-State: AOAM5335ATexeL2AyyZ4WCki9CNLiIw3cTC2zXJq40eqviadZao2PNqp THo40A4Qrtwd2xfv5yTQXMU= X-Google-Smtp-Source: ABdhPJxcKD1CJDT8eJEBvC4dNChBFf8X3jKspSH8k1vrT9OcQ0ydahtVGVqcYdY3i4PO2Ty1/wtQJw== X-Received: by 2002:a1c:9dc7:: with SMTP id g190mr32885211wme.56.1641026991187; Sat, 01 Jan 2022 00:49:51 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::d7e8]) by smtp.gmail.com with ESMTPSA id o9sm14806578wri.97.2022.01.01.00.49.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jan 2022 00:49:50 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH v3 3/7] staging: r8188eu: bTXPowerDataReadFromEEPORM is set but never used Date: Sat, 1 Jan 2022 09:49:33 +0100 Message-Id: <20220101084937.3411-4-straube.linux@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220101084937.3411-1-straube.linux@gmail.com> References: <20220101084937.3411-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The field bTXPowerDataReadFromEEPORM of struct hal_data_8188e is set but never used. Remove it. Signed-off-by: Michael Straube --- v3: no changes v2: no changes drivers/staging/r8188eu/hal/rtl8188e_hal_init.c | 3 --- drivers/staging/r8188eu/include/rtl8188e_hal.h | 1 - 2 files changed, 4 deletions(-) diff --git a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c b/drivers/stag= ing/r8188eu/hal/rtl8188e_hal_init.c index d8d6547465a7..065c2701077d 100644 --- a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c +++ b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c @@ -1127,9 +1127,6 @@ void Hal_ReadTxPowerInfo88E(struct adapter *padapter,= u8 *PROMContent, bool Auto =20 Hal_ReadPowerValueFromPROM_8188E(&pwrInfo24G, PROMContent, AutoLoadFail); =20 - if (!AutoLoadFail) - pHalData->bTXPowerDataReadFromEEPORM =3D true; - for (ch =3D 0; ch < CHANNEL_MAX_NUMBER; ch++) { hal_get_chnl_group_88e(ch, &group); =20 diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/stagi= ng/r8188eu/include/rtl8188e_hal.h index 8b54f52f49e2..de58c85b8bdc 100644 --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h @@ -180,7 +180,6 @@ struct hal_data_8188e { u16 EEPROMSDID; u8 EEPROMRegulatory; =20 - u8 bTXPowerDataReadFromEEPORM; u8 EEPROMThermalMeter; u8 bAPKThermalMeterIgnore; =20 --=20 2.34.1 From nobody Thu Jul 2 06:38:35 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16855C433EF for ; Sat, 1 Jan 2022 08:50:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232167AbiAAIuA (ORCPT ); Sat, 1 Jan 2022 03:50:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231348AbiAAItx (ORCPT ); Sat, 1 Jan 2022 03:49:53 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49517C061574 for ; Sat, 1 Jan 2022 00:49:53 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id w20so50706788wra.9 for ; Sat, 01 Jan 2022 00:49:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EOX3rSpe6Y+YD+edQeghlR9ENccpSM4hKY7ygLNTvjg=; b=N12nV/uvkUwL6yl4VCIwJqCSf8U2Gd+XH6dZjuLVSrU3SHtbDtBye59f7WkjX6uMyO jiyAD3QftB+Y5ybnW/Vl56gUuzQLr1O5TFIBnGEewuzu4t5XpKBc/bX+kdppK033S4J5 +BeD5SUkSMe4LyqToCd+O0w998RbIkwhmE05p9zbHts62TZOhPW5PILF0aGmtfpSJ4+O fvjXxWEL5ygVepyNsNSEQyOJza0WkJmyonDs7M/SKlB3p9NPZUgtiDfejr6eZyGldoZY QJkAISqYVAZs7lNKAKfPcuMGzNWtHw5dTPxVuKUmSGf3iqiZMAhrJAA2TP+fIc3QvVUz NbBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EOX3rSpe6Y+YD+edQeghlR9ENccpSM4hKY7ygLNTvjg=; b=T38REf0pyLu3hPKWc6mR1Noh03pIBLQI0fTTAeQ1xR0gFIazWIa+rAiAa/Uaazbgmd dvIlq0Vtq9RDf1/qGN9wHribXA/feD6UIgDgc071sJslc/5cm4N+E95XqORN3D/u8e16 z0BTFqrHsDbFR6i3LEf0W7tWgFLWwwtzCIiw04l/HaNIt33Rj2yH2o43Uc0U+m/jnLzq 13GgWa0Murx3zNyzuA/pw4/nOS96fLZRX6A4u6BW4QC+I8xWbhPazq7l7hODMHI7AQX6 1iDEC8QthmRZHsPQW8Ylus5ckGEtEOeQlnv6nDudo7WanV4d6aOoYKFG1EhL5UetkKGU +TKw== X-Gm-Message-State: AOAM533Tc3+SoYGCodt75OYPcmMn2YTCf1juWYaQN//JdJzkfmbBYc40 Z/1jYkgf8aQI2bPBwKViqnU= X-Google-Smtp-Source: ABdhPJy79/0Fud68RuyOC3koTrXTUAQogNlzNd86dYMW5O2Clu/GBhLkKOs172Lc+YDSIg4C0+uEiw== X-Received: by 2002:adf:e3cf:: with SMTP id k15mr31541256wrm.30.1641026991913; Sat, 01 Jan 2022 00:49:51 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::d7e8]) by smtp.gmail.com with ESMTPSA id o9sm14806578wri.97.2022.01.01.00.49.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jan 2022 00:49:51 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH v3 4/7] staging: r8188eu: bAPKThermalMeterIgnore is set but never used Date: Sat, 1 Jan 2022 09:49:34 +0100 Message-Id: <20220101084937.3411-5-straube.linux@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220101084937.3411-1-straube.linux@gmail.com> References: <20220101084937.3411-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The field bAPKThermalMeterIgnore of struct hal_data_8188e is set but never used. Remove it. Signed-off-by: Michael Straube --- v3: no changes v2: no changes drivers/staging/r8188eu/hal/rtl8188e_hal_init.c | 5 ++--- drivers/staging/r8188eu/include/rtl8188e_hal.h | 1 - 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c b/drivers/stag= ing/r8188eu/hal/rtl8188e_hal_init.c index 065c2701077d..cce291ca44b1 100644 --- a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c +++ b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c @@ -1230,9 +1230,8 @@ void Hal_ReadThermalMeter_88E(struct adapter *Adapter= , u8 *PROMContent, bool Aut else pHalData->EEPROMThermalMeter =3D EEPROM_Default_ThermalMeter_88E; =20 - if (pHalData->EEPROMThermalMeter =3D=3D 0xff || AutoloadFail) { - pHalData->bAPKThermalMeterIgnore =3D true; + if (pHalData->EEPROMThermalMeter =3D=3D 0xff || AutoloadFail) pHalData->EEPROMThermalMeter =3D EEPROM_Default_ThermalMeter_88E; - } + DBG_88E("ThermalMeter =3D 0x%x\n", pHalData->EEPROMThermalMeter); } diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/stagi= ng/r8188eu/include/rtl8188e_hal.h index de58c85b8bdc..40b3db34b8f2 100644 --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h @@ -181,7 +181,6 @@ struct hal_data_8188e { u8 EEPROMRegulatory; =20 u8 EEPROMThermalMeter; - u8 bAPKThermalMeterIgnore; =20 bool EepromOrEfuse; =20 --=20 2.34.1 From nobody Thu Jul 2 06:38:35 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 295F5C4332F for ; Sat, 1 Jan 2022 08:50:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231910AbiAAIuB (ORCPT ); Sat, 1 Jan 2022 03:50:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231376AbiAAIty (ORCPT ); Sat, 1 Jan 2022 03:49:54 -0500 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18930C061574 for ; Sat, 1 Jan 2022 00:49:54 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id j140-20020a1c2392000000b003399ae48f58so18439295wmj.5 for ; Sat, 01 Jan 2022 00:49:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HHVibVWE/yDmiBE8e+vitsiVmxezuf1X83uSBOKODFw=; b=HgsbZsxUAngSCCMei13JY5OOAIaagdjYTTwtvI+j8SKsq0hY1nQHaP3hce4M76FTim 5yhgrF69gXWp/KBjGzhD8OGrOljpM2mYC9a2PEnxn8iHzA1lxdYUI26Dh85LOtA6xnuG KcrUyadvbHKN9elXfDYaJbuFG4f/9Xac6lOnInjdES4DkECSBdbHNCA+KmXPdDpf8sVB wUi6C5Bf+KDb45C6I3atI0lPU3kCMBQjbcQQoEVp2u2ozlu+M7Is9OMaXM2Yf16V02LL cwahfNTY6lIp4YnuJHv37Rck11yUz9MiQUpcLo2Ci4NWgyPt1v7cgY0CVo86yCyC8k7l Dvjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HHVibVWE/yDmiBE8e+vitsiVmxezuf1X83uSBOKODFw=; b=vTt8Vs/riuRet0UlP3wiR7MruuOmbdJ1ML+2U5kKGCX1bQh9lQuUO+VQBAyAI75/QN HvqpCacvESnrH4INJwtTdBnDHjfvOJbmTL+6bIFEBVtkIHt5nqL9ES1qDDEWomwl0r1Y 3rP6fJBWQe8fhURWs9cPxQwzqNvX6uwkP61/ZccoHvZQ8B+u4jO7NWUHNYvYEogqicGJ ctXvdCY95ZqzkYbIkLQIOSwXbCqpAiZmLLf212B2yTbGiBIK+frX+F9k/LksrxIQ4l7D ia9FeIlg3BWMgln+Y7DSm/icwcrJ4EBwNy0fumISFX7ITOSuI7bpTts7+PJmpY9557du w5WA== X-Gm-Message-State: AOAM532NO24H2XShRBcrroZ338qORUK9DK4hQKy7AJAjTgD8kj67Qtth 28Hnklie3CaZGKPkIS5El+Q= X-Google-Smtp-Source: ABdhPJy05KflULe1bFJtZFKWG17km6xBPUaU798jaUe82nRpbd5vK6lqUxYTSygMXk6PUFQB+lUXAg== X-Received: by 2002:a05:600c:1549:: with SMTP id f9mr31868310wmg.112.1641026992630; Sat, 01 Jan 2022 00:49:52 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::d7e8]) by smtp.gmail.com with ESMTPSA id o9sm14806578wri.97.2022.01.01.00.49.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jan 2022 00:49:52 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH v3 5/7] staging: r8188eu: remove unused fields from struct hal_data_8188e Date: Sat, 1 Jan 2022 09:49:35 +0100 Message-Id: <20220101084937.3411-6-straube.linux@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220101084937.3411-1-straube.linux@gmail.com> References: <20220101084937.3411-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove unused fields from struct hal_data_8188e. Signed-off-by: Michael Straube --- v3: no changes v2: no changes .../staging/r8188eu/include/rtl8188e_hal.h | 30 ------------------- 1 file changed, 30 deletions(-) diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/stagi= ng/r8188eu/include/rtl8188e_hal.h index 40b3db34b8f2..2ce42d647a34 100644 --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h @@ -175,15 +175,9 @@ struct hal_data_8188e { =20 u16 BasicRateSet; =20 - /* EEPROM setting. */ - u16 EEPROMSVID; - u16 EEPROMSDID; u8 EEPROMRegulatory; - u8 EEPROMThermalMeter; =20 - bool EepromOrEfuse; - u8 Index24G_CCK_Base[RF_PATH_MAX][CHANNEL_MAX_NUMBER]; u8 Index24G_BW40_Base[RF_PATH_MAX][CHANNEL_MAX_NUMBER]; /* If only one tx, only BW20 and OFDM are used. */ @@ -192,11 +186,6 @@ struct hal_data_8188e { s8 BW20_24G_Diff[RF_PATH_MAX][MAX_TX_COUNT]; s8 BW40_24G_Diff[RF_PATH_MAX][MAX_TX_COUNT]; =20 - u8 TxPwrLevelCck[RF_PATH_MAX][CHANNEL_MAX_NUMBER]; - /* For HT 40MHZ pwr */ - u8 TxPwrLevelHT40_1S[RF_PATH_MAX][CHANNEL_MAX_NUMBER]; - /* For HT 40MHZ pwr */ - u8 TxPwrLevelHT40_2S[RF_PATH_MAX][CHANNEL_MAX_NUMBER]; /* HT 20<->40 Pwr diff */ u8 TxPwrHt20Diff[RF_PATH_MAX][CHANNEL_MAX_NUMBER]; /* For HT<->legacy pwr diff */ @@ -205,7 +194,6 @@ struct hal_data_8188e { u8 PwrGroupHT20[RF_PATH_MAX][CHANNEL_MAX_NUMBER]; u8 PwrGroupHT40[RF_PATH_MAX][CHANNEL_MAX_NUMBER]; =20 - u8 LegacyHTTxPowerDiff;/* Legacy to HT rate power diff */ /* The current Tx Power Level */ u8 CurrentCckTxPwrIdx; u8 CurrentOfdm24GTxPwrIdx; @@ -213,21 +201,12 @@ struct hal_data_8188e { u8 CurrentBW4024GTxPwrIdx; =20 /* Read/write are allow for following hardware information variables */ - u8 framesync; - u32 framesyncC34; - u8 framesyncMonitor; - u8 DefaultInitialGain[4]; u8 pwrGroupCnt; u32 MCSTxPowerLevelOriginalOffset[MAX_PG_GROUP][16]; - u32 CCKTxPowerLevelOriginalOffset; =20 u8 CrystalCap; - u32 AntennaTxPath; /* Antenna path Tx */ - u32 AntennaRxPath; /* Antenna path Rx */ u8 ExternalPA; =20 - u8 b1x1RecvCombine; /* for 1T1R receive combining */ - u32 AcParam_BE; /* Original parameter for BE, use for EDCA turbo. */ =20 struct bb_reg_def PHYRegDef[2]; /* Radio A/B */ @@ -254,17 +233,9 @@ struct hal_data_8188e { u8 FwRsvdPageStartOffset; /* Reserve page start offset except * beacon in TxQ. */ =20 - /* 2010/08/09 MH Add CU power down mode. */ - bool pwrdown; - u8 OutEpQueueSel; u8 OutEpNumber; =20 - /* 2010/11/22 MH Add for slim combo debug mode selective. */ - /* This is used for fix the drawback of CU TSMC-A/UMC-A cut. - * HW auto suspend ability. Close BT clock. */ - bool SlimComboDbg; - u16 EfuseUsedBytes; =20 struct P2P_PS_Offload_t p2p_ps_offload; @@ -280,7 +251,6 @@ struct hal_data_8188e { u8 C2hArray[16]; u8 UsbTxAggMode; u8 UsbTxAggDescNum; - u32 MaxUsbRxAggBlock; =20 enum usb_rx_agg_mode UsbRxAggMode; u8 UsbRxAggBlockCount; /* USB Block count. Block size is --=20 2.34.1 From nobody Thu Jul 2 06:38:35 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38477C43219 for ; Sat, 1 Jan 2022 08:50:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232212AbiAAIuE (ORCPT ); Sat, 1 Jan 2022 03:50:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231408AbiAAItz (ORCPT ); Sat, 1 Jan 2022 03:49:55 -0500 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5A76C06173E for ; Sat, 1 Jan 2022 00:49:54 -0800 (PST) Received: by mail-wr1-x42b.google.com with SMTP id j18so59724140wrd.2 for ; Sat, 01 Jan 2022 00:49:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fZkQCyjgnnx4rx3Sb/nBNm6G3aX374d2a0MfjOD+6ec=; b=Sybhx02EkBFbvZOR3XR5V2eT+cdFzcRaUqYw4aW0s6oikiiYIDJBpNTyJc/X0mHMNc qk8dlNvt7sjpYmSi/MlwhVdSZlsTRRGRi+2ZEyv4lRBZau4I2hYnjR9rAaFm4GMG0amC xsqIcp8jglMNFKxCM9noHJyIX2mF+YSt/2P8YZG7ALUc1B+F+JLx7rXDQFJFpRiGG9bB nkHwJ4g6hAfqoZgqkV/OZ68pIht3lQT6BmtaR+VNRtfeg61i3HZenrO7gjOV3G2QXc9S KVIceQhf+8EG7bVwbAwClD9yVFchjY3G+oXsJsxD7QKxLDNKnMndtyOr8dmJdsSwEIYO lFeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fZkQCyjgnnx4rx3Sb/nBNm6G3aX374d2a0MfjOD+6ec=; b=NtFAfe0M/Wu38xVYE+Dy63l664yvD/LptOrfJSby5aae6xIhDxput/AJ1Rp+34AVZz 3kkf55bMG4/KSYwny1awGyyEhwaeEM0PCBn9VXDGGnZPVkkbnn+fsqxXCYT/ME0daWXi rVKrurMu4db8wlGRYwzBozoubF12maLm0Wcj2IciP+THKXY+mNXbuQobInYCbuwe+8Yy c64cyNRZXbVX1uWUyx9EnfCF/oQsfUrqIXiQ0lq6odhx8TNu/PLyi0CGrrYFTueMK58O fVcajqZQDbsi07nZiKtDFwnE4lUJ4y2zuYbGB1nDM6TePmHIfw6wc+NAl0Gj2SSat6+G 29nA== X-Gm-Message-State: AOAM530oCtLK3Sx2aAK8R7ySujNPYjyfRtkOnf3J5TvHfp6eFmxLpV6E FRbblILyWlal8bpUH8RYn1wBJzSGRqs= X-Google-Smtp-Source: ABdhPJx6zSe6Kh9Z4dazVFhy3Kj6LxmnoOjYto7ujNy1nScVms71ewUF0u2PqvlfVUBhutz2wg3aMg== X-Received: by 2002:adf:fbcf:: with SMTP id d15mr20265320wrs.132.1641026993306; Sat, 01 Jan 2022 00:49:53 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::d7e8]) by smtp.gmail.com with ESMTPSA id o9sm14806578wri.97.2022.01.01.00.49.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jan 2022 00:49:53 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH v3 6/7] staging: r8188eu: IntArray and C2hArray are set but never used Date: Sat, 1 Jan 2022 09:49:36 +0100 Message-Id: <20220101084937.3411-7-straube.linux@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220101084937.3411-1-straube.linux@gmail.com> References: <20220101084937.3411-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The fields IntArray and C2hArray of struct hal_data_8188e are set but never used. Remove them and remove interrupt_handler_8188eu() since it does nothing now. While at it, remove the unsed defines USB_INTR_CONTENT_CPWM1_OFFSET and USB_INTR_CONTENT_CPWM2_OFFSET as well. Signed-off-by: Michael Straube --- v3: Remove INTERRUPT_MSG_FORMAT_LEN from rtl8188e_recv.h. v2: Remove interrupt_handler_8188eu() since it does nothing now. drivers/staging/r8188eu/hal/usb_ops_linux.c | 20 ------------------- .../staging/r8188eu/include/rtl8188e_hal.h | 3 --- .../staging/r8188eu/include/rtl8188e_recv.h | 1 - .../staging/r8188eu/include/rtl8188e_spec.h | 7 ------- 4 files changed, 31 deletions(-) diff --git a/drivers/staging/r8188eu/hal/usb_ops_linux.c b/drivers/staging/= r8188eu/hal/usb_ops_linux.c index 9ec55a77dccd..4a0ab4053e90 100644 --- a/drivers/staging/r8188eu/hal/usb_ops_linux.c +++ b/drivers/staging/r8188eu/hal/usb_ops_linux.c @@ -183,24 +183,6 @@ int rtw_writeN(struct adapter *adapter, u32 addr, u32 = length, u8 *data) return RTW_STATUS_CODE(ret); } =20 -static void interrupt_handler_8188eu(struct adapter *adapt, u16 pkt_len, u= 8 *pbuf) -{ - struct hal_data_8188e *haldata =3D &adapt->haldata; - - if (pkt_len !=3D INTERRUPT_MSG_FORMAT_LEN) { - DBG_88E("%s Invalid interrupt content length (%d)!\n", __func__, pkt_len= ); - return; - } - - /* HISR */ - memcpy(&haldata->IntArray[0], &pbuf[USB_INTR_CONTENT_HISR_OFFSET], 4); - memcpy(&haldata->IntArray[1], &pbuf[USB_INTR_CONTENT_HISRE_OFFSET], 4); - - /* C2H Event */ - if (pbuf[0] !=3D 0) - memcpy(&haldata->C2hArray[0], &pbuf[USB_INTR_CONTENT_C2H_OFFSET], 16); -} - static int recvbuf2recvframe(struct adapter *adapt, struct sk_buff *pskb) { u8 *pbuf; @@ -342,8 +324,6 @@ static int recvbuf2recvframe(struct adapter *adapt, str= uct sk_buff *pskb) pattrib->MacIDValidEntry[0], pattrib->MacIDValidEntry[1] ); - } else if (pattrib->pkt_rpt_type =3D=3D HIS_REPORT) { - interrupt_handler_8188eu(adapt, pattrib->pkt_len, precvframe->rx_data); } rtw_free_recvframe(precvframe, pfree_recv_queue); } diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/stagi= ng/r8188eu/include/rtl8188e_hal.h index 2ce42d647a34..239d0db55639 100644 --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h @@ -246,9 +246,6 @@ struct hal_data_8188e { =20 u32 UsbBulkOutSize; =20 - /* Interrupt relatd register information. */ - u32 IntArray[3];/* HISR0,HISR1,HSISR */ - u8 C2hArray[16]; u8 UsbTxAggMode; u8 UsbTxAggDescNum; =20 diff --git a/drivers/staging/r8188eu/include/rtl8188e_recv.h b/drivers/stag= ing/r8188eu/include/rtl8188e_recv.h index bc30eb4634bb..0be9896eaf0f 100644 --- a/drivers/staging/r8188eu/include/rtl8188e_recv.h +++ b/drivers/staging/r8188eu/include/rtl8188e_recv.h @@ -37,7 +37,6 @@ enum rx_packet_type { HIS_REPORT,/* USB HISR RPT */ }; =20 -#define INTERRUPT_MSG_FORMAT_LEN 60 void rtl8188eu_init_recvbuf(struct recv_buf *buf); s32 rtl8188eu_init_recv_priv(struct adapter *padapter); void rtl8188eu_free_recv_priv(struct adapter * padapter); diff --git a/drivers/staging/r8188eu/include/rtl8188e_spec.h b/drivers/stag= ing/r8188eu/include/rtl8188e_spec.h index e59fd2fe82c5..009222b4a95d 100644 --- a/drivers/staging/r8188eu/include/rtl8188e_spec.h +++ b/drivers/staging/r8188eu/include/rtl8188e_spec.h @@ -475,13 +475,6 @@ Default: 00b. #define MSR_INFRA 0x02 #define MSR_AP 0x03 =20 -/* 88EU (MSR) Media Status Register (Offset 0x4C, 8 bits) */ -#define USB_INTR_CONTENT_C2H_OFFSET 0 -#define USB_INTR_CONTENT_CPWM1_OFFSET 16 -#define USB_INTR_CONTENT_CPWM2_OFFSET 20 -#define USB_INTR_CONTENT_HISR_OFFSET 48 -#define USB_INTR_CONTENT_HISRE_OFFSET 52 - /* 88E Driver Initialization Offload REG_FDHM0(Offset 0x88, 8 bits) */ /* IOL config for REG_FDHM0(Reg0x88) */ #define CMD_INIT_LLT BIT(0) --=20 2.34.1 From nobody Thu Jul 2 06:38:35 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4848EC43217 for ; Sat, 1 Jan 2022 08:50:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232241AbiAAIuG (ORCPT ); Sat, 1 Jan 2022 03:50:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231438AbiAAItz (ORCPT ); Sat, 1 Jan 2022 03:49:55 -0500 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46220C06173F for ; Sat, 1 Jan 2022 00:49:55 -0800 (PST) Received: by mail-wr1-x431.google.com with SMTP id k18so22955036wrg.11 for ; Sat, 01 Jan 2022 00:49:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8r+cRr679ExYoNRZPV7FmhdQZm1WdYwZAxdxXDZnMJQ=; b=GLht4rLA6h25YdxDNBMSrXKlaclXLj6ZPHy2SE2xoG06FSzNulJFqPfD34NR3NQa7Z pC58ydUPVE6Gp5zQ4DcXAHWmI+EpYnSBmKeNjE6g8IOB4kVa0cQ1aH2E5n52PILWvVL0 r5TBPpUIOxQY5lCGUfMyRDmsFXD27LLMPZ5vMbJcJN7uqu/ov81M62pFgWnoGci7wOtW SSfKjLvhs2EgvksgGkjkQG2QPvLmt1sL2pPANWN411nk2mppbvQc9qCVV6wW0d0H/rok Zf6okrSLm+Vfp7DFHmKudTZPVCZzmIAyHaa1tebY9zWznjL2qYOupmP3eIATa74d2fqi HDTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8r+cRr679ExYoNRZPV7FmhdQZm1WdYwZAxdxXDZnMJQ=; b=AESpRAuutXj535QLQ6yiqVnwCxbBSKoi4kqDI+TFi+MP5EfOtX4xRTRks1N8Q8/G/N FC3YjsqduXBJx7YXLs5FIsCxM3A12YZkm3Cr0pUD4erZz6yWrpLg631N50BqJFvdeFhD sI5n/MQJ9zkFQ8zfAcSwQh5msGgi0cOelLYjajddr3uleCMN/QxxDYPsqUu5iQtCkoBB YhatL+LH/nYWuzOf/+A0mRbiq45Rbo5t08lWFgStHjcWndvoXX1GEuzHxWKDiXqLBPZN r5GK5RxYv/Sz3sP3dqlth3bgw8JpZK7O2ratnVWMrZGOeFsVcyzCb/dwFOYa0v4Rng3O WuXg== X-Gm-Message-State: AOAM532cp0kFXK1UGlJYg2VNoDZoulbnPi53REyMbZ+HGTVPo8sfhdBk 5s/t6gL7p3S6Peew2l7IaN4= X-Google-Smtp-Source: ABdhPJynMXEHJPJe6VUcIi1V0sBoXvz6fresJ71AOZRmZg6VFV3q4fZWNMnSHgWyXgQxjbz2zuJevA== X-Received: by 2002:a05:6000:2c2:: with SMTP id o2mr31923464wry.210.1641026993909; Sat, 01 Jan 2022 00:49:53 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::d7e8]) by smtp.gmail.com with ESMTPSA id o9sm14806578wri.97.2022.01.01.00.49.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jan 2022 00:49:53 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH v3 7/7] staging: r8188eu: FwRsvdPageStartOffset is set but never used Date: Sat, 1 Jan 2022 09:49:37 +0100 Message-Id: <20220101084937.3411-8-straube.linux@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220101084937.3411-1-straube.linux@gmail.com> References: <20220101084937.3411-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The field FwRsvdPageStartOffset of struct hal_data_8188e is set but never used. Remove it. Signed-off-by: Michael Straube --- v3: no changes v2: no changes drivers/staging/r8188eu/hal/rtl8188e_cmd.c | 3 --- drivers/staging/r8188eu/include/rtl8188e_hal.h | 2 -- 2 files changed, 5 deletions(-) diff --git a/drivers/staging/r8188eu/hal/rtl8188e_cmd.c b/drivers/staging/r= 8188eu/hal/rtl8188e_cmd.c index ca24e17c369d..a491c37777df 100644 --- a/drivers/staging/r8188eu/hal/rtl8188e_cmd.c +++ b/drivers/staging/r8188eu/hal/rtl8188e_cmd.c @@ -440,7 +440,6 @@ void CheckFwRsvdPageContent(struct adapter *Adapter) /* 2009.10.15 by tynli. */ static void SetFwRsvdPagePkt(struct adapter *adapt, bool bDLFinished) { - struct hal_data_8188e *haldata; struct xmit_frame *pmgntframe; struct pkt_attrib *pattrib; struct xmit_priv *pxmitpriv; @@ -461,7 +460,6 @@ static void SetFwRsvdPagePkt(struct adapter *adapt, boo= l bDLFinished) return; } =20 - haldata =3D &adapt->haldata; pxmitpriv =3D &adapt->xmitpriv; pmlmeext =3D &adapt->mlmeextpriv; pmlmeinfo =3D &pmlmeext->mlmext_info; @@ -480,7 +478,6 @@ static void SetFwRsvdPagePkt(struct adapter *adapt, boo= l bDLFinished) if (PageNeed =3D=3D 1) PageNeed +=3D 1; PageNum +=3D PageNeed; - haldata->FwRsvdPageStartOffset =3D PageNum; =20 BufIndex +=3D PageNeed * 128; =20 diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/stagi= ng/r8188eu/include/rtl8188e_hal.h index 239d0db55639..25f3c04e81b7 100644 --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h @@ -230,8 +230,6 @@ struct hal_data_8188e { =20 u8 bDumpRxPkt;/* for debug */ u8 bDumpTxPkt;/* for debug */ - u8 FwRsvdPageStartOffset; /* Reserve page start offset except - * beacon in TxQ. */ =20 u8 OutEpQueueSel; u8 OutEpNumber; --=20 2.34.1