From nobody Thu Jul 2 06:38:36 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A3A2C433F5 for ; Sat, 1 Jan 2022 08:18:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229769AbiAAISH (ORCPT ); Sat, 1 Jan 2022 03:18:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229658AbiAAISG (ORCPT ); Sat, 1 Jan 2022 03:18:06 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69C3BC061574 for ; Sat, 1 Jan 2022 00:18:06 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id w20so50617985wra.9 for ; Sat, 01 Jan 2022 00:18:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dyAlzOohNwnAjxD5jG0//dHME7ZhYBT+DvDH2X9pgaU=; b=QQc25IzK8IPVhEqsb3ZK80AwVLRmnlQRIh7IdICYlwaRCHfNlmSwGkjEs2hYcpXb/r TVZNWFKGqHZeBlIVqS6H38k7EZgXzNkbYDpriNaecs6xR2AX9Pa7gDxhF3TLju2tETxL owvlBNDTZZFVlTDXFqeBLlRBGAjxhGSXnsVndYGH/zSHXBWI8vlf/AVgFDaDdTpTsook pAdGijuK2GQSXjLQw8BicaQgjtAgIyKcIEvN2GhAJk2X7Far87HaFVBhWbAFfTmEkCoD de/7sTDT9CsVPAroePAPYsrqO3nTDpQS6dewUI6t+M3pUOIeNYWkBXaZDvDCCCRAS04D +EVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dyAlzOohNwnAjxD5jG0//dHME7ZhYBT+DvDH2X9pgaU=; b=aTmG+jDdf1sYWv//2iVGhFGJsLse9X5Vrm1pgwsm1s0I8i0q46QXt+xc1BN+NX8Aum 4veIjnOmxfwD3TMt8rL/U/2WRWGw+Rk/2e2hFAKClQyVrIHJHFqMdsrUAVQjCgCTMgaq Fo3MFy2r2kAPcyAEQXQ1UH9aw691cVVWedeL4H0xreNxEbbBQYj7KBYwFNCLPViTcA7V wDrwpFQVYR188gKS++oE4GX4xUFIub8jzQJH8czvDusr94zbxhy/ckAfl78+yaoactVj eUF+kOO4Irv1JgvBPzXaIr/qI5aWUB0m6rdCulCsdjSXIF4OdthbCcHYb1EYSYBXuUP+ kYEQ== X-Gm-Message-State: AOAM532xa4SYt+nhbmmRyZuAp31DGoxvd25ekGIBUHb6LDQfn+GA8KRQ 1ZOQGFsj4cSWIP0/bDnVeK0= X-Google-Smtp-Source: ABdhPJzapFx0oe3HhEZKXjEF6XsDgiZqdAh8zkrYFst0mZq9OpPraT/ADSPbztlN960M+rvVnEqD5A== X-Received: by 2002:adf:e88a:: with SMTP id d10mr31547425wrm.114.1641025084924; Sat, 01 Jan 2022 00:18:04 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::6619]) by smtp.gmail.com with ESMTPSA id u9sm30693651wmm.7.2022.01.01.00.18.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jan 2022 00:18:04 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH v2 1/7] staging: r8188eu: bRDGEnable is always false Date: Sat, 1 Jan 2022 09:17:52 +0100 Message-Id: <20220101081758.9716-2-straube.linux@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220101081758.9716-1-straube.linux@gmail.com> References: <20220101081758.9716-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The field bRDGEnable in struct hal_data_8188e is never set. It stays at its default value 0. Remove bRDGEnable and related dead code. Signed-off-by: Michael Straube --- v2: no changes drivers/staging/r8188eu/hal/usb_halinit.c | 10 ---------- drivers/staging/r8188eu/include/rtl8188e_hal.h | 3 --- 2 files changed, 13 deletions(-) diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8= 188eu/hal/usb_halinit.c index d5c7e8bf1f38..104705ef170e 100644 --- a/drivers/staging/r8188eu/hal/usb_halinit.c +++ b/drivers/staging/r8188eu/hal/usb_halinit.c @@ -384,13 +384,6 @@ static void _InitEDCA(struct adapter *Adapter) rtw_write32(Adapter, REG_EDCA_VO_PARAM, 0x002FA226); } =20 -static void _InitRDGSetting(struct adapter *Adapter) -{ - rtw_write8(Adapter, REG_RD_CTRL, 0xFF); - rtw_write16(Adapter, REG_RD_NAV_NXT, 0x200); - rtw_write8(Adapter, REG_RD_RESP_PKT_TH, 0x05); -} - static void _InitRetryFunction(struct adapter *Adapter) { u8 value8; @@ -712,9 +705,6 @@ u32 rtl8188eu_hal_init(struct adapter *Adapter) value16 |=3D (MACTXEN | MACRXEN); rtw_write8(Adapter, REG_CR, value16); =20 - if (haldata->bRDGEnable) - _InitRDGSetting(Adapter); - /* Enable TX Report */ /* Enable Tx Report Timer */ value8 =3D rtw_read8(Adapter, REG_TX_RPT_CTRL); diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/stagi= ng/r8188eu/include/rtl8188e_hal.h index b42af86555cd..e8cb093abb62 100644 --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h @@ -236,9 +236,6 @@ struct hal_data_8188e { =20 u32 RfRegChnlVal[2]; =20 - /* RDG enable */ - bool bRDGEnable; - /* for host message to fw */ u8 LastHMEBoxNum; =20 --=20 2.34.1 From nobody Thu Jul 2 06:38:36 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FD24C4332F for ; Sat, 1 Jan 2022 08:18:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229918AbiAAISK (ORCPT ); Sat, 1 Jan 2022 03:18:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229757AbiAAISH (ORCPT ); Sat, 1 Jan 2022 03:18:07 -0500 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D8ADC061574 for ; Sat, 1 Jan 2022 00:18:07 -0800 (PST) Received: by mail-wr1-x42f.google.com with SMTP id s1so59598035wra.6 for ; Sat, 01 Jan 2022 00:18:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7VHZWSW7IZYW+tuJsgx1W6d7mxzf81jEGBsUolGkzPM=; b=bjmxPyvwNFTPhYcJcUJ98dC8ps/bBGutyg7IHwbG8rgvwxO100qA2EiNa4UFb9mShc bae19aCnDi7jaub2Zoyp4I7YMQu8AZwV1QK9tz42eRF9IkyS4W/xFTXaEJBGwWgcEoRe s1dnOsjp1iGyP1eoqBBy1O2AxuRNI8hD/KfGeV5eEjEku1xh+iDBnNRW+LkWcUvR+P6/ Yg4cZlcZQxk5XYyvYlUXXN/FGjRByzIhSbcKFFQHeym1cQxJVxdUqHoSeiGdPAXEaZ8Z sv7Q9uQ0CwBpg6c3YdUQDzVtQU3eza/RLHNyhv9BBVj4PRz41eWCQsizbrZg2vEUowhs IQQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7VHZWSW7IZYW+tuJsgx1W6d7mxzf81jEGBsUolGkzPM=; b=m1cVBGTlQtgYQnysMQtZTo8GxP5Nfasou8kM4o2EX1ubyMLyuSOVAfoclsQ+H6R/x4 rL6bn710OfSMMUhtsnxsNRxvS+f8H0Yzuznw2LfLgc9kR12301o1iDhL1NC+MCk8NjHs UpDuls6F02/BPn/kRlWWTcAtb3lK8juXPzB3JAO9N+r4h3vcOv/qxTEd5BP7Zh0ayfUa F6dLyjMnKpeXJLMsT6TS5BlxdC/A4gBCIro8wzbytp4OxocZu+1DCD2GmQff7o9VUD1W FOC+cX3e6Ly9eLhYUcGEooScZTxUUrp9egKWmGTD50WU8NHa3jvQWsLhLi+QJLcPdBAM HR5A== X-Gm-Message-State: AOAM530uL4qbacsWbWjO5mYdqtTX0PDobFcuHfdO6x4ah2I32bJKs0g8 ZHfpUBnopgOHn5XXP8qvM+w= X-Google-Smtp-Source: ABdhPJxJ33tHYsaHYW+ck0zvMCQIMLYjLwMF6L5bYlo5BOanRAOHbvX6mKtjbZcgesDeUu3mz82hZA== X-Received: by 2002:adf:ec8b:: with SMTP id z11mr32116271wrn.378.1641025085625; Sat, 01 Jan 2022 00:18:05 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::6619]) by smtp.gmail.com with ESMTPSA id u9sm30693651wmm.7.2022.01.01.00.18.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jan 2022 00:18:05 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH v2 2/7] staging: r8188eu: UsbRxHighSpeedMode is set but never used Date: Sat, 1 Jan 2022 09:17:53 +0100 Message-Id: <20220101081758.9716-3-straube.linux@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220101081758.9716-1-straube.linux@gmail.com> References: <20220101081758.9716-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The field UsbRxHighSpeedMode of struct hal_data_8188e is set but never used. Remove it. Signed-off-by: Michael Straube --- v2: no changes drivers/staging/r8188eu/hal/usb_halinit.c | 5 ----- drivers/staging/r8188eu/include/rtl8188e_hal.h | 3 --- 2 files changed, 8 deletions(-) diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8= 188eu/hal/usb_halinit.c index 104705ef170e..96db9a8e7667 100644 --- a/drivers/staging/r8188eu/hal/usb_halinit.c +++ b/drivers/staging/r8188eu/hal/usb_halinit.c @@ -502,16 +502,11 @@ usb_AggSettingRxUpdate( =20 static void InitUsbAggregationSetting(struct adapter *Adapter) { - struct hal_data_8188e *haldata =3D &Adapter->haldata; - /* Tx aggregation setting */ usb_AggSettingTxUpdate(Adapter); =20 /* Rx aggregation setting */ usb_AggSettingRxUpdate(Adapter); - - /* 201/12/10 MH Add for USB agg mode dynamic switch. */ - haldata->UsbRxHighSpeedMode =3D false; } =20 static void _InitOperationMode(struct adapter *Adapter) diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/stagi= ng/r8188eu/include/rtl8188e_hal.h index e8cb093abb62..8b54f52f49e2 100644 --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h @@ -262,9 +262,6 @@ struct hal_data_8188e { u8 OutEpQueueSel; u8 OutEpNumber; =20 - /* Add for USB aggreation mode dynamic shceme. */ - bool UsbRxHighSpeedMode; - /* 2010/11/22 MH Add for slim combo debug mode selective. */ /* This is used for fix the drawback of CU TSMC-A/UMC-A cut. * HW auto suspend ability. Close BT clock. */ --=20 2.34.1 From nobody Thu Jul 2 06:38:36 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3129BC433FE for ; Sat, 1 Jan 2022 08:18:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229963AbiAAISL (ORCPT ); Sat, 1 Jan 2022 03:18:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229658AbiAAISI (ORCPT ); Sat, 1 Jan 2022 03:18:08 -0500 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0675C06173E for ; Sat, 1 Jan 2022 00:18:07 -0800 (PST) Received: by mail-wr1-x42e.google.com with SMTP id v7so59493747wrv.12 for ; Sat, 01 Jan 2022 00:18:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eK7taryyQSQVDJH0tOpVoMb90mygew6Vz5QUqjyD+10=; b=A3vpCJPzTHTnzx3JxK4ba+oIxWkOqewjdxEFSjIvVIoCZMRq5vGyFfSBVwIHgS9RCc qmZKCnmB28KgQywNn74wrsp7822NlNQip2ry3YiOHmTSqoJusLN52LfcjoSPdNA9TLZH n3+TfUmda6iB/CNRwF+W+MDCgl1B1cBN8KWYPfkCEY1PWBHi+OEB5FtEEiPANZDCYX4G /gfNsgFa8cjdfDJZrfrdm47fKm0wRJ6spl7j9sSoN1+UG/EBWWTBi2hcPZHnxBqNp9G9 ZK8KYYR7+8mQyDI1Qlwssxxr0Huu86dvQsIQktnenKCff9SyIvqyHTGcqNnrxMYGBkNw Vy9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eK7taryyQSQVDJH0tOpVoMb90mygew6Vz5QUqjyD+10=; b=mtCHs5nNk8I4G7fjfioYAukg/PEpbSGoDGwDmLSMmCXDI1DdU9lWWHIrtkZ6i73pFW 4BlQwT5MtWoCwE/e7mI7aNsKJ9LzXtFaEPG1Ylx9nE7u6NwTAngqW0MHU/L8W49Ru1bg 5pbZi1RriYpS2mAy6fCfbUJgyzi0ugDlACJPy2+NtLIXaXi45ve4meROsJruIyDVwMSG udlELOQuXLfwDAY2/qO3eDqnem4Q0NgNdATgASOULs6amXdjfzesRxEmLyWt1bF+JiOI Pz4sigMsuhs+CvAwTU/f+TY4W4KVhKebyc1eDLfTPwbvSbrlbGYJazKiv2LoEWod7meN IeyQ== X-Gm-Message-State: AOAM533TVg2g6cX7pXBbcfJCmzrOby7kb0LJa7VZId0J1P8rX8RlgZH+ ZBW9PdUc7wPAv71ROsFcinQ= X-Google-Smtp-Source: ABdhPJxBBUk1kWB1nOkNsVekcIfhxgoiz7bCp3zOW5hmK4GCz4GYNOcuRgsvVk8ay1q/qcuoSPql4A== X-Received: by 2002:a05:6000:1112:: with SMTP id z18mr31091235wrw.129.1641025086424; Sat, 01 Jan 2022 00:18:06 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::6619]) by smtp.gmail.com with ESMTPSA id u9sm30693651wmm.7.2022.01.01.00.18.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jan 2022 00:18:06 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH v2 3/7] staging: r8188eu: bTXPowerDataReadFromEEPORM is set but never used Date: Sat, 1 Jan 2022 09:17:54 +0100 Message-Id: <20220101081758.9716-4-straube.linux@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220101081758.9716-1-straube.linux@gmail.com> References: <20220101081758.9716-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The field bTXPowerDataReadFromEEPORM of struct hal_data_8188e is set but never used. Remove it. Signed-off-by: Michael Straube --- v2: no changes drivers/staging/r8188eu/hal/rtl8188e_hal_init.c | 3 --- drivers/staging/r8188eu/include/rtl8188e_hal.h | 1 - 2 files changed, 4 deletions(-) diff --git a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c b/drivers/stag= ing/r8188eu/hal/rtl8188e_hal_init.c index d8d6547465a7..065c2701077d 100644 --- a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c +++ b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c @@ -1127,9 +1127,6 @@ void Hal_ReadTxPowerInfo88E(struct adapter *padapter,= u8 *PROMContent, bool Auto =20 Hal_ReadPowerValueFromPROM_8188E(&pwrInfo24G, PROMContent, AutoLoadFail); =20 - if (!AutoLoadFail) - pHalData->bTXPowerDataReadFromEEPORM =3D true; - for (ch =3D 0; ch < CHANNEL_MAX_NUMBER; ch++) { hal_get_chnl_group_88e(ch, &group); =20 diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/stagi= ng/r8188eu/include/rtl8188e_hal.h index 8b54f52f49e2..de58c85b8bdc 100644 --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h @@ -180,7 +180,6 @@ struct hal_data_8188e { u16 EEPROMSDID; u8 EEPROMRegulatory; =20 - u8 bTXPowerDataReadFromEEPORM; u8 EEPROMThermalMeter; u8 bAPKThermalMeterIgnore; =20 --=20 2.34.1 From nobody Thu Jul 2 06:38:36 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FD3DC43217 for ; Sat, 1 Jan 2022 08:18:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230374AbiAAISN (ORCPT ); Sat, 1 Jan 2022 03:18:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229775AbiAAISJ (ORCPT ); Sat, 1 Jan 2022 03:18:09 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A546C061574 for ; Sat, 1 Jan 2022 00:18:08 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id n14-20020a7bcbce000000b00332f4abf43fso8992989wmi.0 for ; Sat, 01 Jan 2022 00:18:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=V/ySfznrCVwP33nHINhDWA0To2qZRQwyQe3jvr0Q578=; b=V37BQwEVVnSS2lKE1SO4KaC7cKd5pd5SQVAuwhWCPRwvfKzcLfM78buuuYweTdm+6I RWtW/ga1F0/BHu359sg3H76w6+9jIgT1n0dSPf7fXJfEIe3gT/OXsEqOVVlaHcERLbqb 0MjFG8E6BWS3Hi82bXHM2L4bFr+PMjWlwmBsmBsh3ixYObwDrCzTdMteKh0wKuG4vxC7 v9iPW36XmIH5MmqFHmlsm0jAHsDqB1RZ+ewDUum1dAjR12fGEjeQI/DAXDF4FiwaHl/y i/tzkABEIGCVoxwCzhb4rLB/mhdr4iFT0NjBy0T6PEkFAoMngYlAMsm/kX9/KTUGU97K yvtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=V/ySfznrCVwP33nHINhDWA0To2qZRQwyQe3jvr0Q578=; b=PK8ojdXgGRRad7I9LcMPZs2qsC2x3+6i3UJkdPM7LcKLg+AviNcHSD7YkR7v1SaPrF F45IVjXrJMavS6IcXRF+En7zaT7gj1pa4jcyFTD7Ig1hstpTtEnzHSRuC9yn1grZY1Jb UPc2GeXhS7T/TgLB+uQ2zgdrsS7HhH1ouBZUxqS8nvoFx7F2haXueRnE90MYzhrO1zHA djQcP5THJaQvnwdrI2GziBOaQjcMvmx4IJay/1g7E4nnVKSokbBfxPmd0IswpGKO0aos AZIXUqdyPvgAhnYCWJhqe7gfhg2I+rGcIwgc53j+aGcyygB7plOf3uuu4NKTLua+dmqP T3Mg== X-Gm-Message-State: AOAM532jSNPq19oXuRgq5/eEwl4NbycqQK0owHI4GsOlgycqAyYppVv8 H4sqmkqKs06n28uMYYtlELo= X-Google-Smtp-Source: ABdhPJy1Ob1E9s+MfJ0wRuUANVYtAtgJGP6Jbjlh3QPDn83Qc6hu31IsZzKfpbX+vph7xnIVLkRang== X-Received: by 2002:a1c:9d14:: with SMTP id g20mr32131418wme.134.1641025087270; Sat, 01 Jan 2022 00:18:07 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::6619]) by smtp.gmail.com with ESMTPSA id u9sm30693651wmm.7.2022.01.01.00.18.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jan 2022 00:18:06 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH v2 4/7] staging: r8188eu: bAPKThermalMeterIgnore is set but never used Date: Sat, 1 Jan 2022 09:17:55 +0100 Message-Id: <20220101081758.9716-5-straube.linux@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220101081758.9716-1-straube.linux@gmail.com> References: <20220101081758.9716-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The field bAPKThermalMeterIgnore of struct hal_data_8188e is set but never used. Remove it. Signed-off-by: Michael Straube --- v2: no changes drivers/staging/r8188eu/hal/rtl8188e_hal_init.c | 5 ++--- drivers/staging/r8188eu/include/rtl8188e_hal.h | 1 - 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c b/drivers/stag= ing/r8188eu/hal/rtl8188e_hal_init.c index 065c2701077d..cce291ca44b1 100644 --- a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c +++ b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c @@ -1230,9 +1230,8 @@ void Hal_ReadThermalMeter_88E(struct adapter *Adapter= , u8 *PROMContent, bool Aut else pHalData->EEPROMThermalMeter =3D EEPROM_Default_ThermalMeter_88E; =20 - if (pHalData->EEPROMThermalMeter =3D=3D 0xff || AutoloadFail) { - pHalData->bAPKThermalMeterIgnore =3D true; + if (pHalData->EEPROMThermalMeter =3D=3D 0xff || AutoloadFail) pHalData->EEPROMThermalMeter =3D EEPROM_Default_ThermalMeter_88E; - } + DBG_88E("ThermalMeter =3D 0x%x\n", pHalData->EEPROMThermalMeter); } diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/stagi= ng/r8188eu/include/rtl8188e_hal.h index de58c85b8bdc..40b3db34b8f2 100644 --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h @@ -181,7 +181,6 @@ struct hal_data_8188e { u8 EEPROMRegulatory; =20 u8 EEPROMThermalMeter; - u8 bAPKThermalMeterIgnore; =20 bool EepromOrEfuse; =20 --=20 2.34.1 From nobody Thu Jul 2 06:38:36 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E900C4321E for ; Sat, 1 Jan 2022 08:18:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231371AbiAAISP (ORCPT ); Sat, 1 Jan 2022 03:18:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229807AbiAAISJ (ORCPT ); Sat, 1 Jan 2022 03:18:09 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49BABC061574 for ; Sat, 1 Jan 2022 00:18:09 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id e5so59604705wrc.5 for ; Sat, 01 Jan 2022 00:18:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kTPq3bwy8yog6hFLtW+V15w6R9lOZAWWw5IrK/yQyN8=; b=HgKm7xkW/qoi/ID9pKhSSSbbF/4253umdAAPLBkG2ooU7m5o7vPdbout5Liuf4APqh egHIEF3SKUWBDnUjKTFbYFhBa70bj1f4l6VS0Yf6w9EQKyIyFs4lZUveBecSqGyCDbAb VqSQEsCL5sGG5mydHNwzXanpzUlhK335sFVp/QSQzOqBtSlaPr/Z6dC6uuObN2wARAy/ tctqWxpxGxH7IzvPFwqtYUwKv3c42eRv99WQgI1vqLeQT+jhMciubDtyW7W+NHXzMHS2 qFuJtcipZEAJSy3Jafc7IQkYen2uChAg+mc6iz2XTxKvkHSRIyRXSZjwe2MR3Ymwx/Yj YCUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kTPq3bwy8yog6hFLtW+V15w6R9lOZAWWw5IrK/yQyN8=; b=c2W87gATNvI261vXIfVd3reAZyq14HVBJCrmy4Sor1Hg1czVR2sQy9tKXrlCjyOcai ZMIfUIOLKxeljc/gytOTK49FXfyo+2IDq6Y0Pf8DcDfrDCctMVUBrHvaxf5WTOTivRiu 7B0TkhLdurH+o1gSIOD7VjNtORTbFQr0gdUW4FvHj6dVcjc+zi2MMrdfKAm8q+PLDxLT PhXUn9gjWu30SS2yBp9KKZOrtuj9QyZfohFbbht8nEGn/OPTgIdBF/bQNCaqYufZ0oWA eX9cza7DXdMznQ50e8bKomn1tDSYVreorLFjHNhOGkfRAhkGFyRRriTxUdKRzZPhjA0y 0xzQ== X-Gm-Message-State: AOAM5308vKNwxa3MvDrDNWH2uq4wbVJS90FN/d2alIP7SUSXuBY+nhjI MXxE8Eh+Z9vagxHSO7Q444I= X-Google-Smtp-Source: ABdhPJwKMf+fs+TBJ1CkJHY8LOPZFsGF3o+HS+5e3UgWJ4mJSAx7EQQma8XXTTKq3w3nQQue2pemyQ== X-Received: by 2002:adf:f6c1:: with SMTP id y1mr31607998wrp.351.1641025087926; Sat, 01 Jan 2022 00:18:07 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::6619]) by smtp.gmail.com with ESMTPSA id u9sm30693651wmm.7.2022.01.01.00.18.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jan 2022 00:18:07 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH v2 5/7] staging: r8188eu: remove unused fields from struct hal_data_8188e Date: Sat, 1 Jan 2022 09:17:56 +0100 Message-Id: <20220101081758.9716-6-straube.linux@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220101081758.9716-1-straube.linux@gmail.com> References: <20220101081758.9716-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove unused fields from struct hal_data_8188e. Signed-off-by: Michael Straube --- v2: no changes .../staging/r8188eu/include/rtl8188e_hal.h | 30 ------------------- 1 file changed, 30 deletions(-) diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/stagi= ng/r8188eu/include/rtl8188e_hal.h index 40b3db34b8f2..2ce42d647a34 100644 --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h @@ -175,15 +175,9 @@ struct hal_data_8188e { =20 u16 BasicRateSet; =20 - /* EEPROM setting. */ - u16 EEPROMSVID; - u16 EEPROMSDID; u8 EEPROMRegulatory; - u8 EEPROMThermalMeter; =20 - bool EepromOrEfuse; - u8 Index24G_CCK_Base[RF_PATH_MAX][CHANNEL_MAX_NUMBER]; u8 Index24G_BW40_Base[RF_PATH_MAX][CHANNEL_MAX_NUMBER]; /* If only one tx, only BW20 and OFDM are used. */ @@ -192,11 +186,6 @@ struct hal_data_8188e { s8 BW20_24G_Diff[RF_PATH_MAX][MAX_TX_COUNT]; s8 BW40_24G_Diff[RF_PATH_MAX][MAX_TX_COUNT]; =20 - u8 TxPwrLevelCck[RF_PATH_MAX][CHANNEL_MAX_NUMBER]; - /* For HT 40MHZ pwr */ - u8 TxPwrLevelHT40_1S[RF_PATH_MAX][CHANNEL_MAX_NUMBER]; - /* For HT 40MHZ pwr */ - u8 TxPwrLevelHT40_2S[RF_PATH_MAX][CHANNEL_MAX_NUMBER]; /* HT 20<->40 Pwr diff */ u8 TxPwrHt20Diff[RF_PATH_MAX][CHANNEL_MAX_NUMBER]; /* For HT<->legacy pwr diff */ @@ -205,7 +194,6 @@ struct hal_data_8188e { u8 PwrGroupHT20[RF_PATH_MAX][CHANNEL_MAX_NUMBER]; u8 PwrGroupHT40[RF_PATH_MAX][CHANNEL_MAX_NUMBER]; =20 - u8 LegacyHTTxPowerDiff;/* Legacy to HT rate power diff */ /* The current Tx Power Level */ u8 CurrentCckTxPwrIdx; u8 CurrentOfdm24GTxPwrIdx; @@ -213,21 +201,12 @@ struct hal_data_8188e { u8 CurrentBW4024GTxPwrIdx; =20 /* Read/write are allow for following hardware information variables */ - u8 framesync; - u32 framesyncC34; - u8 framesyncMonitor; - u8 DefaultInitialGain[4]; u8 pwrGroupCnt; u32 MCSTxPowerLevelOriginalOffset[MAX_PG_GROUP][16]; - u32 CCKTxPowerLevelOriginalOffset; =20 u8 CrystalCap; - u32 AntennaTxPath; /* Antenna path Tx */ - u32 AntennaRxPath; /* Antenna path Rx */ u8 ExternalPA; =20 - u8 b1x1RecvCombine; /* for 1T1R receive combining */ - u32 AcParam_BE; /* Original parameter for BE, use for EDCA turbo. */ =20 struct bb_reg_def PHYRegDef[2]; /* Radio A/B */ @@ -254,17 +233,9 @@ struct hal_data_8188e { u8 FwRsvdPageStartOffset; /* Reserve page start offset except * beacon in TxQ. */ =20 - /* 2010/08/09 MH Add CU power down mode. */ - bool pwrdown; - u8 OutEpQueueSel; u8 OutEpNumber; =20 - /* 2010/11/22 MH Add for slim combo debug mode selective. */ - /* This is used for fix the drawback of CU TSMC-A/UMC-A cut. - * HW auto suspend ability. Close BT clock. */ - bool SlimComboDbg; - u16 EfuseUsedBytes; =20 struct P2P_PS_Offload_t p2p_ps_offload; @@ -280,7 +251,6 @@ struct hal_data_8188e { u8 C2hArray[16]; u8 UsbTxAggMode; u8 UsbTxAggDescNum; - u32 MaxUsbRxAggBlock; =20 enum usb_rx_agg_mode UsbRxAggMode; u8 UsbRxAggBlockCount; /* USB Block count. Block size is --=20 2.34.1 From nobody Thu Jul 2 06:38:36 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63EF6C43219 for ; Sat, 1 Jan 2022 08:18:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231409AbiAAISR (ORCPT ); Sat, 1 Jan 2022 03:18:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229933AbiAAISK (ORCPT ); Sat, 1 Jan 2022 03:18:10 -0500 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EAFADC061574 for ; Sat, 1 Jan 2022 00:18:09 -0800 (PST) Received: by mail-wm1-x330.google.com with SMTP id b73so18457034wmd.0 for ; Sat, 01 Jan 2022 00:18:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DXMWSZptIeRPrV7Ny9e/lWoHz+fzwKFZLfpVM59vyP0=; b=VO34iHaCEpkAEFs44Q7eYbTI8ph5n1PkIqK1h8CXuIAV5t45xXfaLuPAyFJXZjUgdG Vei2424ILY+gQlG0xyBOuSOb9EntmNhVN8gwaQ1n19zOT6ozZdQ4xtNNm1dkakeJk6Xm 6hEqxqqohHzr2WN9yJUIAJDptKJ1azvn7553/bMZkI/1u5J5PPYZkCyN2rSLT4urTudy 2OhYGWrbDHRpEBDKL0pfacml2nbQjHLUphvHwMwrkm0MdQPVQy6boRtcIDFKNidwLZ+D QdcJqrfQVSnNaXhLYCMZxYRvF+M9ThP8NUddfGhU5DEYMwH8MYvTR5fgHnBKQnrx1xTm CksA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DXMWSZptIeRPrV7Ny9e/lWoHz+fzwKFZLfpVM59vyP0=; b=A5XHy/bJJDHqn2C39pQU8pLMltUAfuFNRhtkCIAGWZw7AI+WzAGqW+zwygrH8R1zC8 nJQOJePJ3wjIZ1FAj6ooxU2K+xSkSzVPTjb0fka8CQ+EmodGvJwxSi4+3g+hF8B2FCUO FTavw2IuZtjNjCbFbXa9GR2Xx4Yl186Q8kDvMx4gzX7jShIhAU1P/FjTwUq9VDt/zMfl 2KeYaDsFc16cELSgPfs42FoZV8a1HiW2WbvJJ+FjB3u567yOj67A7mF0voNAopaUuapP uZLHmD2Piaui8vcn0DdNO4l2O/Ar9BP0Fbmjd5gExwTiUbGSX5zT6m/c7/Y9NyV5/TLe 0O0Q== X-Gm-Message-State: AOAM533+IW7JGkvRnblq0xZmNY42iTdlCZs33sZ3hlfGcwwrZtM4LrKd WEnRy0Ach2dndiPPJw/NIGO0Pz9XG+4= X-Google-Smtp-Source: ABdhPJyFiu1ixPgRE8CH34H8v8h+o9BmECh2Uy5ksNd1t+hrQ/8aGFGyVvA4bjvcVN26k+CHPiwN+w== X-Received: by 2002:a05:600c:3797:: with SMTP id o23mr31927594wmr.178.1641025088584; Sat, 01 Jan 2022 00:18:08 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::6619]) by smtp.gmail.com with ESMTPSA id u9sm30693651wmm.7.2022.01.01.00.18.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jan 2022 00:18:08 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH v2 6/7] staging: r8188eu: IntArray and C2hArray are set but never used Date: Sat, 1 Jan 2022 09:17:57 +0100 Message-Id: <20220101081758.9716-7-straube.linux@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220101081758.9716-1-straube.linux@gmail.com> References: <20220101081758.9716-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The fields IntArray and C2hArray of struct hal_data_8188e are set but never used. Remove them and remove interrupt_handler_8188eu() since it does nothing now. While at it, remove the unsed defines USB_INTR_CONTENT_CPWM1_OFFSET and USB_INTR_CONTENT_CPWM2_OFFSET as well. Signed-off-by: Michael Straube --- v2: Remove interrupt_handler_8188eu() since it does nothing now. drivers/staging/r8188eu/hal/usb_ops_linux.c | 20 ------------------- .../staging/r8188eu/include/rtl8188e_hal.h | 3 --- .../staging/r8188eu/include/rtl8188e_spec.h | 7 ------- 3 files changed, 30 deletions(-) diff --git a/drivers/staging/r8188eu/hal/usb_ops_linux.c b/drivers/staging/= r8188eu/hal/usb_ops_linux.c index 9ec55a77dccd..4a0ab4053e90 100644 --- a/drivers/staging/r8188eu/hal/usb_ops_linux.c +++ b/drivers/staging/r8188eu/hal/usb_ops_linux.c @@ -183,24 +183,6 @@ int rtw_writeN(struct adapter *adapter, u32 addr, u32 = length, u8 *data) return RTW_STATUS_CODE(ret); } =20 -static void interrupt_handler_8188eu(struct adapter *adapt, u16 pkt_len, u= 8 *pbuf) -{ - struct hal_data_8188e *haldata =3D &adapt->haldata; - - if (pkt_len !=3D INTERRUPT_MSG_FORMAT_LEN) { - DBG_88E("%s Invalid interrupt content length (%d)!\n", __func__, pkt_len= ); - return; - } - - /* HISR */ - memcpy(&haldata->IntArray[0], &pbuf[USB_INTR_CONTENT_HISR_OFFSET], 4); - memcpy(&haldata->IntArray[1], &pbuf[USB_INTR_CONTENT_HISRE_OFFSET], 4); - - /* C2H Event */ - if (pbuf[0] !=3D 0) - memcpy(&haldata->C2hArray[0], &pbuf[USB_INTR_CONTENT_C2H_OFFSET], 16); -} - static int recvbuf2recvframe(struct adapter *adapt, struct sk_buff *pskb) { u8 *pbuf; @@ -342,8 +324,6 @@ static int recvbuf2recvframe(struct adapter *adapt, str= uct sk_buff *pskb) pattrib->MacIDValidEntry[0], pattrib->MacIDValidEntry[1] ); - } else if (pattrib->pkt_rpt_type =3D=3D HIS_REPORT) { - interrupt_handler_8188eu(adapt, pattrib->pkt_len, precvframe->rx_data); } rtw_free_recvframe(precvframe, pfree_recv_queue); } diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/stagi= ng/r8188eu/include/rtl8188e_hal.h index 2ce42d647a34..239d0db55639 100644 --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h @@ -246,9 +246,6 @@ struct hal_data_8188e { =20 u32 UsbBulkOutSize; =20 - /* Interrupt relatd register information. */ - u32 IntArray[3];/* HISR0,HISR1,HSISR */ - u8 C2hArray[16]; u8 UsbTxAggMode; u8 UsbTxAggDescNum; =20 diff --git a/drivers/staging/r8188eu/include/rtl8188e_spec.h b/drivers/stag= ing/r8188eu/include/rtl8188e_spec.h index e59fd2fe82c5..009222b4a95d 100644 --- a/drivers/staging/r8188eu/include/rtl8188e_spec.h +++ b/drivers/staging/r8188eu/include/rtl8188e_spec.h @@ -475,13 +475,6 @@ Default: 00b. #define MSR_INFRA 0x02 #define MSR_AP 0x03 =20 -/* 88EU (MSR) Media Status Register (Offset 0x4C, 8 bits) */ -#define USB_INTR_CONTENT_C2H_OFFSET 0 -#define USB_INTR_CONTENT_CPWM1_OFFSET 16 -#define USB_INTR_CONTENT_CPWM2_OFFSET 20 -#define USB_INTR_CONTENT_HISR_OFFSET 48 -#define USB_INTR_CONTENT_HISRE_OFFSET 52 - /* 88E Driver Initialization Offload REG_FDHM0(Offset 0x88, 8 bits) */ /* IOL config for REG_FDHM0(Reg0x88) */ #define CMD_INIT_LLT BIT(0) --=20 2.34.1 From nobody Thu Jul 2 06:38:36 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7867CC4167D for ; Sat, 1 Jan 2022 08:18:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231348AbiAAIST (ORCPT ); Sat, 1 Jan 2022 03:18:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229757AbiAAISL (ORCPT ); Sat, 1 Jan 2022 03:18:11 -0500 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84898C06173F for ; Sat, 1 Jan 2022 00:18:10 -0800 (PST) Received: by mail-wr1-x42b.google.com with SMTP id i22so59572386wrb.13 for ; Sat, 01 Jan 2022 00:18:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=df3Y5Bn/VrrxiPw//+w6cx+2LKPl8gWDj/0uHtI1CM0=; b=aOv0J6t/QsEzD6fRmR6ObgtEJcbNbQvfK0pEA6WGYf6i8L4nvmpoSjii8r6qsb/fcF fuwIK0b6uZayUpQGhOJUGLbr9MzhuVVK7QK1t7s73aXCZyY4AbMbRwziWV8O9tLThlgi YXD/ERSTYJQbrZWJ/N1TzjGjWHihfmSKXm76sb8gUQ/Q81r1Q+pAuD/No85HHPLYZXeV usy7g3Y49yWmQYXoP1ccA7cyyvm1pKTp/tWuj9Uq4EJs44es6/BCD4g8TYrArS8bbGX4 f0rAMVVPF4mpUj0Yooy2xiOJrF8AlMF4zQhRwtCEixdLgGRrCriRaP041l+ItUnwPdfQ 0mCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=df3Y5Bn/VrrxiPw//+w6cx+2LKPl8gWDj/0uHtI1CM0=; b=i5USDdoFaUUr4DP9ZdI/u8Vdaqw2z71RftijJ3acw7oeHePPchHZNbYY7/zJP5OWYO O7mrjkDSoxQn13eLZ5mdPMFEHq7bwEybdVQip6tK0XPLf9SkNGpCOlQOXJG/26cqu618 uIRpculnmqxBpAtzzHWFX3BASVxRbNdEp8nC63iGXEn3QAlXEEuvxMyFv9ne956lz91h I/Bz9NRm2YCipvCX+Kk3gwWkYLsbRpXiaRrkNGrZQA53eHIwUCDBV535s0ZqPNueSO3Y WnwoiJT7huBGYBvef7Y+5slx64q7V7RMDPEYlMXqdm8c2ATsKlSUFWenMNEfjkYIkiVB aLsA== X-Gm-Message-State: AOAM5307mjGdcqjocBC0Za0zpZchgxmN/D6QIgaXLboAxx/TpKpQlCpV Bc/Q9vMKjOsioZ+nFR9mYY0= X-Google-Smtp-Source: ABdhPJxad99z1MbSk9y/fKaDaVUSYx8S6KMiDGBFiwBOoOTbvVMU66uJ0qyhawudDmYqp0HFKzXN7A== X-Received: by 2002:a5d:6709:: with SMTP id o9mr31470420wru.356.1641025089198; Sat, 01 Jan 2022 00:18:09 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::6619]) by smtp.gmail.com with ESMTPSA id u9sm30693651wmm.7.2022.01.01.00.18.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jan 2022 00:18:08 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH v2 7/7] staging: r8188eu: FwRsvdPageStartOffset is set but never used Date: Sat, 1 Jan 2022 09:17:58 +0100 Message-Id: <20220101081758.9716-8-straube.linux@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220101081758.9716-1-straube.linux@gmail.com> References: <20220101081758.9716-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The field FwRsvdPageStartOffset of struct hal_data_8188e is set but never used. Remove it. Signed-off-by: Michael Straube --- v2: no changes drivers/staging/r8188eu/hal/rtl8188e_cmd.c | 3 --- drivers/staging/r8188eu/include/rtl8188e_hal.h | 2 -- 2 files changed, 5 deletions(-) diff --git a/drivers/staging/r8188eu/hal/rtl8188e_cmd.c b/drivers/staging/r= 8188eu/hal/rtl8188e_cmd.c index ca24e17c369d..a491c37777df 100644 --- a/drivers/staging/r8188eu/hal/rtl8188e_cmd.c +++ b/drivers/staging/r8188eu/hal/rtl8188e_cmd.c @@ -440,7 +440,6 @@ void CheckFwRsvdPageContent(struct adapter *Adapter) /* 2009.10.15 by tynli. */ static void SetFwRsvdPagePkt(struct adapter *adapt, bool bDLFinished) { - struct hal_data_8188e *haldata; struct xmit_frame *pmgntframe; struct pkt_attrib *pattrib; struct xmit_priv *pxmitpriv; @@ -461,7 +460,6 @@ static void SetFwRsvdPagePkt(struct adapter *adapt, boo= l bDLFinished) return; } =20 - haldata =3D &adapt->haldata; pxmitpriv =3D &adapt->xmitpriv; pmlmeext =3D &adapt->mlmeextpriv; pmlmeinfo =3D &pmlmeext->mlmext_info; @@ -480,7 +478,6 @@ static void SetFwRsvdPagePkt(struct adapter *adapt, boo= l bDLFinished) if (PageNeed =3D=3D 1) PageNeed +=3D 1; PageNum +=3D PageNeed; - haldata->FwRsvdPageStartOffset =3D PageNum; =20 BufIndex +=3D PageNeed * 128; =20 diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/stagi= ng/r8188eu/include/rtl8188e_hal.h index 239d0db55639..25f3c04e81b7 100644 --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h @@ -230,8 +230,6 @@ struct hal_data_8188e { =20 u8 bDumpRxPkt;/* for debug */ u8 bDumpTxPkt;/* for debug */ - u8 FwRsvdPageStartOffset; /* Reserve page start offset except - * beacon in TxQ. */ =20 u8 OutEpQueueSel; u8 OutEpNumber; --=20 2.34.1