From nobody Wed Jul 1 04:14:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BF67C433EF for ; Thu, 30 Dec 2021 20:01:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242067AbhL3UBK (ORCPT ); Thu, 30 Dec 2021 15:01:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242055AbhL3UBI (ORCPT ); Thu, 30 Dec 2021 15:01:08 -0500 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 973BCC061574 for ; Thu, 30 Dec 2021 12:01:07 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id v7so52257191wrv.12 for ; Thu, 30 Dec 2021 12:01:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5qh8kFRJCC9bZfIin5oq0yDXNUuQVM5WW/FTbxAj8HY=; b=lG2KQQ3txqqa0lLHdPi/YlgdiHwm2wAKRtp9EyOKp8DTPUS1sNEw541f1dkTyo9ETI aat8pK4nrISa9tfy9eVR7UQjfZ+u/kimEbuxMP+Zt/PgHEQmVcNSj45NZqe3Yj5HOqNR Pn5WPb0J7h3v+oCpM6bAavgJjW1wb0A+2kc7Mct1Kdcj15BcwnJghrs8AakjwUM+VovL tyneh59nWonun714/88im0UiYqykJPZ1L8Kdc7F1Y5wgzClNnqXH4dYLmPAIXAkJ1Jjp psly4Fb3jgX0HjBg9InQ32kHmOz7z7SjUmsmE0XaDyK5u0RzBQpBNVzSp53RzOp6jNp0 /n7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5qh8kFRJCC9bZfIin5oq0yDXNUuQVM5WW/FTbxAj8HY=; b=IMjbmcrLghdD3nv0lYPeTorF58ktbUx7ql7na6VuUXSNoc2ewMxqX49XBoS7EhqjIJ ZNeypn/So19Krp60C7A1tsYr6n3O8kdnKF0mR5TBJ2FlHtZUJ4dNIiewFJa1gc9oLES+ eTzw0c+QfCyI3RA7yT5kLU4+Sn/LbwHLuy2GsGclsaxhKIy0zKs48K+MIfSueMPBRJj2 C5uT/vdTYLL0tcQeBAuTmPYtsVmPwX7Vx+AVNnAm+Gl/qN0pVkxMSLoEL5K8ai1OoT7q itgbnhR+HpYgC/ue2/tXam1uwkoZx+1vS2GdFWm5zamuNTGe81NG+2rWkevhkupehgKi t+xg== X-Gm-Message-State: AOAM530J3NOV+gNf1xVaegFuFY94wMAk0dcnlc37t/yo9BMtQC4lKg6D eNhvVMiKsAcghfJFSYsZtSg= X-Google-Smtp-Source: ABdhPJx2vOFcp7rwJD0AiyjxDud9VUPgEdRTp9LjW6cTBvdjt63AEUnMhaPfrASGolEMwU/OXqdkIQ== X-Received: by 2002:a05:6000:1865:: with SMTP id d5mr25335247wri.650.1640894466241; Thu, 30 Dec 2021 12:01:06 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::6619]) by smtp.gmail.com with ESMTPSA id o8sm29042286wry.20.2021.12.30.12.01.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Dec 2021 12:01:05 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 1/7] staging: r8188eu: bRDGEnable is always false Date: Thu, 30 Dec 2021 21:00:53 +0100 Message-Id: <20211230200059.13406-2-straube.linux@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20211230200059.13406-1-straube.linux@gmail.com> References: <20211230200059.13406-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The field bRDGEnable in struct hal_data_8188e is never set. It stays at its default value 0. Remove bRDGEnable and related dead code. Signed-off-by: Michael Straube --- drivers/staging/r8188eu/hal/usb_halinit.c | 10 ---------- drivers/staging/r8188eu/include/rtl8188e_hal.h | 3 --- 2 files changed, 13 deletions(-) diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8= 188eu/hal/usb_halinit.c index d5c7e8bf1f38..104705ef170e 100644 --- a/drivers/staging/r8188eu/hal/usb_halinit.c +++ b/drivers/staging/r8188eu/hal/usb_halinit.c @@ -384,13 +384,6 @@ static void _InitEDCA(struct adapter *Adapter) rtw_write32(Adapter, REG_EDCA_VO_PARAM, 0x002FA226); } =20 -static void _InitRDGSetting(struct adapter *Adapter) -{ - rtw_write8(Adapter, REG_RD_CTRL, 0xFF); - rtw_write16(Adapter, REG_RD_NAV_NXT, 0x200); - rtw_write8(Adapter, REG_RD_RESP_PKT_TH, 0x05); -} - static void _InitRetryFunction(struct adapter *Adapter) { u8 value8; @@ -712,9 +705,6 @@ u32 rtl8188eu_hal_init(struct adapter *Adapter) value16 |=3D (MACTXEN | MACRXEN); rtw_write8(Adapter, REG_CR, value16); =20 - if (haldata->bRDGEnable) - _InitRDGSetting(Adapter); - /* Enable TX Report */ /* Enable Tx Report Timer */ value8 =3D rtw_read8(Adapter, REG_TX_RPT_CTRL); diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/stagi= ng/r8188eu/include/rtl8188e_hal.h index b42af86555cd..e8cb093abb62 100644 --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h @@ -236,9 +236,6 @@ struct hal_data_8188e { =20 u32 RfRegChnlVal[2]; =20 - /* RDG enable */ - bool bRDGEnable; - /* for host message to fw */ u8 LastHMEBoxNum; =20 --=20 2.34.1 From nobody Wed Jul 1 04:14:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 754FBC433F5 for ; Thu, 30 Dec 2021 20:01:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242076AbhL3UBL (ORCPT ); Thu, 30 Dec 2021 15:01:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237051AbhL3UBJ (ORCPT ); Thu, 30 Dec 2021 15:01:09 -0500 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6368BC06173E for ; Thu, 30 Dec 2021 12:01:08 -0800 (PST) Received: by mail-wm1-x32e.google.com with SMTP id d198-20020a1c1dcf000000b0034569cdd2a2so13818615wmd.5 for ; Thu, 30 Dec 2021 12:01:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q6ueGjhitt5AKVe2y1vecDo+aJ407Ip2YoygN2lvWow=; b=lUjJWRIwzuq9avYjFleZFvHqEKsyrzAZZA/KJA1+TgxIduC1PQ9L0mwv6Er8sOu+l4 PVjWCLUs5p+QAlfZSvE+guw9VGRhIEeBvSpdPY8v6HpZ5+u/IqIfTINqnOOCCllnrqJ5 4HtbpnG9VgVyLUdumUB/ttNJxoOejHYaYugPgozDclGRYeTJ3z6wNl52WwKy6QGKubmq xoi4k1liWeftVZ4Ns9b4IHbZnBsy5OJchinJx5KW+yg3zBWI0vQxXtAVBKztr62tlOmL p+PhxYCu9TnMNHz+xot0nVi4DDpbr9AzvbeD1Xi0FXvlkFESCtZhHiDumwusbk7+sJPQ 2dRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q6ueGjhitt5AKVe2y1vecDo+aJ407Ip2YoygN2lvWow=; b=7vhUfquCEZhDjAcYG7srCx++9b2dvaL0kbtlmboygX2wEJGgUwbJycdGTJPc8PSr+q 2NA7nsfmaDE6TK06/iF/77DHhhucl+4pdrVKeZSARhHT2K9k8b/4WrDmUAP/oXEzsJR2 0gqmHfVKa+nRivAQuAz3uGS2UYVENu1gDF9Hj0mC1/dyAeNZNk0WIT0sdOWDQhgzz2Ud xeM5YwVToCCUs2BhBTbl80WoSx+DXZuFLGmnCJqHZBqx0D6BAaVeDjarps1VbLgdO91q iaDJmTtKW5sAPVsQ3gZz/Zm+sX1HWFU4vTe4RPga6iW/OKaYo0ox9+kMUE1lUv0THM06 ekcw== X-Gm-Message-State: AOAM533pnrIQltHuWPF+WRW6i2jbH2spp6KW9P2H/MyRRihZxDWvvWR0 CB81inZamdlGnZ//qCs80vG6B/vAtV8= X-Google-Smtp-Source: ABdhPJwYJCuNuWbv6IQMeQOBMXgAwgmi9/D3Vj51tik9Y3lsDE8f3KOAKoI5g1C7/KzHcd2ZQYtkiA== X-Received: by 2002:a7b:c08e:: with SMTP id r14mr27058656wmh.68.1640894466941; Thu, 30 Dec 2021 12:01:06 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::6619]) by smtp.gmail.com with ESMTPSA id o8sm29042286wry.20.2021.12.30.12.01.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Dec 2021 12:01:06 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 2/7] staging: r8188eu: UsbRxHighSpeedMode is set but never used Date: Thu, 30 Dec 2021 21:00:54 +0100 Message-Id: <20211230200059.13406-3-straube.linux@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20211230200059.13406-1-straube.linux@gmail.com> References: <20211230200059.13406-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The field UsbRxHighSpeedMode of struct hal_data_8188e is set but never used. Remove it. Signed-off-by: Michael Straube --- drivers/staging/r8188eu/hal/usb_halinit.c | 5 ----- drivers/staging/r8188eu/include/rtl8188e_hal.h | 3 --- 2 files changed, 8 deletions(-) diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8= 188eu/hal/usb_halinit.c index 104705ef170e..96db9a8e7667 100644 --- a/drivers/staging/r8188eu/hal/usb_halinit.c +++ b/drivers/staging/r8188eu/hal/usb_halinit.c @@ -502,16 +502,11 @@ usb_AggSettingRxUpdate( =20 static void InitUsbAggregationSetting(struct adapter *Adapter) { - struct hal_data_8188e *haldata =3D &Adapter->haldata; - /* Tx aggregation setting */ usb_AggSettingTxUpdate(Adapter); =20 /* Rx aggregation setting */ usb_AggSettingRxUpdate(Adapter); - - /* 201/12/10 MH Add for USB agg mode dynamic switch. */ - haldata->UsbRxHighSpeedMode =3D false; } =20 static void _InitOperationMode(struct adapter *Adapter) diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/stagi= ng/r8188eu/include/rtl8188e_hal.h index e8cb093abb62..8b54f52f49e2 100644 --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h @@ -262,9 +262,6 @@ struct hal_data_8188e { u8 OutEpQueueSel; u8 OutEpNumber; =20 - /* Add for USB aggreation mode dynamic shceme. */ - bool UsbRxHighSpeedMode; - /* 2010/11/22 MH Add for slim combo debug mode selective. */ /* This is used for fix the drawback of CU TSMC-A/UMC-A cut. * HW auto suspend ability. Close BT clock. */ --=20 2.34.1 From nobody Wed Jul 1 04:14:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80F21C433EF for ; Thu, 30 Dec 2021 20:01:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242088AbhL3UBN (ORCPT ); Thu, 30 Dec 2021 15:01:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242062AbhL3UBJ (ORCPT ); Thu, 30 Dec 2021 15:01:09 -0500 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D259C061574 for ; Thu, 30 Dec 2021 12:01:09 -0800 (PST) Received: by mail-wm1-x32f.google.com with SMTP id g191-20020a1c9dc8000000b0032fbf912885so13816177wme.4 for ; Thu, 30 Dec 2021 12:01:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yuJQXdVZDt3Q260m2XKqRZ/xVabItJzV8eJCp2HOE80=; b=a/qQ/BOpGTjgv1UdHnPYFHbLQT9c1Otq7B7fCxAAOEhLGhGasfJqsG+CZbxbrBuQPN k/GgA31C2adT7kcVrNI2vp4E0StqPf8WmklzT/1vrnE+BCmK21s9AXOZJkn0w1YpWAuM suLXzvJ133+wRAexS0ruxDm+pvQpGDucHDEg6vQp8P/2n6qGrYRqIEzbdDrQ6g4rRIRr Vu2tkPxl6Be5L4Qpbu57bKxUdZZ5R8emSUN3ZpP9N9k4TI0lHIsMDM9N2fM4PWs9Zt7V kUBo1z63Hwisx8mRNr2J1wjx65B/Lzv+P3QI+/Vc9KqsNaOuIqJotpy7xPUYO8QhyaRQ dyMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yuJQXdVZDt3Q260m2XKqRZ/xVabItJzV8eJCp2HOE80=; b=WkAx1HXG5yUxydp4l/X3qrtyEw7oXOCNkh8z/DBy86hDqHk2me22RizrM66rUH2SJm 7IQKF/vD/xCMbYfGbHgXuBX7NzgXqE2rgq8s5JFrV2kj3uz2lHdkMNadJb5hpPLxs/9g KmJZe1lfgL3WBw247DimB1eY4CBS/0ybnK2U+rNCRqnXWkKkLzG/fvDEXDtfDo8rDmCA r8HM88R/o2VqYF5FxAaJNwqZXNEBtQOJn4jNbC0m6HnS4Nu7qqfq+231FZymNW6vsksP msXV/aRKWt3Hx0dqwVEnMKD+hWDnutEMT6unxoEgo7evdtGv+jKdllr6XUCJ8ZYBcoBW 41pg== X-Gm-Message-State: AOAM533Jm6BRNAkb90qA6c+Tzpk5sSkl2iO4gO+dDUUHHCOGoWp3MpEt uM0nhAazpTVt3KhkhZgjHXcDJnTMlUo= X-Google-Smtp-Source: ABdhPJzTzmAEOWGto84ZQhMkPWLnYMCokESqabDX/0iYn8CqT2OWwY6JBQewb6SoVB6ETrR8CplzJg== X-Received: by 2002:a05:600c:3489:: with SMTP id a9mr26994643wmq.45.1640894467622; Thu, 30 Dec 2021 12:01:07 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::6619]) by smtp.gmail.com with ESMTPSA id o8sm29042286wry.20.2021.12.30.12.01.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Dec 2021 12:01:07 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 3/7] staging: r8188eu: bTXPowerDataReadFromEEPORM is set but never used Date: Thu, 30 Dec 2021 21:00:55 +0100 Message-Id: <20211230200059.13406-4-straube.linux@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20211230200059.13406-1-straube.linux@gmail.com> References: <20211230200059.13406-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The field bTXPowerDataReadFromEEPORM of struct hal_data_8188e is set but never used. Remove it. Signed-off-by: Michael Straube --- drivers/staging/r8188eu/hal/rtl8188e_hal_init.c | 3 --- drivers/staging/r8188eu/include/rtl8188e_hal.h | 1 - 2 files changed, 4 deletions(-) diff --git a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c b/drivers/stag= ing/r8188eu/hal/rtl8188e_hal_init.c index d8d6547465a7..065c2701077d 100644 --- a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c +++ b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c @@ -1127,9 +1127,6 @@ void Hal_ReadTxPowerInfo88E(struct adapter *padapter,= u8 *PROMContent, bool Auto =20 Hal_ReadPowerValueFromPROM_8188E(&pwrInfo24G, PROMContent, AutoLoadFail); =20 - if (!AutoLoadFail) - pHalData->bTXPowerDataReadFromEEPORM =3D true; - for (ch =3D 0; ch < CHANNEL_MAX_NUMBER; ch++) { hal_get_chnl_group_88e(ch, &group); =20 diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/stagi= ng/r8188eu/include/rtl8188e_hal.h index 8b54f52f49e2..de58c85b8bdc 100644 --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h @@ -180,7 +180,6 @@ struct hal_data_8188e { u16 EEPROMSDID; u8 EEPROMRegulatory; =20 - u8 bTXPowerDataReadFromEEPORM; u8 EEPROMThermalMeter; u8 bAPKThermalMeterIgnore; =20 --=20 2.34.1 From nobody Wed Jul 1 04:14:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C80EAC433F5 for ; Thu, 30 Dec 2021 20:01:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242113AbhL3UBQ (ORCPT ); Thu, 30 Dec 2021 15:01:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242065AbhL3UBK (ORCPT ); Thu, 30 Dec 2021 15:01:10 -0500 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E67FC06173E for ; Thu, 30 Dec 2021 12:01:09 -0800 (PST) Received: by mail-wr1-x433.google.com with SMTP id v7so52257359wrv.12 for ; Thu, 30 Dec 2021 12:01:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4eCdntbo1fpqOMRKpRxKk5VqCLi7+91tE3jKZQQIpLM=; b=Zb7JmPF/OFLUDObEsqtwc0tpUtXSoCwHBynii3bEHf/Ez/3jw3wzk4W55FZopLLSIM 6YV4gbqqASDb60kZzgXdBNHKM42cZTq0qSccuh6k9nzi1STD3i8LuckbzTtAgrRM2EWX A6aJALyKYDQhehvm17xQAOp5G3JAsiRw8b76mXoiZ3Y3dp+PC+mauH9PSRusQYnf6bre OLfI2BRshMNZj2QpGOrQ6IpQ3Y7o3oI10IToAOJGcBl+z+V7v+cnUEt3om2niJzAluAi qDhV+u+bPDY+tDiJMnhjICHJ8bWEdJs6OcPs4qaCFHL5pqJtvseA6qb11KKA/qFwmID7 +e+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4eCdntbo1fpqOMRKpRxKk5VqCLi7+91tE3jKZQQIpLM=; b=RneCKgStaYmYGfkMHOG3n3NEIrRdu//STzfcUoZ8B1ObVW8CblB/4RcB7NUiRjKN8O iT7m1BCFQRlr7qe+e7gNGy4j+s5Zvew8H7tPKA181W8oWsqX2vGsO6YrQuDunVT7vjFP vaQNDhqp6ztWzmSOviEb0SXLD58zp4qWGzJf2E/32DeH1yB4vIbmoip7H6tiz0LQtpxd eZHTohta6irUfmfceM1dJlr0yPUB8pFdqHDJ3wvmHmk70LyXp4cYt3E5FnSk7s8SZy52 NChyNRfWwpFwCzzS5jNQwQTp9G+yCPnXMCquooBIPBX1pWvQrYq1ZixFjd9ruRj7oKLm 6EEQ== X-Gm-Message-State: AOAM532S30CHbLXFpY2ejZ8DJ43mOzrYaq8W2HfTI4vTLzMMqs+sBs0k rGczq8ToRv33tjuTlwO6HH8= X-Google-Smtp-Source: ABdhPJxP+zzzLjXOP2uYo44csOHEbeJ1PXAddp0HVDH7XBbtp0K1A7dKLG7EGNNhWT+v1shTDTR0Tg== X-Received: by 2002:a5d:5547:: with SMTP id g7mr16614764wrw.551.1640894468326; Thu, 30 Dec 2021 12:01:08 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::6619]) by smtp.gmail.com with ESMTPSA id o8sm29042286wry.20.2021.12.30.12.01.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Dec 2021 12:01:08 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 4/7] staging: r8188eu: bAPKThermalMeterIgnore is set but never used Date: Thu, 30 Dec 2021 21:00:56 +0100 Message-Id: <20211230200059.13406-5-straube.linux@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20211230200059.13406-1-straube.linux@gmail.com> References: <20211230200059.13406-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The field bAPKThermalMeterIgnore of struct hal_data_8188e is set but never used. Remove it. Signed-off-by: Michael Straube --- drivers/staging/r8188eu/hal/rtl8188e_hal_init.c | 5 ++--- drivers/staging/r8188eu/include/rtl8188e_hal.h | 1 - 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c b/drivers/stag= ing/r8188eu/hal/rtl8188e_hal_init.c index 065c2701077d..cce291ca44b1 100644 --- a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c +++ b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c @@ -1230,9 +1230,8 @@ void Hal_ReadThermalMeter_88E(struct adapter *Adapter= , u8 *PROMContent, bool Aut else pHalData->EEPROMThermalMeter =3D EEPROM_Default_ThermalMeter_88E; =20 - if (pHalData->EEPROMThermalMeter =3D=3D 0xff || AutoloadFail) { - pHalData->bAPKThermalMeterIgnore =3D true; + if (pHalData->EEPROMThermalMeter =3D=3D 0xff || AutoloadFail) pHalData->EEPROMThermalMeter =3D EEPROM_Default_ThermalMeter_88E; - } + DBG_88E("ThermalMeter =3D 0x%x\n", pHalData->EEPROMThermalMeter); } diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/stagi= ng/r8188eu/include/rtl8188e_hal.h index de58c85b8bdc..40b3db34b8f2 100644 --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h @@ -181,7 +181,6 @@ struct hal_data_8188e { u8 EEPROMRegulatory; =20 u8 EEPROMThermalMeter; - u8 bAPKThermalMeterIgnore; =20 bool EepromOrEfuse; =20 --=20 2.34.1 From nobody Wed Jul 1 04:14:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8CEFC433EF for ; Thu, 30 Dec 2021 20:01:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242092AbhL3UBS (ORCPT ); Thu, 30 Dec 2021 15:01:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242069AbhL3UBK (ORCPT ); Thu, 30 Dec 2021 15:01:10 -0500 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6ABDAC061574 for ; Thu, 30 Dec 2021 12:01:10 -0800 (PST) Received: by mail-wr1-x429.google.com with SMTP id a9so52283476wrr.8 for ; Thu, 30 Dec 2021 12:01:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=B1vSJDEPA92WJZ+OLUXTW8AO9oxcwVbu51WrMzfIzm0=; b=Kom2npQpWrk9ZTSpsGA3lB3KehkgszsYsoJCTXU+m+XFDxqNy+47PaJclLShkoy4BU Jg+tykmOBvhDnZ5uoOtvCAZeHT0AIM/ltpIcVywDuy3WjlrHoRFjhjcwMO7vWVo1/a8s qawjIaWaX01HeKIVOr0z4lQEBtQtBjLJp9vEmdxQNsFl1GaoXG0/CW+g1bt2cQkNR/J0 z3J1cq2ZaGWS3fflxx3aX2mwcafZgaZSWWi/SX9JRE9BB8mCFGp1WnZMcq4+um3Z+e6B btXDIVsz82T1eAya6iFUY55sCVpPOfmdb46Z+AAJvaJQgk1ggGFlkI3a25go92mvSLiT zd+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=B1vSJDEPA92WJZ+OLUXTW8AO9oxcwVbu51WrMzfIzm0=; b=CnaejzP5d90bkzPo2dwi3QhLBdFApCYbs8m0OgU02mtSrv3Czmy8VGTkiK0cUpvkpM BGn0OxmOIs2F+psXHe2SCjPzyzrboaZI08jd/cOPLNDOehYOUT/GWKuulS5Rj9yunRKn rfsGcbNA3HvtBP3YMDSaU485zjHe2G5GdZ3MJ8qmf4g83ASaMRFik4hcXrhb8WyfKoy0 b6f45SzVqvFjTtGa84kZGdWCwJojRrHF35EFAWNTbCCId3xa9nz+exSyl1Ahaaasq3JB 6eaC3cN1XlmZV7UhW8QiDHaOSALLvrGMRiW02/XWmWi+cgy/cv9PfSrGwEGrf2RizF0Y +t+g== X-Gm-Message-State: AOAM531P9NJS+3hM0MC/zDfaSIy7vAEPWWRcDdRKAGdzPiHmle1Zp6hx QYg7YvjRfCQ7OVTENtJBdhk= X-Google-Smtp-Source: ABdhPJxWGGxzUblQgB4eK/E0Aux7Ry6+fWaVirWaA+gqIoZGHU9jEZje2S76ltgf3nS69CKoXcxuzw== X-Received: by 2002:adf:b60e:: with SMTP id f14mr2604087wre.11.1640894469031; Thu, 30 Dec 2021 12:01:09 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::6619]) by smtp.gmail.com with ESMTPSA id o8sm29042286wry.20.2021.12.30.12.01.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Dec 2021 12:01:08 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 5/7] staging: r8188eu: remove unused fields from struct hal_data_8188e Date: Thu, 30 Dec 2021 21:00:57 +0100 Message-Id: <20211230200059.13406-6-straube.linux@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20211230200059.13406-1-straube.linux@gmail.com> References: <20211230200059.13406-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove unused fields from struct hal_data_8188e. Signed-off-by: Michael Straube --- .../staging/r8188eu/include/rtl8188e_hal.h | 30 ------------------- 1 file changed, 30 deletions(-) diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/stagi= ng/r8188eu/include/rtl8188e_hal.h index 40b3db34b8f2..2ce42d647a34 100644 --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h @@ -175,15 +175,9 @@ struct hal_data_8188e { =20 u16 BasicRateSet; =20 - /* EEPROM setting. */ - u16 EEPROMSVID; - u16 EEPROMSDID; u8 EEPROMRegulatory; - u8 EEPROMThermalMeter; =20 - bool EepromOrEfuse; - u8 Index24G_CCK_Base[RF_PATH_MAX][CHANNEL_MAX_NUMBER]; u8 Index24G_BW40_Base[RF_PATH_MAX][CHANNEL_MAX_NUMBER]; /* If only one tx, only BW20 and OFDM are used. */ @@ -192,11 +186,6 @@ struct hal_data_8188e { s8 BW20_24G_Diff[RF_PATH_MAX][MAX_TX_COUNT]; s8 BW40_24G_Diff[RF_PATH_MAX][MAX_TX_COUNT]; =20 - u8 TxPwrLevelCck[RF_PATH_MAX][CHANNEL_MAX_NUMBER]; - /* For HT 40MHZ pwr */ - u8 TxPwrLevelHT40_1S[RF_PATH_MAX][CHANNEL_MAX_NUMBER]; - /* For HT 40MHZ pwr */ - u8 TxPwrLevelHT40_2S[RF_PATH_MAX][CHANNEL_MAX_NUMBER]; /* HT 20<->40 Pwr diff */ u8 TxPwrHt20Diff[RF_PATH_MAX][CHANNEL_MAX_NUMBER]; /* For HT<->legacy pwr diff */ @@ -205,7 +194,6 @@ struct hal_data_8188e { u8 PwrGroupHT20[RF_PATH_MAX][CHANNEL_MAX_NUMBER]; u8 PwrGroupHT40[RF_PATH_MAX][CHANNEL_MAX_NUMBER]; =20 - u8 LegacyHTTxPowerDiff;/* Legacy to HT rate power diff */ /* The current Tx Power Level */ u8 CurrentCckTxPwrIdx; u8 CurrentOfdm24GTxPwrIdx; @@ -213,21 +201,12 @@ struct hal_data_8188e { u8 CurrentBW4024GTxPwrIdx; =20 /* Read/write are allow for following hardware information variables */ - u8 framesync; - u32 framesyncC34; - u8 framesyncMonitor; - u8 DefaultInitialGain[4]; u8 pwrGroupCnt; u32 MCSTxPowerLevelOriginalOffset[MAX_PG_GROUP][16]; - u32 CCKTxPowerLevelOriginalOffset; =20 u8 CrystalCap; - u32 AntennaTxPath; /* Antenna path Tx */ - u32 AntennaRxPath; /* Antenna path Rx */ u8 ExternalPA; =20 - u8 b1x1RecvCombine; /* for 1T1R receive combining */ - u32 AcParam_BE; /* Original parameter for BE, use for EDCA turbo. */ =20 struct bb_reg_def PHYRegDef[2]; /* Radio A/B */ @@ -254,17 +233,9 @@ struct hal_data_8188e { u8 FwRsvdPageStartOffset; /* Reserve page start offset except * beacon in TxQ. */ =20 - /* 2010/08/09 MH Add CU power down mode. */ - bool pwrdown; - u8 OutEpQueueSel; u8 OutEpNumber; =20 - /* 2010/11/22 MH Add for slim combo debug mode selective. */ - /* This is used for fix the drawback of CU TSMC-A/UMC-A cut. - * HW auto suspend ability. Close BT clock. */ - bool SlimComboDbg; - u16 EfuseUsedBytes; =20 struct P2P_PS_Offload_t p2p_ps_offload; @@ -280,7 +251,6 @@ struct hal_data_8188e { u8 C2hArray[16]; u8 UsbTxAggMode; u8 UsbTxAggDescNum; - u32 MaxUsbRxAggBlock; =20 enum usb_rx_agg_mode UsbRxAggMode; u8 UsbRxAggBlockCount; /* USB Block count. Block size is --=20 2.34.1 From nobody Wed Jul 1 04:14:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75530C433FE for ; Thu, 30 Dec 2021 20:01:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242100AbhL3UBU (ORCPT ); Thu, 30 Dec 2021 15:01:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242080AbhL3UBL (ORCPT ); Thu, 30 Dec 2021 15:01:11 -0500 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54C10C061574 for ; Thu, 30 Dec 2021 12:01:11 -0800 (PST) Received: by mail-wm1-x329.google.com with SMTP id a203-20020a1c7fd4000000b003457874263aso16563149wmd.2 for ; Thu, 30 Dec 2021 12:01:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5CtCwwPsCao8kkeRXV1Zww5XYrsoEXQXIXV3u2Cd1x4=; b=fKJE5tHF/wWzzTMnhcAO2od0kiS1rsPcb+5qwSGYe2uaF2LJAfClResc8KPEKhJPeQ mMoCcHuwYc0wqRAD1Ggp5NuFoU9d4mMnw3UWDZStchayTuaAC/2MDS6irJwLSfHcvUiw KbDu1xNHMrcpp/HptDW75IjelYVgK+Dy79AJbjKyav8W8k47wvoRFJm0ObuWc42rDy8c m76V1sHE70apbb0joGOFL3rq47vv2KqI3htgTf4ZjedVT9Ifkogj8+ib2lTZVS0VQGvI uaxrApeZJ+/0JyoqptWK46+Z/S4oVsApNVwGLlxqmwiu0KIxrv2HqN+eGhzljN6wKSUj n7yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5CtCwwPsCao8kkeRXV1Zww5XYrsoEXQXIXV3u2Cd1x4=; b=a7ELztjaSmuAk3FEkj6YnOI4TPefN0Wod0gnm9arZA1AZV5cXEzMaIzKhEZ2WrDbEN F76O9zzTPYeOBnjZF8oBvbjaTWCU088BRn2JrGzUnCzakVJn2I5ZXSTpmZ3X/d+os8Dn 9q/JCIBZdknLAwYjIr1us7B9k0I8apeJNjPhietqMYIYfinQxOM95+kA/LKyFH5vKY3h O1zG52W/4pHlVa4l/KRYzXEnA0fgC1ABDyl6PI8PsHPOZOyeY5M8QQY/TJ+IlZ0OrmsH pkCUPgciAQmVsi1bXWDbdkkuOeMhOX0nuL51O7vbGYRMLa8UQOWu0t+GPt3M0/ih4Akr jE9A== X-Gm-Message-State: AOAM531SCoUvyxrQ+v7A8RCE3GW1RNfweyktHHRPJG81qFSWTgIaThhL fd111MScyZKG/eUuWF6pmZ4= X-Google-Smtp-Source: ABdhPJyKE7LoeS4OkyEwk4Pv3xU+Wioc8bGJ0Y7C+SGbwCUwusJZHlxkojJD+zJU96u2ISRsNR5LoQ== X-Received: by 2002:a1c:494:: with SMTP id 142mr27836964wme.191.1640894469710; Thu, 30 Dec 2021 12:01:09 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::6619]) by smtp.gmail.com with ESMTPSA id o8sm29042286wry.20.2021.12.30.12.01.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Dec 2021 12:01:09 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 6/7] staging: r8188eu: IntArray and C2hArray are set but never used Date: Thu, 30 Dec 2021 21:00:58 +0100 Message-Id: <20211230200059.13406-7-straube.linux@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20211230200059.13406-1-straube.linux@gmail.com> References: <20211230200059.13406-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The fields IntArray and C2hArray of struct hal_data_8188e are set but never used. Remove them. While at it, remove the unsed defines USB_INTR_CONTENT_CPWM1_OFFSET and USB_INTR_CONTENT_CPWM2_OFFSET as well. Signed-off-by: Michael Straube --- drivers/staging/r8188eu/hal/usb_ops_linux.c | 10 ---------- drivers/staging/r8188eu/include/rtl8188e_hal.h | 3 --- drivers/staging/r8188eu/include/rtl8188e_spec.h | 7 ------- 3 files changed, 20 deletions(-) diff --git a/drivers/staging/r8188eu/hal/usb_ops_linux.c b/drivers/staging/= r8188eu/hal/usb_ops_linux.c index 9ec55a77dccd..85bcde5ee79a 100644 --- a/drivers/staging/r8188eu/hal/usb_ops_linux.c +++ b/drivers/staging/r8188eu/hal/usb_ops_linux.c @@ -185,20 +185,10 @@ int rtw_writeN(struct adapter *adapter, u32 addr, u32= length, u8 *data) =20 static void interrupt_handler_8188eu(struct adapter *adapt, u16 pkt_len, u= 8 *pbuf) { - struct hal_data_8188e *haldata =3D &adapt->haldata; - if (pkt_len !=3D INTERRUPT_MSG_FORMAT_LEN) { DBG_88E("%s Invalid interrupt content length (%d)!\n", __func__, pkt_len= ); return; } - - /* HISR */ - memcpy(&haldata->IntArray[0], &pbuf[USB_INTR_CONTENT_HISR_OFFSET], 4); - memcpy(&haldata->IntArray[1], &pbuf[USB_INTR_CONTENT_HISRE_OFFSET], 4); - - /* C2H Event */ - if (pbuf[0] !=3D 0) - memcpy(&haldata->C2hArray[0], &pbuf[USB_INTR_CONTENT_C2H_OFFSET], 16); } =20 static int recvbuf2recvframe(struct adapter *adapt, struct sk_buff *pskb) diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/stagi= ng/r8188eu/include/rtl8188e_hal.h index 2ce42d647a34..239d0db55639 100644 --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h @@ -246,9 +246,6 @@ struct hal_data_8188e { =20 u32 UsbBulkOutSize; =20 - /* Interrupt relatd register information. */ - u32 IntArray[3];/* HISR0,HISR1,HSISR */ - u8 C2hArray[16]; u8 UsbTxAggMode; u8 UsbTxAggDescNum; =20 diff --git a/drivers/staging/r8188eu/include/rtl8188e_spec.h b/drivers/stag= ing/r8188eu/include/rtl8188e_spec.h index e59fd2fe82c5..009222b4a95d 100644 --- a/drivers/staging/r8188eu/include/rtl8188e_spec.h +++ b/drivers/staging/r8188eu/include/rtl8188e_spec.h @@ -475,13 +475,6 @@ Default: 00b. #define MSR_INFRA 0x02 #define MSR_AP 0x03 =20 -/* 88EU (MSR) Media Status Register (Offset 0x4C, 8 bits) */ -#define USB_INTR_CONTENT_C2H_OFFSET 0 -#define USB_INTR_CONTENT_CPWM1_OFFSET 16 -#define USB_INTR_CONTENT_CPWM2_OFFSET 20 -#define USB_INTR_CONTENT_HISR_OFFSET 48 -#define USB_INTR_CONTENT_HISRE_OFFSET 52 - /* 88E Driver Initialization Offload REG_FDHM0(Offset 0x88, 8 bits) */ /* IOL config for REG_FDHM0(Reg0x88) */ #define CMD_INIT_LLT BIT(0) --=20 2.34.1 From nobody Wed Jul 1 04:14:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71AAAC433F5 for ; Thu, 30 Dec 2021 20:01:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242114AbhL3UBX (ORCPT ); Thu, 30 Dec 2021 15:01:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242079AbhL3UBM (ORCPT ); Thu, 30 Dec 2021 15:01:12 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8B20C06173E for ; Thu, 30 Dec 2021 12:01:11 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id v11so52380336wrw.10 for ; Thu, 30 Dec 2021 12:01:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SxBAyfnlWCSVSWlKHhb9lVTqDDEl0PwfIm0RriFdcEU=; b=Uq07Y+CTPgl4iJGQJeSFZIYDoa2RSt3SJdAULbfsVgp42Cyv8q8g6vqvM/ZFTlRw7n d4H3FSMmMG712eKjpyPezAQTaLsJ5AGO0wE+AADugVpVRUxp+fadg1iO55IMO/tS3ZxT IyJ3tSLZZBoQQPxvA59lB32KQx86vFO4RwhMUpC+hcnDRUNS+HIv5WZiYCouPm3H6H/T zBbwc7VFtGrlbFQifMOahI8zqj6uG33Xr8D0dRtvxBNfj0Ao7YVgXq2CRn2mXn6fyQPi XKmaDFbrbYiU2onGPyKXW7kem1LmuDgjiSADDA1W55G6PzLpR3Vc0oX2acYK1hrcuGT0 qjDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SxBAyfnlWCSVSWlKHhb9lVTqDDEl0PwfIm0RriFdcEU=; b=ntD0JfMv/bTj+hbQd8sABSnix43IPsuvKfdzqrNoYHvWSaB7IeagQr5zuR2dnGFkpw JxL9ZpfA38oHXX/SLOaKwoSYpMFRJxSq5x99L9lVJtBlfnNyNewkOM6jVGyovNBAvKRR zlv1D/OHzu03knElxCnZBbNqZzjDJCF7n1XSbyVzU07aFeCe6wMVi708wWKztFZwkOKi 5tCkKdcAy1HEySCBb5IXLiwQzlT6i28mB/W7lhciSJmyhFx6V1ZCl2VRrEBlRJ4nak83 n/+uSQR5kBV8IXlisr+gCDjM///HpYbhEU/R9SSEhHKplfpa6RGZa7oJM07x/U0i9paV WBbw== X-Gm-Message-State: AOAM532FjjtoOxC+MjC+q9tX2wr0p3pERZfNdrkoxpn/8K8ZaBC0zQCA SwbDn8/AQuIdb2UENMJkUMM= X-Google-Smtp-Source: ABdhPJz25IenNzkMGCPTIHnURmA31HLCCYj5aQTJh92hGu4l72n8pLmnGsgvXOSPsSXnMTWZOyEzKQ== X-Received: by 2002:a05:6000:1787:: with SMTP id e7mr27249908wrg.31.1640894470418; Thu, 30 Dec 2021 12:01:10 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::6619]) by smtp.gmail.com with ESMTPSA id o8sm29042286wry.20.2021.12.30.12.01.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Dec 2021 12:01:10 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 7/7] staging: r8188eu: FwRsvdPageStartOffset is set but never used Date: Thu, 30 Dec 2021 21:00:59 +0100 Message-Id: <20211230200059.13406-8-straube.linux@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20211230200059.13406-1-straube.linux@gmail.com> References: <20211230200059.13406-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The field FwRsvdPageStartOffset of struct hal_data_8188e is set but never used. Remove it. Signed-off-by: Michael Straube --- drivers/staging/r8188eu/hal/rtl8188e_cmd.c | 3 --- drivers/staging/r8188eu/include/rtl8188e_hal.h | 2 -- 2 files changed, 5 deletions(-) diff --git a/drivers/staging/r8188eu/hal/rtl8188e_cmd.c b/drivers/staging/r= 8188eu/hal/rtl8188e_cmd.c index ca24e17c369d..a491c37777df 100644 --- a/drivers/staging/r8188eu/hal/rtl8188e_cmd.c +++ b/drivers/staging/r8188eu/hal/rtl8188e_cmd.c @@ -440,7 +440,6 @@ void CheckFwRsvdPageContent(struct adapter *Adapter) /* 2009.10.15 by tynli. */ static void SetFwRsvdPagePkt(struct adapter *adapt, bool bDLFinished) { - struct hal_data_8188e *haldata; struct xmit_frame *pmgntframe; struct pkt_attrib *pattrib; struct xmit_priv *pxmitpriv; @@ -461,7 +460,6 @@ static void SetFwRsvdPagePkt(struct adapter *adapt, boo= l bDLFinished) return; } =20 - haldata =3D &adapt->haldata; pxmitpriv =3D &adapt->xmitpriv; pmlmeext =3D &adapt->mlmeextpriv; pmlmeinfo =3D &pmlmeext->mlmext_info; @@ -480,7 +478,6 @@ static void SetFwRsvdPagePkt(struct adapter *adapt, boo= l bDLFinished) if (PageNeed =3D=3D 1) PageNeed +=3D 1; PageNum +=3D PageNeed; - haldata->FwRsvdPageStartOffset =3D PageNum; =20 BufIndex +=3D PageNeed * 128; =20 diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/stagi= ng/r8188eu/include/rtl8188e_hal.h index 239d0db55639..25f3c04e81b7 100644 --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h @@ -230,8 +230,6 @@ struct hal_data_8188e { =20 u8 bDumpRxPkt;/* for debug */ u8 bDumpTxPkt;/* for debug */ - u8 FwRsvdPageStartOffset; /* Reserve page start offset except - * beacon in TxQ. */ =20 u8 OutEpQueueSel; u8 OutEpNumber; --=20 2.34.1