From nobody Wed Jul 1 06:46:22 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8C41C433F5 for ; Tue, 28 Dec 2021 10:11:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233585AbhL1KLr (ORCPT ); Tue, 28 Dec 2021 05:11:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233380AbhL1KLp (ORCPT ); Tue, 28 Dec 2021 05:11:45 -0500 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46848C061574 for ; Tue, 28 Dec 2021 02:11:45 -0800 (PST) Received: by mail-wm1-x333.google.com with SMTP id e5so10862346wmq.1 for ; Tue, 28 Dec 2021 02:11:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yuaztYvPHWrZ6c/Uw5eoLffstSdeo51VPiTo6JhL6Gw=; b=pNHP90HtuH/0E6Tyzikwa3xEmGdz37G4XeMVnHumnNqdwDpSN1gcm7ylk66aGjaB/Y EHjL/tCsNUOu+mdvWGAdQYwzRq3oIKVFEL9Tp56EXHUr2c491E09zPjbBBc32BGI5SEM MUcdIhXyvE72HTCfSO+fGUNad9TvZaDy5xvQcYCx3BzfP7sOjoRSk7gBjNbbOiXJzBZT 0oLSStY5amVq5n1MZkoMJ139GEMhoFrhHeAAw/+5IoJiUwLLFFdDrTn/dqgLI2gDfCPR 5mPnOSycAUnoaNEc37+9N9Kn+IoB9KZAx6/kAFv85ebwYTi6LiWZicdWILx3HFz3bjuD W9pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yuaztYvPHWrZ6c/Uw5eoLffstSdeo51VPiTo6JhL6Gw=; b=iDeHHqQUJZyb7lyGfrTUVahYSRgxEi9YnrAg4eae0EkMYzO0nmlGqR63XmAMrva5zI smTPd6SlzG20txlx0tC0WDcpmYfJl/SJuztrr4nwWttee5CoeZUsVDRERnHAIj+0AZIb 1FaA6QxTsrrfpGnKCz2Tb+mokZNrbedmz2CmTU3BlGKnlQ0VCCQb2Ge89QNI7yyST+jM lEeP4vNVmHdVBBORIOXyrJQTUIqY0u/kXgRGnoVLnQ340iUMQf1ol2ExZum0iz4yBhEK gi6gw2egknhZYax0qNCZx3QvcYkNcY0DbB0pXOuI5fpgBtgiHZ9TqXt+pa+vnhQJ83dQ NxMQ== X-Gm-Message-State: AOAM532nGtant3PGh8eSFYeTATS1br4BN0a8n2f9j0i3L7c26FUOU0HX VbZrVpa4NC31r5cVtROIYGQ= X-Google-Smtp-Source: ABdhPJxNMozG3p9MRQ8D/blBHymENSelCHy1aTypedvv2Fij5RJsOROZb5bTsCoJULhmYXTlC/skfA== X-Received: by 2002:a05:600c:2f01:: with SMTP id r1mr17018955wmn.153.1640686303912; Tue, 28 Dec 2021 02:11:43 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::6619]) by smtp.gmail.com with ESMTPSA id d62sm21160984wmd.3.2021.12.28.02.11.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Dec 2021 02:11:43 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube , Martin Kaiser Subject: [PATCH 01/10] staging: r8188eu: DM_PriCCA is set but never used Date: Tue, 28 Dec 2021 11:11:11 +0100 Message-Id: <20211228101120.9120-2-straube.linux@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20211228101120.9120-1-straube.linux@gmail.com> References: <20211228101120.9120-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The field DM_PriCCA of struct odm_dm_struct is set but never used. Remove it and remove related dead code. Acked-by: Martin Kaiser Signed-off-by: Michael Straube --- drivers/staging/r8188eu/hal/odm.c | 1 - drivers/staging/r8188eu/hal/odm_RTL8188E.c | 15 --------------- drivers/staging/r8188eu/include/odm.h | 9 --------- drivers/staging/r8188eu/include/odm_RTL8188E.h | 2 -- 4 files changed, 27 deletions(-) diff --git a/drivers/staging/r8188eu/hal/odm.c b/drivers/staging/r8188eu/ha= l/odm.c index 7a42687b3128..a820bdc26fbc 100644 --- a/drivers/staging/r8188eu/hal/odm.c +++ b/drivers/staging/r8188eu/hal/odm.c @@ -152,7 +152,6 @@ void ODM_DMInit(struct odm_dm_struct *pDM_Odm) odm_DIGInit(pDM_Odm); odm_RateAdaptiveMaskInit(pDM_Odm); =20 - odm_PrimaryCCA_Init(pDM_Odm); /* Gary */ odm_DynamicBBPowerSavingInit(pDM_Odm); odm_TXPowerTrackingInit(pDM_Odm); ODM_EdcaTurboInit(pDM_Odm); diff --git a/drivers/staging/r8188eu/hal/odm_RTL8188E.c b/drivers/staging/r= 8188eu/hal/odm_RTL8188E.c index 8af45c7535ea..34530fcd00d8 100644 --- a/drivers/staging/r8188eu/hal/odm_RTL8188E.c +++ b/drivers/staging/r8188eu/hal/odm_RTL8188E.c @@ -260,18 +260,3 @@ void ODM_AntennaDiversity_88E(struct odm_dm_struct *dm= _odm) if ((dm_odm->AntDivType =3D=3D CG_TRX_HW_ANTDIV) || (dm_odm->AntDivType = =3D=3D CGCS_RX_HW_ANTDIV)) odm_HWAntDiv(dm_odm); } - -/* 3=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */ -/* 3 Dynamic Primary CCA */ -/* 3=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */ - -void odm_PrimaryCCA_Init(struct odm_dm_struct *dm_odm) -{ - struct dyn_primary_cca *PrimaryCCA =3D &dm_odm->DM_PriCCA; - - PrimaryCCA->dup_rts_flag =3D 0; - PrimaryCCA->intf_flag =3D 0; - PrimaryCCA->intf_type =3D 0; - PrimaryCCA->monitor_flag =3D 0; - PrimaryCCA->pri_cca_flag =3D 0; -} diff --git a/drivers/staging/r8188eu/include/odm.h b/drivers/staging/r8188e= u/include/odm.h index 19e859b989ad..306640e92e6f 100644 --- a/drivers/staging/r8188eu/include/odm.h +++ b/drivers/staging/r8188eu/include/odm.h @@ -81,14 +81,6 @@ struct false_alarm_stats { u32 Cnt_BW_LSC; /* Gary */ }; =20 -struct dyn_primary_cca { - u8 pri_cca_flag; - u8 intf_flag; - u8 intf_type; - u8 dup_rts_flag; - u8 monitor_flag; -}; - struct rx_hpc { u8 RXHP_flag; u8 PSD_func_trigger; @@ -487,7 +479,6 @@ struct odm_dm_struct { struct fast_ant_train DM_FatTable; struct rtw_dig DM_DigTable; struct rtl_ps DM_PSTable; - struct dyn_primary_cca DM_PriCCA; struct false_alarm_stats FalseAlmCnt; struct sw_ant_switch DM_SWAT_Table; bool RSSI_test; diff --git a/drivers/staging/r8188eu/include/odm_RTL8188E.h b/drivers/stagi= ng/r8188eu/include/odm_RTL8188E.h index 96e50c9224aa..85a0d7ec7378 100644 --- a/drivers/staging/r8188eu/include/odm_RTL8188E.h +++ b/drivers/staging/r8188eu/include/odm_RTL8188E.h @@ -29,6 +29,4 @@ void odm_FastAntTrainingCallback(struct odm_dm_struct *pD= M_Odm); =20 void odm_FastAntTrainingWorkItemCallback(struct odm_dm_struct *pDM_Odm); =20 -void odm_PrimaryCCA_Init(struct odm_dm_struct *pDM_Odm); - #endif --=20 2.34.1 From nobody Wed Jul 1 06:46:22 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83D92C433EF for ; Tue, 28 Dec 2021 10:11:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233671AbhL1KLt (ORCPT ); Tue, 28 Dec 2021 05:11:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229915AbhL1KLq (ORCPT ); Tue, 28 Dec 2021 05:11:46 -0500 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02987C061574 for ; Tue, 28 Dec 2021 02:11:46 -0800 (PST) Received: by mail-wm1-x32c.google.com with SMTP id bg19-20020a05600c3c9300b0034565e837b6so6096361wmb.1 for ; Tue, 28 Dec 2021 02:11:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=j1aFnyHFUtPdBZotM5iBED56xT2FvKcAtJi+DzbG5wA=; b=ZOTCc8hb63q9418FaiqBdAUzCMOI6zc8pbICndChUVCr4dtLo6I3GJ3QWC+M/y1IvR +UuAgaTdIxNxLsfGyhO7L11pxIS3N9mribQQ7Gpk7POSfOi7nXNi510yYOA0g81LKFbC ZNGy3sw4hhsX4FWdCvLVCZA2RmgsoV1phDWLw4xHc60UgfB6mXKK3DN1vNa90k6vQbSy 5XyFizqrlg1FrlD68qmnUzgXvq/2bNIiKo4E6SIDry5jOL7n+VpEJnSiw4XWLH+2WaCR h8mBeho8soputU3nud86sKfP8qvaC7bA8r1/ZuNb0xLDLGQYAWTKJ9b5j9w9AXlL0kTN Dtjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=j1aFnyHFUtPdBZotM5iBED56xT2FvKcAtJi+DzbG5wA=; b=2HDOqhf8uUP3ft6fAKnsMQmAOIF0cz1mTwKlerCEHcNXNhmTUdq2Po78lBTRlDBd4D bu3tY+mYXe3rgRLH3KfoKwoBgf13C50zu7weYaGS4ULa83Hl/0IpkpQ2IWQ0m8VZv6Ws D154RVZHr2aMigWn42IecW2RPvh/x67eIzcIrrWFuaq66VfKlwS4b20yk0Os3D6ufsqK vI0dk/drFl1tEyTpW2JnyRFtVEIby/RW/DzknOXH1p8K7LjeoR8/VlJEPVclBuesHSGs G9PO+UhblrrkAXLdq7LcNbiWnDVAscSzOvwVpuVRrSII17dSd4l9QyxE0U5Jz20nbTCu 8A1w== X-Gm-Message-State: AOAM5314Df+EmLoYw3a0K+VR6+jw+J5YN3JgNbRh3zC2SF6yEAVVPnxb np1/EqoQERs0MTmIDD0DRg2FhZl3wGk= X-Google-Smtp-Source: ABdhPJzWbaHSeTVaieSdzN6jiQhmL/D+iZDpgSpCs7saI+O3cowFz3vUnff9dAQYLqHbvNIAHzbdFg== X-Received: by 2002:a7b:c249:: with SMTP id b9mr16269975wmj.159.1640686304626; Tue, 28 Dec 2021 02:11:44 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::6619]) by smtp.gmail.com with ESMTPSA id d62sm21160984wmd.3.2021.12.28.02.11.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Dec 2021 02:11:44 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 02/10] staging: r8188eu: remove GET_CVID_ROM_VERSION Date: Tue, 28 Dec 2021 11:11:12 +0100 Message-Id: <20211228101120.9120-3-straube.linux@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20211228101120.9120-1-straube.linux@gmail.com> References: <20211228101120.9120-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The macro GET_CVID_ROM_VERSION is not used. Remove it. Signed-off-by: Michael Straube --- drivers/staging/r8188eu/include/HalVerDef.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/r8188eu/include/HalVerDef.h b/drivers/staging/= r8188eu/include/HalVerDef.h index 1d96657e6a98..62b94c993f0d 100644 --- a/drivers/staging/r8188eu/include/HalVerDef.h +++ b/drivers/staging/r8188eu/include/HalVerDef.h @@ -35,7 +35,6 @@ struct HAL_VERSION { #define GET_CVID_CHIP_TYPE(version) (((version).ChipType)) #define GET_CVID_MANUFACTUER(version) (((version).VendorType)) #define GET_CVID_CUT_VERSION(version) (((version).CUTVersion)) -#define GET_CVID_ROM_VERSION(version) (((version).ROMVer) & ROM_VERSION_MA= SK) =20 /* Common Macro. -- */ /* HAL_VERSION VersionID */ --=20 2.34.1 From nobody Wed Jul 1 06:46:22 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBC31C433F5 for ; Tue, 28 Dec 2021 10:11:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233754AbhL1KLv (ORCPT ); Tue, 28 Dec 2021 05:11:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233514AbhL1KLr (ORCPT ); Tue, 28 Dec 2021 05:11:47 -0500 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D789C061574 for ; Tue, 28 Dec 2021 02:11:46 -0800 (PST) Received: by mail-wm1-x334.google.com with SMTP id g132so11282604wmg.2 for ; Tue, 28 Dec 2021 02:11:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6D1iaBgXOAkMH79XbQmEXP2lg5qLQCLAwgOT3lAeyto=; b=Z+y2pUBKzPmhUx+ckpypbI7V5e5qxPTwHOYjxD99edIv+rPd2dXxEvmtHSJGMZ6G/X nSfHblY4jOYTIUhbsK+pouhBUiMO7G5sxumbypOUjZxAHrsBqeSpAnh5yLbxQ/+o5gVh rr4kRVPRZZR64WtaloTArMCV6bBifOaWMVpnD29i+19N+JG4w32Vf7fHsrAuZHJyk5M/ VTgRMZgRcxkSCUI389XSyHc8Nze9rBWQv6gLj9Mxxm7KugawAb1YRVjzrxvb3voZOOn1 Z3gk8aKRPkxhcURuRdUuVqQztmm6PSe25CMNJ8JiImplDAYLn6K8JR9uT8kgMyjXEUcO aYJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6D1iaBgXOAkMH79XbQmEXP2lg5qLQCLAwgOT3lAeyto=; b=wqGThu8nASGHK8JObjmFp1mLeJEUfEM784qPeucuWdzFq4PNjGkJXEm1WvCErW6Eaq Ko8VNgMubNWzJQ+GHJs02xTHMc5/hPpfTg+KOYxJNNiTEW1ylFDY0I1/TrGLv21lb/lD s3UVDRsQ6FoiNP6/eFGRKCyelidY6qiteroDKmRBqRHvDITovEVqSMNEjyqTtWnjZYxO eBIZP/EX8UKcGMhn4eRSQzSip24ikfc2ehkKUz+473MtTEpIegDVogLb4fmg//VLYJSR lJ5ZzV6iscKpejHkNiJQGaXIVWm1cc0aWQuj08vbFGcbGE9Xo/crTzPRp+7SltEAFeKW 55MA== X-Gm-Message-State: AOAM530jrkxFy6ip0mcUOgvooAjJ9tKslu08cLShqBZxrwUhxv6bpWeU hT9DS3lf3hPrltPyBEJayPo= X-Google-Smtp-Source: ABdhPJzxesYcWBNYIQx1hTR8/D8SgTEdUPmhHkxl+9WW5KlPDjSYyODTHyPXOlF4GqYNXU5GYZjUnQ== X-Received: by 2002:a7b:c0c4:: with SMTP id s4mr16413328wmh.26.1640686305295; Tue, 28 Dec 2021 02:11:45 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::6619]) by smtp.gmail.com with ESMTPSA id d62sm21160984wmd.3.2021.12.28.02.11.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Dec 2021 02:11:45 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 03/10] staging: r8188eu: remove unused enum odm_h2c_cmd Date: Tue, 28 Dec 2021 11:11:13 +0100 Message-Id: <20211228101120.9120-4-straube.linux@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20211228101120.9120-1-straube.linux@gmail.com> References: <20211228101120.9120-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The enum odm_h2c_cmd is not used in this driver. Remove it. Signed-off-by: Michael Straube --- drivers/staging/r8188eu/include/odm_interface.h | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/r8188eu/include/odm_interface.h b/drivers/stag= ing/r8188eu/include/odm_interface.h index 64c29c1da19d..e27ba77577a7 100644 --- a/drivers/staging/r8188eu/include/odm_interface.h +++ b/drivers/staging/r8188eu/include/odm_interface.h @@ -4,13 +4,6 @@ #ifndef __ODM_INTERFACE_H__ #define __ODM_INTERFACE_H__ =20 -enum odm_h2c_cmd { - ODM_H2C_RSSI_REPORT =3D 0, - ODM_H2C_PSD_RESULT=3D 1, - ODM_H2C_PathDiv =3D 2, - ODM_MAX_H2CCMD -}; - /* 2012/02/17 MH For non-MP compile pass only. Linux does not support wor= kitem. */ /* Suggest HW team to use thread instead of workitem. Windows also suppor= t the feature. */ typedef void (*RT_WORKITEM_CALL_BACK)(void *pContext); --=20 2.34.1 From nobody Wed Jul 1 06:46:22 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56912C433F5 for ; Tue, 28 Dec 2021 10:11:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233914AbhL1KLz (ORCPT ); Tue, 28 Dec 2021 05:11:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233590AbhL1KLr (ORCPT ); Tue, 28 Dec 2021 05:11:47 -0500 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51D5DC061574 for ; Tue, 28 Dec 2021 02:11:47 -0800 (PST) Received: by mail-wr1-x431.google.com with SMTP id d9so37485277wrb.0 for ; Tue, 28 Dec 2021 02:11:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=syi4xzz6q/zd3yOkEKI1/sCYTEmmG2y2NufKeEEtv6A=; b=XcrJ/gN1FeqnF/1WCEj8RpzU58LK5SdY+3TMl3pN69VXieZJqNwvXAxunM5tvphHPq xLvFuvdZVIIokviXLObUepAeDZu71yJGDTkYc3AwWVgD4ZbD4jgo0nOASjmQbiuN4do+ VGpM3iua23xiK4lwnlBEl4jY4pwA2SaihRkWiL09FHH1PzChfXZ2n3e2XAQKG42EYJ3d OkFzI32mRITF4CLzlIk61n5NQtJqifui5zEeSJBH2z1l7SQXB/2+1PY0vSle82Z5WkEx ko0HPPdfX443cl1AX2AoSo5w3lBzqALGRA3Q8PmFKoG4fw+qWMqGBiZHjnoO5iuCANhw t44A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=syi4xzz6q/zd3yOkEKI1/sCYTEmmG2y2NufKeEEtv6A=; b=01ZAiAdj47JMgngH6kd+cLi/LsTV+YFbNOqt1Hu1fW1CDn46WSE5D+k1ZYmVsNujM+ DDymYogcGKeXvMB6EzloI2s7SdK/6LQiCiIAZBfQ6O2wnT5syuSKxZcyZkMrM4gYjhgK IaF+tp/GymiPTFyXbvrSohQ8FoS/H1wMDZ8QXMx2wv4dz9fmkaXzEu9Ql8NIIsRA1oKj 4GNhutYlBh4fo8ez/D+6iiY+fW6vI4oa9wcfY4YRS30nCmYb1ZDNRWVgDTTPGwxwyRyu Y7UKyK32Hsk3VCL1e1oLpemICG2By8fO4bJU/kLBOw0ymEzP2ntxAkwUyIKujgylQH55 UOhw== X-Gm-Message-State: AOAM533ISM00pfhEauKHJ949ysVBtuMF/FClUVvL8I5I7udtWbTjjLUe dxSLcfQjbwk9ahvBRTh2IxE= X-Google-Smtp-Source: ABdhPJzt8Kac8Iry1ow3xpBJEQwN2DRCUeHzY5IeIjE4QawqTRQt8vRMQEsgo7Kqb2d9tHyuIGM4HQ== X-Received: by 2002:a5d:584f:: with SMTP id i15mr16388073wrf.542.1640686305982; Tue, 28 Dec 2021 02:11:45 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::6619]) by smtp.gmail.com with ESMTPSA id d62sm21160984wmd.3.2021.12.28.02.11.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Dec 2021 02:11:45 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 04/10] staging: r8188eu: remove ODM_CMNINFO_ABILITY from ODM_CmnInfoInit() Date: Tue, 28 Dec 2021 11:11:14 +0100 Message-Id: <20211228101120.9120-5-straube.linux@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20211228101120.9120-1-straube.linux@gmail.com> References: <20211228101120.9120-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" ODM_CmnInfoInit() is never called with ODM_CMNINFO_ABILITY. Remove that unused case from ODM_CmnInfoInit(). Signed-off-by: Michael Straube --- drivers/staging/r8188eu/hal/odm.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/r8188eu/hal/odm.c b/drivers/staging/r8188eu/ha= l/odm.c index a820bdc26fbc..afd208c3ba05 100644 --- a/drivers/staging/r8188eu/hal/odm.c +++ b/drivers/staging/r8188eu/hal/odm.c @@ -195,9 +195,6 @@ void ODM_CmnInfoInit(struct odm_dm_struct *pDM_Odm, enu= m odm_common_info_def Cmn /* This section is used for init value */ switch (CmnInfo) { /* Fixed ODM value. */ - case ODM_CMNINFO_ABILITY: - pDM_Odm->SupportAbility =3D (u32)Value; - break; case ODM_CMNINFO_MP_TEST_CHIP: pDM_Odm->bIsMPChip =3D (u8)Value; break; --=20 2.34.1 From nobody Wed Jul 1 06:46:22 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A97CC433F5 for ; Tue, 28 Dec 2021 10:11:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236051AbhL1KL5 (ORCPT ); Tue, 28 Dec 2021 05:11:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233380AbhL1KLs (ORCPT ); Tue, 28 Dec 2021 05:11:48 -0500 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14A2EC061574 for ; Tue, 28 Dec 2021 02:11:48 -0800 (PST) Received: by mail-wr1-x42e.google.com with SMTP id v11so37372776wrw.10 for ; Tue, 28 Dec 2021 02:11:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Mt8uB8InKVSd7M1Zm7yP7T7TeRc65Jt+J/dhsCZjMMo=; b=dcTjK2Pvj/EejNH03RgYIAfrJE+aeYz78xbMM8wkdl29TrZHN56BYImT9LC76ZezGc CecKBq25JGqOCa4xkUZI9jPXE0vkzFM4O/8G2/namHfBsQTiP9mW7rKt2uOYZlxcgIhG ohgKw0bA6Z6rjx1TTgk8ChpSWhRRoqmnGpwc7a6/DuEGQ4Pqx1G4xETQK03IamT8V4xz 3lgeVnel0ica3qi2LBt6Z6yOTulCaCgHNIEMpoclUAa5j7ltMYrZnIichs7ERdbGML/d p4X+YrHU1qcYEwFe69TCoHcKm8JT+Pdr0/KtG7tN9jlbEJ2U+LEGOYa+cFUEWPdwTr44 2q8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Mt8uB8InKVSd7M1Zm7yP7T7TeRc65Jt+J/dhsCZjMMo=; b=3Z5FNxKAUKhg+ylF1V/Gqf89cporzmIX3oHTW/TRAFwYxkowDqJV9lCzmdXZ4rUbLX LopDZnfhACzkpZcu1cdE4BVYtDZ7NlRx7f1PZ/NhIL3FmnEH3bMLwbSBUKJNHw0J9AdT cWkC1L2OuScqHcyMZ46tApLaIoSxaqlECzA02iwJFGLFG8WjqYWRoJCdWz7fHMhDbocW LDNOnx3HIL9f/NxfHvj1ngAKLjZTS2nJcDEWHk2j9KdmNOoKVM1u18S5oab1kxQJvajD 3ZVAyMtCgFR6CAonfMyoaPWHVyMnAizh7IgJWoCLNoVJPZPITiJaNSosGcCASO092WwQ YhHw== X-Gm-Message-State: AOAM533x3azo+sBLpDX1acOfp3ggiC474jeBp9oCMjBqaskKnKLgbHIx Eo9RyRAtDgd1ewSqxgxV78g= X-Google-Smtp-Source: ABdhPJwMNY3LTqwVY0YmTfHcJEtQ1xU3tYGpxwVxPTulidN87ehPxDy/PrduER3+tf8rCDR4WZShIQ== X-Received: by 2002:adf:f48e:: with SMTP id l14mr16026826wro.88.1640686306631; Tue, 28 Dec 2021 02:11:46 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::6619]) by smtp.gmail.com with ESMTPSA id d62sm21160984wmd.3.2021.12.28.02.11.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Dec 2021 02:11:46 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 05/10] staging: r8188eu: remove write-only fields from struct rtl_ps Date: Tue, 28 Dec 2021 11:11:15 +0100 Message-Id: <20211228101120.9120-6-straube.linux@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20211228101120.9120-1-straube.linux@gmail.com> References: <20211228101120.9120-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The fields pre_cca_state, cur_cca_state and rssi_val_min of struct rtl_ps are set but never used. Remove them. Signed-off-by: Michael Straube --- drivers/staging/r8188eu/hal/odm.c | 3 --- drivers/staging/r8188eu/include/odm.h | 12 ------------ 2 files changed, 15 deletions(-) diff --git a/drivers/staging/r8188eu/hal/odm.c b/drivers/staging/r8188eu/ha= l/odm.c index afd208c3ba05..b1bb81c97c5c 100644 --- a/drivers/staging/r8188eu/hal/odm.c +++ b/drivers/staging/r8188eu/hal/odm.c @@ -574,11 +574,8 @@ void odm_DynamicBBPowerSavingInit(struct odm_dm_struct= *pDM_Odm) { struct rtl_ps *pDM_PSTable =3D &pDM_Odm->DM_PSTable; =20 - pDM_PSTable->pre_cca_state =3D CCA_MAX; - pDM_PSTable->cur_cca_state =3D CCA_MAX; pDM_PSTable->pre_rf_state =3D RF_MAX; pDM_PSTable->cur_rf_state =3D RF_MAX; - pDM_PSTable->rssi_val_min =3D 0; pDM_PSTable->initialize =3D 0; } =20 diff --git a/drivers/staging/r8188eu/include/odm.h b/drivers/staging/r8188e= u/include/odm.h index 306640e92e6f..66dc93518628 100644 --- a/drivers/staging/r8188eu/include/odm.h +++ b/drivers/staging/r8188eu/include/odm.h @@ -48,14 +48,8 @@ struct rtw_dig { }; =20 struct rtl_ps { - u8 pre_cca_state; - u8 cur_cca_state; - u8 pre_rf_state; u8 cur_rf_state; - - int rssi_val_min; - u8 initialize; u32 reg_874; u32 reg_c70; @@ -543,12 +537,6 @@ enum odm_bb_config_type { /* 3 BB Power Save */ /* 3=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */ =20 -enum dm_1r_cca { - CCA_1R =3D 0, - CCA_2R =3D 1, - CCA_MAX =3D 2, -}; - enum dm_rf { RF_Save =3D 0, RF_Normal =3D 1, --=20 2.34.1 From nobody Wed Jul 1 06:46:22 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6187C433EF for ; Tue, 28 Dec 2021 10:12:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236070AbhL1KL6 (ORCPT ); Tue, 28 Dec 2021 05:11:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233678AbhL1KLt (ORCPT ); Tue, 28 Dec 2021 05:11:49 -0500 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD26EC061574 for ; Tue, 28 Dec 2021 02:11:48 -0800 (PST) Received: by mail-wr1-x436.google.com with SMTP id k18so649203wrg.11 for ; Tue, 28 Dec 2021 02:11:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=g7uqoTKpq+D1932lWi4R+j2Cpn0lqrO7AJ2oZ+FkUIc=; b=GVkRRsSBZH2Sx4dnkSf9dBo6SlxUShXBGtS8qUAdFiXZZ+xmSe7WnC2sX5jtrULMbw +bLvgEw42GmGznPX7mv3VID/g327UuY4Ob8RD9z6Ha6eP0ynmryPR3ijmhCp+bOymr5L 3w/O8n1L8Bp7IRvpn6iyzVdude+y64Q5FRzgiGCDRYN71l5NzXvagqlynxsRBc5QJXtO Isat7StxIgJEeIEqnF0mv+eswcfar7gx/jp7oxxrVijZ00JQKVSSBejzIqosuPlUuKnO iDMQ1/CZNKaP7JxPhAzl/3FbsX/LuTyyW4MXl8oyauEflw2ESiifR/AhMGtejk6JLO7m hJVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=g7uqoTKpq+D1932lWi4R+j2Cpn0lqrO7AJ2oZ+FkUIc=; b=q9f1GJ3QMW/mSrf3r8mLaPut4hRelFwXMyd+NKZtdtAejIBAlKUGC+oYCvufohyDGZ wkB7bkm+8zfs4cgMjMStvDLQlhMP0p9G0KoaMas1E2M2ZGikd1ujEP2PVxbspvU91mC0 5fvY9APBnBKIveiGg5eOykkb1X6q7PPyA8UaILmn800qJCfuGdJhr9++GCSUradNTJHQ N9y8imX7sve+GUoK43kZZbs7hAyeoL5SfJfcPk72VzdWwDAFOa3zj3IqhUfNiUWPP1S/ i52/3NRvXH76ERMyUiKZj9i07CfiPfwY2JTi04aduMLVrAdyxFjULO1HzHk7C2g8CytF cs1Q== X-Gm-Message-State: AOAM532mfU8t8L3IYn4efWobPtxSAj5TRc6vp3am25GlvS7lGC/eZAls 3O0mpnVMAX0vkIfAgLYbr0I= X-Google-Smtp-Source: ABdhPJxVq0Q+bBVGVIxyuuOEesl233rv+pQay35hHKJCZos2FL9Sr2unQc1PxiLvwdVzSO4bkmZk9g== X-Received: by 2002:a05:6000:18c6:: with SMTP id w6mr7844132wrq.449.1640686307485; Tue, 28 Dec 2021 02:11:47 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::6619]) by smtp.gmail.com with ESMTPSA id d62sm21160984wmd.3.2021.12.28.02.11.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Dec 2021 02:11:47 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 06/10] staging: r8188eu: FAT_State is always FAT_NORMAL_STATE Date: Tue, 28 Dec 2021 11:11:16 +0100 Message-Id: <20211228101120.9120-7-straube.linux@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20211228101120.9120-1-straube.linux@gmail.com> References: <20211228101120.9120-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" In this driver pDM_FatTable->FAT_State is always FAT_NORMAL_STATE. So the check 'if (pDM_FatTable->FAT_State =3D=3D FAT_TRAINING_STATE)' is always false. Remove dead code that is executed only if that check is true. Signed-off-by: Michael Straube --- drivers/staging/r8188eu/hal/odm_HWConfig.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/staging/r8188eu/hal/odm_HWConfig.c b/drivers/staging/r= 8188eu/hal/odm_HWConfig.c index 1fb2d9a16fea..9de16383cb2d 100644 --- a/drivers/staging/r8188eu/hal/odm_HWConfig.c +++ b/drivers/staging/r8188eu/hal/odm_HWConfig.c @@ -251,15 +251,7 @@ static void odm_Process_RSSIForDM(struct odm_dm_struct= *dm_odm, isCCKrate =3D ((pPktinfo->Rate >=3D DESC92C_RATE1M) && (pPktinfo->Rate <= =3D DESC92C_RATE11M)) ? true : false; =20 /* Smart Antenna Debug Message------------------ */ - if (dm_odm->AntDivType =3D=3D CG_TRX_SMART_ANTDIV) { - if (pDM_FatTable->FAT_State =3D=3D FAT_TRAINING_STATE) { - if (pPktinfo->bPacketToSelf) { - antsel_tr_mux =3D (pDM_FatTable->antsel_rx_keep_2 << 2) | - (pDM_FatTable->antsel_rx_keep_1 << 1) | - pDM_FatTable->antsel_rx_keep_0; - } - } - } else if ((dm_odm->AntDivType =3D=3D CG_TRX_HW_ANTDIV) || (dm_odm->AntDi= vType =3D=3D CGCS_RX_HW_ANTDIV)) { + if ((dm_odm->AntDivType =3D=3D CG_TRX_HW_ANTDIV) || (dm_odm->AntDivType = =3D=3D CGCS_RX_HW_ANTDIV)) { if (pPktinfo->bPacketToSelf || pPktinfo->bPacketBeacon) { antsel_tr_mux =3D (pDM_FatTable->antsel_rx_keep_2 << 2) | (pDM_FatTable->antsel_rx_keep_1 << 1) | pDM_FatTable->antsel_rx_keep_= 0; --=20 2.34.1 From nobody Wed Jul 1 06:46:22 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CE3BC433FE for ; Tue, 28 Dec 2021 10:12:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236141AbhL1KMA (ORCPT ); Tue, 28 Dec 2021 05:12:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233688AbhL1KLu (ORCPT ); Tue, 28 Dec 2021 05:11:50 -0500 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83DA7C06173E for ; Tue, 28 Dec 2021 02:11:49 -0800 (PST) Received: by mail-wr1-x436.google.com with SMTP id d9so37485440wrb.0 for ; Tue, 28 Dec 2021 02:11:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EjwXk8DAoVctoWcKSh1CxTed9Argmbii4xJnIrYtVZc=; b=B2ZfjswxYQF099t1ED3UHvTKXrMVJzSlr+cqPCFWClcD4UgpSKr9j7C5of6vN2fbjR yursA2m2V0p167sRe6frBdGOroHSnU7afmB++i2zskVSx2Tht1n/X9ZVgcjnT+e7/Kba 9nuMredI/07qVyO/IPHQ0IcvgHi2ISwzVbqbCy2x44GlgJUCtKdFIaqFzXySLupLsTSC iQqSnuAnQ+RyYDzvgua6wXoV+EQNwW3r25vxPKRjYWFtKbeF8eCiZdS08nwg6luwCo6O +p3XgqehAY6RTQ9m20lcTWv/ZNkbaY0R4/SDgmy/7KmSYde15TIUF45oZDRHrFvOzM6o QAQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EjwXk8DAoVctoWcKSh1CxTed9Argmbii4xJnIrYtVZc=; b=7OgcJ+fHNQmwUUDeZEhl+CKt8CW9luRri5Tyzn4bpP+6NIXeUSAd3LngLYQUTkBLce sfQHro+lqykYQr2S4hMK1n5Mgr/7oIQ01Mp2pnjr92DBfmbBA+4+bCPsx8ZWNuCk0xQL pD7C36wIuZ3cDF45KEw4pejMmWMieENNcCKNgX6YjRP4KpARfPXnohCLgZFIiacjfsTu B6VkIGhaYtwsu5+lEf5QkSzBxGPKtCmadfWJC7KQCEtxWmt7tINGtKbg6nkZoVDhmYoc wZL8QnBUdjwOetexZLBpSFpBKrgIXcbUdzRxx4jrEurKh4DbeKq83F0W5hxQQgTwfgUc WLng== X-Gm-Message-State: AOAM5314YdVHQbCApsG/pJVb+ink8TDJeqasFPN3dTqiizxOieS4w9cQ Zz+g3kuKK30ZyGf5QC/4upw= X-Google-Smtp-Source: ABdhPJycaCqsdFX+otOe7KZPXWoMVSn1rlIJHmQIHnRNs/9aLjqFkfOtLFSN7AkgiH3sTT45sIrqSg== X-Received: by 2002:a5d:4e92:: with SMTP id e18mr16143241wru.89.1640686308209; Tue, 28 Dec 2021 02:11:48 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::6619]) by smtp.gmail.com with ESMTPSA id d62sm21160984wmd.3.2021.12.28.02.11.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Dec 2021 02:11:47 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 07/10] staging: r8188eu: FAT_State is set but never used Date: Tue, 28 Dec 2021 11:11:17 +0100 Message-Id: <20211228101120.9120-8-straube.linux@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20211228101120.9120-1-straube.linux@gmail.com> References: <20211228101120.9120-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The field FAT_State of struct fast_ant_train is set but never used. Remove it. Signed-off-by: Michael Straube --- drivers/staging/r8188eu/hal/odm_RTL8188E.c | 1 - drivers/staging/r8188eu/include/odm.h | 6 ------ 2 files changed, 7 deletions(-) diff --git a/drivers/staging/r8188eu/hal/odm_RTL8188E.c b/drivers/staging/r= 8188eu/hal/odm_RTL8188E.c index 34530fcd00d8..1dcdf6a131fc 100644 --- a/drivers/staging/r8188eu/hal/odm_RTL8188E.c +++ b/drivers/staging/r8188eu/hal/odm_RTL8188E.c @@ -60,7 +60,6 @@ static void odm_FastAntTrainingInit(struct odm_dm_struct = *dm_odm) struct fast_ant_train *dm_fat_tbl =3D &dm_odm->DM_FatTable; =20 dm_fat_tbl->TrainIdx =3D 0; - dm_fat_tbl->FAT_State =3D FAT_NORMAL_STATE; =20 /* MAC Setting */ value32 =3D ODM_GetMACReg(dm_odm, 0x4c, bMaskDWord); diff --git a/drivers/staging/r8188eu/include/odm.h b/drivers/staging/r8188e= u/include/odm.h index 66dc93518628..db72eea83382 100644 --- a/drivers/staging/r8188eu/include/odm.h +++ b/drivers/staging/r8188eu/include/odm.h @@ -387,7 +387,6 @@ struct fast_ant_train { u8 antsel_rx_keep_0; u8 antsel_rx_keep_1; u8 antsel_rx_keep_2; - u8 FAT_State; u32 TrainIdx; u8 antsel_a[ODM_ASSOCIATE_ENTRY_NUM]; u8 antsel_b[ODM_ASSOCIATE_ENTRY_NUM]; @@ -400,11 +399,6 @@ struct fast_ant_train { bool bBecomeLinked; }; =20 -enum fat_state { - FAT_NORMAL_STATE =3D 0, - FAT_TRAINING_STATE =3D 1, -}; - enum ant_div_type { NO_ANTDIV =3D 0xFF, CG_TRX_HW_ANTDIV =3D 0x01, --=20 2.34.1 From nobody Wed Jul 1 06:46:22 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EB7CC433EF for ; Tue, 28 Dec 2021 10:12:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236241AbhL1KMG (ORCPT ); Tue, 28 Dec 2021 05:12:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233681AbhL1KLu (ORCPT ); Tue, 28 Dec 2021 05:11:50 -0500 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43F2CC061574 for ; Tue, 28 Dec 2021 02:11:50 -0800 (PST) Received: by mail-wr1-x436.google.com with SMTP id i22so37320033wrb.13 for ; Tue, 28 Dec 2021 02:11:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yX6WsvFj3mzN8+krDEd2nQc532OtlqFbEGHYa+8owtg=; b=CHqtD85QiJVOrksiY6idhWxmYujhHyOhKTQI7XM9wP4NbStnJumSS2PoIywdrz2tWB 0TuCLwFgOPv3VrjrwEvgEQ8JNungyWnloDxjZYXoENP6jgfRKZPNaPivRm/3xNJx1cj8 iV0U8R2xJE+2Fvb44pUeapqDxTLd+EVVX8DMT8QBSutSX+uSYhISEJkT0ry5AQu6UKXT QCO9uIuk+I424oHn3wQ3Fjv+wkd5UA9nhJDLXU9u48I3WNkkynQQ3/HHNMlpgdkfbtBh l7SMuwWRtytA6//x5XOXmnON450PNLk7FmXlkdFhvTaJFSBR8z8SgTA6E1QmfSHLkDdF LyLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yX6WsvFj3mzN8+krDEd2nQc532OtlqFbEGHYa+8owtg=; b=FPE6hp0/GMIFRjR/blIR645h+oV9FIJiu0tk6fl/F7/M1Yy5MjcHJATPOkHSPlHGY4 Sw8dOE+p93P25MInUq6oAmlpeBmWG1HwxLt4/kMP3rFi8hPsolGdMAWopWrb8zazLGXn 4Cv6QViQ3QX5g1/Pk4wA7qcaWI1fR/GHgdnYnlidWkLXDoNj2CaV9NyqBBRDzRnGlC9j Naoqx5rcMo1Wr0lSEKjo02Uv8DtEr444ukeb6k/Bdz6jNI5KUGNkfztmk8bFiWCEDRnW caK6C0/H9XfHfn0YNwRwQDWaAIqj6940O1+qf4wKqKr8wUkgZknpz7c7xvzE8njGANHQ UE8A== X-Gm-Message-State: AOAM531y4R1Dl4kM67rpdZToXb1DpZPat+YoRbJhlzl8P/4rX+9TNNnp NDas/6mEaB/qUE9FYYMGOpk= X-Google-Smtp-Source: ABdhPJzegxx5hMNs0p3/9iYzdbhROmlLk6Bx1Oc3qbdik5CJOyuzgGdLldW4RGhoSQXoAcHfbacrSA== X-Received: by 2002:adf:ea8c:: with SMTP id s12mr15894183wrm.342.1640686308890; Tue, 28 Dec 2021 02:11:48 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::6619]) by smtp.gmail.com with ESMTPSA id d62sm21160984wmd.3.2021.12.28.02.11.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Dec 2021 02:11:48 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 08/10] staging: r8188eu: TrainIdx is set but never used Date: Tue, 28 Dec 2021 11:11:18 +0100 Message-Id: <20211228101120.9120-9-straube.linux@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20211228101120.9120-1-straube.linux@gmail.com> References: <20211228101120.9120-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The field TrainIdx of struct fast_ant_train is set but never used. Remove it. Signed-off-by: Michael Straube --- drivers/staging/r8188eu/hal/odm_RTL8188E.c | 3 --- drivers/staging/r8188eu/include/odm.h | 1 - 2 files changed, 4 deletions(-) diff --git a/drivers/staging/r8188eu/hal/odm_RTL8188E.c b/drivers/staging/r= 8188eu/hal/odm_RTL8188E.c index 1dcdf6a131fc..eefa448d2002 100644 --- a/drivers/staging/r8188eu/hal/odm_RTL8188E.c +++ b/drivers/staging/r8188eu/hal/odm_RTL8188E.c @@ -57,9 +57,6 @@ static void odm_TRX_HWAntDivInit(struct odm_dm_struct *dm= _odm) static void odm_FastAntTrainingInit(struct odm_dm_struct *dm_odm) { u32 value32; - struct fast_ant_train *dm_fat_tbl =3D &dm_odm->DM_FatTable; - - dm_fat_tbl->TrainIdx =3D 0; =20 /* MAC Setting */ value32 =3D ODM_GetMACReg(dm_odm, 0x4c, bMaskDWord); diff --git a/drivers/staging/r8188eu/include/odm.h b/drivers/staging/r8188e= u/include/odm.h index db72eea83382..a037d7b863fb 100644 --- a/drivers/staging/r8188eu/include/odm.h +++ b/drivers/staging/r8188eu/include/odm.h @@ -387,7 +387,6 @@ struct fast_ant_train { u8 antsel_rx_keep_0; u8 antsel_rx_keep_1; u8 antsel_rx_keep_2; - u32 TrainIdx; u8 antsel_a[ODM_ASSOCIATE_ENTRY_NUM]; u8 antsel_b[ODM_ASSOCIATE_ENTRY_NUM]; u8 antsel_c[ODM_ASSOCIATE_ENTRY_NUM]; --=20 2.34.1 From nobody Wed Jul 1 06:46:22 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22406C433EF for ; Tue, 28 Dec 2021 10:12:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236031AbhL1KMD (ORCPT ); Tue, 28 Dec 2021 05:12:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233771AbhL1KLv (ORCPT ); Tue, 28 Dec 2021 05:11:51 -0500 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF74FC06173F for ; Tue, 28 Dec 2021 02:11:50 -0800 (PST) Received: by mail-wr1-x42e.google.com with SMTP id q16so37389616wrg.7 for ; Tue, 28 Dec 2021 02:11:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NHOLXaWQQuVn3Qf7fYQiZFpLvUeZKWbm7r3R3sqCc7Y=; b=EfNEhmYPDYfRJMzTVmnUk+4T+4YdcsHb6j4U8R1A5SLZ5iZcKWvYVTJrbwjdY0CPBW 7Djwf7VOnDTVdF2wfhn+m9PQUG/cKPBYGSwiotAPF+ClRD1d7YhAPsfm9nG2TyQ9odZ7 Og2ot7eDSXx9GVd/QTqXCRkjSkbSfF4fC3jAtXUpRAiBLpWGinMWSeqR7eTvPg9DhGFc mB1bG85/gvxBAF5/5ma5UFMASofHiVWf4F4f65cknpje5XuCmg99A86TC6n2Tp7a6EZo p3uwwhs8VtolJ1PfbvAVW90EKYje6my6/2JPM9RYQjM8CNLbsHlTXJZB2lkMVuOeQcTV BTVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NHOLXaWQQuVn3Qf7fYQiZFpLvUeZKWbm7r3R3sqCc7Y=; b=z1E9mml37MTD5TkGkDBNhBOf6ygBIMpofqs5CoLYrsukibVWIeUZFfsCFfCus3MsVZ kzTBrDiqJ/uaXd+1U+QmB62iXOpBCbOPPvTsC+O0flQVMizBZ1dYaOpdegT49hdvKYJd z0dzxQt4h3a83Z5IOVGjWDT5YxZ58TQsWt28q8y2QjEn0NvwRfleX9jwZomXUJw4iFEm sKsyX4PkfRkWf5yYwSjBx8QY8RrLBp7NPU51YuT3BLWsHmUgO5LcAFXBkgUep0Kk8j79 sVwXEk5YT2VXxJyRFwqS7uAHoYVy34/ggUlzV7x9RDkFA2FPzp1KGL3XU9KvcYyhAyD4 ITiw== X-Gm-Message-State: AOAM530ciN1tq9SakM61P6K4sU/iI8TknLpeDAxq9ohv4kideIR1tj10 /9WEVX3f1XulkrBCHrhWXQ0= X-Google-Smtp-Source: ABdhPJwZ+lqpBiYIB5ZFvjbQJtjep5ZCDkTFZ4edGi4ROMKQ8uo2QERUWbYH2HHO14o+Axo/hHJ85Q== X-Received: by 2002:a5d:69c8:: with SMTP id s8mr15755165wrw.220.1640686309622; Tue, 28 Dec 2021 02:11:49 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::6619]) by smtp.gmail.com with ESMTPSA id d62sm21160984wmd.3.2021.12.28.02.11.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Dec 2021 02:11:49 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 09/10] staging: r8188eu: RSSI_test is always false Date: Tue, 28 Dec 2021 11:11:19 +0100 Message-Id: <20211228101120.9120-10-straube.linux@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20211228101120.9120-1-straube.linux@gmail.com> References: <20211228101120.9120-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The field RSSI_test of struct odm_dm_struct is never set. It stays at the default value 0. Remove it and remove a related if test that is always true. Signed-off-by: Michael Straube --- drivers/staging/r8188eu/hal/odm_HWConfig.c | 6 ++---- drivers/staging/r8188eu/include/odm.h | 1 - 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/r8188eu/hal/odm_HWConfig.c b/drivers/staging/r= 8188eu/hal/odm_HWConfig.c index 9de16383cb2d..7509e3c3f418 100644 --- a/drivers/staging/r8188eu/hal/odm_HWConfig.c +++ b/drivers/staging/r8188eu/hal/odm_HWConfig.c @@ -358,10 +358,8 @@ void ODM_PhyStatusQuery(struct odm_dm_struct *dm_odm, struct odm_per_pkt_info *pPktinfo, struct adapter *adapt) { - odm_RxPhyStatus92CSeries_Parsing(dm_odm, pPhyInfo, pPhyStatus, - pPktinfo, adapt); - if (!dm_odm->RSSI_test) - odm_Process_RSSIForDM(dm_odm, pPhyInfo, pPktinfo); + odm_RxPhyStatus92CSeries_Parsing(dm_odm, pPhyInfo, pPhyStatus, pPktinfo, = adapt); + odm_Process_RSSIForDM(dm_odm, pPhyInfo, pPktinfo); } =20 enum HAL_STATUS ODM_ConfigRFWithHeaderFile(struct odm_dm_struct *dm_odm, diff --git a/drivers/staging/r8188eu/include/odm.h b/drivers/staging/r8188e= u/include/odm.h index a037d7b863fb..c07dbf763903 100644 --- a/drivers/staging/r8188eu/include/odm.h +++ b/drivers/staging/r8188eu/include/odm.h @@ -468,7 +468,6 @@ struct odm_dm_struct { struct rtl_ps DM_PSTable; struct false_alarm_stats FalseAlmCnt; struct sw_ant_switch DM_SWAT_Table; - bool RSSI_test; =20 struct edca_turbo DM_EDCA_Table; =20 --=20 2.34.1 From nobody Wed Jul 1 06:46:22 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55388C433EF for ; Tue, 28 Dec 2021 10:12:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233815AbhL1KMI (ORCPT ); Tue, 28 Dec 2021 05:12:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233835AbhL1KLw (ORCPT ); Tue, 28 Dec 2021 05:11:52 -0500 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0A6CC06173E for ; Tue, 28 Dec 2021 02:11:51 -0800 (PST) Received: by mail-wr1-x433.google.com with SMTP id s1so37457961wrg.1 for ; Tue, 28 Dec 2021 02:11:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oY9hSfkqZTFPqAFtoGBpdMUae0krMzwYjwLMqlw8+0I=; b=JHfloE24oleodZ3g+wWzd3v/hSXxLN6jmrsVGqZ/iN4MQYQsax2gGyFoQDuOrFUfyc Ft99f3nus0fTrbAguzYnQvwxtOluL5tSq3Hj+LRYnDQfk/ocIj+AO8z6hQ0KwLNQAtWA v7u38tHMUdHUHj2p8v1BbVBA5jkgsJnJ1tFYGJLfevlvQhkl2D7qi23VLPuXOouqYPaP Hf6LPMQL3kcQ3H/wA60+mrwaE84eIUS7XTZYY/C5SQSuPGM2xDk3PMXDI2rWKApidx9w MwXH47DYQoXWpzqNuN1hXSgw3JYWIGy9LkbMsqrtdTXaoyPx6S+gMvGL+mJra0aW3tyK ZsNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oY9hSfkqZTFPqAFtoGBpdMUae0krMzwYjwLMqlw8+0I=; b=qliI3rt1EaqEy5xQ3wAX3z8fNd48aCNwWPq7838V24mCXp1t6A5EKbmriIxkO3k7zG I/6Ccd1Scqn+fM/afC8hBqQ/eVfkylYKXChf/DJ/N+YHSQa+8lYX4B160AtsiTz3L3Vi F7CWSURM5oDrRSyScoqPfpR1zQcxgHA07II+AzGPX7RsiSJlBuxqY9vo47g7qcAPPWGL JVgEBWaHg1G5I9YzBryBsRt1fzgdTCVBTxahCCTpR3aGKZvkwM7s0Kg7IFEoj2WpxOrT znZblGOeskSQzdIQp2ou87f2Idzch6i+Yxaj+sNn0vv50KVRhQwBc7E0Ls6OWBRXp6R+ BH3A== X-Gm-Message-State: AOAM530yuj56K4fgHsZWfGZoBWzxNhngdIyzrdXKlVJx1e3d0fUrKtX2 DhR993pRimNESmprEUve+Ts5UH3YWwI= X-Google-Smtp-Source: ABdhPJzNxtaG7srAogqMjSOtL5UgMh5WTzO8tfE7aTZKkZe08FODYcEuoKfzyHp5COgFsW/IaSs14Q== X-Received: by 2002:a05:6000:2a9:: with SMTP id l9mr15786747wry.185.1640686310321; Tue, 28 Dec 2021 02:11:50 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::6619]) by smtp.gmail.com with ESMTPSA id d62sm21160984wmd.3.2021.12.28.02.11.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Dec 2021 02:11:50 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 10/10] staging: r8188eu: merge _ReadLEDSetting() into ReadAdapterInfo8188EU() Date: Tue, 28 Dec 2021 11:11:20 +0100 Message-Id: <20211228101120.9120-11-straube.linux@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20211228101120.9120-1-straube.linux@gmail.com> References: <20211228101120.9120-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Function _ReadLEDSetting() sets only a single variable and the only user is ReadAdapterInfo8188EU(). Remove _ReadLEDSetting() and set the variable in ReadAdapterInfo8188EU() directly. Signed-off-by: Michael Straube --- drivers/staging/r8188eu/hal/usb_halinit.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8= 188eu/hal/usb_halinit.c index 9edde72aebb2..b362c622ea8a 100644 --- a/drivers/staging/r8188eu/hal/usb_halinit.c +++ b/drivers/staging/r8188eu/hal/usb_halinit.c @@ -914,12 +914,6 @@ unsigned int rtl8188eu_inirp_init(struct adapter *Adap= ter) /* EEPROM/EFUSE Content Parsing */ /* */ /* */ -static void _ReadLEDSetting(struct adapter *Adapter, u8 *PROMContent, bool= AutoloadFail) -{ - struct led_priv *pledpriv =3D &Adapter->ledpriv; - - pledpriv->bRegUseLed =3D true; -} =20 static void Hal_EfuseParseMACAddr_8188EU(struct adapter *adapt, u8 *hwinfo= , bool AutoLoadFail) { @@ -939,6 +933,7 @@ static void Hal_EfuseParseMACAddr_8188EU(struct adapter= *adapt, u8 *hwinfo, bool void ReadAdapterInfo8188EU(struct adapter *Adapter) { struct eeprom_priv *eeprom =3D &Adapter->eeprompriv; + struct led_priv *ledpriv =3D &Adapter->ledpriv; u8 eeValue; =20 /* Read EEPROM size before call any EEPROM function */ @@ -966,7 +961,7 @@ void ReadAdapterInfo8188EU(struct adapter *Adapter) Hal_ReadAntennaDiversity88E(Adapter, eeprom->efuse_eeprom_data, eeprom->b= autoload_fail_flag); Hal_ReadThermalMeter_88E(Adapter, eeprom->efuse_eeprom_data, eeprom->baut= oload_fail_flag); =20 - _ReadLEDSetting(Adapter, eeprom->efuse_eeprom_data, eeprom->bautoload_fai= l_flag); + ledpriv->bRegUseLed =3D true; } =20 static void ResumeTxBeacon(struct adapter *adapt) --=20 2.34.1