From nobody Wed Jul 1 07:50:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FB41C433FE for ; Sun, 26 Dec 2021 11:25:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233262AbhLZLZS (ORCPT ); Sun, 26 Dec 2021 06:25:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233212AbhLZLZQ (ORCPT ); Sun, 26 Dec 2021 06:25:16 -0500 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 829AAC06173E for ; Sun, 26 Dec 2021 03:25:16 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id g191-20020a1c9dc8000000b0032fbf912885so6940964wme.4 for ; Sun, 26 Dec 2021 03:25:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9LTDPcsLit3ZltGpmydxyhDaBvNBfOjBIIApsVidYlU=; b=ejlSnBRYPWQDz4Nz+pf/Ob69zbAjcqMfijxXsTWcXhySEQRzUT3JCExyZ5Q1SIvA3c kQEyhuRzvpXKwr0S+/rKlCIT/w8ncJ+aQzdm7jpMBRPCQQr/da5ZGlqL/VYyn43hxxCv CHtfylV68MCTsg4AhrkoS7zKdwb4IMm7OEpKDU3FaIoEA3fCSGm4fcRNK4c54Tcqvr6/ zq9E1bBZJSI6Mp+0nnb2zUxeSOTTcaPXWRQkOYUc5TBf57vUoysacqIO7xX3ytpTmfP5 OepQvrBjQUOgumuDejvOFTQ3kmvegmDblhp3SxIv7Bir6Vv/VhSt9Mkh5t4Y/gKXUW3F iQmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9LTDPcsLit3ZltGpmydxyhDaBvNBfOjBIIApsVidYlU=; b=xNGwcIIeoA7vGxiDSRpWJ98AMASWO2XIP7csTziKwCW8yFCQFr9oHLf0i4hjGnua7M XBBhv0aXH9im0NjdkyuRaLDy0X8rvnC4j1HYlMjSyud+zMX/nQyNqyqv09lfRhHE9hPc AJTLypLShEvqwldwoFnRhaKvxrUPcuKwbFp2gXAeIaA/1eDP3wx4SwzO0rObQtr5hkjX 2UWY8V81XtR3Omhyg7zF/M5MTY3nLJjucXbXeXIaoyYHpsj7LlwvOtvLah8y4cZljj9P zNvgTQ4ULZ9GgB85mXvRHnYi2CxoLEU0ifviORG+O8rzQadGVUsUgFZYfU+fPNlP6PS8 X2bQ== X-Gm-Message-State: AOAM5308zpu29uPrWe2ZORZX3CRjezW1OvgBwRllrxkWwGfaP56xjKX9 0pWOW4yhe9uDZcLVsBNj3Y4= X-Google-Smtp-Source: ABdhPJxzOeTdg3Sm90f1frrXzLRCNKL4Q9YDL0ikNej0GhBsklk2qdNprmmmNirl5P7CW0Jv6ObHPQ== X-Received: by 2002:a05:600c:209:: with SMTP id 9mr10183053wmi.145.1640517915050; Sun, 26 Dec 2021 03:25:15 -0800 (PST) Received: from localhost.localdomain ([217.113.240.86]) by smtp.gmail.com with ESMTPSA id g12sm13654743wrd.71.2021.12.26.03.25.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Dec 2021 03:25:14 -0800 (PST) From: =?UTF-8?q?Jos=C3=A9=20Exp=C3=B3sito?= To: contact@emersion.fr Cc: ville.syrjala@linux.intel.com, dmitry.baryshkov@linaro.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@linux.ie, daniel@ffwll.ch, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, marex@denx.de, stefan@agner.ch, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, yannick.fertre@foss.st.com, philippe.cornu@foss.st.com, benjamin.gaignard@linaro.org, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, =?UTF-8?q?Jos=C3=A9=20Exp=C3=B3sito?= Subject: [PATCH v3 1/6] =?UTF-8?q?drm/plane:=20Make=20format=5Fmod=5Fsuppo?= =?UTF-8?q?rted=20truly=C2=A0optional?= Date: Sun, 26 Dec 2021 12:24:58 +0100 Message-Id: <20211226112503.31771-2-jose.exposito89@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211226112503.31771-1-jose.exposito89@gmail.com> References: <20211226112503.31771-1-jose.exposito89@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The documentation for "drm_plane_funcs.format_mod_supported" reads: This *optional* hook is used for the DRM to determine if the given format/modifier combination is valid for the plane. This allows the DRM to generate the correct format bitmask (which formats apply to which modifier), and to validate modifiers at atomic_check time. *If not present*, then any modifier in the plane's modifier list is allowed with any of the plane's formats. However, where the function is not present, an invalid IN_FORMATS blob property with modifiers but no formats is exposed to user-space. This breaks the latest Weston [1]. For testing purposes, I extracted the affected code to a standalone program [2]. Make "create_in_format_blob" behave as documented. [1] https://gitlab.freedesktop.org/wayland/weston/-/blob/9.0/libweston/back= end-drm/kms.c#L431 [2] https://github.com/JoseExposito/drm-sandbox/blob/main/in_formats.c Signed-off-by: Jos=C3=A9 Exp=C3=B3sito Reviewed-by: Simon Ser --- v2: - Remove unused "done:" label to fix compile warning Reported-by: kernel test robot - Add Reviewed-by (thanks to Simon Ser) --- drivers/gpu/drm/drm_plane.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c index 82afb854141b..deeec60a3315 100644 --- a/drivers/gpu/drm/drm_plane.c +++ b/drivers/gpu/drm/drm_plane.c @@ -202,17 +202,13 @@ static int create_in_format_blob(struct drm_device *d= ev, struct drm_plane *plane =20 memcpy(formats_ptr(blob_data), plane->format_types, formats_size); =20 - /* If we can't determine support, just bail */ - if (!plane->funcs->format_mod_supported) - goto done; - mod =3D modifiers_ptr(blob_data); for (i =3D 0; i < plane->modifier_count; i++) { for (j =3D 0; j < plane->format_count; j++) { - if (plane->funcs->format_mod_supported(plane, + if (!plane->funcs->format_mod_supported || + plane->funcs->format_mod_supported(plane, plane->format_types[j], plane->modifiers[i])) { - mod->formats |=3D 1ULL << j; } } @@ -223,7 +219,6 @@ static int create_in_format_blob(struct drm_device *dev= , struct drm_plane *plane mod++; } =20 -done: drm_object_attach_property(&plane->base, config->modifiers_property, blob->base.id); =20 --=20 2.25.1 From nobody Wed Jul 1 07:50:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B61C3C433F5 for ; Sun, 26 Dec 2021 11:25:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233269AbhLZLZU (ORCPT ); Sun, 26 Dec 2021 06:25:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233263AbhLZLZS (ORCPT ); Sun, 26 Dec 2021 06:25:18 -0500 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA71DC06173E for ; Sun, 26 Dec 2021 03:25:17 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id l4so7907074wmq.3 for ; Sun, 26 Dec 2021 03:25:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JVsPYyeSs0Z89jpnz+/jWObtkdsoENnAN2PsMGBB0X8=; b=Ay89gIcMZst8GS6tyGXp98KOAC6Qgvu1V13cw/bSJfQ0fXJgZG1CyQSXYBVYyvR85x chNrltN4WsAL+D/E3LN61lFu800OdW4YqE6Db671ZbGItmrxctjiekoTQY0QMokGJw5/ dFUWjTEqmeu7+zjUpWpFiuLEq/JaQFOlkPTQPKbBf+sB0HwATkpJjBjYCpHkXvy3l+LB Xg+NBHYtfxiRQwHcnYXOynDBNnmRXqt1Y9sodZKjUdDsfBRynMJBPd+bt21AhRYc69WM DOS4WhO6K4Oo4XOYxTYk8cqZyoBIkjRq7c4O3pNViYg5skoeqHc5uCCEZq03e9AUZ3xI FgVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JVsPYyeSs0Z89jpnz+/jWObtkdsoENnAN2PsMGBB0X8=; b=7ohHfOcNjZ4CBizkSoc3tovBHrqy71IgUGwR3q2h7X5xRzULVoxHKstD8RjbDeyjwM HC2Push9lc8uC1yDL+k7hzCURStgeIC6YUyeHNE2pxYaGDjUWk+AmaIlUFXjv1xgkjP/ Uko4HfGwzGAtQm6bp0/pwApIYdXIvOaub+Eqb1coAAKfoOQ3LTuPDEcPb+UHU9BpTLPL olVJy+gE7EHBY6FeBQXbIFn4DwcQivTfe20FpYCaKOfSuvUnnjwqLI5QjLaZcRreQF+1 xqFhso2mOWcoZgSMoI+mCbSSpJIrfRSwAL2aZKoTOXKEenA7v7Q7KzcSLHciSbjAYH++ PY6w== X-Gm-Message-State: AOAM530Ne/KZGkY72ZYDLInax57WihmXrxNsSH795iuAJCBCx9KVl7ev XQJxFL2OffmeEVwWPWLzaTo= X-Google-Smtp-Source: ABdhPJw57VZXKuh209lrx9BjCOI+QhODbcZjFyWAqCKVxPAtqvffXu2BoHojbDQtI0Ncc1Ggqfq3oA== X-Received: by 2002:a05:600c:6018:: with SMTP id az24mr9821191wmb.103.1640517916521; Sun, 26 Dec 2021 03:25:16 -0800 (PST) Received: from localhost.localdomain ([217.113.240.86]) by smtp.gmail.com with ESMTPSA id g12sm13654743wrd.71.2021.12.26.03.25.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Dec 2021 03:25:16 -0800 (PST) From: =?UTF-8?q?Jos=C3=A9=20Exp=C3=B3sito?= To: contact@emersion.fr Cc: ville.syrjala@linux.intel.com, dmitry.baryshkov@linaro.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@linux.ie, daniel@ffwll.ch, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, marex@denx.de, stefan@agner.ch, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, yannick.fertre@foss.st.com, philippe.cornu@foss.st.com, benjamin.gaignard@linaro.org, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, =?UTF-8?q?Jos=C3=A9=20Exp=C3=B3sito?= Subject: [PATCH v3 2/6] drm/plane: Fix typo in format_mod_supported documentation Date: Sun, 26 Dec 2021 12:24:59 +0100 Message-Id: <20211226112503.31771-3-jose.exposito89@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211226112503.31771-1-jose.exposito89@gmail.com> References: <20211226112503.31771-1-jose.exposito89@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix minor typo: "valdiate" -> "validate". Signed-off-by: Jos=C3=A9 Exp=C3=B3sito Reviewed-by: Simon Ser --- include/drm/drm_plane.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h index 0c1102dc4d88..06759badf99f 100644 --- a/include/drm/drm_plane.h +++ b/include/drm/drm_plane.h @@ -516,7 +516,7 @@ struct drm_plane_funcs { * This optional hook is used for the DRM to determine if the given * format/modifier combination is valid for the plane. This allows the * DRM to generate the correct format bitmask (which formats apply to - * which modifier), and to valdiate modifiers at atomic_check time. + * which modifier), and to validate modifiers at atomic_check time. * * If not present, then any modifier in the plane's modifier * list is allowed with any of the plane's formats. --=20 2.25.1 From nobody Wed Jul 1 07:50:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E278CC433EF for ; Sun, 26 Dec 2021 11:25:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233288AbhLZLZX (ORCPT ); Sun, 26 Dec 2021 06:25:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233265AbhLZLZU (ORCPT ); Sun, 26 Dec 2021 06:25:20 -0500 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9597DC06173E for ; Sun, 26 Dec 2021 03:25:19 -0800 (PST) Received: by mail-wr1-x433.google.com with SMTP id s1so26524900wra.6 for ; Sun, 26 Dec 2021 03:25:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=udzgSr2XOO8m43wZrlgxQCrOrIrYf8SlPUnoZjFzTYk=; b=aCJzevHTBUPOKcQPw7hm+UB6JT/t1Fj3BW8O/jb392wnD0zkTkz+ZRTgelV2Yqg4MX W56GKzMk7Dzv9jaWuj28ZGU0lVkjYx9uNQh/0FadJ8JoyS4D8EWW4CIAYW1tl0U9P7Lu lOPPBpLonGHs296MrSx6PHecvp6ye/GIP5RQ4mgs54meCrWhzDzzmfoqLTwl5T4r5ib9 Pu/3qMSp+gxIEeM+eE+BXjRwq2tGWwY7trJ/lA3Gq2QHZqATUNoI4JMtTWT95wDJflmL miGdPBFBHeeWcNJEd7MBupYAO07XGQ5e+OUbtSazNCYnC5IefApuP8gZt5MQQnVdZSo+ V4aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=udzgSr2XOO8m43wZrlgxQCrOrIrYf8SlPUnoZjFzTYk=; b=2Rp88VF22kPW8iiZ9ZXM5VZV/SbX8sWQ1u2mFL+hCJkoPyozi8HAUruBL39O7EpiZx R62KRrfLl/7IEoNfDSf8Z/SBenAhuj8fWORNmWiJxQbe+41m80HZ2NlAbl40j0NjADEU zXP+ClDn9Fkoe0Fa1t90amraMcOaDrLKTjz0TekBCrHaWYe0unPZySPi018bwXg/N9ty CX0EoHjQqVRr+tfxps+qz5PVjzye8oYhKlRHRYPCT6d1k+q5dkw3CuQep7vkUXblNEDH KXjfNTPUk6uaD6u8w58Ywr3sW0rqGQelIBUOxWLXqPvnDY8u7eysqi09QTITuE//6dE9 T1+g== X-Gm-Message-State: AOAM532bN9C58B0rQ8uC10y2jG66MXWrF5gYhlCzDSPyHspzjJIJQc4v MB+cTv3g0DgjZ/a6mJxfLWk= X-Google-Smtp-Source: ABdhPJxUGkExUZ7jGhhIux0K+s4/ECaFhn9zxSixHZY9ABIuQhk4H3r2v0oZ1KM30IAWTvYNQ1yqjg== X-Received: by 2002:a05:6000:1845:: with SMTP id c5mr9492151wri.499.1640517918125; Sun, 26 Dec 2021 03:25:18 -0800 (PST) Received: from localhost.localdomain ([217.113.240.86]) by smtp.gmail.com with ESMTPSA id g12sm13654743wrd.71.2021.12.26.03.25.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Dec 2021 03:25:17 -0800 (PST) From: =?UTF-8?q?Jos=C3=A9=20Exp=C3=B3sito?= To: contact@emersion.fr Cc: ville.syrjala@linux.intel.com, dmitry.baryshkov@linaro.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@linux.ie, daniel@ffwll.ch, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, marex@denx.de, stefan@agner.ch, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, yannick.fertre@foss.st.com, philippe.cornu@foss.st.com, benjamin.gaignard@linaro.org, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, =?UTF-8?q?Jos=C3=A9=20Exp=C3=B3sito?= Subject: [PATCH v3 3/6] drm/simple-kms: Drop format_mod_supported function Date: Sun, 26 Dec 2021 12:25:00 +0100 Message-Id: <20211226112503.31771-4-jose.exposito89@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211226112503.31771-1-jose.exposito89@gmail.com> References: <20211226112503.31771-1-jose.exposito89@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The "drm_plane_funcs.format_mod_supported" can be removed in favor of the default implementation. Signed-off-by: Jos=C3=A9 Exp=C3=B3sito --- drivers/gpu/drm/drm_simple_kms_helper.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/drm_simple_kms_helper.c b/drivers/gpu/drm/drm_= simple_kms_helper.c index 72989ed1baba..2c6aa67c6956 100644 --- a/drivers/gpu/drm/drm_simple_kms_helper.c +++ b/drivers/gpu/drm/drm_simple_kms_helper.c @@ -284,13 +284,6 @@ static void drm_simple_kms_plane_cleanup_fb(struct drm= _plane *plane, pipe->funcs->cleanup_fb(pipe, state); } =20 -static bool drm_simple_kms_format_mod_supported(struct drm_plane *plane, - uint32_t format, - uint64_t modifier) -{ - return modifier =3D=3D DRM_FORMAT_MOD_LINEAR; -} - static const struct drm_plane_helper_funcs drm_simple_kms_plane_helper_fun= cs =3D { .prepare_fb =3D drm_simple_kms_plane_prepare_fb, .cleanup_fb =3D drm_simple_kms_plane_cleanup_fb, @@ -339,7 +332,6 @@ static const struct drm_plane_funcs drm_simple_kms_plan= e_funcs =3D { .reset =3D drm_simple_kms_plane_reset, .atomic_duplicate_state =3D drm_simple_kms_plane_duplicate_state, .atomic_destroy_state =3D drm_simple_kms_plane_destroy_state, - .format_mod_supported =3D drm_simple_kms_format_mod_supported, }; =20 /** --=20 2.25.1 From nobody Wed Jul 1 07:50:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 057EBC4332F for ; Sun, 26 Dec 2021 11:25:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233298AbhLZLZ0 (ORCPT ); Sun, 26 Dec 2021 06:25:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233273AbhLZLZV (ORCPT ); Sun, 26 Dec 2021 06:25:21 -0500 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33E2AC061401 for ; Sun, 26 Dec 2021 03:25:21 -0800 (PST) Received: by mail-wm1-x32f.google.com with SMTP id e5so7505435wmq.1 for ; Sun, 26 Dec 2021 03:25:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2sH9LpoHKM1nYuCNdjrxssHqCL8Z5G+nLzADIXmtmn8=; b=mAetoydiC9DFErqK91+G/B0kP4LJaIEX6wTtFjgxIx2puQBkWT35g7OEs0I6Wxm4eT DIS4O5D0u43xloptLbFpnamIbkbZp4QW1A5pN+Ad2pADFD6SEdOMQyLza03nFZ8lW8/3 Eesto4lZJ3IicDl5rRiAAttyieCY8P8S5nM1MM/+1js3SzqevyK2awp22JsgoAOcP7eZ OptHCawHlqbW35aAG3+Wq4go/qCvwqqXt16SSXCJoYAnFMvUPqjB4E0JWPAhZRvtpJr8 /sV2Bn9XrAl+tgezM0TeuEPuu3A4TNULvoMGSlh58yjiIkGU3uZ6N06sfsiT5q/eDeSa /v2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2sH9LpoHKM1nYuCNdjrxssHqCL8Z5G+nLzADIXmtmn8=; b=R+3KSWPd4AZX5DKKu9Ptbd4FvUBRM7A7e5jvyqyhVGEP815SC8TXc7ZuEe00Bx68Sy lDIBVq55rbTgUqbbnZhZb6tooW9Zth/m/39EuegqdpI8P+MkKxrwb8yQgBgA8cRm+og0 52QsVUXGKlEFjUXsKkL1wRex6M35DmD7FPzNmSkn7pfS+c+J9IMbQeXjsPv1EqFt6Anq FiMc99O/uBRPf6Imrf4QKwJIOvaRU1xokqdZhDP6oQpaiVYumoSrvCTTKnEW8/VxSIuZ PW7KDWaHvxkTHmUp039v3bkL/4psvGDV/cHY7J/lrwKK3LpxXRGwIRWRDpFDfokIecjB 5H8w== X-Gm-Message-State: AOAM533CfSjF+Db+v5/XefjUVkZuJly0+9Rdls8o/fgRA4XmMMjFQAiw jJFPEssM53B4y5ybQkZltf4= X-Google-Smtp-Source: ABdhPJz4lUyJV89AeASjgwh8PQuZGePew9x5IF62xdHwLSvNvHxbwPsKoabWCJpDvO3twBCqWu015Q== X-Received: by 2002:a05:600c:3787:: with SMTP id o7mr10046954wmr.110.1640517919698; Sun, 26 Dec 2021 03:25:19 -0800 (PST) Received: from localhost.localdomain ([217.113.240.86]) by smtp.gmail.com with ESMTPSA id g12sm13654743wrd.71.2021.12.26.03.25.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Dec 2021 03:25:19 -0800 (PST) From: =?UTF-8?q?Jos=C3=A9=20Exp=C3=B3sito?= To: contact@emersion.fr Cc: ville.syrjala@linux.intel.com, dmitry.baryshkov@linaro.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@linux.ie, daniel@ffwll.ch, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, marex@denx.de, stefan@agner.ch, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, yannick.fertre@foss.st.com, philippe.cornu@foss.st.com, benjamin.gaignard@linaro.org, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, =?UTF-8?q?Jos=C3=A9=20Exp=C3=B3sito?= Subject: [PATCH v3 4/6] drm/i915/display: Drop format_mod_supported function Date: Sun, 26 Dec 2021 12:25:01 +0100 Message-Id: <20211226112503.31771-5-jose.exposito89@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211226112503.31771-1-jose.exposito89@gmail.com> References: <20211226112503.31771-1-jose.exposito89@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The "drm_plane_funcs.format_mod_supported" can be removed in favor of the default implementation. Signed-off-by: Jos=C3=A9 Exp=C3=B3sito --- drivers/gpu/drm/i915/display/intel_cursor.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_cursor.c b/drivers/gpu/drm/= i915/display/intel_cursor.c index 11842f212613..6a5e022f5e21 100644 --- a/drivers/gpu/drm/i915/display/intel_cursor.c +++ b/drivers/gpu/drm/i915/display/intel_cursor.c @@ -602,13 +602,6 @@ static bool i9xx_cursor_get_hw_state(struct intel_plan= e *plane, return ret; } =20 -static bool intel_cursor_format_mod_supported(struct drm_plane *_plane, - u32 format, u64 modifier) -{ - return modifier =3D=3D DRM_FORMAT_MOD_LINEAR && - format =3D=3D DRM_FORMAT_ARGB8888; -} - static int intel_legacy_cursor_update(struct drm_plane *_plane, struct drm_crtc *_crtc, @@ -745,7 +738,6 @@ static const struct drm_plane_funcs intel_cursor_plane_= funcs =3D { .destroy =3D intel_plane_destroy, .atomic_duplicate_state =3D intel_plane_duplicate_state, .atomic_destroy_state =3D intel_plane_destroy_state, - .format_mod_supported =3D intel_cursor_format_mod_supported, }; =20 struct intel_plane * --=20 2.25.1 From nobody Wed Jul 1 07:50:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D2F5C433FE for ; Sun, 26 Dec 2021 11:25:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233297AbhLZLZ2 (ORCPT ); Sun, 26 Dec 2021 06:25:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233282AbhLZLZX (ORCPT ); Sun, 26 Dec 2021 06:25:23 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1187C06173E for ; Sun, 26 Dec 2021 03:25:22 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id t18so26472042wrg.11 for ; Sun, 26 Dec 2021 03:25:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3uC+zpueN0jaqztWM7eUqBfpEMbmsR8tb66iIJAnvGU=; b=RwDE0YPkDLqtqo7Dvnlm/ydiYanOQlnAMem2isy3ndgorcODT7JcvNFIyr443LTwSg WliRTsg8U5K6xpvrcgejsyGKhya4NPPV1Uea3wAuINZpe69Qi4Co3GCY8+RCvB5zICJN 79sCOX7fKsf0zNbAvzhCEj30xYFAmhu4mxWkaRe0EvJkW/pW8fygcR8ybIZ/WTrgKhBW WcMktKG4ZIskNlW/H43GfZIK16XeZawEhw7iKEf6idJrc9oK20T4+HFBD3es+GpMVzr9 czP8Xc5f78UoC+IsRP3PfKQz9Rc6Zl71pPJ9HwZfuNpEHKkQuf3Bn8gfrACtKdQA8/At oNXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3uC+zpueN0jaqztWM7eUqBfpEMbmsR8tb66iIJAnvGU=; b=NvADWLi8kowgF0GnE0vIKJd8l6OYsrZLp+ORemlnRN34K1so90lhn6bOAwHN96TTD+ 03PeSZFrQxyjqozxPKRkqcyDEp7NaCalW3XiNgsM4vOhlnZvTz5/5SknxfkDeP9FOaMS VmXtEvyz59VkzlnO9Bzzwc1vqa90uxceW3rqkIZ7vJjxAEQfeooPYjuoNUAnmAyHRixu XkL01bYrLHWLZ+YlV3Me5sCxlmOBmCbxIvL8eAFYU5WvDUQBdlNVbyZJuH+f+VJHXy2X Pqu0fqJq/krAoS3ya9qln6MoDwVtv8OTUPEMjj6mUtP5HiSPY2Y5ILhBGjLlVv+DhRei qfmg== X-Gm-Message-State: AOAM531R9dOsf2yAFI2fxzCmol+JGxn052O/CSO7ILK2l9CjSyUopBFp toOHybJN6CDZTZqKX5bgTGk= X-Google-Smtp-Source: ABdhPJwPiaAlI5ue8SBY/hNuXdX5I1LiZxPv2bA/DypMkY+1VW51yINEbKM/DxTgrTs1AI5TJvkxhw== X-Received: by 2002:adf:9004:: with SMTP id h4mr9898117wrh.593.1640517921215; Sun, 26 Dec 2021 03:25:21 -0800 (PST) Received: from localhost.localdomain ([217.113.240.86]) by smtp.gmail.com with ESMTPSA id g12sm13654743wrd.71.2021.12.26.03.25.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Dec 2021 03:25:20 -0800 (PST) From: =?UTF-8?q?Jos=C3=A9=20Exp=C3=B3sito?= To: contact@emersion.fr Cc: ville.syrjala@linux.intel.com, dmitry.baryshkov@linaro.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@linux.ie, daniel@ffwll.ch, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, marex@denx.de, stefan@agner.ch, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, yannick.fertre@foss.st.com, philippe.cornu@foss.st.com, benjamin.gaignard@linaro.org, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, =?UTF-8?q?Jos=C3=A9=20Exp=C3=B3sito?= Subject: [PATCH v3 5/6] drm: mxsfb: Drop format_mod_supported function Date: Sun, 26 Dec 2021 12:25:02 +0100 Message-Id: <20211226112503.31771-6-jose.exposito89@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211226112503.31771-1-jose.exposito89@gmail.com> References: <20211226112503.31771-1-jose.exposito89@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The "drm_plane_funcs.format_mod_supported" can be removed in favor of the default implementation. Signed-off-by: Jos=C3=A9 Exp=C3=B3sito --- drivers/gpu/drm/mxsfb/mxsfb_kms.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c b/drivers/gpu/drm/mxsfb/mxsf= b_kms.c index 0655582ae8ed..df32e1c3cc5d 100644 --- a/drivers/gpu/drm/mxsfb/mxsfb_kms.c +++ b/drivers/gpu/drm/mxsfb/mxsfb_kms.c @@ -554,13 +554,6 @@ static void mxsfb_plane_overlay_atomic_update(struct d= rm_plane *plane, writel(ctrl, mxsfb->base + LCDC_AS_CTRL); } =20 -static bool mxsfb_format_mod_supported(struct drm_plane *plane, - uint32_t format, - uint64_t modifier) -{ - return modifier =3D=3D DRM_FORMAT_MOD_LINEAR; -} - static const struct drm_plane_helper_funcs mxsfb_plane_primary_helper_func= s =3D { .atomic_check =3D mxsfb_plane_atomic_check, .atomic_update =3D mxsfb_plane_primary_atomic_update, @@ -572,7 +565,6 @@ static const struct drm_plane_helper_funcs mxsfb_plane_= overlay_helper_funcs =3D { }; =20 static const struct drm_plane_funcs mxsfb_plane_funcs =3D { - .format_mod_supported =3D mxsfb_format_mod_supported, .update_plane =3D drm_atomic_helper_update_plane, .disable_plane =3D drm_atomic_helper_disable_plane, .destroy =3D drm_plane_cleanup, --=20 2.25.1 From nobody Wed Jul 1 07:50:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C23CC43217 for ; Sun, 26 Dec 2021 11:25:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233313AbhLZLZa (ORCPT ); Sun, 26 Dec 2021 06:25:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233293AbhLZLZY (ORCPT ); Sun, 26 Dec 2021 06:25:24 -0500 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D3D2C061757 for ; Sun, 26 Dec 2021 03:25:24 -0800 (PST) Received: by mail-wr1-x431.google.com with SMTP id d9so26632245wrb.0 for ; Sun, 26 Dec 2021 03:25:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3w0cyRxbnflG1Lzaa+D9LFgBBXj2WLi8B2+0IaB0cco=; b=PwXLZV+6O9zswzpPoQeLANPNLyAa5j9TTefYDsBvxzJHw7hsiT7vgEJO67viIuaBiK joS9USvBHQU7W3SIlSlVlgL1mYDZ9GdAj6OOVHGzOLhwrXOtxouH24D1FvTOcNPBx1hu cgYJFZ0JNDK45DRlTqL7+hohi4LKCBmpHJMZ7FYsBeaLfb3+QvZpNbnybehWxIYzAW9A zIdhrscxtU7zpauASJezylBL9be5Gt7PrhZ4YGNwtTDe/dk3r/8eHOBjzyS88i2wv2vz I6dy2YgPWM+zzpAj2FRI6ftDhWK37okU082jWiQr1P8b2ZnvThZubK2qMqrpGqHTwjcb AcZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3w0cyRxbnflG1Lzaa+D9LFgBBXj2WLi8B2+0IaB0cco=; b=3dvxusH76/Ayb4wOpdQ1DIuSVRA0nVf3BD/ALwH1S7qPsmEP++UMfyR3ClR0V9QoFI nplSpdst10baKGkiBtH3qpowvZvplfznVVms6B8xp9eGEdwRMUvQ2zCUSRuQ814SWEm5 qkDQy8e6gkXFgoXpyjEc42DhPblSjVOImsNIAGWP4u46sJsZQfIt1qrZsLzYkggYdGGc +5o0LrfNZQtjV1Ii09aVvOqBra8hfrvOZuUleY1jhA3r/HSfFaI1XVUP6avcUMv7MjG6 Y+RKt1jYGL8qVxaaerSfkqWmqwaITUausH8w6nImnbu4N1CApFXu23Ji2KM96JedQwBB 7yzQ== X-Gm-Message-State: AOAM532WP/G6gqOw3rcEeGzyEuppiJyhLwg10Ww3YelBpyuZxyvkuSZP 9HCiJB2FJQVruh2/cidpp4k= X-Google-Smtp-Source: ABdhPJyMMwBvN0I/TVcPJvi99lJUbcE0uky0CFSE//bOHq3fI8piG76lCpdID1rhkzRsL/yanK1mSw== X-Received: by 2002:a5d:638b:: with SMTP id p11mr9352371wru.241.1640517922894; Sun, 26 Dec 2021 03:25:22 -0800 (PST) Received: from localhost.localdomain ([217.113.240.86]) by smtp.gmail.com with ESMTPSA id g12sm13654743wrd.71.2021.12.26.03.25.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Dec 2021 03:25:22 -0800 (PST) From: =?UTF-8?q?Jos=C3=A9=20Exp=C3=B3sito?= To: contact@emersion.fr Cc: ville.syrjala@linux.intel.com, dmitry.baryshkov@linaro.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@linux.ie, daniel@ffwll.ch, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, marex@denx.de, stefan@agner.ch, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, yannick.fertre@foss.st.com, philippe.cornu@foss.st.com, benjamin.gaignard@linaro.org, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, =?UTF-8?q?Jos=C3=A9=20Exp=C3=B3sito?= Subject: [PATCH v3 6/6] drm/stm: ltdc: Drop format_mod_supported function Date: Sun, 26 Dec 2021 12:25:03 +0100 Message-Id: <20211226112503.31771-7-jose.exposito89@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211226112503.31771-1-jose.exposito89@gmail.com> References: <20211226112503.31771-1-jose.exposito89@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The "drm_plane_funcs.format_mod_supported" can be removed in favor of the default implementation. Signed-off-by: Jos=C3=A9 Exp=C3=B3sito --- drivers/gpu/drm/stm/ltdc.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c index dbdee954692a..ef909e50f0e4 100644 --- a/drivers/gpu/drm/stm/ltdc.c +++ b/drivers/gpu/drm/stm/ltdc.c @@ -925,16 +925,6 @@ static void ltdc_plane_atomic_print_state(struct drm_p= rinter *p, fpsi->counter =3D 0; } =20 -static bool ltdc_plane_format_mod_supported(struct drm_plane *plane, - u32 format, - u64 modifier) -{ - if (modifier =3D=3D DRM_FORMAT_MOD_LINEAR) - return true; - - return false; -} - static const struct drm_plane_funcs ltdc_plane_funcs =3D { .update_plane =3D drm_atomic_helper_update_plane, .disable_plane =3D drm_atomic_helper_disable_plane, @@ -943,7 +933,6 @@ static const struct drm_plane_funcs ltdc_plane_funcs = =3D { .atomic_duplicate_state =3D drm_atomic_helper_plane_duplicate_state, .atomic_destroy_state =3D drm_atomic_helper_plane_destroy_state, .atomic_print_state =3D ltdc_plane_atomic_print_state, - .format_mod_supported =3D ltdc_plane_format_mod_supported, }; =20 static const struct drm_plane_helper_funcs ltdc_plane_helper_funcs =3D { --=20 2.25.1