From nobody Wed Jul 1 12:20:12 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC36CC433F5 for ; Tue, 21 Dec 2021 23:06:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235211AbhLUXGF (ORCPT ); Tue, 21 Dec 2021 18:06:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235079AbhLUXGE (ORCPT ); Tue, 21 Dec 2021 18:06:04 -0500 Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90822C061574 for ; Tue, 21 Dec 2021 15:06:04 -0800 (PST) Received: by mail-qt1-x834.google.com with SMTP id 8so338161qtx.5 for ; Tue, 21 Dec 2021 15:06:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FvSSROr+K+Ysb8k8Dk2ivOhBjqdFNd8mpizso6zU3/E=; b=Z7actIIro4tY/xus/N4EsFgK5T9jrY0dmTypeQi6AUaC9+fHFPVQMmIULXW2jGAo0d Lg4XCvUqMW2jQkGUTHyb2ryBqpCpLxeJli0zuOiSPGSjaQjbsyeY6kFFdNs69qc7a4tx eFVFfLHlpvEshVaHOwpg5dw7MAv5UwO5AtmQzyMXvr1Yd7mIVB3jTLUYhlIqEONL1bW6 kWYYZRCafS/2ItN9idLtlc31g14b3xFgauk3z3fmMkndi0W0TBDTMqVMKMO5eafCX5r2 ciBdTYN0mJ5HOmd7OYTBsIuBQRjmWIDE9LdSRXA6M17ly6l/D28HhE6sIhgoEjVYH01w FjiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FvSSROr+K+Ysb8k8Dk2ivOhBjqdFNd8mpizso6zU3/E=; b=2BXE6CKzjpEw4cfFSAzmoZYM2B1/efq/vL3FTqlRA1McADrFBt98YZlSx9ofuj10y5 YFCpUe/xTb3bzUAN294E6SkLx35Sv0M4LgLWPIf1qTKVbgLuUx1nUIO/E3PLro9SxhJl WhZyxwm7zuTLAp6M0XFzbD4pOv7W3sWJhcJIHdMUO7HPVCSLq05yLaOqMJH0hs/4ChmI oOJsKRmOe6uvPCvcA8yKxCsEn6QTJaY/HeTadhnUlZNtadaynLpiaFM7gUW4RDiIQEpA deWD5ogg9TGfaqkctiPgceCzrKmfSiQZcDuR5IfaO09hqqj2iVsrf+CH5QvqDUaGkmMs tqMw== X-Gm-Message-State: AOAM531uTc3U0AWirSRzE9kWiFR1JOKCmdJbI5ZESFMm9esrh/5+DUAr EYDBUsd0q3dvqsa9MAbJNGEma7mY18RgnQ== X-Google-Smtp-Source: ABdhPJwhqxDrZonZy2PZJUkfNCxSLYysjkIJJJDt2kCyWtrUAYvbCVWd4nIhKKhHcjzRx57beYoxWw== X-Received: by 2002:a05:622a:24b:: with SMTP id c11mr365036qtx.19.1640127963664; Tue, 21 Dec 2021 15:06:03 -0800 (PST) Received: from master-x64.sparksnet (c-98-233-193-225.hsd1.md.comcast.net. [98.233.193.225]) by smtp.gmail.com with ESMTPSA id s6sm365165qko.43.2021.12.21.15.06.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Dec 2021 15:06:03 -0800 (PST) From: Peter Geis To: Lee Jones Cc: Peter Geis , Robin Murphy , Heiko Stuebner , linux-rockchip@lists.infradead.org, Nicolas Frattaroli , Dmitry Osipenko , Frank Wunderlich , linux-kernel@vger.kernel.org Subject: [PATCH v4] mfd: rk808: add reboot support to rk808.c Date: Tue, 21 Dec 2021 18:05:50 -0500 Message-Id: <20211221230550.1331047-1-pgwipeout@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This adds reboot support to the rk808 pmic driver and enables it for the rk809 and rk817 devices. This only enables if the rockchip,system-power-controller flag is set. Signed-off-by: Peter Geis Signed-off-by: Frank Wunderlich Reviewed-by: Dmitry Osipenko --- (Resending due to incorrect Subject line) This patch was created to address issues with psci-reset on rk356x chips. Until the rk356x series ATF open source code is released so we can fix the issue at the source, this is the only way to ensure reliable resetting on devices using these chips. After testing the rk808 (thanks Robin!), it was found DEV_OFF_RST does not reset the PMIC to a power on state. Since the rk805 and rk818 match this register layout, I'm removing support for all three in the v2. It may be possible to add support to them using an RTC wakeup, but that has not been explored and is outside the scope of this patch. Changelog: V4: - reorder rk808_restart_notify (Thanks Dmitry) - drop of_property_read_bool before unregister (Good catch Frank) V3: Thanks Dmitry! - Adjust priority to be in line with other pmic drivers - Move ret handling to case switch - Make default registration debug - Add unregister function on removal V2: - Squash the patch from Frank Wunderlich for rk809 support. - Remove support for the rk805, rk808, and rk818 devices. - Only register the reset handler for supported devices. - Remove unnecessary dev_err and dev_warn statements. - Register the reset handler directly drivers/mfd/rk808.c | 44 +++++++++++++++++++++++++++++++++++++++ include/linux/mfd/rk808.h | 1 + 2 files changed, 45 insertions(+) diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c index b181fe401330..874d461dda44 100644 --- a/drivers/mfd/rk808.c +++ b/drivers/mfd/rk808.c @@ -19,6 +19,7 @@ #include #include #include +#include =20 struct rk808_reg_data { int addr; @@ -543,6 +544,7 @@ static void rk808_pm_power_off(void) reg =3D RK808_DEVCTRL_REG, bit =3D DEV_OFF_RST; break; + case RK809_ID: case RK817_ID: reg =3D RK817_SYS_CFG(3); bit =3D DEV_OFF; @@ -559,6 +561,34 @@ static void rk808_pm_power_off(void) dev_err(&rk808_i2c_client->dev, "Failed to shutdown device!\n"); } =20 +static int rk808_restart_notify(struct notifier_block *this, unsigned long= mode, void *cmd) +{ + struct rk808 *rk808 =3D i2c_get_clientdata(rk808_i2c_client); + unsigned int reg, bit; + int ret; + + switch (rk808->variant) { + case RK809_ID: + case RK817_ID: + reg =3D RK817_SYS_CFG(3); + bit =3D DEV_RST; + break; + + default: + return NOTIFY_DONE; + } + ret =3D regmap_update_bits(rk808->regmap, reg, bit, bit); + if (ret) + dev_err(&rk808_i2c_client->dev, "Failed to restart device!\n"); + + return NOTIFY_DONE; +} + +static struct notifier_block rk808_restart_handler =3D { + .notifier_call =3D rk808_restart_notify, + .priority =3D 192, +}; + static void rk8xx_shutdown(struct i2c_client *client) { struct rk808 *rk808 =3D i2c_get_clientdata(client); @@ -727,6 +757,18 @@ static int rk808_probe(struct i2c_client *client, if (of_property_read_bool(np, "rockchip,system-power-controller")) { rk808_i2c_client =3D client; pm_power_off =3D rk808_pm_power_off; + + switch (rk808->variant) { + case RK809_ID: + case RK817_ID: + ret =3D register_restart_handler(&rk808_restart_handler); + if (ret) + dev_warn(&client->dev, "failed to register restart handler, %d\n", ret= ); + break; + default: + dev_dbg(&client->dev, "pmic controlled board reset not supported\n"); + break; + } } =20 return 0; @@ -749,6 +791,8 @@ static int rk808_remove(struct i2c_client *client) if (pm_power_off =3D=3D rk808_pm_power_off) pm_power_off =3D NULL; =20 + unregister_restart_handler(&rk808_restart_handler); + return 0; } =20 diff --git a/include/linux/mfd/rk808.h b/include/linux/mfd/rk808.h index a96e6d43ca06..58602032e642 100644 --- a/include/linux/mfd/rk808.h +++ b/include/linux/mfd/rk808.h @@ -373,6 +373,7 @@ enum rk805_reg { #define SWITCH2_EN BIT(6) #define SWITCH1_EN BIT(5) #define DEV_OFF_RST BIT(3) +#define DEV_RST BIT(2) #define DEV_OFF BIT(0) #define RTC_STOP BIT(0) =20 --=20 2.25.1