From nobody Wed Jul 1 17:38:48 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E3A3C433EF for ; Fri, 17 Dec 2021 12:26:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236266AbhLQM0q (ORCPT ); Fri, 17 Dec 2021 07:26:46 -0500 Received: from esa.microchip.iphmx.com ([68.232.154.123]:31965 "EHLO esa.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236248AbhLQM0p (ORCPT ); Fri, 17 Dec 2021 07:26:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1639744005; x=1671280005; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=V5ZR6s8MB7+mpb2lz2QxEhkfyBBpZFRy1C+27uyk7k4=; b=D3YG/RLFXjetWuexsd0Gj84KrYt7yusDD4B9GwNEUQkESkiAnuvHBY2s 376e62O8aAaHuK9C7Tsmt28p+2mm+wwHClHD3HGsP3r5SeKsXOHjnr4OV CmaXIj7UKiOYH09xUbVMrAGFkhMRWvh/dbosYb5sxCiEND+y1ewLFyBxk PaLjqMRtx2Ny0eFgGHwJFk1UBVlEO+1wllVFQJaGCO9OkRNhasFdCB1SF AGxowSnFZrHPertUIQ6HuZlYcOXM/6NbHnOokdFDGzl2LDBtPQdsBaDOH OlUtcgSvGBx1bDhcK93mMVN+Nv/LziupMB+Hylid6+skNjE0iA+WisTj6 g==; IronPort-SDR: vrusUyFqdmu3lle/KGNTDzL8oeCzklp9GWQ4094UuC0+YBvFSLNeYyRXrWKbo9WmtUkBoZ8s/K 9NWUSLvP33Eku8rSvuwVRc+0xY6U/FZhi1mwD1nQIx+AXhANtKQB4XefFF4brFsMSqK024PKii tNOCtXgYWfNtTUSk9ob/8umQsaqcD+NrtaZVGTCbKnMMnMAq/p1ORToDXJOOzC/eKRGfVOIgIk BFN/bdoN/tZPFLSZDun5uAX37sR2l+XtoU92jKYukrUQl/8g1lt4M2JlL6mE77hrd0m1iwiSOI EXO6hgHsxQIGC1e6qq9bP53R X-IronPort-AV: E=Sophos;i="5.88,213,1635231600"; d="scan'208";a="140126600" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 17 Dec 2021 05:26:44 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Fri, 17 Dec 2021 05:26:44 -0700 Received: from ROB-ULT-M18064N.mchp-main.com (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.2375.17 via Frontend Transport; Fri, 17 Dec 2021 05:26:41 -0700 From: Tudor Ambarus To: , , , , , CC: , , "Tudor Ambarus" Subject: [PATCH 1/2] mtd: spi-nor: Remove debugfs entries that duplicate sysfs entries Date: Fri, 17 Dec 2021 14:26:35 +0200 Message-ID: <20211217122636.474976-2-tudor.ambarus@microchip.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211217122636.474976-1-tudor.ambarus@microchip.com> References: <20211217122636.474976-1-tudor.ambarus@microchip.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" SPI NOR sysfs defines partname and jedec_id device attributes, which duplicate the information from debugfs. Since the sysfs directory structure and the attributes in each directory define an ABI between the kernel and user space, thus it can never be removed, remove the debugfs entries so that we don't duplicate the information. Signed-off-by: Tudor Ambarus Reviewed-by: Pratyush Yadav --- drivers/mtd/spi-nor/core.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c index 2e21d5ac0e2d..435bd17af0b4 100644 --- a/drivers/mtd/spi-nor/core.c +++ b/drivers/mtd/spi-nor/core.c @@ -3126,16 +3126,6 @@ static const struct flash_info *spi_nor_match_id(str= uct spi_nor *nor, return NULL; } =20 -static void spi_nor_debugfs_init(struct spi_nor *nor, - const struct flash_info *info) -{ - struct mtd_info *mtd =3D &nor->mtd; - - mtd->dbg.partname =3D info->name; - mtd->dbg.partid =3D devm_kasprintf(nor->dev, GFP_KERNEL, "spi-nor:%*phN", - info->id_len, info->id); -} - static const struct flash_info *spi_nor_get_flash_info(struct spi_nor *nor, const char *name) { @@ -3243,8 +3233,6 @@ int spi_nor_scan(struct spi_nor *nor, const char *nam= e, =20 nor->info =3D info; =20 - spi_nor_debugfs_init(nor, info); - mutex_init(&nor->lock); =20 /* Init flash parameters based on flash_info struct and SFDP */ --=20 2.25.1 From nobody Wed Jul 1 17:38:48 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61C06C433EF for ; Fri, 17 Dec 2021 12:27:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236347AbhLQM1E (ORCPT ); Fri, 17 Dec 2021 07:27:04 -0500 Received: from esa.microchip.iphmx.com ([68.232.154.123]:31989 "EHLO esa.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236322AbhLQM0v (ORCPT ); Fri, 17 Dec 2021 07:26:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1639744010; x=1671280010; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=o0b6NEaAdzRZp/oj1QR5jmYHPgsawDkmnu8lKNhP8dA=; b=ifY5eA6dVX2Vvqt8Y2RDgIDxF7a8DYdDmGZ3w31/V09uUWuWc1usfq+B 8tioqOGDnMAXIA9idLY58I8wcPSKhM4XaBRCAZFP0Za2b2a9ynqJaArBE d4ZscUzz8DzxXV5Fbj36tXL34nIZ/To/6huBFbYtvUCUCKoAFmywIWIcj Dt9ZQ8JTNyvCRJCoSqRK2tMOSRcKtbuRinI5+hNxVq4acDzWVMYtQFKul bTae2ZrBYuvbyBdc6ZZYDpyG7HpAubHoVkRMreJzxYLWu3p4/3dAP8PNZ hsmv+kuTFSmjaJ1VeTdcnf34gHvL8pR8Ck2neD41ZidvAYuTlG6acJ7Y8 A==; IronPort-SDR: FXsndbt7yXlNiJ4sCLGUWhx1mMiHe7cPP9NtEGIoqGaRmhTM7/L2AAVFoc+5tzYl9BpDrZ0iII z7dv0P6qRQ7zIyDKgDZvoFVwSGcfGkBQB47b5N2INR8JAN24MgwzMO6hLGH9/+tdY7DHop6rCQ uGYS9TiSsvSudvW5CZjt8YZmWcsYX8aKCRuIWVehzLOMqldRqiXB3yEEwo98nMJDQ6BH6U+8/+ WzJSQDlmjda6Rxvhbd14lCaCvNnrkPJT3hjChcgB01rodpc5XjfM8YmN76qbhzPr4Smf0sAXpt 36ykzbXkd7hI4a0LjMbsaRSs X-IronPort-AV: E=Sophos;i="5.88,213,1635231600"; d="scan'208";a="140126610" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 17 Dec 2021 05:26:49 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Fri, 17 Dec 2021 05:26:46 -0700 Received: from ROB-ULT-M18064N.mchp-main.com (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.2375.17 via Frontend Transport; Fri, 17 Dec 2021 05:26:44 -0700 From: Tudor Ambarus To: , , , , , CC: , , "Tudor Ambarus" Subject: [PATCH 2/2] mtd: core: Remove partid and partname debugfs files Date: Fri, 17 Dec 2021 14:26:36 +0200 Message-ID: <20211217122636.474976-3-tudor.ambarus@microchip.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211217122636.474976-1-tudor.ambarus@microchip.com> References: <20211217122636.474976-1-tudor.ambarus@microchip.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" partid and partname debugfs file are no longer used in mtd, remove dead code. Signed-off-by: Tudor Ambarus --- drivers/mtd/mtdcore.c | 35 +---------------------------------- include/linux/mtd/mtd.h | 3 --- 2 files changed, 1 insertion(+), 37 deletions(-) diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c index 9186268d361b..1977755fc955 100644 --- a/drivers/mtd/mtdcore.c +++ b/drivers/mtd/mtdcore.c @@ -336,49 +336,16 @@ static const struct device_type mtd_devtype =3D { .release =3D mtd_release, }; =20 -static int mtd_partid_debug_show(struct seq_file *s, void *p) -{ - struct mtd_info *mtd =3D s->private; - - seq_printf(s, "%s\n", mtd->dbg.partid); - - return 0; -} - -DEFINE_SHOW_ATTRIBUTE(mtd_partid_debug); - -static int mtd_partname_debug_show(struct seq_file *s, void *p) -{ - struct mtd_info *mtd =3D s->private; - - seq_printf(s, "%s\n", mtd->dbg.partname); - - return 0; -} - -DEFINE_SHOW_ATTRIBUTE(mtd_partname_debug); - static struct dentry *dfs_dir_mtd; =20 static void mtd_debugfs_populate(struct mtd_info *mtd) { - struct mtd_info *master =3D mtd_get_master(mtd); struct device *dev =3D &mtd->dev; - struct dentry *root; =20 if (IS_ERR_OR_NULL(dfs_dir_mtd)) return; =20 - root =3D debugfs_create_dir(dev_name(dev), dfs_dir_mtd); - mtd->dbg.dfs_dir =3D root; - - if (master->dbg.partid) - debugfs_create_file("partid", 0400, root, master, - &mtd_partid_debug_fops); - - if (master->dbg.partname) - debugfs_create_file("partname", 0400, root, master, - &mtd_partname_debug_fops); + mtd->dbg.dfs_dir =3D debugfs_create_dir(dev_name(dev), dfs_dir_mtd); } =20 #ifndef CONFIG_MMU diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h index f5e7dfc2e4e9..00cb269d0261 100644 --- a/include/linux/mtd/mtd.h +++ b/include/linux/mtd/mtd.h @@ -188,9 +188,6 @@ struct module; /* only needed for owner field in mtd_in= fo */ */ struct mtd_debug_info { struct dentry *dfs_dir; - - const char *partname; - const char *partid; }; =20 /** --=20 2.25.1