From nobody Wed Jul 1 21:31:43 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FCB0C35278 for ; Wed, 15 Dec 2021 16:01:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244328AbhLOP4H (ORCPT ); Wed, 15 Dec 2021 10:56:07 -0500 Received: from marcansoft.com ([212.63.210.85]:52888 "EHLO mail.marcansoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244285AbhLOP4D (ORCPT ); Wed, 15 Dec 2021 10:56:03 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: hector@marcansoft.com) by mail.marcansoft.com (Postfix) with ESMTPSA id 73E38421F5; Wed, 15 Dec 2021 15:55:59 +0000 (UTC) From: Hector Martin To: Sven Peter , Jassi Brar , Rob Herring Cc: Hector Martin , Alyssa Rosenzweig , Mark Kettenis , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v2 1/2] dt-bindings: mailbox: apple,mailbox: Add generic and t6000 compatibles Date: Thu, 16 Dec 2021 00:55:26 +0900 Message-Id: <20211215155527.36775-2-marcan@marcan.st> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211215155527.36775-1-marcan@marcan.st> References: <20211215155527.36775-1-marcan@marcan.st> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Much as we've done with other blocks, let's introduce generic compatibles so drivers can bind to those and still work with future SoCs, as long as the hardware remains the same. Also go ahead and add compatibles for the new t600x SoCs (we group those as t6000). Note that no DTs instantiate devices with this binding yet. Reviewed-by: Mark Kettenis Signed-off-by: Hector Martin Reviewed-by: Rob Herring Reviewed-by: Sven Peter --- .../devicetree/bindings/mailbox/apple,mailbox.yaml | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/mailbox/apple,mailbox.yaml b= /Documentation/devicetree/bindings/mailbox/apple,mailbox.yaml index 2c1704b34e7a..e3d87239811c 100644 --- a/Documentation/devicetree/bindings/mailbox/apple,mailbox.yaml +++ b/Documentation/devicetree/bindings/mailbox/apple,mailbox.yaml @@ -27,14 +27,20 @@ properties: for example for the display controller, the system management controller and the NVMe coprocessor. items: - - const: apple,t8103-asc-mailbox + - enum: + - apple,t8103-asc-mailbox + - apple,t6000-asc-mailbox + - const: apple,asc-mailbox-v4 =20 - description: M3 mailboxes are an older variant with a slightly different MMIO interface still found on the M1. It is used for the Thunderbolt co-processors. items: - - const: apple,t8103-m3-mailbox + - enum: + - apple,t8103-m3-mailbox + - apple,t6000-m3-mailbox + - const: apple,m3-mailbox-v2 =20 reg: maxItems: 1 @@ -68,7 +74,7 @@ additionalProperties: false examples: - | mailbox@77408000 { - compatible =3D "apple,t8103-asc-mailbox"; + compatible =3D "apple,t8103-asc-mailbox", "apple,asc-mailb= ox-v4"; reg =3D <0x77408000 0x4000>; interrupts =3D <1 583 4>, <1 584 4>, <1 585 4>, <1 586 4>; interrupt-names =3D "send-empty", "send-not-empty", --=20 2.33.0 From nobody Wed Jul 1 21:31:43 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 980F1C3527B for ; Wed, 15 Dec 2021 16:01:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244323AbhLOP4N (ORCPT ); Wed, 15 Dec 2021 10:56:13 -0500 Received: from marcansoft.com ([212.63.210.85]:52918 "EHLO mail.marcansoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244287AbhLOP4G (ORCPT ); Wed, 15 Dec 2021 10:56:06 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: hector@marcansoft.com) by mail.marcansoft.com (Postfix) with ESMTPSA id 84F53424D0; Wed, 15 Dec 2021 15:56:02 +0000 (UTC) From: Hector Martin To: Sven Peter , Jassi Brar , Rob Herring Cc: Hector Martin , Alyssa Rosenzweig , Mark Kettenis , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v2 2/2] mailbox: apple: Bind to generic compatibles Date: Thu, 16 Dec 2021 00:55:27 +0900 Message-Id: <20211215155527.36775-3-marcan@marcan.st> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211215155527.36775-1-marcan@marcan.st> References: <20211215155527.36775-1-marcan@marcan.st> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" As with other blocks, we intend to have drivers bind to generic compatibles as long as there are no SoC-specific quirks. This allows forward-compatibility with future SoCs. No upstream DTs instantiate this yet, so it's still safe to make this breaking change. Signed-off-by: Hector Martin --- drivers/mailbox/apple-mailbox.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mailbox/apple-mailbox.c b/drivers/mailbox/apple-mailbo= x.c index 72942002a54a..496c4951ccb1 100644 --- a/drivers/mailbox/apple-mailbox.c +++ b/drivers/mailbox/apple-mailbox.c @@ -364,8 +364,8 @@ static const struct apple_mbox_hw apple_mbox_m3_hw =3D { }; =20 static const struct of_device_id apple_mbox_of_match[] =3D { - { .compatible =3D "apple,t8103-asc-mailbox", .data =3D &apple_mbox_asc_hw= }, - { .compatible =3D "apple,t8103-m3-mailbox", .data =3D &apple_mbox_m3_hw }, + { .compatible =3D "apple,asc-mailbox-v4", .data =3D &apple_mbox_asc_hw }, + { .compatible =3D "apple,m3-mailbox-v2", .data =3D &apple_mbox_m3_hw }, {} }; MODULE_DEVICE_TABLE(of, apple_mbox_of_match); --=20 2.33.0