From nobody Sun Sep 22 13:29:52 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2829FC4332F for ; Thu, 4 Nov 2021 01:40:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0E946611EE for ; Thu, 4 Nov 2021 01:40:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232956AbhKDBn1 (ORCPT ); Wed, 3 Nov 2021 21:43:27 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:60176 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S232918AbhKDBnY (ORCPT ); Wed, 3 Nov 2021 21:43:24 -0400 X-UUID: dd3ec9a3dceb43678b58dfa50f612cf4-20211104 X-UUID: dd3ec9a3dceb43678b58dfa50f612cf4-20211104 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1202912524; Thu, 04 Nov 2021 09:40:45 +0800 Received: from mtkmbs10n2.mediatek.inc (172.21.101.183) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Thu, 4 Nov 2021 09:40:43 +0800 Received: from localhost.localdomain (10.17.3.154) by mtkmbs10n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Thu, 4 Nov 2021 09:40:42 +0800 From: Zhiyong Tao To: , , , , CC: , , , , , , , , , , , , Guodong Liu Subject: [PATCH] pinctrl: mediatek: fix global-out-of-bounds issue Date: Thu, 4 Nov 2021 09:40:39 +0800 Message-ID: <20211104014039.26772-2-zhiyong.tao@mediatek.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211104014039.26772-1-zhiyong.tao@mediatek.com> References: <20211104014039.26772-1-zhiyong.tao@mediatek.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Guodong Liu When eint virtual eint number is greater than gpio number, it maybe produce 'desc[eint_n]' size globle-out-of-bounds issue. Signed-off-by: Zhiyong Tao Signed-off-by: Guodong Liu --- drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pin= ctrl/mediatek/pinctrl-mtk-common-v2.c index 45ebdeba985a..9d57c897835c 100644 --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c @@ -286,7 +286,8 @@ static int mtk_xt_get_gpio_n(void *data, unsigned long = eint_n, *gpio_chip =3D &hw->chip; =20 /* Be greedy to guess first gpio_n is equal to eint_n */ - if (desc[eint_n].eint.eint_n =3D=3D eint_n) + if (((*gpio_chip)->ngpio > eint_n) && + desc[eint_n].eint.eint_n =3D=3D eint_n) *gpio_n =3D eint_n; else *gpio_n =3D mtk_xt_find_eint_num(hw, eint_n); --=20 2.25.1