From nobody Thu Apr 2 12:37:01 2026 Received: from mail-07.mail-europe.com (mail-0701.mail-europe.com [51.83.17.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 867CE13A3ED for ; Sun, 29 Mar 2026 02:03:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=51.83.17.38 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774749840; cv=none; b=lLp10qVbctAZhtLYn1Km689fm3XKMuHHBHOlH2IU72QsIiY1NZBEc0P5c2h+1lXze+laD0rTLsTDKUKItRyMUti/+XsK40QMqq2EGuLIpVRt12tSMo4LIwvCOy360hOL5ck4L6BEfF6T9ztUdpi26qIw2MyMV8w3SEsMp4AQZK4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774749840; c=relaxed/simple; bh=MPpX+1V6sVnrbYjFzZoWq8S2QJs+13VLPXX8jUTZTI0=; h=Date:To:From:Cc:Subject:Message-ID:MIME-Version:Content-Type; b=FXDv0J4pWqoaVAsRL8bvmcw+aaCUECv4o6nP7AujURQOKYzvxGGKtrhYeFpr06iMmX+HGBOfA6ReVRSILNmEEF2J2MCWngI1IXD/Fss+X38QWKCyo+UtJNFHiBqEKnttEhTdwc8Mgq0FFDXuD9CAIXi4k8jLkYg6PG2PcosE5mc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=proton.me; spf=fail smtp.mailfrom=proton.me; dkim=pass (2048-bit key) header.d=proton.me header.i=@proton.me header.b=ERsfArzz; arc=none smtp.client-ip=51.83.17.38 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=proton.me Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=proton.me Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=proton.me header.i=@proton.me header.b="ERsfArzz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1774749821; x=1775009021; bh=jw7+sfd+qB0vbVbLoMklzSKEktx9W18DbP2b4yckE6w=; h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=ERsfArzzV92+H7OtUJKXH+gRSGPlsbzrQR3grewV/1WUKEyLS786ALUKRgeCj0Txn Bm//TJRydyyh5x5wxQuCm2LeYdGIELt+B3JpTxRVPfhsNB+XQ2cLE/TykTaYPUjA/x jgpXTRSb+curNe1+wqvrICF/FFuPX9Ej7a0+BxFxElQZPbiRBT94CsHrfFucUBWS5A doINANtiS0NFsFFfs16wLZeW62ewxZ8GZ7dC6m2x0S9XK2yFFg0zloV54SIYLf4Qw2 30JHO9oR11C1hVa3KZVIfev7jEUz65BpHQszrymWutLvlZjZ9z2ToKq4EWmnBcseRB hAaSip7uu0Bww== Date: Sun, 29 Mar 2026 02:03:38 +0000 To: "sfrench@samba.org" From: FredTheDude Cc: "pc@manguebit.org" , "ronniesahlberg@gmail.com" , "sprasad@microsoft.com" , "tom@talpey.com" , "bharathsm@microsoft.com" , "linux-cifs@vger.kernel.org" , "samba-technical@lists.samba.org" , "linux-kernel@vger.kernel.org" Subject: [PATCH] fs/smb/client: add verbose error logging for UNC parsing Message-ID: <2__2tXx9Hngg7rDwgOdZVY8FFBkjQGk_0TviV3dVWkoCa9CZznTtxHJsVvgg9U0lyXUo-_6KKPTPFZTIGTLo9YfQczBj2CxTZypXB2ydr7c=@proton.me> Feedback-ID: 151443565:user:proton X-Pm-Message-ID: e1b80ed98d432ae410aefef9a25b1ff45a792b96 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add cifs_dbg(VFS, ...) statements to smb3_parse_devname() to provide explicit feedback when parsing fails. Currently, the function returns -EINVAL silently, making it difficult to debug mount failures caused by malformed paths or missing share names. Signed-off-by: Fredric Cover --- If I made any stupid mistakes, please be patient with me. C is not my best language, and this is my first patch, and I am just a high= school freshman. Thanks! --- fs/smb/client/fs_context.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/fs/smb/client/fs_context.c b/fs/smb/client/fs_context.c index a4a7c7eee..03c112f4d 100644 --- a/fs/smb/client/fs_context.c +++ b/fs/smb/client/fs_context.c @@ -658,13 +658,17 @@ smb3_parse_devname(const char *devname, struct smb3_f= s_context *ctx) /* make sure we have a valid UNC double delimiter prefix */ len =3D strspn(devname, delims); - if (len !=3D 2) + if (len !=3D 2) { + cifs_dbg(VFS, "UNC: path must begin with // or \\\\\n"); return -EINVAL; + } /* find delimiter between host and sharename */ pos =3D strpbrk(devname + 2, delims); - if (!pos) + if (!pos) { + cifs_dbg(VFS, "UNC: missing delimiter between hostname and = share name\n"); return -EINVAL; + } /* record the server hostname */ kfree(ctx->server_hostname); @@ -677,8 +681,10 @@ smb3_parse_devname(const char *devname, struct smb3_fs= _context *ctx) /* now go until next delimiter or end of string */ len =3D strcspn(pos, delims); - if (!len) + if (!len) { + cifs_dbg(VFS, "UNC: missing share name\n"); return -EINVAL; + } /* move "pos" up to delimiter or NULL */ pos +=3D len; -- 2.43.0