From nobody Mon Dec 1 22:34:53 2025 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09BD52405ED for ; Thu, 27 Nov 2025 05:11:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764220312; cv=none; b=fT05mn2m7KdseVE/l/wSBUJiuJO/GO4JEVBWd5UHbgvtdtfVpFnc02eX9+E8PiVG2fZUr2UQEFB8Dfge32Lw5bB0l4EE6kTpVYPfEEBZpItB8XZKbcr2ePscPJ2TqvlZeygpq2/JIIVqW+XgboyVg+65lxvAunTcgX5TvlMxvHg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764220312; c=relaxed/simple; bh=xqoXGsLfHU7BEABl2Nwm5NzQvKTRoqZO3QwTLG4qSB4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Db2lsLH2cEhjw1Fitv56nt0a0Ie0g+JaVB2k2/fBq/ahnp7RQae4fhZQKeCW2wyGX4EFJLY4YlDP6DG/CAVB1XFB2qmETa+TYCs+M0oHsmSiXXX0i3D8bbdvvxUwhpwge75edpXn2EaFXtDHgsHKDPuXJ6Sy7oMeiYfkW+4d+IA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fJ73wRL9; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fJ73wRL9" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2980d9b7df5so5659385ad.3 for ; Wed, 26 Nov 2025 21:11:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764220310; x=1764825110; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lH7KcWGBcyMFUXjXeQ0ZgXTh7zF56Hw8Qv1tMObDrw8=; b=fJ73wRL9ZxHL/DCrdaQGYOmOdzDcJgx8q9ohDMIW9r9nCbzYZ1y3X1mu/OIrvQjv0c bENHrhGXOSx0O/Ac6dRLcyF1GvgsV9DcufnHOrWDEKWxAL2gl1mmOCcSRy68QxkQHgJf UZt6fXr4rA2/x8t/Lzde0+7ePncyyRqxwG9u1dGwn8/mSOD7AT37ZBwCX++0eJGAp+n7 UXbGLMAJ+vMJjKwW57e+RP46FLeunBQhPx6NDexMTcuKXtGaX/TX8mHAzYv6xee9vrwG 8VptozSF+BPK0HCygMP+Kxgyazckz642R1qa6nziQf2T6U6l8gStv+FPmIil1hPoY3N7 u/lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764220310; x=1764825110; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lH7KcWGBcyMFUXjXeQ0ZgXTh7zF56Hw8Qv1tMObDrw8=; b=s+PJFwDymmgr95x2oyYTG7OX9dFA4/NNRIDSNmvUASOq12IZhjwn4Sh1CIVoSfSJrI AdGFRJMPviN7+qpQrlz06NuSx1m54eAwzEdPXkYnP76+RDwWRB3Y5lMnoo5XEa/3/+HZ Rlnj8M9J5J+Ba0AaV+LZBseSVRgNKVkia8t1t3Po7u6aYmbk2Zz2hPEX4cziWGPnStlP IAENQIPO86d9DAQhv3IHkMfpJPw5MKL8PqcBFwds6nk+8cg3Y7034ztdyZELrIHUsVc1 jBL0H0lOvlvJQWhKHGOruziNcYqMqOXKDI/PMyOwmbTvYjgY64oTrRw+nz4JPWoBCAhz FemQ== X-Forwarded-Encrypted: i=1; AJvYcCVysBHO9he+H+iUHhaxyqiUIzTeRiLyz/QrjPS5DveBeKVGLoK9C7rRf3xL8I1Xjl8K6hueXFCFrESasUY=@vger.kernel.org X-Gm-Message-State: AOJu0YyobQxlah09caGOEhvd2RZCf+C8e6Z5th1NUMVjBwmg1zczknRV +t4ksrEAFzQKhMTRfzhB3wn5RN5M1BbNLl5gFAFBq6HYIIxCR+XOAMCq X-Gm-Gg: ASbGncuj2ir7IBnphhHqOB/seKA8kIfJvuTk2N3CIhrj+XSfvs8/wi1LkQzEe2ySHGK HmEYFPhcGIjth8U+ioad1fUrZq8Adcfmoid3S1rHinjtqNpZLnT9/YHT5znMmIiLLmjep3uIIiG L4F2/KMC+uBlraGqbvav8dV3zNQ5jwtwUN33JDOOjP7N+AOotDt9lcBC8Riw+py2Oew1ju9H1nq KM9XebEGyGLKO4KfogTiNzN8+1LY1CS9CNBeSHnCWOmNWDoKYFGulFja4PJR3RGy8XIY7k0Xdrh EyF6bsnUItgDkgzVNuiKQj6eumYEOGlvT22lNWR6umTbNnTpJ0fkb45BFnw3vprVaZdKA/paag2 XHyCTq3zUIn29xNqNfwpnijotzgBveY0dJD2J2dmdG8cms+VFWjL4EeJeZXooPqbiKewzVsFnUU v66Y7QUhKSdAlp2jtdHxqINbxnLA== X-Google-Smtp-Source: AGHT+IHNWlOwlS+0w4rINsUXZGLEAulPrevlqrPihA9vZwY8xNaNEfoM4zs7C5Q7zgzN5GDxf7Kgmg== X-Received: by 2002:a17:903:f8b:b0:295:6d30:e26f with SMTP id d9443c01a7336-29b6becfe11mr233126345ad.22.1764220310214; Wed, 26 Nov 2025 21:11:50 -0800 (PST) Received: from chandna.localdomain ([106.222.232.43]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29bce442744sm3590715ad.23.2025.11.26.21.11.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 21:11:49 -0800 (PST) From: Sahil Chandna To: akpm@linux-foundation.org, david@redhat.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, hannes@cmpxchg.org, shakeel.butt@linux.dev, zhengqi.arch@bytedance.com, Liam.Howlett@oracle.com, weixugc@google.com, axelrasmussen@google.com, yuanchu@google.com, yosry.ahmed@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: david@kernel.org, Sahil Chandna , Matthew Wilcox , David Laight Subject: [PATCH v3 1/3] mm: pagewalk: simplify hugepage boundary calculation using min() Date: Thu, 27 Nov 2025 10:41:28 +0530 Message-ID: <1e01c12f7666ade41f5f34ada24ad3de1087454f.1764177933.git.chandna.sahil@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use the min() macro to compute the minimum value instead of an explicit=20 ternary expression. This improves readability and matches common kernel=20 style. Also change the return hugepage boundary expression for better clarity. This was flagged by Coccinelle (misc/minmax.cocci) as an opportunity to use min(). Found by: make coccicheck MODE=3Dreport M=3Dmm/ No functional change intended. Suggested-by: David Hildenbrand (Red Hat) Suggested-by: Matthew Wilcox Suggested-by: David Laight Signed-off-by: Sahil Chandna Acked-by: David Hildenbrand (Red Hat) --- changes since v2: - change the return expression for readability and clarity.=20 changes since v1: - Updated boundary calculation of huge page range for better clarity. - No Functional changes intended. link to v1: https://lore.kernel.org/all/ff24b3c573b766b187b55a38497fbad0a31= 9b9f8.1763227530.git.chandna.sahil@gmail.com/ link to v2: https://lore.kernel.org/all/f802959f58865371ba1b10081bced98e378= 4c5e4.1763796152.git.chandna.sahil@gmail.com/ --- mm/pagewalk.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/pagewalk.c b/mm/pagewalk.c index 9f91cf85a5be..9fd59d517f37 100644 --- a/mm/pagewalk.c +++ b/mm/pagewalk.c @@ -312,8 +312,7 @@ static int walk_pgd_range(unsigned long addr, unsigned = long end, static unsigned long hugetlb_entry_end(struct hstate *h, unsigned long add= r, unsigned long end) { - unsigned long boundary =3D (addr & huge_page_mask(h)) + huge_page_size(h); - return boundary < end ? boundary : end; + return min(ALIGN(addr, huge_page_size(h)), end); } =20 static int walk_hugetlb_range(unsigned long addr, unsigned long end, --=20 2.50.1