From nobody Sat Jul 25 21:59:20 2026 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A0F1353A74; Mon, 13 Jul 2026 08:32:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783931556; cv=none; b=kNihrB5DnjnQOlL0PJ0zZlb96r/aa//Ke1KNpKyAiHcoZW+ud4oB4zho5mWUZvG/wgdIH/S2hRpopS1ueJh9NruWm+jJZCP/C+zvwGdN67Nq3x6SSJoAjTmrajBS1b+4XjTXrXA2VYK/01frhOUAJdQnCsnvQJKfqCe0Tqofwbs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783931556; c=relaxed/simple; bh=uaUW/O+6q0/S0EDVJXNHXwZG3Ves7z414KTsEV1RK9g=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=r3p4gvB/yF1V4aKDMFWbfH0IPb7MsgMCckxWpHu1esEFdRIKIJQ/Eph4oEngdhYn5iP5MFigcPe6gV4yWUDoz8Bf24FkwLghmAsiDGBHS2tllursxITdO1Brb8E3wLeYguUXoWaQYGsL5qaQwOtFjqfx50nVXWYLrzNhIRVVdP4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 62a517ac7e9511f1aa26b74ffac11d73-20260713 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.12,REQID:e7d23ba5-70c5-47a7-8204-3c656e401106,IP:0,U RL:0,TC:0,Content:-5,EDM:25,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:20 X-CID-META: VersionHash:e7bac3a,CLOUDID:41abb22e5d5eb5801cbab6e2ec05fd27,BulkI D:nil,BulkQuantity:0,Recheck:0,SF:102|850|865|898,TC:nil,Content:0|15|50,E DM:5,IP:nil,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA: 0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: 62a517ac7e9511f1aa26b74ffac11d73-20260713 X-User: xiaopei01@kylinos.cn Received: from localhost.localdomain [(10.44.16.150)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 178118124; Mon, 13 Jul 2026 16:32:29 +0800 From: Pei Xiao To: dlan@kernel.org, rafael@kernel.org, troy.mitchell@linux.spacemit.com, shuwei.wu@mailbox.org, linux-pm@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Pei Xiao Subject: [PATCH] thermal: spacemit: k1: disable hardware on driver remove Date: Mon, 13 Jul 2026 16:32:23 +0800 Message-Id: <1db7d94eeaced9a92e3670d28e0c97c22f15f108.1783931396.git.xiaopei01@kylinos.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver uses devm_request_threaded_irq() but never disables the hardware interrupt enable, sensor enable, or sensor power bits when the driver is unbound. Add a devm action that clears K1_TSENSOR_INT_EN_REG, K1_TSENSOR_EN_ALL, and K1_TSENSOR_PCTRL_ENABLE on remove, mirroring what k1_tsensor_init() sets up. Signed-off-by: Pei Xiao --- drivers/thermal/spacemit/k1_tsensor.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/drivers/thermal/spacemit/k1_tsensor.c b/drivers/thermal/spacem= it/k1_tsensor.c index 79222d233129..cf79dc7d403f 100644 --- a/drivers/thermal/spacemit/k1_tsensor.c +++ b/drivers/thermal/spacemit/k1_tsensor.c @@ -199,6 +199,29 @@ static irqreturn_t k1_tsensor_irq_thread(int irq, void= *data) return IRQ_HANDLED; } =20 +static void k1_tsensor_shutdown(struct k1_tsensor *ts) +{ + u32 val; + + /* Disable all interrupts */ + writel(0xffffffff, ts->base + K1_TSENSOR_INT_EN_REG); + + /* Disable all sensor */ + val =3D readl(ts->base + K1_TSENSOR_EN_REG); + val &=3D ~K1_TSENSOR_EN_ALL; + writel(val, ts->base + K1_TSENSOR_EN_REG); + + /* Power down the sensor module */ + val =3D readl(ts->base + K1_TSENSOR_PCTRL_REG); + val &=3D ~K1_TSENSOR_PCTRL_ENABLE; + writel(val, ts->base + K1_TSENSOR_PCTRL_REG); +} + +static void devm_k1_tsensor_shutdown(void *data) +{ + k1_tsensor_shutdown(data); +} + static int k1_tsensor_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; @@ -229,6 +252,10 @@ static int k1_tsensor_probe(struct platform_device *pd= ev) =20 k1_tsensor_init(ts); =20 + ret =3D devm_add_action_or_reset(dev, devm_k1_tsensor_shutdown, ts); + if (ret) + return ret; + irq =3D platform_get_irq(pdev, 0); if (irq < 0) return irq; --=20 2.25.1