From nobody Sun Feb 8 14:56:53 2026 Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D253A148FFF for ; Fri, 19 Jul 2024 23:53:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721433211; cv=none; b=En3Tg/bkm/5ov7V9xqgMzFhJnhsRS1uwjZClvQTKXJXBbGq3KEalYVzh3aUcjhn9eDO9Ntwl/9BYqs2TE5wOnyr+vzEncsDS6dIbIYYiIlSkeIJZHEAR3zl2i8CE0jJG4vF+t+02lM4PWqquXX3uObcc6GnnERxhAxqR8zP0ATY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721433211; c=relaxed/simple; bh=N0Bf1snEyOmN9PwI7D1qGPLrWeE4OLp76LEIGveAXm8=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=LxcEGdE0XCykkmU/8bCvNOjSyNm3ejrAnPKW2oyDfexJdeM04uLlE4PRp8RuvySlkTVa3rFgJZ5u1odKb3S14ogUMco0sDU+laOkWXKjJ47mk9Gj5QrfMMgNbXvFoSkgXQq+bNt4fbXr0RPcmvp6GjRHL66k//D8wc5oELMAYV8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=atkeKVRF; arc=none smtp.client-ip=209.85.210.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="atkeKVRF" Received: by mail-ot1-f43.google.com with SMTP id 46e09a7af769-70448cae1e0so1210539a34.3 for ; Fri, 19 Jul 2024 16:53:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721433209; x=1722038009; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=ZMyG/FHVUOF+k6JySFz3GLM1XY2nmeubfD72U+zllkA=; b=atkeKVRFNA+aR7+F2Tw/EkyJkCCxEog/Q1Psm6iSyAmbNmmEVxkxy8uwbG2eGAVeLX 8nvJRsC3I+d5gFa2Q8tAZZdRJs9uHl1ty377nNBWUxwes/NOlzE7Jp2fqDmVKBOw0fhl ya2XXYj7j31uow4viFa2JxBdb6UPq1h75uuMlUu1Z0TCezVVEe8ZTIOn2H/CTj8NM678 1NQP3+BDmCHJ4NEcupxZwyf0V74YmC+ozfvVD+tc5cl4v/Hpiz9xEgiNBWL+PWmVbr4Q 2GtsrZrDHZglbuIn4Lg92Twtlz7WvJfRZHUql9m0ykLpf5qy9hSL5+GpHSR7EYwQwrsW YYsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721433209; x=1722038009; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZMyG/FHVUOF+k6JySFz3GLM1XY2nmeubfD72U+zllkA=; b=MFM/SO8LEToJv0O0cYfZdK68CvCw9sm2UPcqPZnYNNSbJCIRXcrGT1ndUrg/HZ2qAd cecKxZTHiYWHvOAULRSlaZP3pvkb6uddtCHar7+U9D5AYMR7PfluwDJzMjx2bNY+4vEe OI3Cl+B0XgmuM81snly/jQtrLpj8dS7WJq1SiMyv6oOxUkCDuh5eYwvbv8eNSnHuCL+u hatIFstIDI1VovJ3cDmiWnihKMIyn5X+FtXoHjkR9Nm9U+MnoGFsP9/vNk12gVuC+9iw uWrC7uMKFUhb0kXOguAUUEBaXsJ6fzu9a4vfHl1zI0bRQZKTRW8iWfQlPsuB6v5Ynrqu p0tQ== X-Forwarded-Encrypted: i=1; AJvYcCXNxqm4T8fnbnLDmp1dGCmHFNhrp9Q6Xfc0KERw48vpbyOs/2SUf3r6o1ZCx7+60fWuEd3KeRvWEkez3ts6JlPl48Jhxgw6Jy4GstEq X-Gm-Message-State: AOJu0Yz8dETZ38Ml3wtDBNIOQWukuBri/r4uI+/Co992QJM3tkeL09ng QBA+XVTiuqD+sCo0Ev7dcdAL6y4+SOk2zQ6NHybHhSTxVSWex20QQhWNVDzBaKw= X-Google-Smtp-Source: AGHT+IHZwhEqRVINdFyb0JRqoDuwEVo6XNOi3YkdDsvf5Rjc9CJ2SYqTjSAxr4NzWjTL0X9tiwaDdQ== X-Received: by 2002:a05:6830:b87:b0:703:5e1f:8f8c with SMTP id 46e09a7af769-7090092dedfmr71204a34.18.1721433208989; Fri, 19 Jul 2024 16:53:28 -0700 (PDT) Received: from localhost ([2603:8080:b800:f700:739a:b665:7f57:d340]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-708f60d3560sm519172a34.31.2024.07.19.16.53.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jul 2024 16:53:28 -0700 (PDT) Date: Fri, 19 Jul 2024 18:53:26 -0500 From: Dan Carpenter To: Kishon Vijay Abraham I Cc: Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Manivannan Sadhasivam , Niklas Cassel , Siddharth Vadapalli , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Damien Le Moal , Yoshihiro Shimoda , Aleksandr Mishin , Vignesh Raghavendra , Jan Kiszka , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] PCI: keystone: Fix && vs || typo Message-ID: <1b762a93-e1b2-4af3-8c04-c8843905c279@stanley.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This code accidentally uses && where || was intended. It potentially results in a NULL dereference. Fixes: 86f271f22bbb ("PCI: keystone: Add workaround for Errata #i2037 (AM65= x SR 1.0)") Signed-off-by: Dan Carpenter Reviewed-by: Manivannan Sadhasivam Reviewed-by: Siddharth Vadapalli --- drivers/pci/controller/dwc/pci-keystone.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/contro= ller/dwc/pci-keystone.c index 52c6420ae200..95a471d6a586 100644 --- a/drivers/pci/controller/dwc/pci-keystone.c +++ b/drivers/pci/controller/dwc/pci-keystone.c @@ -577,7 +577,7 @@ static void ks_pcie_quirk(struct pci_dev *dev) */ if (pci_match_id(am6_pci_devids, bridge)) { bridge_dev =3D pci_get_host_bridge_device(dev); - if (!bridge_dev && !bridge_dev->parent) + if (!bridge_dev || !bridge_dev->parent) return; =20 ks_pcie =3D dev_get_drvdata(bridge_dev->parent); --=20 2.43.0