From nobody Tue Sep 16 21:45:08 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 677EEC3DA79 for ; Thu, 29 Dec 2022 16:26:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233759AbiL2Q0M (ORCPT ); Thu, 29 Dec 2022 11:26:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233335AbiL2QZo (ORCPT ); Thu, 29 Dec 2022 11:25:44 -0500 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E29DBB for ; Thu, 29 Dec 2022 08:25:42 -0800 (PST) Received: by mail-ed1-x52b.google.com with SMTP id u28so22456929edd.10 for ; Thu, 29 Dec 2022 08:25:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=t8N//8jqLWrIkBGyfF8wv4Tl2KGsW1laCrcUj0eqwXw=; b=SOjIqDPJjAG3X8J2l0O1eskK3G1j4SzA1AkgO3M8IcMOGAfztcEIN0KSRvfW5nTL1c QBqK6wQBjo+GxJGcwUPfSufBmYCEG3TLjOMiDGPiiuVXw0rvqyLeALougT+LBzP5wIxj FKIF5Zf3HX4K9c4oDeZV6RpaA8xspwXNhozk6x1PgN16C+nxgRIHqjGNUSzAHBcn9eaz 9w/cO6YzILmXE6rmSLYAZSe3PEvroAtnMweberW0+j9NEJ1iiJ8e5tvf58Pl9/Xco093 b2cywR8IKDTatE3ZgHYEZcH6wBbtedaqn0qeZr/RqvE9g7wzJ178dmD3oLadYRT6tBfC AVCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=t8N//8jqLWrIkBGyfF8wv4Tl2KGsW1laCrcUj0eqwXw=; b=WEYuxA7I2PkLcWt6MO8iGV3KGISGCgKt6u3tILzgRJFojN3WmJuPa+bgRACGntppdp gNONBW1nQRi2ZN+WFDldAcN28c+k5ECIUFcVTUkJI8bzrl9wp9Z0wpX0JSyFgs9Qs2YX KOlayZXh6rm2p1gWofuLEx4aa8abMbi9bR/M54ewzLMA9N4ar5i9BDwE68H+uSPu1TF6 HQjUSLspn7dICt8afXVX1aVkogtc43+X4U9c7QGubVFAEIePYkjHd4xXPrLjKXwxWUyK 6vbdrUtTZQsfrB5qwpfxx6T5rLh1pGqwSAvYXKyT3DYRgOIU9rjdwJSQoB7+qm1CHnKH O2Ow== X-Gm-Message-State: AFqh2kqqY89IANcKg97Udbs6fpQfii2wsFsM/YhS3hv/peHusj5HWTMY 26S1OJxVogm7fQPDtiKxJp6jUWZvJ7Q= X-Google-Smtp-Source: AMrXdXtAgAaBcAczHzVDiavvwBqKWtBJ7XKXpu6mOv6PHDKBjjo6OQGw73CzqRIFzxE01OfbMiFeVg== X-Received: by 2002:aa7:dd13:0:b0:479:8313:2fe6 with SMTP id i19-20020aa7dd13000000b0047983132fe6mr4986436edv.1.1672331140891; Thu, 29 Dec 2022 08:25:40 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p54a07888.dip0.t-ipconnect.de. [84.160.120.136]) by smtp.gmail.com with ESMTPSA id bm25-20020a0564020b1900b0045cf4f72b04sm8420941edb.94.2022.12.29.08.25.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Dec 2022 08:25:40 -0800 (PST) Date: Thu, 29 Dec 2022 17:25:38 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 1/7] staging: rtl8192e: Rename ChannelPlan, eeprom_ChannelPlan and CckPwEnl Message-ID: <1b705718afdcf56475c10db4b284d2c91a58b250.1672330343.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable ChannelPlan to chnl_plan, eeprom_ChannelPlan to eeprom_chnl_plan and CckPwEnl to cck_pwr_enl to avoid CamelCase which is not accepted by checkpatch. Signed-off-by: Philipp Hortmann --- .../rtl8192e/rtl8192e/r8190P_rtl8256.c | 2 +- .../staging/rtl8192e/rtl8192e/r8192E_dev.c | 20 +++++++++---------- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 8 ++++---- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 6 +++--- 4 files changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c b/drivers/s= taging/rtl8192e/rtl8192e/r8190P_rtl8256.c index ab2e9b729883..93928f3585c1 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c @@ -154,7 +154,7 @@ void rtl92e_set_cck_tx_power(struct net_device *dev, u8= powerlevel) if (priv->CustomerID =3D=3D RT_CID_819x_Netcore) TxAGC =3D 0x22; else - TxAGC +=3D priv->CckPwEnl; + TxAGC +=3D priv->cck_pwr_enl; } if (TxAGC > 0x24) TxAGC =3D 0x24; diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index f02e67f68e23..25fa7714df4e 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -306,7 +306,7 @@ static void _rtl92e_read_eeprom_info(struct net_device = *dev) priv->eeprom_CustomerID =3D usValue & 0xff; usValue =3D rtl92e_eeprom_read(dev, EEPROM_ICVersion_ChannelPlan>>1); - priv->eeprom_ChannelPlan =3D usValue&0xff; + priv->eeprom_chnl_plan =3D usValue&0xff; IC_Version =3D (usValue & 0xff00)>>8; =20 ICVer8192 =3D IC_Version & 0xf; @@ -328,7 +328,7 @@ static void _rtl92e_read_eeprom_info(struct net_device = *dev) priv->eeprom_vid =3D 0; priv->eeprom_did =3D 0; priv->eeprom_CustomerID =3D 0; - priv->eeprom_ChannelPlan =3D 0; + priv->eeprom_chnl_plan =3D 0; } =20 if (!priv->AutoloadFailFlag) { @@ -473,9 +473,9 @@ static void _rtl92e_read_eeprom_info(struct net_device = *dev) priv->rf_chip =3D RF_8256; =20 if (priv->reg_chnl_plan =3D=3D 0xf) - priv->ChannelPlan =3D priv->eeprom_ChannelPlan; + priv->chnl_plan =3D priv->eeprom_chnl_plan; else - priv->ChannelPlan =3D priv->reg_chnl_plan; + priv->chnl_plan =3D priv->reg_chnl_plan; =20 if (priv->eeprom_vid =3D=3D 0x1186 && priv->eeprom_did =3D=3D 0x3304) priv->CustomerID =3D RT_CID_DLINK; @@ -495,10 +495,10 @@ static void _rtl92e_read_eeprom_info(struct net_devic= e *dev) break; case EEPROM_CID_TOSHIBA: priv->CustomerID =3D RT_CID_TOSHIBA; - if (priv->eeprom_ChannelPlan&0x80) - priv->ChannelPlan =3D priv->eeprom_ChannelPlan&0x7f; + if (priv->eeprom_chnl_plan & 0x80) + priv->chnl_plan =3D priv->eeprom_chnl_plan & 0x7f; else - priv->ChannelPlan =3D 0x0; + priv->chnl_plan =3D 0x0; break; case EEPROM_CID_Nettronix: priv->CustomerID =3D RT_CID_Nettronix; @@ -516,9 +516,9 @@ static void _rtl92e_read_eeprom_info(struct net_device = *dev) break; } =20 - if (priv->ChannelPlan > CHANNEL_PLAN_LEN - 1) - priv->ChannelPlan =3D 0; - priv->ChannelPlan =3D COUNTRY_CODE_WORLD_WIDE_13; + if (priv->chnl_plan > CHANNEL_PLAN_LEN - 1) + priv->chnl_plan =3D 0; + priv->chnl_plan =3D COUNTRY_CODE_WORLD_WIDE_13; =20 if (priv->eeprom_vid =3D=3D 0x1186 && priv->eeprom_did =3D=3D 0x3304) priv->rtllib->bSupportRemoteWakeUp =3D true; diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.c index f8fbe78ccad9..92260d098eaa 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -862,7 +862,7 @@ static void _rtl92e_init_priv_variable(struct net_devic= e *dev) priv->cck_present_attn =3D 0; priv->rfa_txpowertrackingindex =3D 0; priv->rfc_txpowertrackingindex =3D 0; - priv->CckPwEnl =3D 6; + priv->cck_pwr_enl =3D 6; priv->rst_progress =3D RESET_TYPE_NORESET; priv->force_reset =3D false; memset(priv->rtllib->swcamtable, 0, sizeof(struct sw_cam_table) * 32); @@ -952,13 +952,13 @@ static short _rtl92e_get_channel_map(struct net_devic= e *dev) return -1; } =20 - if (priv->ChannelPlan >=3D COUNTRY_CODE_MAX) { + if (priv->chnl_plan >=3D COUNTRY_CODE_MAX) { netdev_info(dev, "rtl819x_init:Error channel plan! Set to default.\n"); - priv->ChannelPlan =3D COUNTRY_CODE_FCC; + priv->chnl_plan =3D COUNTRY_CODE_FCC; } dot11d_init(priv->rtllib); - dot11d_channel_map(priv->ChannelPlan, priv->rtllib); + dot11d_channel_map(priv->chnl_plan, priv->rtllib); for (i =3D 1; i <=3D 11; i++) (priv->rtllib->active_channel_map)[i] =3D 1; (priv->rtllib->active_channel_map)[12] =3D 2; diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.h index cceb77492363..93b3b75a063f 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -420,7 +420,7 @@ struct r8192_priv { u16 eeprom_vid; u16 eeprom_did; u8 eeprom_CustomerID; - u16 eeprom_ChannelPlan; + u16 eeprom_chnl_plan; =20 u8 EEPROMTxPowerLevelCCK[14]; u8 EEPROMTxPowerLevelOFDM24G[14]; @@ -451,7 +451,7 @@ struct r8192_priv { bool bTXPowerDataReadFromEEPORM; =20 u16 reg_chnl_plan; - u16 ChannelPlan; + u16 chnl_plan; u8 hw_rf_off_action; =20 bool rf_change_in_progress; @@ -460,7 +460,7 @@ struct r8192_priv { =20 u8 DM_Type; =20 - u8 CckPwEnl; + u8 cck_pwr_enl; u16 TSSI_13dBm; u32 Pwr_Track; u8 CCKPresentAttentuation_20Mdefault; --=20 2.39.0