From nobody Wed Apr 8 12:41:20 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D920DC6FA82 for ; Fri, 2 Sep 2022 21:40:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231199AbiIBVk1 (ORCPT ); Fri, 2 Sep 2022 17:40:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229500AbiIBVkY (ORCPT ); Fri, 2 Sep 2022 17:40:24 -0400 Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A304038476 for ; Fri, 2 Sep 2022 14:40:21 -0700 (PDT) Received: by mail-qk1-x730.google.com with SMTP id g16so2728008qkl.11 for ; Fri, 02 Sep 2022 14:40:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=bR3hEleHn1hDXjDK6nUjMSvBYEAsUeJzCzyUGuVERRQ=; b=wuzCTnre6tTsSegsWv8KZyKcXhhqdhcG6fFIvRHpUAcFTLq9edlgDAeNCrP1BZBuQs +snDeAgYpQ9ou4o7gjLmO4qAPCuMqjAMbSPDH6nE3m4Wt26glIh+Q+WnQ8h2JPbH743C XofCCIy/C62BWw7Gz4ktIrZQqvhlIuwS7utzOIyMLVq6TDdCeNhT05Niap6zzINjxe9d VRnsUCafjeFcUtRGslnzqSsXeskPb0D729WRKiT3jNNohcyEJmY1jMASfZ0wmaKpZmpH seXeBDvkWD9yhDdZJxHZ8g6wAsmC/bSfQs1ikHOQO7BCPMuu2XRckAw5U3BgMDCidcWo 28Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=bR3hEleHn1hDXjDK6nUjMSvBYEAsUeJzCzyUGuVERRQ=; b=otOpNwzsYl5yBZVtiQZInKQJK7O1I4Marin2cMCGr63lbXd7+tbKTnDsYCPu896Q9k PB2Rt4DEsS+jfbDPP/Nh8opQe7VDVOIbqUX10gtgEZQXjDYOQn6MTofNCWPr6uiimsvy mRkmXM0ml9zMxogBgc93yhVJeQWImLcgvNeHJp8ADVzkuw2OmKJQv3IPZimN2iXXGd2s UksXU1R91w9L0AarI536t1OXJp6v0OVfXD4lPEg3Ttc42XzAROwmqFcyP/BALy8gbKII ZcELQ1Zhh1SfTLQmIlY6LG/jyVpmns3fIvhUuaTAYuoDYuzvRo5kNDQb0T6ZwNN9E06a 9oMg== X-Gm-Message-State: ACgBeo0TcNqVP2nmfAhUrZg2DmzFblvv+qFJOftiMow7EZf9DGo5Gk9V aebcq1vQI/P+cnHKehxdmhyEh4RtDOrhBA== X-Google-Smtp-Source: AA6agR5GjIxXkb/bcDLBsnO3UPU6jpE1pq17eJNvvjhLBlYBn3BCFQ7DqD21u9qoZ70EX7rLo01JsA== X-Received: by 2002:a05:620a:4094:b0:6bb:8514:9c84 with SMTP id f20-20020a05620a409400b006bb85149c84mr24438491qko.134.1662154820356; Fri, 02 Sep 2022 14:40:20 -0700 (PDT) Received: from fedora.attlocal.net (69-109-179-158.lightspeed.dybhfl.sbcglobal.net. [69.109.179.158]) by smtp.gmail.com with ESMTPSA id 15-20020ac84e8f000000b0031f0b43629dsm1819533qtp.23.2022.09.02.14.40.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Sep 2022 14:40:20 -0700 (PDT) From: William Breathitt Gray To: brgl@bgdev.pl, linus.walleij@linaro.org Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, William Breathitt Gray , Frede@cmslaser.com Subject: [PATCH 3/4] gpio: 104-idio-16: Make irq_chip immutable Date: Fri, 2 Sep 2022 13:45:25 -0400 Message-Id: <1a97e3f21f695f238fad9366e5976694b41a5da0.1662140119.git.william.gray@linaro.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Kernel warns about mutable irq_chips: "not an immutable chip, please consider fixing!" Make the struct irq_chip const, flag it as IRQCHIP_IMMUTABLE, add the new helper functions, and call the appropriate gpiolib functions. Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-104-idio-16.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/gpio/gpio-104-idio-16.c b/drivers/gpio/gpio-104-idio-1= 6.c index 65a5f581d981..4756e583f223 100644 --- a/drivers/gpio/gpio-104-idio-16.c +++ b/drivers/gpio/gpio-104-idio-16.c @@ -174,10 +174,11 @@ static void idio_16_irq_mask(struct irq_data *data) { struct gpio_chip *chip =3D irq_data_get_irq_chip_data(data); struct idio_16_gpio *const idio16gpio =3D gpiochip_get_data(chip); - const unsigned long mask =3D BIT(irqd_to_hwirq(data)); + const unsigned long offset =3D irqd_to_hwirq(data); unsigned long flags; =20 - idio16gpio->irq_mask &=3D ~mask; + idio16gpio->irq_mask &=3D ~BIT(offset); + gpiochip_disable_irq(chip, offset); =20 if (!idio16gpio->irq_mask) { raw_spin_lock_irqsave(&idio16gpio->lock, flags); @@ -192,11 +193,12 @@ static void idio_16_irq_unmask(struct irq_data *data) { struct gpio_chip *chip =3D irq_data_get_irq_chip_data(data); struct idio_16_gpio *const idio16gpio =3D gpiochip_get_data(chip); - const unsigned long mask =3D BIT(irqd_to_hwirq(data)); + const unsigned long offset =3D irqd_to_hwirq(data); const unsigned long prev_irq_mask =3D idio16gpio->irq_mask; unsigned long flags; =20 - idio16gpio->irq_mask |=3D mask; + gpiochip_enable_irq(chip, offset); + idio16gpio->irq_mask |=3D BIT(offset); =20 if (!prev_irq_mask) { raw_spin_lock_irqsave(&idio16gpio->lock, flags); @@ -217,12 +219,14 @@ static int idio_16_irq_set_type(struct irq_data *data= , unsigned int flow_type) return 0; } =20 -static struct irq_chip idio_16_irqchip =3D { +static const struct irq_chip idio_16_irqchip =3D { .name =3D "104-idio-16", .irq_ack =3D idio_16_irq_ack, .irq_mask =3D idio_16_irq_mask, .irq_unmask =3D idio_16_irq_unmask, - .irq_set_type =3D idio_16_irq_set_type + .irq_set_type =3D idio_16_irq_set_type, + .flags =3D IRQCHIP_IMMUTABLE, + GPIOCHIP_IRQ_RESOURCE_HELPERS, }; =20 static irqreturn_t idio_16_irq_handler(int irq, void *dev_id) @@ -299,7 +303,7 @@ static int idio_16_probe(struct device *dev, unsigned i= nt id) idio16gpio->out_state =3D 0xFFFF; =20 girq =3D &idio16gpio->chip.irq; - girq->chip =3D &idio_16_irqchip; + gpio_irq_chip_set_chip(girq, &idio_16_irqchip); /* This will let us handle the parent IRQ in the driver */ girq->parent_handler =3D NULL; girq->num_parents =3D 0; --=20 2.37.2