From nobody Fri Dec 19 18:55:54 2025 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E17A2F841 for ; Fri, 22 Dec 2023 22:51:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rGoMN-0005gq-0I; Fri, 22 Dec 2023 23:51:15 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rGoML-000qvX-D7; Fri, 22 Dec 2023 23:51:14 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rGoMM-000Ffi-1M; Fri, 22 Dec 2023 23:51:14 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Thomas Gleixner Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 11/13] irqchip/renesas-rza1: Convert to platform remove callback returning void Date: Fri, 22 Dec 2023 23:50:42 +0100 Message-ID: <1a80e31525d0b02063d2ff1baaaa5e87418f54b6.1703284359.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1796; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=Bsz1h5QGxzBut3kdIXUNVPDmYjq+hBPugF7vd2mkQfE=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlhhLDGfDRrLiK/KeH7o6vmgeojd4haTpeIWkVf dHLHVF6VfmJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZYYSwwAKCRCPgPtYfRL+ Ti/6B/0Uc7C0uWLP+JiDX8poWb9fqLqVJkboTbGDuw8QKClnZ8GXnZ1kWfqxq+sEAxAzJ5kqVaw 1Z6yi6Fg8XYidEuyCh9wwlEqGPU/sojxhURWyGaLh2ZLUnW4yZzqZ5XbsPgGNUecuNJx0Ge1b1W mZu4V5EHMq0GFrq56K40kZbmluI1LIBr48WiXF5xYuRyLSzgn9EfNy7h4Qk1xEWj7bausZD73+P NqiU2OkIiT1Zltu0xSb/5zxZafiCctFRj4Xvygbl1LZPexPts3IfCyJ8NqU/N09G2u0GDAnB9HC rWPzyNQy9GGObqdVm6PVyA21KDXDAzvE6nuAmNXtX1faAqgP X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/irqchip/irq-renesas-rza1.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/irqchip/irq-renesas-rza1.c b/drivers/irqchip/irq-renes= as-rza1.c index e4c99c2e0373..f293ad13809f 100644 --- a/drivers/irqchip/irq-renesas-rza1.c +++ b/drivers/irqchip/irq-renesas-rza1.c @@ -244,12 +244,11 @@ static int rza1_irqc_probe(struct platform_device *pd= ev) return ret; } =20 -static int rza1_irqc_remove(struct platform_device *pdev) +static void rza1_irqc_remove(struct platform_device *pdev) { struct rza1_irqc_priv *priv =3D platform_get_drvdata(pdev); =20 irq_domain_remove(priv->irq_domain); - return 0; } =20 static const struct of_device_id rza1_irqc_dt_ids[] =3D { @@ -260,7 +259,7 @@ MODULE_DEVICE_TABLE(of, rza1_irqc_dt_ids); =20 static struct platform_driver rza1_irqc_device_driver =3D { .probe =3D rza1_irqc_probe, - .remove =3D rza1_irqc_remove, + .remove_new =3D rza1_irqc_remove, .driver =3D { .name =3D "renesas_rza1_irqc", .of_match_table =3D rza1_irqc_dt_ids, --=20 2.42.0