From nobody Thu Apr 9 20:25:35 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 203241FBCA7; Thu, 5 Mar 2026 19:48:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772740104; cv=none; b=C2ikiNMD9m+qBs8n6WsKsP/s3Mi3JDNoWxImn1xv5GShepkbSNh2TfLQuC5/yv5sDVpNcheGHggKBKMMOXMMLuVFryweuaIoM55saPbEu/+24hiy58v1XI8HYeqVTgyqBA50q5ItszOoNmaXMCRkjbAzVhVfa5lw1nogawrzSHo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772740104; c=relaxed/simple; bh=ArBEjEEehMlFNLpth2XtCfGINxTQbnR6YRcCNjwC3KQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=AlsG0mAZmLGysm6s6gUjRhszSTSFZNFG3x6M+02s4CIcfJ3hjGirO3MGtGoExCgc9LiZDvGwkBSXefwViqMzpfMtTzxsHI4ymNCkKRgpKomJ1E4YMasYW4rMqAurdqtEQBoJw6x+bw9Nm3JtvMQwu5RpTdbbZPP4L7UXniLYgiY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TNta+q2z; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TNta+q2z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7F05C19422; Thu, 5 Mar 2026 19:48:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772740103; bh=ArBEjEEehMlFNLpth2XtCfGINxTQbnR6YRcCNjwC3KQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TNta+q2zL8jzsX8hPgYBS3VLfKhWRwpp+tQzdsdLXftUZdiLZjWQNsAb1R6v9TufA zyDo8mRwL8rQXEeGaIhlPW+clySTAnpJVUSbD8ns95eaFmDC1TEQyVrUJULqEKQXXI pfBxaR2gDZcmCeJM2lmFnEBGwB95QEVBtvnYoa6VeyWebb/FfCsnCI+jLVeqtw8YX+ 4QcSWerm5fwltz3P+m+ovZjrgtdQy1rPuTVz5336Xm5QR4IiR7b+2x1dtxawnBUwlb CB4margG6aPMMwmZUBAY3ekc9hgbmuG9t07Fl75HNLOp66a3p8iI6IpTjftty4+Szy 9FzjsSfwYpurA== From: "Rafael J. Wysocki" To: Tzung-Bi Shih Cc: chrome-platform@lists.linux.dev, LKML , Linux ACPI , Benson Leung , Enric Balletbo i Serra , Ravi Chandra Sadineni Subject: [PATCH v2 1/6] platform/chrome: Convert ChromeOS privacy-screen driver to platform Date: Thu, 05 Mar 2026 20:37:54 +0100 Message-ID: <1963835.tdWV9SEqCh@rafael.j.wysocki> Organization: Linux Kernel Development In-Reply-To: <6259948.lOV4Wx5bFT@rafael.j.wysocki> References: <6259948.lOV4Wx5bFT@rafael.j.wysocki> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Rafael J. Wysocki" In all cases in which a struct acpi_driver is used for binding a driver to an ACPI device object, a corresponding platform device is created by the ACPI core and that device is regarded as a proper representation of underlying hardware. Accordingly, a struct platform_driver should be used by driver code to bind to that device. There are multiple reasons why drivers should not bind directly to ACPI device objects [1]. Overall, it is better to bind drivers to platform devices than to their ACPI companions, so convert the ChromeOS privacy-screen ACPI driver to a platform one. While this is not expected to alter functionality, it changes sysfs layout and so it will be visible to user space. Link: https://lore.kernel.org/all/2396510.ElGaqSPkdT@rafael.j.wysocki/ [1] Signed-off-by: Rafael J. Wysocki --- v1 -> v2: No changes --- .../platform/chrome/chromeos_privacy_screen.c | 41 ++++++++----------- 1 file changed, 18 insertions(+), 23 deletions(-) diff --git a/drivers/platform/chrome/chromeos_privacy_screen.c b/drivers/pl= atform/chrome/chromeos_privacy_screen.c index bb74ddf9af4a..abc5d189a389 100644 --- a/drivers/platform/chrome/chromeos_privacy_screen.c +++ b/drivers/platform/chrome/chromeos_privacy_screen.c @@ -12,6 +12,7 @@ */ =20 #include +#include #include =20 /* @@ -32,11 +33,10 @@ chromeos_privacy_screen_get_hw_state(struct drm_privacy= _screen *drm_privacy_screen) { union acpi_object *obj; - acpi_handle handle; struct device *privacy_screen =3D drm_privacy_screen_get_drvdata(drm_privacy_screen); + acpi_handle handle =3D ACPI_HANDLE(privacy_screen); =20 - handle =3D acpi_device_handle(to_acpi_device(privacy_screen)); obj =3D acpi_evaluate_dsm(handle, &chromeos_privacy_screen_dsm_guid, PRIV_SCRN_DSM_REVID, PRIV_SCRN_DSM_FN_GET_STATUS, NULL); @@ -65,11 +65,9 @@ chromeos_privacy_screen_set_sw_state(struct drm_privacy_= screen enum drm_privacy_screen_status state) { union acpi_object *obj =3D NULL; - acpi_handle handle; struct device *privacy_screen =3D drm_privacy_screen_get_drvdata(drm_privacy_screen); - - handle =3D acpi_device_handle(to_acpi_device(privacy_screen)); + acpi_handle handle =3D ACPI_HANDLE(privacy_screen); =20 if (state =3D=3D PRIVACY_SCREEN_DISABLED) { obj =3D acpi_evaluate_dsm(handle, @@ -104,30 +102,28 @@ static const struct drm_privacy_screen_ops chromeos_p= rivacy_screen_ops =3D { .set_sw_state =3D chromeos_privacy_screen_set_sw_state, }; =20 -static int chromeos_privacy_screen_add(struct acpi_device *adev) +static int chromeos_privacy_screen_probe(struct platform_device *pdev) { struct drm_privacy_screen *drm_privacy_screen =3D - drm_privacy_screen_register(&adev->dev, + drm_privacy_screen_register(&pdev->dev, &chromeos_privacy_screen_ops, - &adev->dev); + &pdev->dev); =20 if (IS_ERR(drm_privacy_screen)) { - dev_err(&adev->dev, "Error registering privacy-screen\n"); + dev_err(&pdev->dev, "Error registering privacy-screen\n"); return PTR_ERR(drm_privacy_screen); } =20 - adev->driver_data =3D drm_privacy_screen; - dev_info(&adev->dev, "registered privacy-screen '%s'\n", + platform_set_drvdata(pdev, drm_privacy_screen); + dev_info(&pdev->dev, "registered privacy-screen '%s'\n", dev_name(&drm_privacy_screen->dev)); =20 return 0; } =20 -static void chromeos_privacy_screen_remove(struct acpi_device *adev) +static void chromeos_privacy_screen_remove(struct platform_device *pdev) { - struct drm_privacy_screen *drm_privacy_screen =3D acpi_driver_data(adev); - - drm_privacy_screen_unregister(drm_privacy_screen); + drm_privacy_screen_unregister(platform_get_drvdata(pdev)); } =20 static const struct acpi_device_id chromeos_privacy_screen_device_ids[] = =3D { @@ -136,17 +132,16 @@ static const struct acpi_device_id chromeos_privacy_s= creen_device_ids[] =3D { }; MODULE_DEVICE_TABLE(acpi, chromeos_privacy_screen_device_ids); =20 -static struct acpi_driver chromeos_privacy_screen_driver =3D { - .name =3D "chromeos_privacy_screen_driver", - .class =3D "ChromeOS", - .ids =3D chromeos_privacy_screen_device_ids, - .ops =3D { - .add =3D chromeos_privacy_screen_add, - .remove =3D chromeos_privacy_screen_remove, +static struct platform_driver chromeos_privacy_screen_driver =3D { + .probe =3D chromeos_privacy_screen_probe, + .remove =3D chromeos_privacy_screen_remove, + .driver =3D { + .name =3D "chromeos_privacy_screen_driver", + .acpi_match_table =3D chromeos_privacy_screen_device_ids, }, }; =20 -module_acpi_driver(chromeos_privacy_screen_driver); +module_platform_driver(chromeos_privacy_screen_driver); MODULE_LICENSE("GPL v2"); MODULE_DESCRIPTION("ChromeOS ACPI Privacy Screen driver"); MODULE_AUTHOR("Rajat Jain "); --=20 2.51.0