From nobody Sun Feb 8 13:39:28 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97478313E32 for ; Mon, 5 Jan 2026 08:23:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767601383; cv=none; b=ibRY9e8QuPL9Sz/ZPnlmSi9hhky7eG5T70quRbpt0G8pwnV5zvDOfT5NQJ3kUtd689VcG+dT6U3nDn4R0A8r9mLX9I4VWMI/m8fdgCi9PrDtmxITTQUxOWcAwRAY022CBtsYESL4borYaltZV1CCjD3S/5osemKwobjPOF0z9ek= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767601383; c=relaxed/simple; bh=OKICx5FGcs8IaWdKqJAnv5nr30MUEvkMmLH/rtLJg90=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=g9Ihj8rqop/xS9/weDBSsIvOYVsZNfSplm3++NaHPP8nKske+MX4Jc6sYtchk7ZX3WJCb3vDE7RNoKuLLzEag7jW4KV2eh/Ox14jmk9VPG7NLDRvZtwx7ATjCtPgSGjsyNPASxoQBVw9gZKsGOqVGZlqz2nKDhjcZo84sHk6bBY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=WqVz3irm; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=QPkFrgpu; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WqVz3irm"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="QPkFrgpu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767601380; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=flvV58rpfI6B2CbimOq4yKlcklsexX+NampJykNGX78=; b=WqVz3irmgl/1ZpP+3Mg4itom3mhS8h0Rbrdtt95M6DwQFX+h30kcTMJGJZHFGGTXx46C9n k7QD5ZNc1cE4PvrTUNGjMkSJ8cUXCc4UItybwSIPOawmPH1Lus9RXtQaNSe6Q6nmbZntyM 9kSdOgbhWt0yWZ60HwGundSiE5kWm3A= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-111-VvN_wUG-N0qMHZ7TYJGPzw-1; Mon, 05 Jan 2026 03:22:59 -0500 X-MC-Unique: VvN_wUG-N0qMHZ7TYJGPzw-1 X-Mimecast-MFC-AGG-ID: VvN_wUG-N0qMHZ7TYJGPzw_1767601379 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-47d28e7960fso89204805e9.0 for ; Mon, 05 Jan 2026 00:22:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767601378; x=1768206178; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=flvV58rpfI6B2CbimOq4yKlcklsexX+NampJykNGX78=; b=QPkFrgpuiBMMFofOQ4jAdxxN6c2Vp4oV1Gg7feN7Brwk3IoZE8tlZBtMewNHdCTmcX J89iiXHO8XulT7mvkAYigvNB21HwVkC4UaJh+6qLFH044MYI/AJhC1rir05k3E4D5zAC l2oMwTUjnPVcCbl4v5p9sk+ENJbiTovejKy4d238LehbX5oug0hjfbk+5CP0WUf7R0W5 oAt5vX0zoXLVkMJ/lerxu000WlCDJKWa5kUX14ARIXqnfSsN5oTfZjrjrbgv3FTzfJ+d ohL+mLUyGVtzNS0/P3hyS1HSdrurjG/swvLj6tE2/lIvMl2g9uBukt4A5C+bA3B/QfIq nkBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767601378; x=1768206178; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=flvV58rpfI6B2CbimOq4yKlcklsexX+NampJykNGX78=; b=lwsAi36aeYV0g2yL2fIpMxPMcPfxhCCAXZbK3iMfvl3GW6tsGj2WJJ9JmUJpkodQSd 04BBmbx8L37yX3H0kp+hjUZ6yyhoHPjDxlLBqV/eQkMfktIzKX7z1CSpyxSX5Up/2zkn yZbLDSkUpfXAGmtQtOKdZhArwDH9OKxz63a2OlvvmX6sm6FXFzbxgDBPuyh8ybaub8ij BwPEhTzWCr2SR7Sotk9r376Dks0YA9pVUrAbrxp8rM0XH2r1TiS7eMFZCQiypBhvXTYq L+V23bPKMKFLiG2SbPRLBd98gUGK7Zg2HmkpsSOGp3DUXjgFGKKlmxgFblSl8JKbUld8 lyyw== X-Gm-Message-State: AOJu0Yy4VsKlB6FliwTfOm1fUGdLf/qKnBQOOkLTBQ12flAIM/P3HdOV YdCydXmIFvmfcmM6AEOpHAdYDgPQ30cr5uOe81NLe5MDdj4SafulfGGdOMWHN5fFHaZduihY2IU HdASEFSYqFUfb/ZI8L5DINrMltMn/PCm75RSOmMbeGJ4GMScDlZ3PFuyf6yoBNluvVFc7Ob6Ks/ iFVH7F5nHI8CCXFnSx/UXGjlUi6Ul1FyXxfQfLQyP69r4= X-Gm-Gg: AY/fxX6NHHYOWvEMMuwd9UJsfZ//Y/v/+tSfQQBzlkNLX+GiQ8mTbBhJ4HM2gjSYiry YddfBm+MSuK0/jw/NNYsWNEQB9SQrrhBCfe1EEhWUxxRrXpqAAn0Glfw7ZecCF1Ut1Bgoqnl/e5 L0QngtyLIewquF8s3tJhkrDnGQi90nPAUi8wrMJg+nRpF3KQ26LjL1M2cBJMp2LXABtciGMkOGt uUQpTEjdOnFtTaw49m0afn//lQvCr+uarUZWGIwjqRbL0EGXbMWp7QzIqAq/zRrT1qCYLvUseJA DO3+cMXeJEF6YTCo/VydO6WkMQjddeUS4LWLiOD/5GM9g9szqFBKu6GUL/ab4veVgGLbOAVJQXb H+Tsyt5ch1guSZ/1pey1T0bIn9aO1+s2J2w== X-Received: by 2002:a05:600c:a31a:b0:477:b48d:ba7a with SMTP id 5b1f17b1804b1-47d1afcd9e2mr472221945e9.32.1767601378325; Mon, 05 Jan 2026 00:22:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IEuXSIOihQGqTUh73UD1lwUxn/oQlvSzbaEszKjq8q7pmaQg9MTKbAK1XIofFksKZVCqoImYw== X-Received: by 2002:a05:600c:a31a:b0:477:b48d:ba7a with SMTP id 5b1f17b1804b1-47d1afcd9e2mr472221315e9.32.1767601377489; Mon, 05 Jan 2026 00:22:57 -0800 (PST) Received: from redhat.com (IGLD-80-230-31-118.inter.net.il. [80.230.31.118]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d6d13ed0asm147684535e9.3.2026.01.05.00.22.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jan 2026 00:22:57 -0800 (PST) Date: Mon, 5 Jan 2026 03:22:54 -0500 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: Cong Wang , Jonathan Corbet , Olivia Mackall , Herbert Xu , Jason Wang , Paolo Bonzini , Stefan Hajnoczi , Eugenio =?utf-8?B?UMOpcmV6?= , "James E.J. Bottomley" , "Martin K. Petersen" , Gerd Hoffmann , Xuan Zhuo , Marek Szyprowski , Robin Murphy , Stefano Garzarella , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Petr Tesarik , Leon Romanovsky , Jason Gunthorpe , Bartosz Golaszewski , linux-doc@vger.kernel.org, linux-crypto@vger.kernel.org, virtualization@lists.linux.dev, linux-scsi@vger.kernel.org, iommu@lists.linux.dev, kvm@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v2 01/15] dma-mapping: add __dma_from_device_group_begin()/end() Message-ID: <19163086d5e4704c316f18f6da06bc1c72968904.1767601130.git.mst@redhat.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When a structure contains a buffer that DMA writes to alongside fields that the CPU writes to, cache line sharing between the DMA buffer and CPU-written fields can cause data corruption on non-cache-coherent platforms. Add __dma_from_device_group_begin()/end() annotations to ensure proper alignment to prevent this: struct my_device { spinlock_t lock1; __dma_from_device_group_begin(); char dma_buffer1[16]; char dma_buffer2[16]; __dma_from_device_group_end(); spinlock_t lock2; }; Signed-off-by: Michael S. Tsirkin Acked-by: Marek Szyprowski Reviewed-by: Petr Tesarik --- include/linux/dma-mapping.h | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h index aa36a0d1d9df..29ad2ce700f0 100644 --- a/include/linux/dma-mapping.h +++ b/include/linux/dma-mapping.h @@ -7,6 +7,7 @@ #include #include #include +#include =20 /** * List of possible attributes associated with a DMA mapping. The semantics @@ -703,6 +704,18 @@ static inline int dma_get_cache_alignment(void) } #endif =20 +#ifdef ARCH_HAS_DMA_MINALIGN +#define ____dma_from_device_aligned __aligned(ARCH_DMA_MINALIGN) +#else +#define ____dma_from_device_aligned +#endif +/* Mark start of DMA buffer */ +#define __dma_from_device_group_begin(GROUP) \ + __cacheline_group_begin(GROUP) ____dma_from_device_aligned +/* Mark end of DMA buffer */ +#define __dma_from_device_group_end(GROUP) \ + __cacheline_group_end(GROUP) ____dma_from_device_aligned + static inline void *dmam_alloc_coherent(struct device *dev, size_t size, dma_addr_t *dma_handle, gfp_t gfp) { --=20 MST