From nobody Wed Feb 11 06:31:49 2026 Received: from irl.hu (irl.hu [95.85.9.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECB9B13C9A2; Tue, 26 Mar 2024 16:19:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.85.9.111 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711469943; cv=none; b=YGtSFdtLq33zQcgDvf0WvXaq8l/Abp/QsmWcWFkBpWiekDQxPH70e4x9ou/2LkWivbKoBqn0vfky6/7hukwpSJMm4DFrwpJ92Qi28oOoLe84PLnJAThdV9NL5ZSJVQq3B1BB08VklLkImNPw+1LiiO4ymahiPA/5f3dW/48XdLo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711469943; c=relaxed/simple; bh=L+q8Bz8ds3vFmEIewe+gxAJPjDaqpzMYghNPAeRyPt4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Mime-Version:Content-Type; b=NIEpQf/Rv/ZuKDvFjEEx8RjAlp5QT7bf8lNyqzuWIytIZijm+umR8NwRR59qIUGhjNcuWAAKnzniURzRrxO00wUMgTVflTCcUH1N+6uisCjp9JawWyCl+txU/oKOiP3LklmNobAteKRJrD6cX46CDWh3wThXJrrbx1InAe3Tub4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=irl.hu; spf=pass smtp.mailfrom=irl.hu; arc=none smtp.client-ip=95.85.9.111 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=irl.hu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=irl.hu Received: from fedori.lan (51b68717.dsl.pool.telekom.hu [::ffff:81.182.135.23]) (AUTH: CRAM-MD5 soyer@irl.hu, ) by irl.hu with ESMTPSA id 000000000007733D.000000006602F573.0023D3BC; Tue, 26 Mar 2024 17:18:59 +0100 From: Gergo Koteles To: Shenghao Ding , Kevin Lu , Baojun Xu , Jaroslav Kysela , Takashi Iwai Cc: alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Gergo Koteles Subject: [PATCH v2 3/4] ALSA: hda/tas2781: add debug statements to kcontrols Date: Tue, 26 Mar 2024 17:18:47 +0100 Message-ID: <18ff4b0caab90a2dacf907e62346fd5079a9eb1a.1711469583.git.soyer@irl.hu> X-Mailer: git-send-email 2.44.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mime-Autoconverted: from 8bit to 7bit by courier 1.0 Content-Type: text/plain; charset="utf-8" Sometimes it is useful to examine the timing of kcontrol events. Add debug statements to each kcontrol. Signed-off-by: Gergo Koteles --- sound/pci/hda/tas2781_hda_i2c.c | 35 +++++++++++++++++++++++++++++---- 1 file changed, 31 insertions(+), 4 deletions(-) diff --git a/sound/pci/hda/tas2781_hda_i2c.c b/sound/pci/hda/tas2781_hda_i2= c.c index 9a43f563bb9e..f495caee38e1 100644 --- a/sound/pci/hda/tas2781_hda_i2c.c +++ b/sound/pci/hda/tas2781_hda_i2c.c @@ -189,6 +189,9 @@ static int tasdevice_get_profile_id(struct snd_kcontrol= *kcontrol, =20 ucontrol->value.integer.value[0] =3D tas_priv->rcabin.profile_cfg_id; =20 + dev_dbg(tas_priv->dev, "%s: kcontrol %s: %d\n", + __func__, kcontrol->id.name, tas_priv->rcabin.profile_cfg_id); + mutex_unlock(&tas_priv->codec_lock); =20 return 0; @@ -206,6 +209,10 @@ static int tasdevice_set_profile_id(struct snd_kcontro= l *kcontrol, =20 mutex_lock(&tas_priv->codec_lock); =20 + dev_dbg(tas_priv->dev, "%s: kcontrol %s: %d -> %d\n", + __func__, kcontrol->id.name, + tas_priv->rcabin.profile_cfg_id, val); + if (tas_priv->rcabin.profile_cfg_id !=3D val) { tas_priv->rcabin.profile_cfg_id =3D val; ret =3D 1; @@ -253,6 +260,9 @@ static int tasdevice_program_get(struct snd_kcontrol *k= control, =20 ucontrol->value.integer.value[0] =3D tas_priv->cur_prog; =20 + dev_dbg(tas_priv->dev, "%s: kcontrol %s: %d\n", + __func__, kcontrol->id.name, tas_priv->cur_prog); + mutex_unlock(&tas_priv->codec_lock); =20 return 0; @@ -271,6 +281,9 @@ static int tasdevice_program_put(struct snd_kcontrol *k= control, =20 mutex_lock(&tas_priv->codec_lock); =20 + dev_dbg(tas_priv->dev, "%s: kcontrol %s: %d -> %d\n", + __func__, kcontrol->id.name, tas_priv->cur_prog, val); + if (tas_priv->cur_prog !=3D val) { tas_priv->cur_prog =3D val; ret =3D 1; @@ -290,6 +303,9 @@ static int tasdevice_config_get(struct snd_kcontrol *kc= ontrol, =20 ucontrol->value.integer.value[0] =3D tas_priv->cur_conf; =20 + dev_dbg(tas_priv->dev, "%s: kcontrol %s: %d\n", + __func__, kcontrol->id.name, tas_priv->cur_conf); + mutex_unlock(&tas_priv->codec_lock); =20 return 0; @@ -308,6 +324,9 @@ static int tasdevice_config_put(struct snd_kcontrol *kc= ontrol, =20 mutex_lock(&tas_priv->codec_lock); =20 + dev_dbg(tas_priv->dev, "%s: kcontrol %s: %d -> %d\n", + __func__, kcontrol->id.name, tas_priv->cur_conf, val); + if (tas_priv->cur_conf !=3D val) { tas_priv->cur_conf =3D val; ret =3D 1; @@ -330,6 +349,9 @@ static int tas2781_amp_getvol(struct snd_kcontrol *kcon= trol, =20 ret =3D tasdevice_amp_getvol(tas_priv, ucontrol, mc); =20 + dev_dbg(tas_priv->dev, "%s: kcontrol %s: %ld\n", + __func__, kcontrol->id.name, ucontrol->value.integer.value[0]); + mutex_unlock(&tas_priv->codec_lock); =20 return ret; @@ -345,6 +367,9 @@ static int tas2781_amp_putvol(struct snd_kcontrol *kcon= trol, =20 mutex_lock(&tas_priv->codec_lock); =20 + dev_dbg(tas_priv->dev, "%s: kcontrol %s: -> %ld\n", + __func__, kcontrol->id.name, ucontrol->value.integer.value[0]); + /* The check of the given value is in tasdevice_amp_putvol. */ ret =3D tasdevice_amp_putvol(tas_priv, ucontrol, mc); =20 @@ -361,8 +386,8 @@ static int tas2781_force_fwload_get(struct snd_kcontrol= *kcontrol, mutex_lock(&tas_priv->codec_lock); =20 ucontrol->value.integer.value[0] =3D (int)tas_priv->force_fwload_status; - dev_dbg(tas_priv->dev, "%s : Force FWload %s\n", __func__, - tas_priv->force_fwload_status ? "ON" : "OFF"); + dev_dbg(tas_priv->dev, "%s: kcontrol %s: %d\n", + __func__, kcontrol->id.name, tas_priv->force_fwload_status); =20 mutex_unlock(&tas_priv->codec_lock); =20 @@ -377,14 +402,16 @@ static int tas2781_force_fwload_put(struct snd_kcontr= ol *kcontrol, =20 mutex_lock(&tas_priv->codec_lock); =20 + dev_dbg(tas_priv->dev, "%s: kcontrol %s: %d -> %d\n", + __func__, kcontrol->id.name, + tas_priv->force_fwload_status, val); + if (tas_priv->force_fwload_status =3D=3D val) change =3D false; else { change =3D true; tas_priv->force_fwload_status =3D val; } - dev_dbg(tas_priv->dev, "%s : Force FWload %s\n", __func__, - tas_priv->force_fwload_status ? "ON" : "OFF"); =20 mutex_unlock(&tas_priv->codec_lock); =20 --=20 2.44.0