From nobody Thu Apr 9 11:56:02 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB0C42494ED; Mon, 9 Mar 2026 16:48:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773074886; cv=none; b=JYBtoSbgqwDxBs2nYVYBxmOwPlu05x+OIkpgQSErUcblaFkVdahhG0RK4D1u+AoyuWb8oiQX0UYIZqE/LJr+yx3b6q/zDFBKGJaIEyii28KynKEr90U+W9qPKsTArnGVLymh76+JmveWwgK71TbOHBFXan8zZ8c3Wk1UzWhO9uE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773074886; c=relaxed/simple; bh=Og3btdqqsss2BN07XAVoT1mCvNdW9py94Li7vBmuxJ4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=K4JoY2Px/qPV7ADdmLD8PaursFTI0zfgkYTn+CPyVRCtX2pakRlbF2HNrKq2OELYk6QquDa1Pmskj8ujMoCKIE1Jwf078toeGlpwlxqbyTrrAbzvbRb9hc1TxrZKOpoQ4AoRbq8piFI+duQ+190OUEy8H6W2YhSKuTjS0EfRkg0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YUfyEWvr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YUfyEWvr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3AFAC2BCB2; Mon, 9 Mar 2026 16:48:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773074885; bh=Og3btdqqsss2BN07XAVoT1mCvNdW9py94Li7vBmuxJ4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YUfyEWvrzNP4u8VpiIWyyDzjz8AZuCmEeDOIvLQOUdAhZS+I59gOPLT5M5H+D9f3A RA+4RrdQ6euOM/yiRDCvFFHsN209Guhm5jeiQiHsJMHFwgF1T1qricAxKxF+v4DAoQ KsHu46bPGadSr7OQqBQd1D2e142+tzXOaRs3P9fpLD0BGwH9/Syq6iUyXvXlWEZurl YMKlI1FDSLm2z55aL0RD8NkqerYBN4OQZlity/5QV43H9GhJQArmTdZuFfQIvSRh+V mJQfDni61ORCXiJa1G8qmQcLN2FOZxCjbBBnWBsRO92uczcXTeQ2LAPgjJhtk3A3c8 xsnpNw7yj/pMw== Received: from mchehab by mail.kernel.org with local (Exim 4.99.1) (envelope-from ) id 1vzdm0-0000000Bhag-0IlN; Mon, 09 Mar 2026 17:48:04 +0100 From: Mauro Carvalho Chehab To: Jonathan Corbet , Linux Doc Mailing List Cc: Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, Aleksandr Loktionov , Randy Dunlap Subject: [PATCH 3/8] docs: kdoc: don't add broken comments inside prototypes Date: Mon, 9 Mar 2026 17:47:54 +0100 Message-ID: <18e577dbbd538dcc22945ff139fe3638344e14f0.1773074166.git.mchehab+huawei@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: Mauro Carvalho Chehab Parsing a file like drivers/scsi/isci/host.h, which contains broken kernel-doc markups makes it create a prototype that contains unmatched end comments. That causes, for instance, struct sci_power_control to be shown this this prototype: struct sci_power_control { * it is not. */ bool timer_started; */ struct sci_timer timer; * requesters field. */ u8 phys_waiting; */ u8 phys_granted_power; * mapped into requesters via struct sci_phy.phy_index */ struct isc= i_phy *requesters[SCI_MAX_PHYS]; }; as comments won't start with "/*" anymore. Fix the logic to detect such cases, and keep adding the comments inside it. Signed-off-by: Mauro Carvalho Chehab --- tools/lib/python/kdoc/kdoc_parser.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tools/lib/python/kdoc/kdoc_parser.py b/tools/lib/python/kdoc/k= doc_parser.py index edf70ba139a5..086579d00b5c 100644 --- a/tools/lib/python/kdoc/kdoc_parser.py +++ b/tools/lib/python/kdoc/kdoc_parser.py @@ -1355,6 +1355,12 @@ class KernelDoc: elif doc_content.search(line): self.emit_msg(ln, f"Incorrect use of kernel-doc format: {line}= ") self.state =3D state.PROTO + + # + # Don't let it add partial comments at the code, as breaks the + # logic meant to remove comments from prototypes. + # + self.process_proto_type(ln, "/**\n" + line) # else ... ?? =20 def process_inline_text(self, ln, line): --=20 2.52.0