From nobody Wed Dec 17 00:04:43 2025 Received: from cloudserver094114.home.pl (cloudserver094114.home.pl [79.96.170.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98AA6199252; Mon, 17 Jun 2024 18:13:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=79.96.170.134 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718648000; cv=none; b=rnqChI3Ys72JkdTKA9pmC7GACfpBLO0hYs8uRto05YkQBpPjAS3XfE9jNFpMDCaFxNQfCVLW7BEyUM47v2Omm46I3Ex/VVb0BF692SQuL6rWGwCY7JbU2Fhj5Fi+HdXVd7LbayH+p0UX3kAsv5xZm3U2+BXGqKK8SVvy+bPTKw4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718648000; c=relaxed/simple; bh=igm8Hsce+3exsKL3ldkATepEb7/+cdyJt0g/twzxO/E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ptlKqQkSyhi3n+cHrzkZk0U3EOVa5JgIJajIrsiLZwcdSleEnd8YqPI0zsh68i7cf1FUu65WmB7/ZBa4XHu362i9nrshzupYv74sj7cpB+xQRlcy4fmlRRhfmKqIZfhOodWYK/BLgm+orrpIA+iL844VOiSMB+7I9oyWV3LDg7U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rjwysocki.net; spf=pass smtp.mailfrom=rjwysocki.net; dkim=fail (2048-bit key) header.d=rjwysocki.net header.i=@rjwysocki.net header.b=ffZ+tJhe reason="signature verification failed"; arc=none smtp.client-ip=79.96.170.134 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rjwysocki.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rjwysocki.net Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=rjwysocki.net header.i=@rjwysocki.net header.b="ffZ+tJhe" Received: from localhost (127.0.0.1) (HELO v370.home.net.pl) by /usr/run/smtp (/usr/run/postfix/private/idea_relay_lmtp) via UNIX with SMTP (IdeaSmtpServer 6.2.0) id 76089fbcec77b1d6; Mon, 17 Jun 2024 20:13:15 +0200 Received: from kreacher.localnet (unknown [195.136.19.94]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by cloudserver094114.home.pl (Postfix) with ESMTPSA id 401F616606FD; Mon, 17 Jun 2024 20:13:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=rjwysocki.net; s=dkim; t=1718647995; bh=igm8Hsce+3exsKL3ldkATepEb7/+cdyJt0g/twzxO/E=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ffZ+tJheaBVcw11a+Zefx+6hM5iNE+t9Ys4I8v3mHMkweOf7c83p22dGZcksJfKHO /oJdV6jVR3P5cVsVvyEgTOv4qrcQJScDhyWzeWbR9duqXYyybII3SU2TkXaVvLlLjP 7YwU6wHIHbiPT1IAcCAhKxE3JrOoTR2amIN+wALpolIbCFjd8TCNrghLpSgr4c9h33 sZze3itRs+mEq9zkfD2mO9ve96NYMu9R9wLhUusrxEyXx1eSSjBf8H3powBWsaQmpc z5340pSqyDTDJvk9m87RDm9Nh/1PbA8KAsu1uRLNp2yGnlnKUAyVP7Ke9f6d61CcGn jEbCgiwroG8Rw== From: "Rafael J. Wysocki" To: Linux PM Cc: LKML , "Rafael J. Wysocki" , Lukasz Luba , Daniel Lezcano , Shawn Guo , Pengutronix Kernel Team , Sascha Hauer Subject: [PATCH v1 01/14] thermal: imx: Drop critical trip check from imx_set_trip_temp() Date: Mon, 17 Jun 2024 19:48:56 +0200 Message-ID: <1818450.VLH7GnMWUR@kreacher> In-Reply-To: <8409966.T7Z3S40VBb@kreacher> References: <8409966.T7Z3S40VBb@kreacher> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CLIENT-IP: 195.136.19.94 X-CLIENT-HOSTNAME: 195.136.19.94 X-VADE-SPAMSTATE: clean X-VADE-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvledrfedvhedguddvvdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfjqffogffrnfdpggftiffpkfenuceurghilhhouhhtmecuudehtdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvvefufffkjghfggfgtgesthfuredttddtjeenucfhrhhomhepfdftrghfrggvlhculfdrucghhihsohgtkhhifdcuoehrjhifsehrjhifhihsohgtkhhirdhnvghtqeenucggtffrrghtthgvrhhnpedvffeuiedtgfdvtddugeeujedtffetteegfeekffdvfedttddtuefhgeefvdejhfenucfkphepudelhedrudefiedrudelrdelgeenucevlhhushhtvghrufhiiigvpedvnecurfgrrhgrmhepihhnvghtpeduleehrddufeeirdduledrleegpdhhvghlohepkhhrvggrtghhvghrrdhlohgtrghlnhgvthdpmhgrihhlfhhrohhmpedftfgrfhgrvghlucflrdcuhgihshhotghkihdfuceorhhjfiesrhhjfiihshhotghkihdrnhgvtheqpdhnsggprhgtphhtthhopeekpdhrtghpthhtoheplhhinhhugidqphhmsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtoheprhgrfhgrvghlsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehluhhkrghsiidrlhhusggrsegrrhhmrdgtohhmpdhrtghpthhtohepuggrnhhivghlrdhlvgiitggrnhhosehlihhnrghrohdrohhrghdprhgtphhtthhopehshhgrfihnghhuoheskhgvrhhnvghlrdhorhhg X-DCC--Metrics: v370.home.net.pl 1024; Body=8 Fuz1=8 Fuz2=8 Content-Type: text/plain; charset="utf-8" From: Rafael J. Wysocki Because the IMX thermal driver does not flag its critical trip as writable, imx_set_trip_temp() will never be invoked for it and so the critical trip check can be dropped from there. Signed-off-by: Rafael J. Wysocki --- drivers/thermal/imx_thermal.c | 9 --------- 1 file changed, 9 deletions(-) Index: linux-pm/drivers/thermal/imx_thermal.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- linux-pm.orig/drivers/thermal/imx_thermal.c +++ linux-pm/drivers/thermal/imx_thermal.c @@ -335,21 +335,12 @@ static int imx_set_trip_temp(struct ther int temp) { struct imx_thermal_data *data =3D thermal_zone_device_priv(tz); - struct thermal_trip trip; int ret; =20 ret =3D pm_runtime_resume_and_get(data->dev); if (ret < 0) return ret; =20 - ret =3D __thermal_zone_get_trip(tz, trip_id, &trip); - if (ret) - return ret; - - /* do not allow changing critical threshold */ - if (trip.type =3D=3D THERMAL_TRIP_CRITICAL) - return -EPERM; - /* do not allow passive to be set higher than critical */ if (temp < 0 || temp > trips[IMX_TRIP_CRITICAL].temperature) return -EINVAL;