From nobody Mon Jun 15 10:50:32 2026 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 457AA3B9D99 for ; Thu, 9 Apr 2026 16:34:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775752469; cv=none; b=aJeI5WZSMdTtuLDEVPMM2dwf87w3mN24JQW1De9bQPeEmiirlNN6wUQ7hwGE6UNKPpCGZDag+zi3LEF8FY6rOy2mj0HnUlT395x72IH+wdasYQ8o6knQpU+vjl21EzekB/euuywg9vrtVnoSDrPzJiOt5rWyqLKFJBtqunOa/sQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775752469; c=relaxed/simple; bh=5HPjyCGIUcS+XZxwOq7su4bREXkMRa1byoy+Frp53Po=; h=From:Content-Type:Mime-Version:Date:Subject:Cc:To:Message-Id; b=E8TuuSe+1R/VmPnjyZv1xqPnATACD67SWTOwMoFH7E4LJEPKGRIYdtNB+QwkK4Tewn6T0NJpK6qITLCPV5GL56nqn17k/7UaB+P+9lr2Aa0MWSK341oRmOMZ95bqspxmHsLm47GmDI8Q9u0T6671mKcpKoFXELnBvESCu0G0rW4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=doyensec.com; spf=pass smtp.mailfrom=doyensec.com; dkim=pass (2048-bit key) header.d=doyensec.com header.i=@doyensec.com header.b=aH6o9YBl; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=doyensec.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=doyensec.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=doyensec.com header.i=@doyensec.com header.b="aH6o9YBl" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-65c4152313fso1421173a12.1 for ; Thu, 09 Apr 2026 09:34:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=doyensec.com; s=google; t=1775752465; x=1776357265; darn=vger.kernel.org; h=message-id:to:cc:subject:date:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=yvD6iQG1O/I+/j+ks+GogJBSWRhUCp/c6DPnLqjhUYs=; b=aH6o9YBltKABjgEBzu/nAhJP6F+ofom9cYSXrXN4aaDfOUPGiaZrCKPx64PfJ/GcvU zUE8AKS3H2E3OetHTZPleDT130VdpSpbGC9gRiC6/QKayxa30X+ePVnaxKI+05kMXeS2 hj3QQG7FQQCtq/mekkWUN4lFdWqr5IlEQ7tBC4WBNUdO08rzgS816SlSNVJ54iKmhjVj /qcLjovbuvRO864kRgMiFxf4tfi+QlhF7IJeTNRXG/7z7tutOH1zXpvq3qbfb8NvuAQu iYi7KTChBm8nLQC9Jt1jMn9O2ezdAjgEQzjGrHOe6fKCZwKbovd5KhswuT6GZaeFjeGs Hrxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775752465; x=1776357265; h=message-id:to:cc:subject:date:mime-version :content-transfer-encoding:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=yvD6iQG1O/I+/j+ks+GogJBSWRhUCp/c6DPnLqjhUYs=; b=Ro0ngq7EajL4FdXZ7n/FQET16F/Kwi9t0wh+vy9c6W1uA5zeD2NJwVfHk7GatkPmjX +tKF5cU4bSI/LoqNuCyK4LBx6FSTLM+8VTlXZ6LgDLNr7m0jkca+XlBzb8adCGsS8IJD 4FP45RJqdLDzkSvJ9/r5gHb6eXYPTFyZW24noynv1KuueiNfk7QyvOmuFKrq8gE0InYW tpTprZ+4K9+WVkQpHA1Ns4WZXo+C7Hbe6bMcdXrf5KMcxSAFcXjVXxMLZf35Hg+t0BuF A06KehS+w4pzYRa4d6JPLqH8cWnfvTHEaMBX1LQSVMeIkuobNsXnQkdlJMsV05yxa9QS D/kw== X-Forwarded-Encrypted: i=1; AJvYcCUKNGtzU9KjABXdlUAkFkKlH6HzlRlJ8qEQlWpK51s5RvWGh6DTnlMykXUML18XMAawlMqpKY2PKwUwdaA=@vger.kernel.org X-Gm-Message-State: AOJu0YyKU3gqTgVUEA8p6RUUo59GpdUKEP7y/n0GEbhQqztsWLsrDV4v F54qQlKxvyeHpwdBr386aL/C6vw+uyfKZHJn6D6L+OVDzUC0OTqlzr46jTkmlvKtQaQ= X-Gm-Gg: AeBDieuXwp0wPHHTkjFRCbLS/ttHQ2YFVcuxRKQsf+5dWVoabPPzrkV4ODIO8RzDfOR 93vTWgA7VdI6Rv8vdX0X4+nkP84AyS/hwDAgHv64m03QjeGGz4KLN0e+XpkEnEgg9nDbk42XMaB UuAqSpMKpboQJk394WJrk92v4TimBAiU7avLLKPZI+SY3DI++aeLs/8dmPK+fRxsQGQAVHd95LN nChDuNsDA0P27His3iIhAUACLW7vEkWm2JMbzp0V+cVf4X4aSd09qtxBav7ZPqnaz42mNeSz+8H rp9g3OePCEG0NamD+/o1hAMfOF+Es3NYdBi/tNz79qTpK3SmNw2M4XOljsaVWqNsOyxdzS1ScTf H1kDQvs/K/5sLH7l496z2lwpn2MMuRxny53Q4D9/LxMQvNOR3ebjf10+cgCFAYQEXbBt3qbR1Xm LtFXSKpCDSQ9pTEiJeKaCpCTuiGPeMQHP26sExIuZf/CqX0TtYt+kwsgiq+XgGi24ztmnNV+vil kc3 X-Received: by 2002:a05:6402:504a:b0:66e:df52:7ce0 with SMTP id 4fb4d7f45d1cf-66edf527d86mr8235560a12.17.1775752465513; Thu, 09 Apr 2026 09:34:25 -0700 (PDT) Received: from smtpclient.apple (83.10.27.44.ipv4.supernova.orange.pl. [83.10.27.44]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-66e033a787fsm5984074a12.14.2026.04.09.09.34.23 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Apr 2026 09:34:24 -0700 (PDT) From: Norbert Szetei Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81.1.4\)) Date: Thu, 9 Apr 2026 18:34:12 +0200 Subject: [PATCH v3 net] vsock: fix buffer size clamping order Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Stefano Garzarella Message-Id: <180118C5-8BCF-4A63-A305-4EE53A34AB9C@doyensec.com> X-Mailer: Apple Mail (2.3826.700.81.1.4) Content-Type: text/plain; charset="utf-8" In vsock_update_buffer_size(), the buffer size was being clamped to the maximum first, and then to the minimum. If a user sets a minimum buffer size larger than the maximum, the minimum check overrides the maximum check, inverting the constraint. This breaks the intended socket memory boundaries by allowing the vsk->buffer_size to grow beyond the configured vsk->buffer_max_size. Fix this by checking the minimum first, and then the maximum. This ensures the buffer size never exceeds the buffer_max_size. Fixes: b9f2b0ffde0c ("vsock: handle buffer_size sockopts in the core") Suggested-by: Stefano Garzarella Signed-off-by: Norbert Szetei Reviewed-by: Stefano Garzarella --- v3:=20 - Added Fixes and Suggested-by tags. net/vmw_vsock/af_vsock.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c index d912ed2f012a..08f4dfb9782c 100644 --- a/net/vmw_vsock/af_vsock.c +++ b/net/vmw_vsock/af_vsock.c @@ -1951,12 +1951,12 @@ static void vsock_update_buffer_size(struct vsock_s= ock *vsk, const struct vsock_transport *transport, u64 val) { - if (val > vsk->buffer_max_size) - val =3D vsk->buffer_max_size; - if (val < vsk->buffer_min_size) val =3D vsk->buffer_min_size; =20 + if (val > vsk->buffer_max_size) + val =3D vsk->buffer_max_size; + if (val !=3D vsk->buffer_size && transport && transport->notify_buffer_size) transport->notify_buffer_size(vsk, &val); --=20 2.53.0