From nobody Fri Sep 25 20:48:29 2026 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 106C147986A; Mon, 21 Sep 2026 09:27:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789982865; cv=none; b=YPaL0zKACUs4tn3fZT4bRzjRf+YOSRHIR1G+Lw0/qKA/pBeqEIsfz9dzfDzH6x2hfJL+4nhYpIfq/x+tnlKUOUNBQUJbKn2SXPzTtbdqPhroeHwyJ97H/UTnXU7rgqqfwm0U6EdLEecz1sygTZ430v3vleEZs/o+OJ0ICePBZHs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789982865; c=relaxed/simple; bh=hgV3orOjrKOMr8ez+fAIM41KRdyL9smh3AJFwwJi7KQ=; h=Date:From:To:Subject:Cc:In-Reply-To:References:MIME-Version: Message-ID:Content-Type; b=sL/H0PPtQcggmxvysN/Xjyaqm8Xdy7hJZcUuuVrAWtnDOS5m7ySJS3xBjjx4DuOX59ASuJqYSO4oxHyryCOu5wcQbhAX4E9RESPwSgt49Y4EFW9Q4V8Fj9sPxsxXX7HN0Y8MR+o0SBBkYGpfGQX2PiQuDU/n+R+8fmMfWbE7WnE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=1nEaTyoE; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=IfvR7DPV; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="1nEaTyoE"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="IfvR7DPV" Date: Mon, 21 Sep 2026 09:27:39 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1789982861; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oZO92m/pQj4sfeuXxHkLGsGjYYBcia9C5xfyEyFsLxM=; b=1nEaTyoEYDR3x1SSMol4JnLnJ3atYdn5cClKJXsJxFIgEnkWJ/L3HCFiBdUXHMGudL9hPg 7vB4yL82nea5+i1Vbr+J9jLeNhkiWK0KakRWXguqecuU41nnSKRVZDHdXf5E5Ok5pCpd6W Bg6t++Ide3XXoL/E5AHrqSh0zbHEtpkcUSNGDZOnGLeO8iuaYUgfUSjn4P8KMuTX+KGc/Y 5f513Pk71UDwzc7bo9CGC9OZ9TgfQTGKfizpF8c7FsdKZqcG3xbBR880tqpYvhYm+IZjL7 /Aqyxf8CBrX8yYsUz7fa89Q3qYshwSXz+b0r2a5YR9RvCQl/nGdxHYfEat/n2A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1789982861; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oZO92m/pQj4sfeuXxHkLGsGjYYBcia9C5xfyEyFsLxM=; b=IfvR7DPV7pFLVSJ89lmFHqW8PvGANxPycQZE3cg8mQ3dLI0rpSS5K5H+YT9cnyUN3pJuxH ApCDZTFrg0UketBQ== From: "tip-bot2 for Song Liu" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: objtool/core] objtool/klp: Add test for a static call introduced by the patch Cc: Song Liu , Josh Poimboeuf , Ingo Molnar , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20260916184351.2720310-51-song@kernel.org> References: <20260916184351.2720310-51-song@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <178998285961.2819794.916399678327143574.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Precedence: bulk Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The following commit has been merged into the objtool/core branch of tip: Commit-ID: 938816b7d15644a486ebcea5d58994664b8cc04c Gitweb: https://git.kernel.org/tip/938816b7d15644a486ebcea5d58994664= b8cc04c Author: Song Liu AuthorDate: Wed, 16 Sep 2026 11:43:43 -07:00 Committer: Ingo Molnar CommitterDate: Mon, 21 Sep 2026 11:12:07 +02:00 objtool/klp: Add test for a static call introduced by the patch The counterpart to the static branch case: a patch may add a static call to a function which had none, so the .static_call_sites entry is new and there is nothing in the original to correlate it against. Where the key lives still decides whether that is allowed. A vmlinux key is reachable; a module-owned one is not, for the same reason an existing module key is not -- late module patching lets the livepatch load first and the unresolved entry is dereferenced when the module arrives. Both halves are here because they fail in opposite directions: dropping the new entry leaves a static call the kernel never patches, and accepting a new module-owned one is the corruption the check exists to prevent. Both halves are one test over one fixture: built with -DNEW_CALL the key is vmlinux's and the new entry has to be carried in; built with -DMODNAME as well the key belongs to a module, klp diff has to reject it, and no output object may be left behind. The premise is asserted first -- the original must have no .static_call_sites at all -- since otherwise this is a second copy of test-static-call-module-key. Covers the same ground as corpus/x86_64/static-call-vmlinux-new and corpus/x86_64/static-call-module-new in Joe Lawrence's klp-build unit test corpus. Assisted-by: Claude:claude-opus-4 Based-on-test-by: Joe Lawrence Assisted-by: Claude:claude-opus-5 Signed-off-by: Song Liu Signed-off-by: Josh Poimboeuf Signed-off-by: Ingo Molnar Link: https://patch.msgid.link/20260916184351.2720310-51-song@kernel.org --- tools/objtool/tests/generic/test-static-call-new.sh | 45 ++++++++++++- 1 file changed, 45 insertions(+) create mode 100755 tools/objtool/tests/generic/test-static-call-new.sh diff --git a/tools/objtool/tests/generic/test-static-call-new.sh b/tools/ob= jtool/tests/generic/test-static-call-new.sh new file mode 100755 index 0000000..f7d2b39 --- /dev/null +++ b/tools/objtool/tests/generic/test-static-call-new.sh @@ -0,0 +1,45 @@ +#!/bin/bash +# SPDX-License-Identifier: GPL-2.0 +# +# A patch may introduce a static call where the original function had none. +# +# The .static_call_sites entry is then new, with nothing in the original to +# correlate it against, so klp diff has to carry it into the patch from +# scratch. Where the key lives still decides whether that is allowed: a +# vmlinux key is reachable, and a module-owned one is not, for the same re= ason +# an existing module key is not -- late module patching lets the livepatch= load +# first, and the unresolved entry is dereferenced when the module arrives. +# +# Both halves are here because they fail in opposite directions. Dropping= the +# new entry leaves a static call the kernel never patches; accepting a new +# module-owned one is the corruption the check exists to prevent. +# +# Covers the same ground as corpus/x86_64/static-call-vmlinux-new and +# static-call-module-new in Joe Lawrence's klp-build unit test corpus. + +. "$(dirname "$0")/../lib.sh" + +setup +build_pair static_call.c -DNEW_CALL + +# The premise: the original really has no static call, the patched one doe= s. +has_input_section orig.o .static_call_sites && + fail "fixture put a .static_call_sites in the original; nothing new to ad= d" +has_input_section patched.o .static_call_sites || + probe_skip "compiler produced no .static_call_sites on this arch" + +run_diff +assert_patched target +assert_section .static_call_sites +assert_reloc_sym .static_call_sites target + +# The same new call, with the key owned by a module: not reachable, so the +# build has to stop rather than emit a relocation nothing will resolve. +rm -f "$workdir/out.o" +build_pair static_call.c -DNEW_CALL -DMODNAME=3D'"klp_testmod"' +run_diff 255 +assert_diff_log 'unsupported static call key __SCK__klp_test_call' +[ -e "$workdir/out.o" ] && + fail "output object produced for a rejected input" + +pass "static call introduced by the patch carried in, or rejected for a mo= dule key"