From nobody Tue Sep 29 02:02:38 2026 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26F73468C2C; Thu, 13 Aug 2026 11:16:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786619789; cv=none; b=DKjPDl1bwuRKqeBRk4k+MYj+MxsPYGe7z1nUWxwtz36hvHvxmX3WCqo6NiWujkwheEiZx4Y9jFFG/Fr4bEy9HX4fLX+RmOir7+Yu3kkPPM4ytLyAkcMhJ6Ct0Go2uJrWn3eMGuxmUPA6Vd2Mj/DzLTXeDeKr53Q9VNigGtkRiXE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786619789; c=relaxed/simple; bh=byf8g9tdp7+ybs6SCONnVjEF32X4hcuufcEBgEtMQag=; h=Date:From:To:Subject:Cc:In-Reply-To:References:MIME-Version: Message-ID:Content-Type; b=nRV9ycr1IOhxGS/+rORZvprsVx9aslB06MR4C8/plZ6mpS6d1B56y1u1wDFNxq9zFk2majqGY7vzZcbSxZj65XPNRTZ6b1382Bhhk8tlMmv12i0Sb1S4XSrVGLXyWYgT1p7kE2EVBO9vTNnjlJQuWZGThE2DXzAHGAAh5QkJzvo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=aw81+xeG; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=NZUvVeZE; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="aw81+xeG"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="NZUvVeZE" Date: Thu, 13 Aug 2026 11:16:20 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1786619782; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7SvDm+iIENdr0kfMZRWfLW2Dd4Mb+eHA4JgskOoOvOA=; b=aw81+xeG1FrT7xxZPXAHBsDYyaWhY161YcnOXB57u3jMC8euSgrpGjt5wZbuoThiv76I4h HqJBs1cYZrMmpjq9BYxiY3N4vdb9pl9qtQV62+45LOzzhCJvzRl5nofYwiZ49LRTlT5bjH oNkWVZZy+SdTPer4A3atoZZTyL5tpIhYIfoQaqBYTcDuCeWDNapDaLgwu9UuJlJ7QoBf8u eIyWrFK+Yk9atRyRgEju+NhSGJGuyNU1pAn+XvwEKvzlZsMQpj9Bg7wY/yzw6Afrc8yzRc YdJhtfpaIqtx0ald7wYATg6kP2nQ3/01qy1Gz5emxDdS70bmkfhK5jpYa5CYVg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1786619782; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7SvDm+iIENdr0kfMZRWfLW2Dd4Mb+eHA4JgskOoOvOA=; b=NZUvVeZEDg9b2uaLCrtljVloCm9wNj57D+0/tbMZZB1CtVI863ZkVHNXB0lDynGkCVwUJ8 bq4WvNjIHAJ6TfBw== From: "tip-bot2 for Puranjay Mohan" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: objtool/core] objtool/klp: Fix vmlinux .klp.symid link error for .exitcall.exit symbols Cc: Puranjay Mohan , Josh Poimboeuf , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <178661978061.442315.11308131482783171869.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Precedence: bulk Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The following commit has been merged into the objtool/core branch of tip: Commit-ID: 6656cf1e975aa152c082012b820efffaebd49979 Gitweb: https://git.kernel.org/tip/6656cf1e975aa152c082012b820efffae= bd49979 Author: Puranjay Mohan AuthorDate: Fri, 07 Aug 2026 11:16:29 -07:00 Committer: Josh Poimboeuf CommitterDate: Wed, 12 Aug 2026 13:33:32 -07:00 objtool/klp: Fix vmlinux .klp.symid link error for .exitcall.exit symbols Building a kernel via klp-build fails to link: `__exitcall_aes_mod_exit' referenced in section `.klp.symid' of vmlinux.o= : defined in discarded section `.exitcall.exit' of vmlinux.o `__exitcall_dax_exit' referenced in section `.klp.symid' of vmlinux.o: de= fined in discarded section `.exitcall.exit' of vmlinux.o `__exitcall_hid_exit' referenced in section `.klp.symid' of vmlinux.o: de= fined in discarded section `.exitcall.exit' of vmlinux.o `__exitcall_usb_serial_module_exit' referenced in section `.klp.symid' of= vmlinux.o: defined in discarded section `.exitcall.exit' of vmlinux.o module_exit() on a built-in emits a static __exitcall_$fn pointer into .exitcall.exit, which vmlinux.lds.h discards unconditionally via EXIT_CALL. When two built-in translation units define a module_exit() function of the same name, the resulting local symbols collide, symid_needed() sees a duplicate and emits a .klp.symid entry for each, referencing symbols the linker then throws away. Same-named module_exit() functions are not rare: dax_exit drivers/dax/device.c, drivers/dax/fsdev.c hid_exit drivers/hid/hid-core.c, drivers/hid/usbhid/hid-co= re.c aes_mod_exit arch/arm64/crypto/aes-ce-ccm-glue.c, lib/crypto/a= es.c usb_serial_module_exit module_usb_serial_driver() expands to this fixed name in each of its ~49 users The last one makes the collision structural rather than accidental: any kernel with two built-in USB serial drivers has it. This is not arch specific either; it only requires the objects to be built in rather than modular, which is why a monolithic config trips it while a typical distro config does not. Add .exitcall.exit to the discarded section list so its symbols don't get symids. This is the same failure mode as "objtool/klp: Fix vmlinux .klp.symid link error for .no_trim_symbol symbols", for another unconditionally discarded allocated section. Fixes: 029223d30162 ("objtool/klp: Add .klp.symid for sympos disambiguation= ") Signed-off-by: Puranjay Mohan Link: https://patch.msgid.link/m24igzlbxf.fsf@kernel.org Signed-off-by: Josh Poimboeuf --- tools/objtool/klp-symid.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/objtool/klp-symid.c b/tools/objtool/klp-symid.c index 21d8708..b19f76d 100644 --- a/tools/objtool/klp-symid.c +++ b/tools/objtool/klp-symid.c @@ -30,6 +30,7 @@ =20 static const char * const discarded_secs[] =3D { ".discard", + ".exitcall.exit", ".modinfo", ".no_trim_symbol", "__tracepoint_check",