From nobody Tue Sep 29 10:35:40 2026 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A5A5381B02; Sat, 8 Aug 2026 20:48:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786222117; cv=none; b=JPsNSNihHnITX14dhC1r3bXkagOBQc/NbiqHkcHyGwL3gFlS6qvf6uE0g46/chO/EpRQGqfk5ZaL4Mtz3bbbzN7/YW7oZ/HexJI83affr9MpHe5hqGsOpAYfa5b6atEtsrLaJiNw7f1WbE+qxYiIhdYixb5903jC6nqyBDb5cLM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786222117; c=relaxed/simple; bh=Xnn8NXHKjb8aslJaFEniEsBnUJgEM4dVvlwgv3uVHH4=; h=Date:From:To:Subject:Cc:In-Reply-To:References:MIME-Version: Message-ID:Content-Type; b=iQANDrBrf5pj3wjfkzjehU21/zQumbXiZwnAl1DEPvNdALXiXWztpM4u1khRFaBl8XZdzjmFPTWJewwDVBDMKD0XK3aI9fU2Pt6pGi8KTjFdM5unoDENcs5A8WlaulnJIm5Mhc4TWT6aStEN+t4N2rF52fliCxc3tglIJa7uBjg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=nZBopgoP; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=3/maonhp; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="nZBopgoP"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="3/maonhp" Date: Sat, 08 Aug 2026 20:48:32 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1786222113; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gj5T1xJcXF8eC6UDI5Yz5y/KObeY+ndxdiI0cjIoZ0c=; b=nZBopgoPo3CtfYm/DzTwnRHc/LnKCZvsQ/nY0cf0JQIsrcf3iFYqBhaKuN53szUuW+073u hlGl+IiQFJKcjaTc7BJ3471pN1CqptVzFz0zzVyibggTmkYsQyLzyRCpx1LJMVGnyYEbAy 6/fIJnKXtmzVmdFykYPTGtaEUdHAWUXW6t+iLkEOQLab9aESqkDo018Ib+YUPREAhhUNZd t6DlArLMsqjWiHgfnP23nuiI6CugDGcOV0hfiB2JSMRswnVYIQtWLtLjSUtrTl30APtoRX E6u9gcLUIEQ6XSY0PtsoDB7UADb2Fx1ga1AffL26sgCRZH6NuWqOvkcZ7FdO0Q== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1786222113; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gj5T1xJcXF8eC6UDI5Yz5y/KObeY+ndxdiI0cjIoZ0c=; b=3/maonhpo2Xy81ooHHXMtBLXYQzazfP1ruC7BQwVTt74ZR815UDWuKKDdjs1OpnGrQvyB9 jelqAip/6hQoo0Cw== From: "tip-bot2 for Lyude Paul" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: locking/core] openrisc: Include in smp.h Cc: Lyude Paul , Boqun Feng , "Peter Zijlstra (Intel)" , Stafford Horne , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20260804161447.84806-5-boqun@kernel.org> References: <20260804161447.84806-5-boqun@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <178622211216.442315.6367771172267384969.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Precedence: bulk Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The following commit has been merged into the locking/core branch of tip: Commit-ID: e35e7700029b936356d736d6378cf596019e4cc8 Gitweb: https://git.kernel.org/tip/e35e7700029b936356d736d6378cf5960= 19e4cc8 Author: Lyude Paul AuthorDate: Tue, 04 Aug 2026 09:14:26 -07:00 Committer: Peter Zijlstra CommitterDate: Sat, 08 Aug 2026 22:44:06 +02:00 openrisc: Include in smp.h While OpenRISC currently doesn't fail to build upstream, it appears that including in the right headers is enough to break that - primarily because OpenRISC's asm/smp.h header doesn't actually provide any definition for struct cpumask. Which means the only reason we aren't failing to build the kernel is because we've been lucky enough that every spot including asm/smp.h already has definitions for struct cpumask pulled in. This became evident when trying to work on a patch series for adding ref-counted interrupt enable/disable to the kernel, where introducing a new interrupt_rc.h header suddenly introduced a build error on OpenRISC: In file included from include/linux/interrupt_rc.h:17, from include/linux/spinlock.h:60, from include/linux/mmzone.h:8, from include/linux/gfp.h:7, from include/linux/mm.h:7, from arch/openrisc/include/asm/pgalloc.h:20, from arch/openrisc/include/asm/io.h:18, from include/linux/io.h:12, from drivers/irqchip/irq-ompic.c:61: arch/openrisc/include/asm/smp.h:21:59: warning: 'struct cpumask' declared inside parameter list will not be visible outside of this definition or declaration 21 | extern void arch_send_call_function_ipi_mask(const struct cpum= ask *mask); | ^~~~= ~~~ arch/openrisc/include/asm/smp.h:23:54: warning: 'struct cpumask' declared inside parameter list will not be visible outside of this definition or declaration 23 | extern void set_smp_cross_call(void (*)(const struct cpumask *= , unsigned int)); | ^~~~~~~ drivers/irqchip/irq-ompic.c: In function 'ompic_of_init': >> drivers/irqchip/irq-ompic.c:191:28: error: passing argument 1 of 'set_smp_cross_call' from incompatible pointer type [-Werror=3Dincompatible-pointer-types] 191 | set_smp_cross_call(ompic_raise_softirq); | ^~~~~~~~~~~~~~~~~~~ | | | void (*)(const struct cpumask *, un= signed int) arch/openrisc/include/asm/smp.h:23:32: note: expected 'void (*)(const struct cpumask *, unsigned int)' but argument is of type 'void (*)(const struct cpumask *, unsigned int)' 23 | extern void set_smp_cross_call(void (*)(const struct cpumask *= , unsigned int)); To fix this, let's take an example from the smp.h headers of other architectures (x86, hexagon, arm64, probably more): just include linux/cpumask.h at the top. Signed-off-by: Lyude Paul Signed-off-by: Boqun Feng Signed-off-by: Peter Zijlstra (Intel) Acked-by: Stafford Horne Link: https://patch.msgid.link/20260804161447.84806-5-boqun@kernel.org --- arch/openrisc/include/asm/smp.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/openrisc/include/asm/smp.h b/arch/openrisc/include/asm/sm= p.h index 007296f..84653aa 100644 --- a/arch/openrisc/include/asm/smp.h +++ b/arch/openrisc/include/asm/smp.h @@ -9,6 +9,8 @@ #ifndef __ASM_OPENRISC_SMP_H #define __ASM_OPENRISC_SMP_H =20 +#include + #include #include =20