From nobody Sat Jul 25 02:43:16 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA2063AD505; Mon, 20 Jul 2026 10:43:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784544227; cv=none; b=dksH+77EYmUQu4FmWFpRx3v8qt/belDK3u1uBtsPAUrE9U1t1EU1Ov6OnDHWFqo0LuVbhUL4u0zKrSy67LiR4hkVAJCrAlkE9Mb9jsBQjlaFHIMiJWjksvSZGm3dgkRHHqz0MQi9vc91NZSKYxgeAptlFRGDn7F1HF0wQLVDI9M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784544227; c=relaxed/simple; bh=2mZXoIzvSAZokoGoDXcnNZuL3xYCxPOTGwEJnRO533o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mqOfbjMj2jDhWSyHs9K7Da4KBBuwAxTa2vtgP6zOppQLzpxife5rXhwa+6OfaXR4yyrSPcb+X7+swt8PC3f7gQ+efxSNCjGkAs/Y0jXkDH9Y7MOMqeV9fSyeGjsK4QeNyRDoDvXUzUYMXwSX45QUYz/PYsZL2PpHAE+HAE+sACM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DJvR+K8N; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DJvR+K8N" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 837EA1F000E9; Mon, 20 Jul 2026 10:43:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784544222; bh=9ThXQ25nS188ePU8Js7Kwou012mg2AJOuu/gKi5oCfc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=DJvR+K8N+t+jY87ADBshiqzfUTMzSe7XvmDtAZa8iCqzRM2cqJVgICtya28xQfIED 2pDQUbqpWXjL9+vm00INBlgoZSKiIEqELjvDam/lwbhY1HIEgdkcG9PMi+WmYTtj7H mLrrwZc+kNz89uIZtYeeaK1QW3mk76VMTrcKx2GS7STCQpgUCBRfo6J0mmyeMhQkqC o3on7iSC9CuXVYdEDWOQA/VlQDjhsdeyBobOXBkK1ktX2qAKkCuw/rQDTuPBoicYiw yHez9bhdhm+C8JQhet3AUAF3I3SoTeS3ZhGwjFrPv/rdKA/B4muwS+N6EjkBOEHaxR P1JVdOtRHC8WQ== From: "Masami Hiramatsu (Google)" To: Steven Rostedt , Masami Hiramatsu Cc: Mathieu Desnoyers , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: [PATCH 01/10] tracing/probes: Remove duplicate MAX_ARRAY_LEN macro definition Date: Mon, 20 Jul 2026 19:43:39 +0900 Message-ID: <178454421926.296567.6649983666070787570.stgit@devnote2> X-Mailer: git-send-email 2.43.0 In-Reply-To: <178454420994.296567.10239174745865301350.stgit@devnote2> References: <178454420994.296567.10239174745865301350.stgit@devnote2> User-Agent: StGit/0.19 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Masami Hiramatsu (Google) MAX_ARRAY_LEN is defined twice in trace_probe.h. Remove the redundant definition. Assisted-by: Antigravity:gemini-3.5-flash Signed-off-by: Masami Hiramatsu (Google) --- kernel/trace/trace_probe.h | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/trace/trace_probe.h b/kernel/trace/trace_probe.h index ebdc706e7cb6..b3571c85abb1 100644 --- a/kernel/trace/trace_probe.h +++ b/kernel/trace/trace_probe.h @@ -220,7 +220,6 @@ DECLARE_BASIC_PRINT_TYPE_FUNC(symbol); _ASSIGN_FETCH_TYPE(#ptype, ptype, ftype, sizeof(ftype), sign, atype) =20 #define ASSIGN_FETCH_TYPE_END {} -#define MAX_ARRAY_LEN 64 =20 #ifdef CONFIG_KPROBE_EVENTS bool trace_kprobe_on_func_entry(struct trace_event_call *call); From nobody Sat Jul 25 02:43:16 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8092B3DBD47; Mon, 20 Jul 2026 10:43:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784544241; cv=none; b=jt32TNabSzppiOnGd1H7XA4zA40VRwoJJ4cVMsygA2Or90buJLkQd+1LOynndahrR4iQmp724QC8UXpGPyaO4IH7jhyR6J0CF/ySyBP5BZ5uBZac8z48wPw/zUJLcP9bqyx8S3J76zU7SMPpzOdxydeF3BmRStlqkg1q2Nzdqa4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784544241; c=relaxed/simple; bh=7iwhT+OMjeqlBnHKCtI3TLdB7erI40oggHs3AYxmGNg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=G8n5rQVL0GEJMQxZ9DJEUD6UNagSjJ/rMTc4AnkT9Ez4uI1pCZqOzASObex25GbhtEPkOjyq67QUt25Vp0pSP95QWXPPYoXg+1Qf5ZTkAj3cMhvgsWHej7uQLaaime7VK/ySmaVxzh4mPfYblYXegM9QkOAIZhpcSLKji0eG2Xs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kWhjOrCE; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kWhjOrCE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CBDDA1F000E9; Mon, 20 Jul 2026 10:43:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784544232; bh=r54JjzfEk9czsuC0MJryDnII5W8oRT9GKoRXZth4XIM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=kWhjOrCEyXZHKrqN1a5C2G/c0EgUL4T1hNiiumxcpdkUKMhNu5fxnfl/rTgS6pZEQ brQsUL99Kx48b6bWhJKLZNkfzoWbRJtr31iPwWh6PJr9fQ+v9iOEQ78EF8GdJeb5V/ o1tFU9c4KllytmYJLUZC1Yf8tbq4t2S4OABjEZsNsuZbmcEt6VZUlXAKPa9V27tite LYBQ6IDBR60LcJ319CLdlbSGa1B9lXdQV+HiL1O1Rwrkvlq6hv4/Vr7y4bCHzH3VTT YCuOYFLqMPq2ifNvNlFicsxsGTt331ljzlPCD3uQ2BWiLasd1tQ1DAUPNCuJ21QQZ6 +wtbOg9qpbzGQ== From: "Masami Hiramatsu (Google)" To: Steven Rostedt , Masami Hiramatsu Cc: Mathieu Desnoyers , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: [PATCH 02/10] tracing/probes: Remove redundant boolean conversion in trace_probe_has_single_file() Date: Mon, 20 Jul 2026 19:43:48 +0900 Message-ID: <178454422826.296567.4382363406595169533.stgit@devnote2> X-Mailer: git-send-email 2.43.0 In-Reply-To: <178454420994.296567.10239174745865301350.stgit@devnote2> References: <178454420994.296567.10239174745865301350.stgit@devnote2> User-Agent: StGit/0.19 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Masami Hiramatsu (Google) list_is_singular() returns a boolean value, so the double negation (!!) in trace_probe_has_single_file() is redundant. Remove it. Assisted-by: Antigravity:gemini-3.5-flash Signed-off-by: Masami Hiramatsu (Google) --- kernel/trace/trace_probe.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace_probe.h b/kernel/trace/trace_probe.h index b3571c85abb1..c0f05763811c 100644 --- a/kernel/trace/trace_probe.h +++ b/kernel/trace/trace_probe.h @@ -360,7 +360,7 @@ static inline int trace_probe_unregister_event_call(str= uct trace_probe *tp) =20 static inline bool trace_probe_has_single_file(struct trace_probe *tp) { - return !!list_is_singular(&tp->event->files); + return list_is_singular(&tp->event->files); } =20 int trace_probe_init(struct trace_probe *tp, const char *event, From nobody Sat Jul 25 02:43:16 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C8723DCDAB; Mon, 20 Jul 2026 10:44:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784544255; cv=none; b=PdzbxaFMdrOva/wh3HoPbJP8+M3zqNpvZlOVT++jNK7TFbmnrDs+I4Cx5GVu2+p2OAoY1FhE8fYeIR50rOllmqZ0CjDUqvr1bkIeSvxUuBK+uNtWN0GdygeZ9G3RMKG/Vz6di1kKetVZjE5sCIjUh1mLdG6XqEMoifzCPlQ23oI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784544255; c=relaxed/simple; bh=1PMfcfVNo+EYFmcwkHRrP8vXKS9gzrg1aqxHd+IOfNw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YyN3MsVMdWDzsvQH0f+cR/PxbLlMiLlwOB0WvEWOd0dXp/22IIOhEaXPLnPxvWBtMUAjE7y49XlpUMdyXhg27yE5Vp/6cq3XPM7W3Er9OTXNQkfjx5nxKPMLQHbg9CZ5Ny0U3IZYTlCr49+1GoWb+iNgsFGDMu/0vmwZGpLz284= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QpO0lpr+; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QpO0lpr+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 257C31F00A3D; Mon, 20 Jul 2026 10:43:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784544241; bh=yaNa94Ge2NX6/wJoRd+5oweC6fVIPAVHk59DVlRbaaM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=QpO0lpr+5hEYYTdCvTGl6RF46SlEQN+Mm5ZIDGAW9I8y94wYlfFOOPGL9cfcqI7JP eiIQsgRf32RlmexGVjuwNQrGhJsswkgShuBNjlCUn03Ddi/UCr7H36zscKaQdQ86yS AgGFaJ2L4zo/VD6OLkv/PLvmMSC+KJwOkI6rKWg9sC3ruCwt2y+YuC4pWNmlWY4zND A3attoZkqWKuuze1snZj7Ux7Y1RulE7Kt1Sm8xA47Vd9khOTuawzpDvLMzCx2FvcCa 3N7Sp0nB+ItHyPAhmJmHQonmnSJqaQsuC4fsjwLG2aZgdR98UHf22j71hFozPvNnyv kJGw21SDC18Rg== From: "Masami Hiramatsu (Google)" To: Steven Rostedt , Masami Hiramatsu Cc: Mathieu Desnoyers , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: [PATCH 03/10] tracing/probes: Remove redundant bounds check in trace_probe_compare_arg_type() Date: Mon, 20 Jul 2026 19:43:57 +0900 Message-ID: <178454423769.296567.6694636865644203423.stgit@devnote2> X-Mailer: git-send-email 2.43.0 In-Reply-To: <178454420994.296567.10239174745865301350.stgit@devnote2> References: <178454420994.296567.10239174745865301350.stgit@devnote2> User-Agent: StGit/0.19 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Masami Hiramatsu (Google) In trace_probe_compare_arg_type(), prior to entering the comparison loop, a->nr_args and b->nr_args are checked for equality. Since the loop condition is i < a->nr_args, i is guaranteed to be less than b->nr_args inside the loop. Remove the redundant (b->nr_args <=3D i) check. Assisted-by: Antigravity:gemini-3.5-flash Signed-off-by: Masami Hiramatsu (Google) --- kernel/trace/trace_probe.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c index 7568f5e68de7..91ba4490937b 100644 --- a/kernel/trace/trace_probe.c +++ b/kernel/trace/trace_probe.c @@ -2770,10 +2770,9 @@ int trace_probe_compare_arg_type(struct trace_probe = *a, struct trace_probe *b) return b->nr_args + 1; =20 for (i =3D 0; i < a->nr_args; i++) { - if ((b->nr_args <=3D i) || - ((a->args[i].type !=3D b->args[i].type) || - (a->args[i].count !=3D b->args[i].count) || - strcmp(a->args[i].name, b->args[i].name))) + if ((a->args[i].type !=3D b->args[i].type) || + (a->args[i].count !=3D b->args[i].count) || + strcmp(a->args[i].name, b->args[i].name)) return i + 1; } From nobody Sat Jul 25 02:43:16 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B074D3D9690; Mon, 20 Jul 2026 10:44:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784544264; cv=none; b=U7n2BJkXr1p4S6Y27f3CDDDN8YM2nbta8ZqjJbYHoaLEbRb3QyjBL8JKWqdDG/iGM/qtb0tYLXWzO/MTGMO4Chswo6yx6G3WLavJV5q4XwLSt6CJ93w6J1LmE0DGCo5gRQ4Rm7CisDNNfONYAhSL8b5hep+p00o/QMIIhQjI1ZI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784544264; c=relaxed/simple; bh=FNRVNPmNaEWmQEPDDA6nagdSq3O+d53haEr4O3hDXLw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cYyxOp5eGYN9qn479ylE5QCgDY/Znc9oBVSzZpRZNma74s71QbpqONEZ3H4QOSvFe7vbCfOR4S0PobVL9f+HrcHkrQBNNUnaXaiilovdmukHCMvwJ9LA2gXpbAR0jyhjatgzHUTX6DNoXpeZqAGSigHFBTyCWB37LgXdZzfKbVU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fT2LB3Xc; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fT2LB3Xc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6EBBB1F000E9; Mon, 20 Jul 2026 10:44:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784544250; bh=qtEKS4+ecMMcLw2egjWiwbg3Kco0HW+YqEdNdM0Zzi8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=fT2LB3XcvXNM39+8/BvAxmYakMa727QslYk61LeuTGgswCc8dkXPEAf4YvuhxyvXz jFoOV1IoXvXS669RAAHWJFdvNJy94O+YEpSl/3mbG+2OFKOojQWZuuN6IenDDO3gxV G2DzB6g/hikNpm7UR7BzMMWv9itU9Js6gE7lU6fLTYegD7GrohRXmI3E7r34Vo4oi0 mka4CWA7aa7xz7Qme48SsrPpP0Lq/ep4DwBq3aNJcOxzspjBUlHm7purRIqBJYkfhC fvk3FTbcihBk3tJOcgU06xI+ZedMKVN3nnvcZ0oKn31kWScOQ2M16YsK0dRjxqTXqt BzZBB/j+FG2Qw== From: "Masami Hiramatsu (Google)" To: Steven Rostedt , Masami Hiramatsu Cc: Mathieu Desnoyers , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: [PATCH 04/10] tracing/probes: Remove unused parameter from parse_probe_var_retval() Date: Mon, 20 Jul 2026 19:44:07 +0900 Message-ID: <178454424711.296567.15352344258939682112.stgit@devnote2> X-Mailer: git-send-email 2.43.0 In-Reply-To: <178454420994.296567.10239174745865301350.stgit@devnote2> References: <178454420994.296567.10239174745865301350.stgit@devnote2> User-Agent: StGit/0.19 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Masami Hiramatsu (Google) The parameter 'arg' in parse_probe_var_retval() is unused. Remove it and update its caller accordingly. Assisted-by: Antigravity:gemini-3.5-flash Signed-off-by: Masami Hiramatsu (Google) --- kernel/trace/trace_probe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c index 91ba4490937b..eb7be3725e85 100644 --- a/kernel/trace/trace_probe.c +++ b/kernel/trace/trace_probe.c @@ -1262,7 +1262,7 @@ NOKPROBE_SYMBOL(store_trace_entry_data) =20 #define PARAM_MAX_STACK (THREAD_SIZE / sizeof(unsigned long)) =20 -static int parse_probe_var_retval(char *orig_arg, char *arg, +static int parse_probe_var_retval(char *orig_arg, struct fetch_insn **pcode, struct fetch_insn *end, struct traceprobe_parse_context *ctx) @@ -1415,7 +1415,7 @@ static int parse_probe_vars(char *orig_arg, const str= uct fetch_type *t, goto inval; =20 if (str_has_prefix(arg, "retval")) - return parse_probe_var_retval(orig_arg, arg, pcode, end, ctx); + return parse_probe_var_retval(orig_arg, pcode, end, ctx); =20 len =3D str_has_prefix(arg, "stack"); if (len) From nobody Sat Jul 25 02:43:16 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C92603DD51F; Mon, 20 Jul 2026 10:44:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784544269; cv=none; b=p1yFCvmVtPZ0LNxyx1CK0hI4AGWzius1B8ni4heWEokbZRbfVmQmYI45WKJ8V3QWSYDNN2NU1V/5n/IS3kIexV3GyDLrVoaZG5t+EuP5JY0IxzfNYk+RFuJ1HMu4XA3KNTl5HsXBfdOhnAyNwgmnV1uMTiWgXALmrvr92X8LmLs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784544269; c=relaxed/simple; bh=y7erpFLEoigXGEjDGYSA5IoLhQSJjlvvgwFFcRRwNd8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=f502d9evcWwWw0dZ4r8EAzLL1C7tD1Knk72KBRfKohTtSZ1GZC9A5ELETfscf59ewrMU44dL+wFVilLapXUi9YI5RYf/W6bwMgSal4afHzTR9y1MY2GcLuZ/AOhVoRYRn2xFo/8qqz+VUeBlDIfLkiJCWMga5Wu+1NXrwAG+Mss= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mx1vKqSv; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mx1vKqSv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A817D1F00A3A; Mon, 20 Jul 2026 10:44:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784544260; bh=MduZI2Ivb5+yMttRcwHzJDmifVQ4du5CTOPuXPV95RA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=mx1vKqSvpS218k4P+slszmAHyBNfMeJCFPNTjvcBr77y+dEysRCoK/Q5LXPIWR3Os 03+tfClgnDVSn79Fkuq3Sud7+SS1OREWPL+UGWgtloJJpHvqg2iNdtH5jOfGuJshiZ 4JGQN8TyPmTSAuvmrOCGSmO9s88Vq+B6/4BSuflrLGGDokLiZjgFVWg8BD0Lsgfzeh 0IddZ6fP00rinqqzCOxbdQma5kHkHrqw0fzvlRP+XpNmWOzyu3Uz5Od7ZleYaN6bnZ HAljP9Sd9MPs7W9gBHQjvVNRIuZ/iMlDMK8smu35KWsxl7bjSfDt0X8WdDsUZEVBRN WYUxkQP567Kjw== From: "Masami Hiramatsu (Google)" To: Steven Rostedt , Masami Hiramatsu Cc: Mathieu Desnoyers , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: [PATCH 05/10] tracing/probes: Cleanup pointer arithmetic in store_trace_entry_data() Date: Mon, 20 Jul 2026 19:44:16 +0900 Message-ID: <178454425622.296567.16952341966130280432.stgit@devnote2> X-Mailer: git-send-email 2.43.0 In-Reply-To: <178454420994.296567.10239174745865301350.stgit@devnote2> References: <178454420994.296567.10239174745865301350.stgit@devnote2> User-Agent: StGit/0.19 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Masami Hiramatsu (Google) In store_trace_entry_data(), edata is cast to unsigned long for pointer offset arithmetic before being cast back to unsigned long *. Cast edata to u8 * instead. Assisted-by: Antigravity:gemini-3.5-flash Signed-off-by: Masami Hiramatsu (Google) --- kernel/trace/trace_probe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c index eb7be3725e85..4899aa5f9230 100644 --- a/kernel/trace/trace_probe.c +++ b/kernel/trace/trace_probe.c @@ -1246,7 +1246,7 @@ void store_trace_entry_data(void *edata, struct trace= _probe *tp, struct pt_regs val =3D regs_get_kernel_argument(regs, code->param); break; case FETCH_OP_ST_EDATA: - *(unsigned long *)((unsigned long)edata + code->offset) =3D val; + *(unsigned long *)((u8 *)edata + code->offset) =3D val; break; case FETCH_OP_END: goto end; From nobody Sat Jul 25 02:43:16 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA4E53DEACC; Mon, 20 Jul 2026 10:44:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784544279; cv=none; b=fQIJZH/PkFLZTg21SGMHHXsZxw676n4OiU4XoLrkocaoALzn9JuscdopcXw0iLa8LXC1gvjSJeJEXySTlFRxFA4lXkjbBxMgSOFw5yJJpLHJgI4X9hEouxI+OJM1YiYFFBZXYpy0waCQ4XDDznaORFs/CrIZGrrOp5/9hHyb1Yo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784544279; c=relaxed/simple; bh=g+H17M+iXGwuA0QGd0Qlc2BtwRVhN2ItpW9d0MLu8fs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=SjadmI4UrFL7TIRgRYFmaTgAJHHbGVlNpO0TowK/Edr8BFsK19FF8g7PSnrKInkrPfJqgpTfy4JNM45egG3fcv1Ygl4hYOEqilSulz1lWEeSaeqRK+eAfOWQDkyMFxmnGjYxpQAIDVUyZCqM8ayNFXS49c4l9K54huHffjFN830= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VlAql9h/; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VlAql9h/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5D391F000E9; Mon, 20 Jul 2026 10:44:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784544269; bh=6d3WXTHTastn4to/Cmx8QUQto+Rl7lHpOtUy0Yr0XcU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=VlAql9h/o9tF3CKUqqZToW+48SBTQy1s6LStmmV1VaulL8Em0MzYUTULR4GtQsXB+ CYY2znKnbPEcp6+GX32sxSK43q0FgtjiRUB1Tlwu9lWMh0hhQjxoH4TCft23kcBOsX vkTL85yLdTWB1swxn98X7L2pYhsRhkDo/00n+aHp0TFVeRXILxUYr7K+C5AXfHDHuP wwvkWT5GScxSeFnfopqBjhbOxy28DV6bL5ebP11LZ65f6aGiLqxlgCwEXbZuBtGuNK XhiR/e3JYsm3/mWCML0Lmb6IfPBun+GiX+Jkv2lAB6Y801f2PdhGgOnL8sLOsNpzGf 3yS4m5GJJyx2A== From: "Masami Hiramatsu (Google)" To: Steven Rostedt , Masami Hiramatsu Cc: Mathieu Desnoyers , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: [PATCH 06/10] tracing/probes: Simplify BTF_KIND_PTR case in fetch_type_from_btf_type() Date: Mon, 20 Jul 2026 19:44:25 +0900 Message-ID: <178454426554.296567.17700307233923830044.stgit@devnote2> X-Mailer: git-send-email 2.43.0 In-Reply-To: <178454420994.296567.10239174745865301350.stgit@devnote2> References: <178454420994.296567.10239174745865301350.stgit@devnote2> User-Agent: StGit/0.19 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Masami Hiramatsu (Google) Use a ternary operator for checking IS_ENABLED(CONFIG_64BIT) in the BTF_KIND_PTR case of fetch_type_from_btf_type() to simplify the code. Assisted-by: Antigravity:gemini-3.5-flash Signed-off-by: Masami Hiramatsu (Google) --- kernel/trace/trace_probe.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c index 4899aa5f9230..fc62d09ea535 100644 --- a/kernel/trace/trace_probe.c +++ b/kernel/trace/trace_probe.c @@ -495,10 +495,7 @@ static const char *fetch_type_from_btf_type(struct btf= *btf, return "s64"; case BTF_KIND_PTR: /* pointer will be converted to "x??" */ - if (IS_ENABLED(CONFIG_64BIT)) - return "x64"; - else - return "x32"; + return IS_ENABLED(CONFIG_64BIT) ? "x64" : "x32"; case BTF_KIND_INT: intdata =3D btf_type_int(type); if (BTF_INT_ENCODING(intdata) & BTF_INT_SIGNED) { From nobody Sat Jul 25 02:43:16 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A88803DEAC0; Mon, 20 Jul 2026 10:44:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784544287; cv=none; b=Kr+UEoSsPxPCnYLV7RYzafrUYelS+SkHX5C0sCgnbwVEnP//GobnEGAL2nxx4j5n4wKIBOxYKwaS6LXzgAdK8fRZmRN/jguoxJVP6J0WDZSWTulFcUT0rUv04+cvP6w/G0zLe6IgBrbiz0mn9j+QMRepUBV4vlW5Gw2Fp8v5K14= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784544287; c=relaxed/simple; bh=aA+R0IiYHA0OfmjHLL3+6BUYT0Y/6KxI8s9ffIHr1bw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=RhLizv2Nj0JsJuV1Ecl0NkkdZLtEjVDFdXxkBCUZwJVLEBjyYH+hNLqAVn+mS87Y73qhzgZAVDU+2kH25rzmAvHWJVhJXnx+pjuNDkNmKYRDN7SYvSYcwKWHzWzBKQHz0LO8tLpiICNk4oUFun0YKVycQKF7/3MaUhl+WmtVG7E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=H3OZ8/x8; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="H3OZ8/x8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C67FF1F00A3A; Mon, 20 Jul 2026 10:44:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784544278; bh=iopxLIu1LWBuR4o+YVogozwucUAvF1mqRMs64bfaww8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=H3OZ8/x8NCYEv4s6gBtJ8PWYV0XWE+byoz+Zk0hjD7bJRmJo4XPVHKYVF7zC2JGt2 fYK5/UMRmhwO/xbWGUZD9RUwkOzpR07G+SFJvjNXZRRFzpzUuw7TkgeKPj8CdqD6wc IqMLCKx8mxD+4P3oOdkeZ1EjBr6AHkBhYNLqEWxXrPhLgG5q8oHR+xqS5mHq5SM60f VG5fmugsydGbOJvBvNYpk7hVoKvG6IHs8NRs199CBzyzRSRbQAID9mT+QB+qgZmRIl C7AyWZeZ4kVQAGK018N5txmA7HpYBEkNeHN25ZPztIu3jkoYrLJvxaaw+e9igRwbIB elw/ilM88vJug== From: "Masami Hiramatsu (Google)" To: Steven Rostedt , Masami Hiramatsu Cc: Mathieu Desnoyers , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: [PATCH 07/10] tracing/fprobe: Remove redundant snprintf in trace_fprobe_match_command_head() Date: Mon, 20 Jul 2026 19:44:34 +0900 Message-ID: <178454427449.296567.12336315661120939938.stgit@devnote2> X-Mailer: git-send-email 2.43.0 In-Reply-To: <178454420994.296567.10239174745865301350.stgit@devnote2> References: <178454420994.296567.10239174745865301350.stgit@devnote2> User-Agent: StGit/0.19 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Masami Hiramatsu (Google) trace_fprobe_match_command_head() copies trace_fprobe_symbol(tf) into a local buffer 'buf' of size MAX_COMMON_HEAD_LEN + 1 using snprintf before comparing with argv[0]. Since trace_fprobe_symbol(tf) already returns a null-terminated string, comparing it directly with argv[0] via strcmp() avoids stack buffer usage and potential symbol truncation at MAX_COMMON_HEAD_LEN. Assisted-by: Antigravity:gemini-3.5-flash Signed-off-by: Masami Hiramatsu (Google) --- kernel/trace/trace_fprobe.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/kernel/trace/trace_fprobe.c b/kernel/trace/trace_fprobe.c index 5638a90e61cc..566b64853c61 100644 --- a/kernel/trace/trace_fprobe.c +++ b/kernel/trace/trace_fprobe.c @@ -238,13 +238,10 @@ static bool trace_fprobe_is_busy(struct dyn_event *ev) static bool trace_fprobe_match_command_head(struct trace_fprobe *tf, int argc, const char **argv) { - char buf[MAX_COMMON_HEAD_LEN + 1]; - if (!argc) return true; =20 - snprintf(buf, sizeof(buf), "%s", trace_fprobe_symbol(tf)); - if (strcmp(buf, argv[0])) + if (strcmp(trace_fprobe_symbol(tf), argv[0])) return false; argc--; argv++; From nobody Sat Jul 25 02:43:16 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15BB13DDB06; Mon, 20 Jul 2026 10:44:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784544298; cv=none; b=maKnZoooQtU39ktwEBIx9D2cWruOy7/Igb7ShdhViBxvno/e2oNEU7uJfUYZdQHP7ONcicZumeb/gUda5iOXPV4qcvq6Mc1/k1skP+qxpFdIDUfCMLNOv6X14eYm10Kasq+Dy2/+lSsJx0OXcSmFzBb7u3dCbr6bn3uD+ggshcE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784544298; c=relaxed/simple; bh=LV9wZknICYkghG3A0yONr15qtMDlN6ma0+U1qsIUhgc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=owL7qqqEZfE91L4PlO+mAZK2uWEbFutw5+WiFdZnoGwFURLwl5pxNx1QoGSLYHZ6B4hKDGK308zT2XlVyO168Kqs/EK61Ogd8uvZ9v/R7Ouq8YdVlO7VCIB5HqImNdYcEOkDHDGKglqj8IxXd8RXCFZdJS9Ih4udQAQRjpvKXaY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=m/DUTWTI; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="m/DUTWTI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 394331F000E9; Mon, 20 Jul 2026 10:44:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784544287; bh=OJfwycJ/7ClTOzd4xktAKZT6GOwq9Yrwaydn1j9pmP8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=m/DUTWTIZ2r7ZmXu9tRnxLTfRlt6NzULQdOJQfZSqxOJNGbyFmM9UM+PejrLdadhA GfJKLU+PjZ47i7pIFtsBALoxlNUSqst5B1Bt5d1blprZlc9TStgHElIQXBDkd/SYt4 vGUR3SfsHuGKIwFCVcUuUlf5/ZeStWiORpiacK/xD2bFk17LtT3X1m9mOfX9oL5zUH c0tnr+FTZMORQ4YSm+M2T6d3VdnPvYInAUsPDfa1XwNR9rVxDXz96yMz9BpscgboKd m5LSykT9GbW4AUzKCLhcycpDluacbm8iMbrsQcu3SrbTrB+lcFuQ84WLfCDyvCjkZI HqNIxG6DY6hyw== From: "Masami Hiramatsu (Google)" To: Steven Rostedt , Masami Hiramatsu Cc: Mathieu Desnoyers , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: [PATCH 08/10] tracing/fprobe: Remove redundant memset in fentry_perf_func() Date: Mon, 20 Jul 2026 19:44:43 +0900 Message-ID: <178454428366.296567.16465331441301815980.stgit@devnote2> X-Mailer: git-send-email 2.43.0 In-Reply-To: <178454420994.296567.10239174745865301350.stgit@devnote2> References: <178454420994.296567.10239174745865301350.stgit@devnote2> User-Agent: StGit/0.19 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Masami Hiramatsu (Google) fentry_perf_func() calls memset(&entry[1], 0, dsize) prior to calling store_trace_args(). store_trace_args() populates the entry buffer and handles dynamic data fields. Furthermore, passing dsize (the dynamic data byte length) to memset at &entry[1] (the start of fixed trace arguments) is inaccurate as it zeroes from the fixed args area rather than the dynamic data region. Remove this redundant memset call to align with fexit_perf_func() and other probe perf functions. Assisted-by: Antigravity:gemini-3.5-flash Signed-off-by: Masami Hiramatsu (Google) --- kernel/trace/trace_fprobe.c | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/trace/trace_fprobe.c b/kernel/trace/trace_fprobe.c index 566b64853c61..ec9105fca4a6 100644 --- a/kernel/trace/trace_fprobe.c +++ b/kernel/trace/trace_fprobe.c @@ -471,7 +471,6 @@ static int fentry_perf_func(struct trace_fprobe *tf, un= signed long entry_ip, regs =3D ftrace_fill_perf_regs(fregs, regs); =20 entry->ip =3D entry_ip; - memset(&entry[1], 0, dsize); store_trace_args(&entry[1], &tf->tp, fregs, NULL, sizeof(*entry), dsize); perf_trace_buf_submit(entry, size, rctx, call->event.type, 1, regs, head, NULL); From nobody Sat Jul 25 02:43:16 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F384D3DD875; Mon, 20 Jul 2026 10:45:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784544307; cv=none; b=bfHNfO0RDl27Er2LXOSnAR11Hs+Z7wMRuHn6pfFy2AKjcMEz8q1hHXrCZTVvPIveoEvcRuPXSZR3ObH5fG65YwqiSywT6tv3OSmmkO8dx1IvNP9ZyvcAYkS/S7xgabuot1nms2a8HdT3NZAQyVsHG2D+GaDdgUH1IC+0Rvi4Gdk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784544307; c=relaxed/simple; bh=Scya5jTzoMHfqY9tcNDtgk5ta4MhElG464vtFe/Wp/s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=IxXg4OG38seKBV1Tg25Lgga58785XMKDeYG4UnQ+QbnXZSgxl/dWAIeXS0f9np8AzbDT2vZ/rc/prvpspxxFQG9x+aCl3CuVJ0ycaqCXK1Zy6KFYw8gLlnBqw3CWIJCUuOZWJ20mrLgEdBksMGgPg5PADnR9o3I5h2zCX+ZGsg0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dpb0YfI3; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dpb0YfI3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85D351F00A3A; Mon, 20 Jul 2026 10:44:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784544297; bh=aT6chHk/hvlofAsrR1SryBN8/uGxNuXdVvRWxO6TYBE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=dpb0YfI3Oj9SuDk0PAH59c0mGHB43yj51WD7ZpDFbkksSLxjCgZiZHcR9NQZpJjjD yagfukj9xs/U/7Tgj6DjzGCck8cjMKT6A+QuDnqUIPHrMXuK4D5tAmNaqK/4mXc6Im sSB2SnrSKJli48GqF3CcMu12HKunJP3t/wczkqbNDPHOj5lJP0kR58yLqiAYI+e0FC 6J87EUM9bsuKCElfC7TAXZ9bv23DMI5oyarWZNiSlA0bIgqg02uSA3rkZIY/REbV0S 8m4LYei1xbI5enM4Ml/gWZYiAHykJRrQsz3gNnzy8Sfkoe4OTEdS5rJXPrMQ9gpn0I ljwTOg64CTTuA== From: "Masami Hiramatsu (Google)" To: Steven Rostedt , Masami Hiramatsu Cc: Mathieu Desnoyers , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: [PATCH 09/10] tracing/kprobe: Remove redundant memset in kprobe_perf_func() Date: Mon, 20 Jul 2026 19:44:53 +0900 Message-ID: <178454429309.296567.17379087988750549247.stgit@devnote2> X-Mailer: git-send-email 2.43.0 In-Reply-To: <178454420994.296567.10239174745865301350.stgit@devnote2> References: <178454420994.296567.10239174745865301350.stgit@devnote2> User-Agent: StGit/0.19 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Masami Hiramatsu (Google) kprobe_perf_func() calls memset(&entry[1], 0, dsize) prior to calling store_trace_args(). store_trace_args() populates the entry buffer and handles dynamic data fields. Remove this redundant memset call to align with kretprobe_perf_func() and other probe perf functions. Assisted-by: Antigravity:gemini-3.5-flash Signed-off-by: Masami Hiramatsu (Google) --- kernel/trace/trace_kprobe.c | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c index cc24e992732c..c25f902aa1a6 100644 --- a/kernel/trace/trace_kprobe.c +++ b/kernel/trace/trace_kprobe.c @@ -1721,7 +1721,6 @@ kprobe_perf_func(struct trace_kprobe *tk, struct pt_r= egs *regs) return 0; =20 entry->ip =3D (unsigned long)tk->rp.kp.addr; - memset(&entry[1], 0, dsize); store_trace_args(&entry[1], &tk->tp, regs, NULL, sizeof(*entry), dsize); perf_trace_buf_submit(entry, size, rctx, call->event.type, 1, regs, head, NULL); From nobody Sat Jul 25 02:43:16 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 773212FD68B; Mon, 20 Jul 2026 10:45:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784544320; cv=none; b=BBhTSedzKgzg1fGm9Zpsocn2L9/bgPoy/Jr5j8IqZfv2O3IYTxO5Y7XH8a6oAaMN6uizwxhRuZmnREep/OJ8xiepfNgjLPu6LoJNixfuFZYqkzH9+E2jqq1/9FzvJbfoh0dEZCbwlD386fx7vR/QE1NWeQo1LNwnfRk5XTd/gJ4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784544320; c=relaxed/simple; bh=cjxSwuLlduv7vNavamNRS5b1a5l14ctDnJVO5czszNQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Cm0mR84yRRAudi7BF+oqcOGtG+8QvnH7HwHNPr31UkRT/69BHpCvHkMpNwsbcKtT+d6G+NMkRDxF8MXmFr4uPqaZ5lmuibyLfD78hSJWpNR1ugWy4dStWTEEzQUblDOIYBWeD77VqUf6oUnb5E4VWFSL3esS/ds+7DlFZX/blx8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Zan1DjI0; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Zan1DjI0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED9D61F00A3E; Mon, 20 Jul 2026 10:45:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784544306; bh=5EiU38AUN9ixRY5i2B6B8FAhm2x98CYweIuaUwwxgDM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Zan1DjI0QZUdBwwehMOndd7rRWqkuhPiB80pEyDpB4WYsKiMoYO4FonyGxKLEvLd4 Sjw1wz46B+vB0wdvxEvR1hq7IJJLTH9bb6pojCTiq/baltYWy5zbyWcYAav0oxfn6o bxUrcr0RloqrfaZZL9oDOwJi0ZjBvXS7FOAsBQoQsODPBsiq8hsLY+ic8kZWfRDVI3 dfbuUd8I3+BZFsbKbR38Atc1ZLFPyDC/fMO+PTgpd71ZQZHitcO5rTXc31jc7C/c27 1qYoOyfIpypT1ZQDWw62MosJiIvkXXSBT6I8I8/CT+phlAsKhaVjur8e9YB/iU37nI l25taxK5JeYbA== From: "Masami Hiramatsu (Google)" To: Steven Rostedt , Masami Hiramatsu Cc: Mathieu Desnoyers , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: [PATCH 10/10] tracing/probes: Fix extra whitespace in trace_probe_kernel.h Date: Mon, 20 Jul 2026 19:45:02 +0900 Message-ID: <178454430235.296567.9486503882045148585.stgit@devnote2> X-Mailer: git-send-email 2.43.0 In-Reply-To: <178454420994.296567.10239174745865301350.stgit@devnote2> References: <178454420994.296567.10239174745865301350.stgit@devnote2> User-Agent: StGit/0.19 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Masami Hiramatsu (Google) Clean up extra space after '=3D' in fetch_store_strlen_user(). Assisted-by: Antigravity:gemini-3.5-flash Signed-off-by: Masami Hiramatsu (Google) --- kernel/trace/trace_probe_kernel.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace_probe_kernel.h b/kernel/trace/trace_probe_k= ernel.h index bb723eefd7b7..4eb4acfa09ba 100644 --- a/kernel/trace/trace_probe_kernel.h +++ b/kernel/trace/trace_probe_kernel.h @@ -12,7 +12,7 @@ static nokprobe_inline int fetch_store_strlen_user(unsigned long addr) { - const void __user *uaddr =3D (__force const void __user *)addr; + const void __user *uaddr =3D (__force const void __user *)addr; =20 return strnlen_user_nofault(uaddr, MAX_STRING_SIZE); }