From nobody Mon Jun 8 12:14:07 2026 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B6BF3C585B; Fri, 29 May 2026 10:45:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780051545; cv=none; b=FKukC8CiIpJpxR0XP88n+RkaUNtRm2rkz77v+O+/xEHFD/nfJt1QQpaxgDxuSdD/a9jCxzb7K9S1BY5v/Y6EAiy+QoC3aqjz5bBjb2QZZ6SigM6kygK00/RT30jLgKOxCj6q8pmcUxSOgUQMivFMZ9YZBnUgS9yQJ9fPvGbAogw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780051545; c=relaxed/simple; bh=+mCGQt0ltIY9yoICt+g6Y+w4fS4PjeOlLjxjYXFGIM8=; h=Date:From:To:Subject:Cc:In-Reply-To:References:MIME-Version: Message-ID:Content-Type; b=rqGZMH91dTR/PQ9nBGNcyRA8J/z9H81fROEf6g2+zTrsktIEI+K/iMUu4aX0lPmnf527t2DOnmmJShIrnYG+bm1eFlRCQhmHU5xzg0Ybapg2WpylAEzoeDYcCRJDxeGwXqxcv51s8ybptELEHqMCJVfkKE0fZgME7lFg3bVD5uA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=yFtdstVg; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=MnplsbEP; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="yFtdstVg"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="MnplsbEP" Date: Fri, 29 May 2026 10:45:41 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1780051542; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8YDHLoqHlwo2GEAVPMF0bfURSufJXugvgj7/zTWu5Go=; b=yFtdstVgkNoOFMsfER8a1hDn+YLV8dznjC7YXLmzMtwTCyqacBhFAQWIR4j+37uq/UnRU0 6nODdJ9K4HjIFIJvSbVkHPsARO+N0Wl8wwbf+VCpumtbwMoYz/H0xbWbJA332fgy9D4L3f Z8w1eHiqUmHUauvD1gsIw4lVuy6HS7/YyPbydj+4IjfR1YTgbhHnoBEHarj3SSobPEK54M 4CgeKGaE1OO6DCHRZsjqCLYYDjpvt3YUAisoYyFjxMthdmESC+WTQZj8674VHSnzLS8fuD DtMvDRR5SY3WJ3rzoc0ryjUXlMo1dDQHaXN0JzQggEVHJCCxZQOZMVX3bhWP5g== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1780051542; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8YDHLoqHlwo2GEAVPMF0bfURSufJXugvgj7/zTWu5Go=; b=MnplsbEPJp60xTdqNFyDEMnXFZIf4gBes33LFlqDq5xvp4H0RJpv2X97Q2Js0arfSLZqEI +wJvk5w5Qs+5yDAg== From: "tip-bot2 for Andrea Righi" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: sched/core] sched/deadline: Reject debugfs dl_server writes for offline CPUs Cc: Sashiko , Andrea Righi , "Peter Zijlstra (Intel)" , Juri Lelli , "abaci-kreproducer" , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20260526100502.575774-1-arighi@nvidia.com> References: <20260526100502.575774-1-arighi@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <178005154144.1039918.11043401184924357057.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Precedence: bulk Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The following commit has been merged into the sched/core branch of tip: Commit-ID: 4043f549841619a01999bf5d4e0b7931ef87f6cc Gitweb: https://git.kernel.org/tip/4043f549841619a01999bf5d4e0b7931e= f87f6cc Author: Andrea Righi AuthorDate: Tue, 26 May 2026 12:05:02 +02:00 Committer: Peter Zijlstra CommitterDate: Fri, 29 May 2026 12:43:15 +02:00 sched/deadline: Reject debugfs dl_server writes for offline CPUs Writing runtime or period via the per-CPU dl_server debugfs files (/sys/kernel/debug/sched/{fair,ext}_server/cpu*/{runtime,period}) on an offline CPU can trigger two distinct kernel issues: 1) Divide-by-zero in dl_server_apply_params(): Oops: divide error: 0000 [#1] SMP NOPTI RIP: 0010:dl_server_apply_params+0x239/0x3a0 Call Trace: sched_server_write_common.isra.0+0x21a/0x3c0 full_proxy_write+0x78/0xd0 vfs_write+0xe7/0x6e0 Both __dl_sub() and __dl_add() divide by cpus internally, which can be 0 once the CPU has been removed from any active root-domain span (this has been latent since the debugfs interface was introduced). 2) WARN_ON_ONCE in dl_server_start(): WARNING: kernel/sched/deadline.c:1805 at dl_server_start+0x232/0x270 Commit ee6e44dfe6e5 ("sched/deadline: Stop dl_server before CPU goes offline") added this check to catch enqueueing the server on an offline rq. There's no meaningful semantics for re-configuring the per-CPU dl_server bandwidth while the CPU is offline, so simply reject the write with -EBUSY so userspace gets a clear error. Closes: https://lore.kernel.org/all/20260526092228.3B6891F00A3A@smtp.kernel= .org/ Fixes: d741f297bcea ("sched/fair: Fair server interface") Reported-by: Sashiko Signed-off-by: Andrea Righi Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Juri Lelli Tested-by: abaci-kreproducer Link: https://patch.msgid.link/20260526100502.575774-1-arighi@nvidia.com --- kernel/sched/debug.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c index 4809e1d..5e09cf9 100644 --- a/kernel/sched/debug.c +++ b/kernel/sched/debug.c @@ -416,6 +416,9 @@ static ssize_t sched_server_write_common(struct file *f= ilp, const char __user *u return -EINVAL; } =20 + if (!cpu_online(cpu_of(rq))) + return -EBUSY; + update_rq_clock(rq); dl_server_stop(dl_se); retval =3D dl_server_apply_params(dl_se, runtime, period, 0);