From nobody Mon May 25 05:54:13 2026 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C50F92ECE91 for ; Mon, 18 May 2026 08:04:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779091489; cv=none; b=NZgFiMj5qoupjNlDVg7p9uSx+qXxfF00dCb0+feaipjWz5fbZ4tzhvDYpSf4qoYPEnigdruun9sFT9fR35lRF13KFMWUxsWBJPPYJegAymKP6uUjDt70WkwU0ZpTO2h3zvPJQIbFKPMLciYri/14JUmhGisD1MQHjo3045AW4DE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779091489; c=relaxed/simple; bh=PXunouNx6flJMIUdlDcTZ0lwTbT8RlEKBbd+k+PsnHc=; h=From:To:Cc:Date:Message-ID:Subject:Content-Type:MIME-Version; b=cPDHMJ+w+0co2sRrtPXmZz1hqxW+6ctE2/QK4APVwyNOMRkBR3QU1SDzKAgYviY1CW8pKJ8DkI3/BuLmjgH/bXI5LCGDS9s7668lGUr97THB//xNFJaBD0vNOBDahH8YYRvr59ewNToAqkZxagZ6Khq7p5XFHTQFxqh5E7bVJnU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sdfC93A2; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sdfC93A2" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-c82471904fcso718044a12.2 for ; Mon, 18 May 2026 01:04:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779091487; x=1779696287; darn=vger.kernel.org; h=mime-version:content-transfer-encoding:subject:message-id:date:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=HFnv5RAtZZqCB/DQ5TMyFrf4XXbpu5FQe7786lTdjlI=; b=sdfC93A2kCOm2tiXuzDYwfD2QLjxKP0+EEnsS/b2aQQ1JudY5df4SsVS6WwW0e+BK0 m54JNgmHovAoa2mqtMEObwbyp6RM4TQBGxV3AxG9C2HTvFvHNVnRUrS5gAAvSAJ1RRff a2urR+N9SF6LtklOoNqNcMehCkjM8PVxT91DoVXiU2QfwIRp3oyGm26YdxfMYyNpPjv5 XFsLjRWvvEO7k89V0zB1WUTB14nIw79HhbDwu6oJLBvT8CgTayRL/mYydutbFKNC1Qgf CEZYVHTxqyuzEUcUeqKmRn89f8pTgMhT54rRu/s0RXxEW+T3+TnxJvBArqyjrOWHhsPB blNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779091487; x=1779696287; h=mime-version:content-transfer-encoding:subject:message-id:date:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HFnv5RAtZZqCB/DQ5TMyFrf4XXbpu5FQe7786lTdjlI=; b=EB0h0ic+sC5ma3JLoktVxVvJtd6JWgyTZVbJJszycZy6jjfHSPssfMkTsGAEr8QSmo q0m9kPe6AQQYErKcGzR5imjeNgxNx+QfXXEV8gLdWtr3Glc4i7wK8rDhMhj/aqpcD5PG n8gy9MwYy0WB02ln+GiJsTXjgxqY8YUX0wuPhbFeG1ifdRmYAOs6h5WZ/MTdGx/Etz+F zpcznyKiRX5Ls+Q7pCyhaDUb1ih8LCmjm2hYvg8Hjv5eMaf1GPIbGUV5hSDNabr50K1R +MQr9Uiv3hie1rlQnJQfwlNkW5oQSCsYS7eooBgOALYfcXXTC4FGL7sdLuVXm/aqtg/J K+9A== X-Forwarded-Encrypted: i=1; AFNElJ/oK+bDRhuwkIwteUgAZQ66WtQdlxYybei7rlcNeHwinO7Xyg9gRb9MV80n2CTjkj6TAKdoXHCu8/E1Z50=@vger.kernel.org X-Gm-Message-State: AOJu0YxabaZfGl6ixjNXse8ioH+f4j4A4WioxSI1y06hF4+Axd9No2IG 2vn6K2qXYSxb6YMQw/9Hvsw8m9uIWFLNF7SkqvIpGDULcqwXcoOmkZO9 X-Gm-Gg: Acq92OERXRoSxBWNKBnr6oBL8jwZOgI/T2yF810+fJ/lHFJA80WavdSNvl+2eJsAHvK EPidcjJFIAHibxPlOhapZFUs+8usk+axskLZa9lINw+4lAh8Ili0FzVsuSoksq797IN1Az37AS+ B2IbZG7XAZTaaudBVl4TCgIr3ooUyvoc4wheLDvXDzWCFJpwyFa1vSroM5rwllbCM1hAQah9WoC u+MdRtsb8FShqPU3tiHsTJVc4sMbgcU26CD5qnmQKZ/NgNKDMCFD/H/d1o3MevZ4q1fuXbSFarR IK0uG/RlQgkGVpzu8TH72DZDGhfMQ9ZzPy9Z57jw3j7Sd40/gyYU2sjUXxo9GaaZ7ZtVKIoDh1s /cT11HFDebxjaddPsxAGosrtg8UX3QWUdNhqOt0U6xCjyjQkiXg/vkDOvEZtQcvzPu1TvCrjoby qWhvY2CL3ntatSm4tMTBJNmGCdcBA517r/u5H3j13aUczKusKMto5Wexc/4M2caSlb/83zIdb5S 7Dj9AxntYmvA0LYf5A8smfjcQ1G X-Received: by 2002:a17:902:b288:b0:2bd:2de3:519f with SMTP id d9443c01a7336-2bd7e97d27cmr110339225ad.19.1779091486960; Mon, 18 May 2026 01:04:46 -0700 (PDT) Received: from 1.0.0.127.in-addr.arpa ([110.44.115.146]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5cfe64a9sm140971935ad.53.2026.05.18.01.04.41 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 May 2026 01:04:46 -0700 (PDT) From: Shuvam Pandey To: Yue Wang , Lorenzo Pieralisi =?utf-8?q?=2C?= Krzysztof =?utf-8?q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl Cc: linux-pci@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Mon, 18 May 2026 13:49:40 +0545 Message-ID: <177909148011.9588.6639767953842842291@gmail.com> Subject: [PATCH] PCI: meson: Propagate devm_add_action_or_reset() failure Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 meson_pcie_probe_clock() enables a clock and then registers a devres action to disable it during teardown. If devm_add_action_or_reset() fails, it runs the action immediately, disabling the clock. The return value is currently ignored, so on that failure path meson_pcie_probe_clock() returns the disabled clock and probe continues. Return the error so the existing probe error path unwinds normally. Fixes: 9c0ef6d34fdbf ("PCI: amlogic: Add the Amlogic Meson PCIe controller = driver") Signed-off-by: Shuvam Pandey Reviewed-by: Neil Armstrong --- drivers/pci/controller/dwc/pci-meson.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/dwc/pci-meson.c b/drivers/pci/controlle= r/dwc/pci-meson.c index 0694084f612b..8d495bcc3a41 100644 --- a/drivers/pci/controller/dwc/pci-meson.c +++ b/drivers/pci/controller/dwc/pci-meson.c @@ -204,7 +204,9 @@ static inline struct clk *meson_pcie_probe_clock(struct= device *dev, return ERR_PTR(ret); } =20 - devm_add_action_or_reset(dev, meson_pcie_disable_clock, clk); + ret =3D devm_add_action_or_reset(dev, meson_pcie_disable_clock, clk); + if (ret) + return ERR_PTR(ret); =20 return clk; } --=20 2.50.0