From nobody Sat Jun 13 22:11:39 2026 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9814423A76; Tue, 5 May 2026 10:56:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777978609; cv=none; b=eNLTgsKQSsD33WezaaBpZ7rsHpI1ZPR6PvJHw54t1jn+Qh9+MUwW/Ih/tRPqAhuAiEeXNRnCso7/OYn2k9SvH8j4ai6egaBzUZ++b7wBILs8Cr2Ko4SuIM68FvvzSay7VHtmjKkw4t0JetZCix+q+GW2ZB+oGnQp3QaX+LRNYT4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777978609; c=relaxed/simple; bh=GPFm2wRpGMLb8hHxxlKlZb9aoY1EZa1Pe/OYlpTqu1M=; h=Date:From:To:Subject:Cc:MIME-Version:Message-ID:Content-Type; b=r9TRjRcOUbim7KtyYcom4gpIk9WAmBrlSw9VS64UlgDAZLox8YV5q6bGJi9fILUj9ikZ7xwXWuYx4f2DPPlkZhelH9yRYykaq5WcX1S/1s0Ypnan62xcgFDa7dVX4/oQQcOT9PgsAMrP7s8xHGuONj04TdNgMkfFfV4TsW9z3iM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=oG+g8ybE; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=ESwy4GGs; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="oG+g8ybE"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="ESwy4GGs" Date: Tue, 05 May 2026 10:56:45 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1777978606; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7JXVrRWZYoiGnV1byADs6sajtWK98QkYRFsr3R4MeMg=; b=oG+g8ybEzkBO7xUyvngVGkdOrHxHl/AdxmrLZ6mVAd6SNT8lMh7fSWzitq0U4ZW1HcqKce 3JxHhS1FD5F2Cwvq5EpRRQwKrkaU//deQ337eNWvagJI+bpJp7Et1iNDlG/Eh721g51iv/ CL8DRv/DBA5Weo/gOOpTDRjT1A9MtLB6OugJpW0NYVHoEEUSQUQap5zLXp5FFYerHMGPkY EiMo/StTR6FgLmWqpgllfXXd0DqwJMwDoqYCMxAdHFqEqZcEhyNsz7rOS0RnH2GUCX4iZV KIeTU6Q5Sjrmp3/JiSI686y/ByDHSBSvwMOt7q2bRvy4GajKIJDmRFfpz4BLUA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1777978606; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7JXVrRWZYoiGnV1byADs6sajtWK98QkYRFsr3R4MeMg=; b=ESwy4GGsFN3jYPlxWL9SwUtMP1w4QtI4vYpgO22DXqzNPo3vlwrs+zf8l3fjH92uFwrIVd 8s0QaEr3Ev1p2dDg== From: "tip-bot2 for Joe Lawrence" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: objtool/core] objtool/klp: Fix create_fake_symbols() skipping entsize-based sections Cc: Joe Lawrence , Song Liu , Miroslav Benes , Josh Poimboeuf , x86@kernel.org, linux-kernel@vger.kernel.org Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <177797860532.424702.1887539390076341636.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Precedence: bulk Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The following commit has been merged into the objtool/core branch of tip: Commit-ID: 3de711fba73ad93b8b3fbe09cf681cefed5d573d Gitweb: https://git.kernel.org/tip/3de711fba73ad93b8b3fbe09cf681cefe= d5d573d Author: Joe Lawrence AuthorDate: Tue, 24 Mar 2026 17:34:16 -04:00 Committer: Josh Poimboeuf CommitterDate: Mon, 04 May 2026 21:16:00 -07:00 objtool/klp: Fix create_fake_symbols() skipping entsize-based sections create_fake_symbols() has two phases: creating symbols from ANNOTATE_DATA_SPECIAL entries, and a fallback that uses sh_entsize for special sections like .static_call_sites. When .discard.annotate_data is absent, the function returns early, skipping the entsize fallback and silently allowing unsupported module-local static call keys through. Fix it by jumping to the entsize phase instead of returning early. Fixes: dd590d4d57eb ("objtool/klp: Introduce klp diff subcommand for diffin= g object files") Assisted-by: Claude:claude-4-opus Signed-off-by: Joe Lawrence Acked-by: Song Liu Reviewed-by: Miroslav Benes Signed-off-by: Josh Poimboeuf --- tools/objtool/klp-diff.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/objtool/klp-diff.c b/tools/objtool/klp-diff.c index c5d4c9e..0653bf6 100644 --- a/tools/objtool/klp-diff.c +++ b/tools/objtool/klp-diff.c @@ -1374,7 +1374,7 @@ static int create_fake_symbols(struct elf *elf) =20 sec =3D find_section_by_name(elf, ".discard.annotate_data"); if (!sec || !sec->rsec) - return 0; + goto entsize; =20 for_each_reloc(sec->rsec, reloc) { unsigned long offset, size; @@ -1406,7 +1406,7 @@ static int create_fake_symbols(struct elf *elf) /* * 2) Make symbols for sh_entsize, and simple arrays of pointers: */ - +entsize: for_each_sec(elf, sec) { unsigned int entry_size; unsigned long offset;