From nobody Tue Apr 14 14:07:33 2026 Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 364062C21F4 for ; Tue, 14 Apr 2026 06:04:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776146679; cv=none; b=QoY/lOMIzsJynKEga40vwqfCb1clFpqoUmKjFK5uT33faVSll7VF/PnKJbnBvw/mmN3J8ZIipPVFH5sVKtD8RVVrHL8HzR+eVqkxxurd2ToHKCna+OOTmANJz0DmNnngWby0VaH5l7v3fdHE7KDqha/MJ7g73VfWnJEse9UFEwc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776146679; c=relaxed/simple; bh=kwwtfunrD7hHLNzuaOfO0jJzIZvS2EcOuH2zmnFPgUk=; h=Content-Type:MIME-Version:From:To:Cc:Subject:Date:Message-ID; b=CyqopWoXu2AT7/xA2J+27n7GiEmvLHVolcjU1Zt57T9oB1fCKS2YB5iZ1k13BWgNukmbCQ6w7PSqTQ2b+NfaKK23rkmnWBBUsr8ZhGziV7Uf/5GJhS7o63VmLeBKLv9RUYHmfNrjvKzSCZCC9WVZkWDb+eLiDup6wvbued2bNXY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nnYR0gye; arc=none smtp.client-ip=209.85.219.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nnYR0gye" Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-8a48deebe95so43070676d6.0 for ; Mon, 13 Apr 2026 23:04:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776146676; x=1776751476; darn=vger.kernel.org; h=message-id:date:subject:cc:to:from:content-transfer-encoding :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=kwwtfunrD7hHLNzuaOfO0jJzIZvS2EcOuH2zmnFPgUk=; b=nnYR0gyeyzVRzoqMyZiwHiNiTy1LLnjPwA5R9z4ZWUvuoga3Vi1Z3MrRNKMu6BGycD utUmEgxUr1MdIeXSIQrR4sqwJuGAcjOfRTrtqL7sfoEOLYQC8P8tb+0eNxze97p7Sz4Z bA/YoeKMxRm+uf7zdFeAcaL6Bt1OlkPyjuqLX4XVxXxnm4mKBDHIajd3p+oOwtihuNzq JXEnBcq8hazL48bk6trY3rTjQ6kzKwlSS4aiTvDSysfczrBxDohdGoM98wjtYOxzbncr MeVKbLtzN+SxjoicKmO3uxJFjc8LtYAEff09g/F+ejnC90fclfKWehQT/AazmmqRoDWb 5S2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776146676; x=1776751476; h=message-id:date:subject:cc:to:from:content-transfer-encoding :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kwwtfunrD7hHLNzuaOfO0jJzIZvS2EcOuH2zmnFPgUk=; b=N3zp98mQEMecVy58mb1ac6r+0pmcwuRJh18YZ/NR6b1ryKezwtffae15QUkEem1Sut UzgFi4wftOkbms7SBeMDu2Kkjc9A/tKTv4zsQ8BzJKPWhKfxNfVZi9OalsFROcjUTo2A zKYcDggbA9R0RwHzly0jo6DnqkwNyqs8IuuWKJw/IGOUhLONTp0yE8R7FopphhEQ47Kr uzwcLUp+0Z0VulGOcTv0pG4FgaVizZhPd1nDxO+sSoe0pi8yZFyfQnp1iqoBSXWOaR9p 0BRAJJ18jfzCJdTUxRWutLdNvomgvgpOQAIDec4rfCLmrtqduKo6CIiCp6SS1UYF1d0a ZW1g== X-Forwarded-Encrypted: i=1; AFNElJ8Ay1/jsAPStwrBHKGjEQGDjA1BCogEvCLYenZihqeuU6cDgSl3bBnWkDrXgfJ+n2zmjUqBofZM1Kr4VOs=@vger.kernel.org X-Gm-Message-State: AOJu0Yxy6V7NNNjA92GnxFvQYHIUpE0ZQ3c1mLABst6BLaRppyyu9+Jo DZVzGwFCBOi08/QET3fVayEV2EFzTKSKsQekYaeJjsyiSxbl1mFf2MIR X-Gm-Gg: AeBDietOUQ/H8zFVVOW2Nz0VG7r3xRU6Lyu4+ZOkSazYZ2YsI71wad0dtZx9fux9TN6 vhTYcaXCn0iJvtU3BOhWsEVAfxDTG/VO39LdA1xCPwJIYfgff5jLH3CasXrZveWoTP4SiARxvCQ SFeJrPJoJctZ9F0t1lTT7ybyKA3pyY2f5OBsMWgBdrRZSMl81GcjU5lOQHLspRhnVMFjP745Avi z2NGc2eZtoZR06FY9/J7zkaX06PmgqcSOvK2caq25Vp7391K+GwaKIZzkQpMlQjerevjpIyzara Kh0dMSybaPJYD/BFUFOUhL7/3Qwv0auL1C7BbGPN2kQz8LFCvJv4xM59YDfnksnmUTTQoyUBMpS WNlLM7l+H2NJJvDj2bcF69uyjK5iQfwOpz4d2lwFZLlc2zp6L+em9ytqNnEVwbJ8KeHNCiPQ0g1 5kLsszAmnk090/FPEGZqyr/2gcU5b8Ry5mLW2HfmiYhsdAhhL0yPJBzIXaZE0l4SdoJzp2/U4= X-Received: by 2002:a05:6214:5402:b0:89c:5f6e:451a with SMTP id 6a1803df08f44-8ac861cac52mr271499016d6.21.1776146676021; Mon, 13 Apr 2026 23:04:36 -0700 (PDT) Received: from tdc4045031631.internal.cloudapp.net ([20.63.37.123]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ac84a10e7esm113910586d6.16.2026.04.13.23.04.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 23:04:35 -0700 (PDT) Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Ashutosh Desai To: netdev@vger.kernel.org Cc: linux-hams@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] rose: fix OOB reads on short CLEAR REQUEST frames Date: Tue, 14 Apr 2026 06:04:34 -0000 Message-ID: <177614667427.3606651.8700070406932922261@gmail.com> rose_process_rx_frame() calls rose_decode() which reads skb->data[2] without any prior length check. For CLEAR REQUEST frames the state machines then read skb->data[3] and skb->data[4] as the cause and diagnostic bytes. A crafted 3-byte ROSE CLEAR REQUEST frame passes the minimum length gate in rose_route_frame() and reaches rose_process_rx_frame(), where rose_decode() reads one byte past the header and the state machines read two bytes past the valid buffer. Add a pskb_may_pull(skb, 3) check before rose_decode() to cover its skb->data[2] access, and a pskb_may_pull(skb, 5) check afterwards for the CLEAR REQUEST path to cover the cause and diagnostic reads. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable@vger.kernel.org Signed-off-by: Ashutosh Desai --- V1 -> V2: switch skb->len check to pskb_may_pull; also add pskb_may_pull(skb, 3) before rose_decode() to cover its skb->data[2] access v1: https://lore.kernel.org/netdev/20260409013246.2051746-1-ashutoshdesai99= 3@gmail.com/ net/rose/rose_in.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/net/rose/rose_in.c b/net/rose/rose_in.c index 0276b393f0e5..b9f01a11e2df 100644 --- a/net/rose/rose_in.c +++ b/net/rose/rose_in.c @@ -269,8 +269,18 @@ int rose_process_rx_frame(struct sock *sk, struct sk_b= uff *skb) if (rose->state =3D=3D ROSE_STATE_0) 0; =20 +if (!pskb_may_pull(skb, 3)) { +kfree_skb(skb); +return 0; +} + frametype =3D rose_decode(skb, &ns, &nr, &q, &d, &m); =20 +if (frametype =3D=3D ROSE_CLEAR_REQUEST && !pskb_may_pull(skb, 5)) { +kfree_skb(skb); +return 0; +} + switch (rose->state) { case ROSE_STATE_1: ueued =3D rose_state1_machine(sk, skb, frametype); --=20 2.34.1