From nobody Mon Jun 15 00:20:16 2026 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E40A739A041 for ; Tue, 7 Apr 2026 08:35:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775550929; cv=none; b=OmvLhT8yqoGXjMOP4HkpZgFRRmWw+oTK+8CSBao7i0WDPA8THkoOxfJKtRQH6BadO0Ir+U3eqeI35MT8nWQQIH/v80SvfAleSi3W3bEz1lO0yJM/brrEsq6EvYL6n2LdwQuN9qFe/RbA2hGLKnFa0JOULtz52qP3WJg4+CvLwOs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775550929; c=relaxed/simple; bh=dKTujzU/RT4gZ0YeCuNIiO3l8HTosq2qqb8WSt2cwZY=; h=From:To:Cc:Subject:Message-ID:Date:Content-Type:MIME-Version; b=qJKQrmPdp0wnczGFy2wKA9PA095Z51famBzUSmm3eXmw5pfkSNfslcG0H1okYEAE18KGU2KP61PghqBqO3EJdhuacxWCdsKePay9dpJTekE165hw6pjBNBtkoUbLbtoFBgOkUSDBGsqlKXGqMC551kMbqWpkJgyR2Hc5HS0Yw8Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sOIM9gM4; arc=none smtp.client-ip=209.85.215.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sOIM9gM4" Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-c76cce85bd9so1709506a12.1 for ; Tue, 07 Apr 2026 01:35:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775550919; x=1776155719; darn=vger.kernel.org; h=mime-version:content-transfer-encoding:date:message-id:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=LkzOHxn7RTxz0GA1rTzNHX8XFNh7eSE/QKKRVQuNXEQ=; b=sOIM9gM4MNcwg4V3eeUPr6Z9rcLL2WuLqnJvoHTJxZPuCN2r8wlbl0dTigkD+Fl2qo Rv4U5OHgkEMr3znCP4O8bu/d1wQdCvnqXxQJDYvXc6luTmvAboFjKV+rt1V9e36tcHM7 tHqyCcAFaQFG/xPvEY3PpjObDm+CykSVSBO3GIbBAicyQ8y+olKBkA7o0F5QbUxmMRdH Q7P07CSEAIwnF1Hj6HuhoVW9UHcfKIssHZg3J3Ftg+cqoej/GG1jdeoAmdE9EOY0WBTC Ar/sN5DGmBBT3DViFutrM3eDUZYLCuG//UI/Wg/LK/gS4f7sn8CKy/4fOLvpx1iMCLTB at5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775550919; x=1776155719; h=mime-version:content-transfer-encoding:date:message-id:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LkzOHxn7RTxz0GA1rTzNHX8XFNh7eSE/QKKRVQuNXEQ=; b=aCtMPnd66C/gsq2KGZlxLih4c4NCNN5VVwBZlWhbhCS4kJyUXElRgTRBzT2i0qq2Q5 Qmuz7PTVPs3o5fup79+a36Nm0DRUMU6q0dOVb/Z0bAlONLqnr+s7LctEjirZ1mjiu+Ke /L7MmFHxtrHBuJE6btNWjzf2MRGpBfWfINkzvIiDaGC3tgc4Ew2c0Ci8/KY2LymlVPPD jRuGeabKHr3LTyvOrbaYDeghUBFgMXsco/R0uHr180oQfWplNXhHLDzaCjSQKrkqsxEd COk1FOURR5K9fo2F6GKfVQZXyX+cYFQNUGFrPbAbbjQ3mymy6DjL9iaeCdxMatJ7I6hO gTOg== X-Gm-Message-State: AOJu0YzAxCDVDCobxWOS4/f9C3LHXadCaHcSPtKnge3AZ+/1a08KGmvG V1mkhbnA9RBBVV2KC9NpL4KCEUaBPk7ISr3ZlHgLojZVz1Sj3JOVSMpv X-Gm-Gg: AeBDieuxGsoSKJwxJZpcz0vhad23Y/9ibpFpoh0UD3D77sY5bVw+DLUAd193vC36OHE YPTMN78KsT7CIBEepvQqeCUBa596Qy+QEe2yK/dPhNsFdVwJI9AYEG33sMvp9cIB9F6PtPSzjZV IyUAVlq225gDFMeRUpqw3b5R3P+0oDa2CjL+Q0hGHgQUZqqYy80EI13KY5GH40R1VDtebWKeILL mokfvu/7CF9ib2mte64fH2fgLDNurkE4TE6zAed+4lj7dtaD2Fx9RLDBd8TUdrNo0IMPVXp0VOP wSQ+iiTAy4QeIq8o7fWtuMTCJgSaJSVU79Nn+iDb3ypSgz7I2XtqkxzF0Hcv25lBUb1A3Cf4gAk /L43QOC5cIzihL9m+6N4BKF7GbikCRwBcZABVkUXL6erxYyKV4I9rN4nwNfnLFilzniPU1dGX2L iU0KIarBMe5S2V10aDDWM4Wl5itXS0gGl1w1eI7yAGmwQeYvBJpvL1XfeJsmMfOmBzPvwrouyNm TvNmOHncCTP+KMldy23jA== X-Received: by 2002:a05:6a20:4322:b0:39e:f994:f698 with SMTP id adf61e73a8af0-39f2f0cc6e0mr14883194637.48.1775550919424; Tue, 07 Apr 2026 01:35:19 -0700 (PDT) Received: from Shuvs-MacBook-Air.local ([103.10.28.236]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82cf9c6ad8asm16842931b3a.40.2026.04.07.01.35.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 01:35:19 -0700 (PDT) From: Shuvam Pandey To: David S. Miller , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, syzbot+5ec223ccb83b24ef982f@syzkaller.appspotmail.com Subject: [PATCH net] atm: mpoa: fix mpc->dev refcount across mpoad restart Message-ID: <177555091252.59118.13093904987038690781@gmail.com> Date: Tue, 07 Apr 2026 14:20:12 +0545 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 atm: mpoa: fix mpc->dev refcount across mpoad restart mpoad_close() drops the reference held in mpc->dev with dev_put(), but the mpoa_client stays alive and keeps the same device pointer. A later mpoad attach reuses the existing mpoa_client without reacquiring that reference, so the next close can hit the netdevice refcount warning. Keep the LEC device reference with the mpoa_client until the device unregisters or the client is torn down. Reported-by: syzbot+5ec223ccb83b24ef982f@syzkaller.appspotmail.com Link: https://groups.google.com/g/syzkaller-bugs/c/qhZ5MJfLBOE/m/UnotmgRdAQ= AJ Signed-off-by: Shuvam Pandey --- net/atm/mpc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/atm/mpc.c b/net/atm/mpc.c index ce8e9780373b..1e9b9c633e8b 100644 --- a/net/atm/mpc.c +++ b/net/atm/mpc.c @@ -886,7 +886,6 @@ static void mpoad_close(struct atm_vcc *vcc) struct lec_priv *priv =3D netdev_priv(mpc->dev); priv->lane2_ops->associate_indicator =3D NULL; stop_mpc(mpc); - dev_put(mpc->dev); } =20 mpc->in_ops->destroy_cache(mpc); @@ -1508,6 +1507,8 @@ static void __exit atm_mpoa_cleanup(void) priv =3D netdev_priv(mpc->dev); if (priv->lane2_ops !=3D NULL) priv->lane2_ops->associate_indicator =3D NULL; + dev_put(mpc->dev); + mpc->dev =3D NULL; } ddprintk("about to clear caches\n"); mpc->in_ops->destroy_cache(mpc); --=20 2.50.0