From nobody Sun Jun 14 08:21:21 2026 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE12E36493C; Wed, 1 Apr 2026 19:34:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775072076; cv=none; b=NdQBdqKcBt+DQhJnufHioxgd6te+CQ8O93+qboN35CyGuzOaRpd7cP/4ElfwBynfDu2LvD1tVO/4KsHVsIkfs8b1ERMn43RqgtK7NyjalxUXzxXenNtG6sLkIFxPr2XtN0bPbG3096841MoSTYwKfjJqzemyWlOk2BiP1Aa9ROs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775072076; c=relaxed/simple; bh=bld5jO+28BUJBipwwmYcJrcwFBwlK4/9hkzQM8XWxDs=; h=Date:From:To:Subject:Cc:In-Reply-To:References:MIME-Version: Message-ID:Content-Type; b=eAZvPbCJ5BT/jYi/HTJToKQb1JX6GEpUypWp2LF/sVlngRtv7zZ7gupMDv8ypGPjOPOBp6PNMpm9SWizgt59XIIk8Eesc5DDKAPemC2oqCRpiPhQMatzg5j9A7fJ89OQF4M57y1Jd/eeeZWbI5GnvJQGOOOYp9zQ6uEKApztNQk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=2ANa22X3; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=flNVKZRk; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="2ANa22X3"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="flNVKZRk" Date: Wed, 01 Apr 2026 19:34:31 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1775072073; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+pBlhsJ4GuTVuKEJo0Tb2R8FIrIumPylVnfIyNka+gk=; b=2ANa22X3ky6VF+zykqCOMpk5CZ+YzCsjla/coGol9hHCxVta7b/5+KDm2uNkYUgziUimbD 6XomqI1CTZxdFHbM/yuJfeYP0AKeEiE6Xj6+UmGK4NRghGS0Oaxbu7kMxCS3lCYowW7Qei u0RQ9qUDrz76lPRjMo3TTQz9YJ9slmzk9YaS3pROLx40pN5/oSmSiRq7zn+r3YGhzVfFoK Jc/ZOb0O1WK0Xrhp0RTXHPFegjAXUByDzrCauTxlRbVs7dEun5+qi8sT2ea20KwONNGMp2 h4+OUmOeOqOq/WgQXMNZYYvJpDe75DMAKa4gfaDK3CtVv/9pB6J/WUzSVB+pRw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1775072073; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+pBlhsJ4GuTVuKEJo0Tb2R8FIrIumPylVnfIyNka+gk=; b=flNVKZRkXcMLIUzstjI2EtGw9lJku2Opu4262UMkLug73p6lNF/4q6akvxjw+GhtPgvPoh l71Al0yFBd2wb2Dw== From: "tip-bot2 for Mario Limonciello (AMD)" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: x86/platform] firmware: dmi: Adjust dmi_decode() to use enums Cc: "Mario Limonciello (AMD)" , "Borislav Petkov (AMD)" , Jean Delvare , Yazen Ghannam , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20260307141024.819807-3-superm1@kernel.org> References: <20260307141024.819807-3-superm1@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <177507207136.1647592.13163049356929005215.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Precedence: bulk Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The following commit has been merged into the x86/platform branch of tip: Commit-ID: 28189e95712b70008754c993ecd3531d1c7018d1 Gitweb: https://git.kernel.org/tip/28189e95712b70008754c993ecd3531d1= c7018d1 Author: Mario Limonciello (AMD) AuthorDate: Sat, 07 Mar 2026 08:10:21 -06:00 Committer: Borislav Petkov (AMD) CommitterDate: Wed, 01 Apr 2026 20:54:16 +02:00 firmware: dmi: Adjust dmi_decode() to use enums dmi_decode() has hardcoded values with comments for each DMI entry type. The same information is already in dmi.h though, so drop the comments and use t= he definitions instead. Signed-off-by: Mario Limonciello (AMD) Signed-off-by: Borislav Petkov (AMD) Reviewed-by: Jean Delvare Reviewed-by: Yazen Ghannam Link: https://patch.msgid.link/20260307141024.819807-3-superm1@kernel.org --- drivers/firmware/dmi_scan.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c index 70d39ad..80aded4 100644 --- a/drivers/firmware/dmi_scan.c +++ b/drivers/firmware/dmi_scan.c @@ -484,14 +484,14 @@ static void __init dmi_memdev_walk(void) static void __init dmi_decode(const struct dmi_header *dm, void *dummy) { switch (dm->type) { - case 0: /* BIOS Information */ + case DMI_ENTRY_BIOS: dmi_save_ident(dm, DMI_BIOS_VENDOR, 4); dmi_save_ident(dm, DMI_BIOS_VERSION, 5); dmi_save_ident(dm, DMI_BIOS_DATE, 8); dmi_save_release(dm, DMI_BIOS_RELEASE, 21); dmi_save_release(dm, DMI_EC_FIRMWARE_RELEASE, 23); break; - case 1: /* System Information */ + case DMI_ENTRY_SYSTEM: dmi_save_ident(dm, DMI_SYS_VENDOR, 4); dmi_save_ident(dm, DMI_PRODUCT_NAME, 5); dmi_save_ident(dm, DMI_PRODUCT_VERSION, 6); @@ -500,33 +500,33 @@ static void __init dmi_decode(const struct dmi_header= *dm, void *dummy) dmi_save_ident(dm, DMI_PRODUCT_SKU, 25); dmi_save_ident(dm, DMI_PRODUCT_FAMILY, 26); break; - case 2: /* Base Board Information */ + case DMI_ENTRY_BASEBOARD: dmi_save_ident(dm, DMI_BOARD_VENDOR, 4); dmi_save_ident(dm, DMI_BOARD_NAME, 5); dmi_save_ident(dm, DMI_BOARD_VERSION, 6); dmi_save_ident(dm, DMI_BOARD_SERIAL, 7); dmi_save_ident(dm, DMI_BOARD_ASSET_TAG, 8); break; - case 3: /* Chassis Information */ + case DMI_ENTRY_CHASSIS: dmi_save_ident(dm, DMI_CHASSIS_VENDOR, 4); dmi_save_type(dm, DMI_CHASSIS_TYPE, 5); dmi_save_ident(dm, DMI_CHASSIS_VERSION, 6); dmi_save_ident(dm, DMI_CHASSIS_SERIAL, 7); dmi_save_ident(dm, DMI_CHASSIS_ASSET_TAG, 8); break; - case 9: /* System Slots */ + case DMI_ENTRY_SYSTEM_SLOT: dmi_save_system_slot(dm); break; - case 10: /* Onboard Devices Information */ + case DMI_ENTRY_ONBOARD_DEVICE: dmi_save_devices(dm); break; - case 11: /* OEM Strings */ + case DMI_ENTRY_OEMSTRINGS: dmi_save_oem_strings_devices(dm); break; - case 38: /* IPMI Device Information */ + case DMI_ENTRY_IPMI_DEV: dmi_save_ipmi_device(dm); break; - case 41: /* Onboard Devices Extended Information */ + case DMI_ENTRY_ONBOARD_DEV_EXT: dmi_save_extended_devices(dm); } }