From nobody Tue Apr 7 04:21:10 2026 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59CDC15FA81; Mon, 16 Mar 2026 09:50:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773654631; cv=none; b=btdbJ6woVkJ0n4j/VbcTx0ZrUsrqw6eAl7jNKsClW4RB9R8pnYTG9A2glFcUUA3JIcUJrSkgN4Pjx6TgTJkHXlyelFZDx5jqAAlzCKfL/PwSyrCQmfKWQIsVPQwH6I5unqVr//3tRz9pwWnoYvmSy9xLwKddAFdepDUJQ9xqRGU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773654631; c=relaxed/simple; bh=zfTRFlmO+yflOLcvo0+QnvzUmap+k4cHbXxTVxoxlyw=; h=Date:From:To:Subject:Cc:In-Reply-To:References:MIME-Version: Message-ID:Content-Type; b=QpdSrefDZRc2mdet/EVLZOpCkzM1Kk7/T0FgZSyuhOd/0ixP9t17tXa6G3ICDHhVXiGENn1P+RlLcgTlZiYVdn/Kr+xH5mcBRBbiDwNHNmaZ/h6S1cVVU+/jx4PySOj2lGuUH/EAQt8HVoJr7xlDb+6A9lbQfUNoHlVxzUa/kb4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=vENYewCt; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=n2f+m2IU; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="vENYewCt"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="n2f+m2IU" Date: Mon, 16 Mar 2026 09:50:27 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1773654628; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yzjJ+ocssdknA0mAMmNfuMqJIEkqZGlhaZoBnsSF2Iw=; b=vENYewCttcUxrS3LOYTsmh3uU+VrEEVvRQadQT84liBLmWJquyzaK/DbIODzEDJ0iL64fJ +AturjoZkyG+Ha2WepwQAH17P9SGnFFPawqCG0z9x6wuTFk07IVb2XTuZ9PnF9S+t6icLI DHHGnaCnl2SeBC1BZsO3ZTycOppFFXkaIxZoKeM66Yl7RnEW+EM7++awl1rmj9jp8XCUhW hwYTthMi7cNSyi+ftP3h9kAjT6qtGTNIJJnekx/OtGPsTTXmeMvu6jx/X3RnjfcX6pI09j 86H7m/ChNJA2tI3wx5j+Pqfnz5xUV77RLULbODV3bkn9btQB6OeQ2ovxeDQQJQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1773654628; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yzjJ+ocssdknA0mAMmNfuMqJIEkqZGlhaZoBnsSF2Iw=; b=n2f+m2IU0RRqo75bPiNCbqipyFSTE9iYNBY6HEEcBxkhvoOLOqb+9uJrJL6DaA+o0H79HM yl0mdS/sthKogEBw== From: "tip-bot2 for Dapeng Mi" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: perf/urgent] perf/x86/intel: Fix OMR snoop information parsing issues Cc: Ian Rogers , Dapeng Mi , "Peter Zijlstra (Intel)" , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20260311075201.2951073-1-dapeng1.mi@linux.intel.com> References: <20260311075201.2951073-1-dapeng1.mi@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <177365462730.1647592.355135029463303140.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Precedence: bulk Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The following commit has been merged into the perf/urgent branch of tip: Commit-ID: e7fcc54524f04e42641de99028edd9c69dc19f8c Gitweb: https://git.kernel.org/tip/e7fcc54524f04e42641de99028edd9c69= dc19f8c Author: Dapeng Mi AuthorDate: Wed, 11 Mar 2026 15:52:00 +08:00 Committer: Peter Zijlstra CommitterDate: Thu, 12 Mar 2026 11:29:16 +01:00 perf/x86/intel: Fix OMR snoop information parsing issues When omr_source is 0x2, the omr_snoop (bit[6]) and omr_promoted (bit[7]) fields are combined to represent the snoop information. However, the omr_promoted field was not left-shifted by 1 bit, resulting in incorrect snoop information. Besides, the snoop information parsing is not accurate for some OMR sources, like the snoop information should be SNOOP_NONE for these memory access (omr_source >=3D 7) instead of SNOOP_HIT. Fix these issues. Closes: https://lore.kernel.org/all/CAP-5=3DfW4zLWFw1v38zCzB9-cseNSTTCtup= =3Dp2SDxZq7dPayVww@mail.gmail.com/ Fixes: d2bdcde9626c ("perf/x86/intel: Add support for PEBS memory auxiliary= info field in DMR") Reported-by: Ian Rogers Signed-off-by: Dapeng Mi Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Ian Rogers Link: https://patch.msgid.link/20260311075201.2951073-1-dapeng1.mi@linux.in= tel.com --- arch/x86/events/intel/ds.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/arch/x86/events/intel/ds.c b/arch/x86/events/intel/ds.c index 5027afc..7f0d515 100644 --- a/arch/x86/events/intel/ds.c +++ b/arch/x86/events/intel/ds.c @@ -345,12 +345,12 @@ static u64 parse_omr_data_source(u8 dse) if (omr.omr_remote) val |=3D REM; =20 - val |=3D omr.omr_hitm ? P(SNOOP, HITM) : P(SNOOP, HIT); - if (omr.omr_source =3D=3D 0x2) { - u8 snoop =3D omr.omr_snoop | omr.omr_promoted; + u8 snoop =3D omr.omr_snoop | (omr.omr_promoted << 1); =20 - if (snoop =3D=3D 0x0) + if (omr.omr_hitm) + val |=3D P(SNOOP, HITM); + else if (snoop =3D=3D 0x0) val |=3D P(SNOOP, NA); else if (snoop =3D=3D 0x1) val |=3D P(SNOOP, MISS); @@ -359,7 +359,10 @@ static u64 parse_omr_data_source(u8 dse) else if (snoop =3D=3D 0x3) val |=3D P(SNOOP, NONE); } else if (omr.omr_source > 0x2 && omr.omr_source < 0x7) { + val |=3D omr.omr_hitm ? P(SNOOP, HITM) : P(SNOOP, HIT); val |=3D omr.omr_snoop ? P(SNOOPX, FWD) : 0; + } else { + val |=3D P(SNOOP, NONE); } =20 return val;