From nobody Wed Apr 8 03:10:52 2026 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C5253D093D; Tue, 10 Mar 2026 17:43:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773164596; cv=none; b=BpKSTU/2J+HxWMXMLwpEgb4pilwceUIVR1uPkcFYUweT3E/g57cecx2FIgORf2TFlwKnTiN/64uYYx8EmZIJRzf8cS3x380OoT94btEzA2b37ev1ylq3J7s1kepauUe5Ia28Y6w9kplRdQPPhnzMYmR0f4bhCvaAfRezmpduZjc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773164596; c=relaxed/simple; bh=tpJQYjAGYcI8SVYa9zFAPD7e42Lwi1RyVecWQClXbbE=; h=Date:From:To:Subject:Cc:In-Reply-To:References:MIME-Version: Message-ID:Content-Type; b=fwUL3cpAyMjFwXYYWhXcthOagWnbzSn2b4LZn4RcV5uuD0GZf6/h5FxwPpFd4WG2BzsPantI1Gz5MsWtPqmLlY8LyKh2ru9KKXPg8FZXqlx1l2q2jQyYbmVXlOOygYkZSf85LLYLi1Q+vnfivgrk+Sifatb7lUI8UTGDkzwhCtA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=4THSm6XS; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=PD0mtaoc; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="4THSm6XS"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="PD0mtaoc" Date: Tue, 10 Mar 2026 17:43:12 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1773164593; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kvxTT5GgAcdo8Q6RSvvHDika/jB3SgHxlUx9s1sWhNc=; b=4THSm6XSyeIXNteKQ2QwzsUewI6NTHlH8dLL92LDsf/nVEnwfJ7S+RyzbgHESgyyAbo0Ae iiawDB+zyN14ePxW7y3PEB56L2kduugFqwxkb1XND2BR3cTVtoDt4ZfvAeUMUaTP4mPana SlXPZOxz1UA/8OhTwnCe1nony08H1G2rQNqEz7X/zJ2/rx9dpYqfAue2uK6rxFnMNs9hXk xrTp4JFqzQWWtAAV272pg79z+C9VdXLw9UzWFq9Ivy8lSTSgKsjAmO+qHNnTvbj1xj1N1U b0AsTjI2wzGXFL0DwG+F0u2pSkO06tdYqiVPTN72hflOqoEsR1owIVTgCB3PHw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1773164593; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kvxTT5GgAcdo8Q6RSvvHDika/jB3SgHxlUx9s1sWhNc=; b=PD0mtaoc78eG53IbJ18lg9P6+C/nUBgB2wV98x8euEXfNEay/v0lFW81fmanJ93wTf2TDJ 0C99kWMdi9HjJiCA== From: "tip-bot2 for Jessica Liu" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: irq/urgent] irqchip/riscv-aplic: Do not clear ACPI dependencies on probe failure Cc: Jessica Liu , Thomas Gleixner , x86@kernel.org, linux-kernel@vger.kernel.org, maz@kernel.org In-Reply-To: <20260310141600411Fu8H8-GXOOgKISU48Tjgx@zte.com.cn> References: <20260310141600411Fu8H8-GXOOgKISU48Tjgx@zte.com.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <177316459245.1647592.16207762171407846782.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Precedence: bulk Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The following commit has been merged into the irq/urgent branch of tip: Commit-ID: 620b6ded72a7f0f77be6ec44d0462bb85729ab7a Gitweb: https://git.kernel.org/tip/620b6ded72a7f0f77be6ec44d0462bb85= 729ab7a Author: Jessica Liu AuthorDate: Tue, 10 Mar 2026 14:16:00 +08:00 Committer: Thomas Gleixner CommitterDate: Tue, 10 Mar 2026 18:42:33 +01:00 irqchip/riscv-aplic: Do not clear ACPI dependencies on probe failure aplic_probe() calls acpi_dev_clear_dependencies() unconditionally at the end, even when the preceding setup (MSI or direct mode) has failed. This is incorrect because if the device failed to probe, it should not be considered as active and should not clear dependencies for other devices waiting on it. Fix this by returning immediately when the setup fails, skipping the ACPI dependency cleanup. Also, explicitly return 0 on success instead of relying on the value of 'rc' to make the success path clear. Fixes: 5122e380c23b ("irqchip/riscv-aplic: Add ACPI support") Signed-off-by: Jessica Liu Signed-off-by: Thomas Gleixner Link: https://patch.msgid.link/20260310141600411Fu8H8-GXOOgKISU48Tjgx@zte.c= om.cn --- drivers/irqchip/irq-riscv-aplic-main.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/irqchip/irq-riscv-aplic-main.c b/drivers/irqchip/irq-r= iscv-aplic-main.c index 4495ca2..8775f18 100644 --- a/drivers/irqchip/irq-riscv-aplic-main.c +++ b/drivers/irqchip/irq-riscv-aplic-main.c @@ -372,18 +372,21 @@ static int aplic_probe(struct platform_device *pdev) rc =3D aplic_msi_setup(dev, regs); else rc =3D aplic_direct_setup(dev, regs); - if (rc) + + if (rc) { dev_err_probe(dev, rc, "failed to setup APLIC in %s mode\n", msi_mode ? "MSI" : "direct"); - else - register_syscore(&aplic_syscore); + return rc; + } + + register_syscore(&aplic_syscore); =20 #ifdef CONFIG_ACPI if (!acpi_disabled) acpi_dev_clear_dependencies(ACPI_COMPANION(dev)); #endif =20 - return rc; + return 0; } =20 static const struct of_device_id aplic_match[] =3D {