From nobody Thu Apr 9 09:03:35 2026 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15534410D39; Mon, 9 Mar 2026 19:54:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773086061; cv=none; b=Sy0g3ISTjxThDKw3SfN4zhxVqa8waIx588jXRVlHlxOdzGYn1r99mg4rNCkDraP/nGUejwFaQnBMwq7C/MkxZEelBuK6joZl4c3OUd9hCJx2pqgKSZ0NBCfQXXkiIibfRfa7eE7ti8cdOOEMEpdWBvF/cso05O9fJL7YZ+4+ZUw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773086061; c=relaxed/simple; bh=h3Ayd41zGYyTVgSj1LQMzpTaSlE7piqliqD8YKblOqE=; h=Date:From:To:Subject:Cc:In-Reply-To:References:MIME-Version: Message-ID:Content-Type; b=QbbvHXBp7BGMZKjEEOWkVbs2yX7AFKL90lNQToCBIOQnvKt5audLRuZJOxsidDqo1u2Pg1y0dwjj/5dfUWi2fHeIFGQbQSeyJrrGKwyEjvcfLxm8+tCyWtQzIYDsjzqpSLkHSyL68TS670KH3rY7GoaFctb97QjX1x1oJYqgz24= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=vaAPKSNJ; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=frSXUy9s; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="vaAPKSNJ"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="frSXUy9s" Date: Mon, 09 Mar 2026 19:54:17 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1773086058; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aTh9tO36Mho6pMuGAD3kNsXSca+JvYSNXa/u9+QoTt4=; b=vaAPKSNJZJO3zdJFExaR6cs5VyzebgNQJleasrSceYltI+0bklIaKZbzct40oYm/sOgpNe Vp2+AR5VYu+emD+c5JwdWHVrxWMymYQQqTzgaoXlE2vgTN59U4PZQqncsoO6eruX5nsrQa ZF6nXN8tkJ+13X//+oG03AxLeFPDpA6WdSBopdaRCNh7AfqS1hHstCyrp/Q1ZObZdYS+Xx lMdFmDsBGDJSvjXSAi+58OIl+EfWMZhGb9w54Ojyy6iSrz3RS3WRz2DokTLvpdfASEo8sl OuGuBq/mv8oZ+apOM8/R8dv5QY415xmO7dcxyXzI3qqDrIYtvlFpfwWUljtbYw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1773086058; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aTh9tO36Mho6pMuGAD3kNsXSca+JvYSNXa/u9+QoTt4=; b=frSXUy9sLICsfetEZ1HKxWZ3pPp3fZTIiEJcFx5z70dOaFJoga2hosE1x2uGaRZQaWVNC6 YmJ1yh4+1W/+ONBw== From: "tip-bot2 for Josh Poimboeuf" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: objtool/urgent] objtool/klp: Disable unsupported pr_debug() usage Cc: Josh Poimboeuf , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <3a7db3a5b7d4abf9b2534803a74e2e7231322738.1770759954.git.jpoimboe@kernel.org> References: <3a7db3a5b7d4abf9b2534803a74e2e7231322738.1770759954.git.jpoimboe@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <177308605767.1647592.10464594555546991501.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Precedence: bulk Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The following commit has been merged into the objtool/urgent branch of tip: Commit-ID: e476bb277cf91b7ac3ea803ec78a4f0791bddec3 Gitweb: https://git.kernel.org/tip/e476bb277cf91b7ac3ea803ec78a4f079= 1bddec3 Author: Josh Poimboeuf AuthorDate: Tue, 10 Feb 2026 13:50:10 -08:00 Committer: Josh Poimboeuf CommitterDate: Fri, 06 Mar 2026 07:47:11 -08:00 objtool/klp: Disable unsupported pr_debug() usage Instead of erroring out on unsupported pr_debug() (e.g., when patching a module), issue a warning and make it inert, similar to how unsupported tracepoints are currently handled. Reviewed-and-tested-by: Song Liu Link: https://patch.msgid.link/3a7db3a5b7d4abf9b2534803a74e2e7231322738.177= 0759954.git.jpoimboe@kernel.org Signed-off-by: Josh Poimboeuf --- tools/objtool/klp-diff.c | 23 +++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/tools/objtool/klp-diff.c b/tools/objtool/klp-diff.c index d94632e..9ff65b0 100644 --- a/tools/objtool/klp-diff.c +++ b/tools/objtool/klp-diff.c @@ -1334,18 +1334,18 @@ static bool should_keep_special_sym(struct elf *elf= , struct symbol *sym) * be applied after static branch/call init, resulting in code corruption. * * Validate a special section entry to avoid that. Note that an inert - * tracepoint is harmless enough, in that case just skip the entry and pri= nt a - * warning. Otherwise, return an error. + * tracepoint or pr_debug() is harmless enough, in that case just skip the + * entry and print a warning. Otherwise, return an error. * - * This is only a temporary limitation which will be fixed when livepatch = adds - * support for submodules: fully self-contained modules which are embedded= in - * the top-level livepatch module's data and which can be loaded on demand= when - * their corresponding to-be-patched module gets loaded. Then klp relocs = can - * be retired. + * TODO: This is only a temporary limitation which will be fixed when live= patch + * adds support for submodules: fully self-contained modules which are emb= edded + * in the top-level livepatch module's data and which can be loaded on dem= and + * when their corresponding to-be-patched module gets loaded. Then klp re= locs + * can be retired. * * Return: * -1: error: validation failed - * 1: warning: tracepoint skipped + * 1: warning: disabled tracepoint or pr_debug() * 0: success */ static int validate_special_section_klp_reloc(struct elfs *e, struct symbo= l *sym) @@ -1403,6 +1403,13 @@ static int validate_special_section_klp_reloc(struct= elfs *e, struct symbol *sym continue; } =20 + if (strstr(reloc->sym->name, "__UNIQUE_ID_ddebug_")) { + WARN("%s: disabling unsupported pr_debug()", + code_sym->name); + ret =3D 1; + continue; + } + ERROR("%s+0x%lx: unsupported static branch key %s. Use static_key_enab= led() instead", code_sym->name, code_offset, reloc->sym->name); return -1;