From nobody Mon Dec 1 22:05:11 2025 Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazon11013023.outbound.protection.outlook.com [40.93.196.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0772426CE2D; Sun, 30 Nov 2025 10:14:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.196.23 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764497662; cv=fail; b=Ay75we9703O9FjLXMQ+8c8/kX/AZ31iv9UzdejpJvnkf8cI7MBh7PU3Tyk6zlgGK2eAAvUDxoEwJKnuTTKLa8RSRnS8dFee2tEd1FbEvd3PL9wPBFlftJmmD6Q7Ap31CB1kQhXFZbpPoCNSnJChMNYB+VZcBidN0xSvP7QcghJw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764497662; c=relaxed/simple; bh=/mKm2eioAZaGPFc6j9NE6Vx4sivv/R8pnoqfbO5S64Y=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=HdWuFJPcHmyP8kxDwTluuBzejqc7pxb5tnUqsXiaf6WVpv5EutdNr6fHJdxrAULz/CZn6S2sql0PtJz7Cj4mtx9BmECwCY1qYDwZ8Ayr1fpnnJ5tJZIyv172p5F4vbyZ4l1M+Y3UxCzME6ueqVe5mteU6h9Lx+TIouh6l5aIbVI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=X2FIx+4d; arc=fail smtp.client-ip=40.93.196.23 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="X2FIx+4d" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KqYfLq1sfwBGdny6YSoGYt3I5CGr28D7OISboKW3lvGv6IbVaWpDXaoZlT7vkhbBurhOfYNQkZdgkoE+bh+AgZCaUcRWeFf/3rXp5zKgZK2rzkKZ6r7TgnTyn3NWR5IYgYsIX8a+kO3EaLmu2+PHRjR9jE2QltT5hoXiqvQ/19G+a0akMYwSX8rzlDyhg4EeSICFk7A04AnKrHI3dGi/ErYM7EhBgwn6cG8kopbK76wIaVU6ZPbLcrJNYKXqRseatnd1ojKMTR8ryBbgSiLqJA3dEwShtVtBN+eZIe+KugX64lYYlIO8hYZ7aXaHiZlo90gA7draXcwlDq2AivQFHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1I/XDqHC9KiFCT3vfFy1JHesJ01f4oV200WWWA8S+MU=; b=Iw4xCY+ruZzHADTAJPn2MCR50tSvj1UIPNJNZVQOxDQkffpZ0ofd+rhqAl3aGMPvFbP5CBPbAmV9D0WHo7pqhDcv8wez2OhNTlhUKgjOccZdBv5z9Qxnd/qoKfGzyYuXC7VnZzfZBvHjYJVRPVSbEmO09eNV3ez3lJRkkxlWeWxdRgJ4087ZAylPiDYvZwJnAisB6ETn07VIe4Yjz0dd6BD4irQ1cwYIFmWsJbJSKJF1HHhzSTYDf/SRJkdT7olVvBcOG5woW+bB9mM3InBNuG2ixjUnC6Aph+GUv5mRZXLbRaTmqwZxHB80/bMbihciczJ8Mml78TsiFUPdHHKrog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1I/XDqHC9KiFCT3vfFy1JHesJ01f4oV200WWWA8S+MU=; b=X2FIx+4do92KlStmpAZvea5gS/Ch/4ltLAi0VLR23mWfgF1w0RW8da9wqvSeH7XZoc9ZLRmnRWFvn//AJdJm1NIdeIsCeFrls5aFMKY5hBJehyXRCqbO7tKgTta5NgmXAd+SqrYdrwYgDQVAOkSj/Iv8LKePLtkqWOV3PLn7eq313Jr2yqsOr5HMZ4tOPbmMLU4C462aa5K2O4bE7/oSk8Z89qHqWIarhJSDXK1JzjyiShopcAkKc6Jpv/Y6rR34Az7kWQyPGDXZ/gOFSL+D9gA/gEAnoe0z4bJdAN7P+5uj2XoIVmIf9mGoi4rl3m2IJjckkBr3yWhreGBaa0CSXA== Received: from BN0PR04CA0173.namprd04.prod.outlook.com (2603:10b6:408:eb::28) by PH7PR12MB9176.namprd12.prod.outlook.com (2603:10b6:510:2e9::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.17; Sun, 30 Nov 2025 10:14:15 +0000 Received: from BN1PEPF0000468B.namprd05.prod.outlook.com (2603:10b6:408:eb:cafe::37) by BN0PR04CA0173.outlook.office365.com (2603:10b6:408:eb::28) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9366.17 via Frontend Transport; Sun, 30 Nov 2025 10:14:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BN1PEPF0000468B.mail.protection.outlook.com (10.167.243.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.8 via Frontend Transport; Sun, 30 Nov 2025 10:14:14 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 30 Nov 2025 02:14:03 -0800 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 30 Nov 2025 02:14:03 -0800 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Sun, 30 Nov 2025 02:13:56 -0800 From: Tariq Toukan To: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" CC: Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Mark Bloch , "Alexei Starovoitov" , Daniel Borkmann , "Jesper Dangaard Brouer" , John Fastabend , , , , , Gal Pressman , Moshe Shemesh , Dragos Tatulea , William Tu , Subject: [PATCH net-next V2 1/2] net/mlx5e: Update XDP features in switch channels Date: Sun, 30 Nov 2025 12:13:36 +0200 Message-ID: <1764497617-1326331-2-git-send-email-tariqt@nvidia.com> X-Mailer: git-send-email 2.8.0 In-Reply-To: <1764497617-1326331-1-git-send-email-tariqt@nvidia.com> References: <1764497617-1326331-1-git-send-email-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN1PEPF0000468B:EE_|PH7PR12MB9176:EE_ X-MS-Office365-Filtering-Correlation-Id: 6c722284-2720-4921-6b35-08de2ff936f0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|376014|7416014|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?4H3pjZqNcIpVJ7ppR/SB8tGSN8i9Ouy3mnRJ7XCQY0AanfQxm6Z+bYbN35dl?= =?us-ascii?Q?Epg3yDTi8P+soOGqASOoDOpDWDI0wcja6mMw8hdMEoviRDigsyAMv9a81FdI?= =?us-ascii?Q?ZV6TVlhlyozWx3WdvyyJCNtnbN3WF93gPl/nGlLIUwFtd+KCPWCq9A+qMR6P?= =?us-ascii?Q?ZDLkW5FdI1PinrLvuJStcIOJ90Fnv/EV4jP2UJfRXAjmXxkNJuHKlnkwX5TQ?= =?us-ascii?Q?hmQLorHBzXEpwU1J0u3NQksQY5ss8k/lmCUnS6nlLYiMCKfNB7AR1jAzpNaM?= =?us-ascii?Q?fi1b2r/9CW4P6SeSrIcLw4efPCa6o0AaThihIqzVBrSdH/1BsEznm2VjM4Pc?= =?us-ascii?Q?YPrbYt4f/EmBQpKdteM/othVtcgiJJZcqbTfwi7F0xYBCEPGQ6nBTwz7srOY?= =?us-ascii?Q?C/8VFa9ueJSdc2C4JwdbxHC3mtaEcdB3AxPx8DhD2MfKQKoIRKYpLIyfmoUw?= =?us-ascii?Q?PF2nRXoE/XCTKaQQS2al8Ie/B12j0AzIPgMLYZxOJI4enDhB7xchv9dBM2SA?= =?us-ascii?Q?K3pgwR0AiE/6ZEgvisg11apg+hgqfeFZcBNg/3umc/K54Vb8LnuCAc7sVSxE?= =?us-ascii?Q?uoMP8dkxRqxKqpm2V9UF+qCF9qKZt6xOvjxSuq4qb2xOjk5ms1IGZH9DBdHC?= =?us-ascii?Q?ZBieQBkSJYROCRvxA8fspjx+TqQqaPfA1la61RzqF8zkTF0WyxvUZ1hEDXTc?= =?us-ascii?Q?e6+mJTC6Yxkmd2/w3F2SnZELXB9m/kj89iUKipaC7uWnin8jcZ1D4C15X0a+?= =?us-ascii?Q?FmFjvvpRDgtN9tjh6No6skLiePfc3xUnR9DemVMfTAfq3eXhVgQmCK4KEkzc?= =?us-ascii?Q?exzTSaufGOOgoC9TcNAfjEULzqFfeNyAzMIZRJYyxmvKYcpC8xvQGf9hR4Hi?= =?us-ascii?Q?r4tJ2Fs9XBmi/uYyBqIiXd/yeUv8v41oNxnmbX4DxhfkQCnc/KLRZ4+nJub8?= =?us-ascii?Q?5Pbv/LznL7XsKKEOomsd+TS5yvFj2XAiCXKI0RmrRrOjsAoV3VBorkJcNPh7?= =?us-ascii?Q?SQNWge2qssQEnvWxdQZfcmfWZAqhIv+5z4BfBBK5Z02h/fXr9gyDmaHT5P8D?= =?us-ascii?Q?45AfzNZfYGcOILSSW7dMakGhL07s/Cv/GD66MdNBRhEPKOgqGW1xzMJW66LK?= =?us-ascii?Q?qwQf6B7UQ5XFQF38bc9GY1GP2K3/gzYuRm9K4nnSFgNhZzDEXrdxH4abkZgl?= =?us-ascii?Q?mT1FZuyzKxaea4HMYzuNkYXyfgcfLtxubcdXPWfA5Fq2O0JEbcohAJOm3wEi?= =?us-ascii?Q?EO2+lhXdiNVgV5zp3YjH1/6SKd6wgaCdAC5fax7YfUgMsPNHfyv32aQcexZM?= =?us-ascii?Q?fz3f786RKQ+W2Jqr1VjsUiUEho4FLZOhZaykERjh/OPYK1ZE/WUSwJ2YA9zZ?= =?us-ascii?Q?qbODjXpvpFEVi9oSsM4aSdR7ndwvZ3B8uS1slBtZA+5B1SIO7fOhYu5zg/ai?= =?us-ascii?Q?6VHWAZNEYPqmI9ASmbO+Immcv9dgReBSpNTsPOJRsuUrqUILG+rsFxGyp+TP?= =?us-ascii?Q?noeBvHI3YTPlX39RQ8AfnQlpQVrBXHJpioIWZrCkSnUKfvkCMALkVCaJZfCv?= =?us-ascii?Q?5wacCq3pfURCnmRF/tM=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(376014)(7416014)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2025 10:14:14.6336 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6c722284-2720-4921-6b35-08de2ff936f0 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN1PEPF0000468B.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB9176 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The XDP features state might depend of the state of other features, like HW-LRO / HW-GRO. In general, move the re-evaluation announcement of the XDP features (xdp_set_features_flag_locked) into the flow where configuration gets changed. There's no point in updating them elsewhere. This is a more appropriate place, as this modifies the announced features while channels are inactive, which avoids the small interval between channel activation and the proper setting of the XDP features. Signed-off-by: Tariq Toukan Reviewed-by: Dragos Tatulea Reviewed-by: William Tu --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 +- .../net/ethernet/mellanox/mlx5/core/en_ethtool.c | 10 +--------- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 13 ++++++------- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 +- 4 files changed, 9 insertions(+), 18 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en.h b/drivers/net/eth= ernet/mellanox/mlx5/core/en.h index 3ada7c16adfb..811178d8976c 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en.h +++ b/drivers/net/ethernet/mellanox/mlx5/core/en.h @@ -1249,7 +1249,7 @@ void mlx5e_netdev_attach_nic_profile(struct mlx5e_pri= v *priv); void mlx5e_set_netdev_mtu_boundaries(struct mlx5e_priv *priv); void mlx5e_build_nic_params(struct mlx5e_priv *priv, struct mlx5e_xsk *xsk= , u16 mtu); =20 -void mlx5e_set_xdp_feature(struct net_device *netdev); +void mlx5e_set_xdp_feature(struct mlx5e_priv *priv); netdev_features_t mlx5e_features_check(struct sk_buff *skb, struct net_device *netdev, netdev_features_t features); diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c b/drivers= /net/ethernet/mellanox/mlx5/core/en_ethtool.c index fe67c73849f9..d3fef1e7e2f7 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c @@ -2294,7 +2294,6 @@ static int set_pflag_rx_striding_rq(struct net_device= *netdev, bool enable) struct mlx5e_priv *priv =3D netdev_priv(netdev); struct mlx5_core_dev *mdev =3D priv->mdev; struct mlx5e_params new_params; - int err; =20 if (enable) { /* Checking the regular RQ here; mlx5e_validate_xsk_param called @@ -2315,14 +2314,7 @@ static int set_pflag_rx_striding_rq(struct net_devic= e *netdev, bool enable) MLX5E_SET_PFLAG(&new_params, MLX5E_PFLAG_RX_STRIDING_RQ, enable); mlx5e_set_rq_type(mdev, &new_params); =20 - err =3D mlx5e_safe_switch_params(priv, &new_params, NULL, NULL, true); - if (err) - return err; - - /* update XDP supported features */ - mlx5e_set_xdp_feature(netdev); - - return 0; + return mlx5e_safe_switch_params(priv, &new_params, NULL, NULL, true); } =20 static int set_pflag_rx_no_csum_complete(struct net_device *netdev, bool e= nable) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/ne= t/ethernet/mellanox/mlx5/core/en_main.c index e537df670758..f0f2bc7f317d 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c @@ -3365,6 +3365,7 @@ static int mlx5e_switch_priv_params(struct mlx5e_priv= *priv, } } =20 + mlx5e_set_xdp_feature(priv); return 0; } =20 @@ -3396,6 +3397,7 @@ static int mlx5e_switch_priv_channels(struct mlx5e_pr= iv *priv, } } =20 + mlx5e_set_xdp_feature(priv); if (!MLX5_CAP_GEN(priv->mdev, tis_tir_td_order)) mlx5e_close_channels(old_chs); priv->profile->update_rx(priv); @@ -4409,10 +4411,10 @@ static int mlx5e_handle_feature(struct net_device *= netdev, return 0; } =20 -void mlx5e_set_xdp_feature(struct net_device *netdev) +void mlx5e_set_xdp_feature(struct mlx5e_priv *priv) { - struct mlx5e_priv *priv =3D netdev_priv(netdev); struct mlx5e_params *params =3D &priv->channels.params; + struct net_device *netdev =3D priv->netdev; xdp_features_t val; =20 if (!netdev->netdev_ops->ndo_bpf || @@ -4461,9 +4463,6 @@ int mlx5e_set_features(struct net_device *netdev, net= dev_features_t features) return -EINVAL; } =20 - /* update XDP supported features */ - mlx5e_set_xdp_feature(netdev); - return 0; } =20 @@ -5859,7 +5858,7 @@ static void mlx5e_build_nic_netdev(struct net_device = *netdev) netdev->netmem_tx =3D true; =20 netif_set_tso_max_size(netdev, GSO_MAX_SIZE); - mlx5e_set_xdp_feature(netdev); + mlx5e_set_xdp_feature(priv); mlx5e_set_netdev_dev_addr(netdev); mlx5e_macsec_build_netdev(priv); mlx5e_ipsec_build_netdev(priv); @@ -5957,7 +5956,7 @@ static int mlx5e_nic_init(struct mlx5_core_dev *mdev, =20 mlx5e_psp_register(priv); /* update XDP supported features */ - mlx5e_set_xdp_feature(netdev); + mlx5e_set_xdp_feature(priv); =20 if (take_rtnl) rtnl_unlock(); diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c b/drivers/net= /ethernet/mellanox/mlx5/core/en_rep.c index 0335ca8277ef..ee9595109649 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c @@ -867,7 +867,7 @@ static void mlx5e_build_rep_params(struct net_device *n= etdev) if (take_rtnl) rtnl_lock(); /* update XDP supported features */ - mlx5e_set_xdp_feature(netdev); + mlx5e_set_xdp_feature(priv); if (take_rtnl) rtnl_unlock(); =20 --=20 2.31.1 From nobody Mon Dec 1 22:05:11 2025 Received: from CY7PR03CU001.outbound.protection.outlook.com (mail-westcentralusazon11010067.outbound.protection.outlook.com [40.93.198.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C048327703E; Sun, 30 Nov 2025 10:14:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.198.67 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764497666; cv=fail; b=X3FzPoRr8cAdeJQISNNtObcRqcqQQdW/qobkB2NzTsOfHHj0Cy08GWtn7PWiWdFr34F1Ppw5z2IQMOdsCB0AbuWArUj7f04ABHy87vceleEOsgj7/Sm7bTHIuhpYqEmOmlbCeIiEexbIWtUmycmafwWYqE4EcMuY+yuXfGwGVYk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764497666; c=relaxed/simple; bh=SMaSljIRIP2ohkAjE1YVYPmYohA1Kdeyh26ZnGKDboI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YuWodEMxu1akLpJgXVeiZKYW3QYX/V3yJ3/5+FREcIeD3GIxNqBRj/X5KzzQ1qTWg6pDgdndNOwc63RJsQkyRzUc2fuAD//kx3Sxk2Q4d+b2XsN6eZ2ONPcqaAflNBSiUvU0QCKU0ypEHy0iO59Y9d6K/O7SpKjbf1sLfZr61qA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=AAnPtFOj; arc=fail smtp.client-ip=40.93.198.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="AAnPtFOj" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=A/ygrOdzmp8qrSB5XveAPvm1eOem8fklRJUHTHImH3OvPE2m8AANCtvd/riDT9wk4TF++wJgiCoOghTsS2eM5no/TA10y702lCXR6Go+vQjSWpsFPZpOuskfDqsrCDBXsG74UwjvMt3djpr2cdBZP3P8AylkizU/M0qbmKldRnZ1WhxhDXuYVEPyrjjxIr/L81wX6PySWBd1GVU8m8G3wH5/tVuhzEhtTL75u6Tj4zKVqJphVVxmFyfDdV4nlO+hG9CmfgGzCyca7vD2F8MvpzqsK9Gb1WggggHGCZLJoZI8m8Yk/v6oQsXhJKKRMh7oXIbBS62keIjKz7Vx7OUviQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=34hoFB5JLXoeR7t7uQFfZq8sojaobUCjChScObJXkjo=; b=TO8QaqwZk/vlJPVsDud7ZFf9rAADcT+hnPFCX5dYuimrhPpMpH0AtsV/E1A/cTRPiYiG1xbINt2rqrATpfJnImygmB9SI1BA2CLoEEUvmKUSeJyqr+XUk5a0S5c5yNmkSpcdBj8bNZQY40pKIo+FBtHAEwYbSIhe7OMZUcV7ji1HsvTCp1x8INXkfWbmUTNLWd9OEGWSSQZBeuQIuJdTNa/b8ojmYp4ie7g6YVTQ+uj6uo7siCKduFMUhmB6JmhP7+bN37gI/IrLfl/hPcGOw+14bSb++9G7MwTC5qj99wr4PWZTbYTwQcJ6l9AvzA0T4asw6ocS7P9Gt7r6Gf0XWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=34hoFB5JLXoeR7t7uQFfZq8sojaobUCjChScObJXkjo=; b=AAnPtFOjFCSw2SgQMzsOdLeOs5jN7xeRqrURZnjQZ2TtCVgi+pUQZAKvjSpJ3zhGBqXf6ysf9oK8JVFQMk2r1Tgjdk7vQ6g+8f7F3fEzSyIQsA9rRILSQWC/jKezOV+lAiqsgF2pRfcs3XQisqzG7uimpTKuz0HVGRhuvOMIoTGrBgQqOD1MBjzAUAuSF351VJ9NJfoyCtCPgAsd9TBdfFtQQLULJ17IQIMRUrW08bk6k1s1UkaQIdiM6qTBsbjxX3KxDwNlNk5r/Ig8PgMtPHeAldAMM5jOjzpYqxG1NLjW4Qyt4i/nNUXffg8kzbsSmxsgtnNbBKGw6HB5Vc1fFg== Received: from BYAPR02CA0003.namprd02.prod.outlook.com (2603:10b6:a02:ee::16) by MN2PR12MB4253.namprd12.prod.outlook.com (2603:10b6:208:1de::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.17; Sun, 30 Nov 2025 10:14:21 +0000 Received: from SJ5PEPF00000207.namprd05.prod.outlook.com (2603:10b6:a02:ee:cafe::ce) by BYAPR02CA0003.outlook.office365.com (2603:10b6:a02:ee::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9366.17 via Frontend Transport; Sun, 30 Nov 2025 10:14:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SJ5PEPF00000207.mail.protection.outlook.com (10.167.244.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.8 via Frontend Transport; Sun, 30 Nov 2025 10:14:21 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 30 Nov 2025 02:14:10 -0800 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 30 Nov 2025 02:14:10 -0800 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Sun, 30 Nov 2025 02:14:03 -0800 From: Tariq Toukan To: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" CC: Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Mark Bloch , "Alexei Starovoitov" , Daniel Borkmann , "Jesper Dangaard Brouer" , John Fastabend , , , , , Gal Pressman , Moshe Shemesh , Dragos Tatulea , William Tu , Subject: [PATCH net-next V2 2/2] net/mlx5e: Support XDP target xmit with dummy program Date: Sun, 30 Nov 2025 12:13:37 +0200 Message-ID: <1764497617-1326331-3-git-send-email-tariqt@nvidia.com> X-Mailer: git-send-email 2.8.0 In-Reply-To: <1764497617-1326331-1-git-send-email-tariqt@nvidia.com> References: <1764497617-1326331-1-git-send-email-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF00000207:EE_|MN2PR12MB4253:EE_ X-MS-Office365-Filtering-Correlation-Id: 9ba6384d-8114-45df-2e6f-08de2ff93acf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700013|376014|7416014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?DVvlTKLpFdXB2keiyF0nZU+U0xoW13S1B2GSyuMbhE3tNNckAEpZEMXPbvEs?= =?us-ascii?Q?DVIKTNgXSWJ+2fOoQn1bWiNfabthgJUM4DSqSe5c63Dc3U/yqdHa1PxavmFd?= =?us-ascii?Q?2g9QDzylQYU7fMH4FaWUgOb9s57wu3BE8Kz/3R+Lgg0yrdFvwHVI2ai+zsYU?= =?us-ascii?Q?ePcM1nI6p8QcYh04hkPx4VxmVh//iVvvRzj8Sz4SuczzEB8dCf70p/sixfnm?= =?us-ascii?Q?TCPd5idXXchHRcGmFT2GPWkZ9fqG5OB+xk5ewR6Fz2GPCuImI/YrC+y+L0i9?= =?us-ascii?Q?7ZaAq+/jcssyajswSJGAesadAfLPnGkismt+0OTSEqHh9EFmCnmsADl8XKQw?= =?us-ascii?Q?+qxj/49MQX78jtJF56XUe1jaoGXeJEUMMi3Q5EiYAVUO7aosVncCDvzjDM8h?= =?us-ascii?Q?l4064wxLSqf9syxdytIhY1dPOubKycVtSL13YNBvtVAqRACAR3IudC/eCzYI?= =?us-ascii?Q?y0LxH0JVFv06D1AIRiNesrIY7SkObPOpCl8nW6Ub54VekOzIlL3xmxDA/rc4?= =?us-ascii?Q?6l5tbHfn3k8IfjWuWdx8aGBX3o/FyD7jMR/otQ4aRby/pPEdFJs1CVPCHFPy?= =?us-ascii?Q?cHt3uI1qByDGVPlbu5XibwhhguNuG1ILPqFA/YqL8/aMS/Yefi1UJNvJfs9h?= =?us-ascii?Q?Qb+GarfIEM4HIGeuvfTPz7K2fjgPc6YmZpb5DWbXhZ4wP7joMyIh8JbQZAhZ?= =?us-ascii?Q?9GuzOzEreILBbx4uYrHVm0dGEUz6rpsXgOr0il0M+NV407PKdenQnh/lWEFb?= =?us-ascii?Q?h0CitjozDTHuR0TUwkuIwFkP+JgpYqhJXWDkDmqReDmtWw9SQC15MJHWxVw+?= =?us-ascii?Q?beII7zYwOxjaJoQdNyU5q++/ADvEGnkMgCG/wddECtFq+j+h7HBD3heU+WDj?= =?us-ascii?Q?JoGs14EsxRptv/k9D7Sg8IRL5ve5FoeyvGbt3f/3fFX/gzqOex4qqk8hh2ne?= =?us-ascii?Q?Ve0GtliDX7pA7mBUWNzj3Z28I7KSDGRy9f/bZLalC2UOl+VN9+Ap2KF5YvEj?= =?us-ascii?Q?Tgfyo7dwBUwr1TjByNdcqWX4K2VQOskcxzCSLT6hmNV1xzPth/QYnaNJBAZd?= =?us-ascii?Q?n/2upAuwPZwFRD6jvFtzo45so0YSRlUMyHuxOL+S31gxOOWef8z1cSzIMCnv?= =?us-ascii?Q?4rVyDk0MM2TSXgS+ZlUmcjFNqLPwcZ3lhHolEKHd0tYoKppmGlvb1+eSysdW?= =?us-ascii?Q?RvUWqJckgCeuS7m33npJWPiKt2tAr6axQ2wsPI6Nl/xWhudYJCG8kST96cxQ?= =?us-ascii?Q?xfDty7WOmY2ojihQ6rysPr/fOMvVT1OKWGboAc6H6ZgK3Ukw7q8qbhxuQvvC?= =?us-ascii?Q?6rY9RYtJ9nRt+RhQhhsHfC/+ziccE+KXWszjjaeTHYMnd+HN607SdeaUuxvj?= =?us-ascii?Q?MCycJcACR0kFKsWujS3UK06dP4JLvs4uSqGiN8cOYfqxCEx51z2ooPgMpj+b?= =?us-ascii?Q?cvoFFEoo3ynQVvwRuFr7R6a4bwRzyMxIpjtsMelS5EX7+9AEyNiIxJ7CIesh?= =?us-ascii?Q?eA8+PO1/3NBqU6TGjaEX/JALue2ZeVxbCX+KHv0jORUVqBH6/v7+4KCjghz0?= =?us-ascii?Q?MyQV+RZAlxqWaFyPjiM=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(36860700013)(376014)(7416014)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2025 10:14:21.2911 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9ba6384d-8114-45df-2e6f-08de2ff93acf X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF00000207.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4253 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Save per-channel resources in default, in device and host memory. As no better API exist, make the XDP-redirect-target SQ available by loading a dummy XDP program. This improves the latency of interface up/down operations when feature is disabled. Perf numbers: NIC: Connect-X7. Setup: 248 channels, default mtu and rx/tx ring sizes. Interface up + down: Before: 2.246 secs After: 1.798 secs (-0.448 sec) Saves ~1.8 msec per channel. Signed-off-by: Tariq Toukan Reviewed-by: Dragos Tatulea Reviewed-by: William Tu --- .../net/ethernet/mellanox/mlx5/core/en_main.c | 23 +++++++++---------- 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/ne= t/ethernet/mellanox/mlx5/core/en_main.c index f0f2bc7f317d..6168f0814414 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c @@ -2612,7 +2612,7 @@ static int mlx5e_open_queues(struct mlx5e_channel *c, if (err) goto err_close_icosq_cq; =20 - if (netdev_ops->ndo_xdp_xmit) { + if (netdev_ops->ndo_xdp_xmit && c->xdp) { c->xdpsq =3D mlx5e_open_xdpredirect_sq(c, params, cparam, &ccp); if (IS_ERR(c->xdpsq)) { err =3D PTR_ERR(c->xdpsq); @@ -4415,19 +4415,18 @@ void mlx5e_set_xdp_feature(struct mlx5e_priv *priv) { struct mlx5e_params *params =3D &priv->channels.params; struct net_device *netdev =3D priv->netdev; - xdp_features_t val; + xdp_features_t val =3D 0; =20 - if (!netdev->netdev_ops->ndo_bpf || - params->packet_merge.type !=3D MLX5E_PACKET_MERGE_NONE) { - xdp_set_features_flag_locked(netdev, 0); - return; - } + if (netdev->netdev_ops->ndo_bpf && + params->packet_merge.type =3D=3D MLX5E_PACKET_MERGE_NONE) + val =3D NETDEV_XDP_ACT_BASIC | NETDEV_XDP_ACT_REDIRECT | + NETDEV_XDP_ACT_XSK_ZEROCOPY | + NETDEV_XDP_ACT_RX_SG; + + if (netdev->netdev_ops->ndo_xdp_xmit && params->xdp_prog) + val |=3D NETDEV_XDP_ACT_NDO_XMIT | + NETDEV_XDP_ACT_NDO_XMIT_SG; =20 - val =3D NETDEV_XDP_ACT_BASIC | NETDEV_XDP_ACT_REDIRECT | - NETDEV_XDP_ACT_XSK_ZEROCOPY | - NETDEV_XDP_ACT_RX_SG | - NETDEV_XDP_ACT_NDO_XMIT | - NETDEV_XDP_ACT_NDO_XMIT_SG; xdp_set_features_flag_locked(netdev, val); } =20 --=20 2.31.1