From nobody Sun Feb 8 22:05:41 2026 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EB971A5B91 for ; Fri, 7 Mar 2025 08:41:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741336916; cv=none; b=sema2a2LQgW8cHHIra8JG6ZQWBIMrL7VwQ//TvunPyxdkNRiMrjbapC3Vzx6IxEMUQ6sejtvmiU+KYA/L5RYvBi8sfdIBrya8TuAslM7M9MLYS5DAWHkWTgDIHxsQHSiCDNqRuSuxfHz1gM6k11HzTe6J6jK5xzAIjvrmpogeuY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741336916; c=relaxed/simple; bh=a8OMihBwCzHSd0Lvzlm95VVhIx7Ja/KJZMqjMUoCLBc=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=GIYwS52v+IERugvK4RmT4OJsQpsT6NVs54zXHbPw9phXGollmUm2dPDRd+VgZMQOCaBHloi31VxKC2cO6hDbbM33HsgBgHDlSdzH+Pxy2AXG1AcCPLp3XTpYlPLfrrg+uYm1mxCk5Xm9hNnwEPPk/TGz9aGEQtOLg5wukf8zItk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=jrvDyhFs; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jrvDyhFs" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-43bdc607c16so12200105e9.1 for ; Fri, 07 Mar 2025 00:41:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741336913; x=1741941713; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=61P5O7FM4Ars9KAhbX4e1GUUuxK+iGoXonO6kXuEFR8=; b=jrvDyhFsQEcIS2z5qBEjFxNWGdd3/Qpm7Q8StKbUwg3x+sSO9QovCEKZRvxc6t6OvH qxu24OskFN+DnQfK9L1Y6sxoUPimqiYuVr5EhY25w5/KH0szeQ/9mywq59KMaHDtzR0U Bm49OxAGp2izKSjC46AdIDkonL0BqMjSeKMtww+TENgCWwH2/w7pdWlJA6bm6vjJ0H56 igK4Kt//SIRKmLK+vzlXpx7snp9Mub1xYB8Mqwz0kZ42ZsSycid8emgOLlj7DLdEkw3P 4U2LU3wOdmbNWWFj5fqPUTFoPTWcMDAKJ8a5TEzdDsDuye55mU+V5rnawFLwPVxq67k9 H1Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741336913; x=1741941713; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=61P5O7FM4Ars9KAhbX4e1GUUuxK+iGoXonO6kXuEFR8=; b=i0Zb8MnzdTyASIC4vjcctuV9GMkowUlDDPuzb/hZ3nipqLHLU4VQzrrGGBSkCBzKWD kN3DJfPTOd4kRmXQ7t64/T7S7ERhe6iWZNJEXn1n3LW2yACZp88kBD36vmCVYt23Qr4P hmqmr9aMh9wSCkdS7CYnqio0JbcFWKQ2ClZz3NY37qyfgBAli+5Bq+9Ekugb0fh9XdKl 3Lu/kp2GTK8ja336+Ud2pz3fmcDZ/jhlJ2w3eU2c8OTyVFYt7t2uhdcLoKDAlL7K5c+H 9xHdOkgCNoBMFmXAQcDhv2sSD6xXg94X2tm/3Lzg/n7uskRd/mrGtjR90byt8uM4USaJ tkXg== X-Forwarded-Encrypted: i=1; AJvYcCVD7hBvVHF15Sdnh1z/0h0m2a63bOEdxJNT0XL2S0GDEImAez5JyYTYALiCeaTiuR3wx33g0NMfSwtxinE=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0zX7QES+osTPUkqDbhS3rrdNIpjyi3Ag53KZ8AvaLQUpxKDwb i0uEa7iIIiSRYi2LkWkAnsdZJLy8ZUwJ7raludwulzHee65n3mdwegSCMhSfOfE= X-Gm-Gg: ASbGncupmMR8+8cE0+ylzMFNCXktZu9uGlRPaFCtlkBe/mcZpvff525ldSETd8eI4O0 QgBjrLxG6dCax011j1giMimAJ5DXTZs4fekzLEmAKrvIL10CmfJHTIUj/18Io5LmMGfkFbtbPBF c1xUIScNt8PMeiaYaPrp9+jkwSTlH2Y9UeAaUiI8SPV7BK0niuOhdGuAk6KmW7HEsel0Oq7CupE EBFvV4qV71fEdKmCGQcHGgONDfS9h/umxAsV/n7Ieiy4gCouIUzwWpYnjWl0PL1kVYAkb85YVZN vnahCaxO87hWmBXDk59yK2ptYj4cBZrf/04QRzl1HxEuJSkTIA== X-Google-Smtp-Source: AGHT+IGbfL4bBdca2EaHCrCPhox+++ms3htL1SxrfFW81lxG6BAaIMYQupukozaB6u/ZExtXcwAGFg== X-Received: by 2002:a05:600c:4f87:b0:43b:d025:76a6 with SMTP id 5b1f17b1804b1-43c5a60a0edmr17752515e9.15.1741336912663; Fri, 07 Mar 2025 00:41:52 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3912c10437dsm4722937f8f.99.2025.03.07.00.41.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Mar 2025 00:41:52 -0800 (PST) Date: Fri, 7 Mar 2025 11:41:48 +0300 From: Dan Carpenter To: Jeff Hugo Cc: Carl Vanderlip , Oded Gabbay , Jacek Lawrynowicz , Pranjal Ramajor Asha Kanojiya , Stanislaw Gruszka , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH v2] accel/qaic: Fix integer overflow in qaic_validate_req() Message-ID: <176388fa-40fe-4cb4-9aeb-2c91c22130bd@stanley.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" These are u64 variables that come from the user via qaic_attach_slice_bo_ioctl(). Use check_add_overflow() to ensure that the math doesn't have an integer wrapping bug. Cc: stable@vger.kernel.org Fixes: ff13be830333 ("accel/qaic: Add datapath") Signed-off-by: Dan Carpenter Reviewed-by: Jeff Hugo --- v2: use check_add_overflow() instead of open coding a check drivers/accel/qaic/qaic_data.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/accel/qaic/qaic_data.c b/drivers/accel/qaic/qaic_data.c index c20eb63750f5..631e401fbe4a 100644 --- a/drivers/accel/qaic/qaic_data.c +++ b/drivers/accel/qaic/qaic_data.c @@ -554,6 +554,7 @@ static bool invalid_sem(struct qaic_sem *sem) static int qaic_validate_req(struct qaic_device *qdev, struct qaic_attach_= slice_entry *slice_ent, u32 count, u64 total_size) { + u64 total; int i; =20 for (i =3D 0; i < count; i++) { @@ -563,7 +564,8 @@ static int qaic_validate_req(struct qaic_device *qdev, = struct qaic_attach_slice_ invalid_sem(&slice_ent[i].sem2) || invalid_sem(&slice_ent[i].sem3)) return -EINVAL; =20 - if (slice_ent[i].offset + slice_ent[i].size > total_size) + if (check_add_overflow(slice_ent[i].offset, slice_ent[i].size, &total) || + total > total_size) return -EINVAL; } =20 --=20 2.47.2