From nobody Sun Feb 8 02:56:20 2026 Received: from BL2PR02CU003.outbound.protection.outlook.com (mail-eastusazon11011041.outbound.protection.outlook.com [52.101.52.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BFFC2D46A9; Sun, 9 Nov 2025 09:39:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.52.41 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762681143; cv=fail; b=LD7FyK1B6sRjrCsgxR6kLSjvLOXX2PEYbG3Wq81OEnAVWlFl1v2F3a5A8gV9r/M45D2WMtzCb2hDYy8mtbWw+Z2hKmTlbTKK57ih1oORFNb7kJAIjJfiAfFWrIqTnnUefIdfXEhHjFp1Wx0ZajAsxI3FG3BI2G7Odk2IZEuHAxk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762681143; c=relaxed/simple; bh=KKh2cEkP56vqvEkluLx2S1e5G0fnej4SzrtpbEu2qdw=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=OBx/QWZEJ+2qF5zAXms/4m87YUWBOdo4+RZeUbb3KHPwsBHNBiwGJWJRuEzuxRUEmashRH9A4Jd9dV8pWNH7dHaB8CxTdfaazWUjPc6Sso7yrqwPTbV/Q5P9y8irXRKFZcatRYHzM03v5Ocpw3ycQsmIupzQfYOM4ELug8+5E+4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=DHa7D9xk; arc=fail smtp.client-ip=52.101.52.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="DHa7D9xk" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RFvJvJe81n97DnQ9aXO/+Mw/XeKY1pFRSyKXeDP1eQTihcCDLvx/0zQIIi7XJGkqdJRcWuHEWBMeUcwm1L0MPLciINTKb+/KS2p0IyL30SNMaYMok+cGP7R90k06a6n5vXHGbb/TZbKxpJGWpUWDHu9lRtefGTqBfXAeJnmFxcIASiluqMjt+LPw05QUyrOX2YbKU93u7S0FeWQ3QvzG9aNCVDNYDxJuE+PV0ZjJXmEDojP3wE373RUpDkZKFgEEEX4eFFDZz4L5CpQcUOzKin3NxSfaTn3BALxbZTlE6tVxQ+1ACwC1QOLGpK8KeHKeEQ//OVz4DjoekEFWavlIhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h1u4f8vahpPDZYACXYsO6wxWBI3aODBKx1RvjaapLp4=; b=cTxtgvn2FesNBM2e0S8ABUema67CJX3+kLOvdwB/viRSLLUDViVQx/Ux0T3CHWD2EAkAU9168zmbPE3Hx7KAbxz4XIDiYYWilmV9p7ZlVq91rwKWb6ai6smkkBtrDL1eYMxl4LMV06OvPCqX4Fs5QL8553RBhgyq38c5pcs31XysBsSYOHXL+dZlBSC30pyRdZjmfGrKQES6WHIMteaeI5Kf7rPi8vyojtlItFhd+vLgNG00sRFTzjuZVcQXthJHZSQl0fmI4AD260a5RrWvNVvh/7R0duP6Cff+gFMQUYpGLnn9KB9E9vL0r3MsuMUo+bGv0kwtRyxXmdC5a4DBYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h1u4f8vahpPDZYACXYsO6wxWBI3aODBKx1RvjaapLp4=; b=DHa7D9xkZUbuXCZscohAOMD6kLhM8Yx/ZfFWrDcw3HpchH0B2wnXtlv9IzBUHqm25LOLOkl/PN9mmsUDqET7a7XmslE8jbEYgKyb2NHkpxHZ1JV3qpETLDeOidXcDKzqeWNzhkQadhzjApP+c4W5ob+O/upF0ypn6I7NB6e8urPzUhnw5G9OocCMsMYIwLiQa0nVAbGTKm1XYd7gOuNloHxZLVTzZjWiVBSgFCEHf0QbFsj7up+7ZsXe5mRVmgNuHEMmwxxZEt97xkSy6NlbBe1Qk2xMfF1vVsETL5eLvgnOfolSV+Zk1a6CfM94pVJD8a3Rpc2LXPGTix+ueOocxw== Received: from DM6PR11CA0006.namprd11.prod.outlook.com (2603:10b6:5:190::19) by CH2PR12MB4166.namprd12.prod.outlook.com (2603:10b6:610:78::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.7; Sun, 9 Nov 2025 09:38:57 +0000 Received: from CH3PEPF00000013.namprd21.prod.outlook.com (2603:10b6:5:190:cafe::19) by DM6PR11CA0006.outlook.office365.com (2603:10b6:5:190::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9298.16 via Frontend Transport; Sun, 9 Nov 2025 09:39:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CH3PEPF00000013.mail.protection.outlook.com (10.167.244.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.0 via Frontend Transport; Sun, 9 Nov 2025 09:38:57 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 9 Nov 2025 01:38:51 -0800 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 9 Nov 2025 01:38:50 -0800 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Sun, 9 Nov 2025 01:38:46 -0800 From: Tariq Toukan To: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" CC: Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Mark Bloch , , , , Gal Pressman , "Carolina Jubran" Subject: [PATCH net 1/5] net/mlx5e: Fix missing error assignment in mlx5e_xfrm_add_state() Date: Sun, 9 Nov 2025 11:37:49 +0200 Message-ID: <1762681073-1084058-2-git-send-email-tariqt@nvidia.com> X-Mailer: git-send-email 2.8.0 In-Reply-To: <1762681073-1084058-1-git-send-email-tariqt@nvidia.com> References: <1762681073-1084058-1-git-send-email-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000013:EE_|CH2PR12MB4166:EE_ X-MS-Office365-Filtering-Correlation-Id: 2d062675-a316-4664-d9bd-08de1f73ce2c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|376014|36860700013|13003099007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?RdlcLQHdn3Ej4mr+PpfSKD483NqpL4sfcdd/kk8rK17GHXqM/fJb9XNZDp1v?= =?us-ascii?Q?wuKEkXOaB+BmRYC7/pDy4J09axXSE4rDItJDB1vNpsZjuKdSqXCj8bLKh0hw?= =?us-ascii?Q?OGMc9SIxt/kzZ+6kaNRRphTqeDp1+weCri1muIBLW+Xlt1XIepkmZvocJwBW?= =?us-ascii?Q?m/dSvZvrfT2/b30lnCsqqtCpI2/D2iAuteCdjsy5ZEtebM/cV+c6MpfHHrcl?= =?us-ascii?Q?Hv+dOgEVB0tMcZI8W3013GmYKz9a7tyhnNtgozohYjltQIvWtjJw8V8SM//C?= =?us-ascii?Q?4OiAVixzxMF7EASzrFKGDbWBX+dNMUXh7yBvIsXD8SjeXEXI4y8Nc+/s5dyY?= =?us-ascii?Q?iwm6tZsog7rdtM6alR2Mo0NDRuLoxIPOUcNbtTlh9PeKtSsRFP/hu18eBwe1?= =?us-ascii?Q?jqEqhT0pE+Mdpvpwo0GLa33mgkDavcM728xjHZ9mEGI0kFkeIgb3J4QrMMm6?= =?us-ascii?Q?rB2bb3Rgz2RYA+OQfkR7y4+9uxrTQaWQ7jGP9AhIKz1uZzxaa0gFIYhz40vc?= =?us-ascii?Q?VkFvWy0OfzoLaO02EWMUH917IkZtG/7ptUSycj8lvIkT0vRcN0znON+CcYyi?= =?us-ascii?Q?4XKWVplAM2C5ImipKwxTbj8y3Ad1gxJw+keFJOwCIfRmlEdSd3i4DtRFiB9K?= =?us-ascii?Q?ifA3wVxSkF/3nAeUZBWkRW16DrzBXxUwJumxTqPTNd44Yg4k6vslRh1iDZ0g?= =?us-ascii?Q?eRvi9SDKLJQe6u2gEpF8QKRqAM4e6lP+bGgPK8Zj7GA+0FflzkpmawPXBZe9?= =?us-ascii?Q?ruU7KpOfLDnQCWpmZX6KPoHMwwzu4WvAY04xiSaOOommF3Tbi6fXN+iIEyZk?= =?us-ascii?Q?jKdoNlL4FNH9+ZmXRCYOuYxzCYO0VMOMFxa+jhG2SuKBJNwrvmx9VCm4EkVD?= =?us-ascii?Q?biRIHM3t2BWccxH6Tj3ygl46ojJF+sUvymIdSt/2uo/gf8Gjg7W5/V3ShsfC?= =?us-ascii?Q?+uPjZkOLr3vWrCbyJ/E4nHhH6GZrpimbYdRQwgFoaT32/xoSyNB5eJZ78w3Q?= =?us-ascii?Q?GIYae+JvJ2vhsUJyjRqsYbX61lZu9yEPE49CFE9zN66THhF0VczIxdXO2Mxt?= =?us-ascii?Q?pDrxlQ6fcYVjyybDd6Yb8TzO+4JNEnUNKLIJexmB1VR9j+aR76EbwyxCHoPQ?= =?us-ascii?Q?KNifEc4cDa4ZXzyq0iP72z3aNM4HBY+T9BQdii9ofQ5MxhDMyeVb9CFy9M6M?= =?us-ascii?Q?9q0yuiPDAcgT7P39ni064NQHpB11DfrRvoi3n2CjsZWXSWOQe/iUMczXNK3A?= =?us-ascii?Q?GhBIGOZX48pNKUeHQe9ATYpbxooPOCXD8oOh0IIbcXa9Kos05L9kWuhRHQea?= =?us-ascii?Q?4lf+31DEUdTMYn2DhaPK6mRAJsqFcoCzLPlKDvWvWwjThxf1T3BzragnEHKy?= =?us-ascii?Q?MQ1TZ9NvLQXqU+yHptolgtf2jS1L/OqN+BH/vRb6hnv4pykde+WR8YoZBvQU?= =?us-ascii?Q?Ny8uFaqnaehifgMqpdxtbeXzJDGiAAxPeYJU1YUbbXcyHNoSuFgIj6AKDZC1?= =?us-ascii?Q?KbzzosuyL78Lyuwp2W5yDWVffxZT0p2FXtMkfvSbS8qMrH2/NqrYddUfsO9q?= =?us-ascii?Q?eAenZXe+Yw4GFgWXSIL92nF4QYlovM2cyNGL+22w?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(376014)(36860700013)(13003099007);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2025 09:38:57.2416 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2d062675-a316-4664-d9bd-08de1f73ce2c X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000013.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4166 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Carolina Jubran Assign the return value of mlx5_eswitch_block_mode() to 'err' before checking it to avoid returning an uninitialized error code. Fixes: 22239eb258bc ("net/mlx5e: Prevent tunnel reformat when tunnel mode n= ot allowed") Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202510271649.uwsIxD6O-lkp@intel.com/ Closes: http://lore.kernel.org/linux-rdma/aPIEK4rLB586FdDt@stanley.mountain/ Signed-off-by: Carolina Jubran Reviewed-by: Jianbo Liu Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c b/dri= vers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c index 0a4fb8c92268..35d9530037a6 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c @@ -804,7 +804,8 @@ static int mlx5e_xfrm_add_state(struct net_device *dev, goto err_xfrm; } =20 - if (mlx5_eswitch_block_mode(priv->mdev)) + err =3D mlx5_eswitch_block_mode(priv->mdev); + if (err) goto unblock_ipsec; =20 if (x->props.mode =3D=3D XFRM_MODE_TUNNEL && --=20 2.31.1 From nobody Sun Feb 8 02:56:20 2026 Received: from CH4PR04CU002.outbound.protection.outlook.com (mail-northcentralusazon11013037.outbound.protection.outlook.com [40.107.201.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 281AA2D73B1; Sun, 9 Nov 2025 09:39:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.201.37 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762681175; cv=fail; b=eDu1gCFOrzxoMuPJYPeHCtHUTRJfJOsE/YJrqCFQexPLRKvwI/EaKcuUxSMiqbf+ldKxicrch9LNnbY7R43TN569C+kXREoAESkeAopMsi+QRUMH9cYtAA7n2Xml6wHgwVotkoIA03eu0+bfFo/DRoXYi7SApA5xjhU2w2nMdEo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762681175; c=relaxed/simple; bh=F2YBi0oVxOtv0Gt1hvkHDCpUBPwrAwobwGCwVzm0tyw=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fj31wbtX8gC2viFBpelYvP/efik06j4RmEvBCVMETXYy/2KWNTxV4PhNMtuTH8J19hf1MU23JTAJlK19CuEKvTMasb2EksJTSDuj6L5tI1k2XN+9Sa/2V81M/vnmqNYUdydcjz0He6cKvPbaQ/KxWonCnGriWXlLvl7UCUAtmSY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=SLACFqeX; arc=fail smtp.client-ip=40.107.201.37 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="SLACFqeX" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kzEQhM9KxcrCbpeawhT5yQ/wEl6l7G5Vx9hd1BTkZ/YmU4XnbK1WglcCcuP3diivpax51d9ldrYUu6g/4MrnAOWk4HtjDkLaGb5rlupiD+46TtFJEQ0CITz4GgV45qpsOrSgiyyNHvn63RgmYFU3N7D16YOMcbK3TVjOdh+BrcSJHj36cxkr0B5F7RawEIFLP0HHmz9jfPrugDwyBIrbcicqUByZYsTU+X26p78lcegB7SD+lvNKYyG98zYd77SESGT0V9lqlRbOykvoFZD0QG02jBC9IuQPVq34wDBYoS2zGCpRX4AYUB7X1KpKeJzJ/02QSAc/pbsCPy6/dnnuxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S+GgU5WOvCId56ebE6AW88FHdxGveUwY2sMvHw0Ut/4=; b=B98MtoH3YV9ShMHiTuPLVzykcbGtU0K0NCdsylhCCcDEW2nOaifbYmv14HcApAZAXidNS7ZWPkkn7KG3jvIwo5mUUoy+1ygLMbasqp10SEcVrmPW6hRtmUvRoI9QIrBpHenJMj07BL3WhSBuaA6jo1c0ArCuBE6+mGlxm+wOem/tJNkKsgjAWcJPEXVj0uTNj5Q7rW4avmFcFVXwBSt8V4ZeEPco7v1eda2nVPDZ+LA8wYlZ19QSqNkcM878WqNatfGUn4IZGFc8PWZF3jc3AjbzJbffaOOEJvfbOzur2Z37Y5kXI3UnlHUyYTNXb/TdKNLbIw8AwWkynfO4VZitzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S+GgU5WOvCId56ebE6AW88FHdxGveUwY2sMvHw0Ut/4=; b=SLACFqeXJ9Th2g79NlRRGR1GQM1HUZ4BKaHKOAV/+RZH4JRozrpTHKa5majUfL7pmV82SF9RA+r53uDnJ4rTHfffbZGIETelo/6WF3rMgwPziKfzGU/LB0+BFQuFJ4bSU/uFnbdVvfLXr8q3H95ihMLCqd5t/Eu/hWRiiwOdaoxXStj5tSQ+iMcHGL1CTAfXIw07PC4EUrvumrTbs6TRBdizQqQxhzgf5lPagQQ5rbpF/VH88Q/xSTQ8zbX87e+YP6M8NiElOKOnV6GfjPJyMABwqwZ9y+qHBYgOHYVXCT6yoFlQzs5xR+8Go2vF0/Ez9GChIW44Wyej5qhMA/++Cw== Received: from BYAPR05CA0088.namprd05.prod.outlook.com (2603:10b6:a03:e0::29) by IA4PR12MB9812.namprd12.prod.outlook.com (2603:10b6:208:55b::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.16; Sun, 9 Nov 2025 09:39:07 +0000 Received: from MWH0EPF000989E8.namprd02.prod.outlook.com (2603:10b6:a03:e0:cafe::e4) by BYAPR05CA0088.outlook.office365.com (2603:10b6:a03:e0::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9320.11 via Frontend Transport; Sun, 9 Nov 2025 09:39:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by MWH0EPF000989E8.mail.protection.outlook.com (10.167.241.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9320.13 via Frontend Transport; Sun, 9 Nov 2025 09:39:06 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 9 Nov 2025 01:38:55 -0800 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 9 Nov 2025 01:38:55 -0800 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Sun, 9 Nov 2025 01:38:51 -0800 From: Tariq Toukan To: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" CC: Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Mark Bloch , , , , Gal Pressman , Cosmin Ratiu Subject: [PATCH net 2/5] net/mlx5e: Trim the length of the num_doorbell error Date: Sun, 9 Nov 2025 11:37:50 +0200 Message-ID: <1762681073-1084058-3-git-send-email-tariqt@nvidia.com> X-Mailer: git-send-email 2.8.0 In-Reply-To: <1762681073-1084058-1-git-send-email-tariqt@nvidia.com> References: <1762681073-1084058-1-git-send-email-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000989E8:EE_|IA4PR12MB9812:EE_ X-MS-Office365-Filtering-Correlation-Id: 52f4c4c6-e488-4d46-7a3e-08de1f73d3d3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|376014|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?jiZeSfu3s7p14lcjQkg83E69MmAkO4tOs9gjv3YXySpf3Pfxaj2zNXO1YqPu?= =?us-ascii?Q?kvMKjbw1Cp9DYGgSyOC+FuX7IOqykfNPGEwjLTX4/hAUSiyh7njGRXsbdXS6?= =?us-ascii?Q?HrmLxNDsU425AKZTJMXzd8pQB0mj67f/kmMd1f6z2oleS7dohrbEgQp8Jebg?= =?us-ascii?Q?bjMvFuFxV9wXS9HvSRYKe6U0XDPALV+cRvcC3V6cJHoy4Esbi+mMXhtOPjRG?= =?us-ascii?Q?Xlzexn50BtTkNfiXK7hQEHwGyJhuIONJ+lbdsR22wnshqcMttNHpZWBkTTq3?= =?us-ascii?Q?UuBdgKVHSOj6y25kh0dMTG2ppYMkuWi4QBPNz61m8uxRuTEleqoW1vPSWWtk?= =?us-ascii?Q?Paa8PKdQu4Fxa16aByhEZcb08ld+VXvYNsnmNW0IPVyAQ+H84z8P4iV1ZoPc?= =?us-ascii?Q?tN3HCXd/Vq8GS7+apT0cayVr8HMU/aYlaV99pla6vBGWBFFyVpA6JS1o1I09?= =?us-ascii?Q?QgCJHH9utIXWK9dlF7/5awyN+s5qDtig0d+SAWmIq+ApHRSUynzYVqfxw/+X?= =?us-ascii?Q?Q8hlfXcP17hLO0dvC0s+pD4fePgZjDOlMNlVWISoiq0UmOrPaLCx88EGmIDc?= =?us-ascii?Q?DipMyPA8HOZ7kkVohOzZk4Jv1r76HqeqFZQlbmsKYgVAAtXQy4DqrxnD6QgH?= =?us-ascii?Q?zK/PpMsZYTGYAc0IG95k1ez+nOUF1UU6tq3Su91PQsAMwj3qwceBQtA1bJzX?= =?us-ascii?Q?7/sp31Fi1GwmTIHh4y/7ZZ9IZ8RIYUU1fZZFUfNglOa08G6l/i/ViTRMZcGV?= =?us-ascii?Q?zjCKQ+PJSaGgNHmebkTDi8KLowL5kDGbVky+6/Cd2cghhZdT0fPO/4OQKuOu?= =?us-ascii?Q?OYrOGttmmFJIZ9uefNvIQH+MQzsCHce69JjzeNhHpvLiU2rV1VxaaSxvjqxY?= =?us-ascii?Q?y8dxmq9u9t0dWXK3cRl2DBXr/O7QWQ3cthtbd44+F4xrSPkUrox3kP0Q2S0K?= =?us-ascii?Q?WXaeQnV8KTzGfa4aH9lyOre0fkwukcjIZTbF95Dx+N4XLyh22ZbAxis0KHxk?= =?us-ascii?Q?qWmzhVmNQ1hSVzY+CYCST24G2QUJDHWGlbFRCr4EuK5nrqmJqwuGa3eZHOgi?= =?us-ascii?Q?fcsnersZTgQR8waCHFDkDCikhLjAKMZwelJ0HyVz/HKvS9g4ch0XRVa2YcEW?= =?us-ascii?Q?6zL1GHGYYzYbPCqj5Y6Ui1JJF2k8cO/8BExiaYY9OZ7HnvomBSU6YNvH6skV?= =?us-ascii?Q?LhqOnyuSs3iKte54ZTjSV4v3OhSBT3lGWeelBZVeiRqZLjcDR755SSy1UNr9?= =?us-ascii?Q?G+pWjE1RzhP7WCzTlu8AQl2NYO6xzEfgqnSvWuavutO42ceMekqYxY7McA5m?= =?us-ascii?Q?L0k/A4z0b0AAXgtr4Mjko7VGDeHbX527rLz4Q6ZKp+0uYVIrNXOS5kpMZYy6?= =?us-ascii?Q?HGqKZK60AgG0jvMFPIkce40/OMu4TAOnz7GrRxtAZjw7XE8v6RINlpZhwGz3?= =?us-ascii?Q?dZK/xITEMXxdrNll8Nz7iUYxr6ImgKTI5aHZip8vmXkyO5NtxEdE27X5cZFK?= =?us-ascii?Q?JWxpGW2jnFnZU93zh+1xHDcWCltRcPLpRxBB1Egp9DxmbMvcAMhvdeIygy6b?= =?us-ascii?Q?j7Vzotk+rsWlQ+YoUpk=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(376014)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2025 09:39:06.7730 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 52f4c4c6-e488-4d46-7a3e-08de1f73d3d3 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000989E8.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA4PR12MB9812 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Cosmin Ratiu When trying to set num_doorbells to a value greater than the max number of channels, the error message was going over the netlink limit of 80 chars, truncating the most important part of the message, the number of channels. Fix that by trimming the length a bit. Fixes: 11bbcfb7668c ("net/mlx5e: Use the 'num_doorbells' devlink param") Signed-off-by: Cosmin Ratiu Reviewed-by: Dragos Tatulea Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/devlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c b/drivers/ne= t/ethernet/mellanox/mlx5/core/devlink.c index fceea83abbd7..887adf4807d1 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c @@ -541,7 +541,7 @@ static int mlx5_devlink_num_doorbells_validate(struct d= evlink *devlink, u32 id, max_num_channels =3D mlx5e_get_max_num_channels(mdev); if (val32 > max_num_channels) { NL_SET_ERR_MSG_FMT_MOD(extack, - "Requested num_doorbells (%u) exceeds maximum number of channel= s (%u)", + "Requested num_doorbells (%u) exceeds max number of channels (%= u)", val32, max_num_channels); return -EINVAL; } --=20 2.31.1 From nobody Sun Feb 8 02:56:20 2026 Received: from BYAPR05CU005.outbound.protection.outlook.com (mail-westusazon11010047.outbound.protection.outlook.com [52.101.85.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FDA32D46A9; Sun, 9 Nov 2025 09:39:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.85.47 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762681153; cv=fail; b=lF7Coxj93g2Y0Qkh9ILqk7Aq3qm7aYY0pdaww7/IGHtdfHAoU6kILbxz8PYahttLd/ywKR6uaG/+JEvB2XOSD+4yTF9JJcyjO/TYoCvzUeYy48cj1oak3/FP0BdSq+aKD9cA5D96huah/mvjOgdJMCs1H16JWUar0f/ZCffy+OQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762681153; c=relaxed/simple; bh=7KFRU5If7RpDwTCjwSRyelnXWgLyDRQKTMNNZhllPwA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=XvjFVHLei8wjdlhtdwG1lR2KtRc04YVUcwtJS71rJNg+sP1k79CD59s638RFq7ofx/G8b0/6wwRBojxS8F+g4I18psFYD2EdAXrTFKER3jCzJZBYrRTORBo1+HKjYT1W47mGr3zQnOHTZqxXEk4QLd4LRzuLw5kisa204sR4AD0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=AeQFs0Hz; arc=fail smtp.client-ip=52.101.85.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="AeQFs0Hz" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jNSndxgQcOg/3g7wEl/NUF2Xc0uMp6e1CgWCWODK+SdWG1dCykFj4Z8TpkzVcsHDM7WoXZcljZEWBB7/HQ4D8bPjJHminebwl0DWDJ/xPL7byzKpl4kdbNkxtXwAsi4dMmhq6Et1h5Q2acey9vXm6VWNSPCO9dm0AwI6G4b1Pztg39oMRizbGBa2CilDx/nHcQoD6k/TV4nw1MHme8sFHwGTWN7qwEmfFymfP3q7ACeCZ0okOFY3glgMDSj8ATQlZUE4qAKFqi2X23cVBy+X07mYghvQCVxbaQB2KVBnhpyYTRE5myro+5Ue4WN5SiPo/m+10mzlkDKnodiYEc+BEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b83Zi2fmnHnD3HAco1an6+x556DSd3W/H+dmHBuseQA=; b=NBgUcM7asPsP1vOkVq0IlMuagz/zPdMg7cOBwCzrODHLENicnitdXtzxNqlyoUt57Y4z2rHAv5kOWOprdZp1vpUaiGTUnVUEv5+/FBzUtUUz95QOt+ERI/ozEMXe/caLEPI6JvDZlkOIEi1L2pwVoBwcTdMakaFN/aDr1OSjoy+msvSpY1bkFRO0sNUP34YTuTITxjiBwZAqj13h71opnSwb9TmXQnrEVnwB9uYyS0ayDuNu+4lCkVtXxAnBvyUKQB7iRZb4r09wYPHvgfa/63HsDvmFivCraBAlD9pMp9jMHNdjnPC2lLu+YeIjMjWkrTMkJpkOFFsSk5qwZW9S5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b83Zi2fmnHnD3HAco1an6+x556DSd3W/H+dmHBuseQA=; b=AeQFs0Hz2xOA/r5zqCzCGhLaIJN0is3/AvyBGGqY1Gwz2o9t5msn9yjRV60eiLMFwMQ2mY6A+Vo2nZ/HluoD6qpOCdE1yzACnq3AR7GmFAhVr5V2gIIVilY5yrIaUU6yHqNWx8L5wnzZfVT8UTXeSzjTA8PskGpo7rehCPRYAx1fUKH7MzE1xfAefD2SDT5ugeLKxU1N36wfXwD4WmzYOxkFgfo0uaG9qsX4UZY0+4yCCeb4OENJdHD5fGphBCRwmtSrWgIlfLs2sy3S7ljF+i0O9wr8UaA2xx4+iaY7v8VwbZdIvMS2dVRZhhwXy6YZmjpwcMBK8P33gZC24AbL2Q== Received: from DS7PR03CA0022.namprd03.prod.outlook.com (2603:10b6:5:3b8::27) by CY1PR12MB9583.namprd12.prod.outlook.com (2603:10b6:930:fe::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.16; Sun, 9 Nov 2025 09:39:08 +0000 Received: from CH3PEPF00000016.namprd21.prod.outlook.com (2603:10b6:5:3b8:cafe::56) by DS7PR03CA0022.outlook.office365.com (2603:10b6:5:3b8::27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9298.15 via Frontend Transport; Sun, 9 Nov 2025 09:39:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CH3PEPF00000016.mail.protection.outlook.com (10.167.244.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.0 via Frontend Transport; Sun, 9 Nov 2025 09:39:07 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 9 Nov 2025 01:39:00 -0800 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 9 Nov 2025 01:38:59 -0800 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Sun, 9 Nov 2025 01:38:56 -0800 From: Tariq Toukan To: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" CC: Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Mark Bloch , , , , Gal Pressman Subject: [PATCH net 3/5] net/mlx5e: Fix maxrate wraparound in threshold between units Date: Sun, 9 Nov 2025 11:37:51 +0200 Message-ID: <1762681073-1084058-4-git-send-email-tariqt@nvidia.com> X-Mailer: git-send-email 2.8.0 In-Reply-To: <1762681073-1084058-1-git-send-email-tariqt@nvidia.com> References: <1762681073-1084058-1-git-send-email-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000016:EE_|CY1PR12MB9583:EE_ X-MS-Office365-Filtering-Correlation-Id: 31e2e684-81ab-4981-2320-08de1f73d48e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|376014|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?rppV0HIo9+y0peu8hGEGrpN8sSrXMwg/0qkyMnzrw2pFwDDlKWPNI+mCxPAj?= =?us-ascii?Q?+2a8+ncQ0HWc8XU4y28U3P9xecntX0a1GGnYhEXoQFCHFVDym3P/zh8aQihd?= =?us-ascii?Q?A6jpbZR/T/PUmt0NCgJSXNM6YRvhOXjoDgMn4p7ggKJLuEeMgLi32UlC+fCK?= =?us-ascii?Q?abLWzQeqtAn+bIhiINdDr/VSjjz4Y6Z7PqiiGBM5kDtrz59TVvK6lMBcwtRn?= =?us-ascii?Q?rDCUGXQSF7c6kTprgdLyUqPicMSHTego0+PfX22P7oSw9IcNfhob5EWlm9KB?= =?us-ascii?Q?Jg4r5loYPPsjbMjDXzhIiQF5KcKpSd2T/E+/Eggr7SV0iRaDiejY3m8ZRDpS?= =?us-ascii?Q?ZdC7aegGgmHwyyyKOj3O75pe4lh3X+UC6wXXqg6z4uxgCm5PQ8T/JiDmoIXk?= =?us-ascii?Q?qZkloMeERMX5V1XJExSBj62Joj6bwZjdDqM05FvhidlFiqoANFG75CKI3lwK?= =?us-ascii?Q?G+vCMkutxmSYnBmFOVjC59VcJoBTbIyp90stgilOQvFy69Xfomy9mLbCnH4M?= =?us-ascii?Q?XSfc3e2wws3Pi9ScTjRZwFtJqH/XC5pBlbUv1sLP/jtY1kUpZNrlnGgNRbyU?= =?us-ascii?Q?VzlpMmnMMypahUiX6TuUvUaScQ8WZI9CqGrDzq3Rifm4JeGmcfvRQ21Skqnt?= =?us-ascii?Q?7XpnV0zhQUkxn+a8MN5482h2c8KKd5WyK7q7Wm+up9516t1y3wb/R2fNUa1Z?= =?us-ascii?Q?LRLkRFaXi/VhX1ybNpsQMdOcpRvwhOZB/AQO1seWSJk/yqeA2yka7to1ta4D?= =?us-ascii?Q?M1SxMxIOomCSWMTDG3vUZMK7dzPsng8LsOJWc35EqqguchYN+Hr+XfjKKnBK?= =?us-ascii?Q?132kHbosX/EZ3tmV9aKWlLZKHlJ/3gqPMdJ3J/yRgwfWvMH1dUr1yXzlh/xv?= =?us-ascii?Q?ofUv+VlaX10FYPKhTAnHNxJCRVysyXWqwWw9ZI1MykzeaXT+oDj1KhtKlSJZ?= =?us-ascii?Q?JdvWvAtCx+Okq4DI2QrOpmxCw6H8O4eAKjUxcllGod+EImNr7QR7xGqf/oju?= =?us-ascii?Q?0k4vl2WLgwM4UB0llFyLNb7WZOlVCCPmfk2A/pttl3883d+VWYu1c1f1Rv3M?= =?us-ascii?Q?CbLy2E9iUYWUtIFvclDV5gRUFmS1WsWVIa7C8ZU64MdAYz9JxK8MG8e/h/ud?= =?us-ascii?Q?X2tVWh4MyOl42CPKlyD+3JewBAsAyze6U2Epoa90mRgKYGchKq1/qABJuvAY?= =?us-ascii?Q?BKcVzM7+HDG6K5ZvTKPM/KBEq5UwsqUoWyme3mBZvuiKiGXuPW+w1SSuLq8+?= =?us-ascii?Q?BpRNbpTcuD4tPwZtjdvWKO2tVdU69wLxfD8VuasMC0SAm47cpSvKtf9PMzAz?= =?us-ascii?Q?WZCSQmzXt0LSkvLIVcMmlCJ03lD5vClr23aU1wewUQ59DeB60FqkPJEmVOwf?= =?us-ascii?Q?64aAgs0jsPpB3OPwUatZ3IPFqjOWlpZqeoWm067+xZ7osdxqtt1Hzc8bN5H9?= =?us-ascii?Q?CakwkEsIxxfnSkKO+D74mzEfp/lOdXO27IVOfDPWlkUQua/39vGCEUR3S/Cx?= =?us-ascii?Q?kP5ri9u49sAflP7RAI2uxe0ZWNk46rKzpPFmZd4UYCHOwMh9zuy8Fc1wOS4s?= =?us-ascii?Q?p+3S+Qil+OFFlaqXsYU=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(376014)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2025 09:39:07.9295 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 31e2e684-81ab-4981-2320-08de1f73d48e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000016.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB9583 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Gal Pressman The previous calculation used roundup() which caused an overflow for rates between 25.5Gbps and 26Gbps. For example, a rate of 25.6Gbps would result in using 100Mbps units with value of 256, which would overflow the 8 bits field. Simplify the upper_limit_mbps calculation by removing the unnecessary roundup, and adjust the comparison to use <=3D to correctly handle the boundary condition. Fixes: d8880795dabf ("net/mlx5e: Implement DCBNL IEEE max rate") Signed-off-by: Gal Pressman Reviewed-by: Nimrod Oren Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c b/drivers/n= et/ethernet/mellanox/mlx5/core/en_dcbnl.c index d166c0d5189e..345614471052 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c @@ -595,18 +595,19 @@ static int mlx5e_dcbnl_ieee_setmaxrate(struct net_dev= ice *netdev, struct mlx5_core_dev *mdev =3D priv->mdev; u8 max_bw_value[IEEE_8021QAZ_MAX_TCS]; u8 max_bw_unit[IEEE_8021QAZ_MAX_TCS]; - __u64 upper_limit_mbps =3D roundup(255 * MLX5E_100MB, MLX5E_1GB); + __u64 upper_limit_mbps; int i; =20 memset(max_bw_value, 0, sizeof(max_bw_value)); memset(max_bw_unit, 0, sizeof(max_bw_unit)); + upper_limit_mbps =3D 255 * MLX5E_100MB; =20 for (i =3D 0; i <=3D mlx5_max_tc(mdev); i++) { if (!maxrate->tc_maxrate[i]) { max_bw_unit[i] =3D MLX5_BW_NO_LIMIT; continue; } - if (maxrate->tc_maxrate[i] < upper_limit_mbps) { + if (maxrate->tc_maxrate[i] <=3D upper_limit_mbps) { max_bw_value[i] =3D div_u64(maxrate->tc_maxrate[i], MLX5E_100MB); max_bw_value[i] =3D max_bw_value[i] ? max_bw_value[i] : 1; --=20 2.31.1 From nobody Sun Feb 8 02:56:20 2026 Received: from CH4PR04CU002.outbound.protection.outlook.com (mail-northcentralusazon11013039.outbound.protection.outlook.com [40.107.201.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB0092D4805; Sun, 9 Nov 2025 09:39:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.201.39 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762681164; cv=fail; b=uV3tE5Vi4LByCd70pwprfAHeVopd0Xj+kIWnkIPLVpf09E/LlNivR36e9FMWl99PYXDNisGccnbHqAU1X241r/oqvbSdkwBPehw4noC3vN4zliIxZcU8nMFG4BYMzeh1sC31qV7HSYEeXGUcBwXOB5LVpC3o+Uyd9qOVyQ0f8Bg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762681164; c=relaxed/simple; bh=tLHW4/gws/sU1h07aQnIxXyYSXuW92bukoK20QE8Af0=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=jY7I4BJdv+KU0AseEgNRinAWu49CsihF4BWs/MABovXeEbWHB9kf9FPEmS8XYZL75O8c16V0YwbGU0LLVSxzBm/WCaLPClHwGVXEc4qKNjaLCT6gN1Xkshf98e9Um57skoqXU/RQBWKcJtadghicAZUJbM0/ECY1DOxuBrZsV/4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=V3SCxtRM; arc=fail smtp.client-ip=40.107.201.39 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="V3SCxtRM" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AKLfvk0JaGueicZgAhvilP9NfIrYpncX0796IrbP5H8yv7dqEfynA68a9tDglUFmC16CQ3GK8kTJecRhFvuGRfvUW5EY1p88a5215cjrw5Hff7A+PmdyXxQSsN5uioGmheaGtHLBn0z/i5+WmTcFbIAAQjAn3PaS825m9rubOZJWoXpRzMWNRxkDx6DGMuouP/suUW42BVMJvaiTHpoX03dDpe30FhZtLJjWLOUNC1mPWGDSaWmwQ5J9Q7zlIoDW7OVc561NbJ8LEcfMso3OxX6UHcFR9LUju0TViqdfJjCRJPGnEuUggWjyNX2b2RF0anecINwsykv6x9ucJbwCTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gm7JUJJmLZlYBTd0zdaBS005P95nzkFID5D8TuTTrZc=; b=m0ojAFy4TbGOuHGxrKMxbc22qe6aE09+3ch7XVPPmrzyyzYBQIEZH4NbiTAACAzZ5L1bD8QW4I9+TBZv391t5Xhc1HlYIxWfMqBPvvvolLAFjf/Eo2OzIs9FghIXUuGlhqvrnAjp2iUi4tsEgWU4+eIXJSVsZS7PK0lx9xo6PiMo7oPxp22RdHoV+RxTgAkh4zTyqMgU4jSWnnlpFnEEHldRitx7rexDDvgLGbVB31LagXQWoX17cwLY+OIOhu0D3gV9HcJtl5zHlchpV1jBiMZ7w1kqqsLP2cbxXuYmNnonwZlR0O5T9O5a0jhKB68XrhbMvZbkFBdh83BtsilofQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gm7JUJJmLZlYBTd0zdaBS005P95nzkFID5D8TuTTrZc=; b=V3SCxtRMeEujbX+QDbYNka34oBCgKjJZgFqbmH0RaAj1UFYdoM5FYg2iWeAg/CujjD4fp3eUt4x5I0//Ozlx1KETt5CjqDBEPo3stTp8oMQDzTr3c8QMKfPI0qoNZ0vz6bE90f5u/YhuMtSUV3Z8IqFPkOLSbYcpP0lPP6YJKZMmbqV0Dqr1zqjsOZvrB5izOzeXithDY3St5lNWgYR1CoMor46P7DJA8MwnPxx5BzF/OxcpVU7IQSSYenUjKAKVWsTf4VukJYSjPpjwEGiY1jEO2n0plWUQfJjMx9tr+WavAbJaJBj1a1WQZ+5tHdKxJDTSxMzNUu6sFLK+LxVJmw== Received: from BY5PR13CA0018.namprd13.prod.outlook.com (2603:10b6:a03:180::31) by SJ2PR12MB9164.namprd12.prod.outlook.com (2603:10b6:a03:556::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.16; Sun, 9 Nov 2025 09:39:18 +0000 Received: from MWH0EPF000989EB.namprd02.prod.outlook.com (2603:10b6:a03:180:cafe::88) by BY5PR13CA0018.outlook.office365.com (2603:10b6:a03:180::31) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9320.12 via Frontend Transport; Sun, 9 Nov 2025 09:39:17 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by MWH0EPF000989EB.mail.protection.outlook.com (10.167.241.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9320.13 via Frontend Transport; Sun, 9 Nov 2025 09:39:17 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 9 Nov 2025 01:39:04 -0800 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 9 Nov 2025 01:39:04 -0800 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Sun, 9 Nov 2025 01:39:00 -0800 From: Tariq Toukan To: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" CC: Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Mark Bloch , , , , Gal Pressman Subject: [PATCH net 4/5] net/mlx5e: Fix wraparound in rate limiting for values above 255 Gbps Date: Sun, 9 Nov 2025 11:37:52 +0200 Message-ID: <1762681073-1084058-5-git-send-email-tariqt@nvidia.com> X-Mailer: git-send-email 2.8.0 In-Reply-To: <1762681073-1084058-1-git-send-email-tariqt@nvidia.com> References: <1762681073-1084058-1-git-send-email-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000989EB:EE_|SJ2PR12MB9164:EE_ X-MS-Office365-Filtering-Correlation-Id: edc8e331-2fbf-4e46-f63a-08de1f73da60 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|376014|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?aerpW2j6JLdtcEqJjpz6Z/d8QL0rsx8XscJjBLAKco88oEFuWhjWujeqRMVX?= =?us-ascii?Q?cafATTieJVrvfHR4T5agzerVuEb3cnRVsoOtcwUJ/AoTj6o4N5bVNLP+DOD1?= =?us-ascii?Q?Ab3mEJ0pgAz8P0VQF1bX4KfzZpWeTs6LM6ipkdpXbph8ptw5O33wHcbDS9rL?= =?us-ascii?Q?XDIjJlCgLONpK/IqmMZYvo1mBOzhmMzwvArUbd7ndDPTLz4sBu6NplHwPOm6?= =?us-ascii?Q?LXQWK2iHltXd6h9Pu10wPkTGKQ02H53CjM/F1IlCwtxUMHcSC9nlAptu6YUw?= =?us-ascii?Q?Gn+jleHnw4g3SPDxSXcCRKp+8nlFqkDRbB1rUjMnMDKRM9VWQgwagUKf+t5H?= =?us-ascii?Q?dZm/66Os3f9kASmfeVoJXoFZ6BrtylF5qvzEYkNLLd+ge3kGwgCv8wj9JRP7?= =?us-ascii?Q?fEa5HyxQ64GPyApuAECaxtcxQ9zXSOeY966cNJgXjfvY8DRmVtN/6AW1c9g2?= =?us-ascii?Q?Y6s2oZq8bIuswmEKzXOUXeiR5CC4ISsiHlhCfuQJNyVQVQpZm1HaO82BkRJj?= =?us-ascii?Q?zDfvkPXhC6gGIjFRBiVxswN9CcKgVouV6q8+klXWfZzUIHZpLtKq2MbJ6ZmA?= =?us-ascii?Q?38EIp1pkH6csnBOqtQA3Wf0Jw8esrnUW8fINpvNs8uUIY2uYu9IN4fMLSTCW?= =?us-ascii?Q?Udpi+2Nh4JbkCYC2dNcPs2MHOtvMLnfMSZ36SRrQyo+7M7yrRiu0zAjUpITZ?= =?us-ascii?Q?/ZFoyYLxplEppFLPYOyn1QiVonJqIgK9FwKjEEJDmEyG4JT/+aVstMWSxwBM?= =?us-ascii?Q?H1GhKzW1DLYlNvqoyz01wSpVaEDQSiU55x24h/9lPL4nLWUchv0ZRts3KYz6?= =?us-ascii?Q?na7Hvw8QRjxM5ePNKLiip31UcpubwpmC6JtL/IYLGesEHZLiCbqshhxmuooW?= =?us-ascii?Q?YWA8z4RxJCIu24lAi5CM/1DJ8W/+8jkrqa0H5Ujx75/j0C91tIGCzxKrPKhz?= =?us-ascii?Q?8EHykrVyC98C/qrdEFd0YYUBoHl932VhfNfLKTo/QlPz5ABqf3UR5WZlAQl0?= =?us-ascii?Q?mXKaQ79MpjGbWTiJOZvRXRkl2je2r9uX+ORxmE3rS6YrKpmpZTFSzyXca+On?= =?us-ascii?Q?DZNhtaWnYmvht0viySdCsXaW7fmXnk+/5nJBpXcBFKndJTaHuK+uD2lEBdTd?= =?us-ascii?Q?gLJ11fj4GvWVv1aqwSElKFnhnqgh16+8WDWtmNEBnYSDoU9i1N3IW887fPVU?= =?us-ascii?Q?5PLzafdHerOSYkOwgfx0efgndyaPAjWGUWXXdMnnzzfXkrXGZt96QSXNh/gB?= =?us-ascii?Q?i44HLyCswePB9VjSXFHf8rzi+9vcXrS60OBF8TNQ2exwAzd81eSHe1OmmfQ2?= =?us-ascii?Q?45G7LFx+ggXw1hHGejDBEnD62pf1Bb4rkecQqsUJlsPGdbS0WLWONY/qegQj?= =?us-ascii?Q?huIGwKty+85LO8miGDmHNcm3Hy6ed17B29aGhtkR4XTbgb3ZbYa8Atk0jKpj?= =?us-ascii?Q?/c6IbtUDye/HPClHXDacw2ReMb6oM/UQpAwEboq2B0TQwIbRkyoC03A3q60q?= =?us-ascii?Q?f9EVKxqPMuTcuusl7lzvlW5EjOoTBo54qmhI9xruPQP20qiiUQdSBfBoYRvM?= =?us-ascii?Q?we4xZYdFgVVzhVYkKXI=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(376014)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2025 09:39:17.7755 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: edc8e331-2fbf-4e46-f63a-08de1f73da60 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000989EB.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB9164 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Gal Pressman Add validation to reject rates exceeding 255 Gbps that would overflow the 8 bits max bandwidth field. Fixes: d8880795dabf ("net/mlx5e: Implement DCBNL IEEE max rate") Signed-off-by: Gal Pressman Reviewed-by: Nimrod Oren Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c b/drivers/n= et/ethernet/mellanox/mlx5/core/en_dcbnl.c index 345614471052..d88a48210fdc 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c @@ -596,11 +596,13 @@ static int mlx5e_dcbnl_ieee_setmaxrate(struct net_dev= ice *netdev, u8 max_bw_value[IEEE_8021QAZ_MAX_TCS]; u8 max_bw_unit[IEEE_8021QAZ_MAX_TCS]; __u64 upper_limit_mbps; + __u64 upper_limit_gbps; int i; =20 memset(max_bw_value, 0, sizeof(max_bw_value)); memset(max_bw_unit, 0, sizeof(max_bw_unit)); upper_limit_mbps =3D 255 * MLX5E_100MB; + upper_limit_gbps =3D 255 * MLX5E_1GB; =20 for (i =3D 0; i <=3D mlx5_max_tc(mdev); i++) { if (!maxrate->tc_maxrate[i]) { @@ -612,10 +614,16 @@ static int mlx5e_dcbnl_ieee_setmaxrate(struct net_dev= ice *netdev, MLX5E_100MB); max_bw_value[i] =3D max_bw_value[i] ? max_bw_value[i] : 1; max_bw_unit[i] =3D MLX5_100_MBPS_UNIT; - } else { + } else if (max_bw_value[i] <=3D upper_limit_gbps) { max_bw_value[i] =3D div_u64(maxrate->tc_maxrate[i], MLX5E_1GB); max_bw_unit[i] =3D MLX5_GBPS_UNIT; + } else { + netdev_err(netdev, + "tc_%d maxrate %llu Kbps exceeds limit %llu\n", + i, maxrate->tc_maxrate[i], + upper_limit_gbps); + return -EINVAL; } } =20 --=20 2.31.1 From nobody Sun Feb 8 02:56:20 2026 Received: from DM5PR21CU001.outbound.protection.outlook.com (mail-centralusazon11011031.outbound.protection.outlook.com [52.101.62.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 440772D8780; Sun, 9 Nov 2025 09:39:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.62.31 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762681169; cv=fail; b=gZ24LFk7v2vdxJbV4M9QkmJJMttUxXp6Y8eBxiAVXOT3MMc+V7p0hP8D+GiS6XcxPHZHl3nlhk4T/w5arxxeLX6o23q5ETcZ9XoytakPkbxAGcjm8dHZaSe0BLWpkb1LpJP8Y4QvRmA73o4rCpK1j3TNAdclT/SZjmPhse8/Hd4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762681169; c=relaxed/simple; bh=OKtkv34FYx6Xai89ZtujWHYwECB4Sr0qeCJevKKPukA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=O/jo2oTtgFAmCIlz7PBB8gJNigmLJ7+EDtwaDhLQbHWbc7sF6Pkew6QxlaS9AMczzEiw+nHujVcatpc3DurA1TgormQllbKT9k2QKbVOoZmQW1WbMbGyoEizk9Gam3NK0MprupJOlkscukHbdj4f26ZLSOAOLNZNxPi/G7nDlLU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=d4hRBC6F; arc=fail smtp.client-ip=52.101.62.31 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="d4hRBC6F" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MNeQxZu3GVN3kqGERuC7cJ7hIX9sV9EUj0fKr++12PrCa6mYU2ZmwbCxu+rcfSGWTT9wJizTsNzeXAF/W1dwPML+9ngFXcuHGI6U5H54eNQWwPVGQagpFlakC+coUGqduzOjrwRIRGto5aqIjpP5fDamr520yPt7hW5Fl0TG2qY4FoTF0q1l+O9O+untRf4vbScZGoeXTjISEMgleRdjBwhYEvBL3D4StgqyXQ64WP+2vRrURePt91ru91QrNAOsHckR1V7c/RZcgjwjtuRy7kKQ9yd8+jCvkHHs5DVD6/eglxdraTtf9VnqQeidccSTCAhGoUfDUM/s6rUG6wwgKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fqc5Ev1T0u3Fy4rmmQ5GmvBxSB2Qcngtcea5BNijcOg=; b=pquyIIylnfrdHfW1fl2gPMwo+vS9LbLHR6maa0e2M/mg3N+B8IJIc5yxA4gqqtAMk+IrNLDtR1f4i9PS5ZXAHTsg2tCNlDdLj2MLpPuWDq35khgtRyns0L/4xkbwJfmcdnel5fpWoQazz01MUZvN6BJI5/0Uro6/8wScijGz3bD85YLsXz5+zVzQDzx8MUsi3jIq33jDDM+ibNNMMow8hJ+9ZFvsuvbUMz/sgUCzUyVZQkDhS9C01zKlYjj8gVxNMR/7D/WQEgXFo++C5Xr/o5ctq3anSHcoRctAymJm6Y/shVIygsAXdGGaRgAOHQykcS2BcW9IU6VAfUKm0Wjt3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fqc5Ev1T0u3Fy4rmmQ5GmvBxSB2Qcngtcea5BNijcOg=; b=d4hRBC6FzLUqqqsn4GlkfvmvVpimJicYP5IMzhu+oZALiq2mOG8GGBo63P5gHgZqiBjBHbX/oS7RzA97rAyZka6ViRd5QU2wKARvoDTsHS9ioXhnF/LFHoj8mY2+W3Jhqkzoyu7H1T2rfvkyuXQ/ZwWC4qW8143oiHRqo0HJi75XcerYP2UdRwUtdkPd0vXyji4fLsqzqVaZB4RMTQpjKMIqTs6dFlZ7/mwTFloz2brKuUmTIRqOTxV1c74v32M4YVxe4tUkOPhn2lz43Rmvpb3brGNS8AHECz549lVdYkrbTTwTzepT47s+dit31IpwA5vOH2nzQcK02JYtEu0ITw== Received: from BY5PR16CA0007.namprd16.prod.outlook.com (2603:10b6:a03:1a0::20) by DM4PR12MB5724.namprd12.prod.outlook.com (2603:10b6:8:5f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.12; Sun, 9 Nov 2025 09:39:23 +0000 Received: from MWH0EPF000989EC.namprd02.prod.outlook.com (2603:10b6:a03:1a0:cafe::d9) by BY5PR16CA0007.outlook.office365.com (2603:10b6:a03:1a0::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9298.14 via Frontend Transport; Sun, 9 Nov 2025 09:39:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by MWH0EPF000989EC.mail.protection.outlook.com (10.167.241.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9320.13 via Frontend Transport; Sun, 9 Nov 2025 09:39:22 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 9 Nov 2025 01:39:09 -0800 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 9 Nov 2025 01:39:08 -0800 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Sun, 9 Nov 2025 01:39:04 -0800 From: Tariq Toukan To: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" CC: Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Mark Bloch , , , , Gal Pressman Subject: [PATCH net 5/5] net/mlx5e: Fix potentially misleading debug message Date: Sun, 9 Nov 2025 11:37:53 +0200 Message-ID: <1762681073-1084058-6-git-send-email-tariqt@nvidia.com> X-Mailer: git-send-email 2.8.0 In-Reply-To: <1762681073-1084058-1-git-send-email-tariqt@nvidia.com> References: <1762681073-1084058-1-git-send-email-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000989EC:EE_|DM4PR12MB5724:EE_ X-MS-Office365-Filtering-Correlation-Id: b7a0b3e8-73e8-4f03-424d-08de1f73dd48 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?DIqTXqAGyc7NSP82Zymua8AGgEQXcxenN87jQaFNgQqHIKmf5KfUFL2Sda2A?= =?us-ascii?Q?aPYomuIu/lbBor/JuFqobgJFwtNQ0G1zRvqgMgcJ4xYa3OHyUlrKa2fpIpk6?= =?us-ascii?Q?+VwyQXAB+eALlN/xdgaP3pmm/UdRDXPYrGrPDuyiRvU341wXcrQ2UzR4ijyg?= =?us-ascii?Q?fkP3rmANBk9LNYQHOhmBmPtfgZ16Z84l0rU2PDao8EJzdhB3yKwohhKTMYjy?= =?us-ascii?Q?vqNPf4RgCNaZ2geIUix/h2SsH3xmWZdUqBUqXFX0txHxPEHaHC9CrdpGyYJi?= =?us-ascii?Q?Kir9FVhwnD+gry75y+A1FxJluUMoLOZNB+1VXY6efcveG4wFERdaRIxDZKK6?= =?us-ascii?Q?W9tEcaye7paGtrVqHdk2pp8wGZSC7DPmaKRq3U3hnRYlt18Zzh9vpqcH4Ynm?= =?us-ascii?Q?r8oC1emNhRLUQ2qYRShu0sBHgcdlLx/wpdRjLozr9dANoyx5hLt4g+S0Ifg8?= =?us-ascii?Q?WO6Y7a+SDkJh5p5YJBufPvPHdZYzAobcPduOqkav8HoO26zjnrrUEGWxfDQe?= =?us-ascii?Q?DmkzQb0qkwUY9mseE/waJ2wlQapE5vjW3F/8aixIP8qEesek6KXkndibCyAB?= =?us-ascii?Q?+t2oD9G9Yuuzb4dUzxXQciER+LfEzw43FoO6CqkkNqT/uLbdgCTOb9H3lqj7?= =?us-ascii?Q?jEETXtNWExjDH6M405m+pxvOE7u5k40lJOWzlpr0Eae2NDCN3lmvTsjF5cPh?= =?us-ascii?Q?DkFRNaIXEUO6zhYzoFG1SzovndT3ZEz/MZakdVCU8bTEZNKA8sIO0o5/odan?= =?us-ascii?Q?iStsLzghBwcwpEeETBwBXkzvFzJtBNomw0uHTdMHfCveYlBdjJ94Kdc9S7GB?= =?us-ascii?Q?DbkmbnfTQUJb4u8mfWWWJTGNTMZqgD+wejkDiL3IENb5lb39Wq1J9sWTaRwi?= =?us-ascii?Q?U+0zQb7TK3WziuNbJLYLXzj9IPMzDeeH2zgpJpYBafqfDvfbc3Era5sl+iZI?= =?us-ascii?Q?8LzGRwFMPJvGsx0aoJ2l77Me9GldPvfKOJttJ8DelDij+8+S3V1G0JfHybvS?= =?us-ascii?Q?9uFwaUegfHq+q5y5z9iM9hNUS9OFuDF5kNmL3vMic1ijumFJtHZnLBms7YG3?= =?us-ascii?Q?cFhnAZiHeYGCc4LiAF8D6R6NmtbzU0DvDEBHHrkYg2pS9KzsfxhWyv7m6Oi4?= =?us-ascii?Q?+5SX3HzJBnp+qK//Gdsy2hHCgQDPJSNPUC8PGyOVWsQxoyU5ujt0aRvuCBxY?= =?us-ascii?Q?WigKIcwm6gYKUM0naJvPsVuRdAJc2/yHbXFWJHhdhJp46PrbXEftbkvX3rY7?= =?us-ascii?Q?QiZQTHy59Awyo5cnWY3Lxj5cYCVFMRuNo9ccvclmcpXrYUrhfb1ALW5DbXHh?= =?us-ascii?Q?5a/mMm65omeTgRQ3Rtgsf6DD0HTxeBHuXt8MQrkyjRFpiqbanlz8gFSt3tw6?= =?us-ascii?Q?VkOnLE5yiX2LVgZ0kCsOGOFsfK+ZTFLzCjehCDMZ2Ohv4aIiogrpYtInB27C?= =?us-ascii?Q?RTRKCLNu7FmUh7LUMNYfRcXY7JBpcwmGr22Vlxe4t/WMgLdPMIV2e7YRuKpR?= =?us-ascii?Q?oeonuqvM0kz9Dd2yWPwgZbeUaVZ/jaNBeKV///y/C1w25qM0xCv3tKEbd4f6?= =?us-ascii?Q?AnmX1R9ivVeKVgl0fuY=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(82310400026)(36860700013)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2025 09:39:22.6468 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b7a0b3e8-73e8-4f03-424d-08de1f73dd48 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000989EC.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5724 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Gal Pressman Change the debug message to print the correct units instead of always assuming Gbps, as the value can be in either 100 Mbps or 1 Gbps units. Fixes: 5da8bc3effb6 ("net/mlx5e: DCBNL, Add debug messages log") Signed-off-by: Gal Pressman Reviewed-by: Nimrod Oren Signed-off-by: Tariq Toukan --- .../net/ethernet/mellanox/mlx5/core/en_dcbnl.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c b/drivers/n= et/ethernet/mellanox/mlx5/core/en_dcbnl.c index d88a48210fdc..9b93da4d52f6 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c @@ -598,6 +598,19 @@ static int mlx5e_dcbnl_ieee_setmaxrate(struct net_devi= ce *netdev, __u64 upper_limit_mbps; __u64 upper_limit_gbps; int i; + struct { + int scale; + const char *units_str; + } units[] =3D { + [MLX5_100_MBPS_UNIT] =3D { + .scale =3D 100, + .units_str =3D "Mbps", + }, + [MLX5_GBPS_UNIT] =3D { + .scale =3D 1, + .units_str =3D "Gbps", + }, + }; =20 memset(max_bw_value, 0, sizeof(max_bw_value)); memset(max_bw_unit, 0, sizeof(max_bw_unit)); @@ -628,8 +641,9 @@ static int mlx5e_dcbnl_ieee_setmaxrate(struct net_devic= e *netdev, } =20 for (i =3D 0; i < IEEE_8021QAZ_MAX_TCS; i++) { - netdev_dbg(netdev, "%s: tc_%d <=3D> max_bw %d Gbps\n", - __func__, i, max_bw_value[i]); + netdev_dbg(netdev, "%s: tc_%d <=3D> max_bw %u %s\n", __func__, i, + max_bw_value[i] * units[max_bw_unit[i]].scale, + units[max_bw_unit[i]].units_str); } =20 return mlx5_modify_port_ets_rate_limit(mdev, max_bw_value, max_bw_unit); --=20 2.31.1