From nobody Thu Oct 2 04:45:16 2025 Received: from BYAPR05CU005.outbound.protection.outlook.com (mail-westusazon11010001.outbound.protection.outlook.com [52.101.85.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3772F287262; Mon, 22 Sep 2025 09:19:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.85.1 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758532766; cv=fail; b=hZ+6243HSXCZRvaEMjMBcQFiwlah4htiO8PNJsLCV+uXTyGMOvOLe5szaLnuRh6QZlSnO0wOuD5VLNm4J0rc10L1SOnf8xAeKh/p/lpSV/IL9MTJKXZbbcuC6CtnzS3t0hJd2wkXywT+4WzUlrvPiK+XzxTt8QEua4JHRXvVgmA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758532766; c=relaxed/simple; bh=z9s4sGjFOnXq2QLWCBMXFj2KC4mOjBaez2/opgnroAE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VcU+Uec6zGgKe/2WXtBtiNKljNSFpGXCYpwS7ql6f4i8BLnuPNpB3s0f64ZH0mE4cbrpnix++USiT/mhFG//mmmMySyzjK9j5I6ax4aLKs8hH3IiSyrPdE7431htMGxJur/byoB/vTizzyC35FIQOLyjrU59HDfTtv04mmlq2vc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Y8aF3J+M; arc=fail smtp.client-ip=52.101.85.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Y8aF3J+M" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lP/CJNH0KsdcdDhjQiaVmsVoHjnvi/1LdIOVf5QQWGBUuOOruSYpFn8h2a/YGwU0yyR0m+OoCAdDX9jpCke0OXzMX7U0uwNTkZzgM6zNf6BngEyVd131yxxHZpqCpWbGjj7/5D28vR/F3Mc1xE8HQVrbkGi5yi09SpF8OWPpPKSYAKgUASN8yJg9mhnAZGojxx6pWk92XK12irxYpVpFUDyDPRbwwOvUanvfvDpu3oD3HVN5uZeAwaTOtAzapNevVpTIvG9FXH2jsTUT19VXWU28u3XMjUGgbW1w9cBQgBDlJUXC10rP4/sT6ql6qRbbvPpMKnEGy8SjlElSfNBGzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WP1Jkj9aWQPKPEgdU8XPHg03E8rM9sktxn8jOrbSWg0=; b=O0VdQB9Rttvh9kC+7vVBAh3Ps6CfIKb6tyjlOhEjBMEI1FfGaNr2eeVVydAzUNdVLqpuv94zUCfpyCmiL/lBgqE4Ai4GoxsU3qd9pA+o/btRknXkogMmkVmRUvgUJ5PcR0150wJxL3X14vS1pz3Z864t2bjkxXUg9S+CvU62oRZM0IIva/XqbzY0LiZAJgf8nFC+zjDqfs2+/BlHx1b/xEHRauo5eSgItyZn/uvUbnnKiyqizNWqm6vssim9khEk3x9Lchbk7WDQwyhL1V4gR1+x4cls4CXXBCcBMaqqs/JbNgd4wvwyR9ev2dSjQotfiTK5lWhkVO9Lt1ThV1NMwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WP1Jkj9aWQPKPEgdU8XPHg03E8rM9sktxn8jOrbSWg0=; b=Y8aF3J+M+J5Ae6zSMegvC+RrLJJpxC0vlWjEGyTGVHi9PcxHxgJcTYi018lppOOTAiA34FSBGdxP4Zr70xmC77SZVKKlanc02gHYFanY0hsdIB2rp8AH+m+5GUU98kh7GmKr/53G843oasBw0rIBAM6ykXGbMKn7KD4+yjMXnC5y5TVJZBhD7z1BHtO8bi0wUue7JoOZatm99r71/3OunwotCtbIE15UWwwTwU9VruA0Ggd6fcLkpnHPDPIKcVeVfR4mBa6QeDuKedEi1vyZqKliE9Tnydx/oLOEUNhXiqF+c9qw/RdJEBadNK7R89DCFL3SojsV+LxdQfLhVeNlBA== Received: from CYXPR03CA0067.namprd03.prod.outlook.com (2603:10b6:930:d1::20) by BL4PR12MB9482.namprd12.prod.outlook.com (2603:10b6:208:58d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9137.17; Mon, 22 Sep 2025 09:19:20 +0000 Received: from CY4PEPF0000EE35.namprd05.prod.outlook.com (2603:10b6:930:d1:cafe::62) by CYXPR03CA0067.outlook.office365.com (2603:10b6:930:d1::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9137.20 via Frontend Transport; Mon, 22 Sep 2025 09:19:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by CY4PEPF0000EE35.mail.protection.outlook.com (10.167.242.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9137.12 via Frontend Transport; Mon, 22 Sep 2025 09:19:20 +0000 Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Mon, 22 Sep 2025 02:19:09 -0700 Received: from drhqmail202.nvidia.com (10.126.190.181) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Mon, 22 Sep 2025 02:19:09 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Mon, 22 Sep 2025 02:19:05 -0700 From: Tariq Toukan To: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" CC: Saeed Mahameed , Tariq Toukan , "Mark Bloch" , Leon Romanovsky , "Jesper Dangaard Brouer" , Ilias Apalodimas , , , , Gal Pressman , Dragos Tatulea Subject: [PATCH net-next 1/2] net: page_pool: Expose internal limit Date: Mon, 22 Sep 2025 12:18:34 +0300 Message-ID: <1758532715-820422-2-git-send-email-tariqt@nvidia.com> X-Mailer: git-send-email 2.8.0 In-Reply-To: <1758532715-820422-1-git-send-email-tariqt@nvidia.com> References: <1758532715-820422-1-git-send-email-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE35:EE_|BL4PR12MB9482:EE_ X-MS-Office365-Filtering-Correlation-Id: 44378bf8-f865-45ab-9c80-08ddf9b91ccd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|82310400026|7416014|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?/+HMWGdllna7YC+04+EaCWrYwBEsaHV2wkr08tBPHzSqvxVY+YSgzYQa1ar4?= =?us-ascii?Q?z97XPF/l1/o24j5ZYeMz48Fcu9oj6k9G1IGcFu88ZwiATwAayJB3U8lJ0YAX?= =?us-ascii?Q?7UQNOKPq/vzyOqsQ5KSwCsne4/jvGeKHy7DW7tQN9OJYRmqGLcA5hYP33mhm?= =?us-ascii?Q?6LLr5iUIF1Akm1Rq6xfQtj5d8Zd+8Ac0iF+jPFOvaLig1KmQrcD44W4cmlK9?= =?us-ascii?Q?jrzZeZ5cyzvEhPWsm1k6sCiswoOTxeYhk7I6TNxtn0rfWrdn6RnVYUJXjOER?= =?us-ascii?Q?a327nI6/SVYR/8rDpN6lwioUwoZVzlPXSZpAK8USJY7ZaJBT9b/ugzFXSg0J?= =?us-ascii?Q?RmTXeBx42+aJVzjEYuBjYRjoG9wmPWaRDywqwYcELnxCEWVP4bh3Jg2Og9Pv?= =?us-ascii?Q?4xfGpoKsB59utD/HXSILYAXpG7Q+CeslhcCxd6+F2HDNozYyuPGJxmtb6n7e?= =?us-ascii?Q?jxIEqxJyhckVImJcFpZzkelc4ecaiX9fq0k4W2+EhUytbnVrqYLrjAB239lp?= =?us-ascii?Q?Tx5QEf7DIL8+0CeaTJIyn68EmHMnt0RUgNxK7PbAx1qNkEOMBOCttTuYkj1V?= =?us-ascii?Q?HaxQsaaEir87O1G3otSgQ0pURWsum+cDr5InooVlcWw8Psv4VsclYcJQTbqO?= =?us-ascii?Q?4S3bfiLLv9cQMl1rcpdxfg0hBPwiapwQQBHsBTi4WjYCTOOtPGNrJJZ6s9xS?= =?us-ascii?Q?m0xawNn4aFgDQaaidfxIlxr/4sSIwhVZYmk8DTiVEa4FisEcImAKWD7c5uAr?= =?us-ascii?Q?s9B4Pk3reAmIFlMUBvnsnoeR6PLbiBQqNMF1tW8XeHlMmdO5h70W5DgocNER?= =?us-ascii?Q?9gkwxq1AkLCHBfonGvagUJhEyvSVlxz9jIH4ThkiYlESMZ8Ndt0GcvO8dsc9?= =?us-ascii?Q?EjQIlxRU6C0Kcp+iyeDBH63/92AWR6TmPMVXLP1jha12Oa78xvKwIx8M1cCX?= =?us-ascii?Q?hpK+wnVbogmAWg5LqsTYmY0KjL06Du++0Dfptv5oqNM3r8kuXT/LADn5GVvw?= =?us-ascii?Q?X0F2teUrtmjG2xMiPKRT/N6d0lyifV8omoUlGzXYFWOz2UO7aj4pUiYrH1Yz?= =?us-ascii?Q?vbQzmTsKRWVYLUb454RLw6jnAhOuwd8KQSq1mAPI34b/TgjXYh9d0fzJ3NMq?= =?us-ascii?Q?66JUAzE82FfbAee3hvHMm0aZrZtWz7HGseowtq/aHDob/dadkTBJVO17kL4v?= =?us-ascii?Q?IIi1CtEmB2KDmEkmOFJWe/R86BB6mMnHfSud4JmXAXhPTq19aGDZyc7KZjca?= =?us-ascii?Q?gKmE2OpwSoSBf16mb/ldHe8nTDCtm99oHfQeFHEXVHEP7ry5xA/8jb+1vcID?= =?us-ascii?Q?Z0fO0p0RWHD07Bv4Bc7BXhrv1g2LemlbLOryZPclEzpbWCglM474sFeSUrav?= =?us-ascii?Q?4bWgEETUUmMgv0Jk9ok+RaP22Yq9YqtPXki9fdKTWScPgyuHE34GUu4mVpvl?= =?us-ascii?Q?7GutgBQveGcCRuZLWESa60Nu7P+rdaKkG3fpYuT9875hMYhTdXqBA8KdanOA?= =?us-ascii?Q?LZVeh4uRy59FlAQPLHBGNKOausfQbKddPxYV?= X-Forefront-Antispam-Report: CIP:216.228.118.232;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge1.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(82310400026)(7416014)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2025 09:19:20.3032 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 44378bf8-f865-45ab-9c80-08ddf9b91ccd X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE35.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL4PR12MB9482 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Dragos Tatulea page_pool_init() has a check for pool_size < 32K. But page_pool users have no access to this limit so there is no way to trim the pool_size in advance. The E2BIG error doesn't help much for retry as the driver has to guess the next size and retry. This patch exposes this limit to in the page_pool header. Signed-off-by: Dragos Tatulea Signed-off-by: Tariq Toukan Reviewed-by: Dawid Osuchowski --- include/net/page_pool/types.h | 2 ++ net/core/page_pool.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/include/net/page_pool/types.h b/include/net/page_pool/types.h index 1509a536cb85..22aee9a65a26 100644 --- a/include/net/page_pool/types.h +++ b/include/net/page_pool/types.h @@ -163,6 +163,8 @@ struct pp_memory_provider_params { const struct memory_provider_ops *mp_ops; }; =20 +#define PAGE_POOL_SIZE_LIMIT 32768 + struct page_pool { struct page_pool_params_fast p; =20 diff --git a/net/core/page_pool.c b/net/core/page_pool.c index 36a98f2bcac3..1f0fdfb02f08 100644 --- a/net/core/page_pool.c +++ b/net/core/page_pool.c @@ -214,7 +214,7 @@ static int page_pool_init(struct page_pool *pool, ring_qsize =3D pool->p.pool_size; =20 /* Sanity limit mem that can be pinned down */ - if (ring_qsize > 32768) + if (ring_qsize > PAGE_POOL_SIZE_LIMIT) return -E2BIG; =20 /* DMA direction is either DMA_FROM_DEVICE or DMA_BIDIRECTIONAL. --=20 2.31.1 From nobody Thu Oct 2 04:45:16 2025 Received: from BL2PR02CU003.outbound.protection.outlook.com (mail-eastusazon11011061.outbound.protection.outlook.com [52.101.52.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCEA71419A9; Mon, 22 Sep 2025 09:19:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.52.61 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758532773; cv=fail; b=KFXq/1jdO6rLm62QNg0QV6B9yvUAKd4LTo5XivU5vSE6dMfIiOPmn/3jiqetdrArZXGbvrzskv5vsx6Q72RZ+S+kucSx5/UahBHVToFIlXQjLlY/xHzZwHtNWNL2Jh785t9m3DQmhtdUk8Z9wm5TR0WZTP2Sw7W4oeZJiC7SOXM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758532773; c=relaxed/simple; bh=n098kY3gWZOVGu5AtJ1ief7zW7Su2ZTeBeznetG4rQQ=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=MaTYPWoe7xI1RuKph8crNeWcB0hwuIWRcjIN3L6aq2f9n0rL1DrdTZ9u27OTs1F94rOMkwZUGlJ9mV66DzIB2+ovEgoqSFT2NQF4AoQPfMPM1m4Q3+RUYbMF5+Luqjxd9pvUIuogCAdAkG24lxZzqcEvGEQP/QxBWzDV36KNPL8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Mj9a3zA8; arc=fail smtp.client-ip=52.101.52.61 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Mj9a3zA8" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HVqRXZvmr/aNdraDkV6+uudZBiSiDR3ha3vmRn9NFIgFcqPg+xlekG7a7lckCS1NVoUhvyu6bFcMCrxLOOMw3at1FPNuO616kCk0hpRgoFDt75gfY91Ilo0PmSXJeEr0MV1vSnqKQFu0g1traeoUC27qDVHsuk4qwczgMBHt2J69s4sun7af3gbLeAfvmgLB4cpp1R3q8byNPIJO4o5pYi40ZLJeZ7e73xE/aHndRt8CiXWRxqnZ+Tm8y+b90LPT0xHZvhyMqCIMgojbDM+JMrlGYtt/sMRTZArn9fN/dinUbanbcA0qI5GMrjG7VARp08MIuHMghmEpA1XPmYMcOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hNlEBFP3TcgRR3V815DR4RW7fjsg8CucXUxchjqllgw=; b=ekGQxpuUrP2uvftc8yF5xCKRvtJA+edpMDlvFHDgpKndgz5BmuseHCz6k2ZXhm8THVUW9S2XE0tVoG67mo52RCvyLInMxWBMKLRERiQRG6OjxWFTgWQFbIvz6D4MT11MmaS+kqiV5xT005GQvGWL4h+tsf7nG6prenZ5MVd4F2hCVdGOP1NZVWIDI9OaD1LR4tguMP8YF0Mwhq5rVLp6YOtOdsEvKmKRCX13Tb+kP8PsdfnLK6QoSaB8jL98JZoiajVAAef9v8da1Ye18jtmwCCSogsba9aRc008r4HtMQfpfrcwDaqGLVqnT6wMqQDE8usV3nxKMI4xdbT245+EPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hNlEBFP3TcgRR3V815DR4RW7fjsg8CucXUxchjqllgw=; b=Mj9a3zA8JOr8+I8KupNmJKT/TdQVIhLY5gCyCeEHMzrsNvDYLq8hL7M4mqZc07IzHnzqRhFYlTGESul9vWW2C5PL22R2kR16vKJOOE7t5bg6nsT+91+8XkV14+XrsYFRtgoxALLrcHzxGyvL+N502RT6JYymNbZtAVdSlsqJRxrmhjvoLOpL6S6z7EzrGULd8ed8dZQ7ybamqXOjMC3A4kVR1UWwjmj2NeEa3eASLXN/JkEdALGC8bfKm4ZOMju3eFWI80YLuYQBFSgWVKud0qBSqnokW7U1vnG7vYhAbxLNQ65UeCLx7k4y2pT/Nlhhou9hzQcodiX2Rjx90XQplQ== Received: from CH0P220CA0026.NAMP220.PROD.OUTLOOK.COM (2603:10b6:610:ef::22) by PH8PR12MB7374.namprd12.prod.outlook.com (2603:10b6:510:216::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9137.16; Mon, 22 Sep 2025 09:19:25 +0000 Received: from CH1PEPF0000A345.namprd04.prod.outlook.com (2603:10b6:610:ef:cafe::56) by CH0P220CA0026.outlook.office365.com (2603:10b6:610:ef::22) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9137.19 via Frontend Transport; Mon, 22 Sep 2025 09:19:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by CH1PEPF0000A345.mail.protection.outlook.com (10.167.244.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9137.12 via Frontend Transport; Mon, 22 Sep 2025 09:19:25 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Mon, 22 Sep 2025 02:19:13 -0700 Received: from drhqmail202.nvidia.com (10.126.190.181) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 22 Sep 2025 02:19:13 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Mon, 22 Sep 2025 02:19:09 -0700 From: Tariq Toukan To: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" CC: Saeed Mahameed , Tariq Toukan , "Mark Bloch" , Leon Romanovsky , "Jesper Dangaard Brouer" , Ilias Apalodimas , , , , Gal Pressman , Dragos Tatulea Subject: [PATCH net-next 2/2] net/mlx5e: Clamp page_pool size to max Date: Mon, 22 Sep 2025 12:18:35 +0300 Message-ID: <1758532715-820422-3-git-send-email-tariqt@nvidia.com> X-Mailer: git-send-email 2.8.0 In-Reply-To: <1758532715-820422-1-git-send-email-tariqt@nvidia.com> References: <1758532715-820422-1-git-send-email-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000A345:EE_|PH8PR12MB7374:EE_ X-MS-Office365-Filtering-Correlation-Id: 84ca2801-f769-4e27-522c-08ddf9b91fd6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|82310400026|7416014|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?KXMW+9TO2pD+Hlh3+CfDGBawWWBGINfCt0Gm+MxGRJaqS4v39yMJ/LD5aMFk?= =?us-ascii?Q?6OWCNptMtXimZ9ekKcce7MPjuhQbJxSuVqhZUhnkRO3bY6qGw6Vwy1732NQs?= =?us-ascii?Q?QCYwa9vNFAGUUu5u10W/g8soyew/QfMOtAoryT08vMYTxzo4MeXrQ1YxDfVe?= =?us-ascii?Q?GhsrLkX07kez7UymdAAwqjxSZh33IYfa9rMQ5R9LCZ6bsfQv95572HZlzO+4?= =?us-ascii?Q?F3Gh6O7zSvLjl162sTbfIqeTZ1wFyIn4JX/Epr6NqXkQNlOhIbejtqebtClk?= =?us-ascii?Q?YOZjKW3D0EAS7Rj57KaYAZQv03jG01xTkH9QG7S7YoIludpOpQVR4B0dobnF?= =?us-ascii?Q?bbXpWXd6DTAIyuxa96FNZ4UW25xDOxmKkU6ruZ0yVlvrpcGo4DG8++kgdO8h?= =?us-ascii?Q?VaDwXXapKSbltn1JG0lJfFhBgr7l1j7Q3oIxY1E66gZRCKBK1t9UqHQnACY6?= =?us-ascii?Q?0oNQEFdt2Vr5hScV2oodRm4BKXT5VynkQuqAvLGe0sXHfxDHfoKXdHZx6CjG?= =?us-ascii?Q?KwfTespCeE97MbQhtu89MHE2Kx9hB9TEy08cefi/RJPCs4iaJ2q387/4QASZ?= =?us-ascii?Q?OcTc6Lqns4DHB7GsTKWlJFeF/C9OSppWBqYNZWvJR5ljdjnAXd7xf5Q9KtG9?= =?us-ascii?Q?iwr01WDYRH/Y14wwaNPZ8XBVNvB0D8oTu9YL+pycdIc6I3hkaRe/MSk5kA+f?= =?us-ascii?Q?43RvNAsfvdyJPc6BDOqFvrZEni1QyOYxlSSCxF0bFx/iuQ7okigZvdSYGv0a?= =?us-ascii?Q?B2PShjuYmifAGXpRsbA5qRoxKoaf4+ej9sjgf3XtDowxLE5xVQnNMkw9UG6l?= =?us-ascii?Q?A8e37poVYpG19CrkIHWITJoobFFLewaD+jeHu7j9hQZ0O+7ve1FuZKV6kzp8?= =?us-ascii?Q?BW+bclZ33YaqUc5n5Yg0qDmJkCJY9ccIJQBX9sxA9BYfshbu4ni6Fj7vNkC/?= =?us-ascii?Q?6D5pRoBihEthwGTLLkvnvM26kI7VsCeN1fHughi/QiFI8LPaGERHBZLE+cuW?= =?us-ascii?Q?NSCIyWYGV471ONW1gmnqPQxxQbhB0pWpQHP5Ho6ZyDbtb3WrBo6zyKX6OJjD?= =?us-ascii?Q?gGUGa9bNcG6MC9A/GznjJPSiC9zrcx5s5qypJMopY4OLL1kZD8ATvT0Db7Od?= =?us-ascii?Q?wWvgcPsBA+2SEXwUkjob7sobPRHKaQy27XCn3OvdPN/q4EErP+Ap6Ausd5Mw?= =?us-ascii?Q?hh8wcXNRpkGJPIF4VgTW5T5Fn0i7f/lYGVGcBnr4k/IzsYnpzTZDP8kDCr7M?= =?us-ascii?Q?lpJLKCwo4/IZ+O9aV7SmgpcUYSzIwKLPLzDgtICJZi/LtfkOKI+5iy9e7/E1?= =?us-ascii?Q?0M+en/WfgheZy9Shlt+kWLJZoiQf2bfbMibztZuSaMB3RnrW3tkIauI5hUlR?= =?us-ascii?Q?DBWhw0sbCH2+C9WKn98gLRHMYkdSXY7X53oSZ3inyt3OWICWIo6ON24nVeLg?= =?us-ascii?Q?KldHuB6ck2hyPS8FJw+xuiSTP6VJGFjStF6W4btKaRkAzExzeZl3TP1CGJgN?= =?us-ascii?Q?n1GHstRhEc0i5oy/sSw/WWhcbmp9nk43O4wx?= X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230040)(36860700013)(82310400026)(7416014)(376014)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2025 09:19:25.3695 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 84ca2801-f769-4e27-522c-08ddf9b91fd6 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000A345.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7374 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Dragos Tatulea When the user configures a large ring size (8K) and a large MTU (9000) in HW-GRO mode, the queue will fail to allocate due to the size of the page_pool going above the limit. This change clamps the pool_size to the limit. Signed-off-by: Dragos Tatulea Signed-off-by: Tariq Toukan Reviewed-by: Dawid Osuchowski --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/ne= t/ethernet/mellanox/mlx5/core/en_main.c index 5e007bb3bad1..e56052895776 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c @@ -989,6 +989,8 @@ static int mlx5e_alloc_rq(struct mlx5e_params *params, /* Create a page_pool and register it with rxq */ struct page_pool_params pp_params =3D { 0 }; =20 + pool_size =3D min_t(u32, pool_size, PAGE_POOL_SIZE_LIMIT); + pp_params.order =3D 0; pp_params.flags =3D PP_FLAG_DMA_MAP | PP_FLAG_DMA_SYNC_DEV; pp_params.pool_size =3D pool_size; --=20 2.31.1