From nobody Thu Oct 2 09:22:04 2025 Received: from CO1PR03CU002.outbound.protection.outlook.com (mail-westus2azon11010023.outbound.protection.outlook.com [52.101.46.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8A8F2C08AC; Thu, 18 Sep 2025 10:44:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.46.23 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758192277; cv=fail; b=c61LFYuylnTAJPmxdHiJjm0pk9kXs+LTTDXdqFayBxXgDw/47/RYiigSQKpH169AIdIlZ8NSqiWoz5Nc8xzZAHQFT8Vui1ZffBZGNNo38q3WiJqow/cpgxPUCnmjfpiLzPik8ETEFum7TQlSaRoEw1pwKfWz4i2nZDx8pTlJvXI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758192277; c=relaxed/simple; bh=VoqeVIuuU+n4jSNKxwqKLlS5aDwAh4RWbgYJ8j/R5Ts=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=i/UThf/PDcwvYJYzvT8tU7D1ImxQzPe5cGfDvwFFjM+gFxagbIqXSPK8WtQv7rEK4AWomSy27bgfU8WtaOpAvr1ArEJ/ZFFsxFVDQ6BbdDtlcuO9m0p/ONDpy8TJn/UY1kLhLOZzisd9EHY0BCFYHQGgQasXS0hsTt4x3XuKSFQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=BubhRTfC; arc=fail smtp.client-ip=52.101.46.23 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="BubhRTfC" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=juCys61QGCGnIOAWwERvyLQiTTOQX52wSTUcYrQK78o2vYZW25GE2aKXvRKQ2Z1N7Epdu8nzDBTn/2j+f0brkahif+R38/KZUglDNevMnni/OXhx1AbovoLU58lPs09PovVcfbQNfhfd/Oewg29aEcSFn75KkiJf/BfMImuw8T/yUNPRpjkT6W+UviO/6XNrmi6DHds9Tp2Ge+3Ip+Yt7MwD1EF/zeNEh3TB8Cj33I3gbklywwO+IQxJ8A2x3ZEPrHhBwaP/GGq+KSAnW66dZKvRJmTe84JC0NwA70lfARPVayr81NQzEC4eoicMIPJfv+iOHtCiMTwtj2/5v3UQyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DuB845ZKWeW1cuJ2SyMT75kQK1wJgFZROXONcj/Qu2M=; b=MO1v5rIFVJsF9PRcGMVHzWgubkEJPFhjfy0ZC6FTvDWYqdVah6d2Iea7XMgSeLqwo6PKzyixcaaPYKrxTP/SQY+0m4aAew4JpLrrI6QSgjCvMeJYghitrZgpp2Vx437cJFzPONUuqFA12VyGOrkZQYPMyHocSm5q9USD9HSB5LKV/cD9V4oAWUTkOfJ5RlPAra/72FMw+RO9W+E8j7arjrAdhmcbWOd+dWo2APdWit6uPub4NapYNSxaYetFtMsWaSIpO/UWS47RQ49me3IYHPHmWQzndlwjztyYif+IHFCsgu+VP4Zz8Ps9JITS2EDUNNYX5quINXYXsEVxcDSE3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DuB845ZKWeW1cuJ2SyMT75kQK1wJgFZROXONcj/Qu2M=; b=BubhRTfC1TiYqwVYs2/qs9qp671Oyd5g7JZqbyOROaBOO7MRryAoOY2MR3N8oMMCbPq/dxzwMO4yz3Xh78WwuYpJe0cmh/w7EFawc9c1RGZkf0RdlQI5dQIHPSSlX+Ag9ruDilv2Z3QNbfWWjNgIrc1p2g9hx91hW6EWYOKF3iLb7E+9jmwICczb0wQG0WBVpNbK36Ox2xaxpiYQSEponUvzcm9ERuySBaZHdGErp1SIwYSYbvzajRqOqHtZVjSvfHmuIr3IIErtg9X7hPy80sMFaZXsf+ewx+MPNf5DsDYJ/HGSyw0lxJ7HO/PWLPoVpB+xQwnTOtGj2UPqzU9XDw== Received: from SN6PR16CA0045.namprd16.prod.outlook.com (2603:10b6:805:ca::22) by SJ2PR12MB7943.namprd12.prod.outlook.com (2603:10b6:a03:4c8::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9115.23; Thu, 18 Sep 2025 10:44:32 +0000 Received: from SA2PEPF00003AE6.namprd02.prod.outlook.com (2603:10b6:805:ca:cafe::f7) by SN6PR16CA0045.outlook.office365.com (2603:10b6:805:ca::22) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9137.14 via Frontend Transport; Thu, 18 Sep 2025 10:44:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SA2PEPF00003AE6.mail.protection.outlook.com (10.167.248.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9137.12 via Frontend Transport; Thu, 18 Sep 2025 10:44:31 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.34; Thu, 18 Sep 2025 03:44:21 -0700 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Thu, 18 Sep 2025 03:44:20 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Thu, 18 Sep 2025 03:44:15 -0700 From: Tariq Toukan To: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" CC: Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Mark Bloch , "Julia Lawall" , Nicolas Palix , Richard Cochran , , , , , "Gal Pressman" Subject: [PATCH net-next 1/2] scripts/coccinelle: Find PTR_ERR() to %pe candidates Date: Thu, 18 Sep 2025 13:43:46 +0300 Message-ID: <1758192227-701925-2-git-send-email-tariqt@nvidia.com> X-Mailer: git-send-email 2.8.0 In-Reply-To: <1758192227-701925-1-git-send-email-tariqt@nvidia.com> References: <1758192227-701925-1-git-send-email-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00003AE6:EE_|SJ2PR12MB7943:EE_ X-MS-Office365-Filtering-Correlation-Id: e8dbb6cd-f92e-4248-4876-08ddf6a059d1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|82310400026|36860700013|1800799024|13003099007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?271TJPTUkzAmqxJ6kNg/E+g8jAftuB+mB2wF1b23RSQZGSp48vwahG8zG0rB?= =?us-ascii?Q?kc+7oE2Kgm5T86Nyfb/RRH6DpeP6Vi9vt+etz5AEvbCodf70G0EH9R1wICoU?= =?us-ascii?Q?Mw1M2lUEp8V8OPfOwaF6IExZlgbk1ZIEt0wM9rGhF63b4ZY66GTg3rXbYIkt?= =?us-ascii?Q?sSjU9Kt9rTE5FXMSBlFsx3HPwJcMSQlBtGlSVFogHPD2Ch34WNsJp7V2xyVH?= =?us-ascii?Q?5LLDpAE8ikz+IN6xIfryJlwVNAXAVtHB3TTaOhxhcDKmIjHiVP5/6v+8NsZD?= =?us-ascii?Q?Etxs27NE91qeHTLFzECO3UQdrQK4Mml/xrZ/8exN89kQc291GJClt+hzCga1?= =?us-ascii?Q?G9kuhxoM5y8edhcXNe2z6g1hP0YHW06yoe/BfKzhpyp2QXjN4lHkGRUH2Jhm?= =?us-ascii?Q?RHSI4QDlBltC6917cUGbNbn9+ppqg6Jx9cjh8utFRADhrVD/z6VjxzRxUwHz?= =?us-ascii?Q?FR7dO9W5CiielTwyNaVRS2U/Qu2VUM6yuvNfywnbbz9tnvgP5szdO7FiATs7?= =?us-ascii?Q?7AggTbrTE0RSeNJQQsWJlbM9Kb+dBRIAZqolJV62JcUpggdpPJzBzMOeJV/S?= =?us-ascii?Q?OasrDYz8PBPZEZNi/O1uCtcES600BqPRQswQAYcLGUuiZ9UNIG7wcoGPkGdD?= =?us-ascii?Q?6c+a+/Zw/zmsaIR36QWVnxEPmK5Jpn+By3DgnmTbHdIUvECYsSeO/SUgI2WP?= =?us-ascii?Q?/htXLgdVlZe9AxpXXjIi9TJDnBQ/g73zQGXOyh1b9HuqPGrwN/bIMGivom5p?= =?us-ascii?Q?AjNUkrNkXjF8b2zzFVB6WO8NTTdpGugz2Jp9bLT6FPRe3Cp1xBG5AJoZ8iNR?= =?us-ascii?Q?xco9SnEarRAuvKSWtFA5CTrg13zp85rvOxKwb/3GzDzDFJP+wG2lroFw4ffQ?= =?us-ascii?Q?0yp+Rtq265JI111wc18qbZo351QbfehHmql4R0pqiBNMzOmQdWwZ59xwE86N?= =?us-ascii?Q?RHT0bmhSYyizgHA+FwHOsXZaMRLSnkNku09uxfkofu3LqIrkt7CmtL3YDHJb?= =?us-ascii?Q?+r6IZWusF2RpmJc1bpI/93bsLBKNvV9qtpRtL9drQSZm16YvpY/QPLiD+f4N?= =?us-ascii?Q?CaJL18hiwBDIMVYXH2p7gUHK5JbeR5+pIERJbdoPX8FhYFzCEzS4sO/tLgdK?= =?us-ascii?Q?yr32pX8+W0rGQdBWhIo3b72Ar2H6318Em6fPvA3rM7cTtB5kw1iI44XWqWL0?= =?us-ascii?Q?KEHwmsqozkU0iyV8Lu7OAd7Q43H5Ok/19tnhQag3hT+sItQ8ayr3y3EZM5yM?= =?us-ascii?Q?L0AQQ+/K/Dd/iHuIMYlb6gA7bRtFemjdULWRHtmvfsRgd2ljaIhsaGNAVcBe?= =?us-ascii?Q?z+EZmdjWYmOBm/6jzlnT6CW7TzsqXa8RBE42+Kp+JzfqoUvW/oCOkqmqit86?= =?us-ascii?Q?7I00wTvZ2p/9MscGvZ138VXk+qNe5Wn+uC01SFZ+B60F9/lbZAhC7ECeSyMG?= =?us-ascii?Q?oJzBn1w1HSt5p3vOImjJuQBwSXUd8fg01WDsBAAR5kdb7M5R+HUBHhi7uuIZ?= =?us-ascii?Q?Q3BON/AhcdWZD80QEP8ASeJCYC8l1ESEoJSS?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(7416014)(82310400026)(36860700013)(1800799024)(13003099007);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2025 10:44:31.6987 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e8dbb6cd-f92e-4248-4876-08ddf6a059d1 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00003AE6.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB7943 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Gal Pressman Add a new Coccinelle script to identify places where PTR_ERR() is used in print functions and suggest using the %pe format specifier instead. For printing error pointers (i.e., a pointer for which IS_ERR() is true) %pe will print a symbolic error name (e.g,. -EINVAL), opposed to the raw errno (e.g,. -22) produced by PTR_ERR(). It also makes the code cleaner by saving a redundant call to PTR_ERR(). The script supports context, report, and org modes. Example transformation: printk("Error: %ld\n", PTR_ERR(ptr)); // Before printk("Error: %pe\n", ptr); // After Signed-off-by: Gal Pressman Reviewed-by: Alexei Lazar Signed-off-by: Tariq Toukan Reviewed-by: Simon Horman --- scripts/coccinelle/misc/ptr_err_to_pe.cocci | 34 +++++++++++++++++++++ 1 file changed, 34 insertions(+) create mode 100644 scripts/coccinelle/misc/ptr_err_to_pe.cocci diff --git a/scripts/coccinelle/misc/ptr_err_to_pe.cocci b/scripts/coccinel= le/misc/ptr_err_to_pe.cocci new file mode 100644 index 000000000000..0494c7709245 --- /dev/null +++ b/scripts/coccinelle/misc/ptr_err_to_pe.cocci @@ -0,0 +1,34 @@ +// SPDX-License-Identifier: GPL-2.0-only +/// Use %pe format specifier instead of PTR_ERR() for printing error point= ers. +/// +/// For printing error pointers (i.e., a pointer for which IS_ERR() is tru= e) +/// %pe will print a symbolic error name (e.g., -EINVAL), opposed to the r= aw +/// errno (e.g., -22) produced by PTR_ERR(). +/// It also makes the code cleaner by saving a redundant call to PTR_ERR(). +/// +// Confidence: High +// Copyright: (C) 2025 NVIDIA CORPORATION & AFFILIATES. +// URL: https://coccinelle.gitlabpages.inria.fr/website +// Options: --no-includes --include-headers + +virtual context +virtual org +virtual report + +@r@ +expression ptr; +constant fmt; +position p; +identifier print_func; +@@ +* print_func(..., fmt, ..., PTR_ERR@p(ptr), ...) + +@script:python depends on r && report@ +p << r.p; +@@ +coccilib.report.print_report(p[0], "WARNING: Consider using %pe to print P= TR_ERR()") + +@script:python depends on r && org@ +p << r.p; +@@ +coccilib.org.print_todo(p[0], "WARNING: Consider using %pe to print PTR_ER= R()") --=20 2.31.1 From nobody Thu Oct 2 09:22:04 2025 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010063.outbound.protection.outlook.com [52.101.56.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAEEB2F361C; Thu, 18 Sep 2025 10:44:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.63 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758192292; cv=fail; b=eTzmvZ5ocYxePvrN9LpJbdIq8kBQVGEZJcfwZSBaGtx5E3qCub+jCC/ON7pI8JMIRysXfxgHkFJDPM62n3tTQv3FxVsheGedpK9pT4blwy/Kty3uXX1Nwu2h89ZVVVLCcb4UQmtV5+TNF2S8ckxnTOnbhSzbuu7fgQuRzSZBOF0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758192292; c=relaxed/simple; bh=WiDvdLcwyBaI4TDlJj/Yh/c3zOMXjuasmG7vD8GES5M=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Ncwy6Uf+qzJePXxdaDrOcB2akJ3UmIj9Tp239AoDf46YzHoaEXbqpWbqnDOZinh0JL9NByO+W1YMbL0VyoxoKQlgoSQNOpcETSUFyJ/zJBqDv9TYJqYoKVznsPPhJfkvHszGEYhB0BAHsJ0x1XH7uEfFnA/2gGbMxuwigWlozpM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=S7vLGtfw; arc=fail smtp.client-ip=52.101.56.63 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="S7vLGtfw" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rUz7vmzcrsGbXtfAVJNtPDR4rPx7kUbuD2IzKN8+YkkdePe9DER8sMDMi3O4u1soYG0EhyzFjQyua2AQtv4TinVWj3H3zGDW9p8bfWTsMHZLZOjdXKlpEUd/aIugJyWwJ8a0DHmAYv8W6rRvt+CtiPXTIdCoNi5iUfvX19Y8Mi9NnKSimNvpMKmsYgG66G/zY/FvMsM8EvcEM2HpGvh7ZbccMcNYIHz1Yr2vwfDXzFyQPzkPEHiRW4IMFGkgu3lKgjtvM/Qs8xQLw8y6Bbe5bXV+4Yhse8f5p7jdEaKeyb4/Vavj1GXhcvnvHi2tN9S6v3C2bQPHqfH2FlGpVWzmPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4EJ+TYw04hJGsyWBdww3UKxti0iD02NoopyzaCWsbCs=; b=Fci9IzbONhaQL/8iFABx3D4/BxnFPs7I8BGit28ksdq+lJi4z8PJGOtpIpoUsrMbcyRuu2vt0yZGr66+DsEkbowTXq9X/8k8DD1Nj8gqiwxhDsRJVfX/Rx2UMWCE5vY/mVSPe/iquqPu9I32nlGVV3SwbufZT/U9wzOlBgBKvLqX+BKISMiRPAP9O/hXzIaLVXtkOIxrQKMYrNaGeLBQlsrMaM4MYlJzkkLG5F/2ieCWfBL23Z7E1jFAHggabmrKeAIbFp0f60sTyXte9A2JLJoTvvtviw42TyiaES3NxndxJLwBZQIHvjQkN+rL07epyxEdEyBkZl9EJ95RClCuzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4EJ+TYw04hJGsyWBdww3UKxti0iD02NoopyzaCWsbCs=; b=S7vLGtfwr9kZyXUVZLi0cHfnBLhFYUR/DY2Y81jgSUkCaamsQeq/06mjABGZRik71fVK1wUJJro2FCTSlf8zFCrf4mREYbU0hEA8cMjXsjSpdJVC9yeu+wFGZ+dEZ1e/hW7AZnjdxXOHmv7BXFe3NTIDELyJmWsazBOUQz6gWGUImBjASpFkXumLfblCidfb4snRPZs3dQOJmKAHaGrudDJeoBbjMSEXDU7pjk0WlM9SUvJr9S6v2EFV2LyPWpEAgc5FBxOG1Gl29ZDtmCkWUjQHbGs2b/GufpVDyK3ejd9YKUHIBqbJKroB5NeDS86+s/ksDUQqU+YO3G0VRaAMfg== Received: from BLAP220CA0010.NAMP220.PROD.OUTLOOK.COM (2603:10b6:208:32c::15) by IA1PR12MB6212.namprd12.prod.outlook.com (2603:10b6:208:3e4::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9137.14; Thu, 18 Sep 2025 10:44:40 +0000 Received: from MN1PEPF0000F0E2.namprd04.prod.outlook.com (2603:10b6:208:32c:cafe::88) by BLAP220CA0010.outlook.office365.com (2603:10b6:208:32c::15) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9137.13 via Frontend Transport; Thu, 18 Sep 2025 10:44:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by MN1PEPF0000F0E2.mail.protection.outlook.com (10.167.242.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9137.12 via Frontend Transport; Thu, 18 Sep 2025 10:44:40 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Thu, 18 Sep 2025 03:44:26 -0700 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Thu, 18 Sep 2025 03:44:26 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Thu, 18 Sep 2025 03:44:21 -0700 From: Tariq Toukan To: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" CC: Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Mark Bloch , "Julia Lawall" , Nicolas Palix , Richard Cochran , , , , , "Gal Pressman" Subject: [PATCH net-next 2/2] net/mlx5: Use %pe format specifier for error pointers Date: Thu, 18 Sep 2025 13:43:47 +0300 Message-ID: <1758192227-701925-3-git-send-email-tariqt@nvidia.com> X-Mailer: git-send-email 2.8.0 In-Reply-To: <1758192227-701925-1-git-send-email-tariqt@nvidia.com> References: <1758192227-701925-1-git-send-email-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN1PEPF0000F0E2:EE_|IA1PR12MB6212:EE_ X-MS-Office365-Filtering-Correlation-Id: 45717ee0-e388-4570-0e89-08ddf6a05eec X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|376014|7416014|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?gswfTEoa4/M8iAVJ04N56k8gJop9HvHCgVfGlULi+wxbWeBvozn509Rdt/hp?= =?us-ascii?Q?ycFGZujISl2DMuzmjg4dBgkp6izHk8c/w7ukbztGOYXXlmdo8ljdLL56Y7jB?= =?us-ascii?Q?mYXM8RjY1gzjZzQCBsToT5Ebt4QEKI8qbUTTsR+VSDImvVO797r3UUl3Na7A?= =?us-ascii?Q?jresohI4b8W5Vs6SkhT+EcVGSulFeltIu+FgXbgpnb+3reiHCcnF31KqCEKs?= =?us-ascii?Q?JdP4FMb55EyV/PaXC1UWil/uY3TRXAz5wMnLCmNfdzFtB1ZyyIN2i9el5RsK?= =?us-ascii?Q?wiP5+V/WdBplhHDlenO1Et2f1Bd4fA/xEps2G9UXNSjhciWpl0gUOCfmjwIG?= =?us-ascii?Q?BNgycgHUKY74xkEiLR7AeetGHZtY1CwRp3VuudeP3oKRKIGbCJ+x1eIfY5L2?= =?us-ascii?Q?/hz3Gai+i2bs60wfkPKdr/+HGkxYgihF0aI+v7ATNljO2P0SIabEK/qtfIEh?= =?us-ascii?Q?1rggdrE8nmZZ1YfRy0zDpoW+vqOrrLRGdt2+nKMatzfwSupSHPH4efdKHXYG?= =?us-ascii?Q?cBJSfI+cYYFrY/FPR4fqAG6Gxh7Ofm9OLfQIIr/1U4mh9CrlYGhePvqkQDPF?= =?us-ascii?Q?6EpkpLUKEDrXilg5EyyEMHiThV9LwOhL2X1kvOUrSUYlsu9dmiAzjaTUZHCY?= =?us-ascii?Q?TYSb86UUrKwgNxSQq23gSZfNR5x9RZWL7yvIf5NnndCdBQcYaL9cUo+Zitz+?= =?us-ascii?Q?vHawb94QGFmtNZHet9F6vtD5FuLz4DCHnmhZs5j2Vxi+QbT41FQ2z1ZH0/Ek?= =?us-ascii?Q?/3rgTtEg0DbzTBHh/LFE/wMMptZcMtiLSSu/60oIYLWbBZF9skV/OPVtQldg?= =?us-ascii?Q?D7L49kEIiQGTnSBjJ4N6BgyHUBApReJi8tcT9sOr+xcCFk7oW7j0addOhFxE?= =?us-ascii?Q?zgIVadPM8s3ZgPYyexEDZLmAMy+XPyjC36UZ4Y8ChQWVXieBRtKddLv6+Kgw?= =?us-ascii?Q?fuf47/Tk48/vRmtRg6b/ot00/8+be5kh0rX93tSJHp4W4HfnWhBxpqxPyr9a?= =?us-ascii?Q?2/MQZciZX8Xzl93VSd2MsoP5y+vHW7DLN8ZO75HkDJAjW274yOsVQY+lrzEy?= =?us-ascii?Q?vQOZpkuD9nkOr+YIf5DTA2NITqmNshAUlOAU1OZfQmyjsSU+BQNvQ6xDGTDw?= =?us-ascii?Q?Pt90vkeqRHM+XX2zzaVj/+OuH0oJQDRj7xpoQfI9r0/uceNy+6topEE3Tr8q?= =?us-ascii?Q?vcIvpkuY01NGde4KRsNM9D5LehaCqAHp0Z/5HzSZS6mriREJrA9yHbWmLEqD?= =?us-ascii?Q?e4f4zPIuxHhux/RWSU25zaFl/dSSKasv8i1r12Q+iGkimhn6IiYnhi/qRmQp?= =?us-ascii?Q?JvPNzEwahTwxL8o8Zlm7WgtFdt8NpAG6FJNGdpgZOhh0lToR888FqhHBDMR5?= =?us-ascii?Q?P+1v11Om84BZZXaTjfeY3X1CepzQMwnqWZ5+ujkb579sAGEt79PaG7d6NSdW?= =?us-ascii?Q?ANVct/24c8vlyNXIV5MVYpQnnjr+QQIPKENDh8EMIBfG9et/aJuAV0vUAYLW?= =?us-ascii?Q?zsE4blZLcaFSvqUqMW1WRYSkHo9bTSa+RtY5?= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(376014)(7416014)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2025 10:44:40.2236 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 45717ee0-e388-4570-0e89-08ddf6a05eec X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: MN1PEPF0000F0E2.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6212 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Gal Pressman Using the coccinelle test introduced in previous commit (scripts/coccinelle/misc/ptr_err_to_pe.cocci), convert error logging throughout the mlx5 driver to use the %pe format specifier instead of PTR_ERR() with integer format specifiers. Signed-off-by: Gal Pressman Reviewed-by: Alexei Lazar Signed-off-by: Tariq Toukan Reviewed-by: Simon Horman --- .../mellanox/mlx5/core/diag/reporter_vnic.c | 4 +- .../mellanox/mlx5/core/en/hv_vhca_stats.c | 4 +- .../mellanox/mlx5/core/en/rep/bridge.c | 7 +-- .../mellanox/mlx5/core/en/reporter_rx.c | 4 +- .../mellanox/mlx5/core/en/reporter_tx.c | 4 +- .../mellanox/mlx5/core/en/tc/ct_fs_hmfs.c | 4 +- .../mellanox/mlx5/core/en/tc/ct_fs_smfs.c | 4 +- .../mellanox/mlx5/core/en/tc/int_port.c | 8 ++-- .../mellanox/mlx5/core/en/tc_tun_encap.c | 8 ++-- .../mellanox/mlx5/core/en_accel/fs_tcp.c | 2 +- .../mellanox/mlx5/core/en_accel/ipsec_fs.c | 4 +- .../ethernet/mellanox/mlx5/core/en_common.c | 4 +- .../net/ethernet/mellanox/mlx5/core/en_rep.c | 4 +- .../mellanox/mlx5/core/esw/acl/egress_lgcy.c | 4 +- .../ethernet/mellanox/mlx5/core/esw/bridge.c | 47 ++++++++++--------- .../mellanox/mlx5/core/esw/vporttbl.c | 4 +- .../net/ethernet/mellanox/mlx5/core/eswitch.c | 4 +- .../mellanox/mlx5/core/eswitch_offloads.c | 16 ++++--- .../net/ethernet/mellanox/mlx5/core/health.c | 8 ++-- .../mellanox/mlx5/core/irq_affinity.c | 4 +- .../ethernet/mellanox/mlx5/core/lib/clock.c | 4 +- .../net/ethernet/mellanox/mlx5/core/main.c | 4 +- 22 files changed, 80 insertions(+), 76 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/diag/reporter_vnic.c b= /drivers/net/ethernet/mellanox/mlx5/core/diag/reporter_vnic.c index 73f5b62b8c7f..a17f82321c25 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/diag/reporter_vnic.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/diag/reporter_vnic.c @@ -138,8 +138,8 @@ void mlx5_reporter_vnic_create(struct mlx5_core_dev *de= v) dev); if (IS_ERR(health->vnic_reporter)) mlx5_core_warn(dev, - "Failed to create vnic reporter, err =3D %ld\n", - PTR_ERR(health->vnic_reporter)); + "Failed to create vnic reporter, err =3D %pe\n", + health->vnic_reporter); } =20 void mlx5_reporter_vnic_destroy(struct mlx5_core_dev *dev) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/hv_vhca_stats.c b/d= rivers/net/ethernet/mellanox/mlx5/core/en/hv_vhca_stats.c index b4f3bd7d346e..195863b2c013 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/hv_vhca_stats.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/hv_vhca_stats.c @@ -138,8 +138,8 @@ void mlx5e_hv_vhca_stats_create(struct mlx5e_priv *priv) if (IS_ERR_OR_NULL(agent)) { if (IS_ERR(agent)) netdev_warn(priv->netdev, - "Failed to create hv vhca stats agent, err =3D %ld\n", - PTR_ERR(agent)); + "Failed to create hv vhca stats agent, err =3D %pe\n", + agent); =20 kvfree(priv->stats_agent.buf); return; diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/rep/bridge.c b/driv= ers/net/ethernet/mellanox/mlx5/core/en/rep/bridge.c index 0f5d7ea8956f..9d1c677814e0 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/rep/bridge.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/rep/bridge.c @@ -488,8 +488,8 @@ static int mlx5_esw_bridge_switchdev_event(struct notif= ier_block *nb, fdb_info, br_offloads); if (IS_ERR(work)) { - WARN_ONCE(1, "Failed to init switchdev work, err=3D%ld", - PTR_ERR(work)); + WARN_ONCE(1, "Failed to init switchdev work, err=3D%pe", + work); return notifier_from_errno(PTR_ERR(work)); } =20 @@ -527,7 +527,8 @@ void mlx5e_rep_bridge_init(struct mlx5e_priv *priv) br_offloads =3D mlx5_esw_bridge_init(esw); rtnl_unlock(); if (IS_ERR(br_offloads)) { - esw_warn(mdev, "Failed to init esw bridge (err=3D%ld)\n", PTR_ERR(br_off= loads)); + esw_warn(mdev, "Failed to init esw bridge (err=3D%pe)\n", + br_offloads); return; } =20 diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_rx.c b/dri= vers/net/ethernet/mellanox/mlx5/core/en/reporter_rx.c index eb1cace5910c..b1415992ffa2 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_rx.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_rx.c @@ -672,8 +672,8 @@ void mlx5e_reporter_rx_create(struct mlx5e_priv *priv) &mlx5_rx_reporter_ops, priv); if (IS_ERR(reporter)) { - netdev_warn(priv->netdev, "Failed to create rx reporter, err =3D %ld\n", - PTR_ERR(reporter)); + netdev_warn(priv->netdev, "Failed to create rx reporter, err =3D %pe\n", + reporter); return; } priv->rx_reporter =3D reporter; diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c b/dri= vers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c index 5a4fe8403a21..9e2cf191ed30 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c @@ -561,8 +561,8 @@ void mlx5e_reporter_tx_create(struct mlx5e_priv *priv) priv); if (IS_ERR(reporter)) { netdev_warn(priv->netdev, - "Failed to create tx reporter, err =3D %ld\n", - PTR_ERR(reporter)); + "Failed to create tx reporter, err =3D %pe\n", + reporter); return; } priv->tx_reporter =3D reporter; diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/ct_fs_hmfs.c b/d= rivers/net/ethernet/mellanox/mlx5/core/en/tc/ct_fs_hmfs.c index 01d522b02947..d3db6146fcad 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/ct_fs_hmfs.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc/ct_fs_hmfs.c @@ -136,8 +136,8 @@ mlx5_ct_fs_hmfs_matcher_get(struct mlx5_ct_fs *fs, stru= ct mlx5_flow_spec *spec, hws_bwc_matcher =3D mlx5_ct_fs_hmfs_matcher_create(fs, tbl, spec, ipv4, t= cp, gre); if (IS_ERR(hws_bwc_matcher)) { netdev_warn(fs->netdev, - "ct_fs_hmfs: failed to create bwc matcher (nat %d, ipv4 %d, tcp %d,= gre %d), err: %ld\n", - nat, ipv4, tcp, gre, PTR_ERR(hws_bwc_matcher)); + "ct_fs_hmfs: failed to create bwc matcher (nat %d, ipv4 %d, tcp %d,= gre %d), err: %pe\n", + nat, ipv4, tcp, gre, hws_bwc_matcher); =20 hmfs_matcher =3D ERR_CAST(hws_bwc_matcher); goto out_unlock; diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/ct_fs_smfs.c b/d= rivers/net/ethernet/mellanox/mlx5/core/en/tc/ct_fs_smfs.c index 0c97c5899904..4d6924b644c9 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/ct_fs_smfs.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc/ct_fs_smfs.c @@ -148,8 +148,8 @@ mlx5_ct_fs_smfs_matcher_get(struct mlx5_ct_fs *fs, bool= nat, bool ipv4, bool tcp dr_matcher =3D mlx5_ct_fs_smfs_matcher_create(fs, tbl, ipv4, tcp, gre, pr= io); if (IS_ERR(dr_matcher)) { netdev_warn(fs->netdev, - "ct_fs_smfs: failed to create matcher (nat %d, ipv4 %d, tcp %d, gre= %d), err: %ld\n", - nat, ipv4, tcp, gre, PTR_ERR(dr_matcher)); + "ct_fs_smfs: failed to create matcher (nat %d, ipv4 %d, tcp %d, gre= %d), err: %pe\n", + nat, ipv4, tcp, gre, dr_matcher); =20 smfs_matcher =3D ERR_CAST(dr_matcher); goto out_unlock; diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/int_port.c b/dri= vers/net/ethernet/mellanox/mlx5/core/en/tc/int_port.c index 8afcec0c5d3c..896f718483c3 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/int_port.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc/int_port.c @@ -93,8 +93,8 @@ mlx5e_int_port_create_rx_rule(struct mlx5_eswitch *esw, flow_rule =3D mlx5_add_flow_rules(esw->offloads.ft_offloads, spec, &flow_act, dest, 1); if (IS_ERR(flow_rule)) - mlx5_core_warn(esw->dev, "ft offloads: Failed to add internal vport rx r= ule err %ld\n", - PTR_ERR(flow_rule)); + mlx5_core_warn(esw->dev, "ft offloads: Failed to add internal vport rx r= ule err %pe\n", + flow_rule); =20 kvfree(spec); =20 @@ -322,8 +322,8 @@ mlx5e_tc_int_port_init(struct mlx5e_priv *priv) sizeof(u32) * 2, (1 << ESW_VPORT_BITS) - 1, true); if (IS_ERR(int_port_priv->metadata_mapping)) { - mlx5_core_warn(priv->mdev, "Can't allocate metadata mapping of int port = offload, err=3D%ld\n", - PTR_ERR(int_port_priv->metadata_mapping)); + mlx5_core_warn(priv->mdev, "Can't allocate metadata mapping of int port = offload, err=3D%pe\n", + int_port_priv->metadata_mapping); goto err_mapping; } =20 diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_encap.c b/dr= ivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_encap.c index a0fc76a1bc08..0735d10f2bac 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_encap.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_encap.c @@ -172,8 +172,8 @@ void mlx5e_tc_encap_flows_add(struct mlx5e_priv *priv, &reformat_params, MLX5_FLOW_NAMESPACE_FDB); if (IS_ERR(e->pkt_reformat)) { - mlx5_core_warn(priv->mdev, "Failed to offload cached encapsulation heade= r, %lu\n", - PTR_ERR(e->pkt_reformat)); + mlx5_core_warn(priv->mdev, "Failed to offload cached encapsulation heade= r, %pe\n", + e->pkt_reformat); return; } e->flags |=3D MLX5_ENCAP_ENTRY_VALID; @@ -1845,8 +1845,8 @@ static int mlx5e_tc_tun_fib_event(struct notifier_blo= ck *nb, unsigned long event queue_work(priv->wq, &fib_work->work); } else if (IS_ERR(fib_work)) { NL_SET_ERR_MSG_MOD(info->extack, "Failed to init fib work"); - mlx5_core_warn(priv->mdev, "Failed to init fib work, %ld\n", - PTR_ERR(fib_work)); + mlx5_core_warn(priv->mdev, "Failed to init fib work, %pe\n", + fib_work); } =20 break; diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c b/dr= ivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c index 4f83e3172767..1febdc5b81f9 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c @@ -138,7 +138,7 @@ struct mlx5_flow_handle *mlx5e_accel_fs_add_sk(struct m= lx5e_flow_steering *fs, flow =3D mlx5_add_flow_rules(ft->t, spec, &flow_act, &dest, 1); =20 if (IS_ERR(flow)) - fs_err(fs, "mlx5_add_flow_rules() failed, flow is %ld\n", PTR_ERR(flow)); + fs_err(fs, "mlx5_add_flow_rules() failed, flow is %pe\n", flow); =20 out: kvfree(spec); diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c b/= drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c index 98b6a3a623f9..cc067a0a3151 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c @@ -1704,8 +1704,8 @@ static int setup_modify_header(struct mlx5e_ipsec *ip= sec, int type, u32 val, u8 =20 modify_hdr =3D mlx5_modify_header_alloc(mdev, ns_type, num_of_actions, ac= tion); if (IS_ERR(modify_hdr)) { - mlx5_core_err(mdev, "Failed to allocate modify_header %ld\n", - PTR_ERR(modify_hdr)); + mlx5_core_err(mdev, "Failed to allocate modify_header %pe\n", + modify_hdr); return PTR_ERR(modify_hdr); } =20 diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_common.c b/drivers/= net/ethernet/mellanox/mlx5/core/en_common.c index 96b744ceaf13..30424ccad584 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_common.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_common.c @@ -210,8 +210,8 @@ int mlx5e_create_mdev_resources(struct mlx5_core_dev *m= dev, bool create_tises) =20 mdev->mlx5e_res.dek_priv =3D mlx5_crypto_dek_init(mdev); if (IS_ERR(mdev->mlx5e_res.dek_priv)) { - mlx5_core_err(mdev, "crypto dek init failed, %ld\n", - PTR_ERR(mdev->mlx5e_res.dek_priv)); + mlx5_core_err(mdev, "crypto dek init failed, %pe\n", + mdev->mlx5e_res.dek_priv); mdev->mlx5e_res.dek_priv =3D NULL; } =20 diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c b/drivers/net= /ethernet/mellanox/mlx5/core/en_rep.c index b231e7855bca..d91db3c8c1b7 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c @@ -1450,8 +1450,8 @@ static void mlx5e_rep_vnic_reporter_create(struct mlx= 5e_priv *priv, rpriv); if (IS_ERR(reporter)) { mlx5_core_err(priv->mdev, - "Failed to create representor vnic reporter, err =3D %ld\n", - PTR_ERR(reporter)); + "Failed to create representor vnic reporter, err =3D %pe\n", + reporter); return; } =20 diff --git a/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/egress_lgcy.c = b/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/egress_lgcy.c index 7dd1dc3f77c7..c9a1654d83a2 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/egress_lgcy.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/egress_lgcy.c @@ -87,8 +87,8 @@ int esw_acl_egress_lgcy_setup(struct mlx5_eswitch *esw, drop_counter =3D mlx5_fc_create(esw->dev, false); if (IS_ERR(drop_counter)) { esw_warn(esw->dev, - "vport[%d] configure egress drop rule counter err(%ld)\n", - vport->vport, PTR_ERR(drop_counter)); + "vport[%d] configure egress drop rule counter err(%pe)\n", + vport->vport, drop_counter); drop_counter =3D NULL; } vport->egress.legacy.drop_counter =3D drop_counter; diff --git a/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c b/drivers= /net/ethernet/mellanox/mlx5/core/esw/bridge.c index 76e35c827da0..60e10047770f 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c @@ -81,7 +81,8 @@ mlx5_esw_bridge_table_create(int max_fte, u32 level, stru= ct mlx5_eswitch *esw) ft_attr.prio =3D FDB_BR_OFFLOAD; fdb =3D mlx5_create_flow_table(ns, &ft_attr); if (IS_ERR(fdb)) - esw_warn(dev, "Failed to create bridge FDB Table (err=3D%ld)\n", PTR_ERR= (fdb)); + esw_warn(dev, "Failed to create bridge FDB Table (err=3D%pe)\n", + fdb); =20 return fdb; } @@ -121,8 +122,8 @@ mlx5_esw_bridge_ingress_vlan_proto_fg_create(unsigned i= nt from, unsigned int to, kvfree(in); if (IS_ERR(fg)) esw_warn(esw->dev, - "Failed to create VLAN(proto=3D%x) flow group for bridge ingress table= (err=3D%ld)\n", - vlan_proto, PTR_ERR(fg)); + "Failed to create VLAN(proto=3D%x) flow group for bridge ingress table= (err=3D%pe)\n", + vlan_proto, fg); =20 return fg; } @@ -180,8 +181,8 @@ mlx5_esw_bridge_ingress_vlan_proto_filter_fg_create(uns= igned int from, unsigned fg =3D mlx5_create_flow_group(ingress_ft, in); if (IS_ERR(fg)) esw_warn(esw->dev, - "Failed to create bridge ingress table VLAN filter flow group (err=3D%= ld)\n", - PTR_ERR(fg)); + "Failed to create bridge ingress table VLAN filter flow group (err=3D%= pe)\n", + fg); kvfree(in); return fg; } @@ -237,8 +238,8 @@ mlx5_esw_bridge_ingress_mac_fg_create(struct mlx5_eswit= ch *esw, struct mlx5_flow fg =3D mlx5_create_flow_group(ingress_ft, in); if (IS_ERR(fg)) esw_warn(esw->dev, - "Failed to create MAC flow group for bridge ingress table (err=3D%ld)\= n", - PTR_ERR(fg)); + "Failed to create MAC flow group for bridge ingress table (err=3D%pe)\= n", + fg); =20 kvfree(in); return fg; @@ -274,8 +275,8 @@ mlx5_esw_bridge_egress_vlan_proto_fg_create(unsigned in= t from, unsigned int to, fg =3D mlx5_create_flow_group(egress_ft, in); if (IS_ERR(fg)) esw_warn(esw->dev, - "Failed to create VLAN flow group for bridge egress table (err=3D%ld)\= n", - PTR_ERR(fg)); + "Failed to create VLAN flow group for bridge egress table (err=3D%pe)\= n", + fg); kvfree(in); return fg; } @@ -324,8 +325,8 @@ mlx5_esw_bridge_egress_mac_fg_create(struct mlx5_eswitc= h *esw, struct mlx5_flow_ fg =3D mlx5_create_flow_group(egress_ft, in); if (IS_ERR(fg)) esw_warn(esw->dev, - "Failed to create bridge egress table MAC flow group (err=3D%ld)\n", - PTR_ERR(fg)); + "Failed to create bridge egress table MAC flow group (err=3D%pe)\n", + fg); kvfree(in); return fg; } @@ -354,8 +355,8 @@ mlx5_esw_bridge_egress_miss_fg_create(struct mlx5_eswit= ch *esw, struct mlx5_flow fg =3D mlx5_create_flow_group(egress_ft, in); if (IS_ERR(fg)) esw_warn(esw->dev, - "Failed to create bridge egress table miss flow group (err=3D%ld)\n", - PTR_ERR(fg)); + "Failed to create bridge egress table miss flow group (err=3D%pe)\n", + fg); kvfree(in); return fg; } @@ -501,8 +502,8 @@ mlx5_esw_bridge_egress_table_init(struct mlx5_esw_bridg= e_offloads *br_offloads, if (mlx5_esw_bridge_pkt_reformat_vlan_pop_supported(esw)) { miss_fg =3D mlx5_esw_bridge_egress_miss_fg_create(esw, egress_ft); if (IS_ERR(miss_fg)) { - esw_warn(esw->dev, "Failed to create miss flow group (err=3D%ld)\n", - PTR_ERR(miss_fg)); + esw_warn(esw->dev, "Failed to create miss flow group (err=3D%pe)\n", + miss_fg); miss_fg =3D NULL; goto skip_miss_flow; } @@ -510,8 +511,8 @@ mlx5_esw_bridge_egress_table_init(struct mlx5_esw_bridg= e_offloads *br_offloads, miss_pkt_reformat =3D mlx5_esw_bridge_pkt_reformat_vlan_pop_create(esw); if (IS_ERR(miss_pkt_reformat)) { esw_warn(esw->dev, - "Failed to alloc packet reformat REMOVE_HEADER (err=3D%ld)\n", - PTR_ERR(miss_pkt_reformat)); + "Failed to alloc packet reformat REMOVE_HEADER (err=3D%pe)\n", + miss_pkt_reformat); miss_pkt_reformat =3D NULL; mlx5_destroy_flow_group(miss_fg); miss_fg =3D NULL; @@ -522,8 +523,8 @@ mlx5_esw_bridge_egress_table_init(struct mlx5_esw_bridg= e_offloads *br_offloads, br_offloads->skip_ft, miss_pkt_reformat); if (IS_ERR(miss_handle)) { - esw_warn(esw->dev, "Failed to create miss flow (err=3D%ld)\n", - PTR_ERR(miss_handle)); + esw_warn(esw->dev, "Failed to create miss flow (err=3D%pe)\n", + miss_handle); miss_handle =3D NULL; mlx5_packet_reformat_dealloc(esw->dev, miss_pkt_reformat); miss_pkt_reformat =3D NULL; @@ -1048,8 +1049,8 @@ mlx5_esw_bridge_vlan_push_create(u16 vlan_proto, stru= ct mlx5_esw_bridge_vlan *vl &reformat_params, MLX5_FLOW_NAMESPACE_FDB); if (IS_ERR(pkt_reformat)) { - esw_warn(esw->dev, "Failed to alloc packet reformat INSERT_HEADER (err= =3D%ld)\n", - PTR_ERR(pkt_reformat)); + esw_warn(esw->dev, "Failed to alloc packet reformat INSERT_HEADER (err= =3D%pe)\n", + pkt_reformat); return PTR_ERR(pkt_reformat); } =20 @@ -1076,8 +1077,8 @@ mlx5_esw_bridge_vlan_pop_create(struct mlx5_esw_bridg= e_vlan *vlan, struct mlx5_e =20 pkt_reformat =3D mlx5_esw_bridge_pkt_reformat_vlan_pop_create(esw); if (IS_ERR(pkt_reformat)) { - esw_warn(esw->dev, "Failed to alloc packet reformat REMOVE_HEADER (err= =3D%ld)\n", - PTR_ERR(pkt_reformat)); + esw_warn(esw->dev, "Failed to alloc packet reformat REMOVE_HEADER (err= =3D%pe)\n", + pkt_reformat); return PTR_ERR(pkt_reformat); } =20 diff --git a/drivers/net/ethernet/mellanox/mlx5/core/esw/vporttbl.c b/drive= rs/net/ethernet/mellanox/mlx5/core/esw/vporttbl.c index 749c3957a128..407062096a82 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/esw/vporttbl.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/vporttbl.c @@ -45,8 +45,8 @@ esw_vport_tbl_create(struct mlx5_eswitch *esw, struct mlx= 5_flow_namespace *ns, ft_attr.flags =3D vport_ns->flags; fdb =3D mlx5_create_auto_grouped_flow_table(ns, &ft_attr); if (IS_ERR(fdb)) { - esw_warn(esw->dev, "Failed to create per vport FDB Table err %ld\n", - PTR_ERR(fdb)); + esw_warn(esw->dev, "Failed to create per vport FDB Table err %pe\n", + fdb); } =20 return fdb; diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c b/drivers/ne= t/ethernet/mellanox/mlx5/core/eswitch.c index 10eca910a2db..e2ffb87b94cb 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c @@ -257,8 +257,8 @@ __esw_fdb_set_vport_rule(struct mlx5_eswitch *esw, u16 = vport, bool rx_rule, &flow_act, &dest, 1); if (IS_ERR(flow_rule)) { esw_warn(esw->dev, - "FDB: Failed to add flow rule: dmac_v(%pM) dmac_c(%pM) -> vport(%d), e= rr(%ld)\n", - dmac_v, dmac_c, vport, PTR_ERR(flow_rule)); + "FDB: Failed to add flow rule: dmac_v(%pM) dmac_c(%pM) -> vport(%d), e= rr(%pe)\n", + dmac_v, dmac_c, vport, flow_rule); flow_rule =3D NULL; } =20 diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c b/d= rivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c index bc9838dc5bf8..b8ec55929ab1 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c @@ -1016,8 +1016,8 @@ mlx5_eswitch_add_send_to_vport_rule(struct mlx5_eswit= ch *on_esw, flow_rule =3D mlx5_add_flow_rules(mlx5_eswitch_get_slow_fdb(on_esw), spec, &flow_act, &dest, 1); if (IS_ERR(flow_rule)) - esw_warn(on_esw->dev, "FDB: Failed to add send to vport rule err %ld\n", - PTR_ERR(flow_rule)); + esw_warn(on_esw->dev, "FDB: Failed to add send to vport rule err %pe\n", + flow_rule); out: kvfree(spec); return flow_rule; @@ -1065,8 +1065,8 @@ mlx5_eswitch_add_send_to_vport_meta_rule(struct mlx5_= eswitch *esw, u16 vport_num flow_rule =3D mlx5_add_flow_rules(mlx5_eswitch_get_slow_fdb(esw), spec, &flow_act, &dest, 1); if (IS_ERR(flow_rule)) - esw_warn(esw->dev, "FDB: Failed to add send to vport meta rule vport %d,= err %ld\n", - vport_num, PTR_ERR(flow_rule)); + esw_warn(esw->dev, "FDB: Failed to add send to vport meta rule vport %d,= err %pe\n", + vport_num, flow_rule); =20 kvfree(spec); return flow_rule; @@ -2159,7 +2159,9 @@ mlx5_eswitch_create_vport_rx_rule(struct mlx5_eswitch= *esw, u16 vport, flow_rule =3D mlx5_add_flow_rules(esw->offloads.ft_offloads, spec, &flow_act, dest, 1); if (IS_ERR(flow_rule)) { - esw_warn(esw->dev, "fs offloads: Failed to add vport rx rule err %ld\n",= PTR_ERR(flow_rule)); + esw_warn(esw->dev, + "fs offloads: Failed to add vport rx rule err %pe\n", + flow_rule); goto out; } =20 @@ -2178,8 +2180,8 @@ static int esw_create_vport_rx_drop_rule(struct mlx5_= eswitch *esw) &flow_act, NULL, 0); if (IS_ERR(flow_rule)) { esw_warn(esw->dev, - "fs offloads: Failed to add vport rx drop rule err %ld\n", - PTR_ERR(flow_rule)); + "fs offloads: Failed to add vport rx drop rule err %pe\n", + flow_rule); return PTR_ERR(flow_rule); } =20 diff --git a/drivers/net/ethernet/mellanox/mlx5/core/health.c b/drivers/net= /ethernet/mellanox/mlx5/core/health.c index b63c5a221eb9..aeeb136f5ebc 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/health.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/health.c @@ -718,15 +718,15 @@ void mlx5_fw_reporters_create(struct mlx5_core_dev *d= ev) =20 health->fw_reporter =3D devl_health_reporter_create(devlink, fw_ops, dev); if (IS_ERR(health->fw_reporter)) - mlx5_core_warn(dev, "Failed to create fw reporter, err =3D %ld\n", - PTR_ERR(health->fw_reporter)); + mlx5_core_warn(dev, "Failed to create fw reporter, err =3D %pe\n", + health->fw_reporter); =20 health->fw_fatal_reporter =3D devl_health_reporter_create(devlink, fw_fatal_ops, dev); if (IS_ERR(health->fw_fatal_reporter)) - mlx5_core_warn(dev, "Failed to create fw fatal reporter, err =3D %ld\n", - PTR_ERR(health->fw_fatal_reporter)); + mlx5_core_warn(dev, "Failed to create fw fatal reporter, err =3D %pe\n", + health->fw_fatal_reporter); } =20 static void mlx5_fw_reporters_destroy(struct mlx5_core_dev *dev) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/irq_affinity.c b/drive= rs/net/ethernet/mellanox/mlx5/core/irq_affinity.c index 82d3c2568244..14d339eceb92 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/irq_affinity.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/irq_affinity.c @@ -150,8 +150,8 @@ mlx5_irq_affinity_request(struct mlx5_core_dev *dev, st= ruct mlx5_irq_pool *pool, if (IS_ERR(new_irq)) { if (!least_loaded_irq) { /* We failed to create an IRQ and we didn't find an IRQ */ - mlx5_core_err(pool->dev, "Didn't find a matching IRQ. err =3D %ld\n", - PTR_ERR(new_irq)); + mlx5_core_err(pool->dev, "Didn't find a matching IRQ. err =3D %pe\n", + new_irq); mutex_unlock(&pool->lock); return new_irq; } diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c b/drivers/= net/ethernet/mellanox/mlx5/core/lib/clock.c index 8f2ad45bec9f..d0ba83d77cd1 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c @@ -1365,9 +1365,9 @@ static void mlx5_init_clock_dev(struct mlx5_core_dev = *mdev) clock->ptp =3D ptp_clock_register(&clock->ptp_info, clock->shared ? NULL : &mdev->pdev->dev); if (IS_ERR(clock->ptp)) { - mlx5_core_warn(mdev, "%sptp_clock_register failed %ld\n", + mlx5_core_warn(mdev, "%sptp_clock_register failed %pe\n", clock->shared ? "shared clock " : "", - PTR_ERR(clock->ptp)); + clock->ptp); clock->ptp =3D NULL; } =20 diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/e= thernet/mellanox/mlx5/core/main.c index 6b6d6b05b893..df93625c9dfa 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/main.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c @@ -979,8 +979,8 @@ static int mlx5_init_once(struct mlx5_core_dev *dev) =20 dev->priv.devc =3D mlx5_devcom_register_device(dev); if (IS_ERR(dev->priv.devc)) - mlx5_core_warn(dev, "failed to register devcom device %ld\n", - PTR_ERR(dev->priv.devc)); + mlx5_core_warn(dev, "failed to register devcom device %pe\n", + dev->priv.devc); =20 err =3D mlx5_query_board_id(dev); if (err) { --=20 2.31.1