From nobody Thu Oct 2 16:32:33 2025 Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11013034.outbound.protection.outlook.com [40.93.201.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D08A4315D2D; Mon, 15 Sep 2025 12:25:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.201.34 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757939152; cv=fail; b=pYL+QSsxsHVexgCaGQ55KqnxH1IMr2n230GQW33Qh2FW7nBOQVLo+szXMHZk888ZMCK8zJnfBXtDFyhmb1aTZrkYyL+2jjR/gmpJlgfeS3pua+ODIHi6RPmDeOQhLc7qOdJwpnrOdmlaS0eqIKPFSmrW4+tLMou3yjfCxXIHTyc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757939152; c=relaxed/simple; bh=xVTMPZT2ppptE0D/2lE8CnMnjCBSeNeAKBjdicvrjn8=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=XJERIbM2PiJlyKXePsQHXAx5OfHOS2MpSyyIbmAyZ1ZkUUTUcsDlZZtSkVD41UjMc6RqWRF6xuz7KteyFJJezP19rKHKsAyVG/R2qJQ/XTHf77vIwnfN4poy0NCe7MD16T3SsX30RfESe2ROt6EFwPWRB8wK7T2BNRZcAdRIzD0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=t+tpuP2I; arc=fail smtp.client-ip=40.93.201.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="t+tpuP2I" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aCZtpp/QJqtcu/Gu9UjKUOlUIrLyMLl2GlIoQPL1z7Sq5/i4brj6+6uh2UwT6hQwuSr73l38pLpkHHqIbIJgqIRtB5iufE0ccaKPTxQ00VBiBacOP9ON6S+mJk7m68uZeK5eYpPdX7ev2uzLcGwhb4GMYpU9xkJ1cNrwHYAFzeO8oumCq62li2wgKySIAwxDXKdwltHXv0DNxAhNnib+4BJbgQOomvsZxCVirgqTVsPJAMUHx5ILllBn/ArjnLx6jiEaUfEbfXn+Rw8cIdhUTgD2jSS58ibVFRrAuXHFcbSMIr4AlyKe6S42awGySC+QndyZqPnTF5Ec2nDIpbhMww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Aar3LQzX+gT8itRDR4xmeGR9frS0rN0gnZHfQMBuJ84=; b=DIfDkAxnU3fznmcabJSJxp42P7AGyuzR2GuoYTkf/zZz8bOqwJSFHrFhDYpcvHQqEWvnpBtVoAwDlYSsVCkQ3AtSmSJKFVPN3CPl5RcS4klEqK9jutM0zJEk+H4qVwyo+td19g/V3w+KpBO+aq4t9p8bD+jRZTcg8/Vjj2YotkJzbQ5qacV4QMrnDtnTs3LHs8j5bZ2oJ7qbJUsgQmQa/Sh7GubuUKgg5C0fPELDjvoIQijHaRaWTOPtUy78n/S3EenhVtnAK5rCYJtsamJIJTfdSJmXRikTNgQDA3pRZmSZPzQOhYQC6jx8nywN9bk0ZMpH4jzk8bRqA0EH4orXaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Aar3LQzX+gT8itRDR4xmeGR9frS0rN0gnZHfQMBuJ84=; b=t+tpuP2IQ/HxQEB2hjBR+VxCykHTdR5192E9UGy+jJpw6N6b0Dz5pkrGSBiY4qXSjh8ROccNxMy+DsNv2z3hMlSSGWlszPHr4EfkGBb3Yxh5hmqb+2zfqYvheZGyzyh4HBys6cTJOGb/hWYZwvF0fHIvFnZjSQCnTE4DcnJ7LxbJryCGVVJaYgmwT2+thHSrkKG9bANohYTeEMf+cuS+jYv8oLEdYBe1IGozImsh4TrJugHgfY2t3hqUfRl05z2PDl+gCa4pf3Z1EE8WP7hhJghKcUMU3Biks1q8UMfm4dE5fxbMT1jG9G9DL5D3GepMwRZ4kvS+bzhEGLiZtpQXaw== Received: from SJ0PR13CA0048.namprd13.prod.outlook.com (2603:10b6:a03:2c2::23) by DS0PR12MB8453.namprd12.prod.outlook.com (2603:10b6:8:157::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9115.21; Mon, 15 Sep 2025 12:25:48 +0000 Received: from CY4PEPF0000EDD3.namprd03.prod.outlook.com (2603:10b6:a03:2c2:cafe::5b) by SJ0PR13CA0048.outlook.office365.com (2603:10b6:a03:2c2::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9137.8 via Frontend Transport; Mon, 15 Sep 2025 12:25:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000EDD3.mail.protection.outlook.com (10.167.241.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9137.12 via Frontend Transport; Mon, 15 Sep 2025 12:25:47 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Mon, 15 Sep 2025 05:25:37 -0700 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Mon, 15 Sep 2025 05:25:36 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Mon, 15 Sep 2025 05:25:31 -0700 From: Tariq Toukan To: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" CC: Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Mark Bloch , , , , Gal Pressman , Lama Kayal , Jianbo Liu , Chris Mi Subject: [PATCH net V2 3/3] net/mlx5e: Add a miss level for ipsec crypto offload Date: Mon, 15 Sep 2025 15:24:34 +0300 Message-ID: <1757939074-617281-4-git-send-email-tariqt@nvidia.com> X-Mailer: git-send-email 2.8.0 In-Reply-To: <1757939074-617281-1-git-send-email-tariqt@nvidia.com> References: <1757939074-617281-1-git-send-email-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EDD3:EE_|DS0PR12MB8453:EE_ X-MS-Office365-Filtering-Correlation-Id: 7fd2c0f4-00b9-46ae-c62c-08ddf453001e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|36860700013|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?01SclVeqnEoIspWzNc+rSUopnWCMNyrW6PKzoOJD1YIoXcP5J4IQ9hBhS647?= =?us-ascii?Q?6vialaXgFJ/VEQ2ETg8P8SZISsTNHVoFu/S9B/0Z5zjR4bML2FPBs3uXSmKW?= =?us-ascii?Q?vgklgHx1wlfJl6fq7b3bvrPAWGs7PtjS7hZKVcefrjl728vB2qchJt2MRL4n?= =?us-ascii?Q?U2NwzF1wNGPRcq+L19IsJleN9IvO+jESEVEbw6IbZTp7SMC4dmRBBDpTqm4A?= =?us-ascii?Q?dZDMzANcj8zSl/QsJGQfFOrVgUKYTHxa2i8zR4gKN5fpMnamG7hTHPNlpudE?= =?us-ascii?Q?6Lu1DzfltTN2Xs2mOwdJFyniQNQuPCpdh3Gk1bYPCYsAu6WAdfBQY02FiQB4?= =?us-ascii?Q?WA9fxlzv72bLg3joYQ5KDrsmlyNUqL8EIANhxzfITwm+HOkaJBKV2oLJTjl/?= =?us-ascii?Q?TYChNNw8bULUqnMY9GITABzToLD6peL9a82JqjKDxAhNO2ztX6C+bkK0OsJC?= =?us-ascii?Q?mx5i+AkeYR1nEk0k51lwX4D6MvTGAVUY+PRj2e2dvjC0ywuff1T0xJpax2CF?= =?us-ascii?Q?YShm3IlgtKQfSjPBNZ3dwnPAI6BUFBilO9H90hSSsLgjAC26mC/nNC1KrYpy?= =?us-ascii?Q?j2wGS5xPMjOKvOdFxg9eKxojZsfH0zkwqS94+mCwN0iSiM/kllfhdhu2kZSj?= =?us-ascii?Q?kZNQa+65obeSe0Ulk1Rmn74Li1YG7WPebSqLbASb6OJtQOnKTZEWmdKmkIux?= =?us-ascii?Q?qxj13uJAy+dS7OZ91MrhgRrQUeWhTBTHdQBoAODHK0CHfFTTgbu/ykfAPVJi?= =?us-ascii?Q?/Udrkltz4qYYlq3aWMBMHC05nEbXe6/yavu3BWQJ8LNMeGC7IQDVLQj8nXFM?= =?us-ascii?Q?97ASdl7k7dTYxE1tnOKk/inh5W2fLHA+mSaSo+2+pSzFEP2WZ1yO1jnJvgjT?= =?us-ascii?Q?us9ESQ2gYqxG7JxFcK0qq4JV167B80I9ByC3gdYkaEcSUnJNQ4fRyWtGxYDI?= =?us-ascii?Q?iIr0rpDrrqfqx2CLnbKLCnklK1MqG9rEZeWmCt2E4LXbTcICPJJBswoPYY0g?= =?us-ascii?Q?Yl3QKQjVFx+E9RtZ8B9YJGsv8pXowzbr94ECiMm6B4btae7gUT5wAoFQBbD8?= =?us-ascii?Q?Ykt3ydgk55R5O+uTWs43H5opN+9HOzpjtBK13Op1m5v3R7FPdSAVinp6J/bS?= =?us-ascii?Q?d8quNVPTJ0CibnNMnMGVEYE5vyWLyYjer81AE9P1DDBevPVNqWxAI2BhzW9Y?= =?us-ascii?Q?bJzOnBlfb+DGrhn65kIAWCeGewL1vvcU+jctFp8VpRVeS/+jVZhOBkDuPWUM?= =?us-ascii?Q?f5yhS/aIxgkHPo+oUmm/UiVLrj5vcmcqN+1sEAmldYsci6D7ynoQle8LV42K?= =?us-ascii?Q?Uu5MF2QWo9eva8H4AccHFyVNXNExUHMSjao95U+BpDhmHzc1YG/Ba3unCO31?= =?us-ascii?Q?wvumAP579XIOt2+R9srNfD/Di05t+T6qHkZITg5L4mgFgimknrL6uV9SPSkR?= =?us-ascii?Q?GxH8kmesOY+ItFLJ7C5D63LCY+j8OH3PPt1vy8pwe4gfKN7shTy4Gwmem6xE?= =?us-ascii?Q?eNCCklhYhlBrojcT/4lE1aj4TbG2YmeZYxNz?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(36860700013)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2025 12:25:47.7365 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7fd2c0f4-00b9-46ae-c62c-08ddf453001e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EDD3.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8453 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lama Kayal The cited commit adds a miss table for switchdev mode. But it uses the same level as policy table. Will hit the following error when running command: # ip xfrm state add src 192.168.1.22 dst 192.168.1.21 proto \ esp spi 1001 reqid 10001 aead 'rfc4106(gcm(aes))' \ 0x3a189a7f9374955d3817886c8587f1da3df387ff 128 \ mode tunnel offload dev enp8s0f0 dir in Error: mlx5_core: Device failed to offload this state. The dmesg error is: mlx5_core 0000:03:00.0: ipsec_miss_create:578:(pid 311797): fail to create= IPsec miss_rule err=3D-22 Fix it by adding a new miss level to avoid the error. Fixes: 7d9e292ecd67 ("net/mlx5e: Move IPSec policy check after decryption") Signed-off-by: Jianbo Liu Signed-off-by: Chris Mi Signed-off-by: Lama Kayal Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/en/fs.h | 1 + drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.h | 1 + drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c | 3 ++- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 4 ++-- 4 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/fs.h b/drivers/net/= ethernet/mellanox/mlx5/core/en/fs.h index 9560fcba643f..ac65e3191480 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/fs.h +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/fs.h @@ -92,6 +92,7 @@ enum { MLX5E_ACCEL_FS_ESP_FT_LEVEL =3D MLX5E_INNER_TTC_FT_LEVEL + 1, MLX5E_ACCEL_FS_ESP_FT_ERR_LEVEL, MLX5E_ACCEL_FS_POL_FT_LEVEL, + MLX5E_ACCEL_FS_POL_MISS_FT_LEVEL, MLX5E_ACCEL_FS_ESP_FT_ROCE_LEVEL, #endif }; diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.h b/dri= vers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.h index ffcd0cdeb775..23703f28386a 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.h +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.h @@ -185,6 +185,7 @@ struct mlx5e_ipsec_rx_create_attr { u32 family; int prio; int pol_level; + int pol_miss_level; int sa_level; int status_level; enum mlx5_flow_namespace_type chains_ns; diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c b/= drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c index 98b6a3a623f9..65dc3529283b 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c @@ -747,6 +747,7 @@ static void ipsec_rx_create_attr_set(struct mlx5e_ipsec= *ipsec, attr->family =3D family; attr->prio =3D MLX5E_NIC_PRIO; attr->pol_level =3D MLX5E_ACCEL_FS_POL_FT_LEVEL; + attr->pol_miss_level =3D MLX5E_ACCEL_FS_POL_MISS_FT_LEVEL; attr->sa_level =3D MLX5E_ACCEL_FS_ESP_FT_LEVEL; attr->status_level =3D MLX5E_ACCEL_FS_ESP_FT_ERR_LEVEL; attr->chains_ns =3D MLX5_FLOW_NAMESPACE_KERNEL; @@ -833,7 +834,7 @@ static int ipsec_rx_chains_create_miss(struct mlx5e_ips= ec *ipsec, =20 ft_attr.max_fte =3D 1; ft_attr.autogroup.max_num_groups =3D 1; - ft_attr.level =3D attr->pol_level; + ft_attr.level =3D attr->pol_miss_level; ft_attr.prio =3D attr->prio; =20 ft =3D mlx5_create_auto_grouped_flow_table(attr->ns, &ft_attr); diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c b/drivers/ne= t/ethernet/mellanox/mlx5/core/fs_core.c index cb165085a4c1..db552c012b4f 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c @@ -114,9 +114,9 @@ #define ETHTOOL_NUM_PRIOS 11 #define ETHTOOL_MIN_LEVEL (KERNEL_MIN_LEVEL + ETHTOOL_NUM_PRIOS) /* Vlan, mac, ttc, inner ttc, {UDP/ANY/aRFS/accel/{esp, esp_err}}, IPsec p= olicy, - * {IPsec RoCE MPV,Alias table},IPsec RoCE policy + * IPsec policy miss, {IPsec RoCE MPV,Alias table},IPsec RoCE policy */ -#define KERNEL_NIC_PRIO_NUM_LEVELS 10 +#define KERNEL_NIC_PRIO_NUM_LEVELS 11 #define KERNEL_NIC_NUM_PRIOS 1 /* One more level for tc, and one more for promisc */ #define KERNEL_MIN_LEVEL (KERNEL_NIC_PRIO_NUM_LEVELS + 2) --=20 2.31.1