From nobody Thu Oct 2 22:40:28 2025 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2071.outbound.protection.outlook.com [40.107.92.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9532E1798F; Wed, 10 Sep 2025 06:48:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.92.71 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757486919; cv=fail; b=E/wZa4YeORKnBHHCEVD4wtQvy/VQd/dHRAfHv+Yxvo46S73Sq65HUBCFIXZakBKj4Z+rgIq0P/TKJ+sZXdhAJMZLSd1UazvqAwbn8Uoy++3ECG8jmlN28CPfzGnNpDkL0JM8RaEiFusLFyV9tSxvvu+8BUyPGH6cnTu/bL1D8IE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757486919; c=relaxed/simple; bh=/MVCRYtzGXtqMvBofzYLpZfqZfxA7i5tKaYAadFsclA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=AO7s7whSQRKkJTkgPWgF8t3+slvscgdBggbB8g8r3wHLPmYn6xUwnS2n56zX0GcLPSqokNPXrIdAADnncBz8rGMvoUTMi/E4filPWl18NzaZ5Pbyda6788dEq90y6bZEkusDjDCRrC/koDMx2vyBK0plhdKxDy3QfH+dqZErg2A= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=bov+ah+J; arc=fail smtp.client-ip=40.107.92.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="bov+ah+J" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uwTuC9zeE+d5yiTIhaMhbTDacHVSOFYm4gMV91NNBneIgiSMaDmrFdnQhMQy++6VUeRgvprXeF3YMCncDnPnNblxhYFiO7FXxk8Ir/EqY2mm2lMtfKvCSWn/nLqBE8338xPmZ9H2JINlCL8uf3EHyNH3TXhg6FUHVfLvmqN8W7OPmUJuO4JQRT4uTVzKsx5wL2IsyQpUYLxOFcv5MqvxyroAa7AkGxGyydNHdHyU7fc0gMWHzs8858jYXNnI8/n/AZkdWBFfu33lh3INQrvLet5Tb3y+tDOCCvJ0SV1fIDDvsaka6dUvAL/kNg1rOBVooKialD1MLQa3CYq+GlX0tA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h8CdkHnM5dhM+KTH00sFx86IeSBn/asiX1naNRDvSqA=; b=MXob42vM+pBAs4RQqzSCeM7mYdcylS/S8NRKNxNpw+4xPNHYXnJuvX2jEoYCiwt9cZksN4YSX4FL26uEniJUdF2j8f/tfSv3BLX9FBPmEuYz5CbST1zw15IMrpa0JmxZ8lTnnI8UmHhOk5h768JNB1Ugo4ocZXt0ODSR+GMrJdPNwa2ct5DC7gk7JIcqNp2ZBuJvIYu+BfQ0jgMP90zLcu7gx42lApynSGuIhsGQDWlkNfwA7HjQBlEKsaiSAsx1KV/z4cHkXgBwDRGGkTufdLtfr9Mk3/6ZO838NzHRBHNDBuwJUMH5bB0F8Gt4259NfLcD72WjCw2bXGb5J4f+bg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h8CdkHnM5dhM+KTH00sFx86IeSBn/asiX1naNRDvSqA=; b=bov+ah+J9QyWvQjytdl9/HjNSxCnHXcHTSeBzYW4D0TyP4/GAmIGyySeqofj984lRLb7OI4hOL2PawxuGsjR5E5pWopgOuOiGRg83thVbOvyQu09dmhxRCYIiVBhvXvcQ05Cn+pu6fQTVQiPRsmzbTo0tBcQqgj53ny/aoGQ1EliMFRlp1RZAECZpa1rSJQ2KiF0i8g6vUz8Hvk7a40mgyRT2yNqfqlHz9Ow2HPgrYJd06WUb19b6E+QoTvHY34yHh7z0VSho0MQMr72tv5lWVbmHSFF5KIzLIvCq4sk1Up7Uu0HpPJOIC8xtQV8f5n3Qxn1e4o3zmF2myjKq/FDAw== Received: from BL0PR02CA0138.namprd02.prod.outlook.com (2603:10b6:208:35::43) by BN7PPFCEE68E7BF.namprd12.prod.outlook.com (2603:10b6:40f:fc02::6e2) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9094.22; Wed, 10 Sep 2025 06:48:33 +0000 Received: from BL02EPF0001A100.namprd03.prod.outlook.com (2603:10b6:208:35:cafe::e8) by BL0PR02CA0138.outlook.office365.com (2603:10b6:208:35::43) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9094.22 via Frontend Transport; Wed, 10 Sep 2025 06:48:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL02EPF0001A100.mail.protection.outlook.com (10.167.242.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9094.14 via Frontend Transport; Wed, 10 Sep 2025 06:48:32 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 9 Sep 2025 23:48:13 -0700 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 9 Sep 2025 23:48:13 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Tue, 9 Sep 2025 23:48:08 -0700 From: Tariq Toukan To: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" CC: Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Mark Bloch , "John Fastabend" , Sabrina Dubroca , , , , Gal Pressman , Boris Pismenny , Shahar Shitrit Subject: [PATCH net 1/3] net: tls: Introduce RX async resync request cancel function Date: Wed, 10 Sep 2025 09:47:39 +0300 Message-ID: <1757486861-542133-2-git-send-email-tariqt@nvidia.com> X-Mailer: git-send-email 2.8.0 In-Reply-To: <1757486861-542133-1-git-send-email-tariqt@nvidia.com> References: <1757486861-542133-1-git-send-email-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A100:EE_|BN7PPFCEE68E7BF:EE_ X-MS-Office365-Filtering-Correlation-Id: e9aaa26c-7f47-43c4-099e-08ddf0360ef0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|376014|82310400026|1800799024|7416014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?wAPsl+eX2nlJyHlWf7a0X1Iuj8HFc8D8JGrZWAQGn01DYZujjgE0DEP0LqS5?= =?us-ascii?Q?bsLtSbCPuMSnHqdrD8HeAe5iT1tiM1C4xsQI/gJc2zLut2ENM5+ni3M2WjYY?= =?us-ascii?Q?Y8dD9YfSMkFlqmdQKSGydJTPwDQJjxWDV8xhJdcEVX2JKOofu/HiBTvls28F?= =?us-ascii?Q?Sh0lPucsRBHhLass7PikTGxiqNy/o0pRTcAufK3I71arCNAmiXxGL3OzqPjF?= =?us-ascii?Q?kGtuZcdv64xMqQUFZZOnmjMfqJwy0493dPPD0h3pOaS+RYL62IDQ6OWx4Byq?= =?us-ascii?Q?ckXlyO/c3DMOAkQ63gyAzt2ZQhZfZF+0/Gov+Q+wEuEA1/6vwjIf2c72RkO4?= =?us-ascii?Q?wEsMt7ujLIc3irwGzy0E27t8RifWWI2PbUkOwdxioOW97xHYCa9L1VKzNmg/?= =?us-ascii?Q?EgoWqKqxBUrOT4Ri6oNETaVR4RUPCDzZYVNbf5eGoCIA8I+/d6HmhpXh+r3F?= =?us-ascii?Q?YioUu/UIat1o9f1+SF8F2poU4zY9xUFbRhVPBSXDrukQpJe/6T8AnigW5hRU?= =?us-ascii?Q?UnzzjyQmcZRHfofdNYBHFREBm6doILHr2sYwK6qP2f8ECG6ZRUHJBltbIJst?= =?us-ascii?Q?EXQ11VVc/KB66NH7qTEclx9mMU79VvQy12vevVr957pXeOdO6wN0sn78waCi?= =?us-ascii?Q?8IPaAFW/h85VyPfAIIn9biyHEaIgZwFqOPaiQ+9cs5Jj5dweIOdlswkHcvis?= =?us-ascii?Q?NED4RxSEgqM6YaiS5s2B0wy0OT/xo6Mucz0Rb/fre0oqNxoxlDeSfsIuSB8w?= =?us-ascii?Q?MrFtUND7GBnRbAU6jHe0SN1NKH3AZbWTBM4+cjo7ZXc25bJvT4eCI+EbZUOn?= =?us-ascii?Q?rLUtjaT7hbY4i/3Z2vKckQu+YYY9IJhOiQsu/xOGXgzK+7CK7rwJJM32jRv+?= =?us-ascii?Q?EEXGvPt2FeVBacRrlRx0tByrvN0stoOfkcIBmvEiTRMx7hlLhx20Ebox1txJ?= =?us-ascii?Q?H4D5v6FuqVfPrqbJlSXVV/vTle0Sn9ML97S+PI0e/whONAP7sA7HNM3G8ayP?= =?us-ascii?Q?7naXPAQz7YShhNGOwRl8MuwxtENYhBB0jyZ9+54gVf2OdOB5TwXJQdJ8A4Ac?= =?us-ascii?Q?YyecFIxUycCNKi2k675T1/ckV+uAkkSTzN5jTpq+S+Ecsq3zSWNwv4DXRV8j?= =?us-ascii?Q?yuCHZykOkNiJ/uuMVIzYkOkTeNW7TBrzPBTO6lq3e287V6htE2c5m+H6/wec?= =?us-ascii?Q?E66Nouofgnseo3E0SSq7B2MxOW3glaD/hF396ToPb9jsAKfDQwJCDlt6n1ax?= =?us-ascii?Q?6PEXXQWKR2F880QjtrAPQZ3792v33NQKL4OJHU18ksnlYAKh5RGFXBNovyQy?= =?us-ascii?Q?YfZ0APqmr54G6xLe57JsySHd5hbVCuAgLkOPbK0CuRP3vomgD1NAd42sV7QB?= =?us-ascii?Q?wc1ZDjJ0ohRXviqrLQGQv2N/Rd9qLEIegqp9jHU0gdpiTUHwtfFGdun4s0Ji?= =?us-ascii?Q?E/Xpfa2Pdc3pAh5GPmgDuNFwM1V7uav/uYsCNhbe8ndt9CXJOvJ2MTW74aTv?= =?us-ascii?Q?wSuKgdUlDbMJUlFXaT7dyHLzOAlJiXjplYB4?= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(36860700013)(376014)(82310400026)(1800799024)(7416014);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2025 06:48:32.3471 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e9aaa26c-7f47-43c4-099e-08ddf0360ef0 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A100.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PPFCEE68E7BF Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Shahar Shitrit When a netdev requests a RX async resync for a TLS connection, the TLS module handles it by logging record headers and attempting to match them to the tcp_sn provided by the device. If a match is found, the TLS module approves the tcp_sn for resynchronization. While waiting for a device response, the TLS module also increments rcd_delta each time a new TLS record is received, tracking the distance from the original resync request. However, if the device response is delayed or fails (e.g due to unstable connection and device getting out of tracking, hardware errors, resource exhaustion etc.), the TLS module keeps logging and incrementing, which can lead to a WARN() when rcd_delta exceeds the threshold. To address that, introduce tls_offload_rx_resync_async_request_cancel() to be called when device response fails. A follow-up patch will use this function to cancel async resync requests in mlx5 when the device is no longer able to complete the resync. Signed-off-by: Shahar Shitrit Signed-off-by: Tariq Toukan --- include/net/tls.h | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/include/net/tls.h b/include/net/tls.h index 857340338b69..380492effe3f 100644 --- a/include/net/tls.h +++ b/include/net/tls.h @@ -472,6 +472,15 @@ tls_offload_rx_resync_async_request_end(struct sock *s= k, __be32 seq) ((u64)ntohl(seq) << 32) | RESYNC_REQ); } =20 +static inline void +tls_offload_rx_resync_async_request_cancel(struct sock *sk) +{ + struct tls_context *tls_ctx =3D tls_get_ctx(sk); + struct tls_offload_context_rx *rx_ctx =3D tls_offload_ctx_rx(tls_ctx); + + atomic64_set(&rx_ctx->resync_async->req, 0); +} + static inline void tls_offload_rx_resync_set_type(struct sock *sk, enum tls_offload_sync_type= type) { --=20 2.31.1 From nobody Thu Oct 2 22:40:28 2025 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2082.outbound.protection.outlook.com [40.107.212.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 549DE30648C; Wed, 10 Sep 2025 06:48:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.212.82 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757486925; cv=fail; b=T3c3YEMCAHiuMLfObdvmJcsU3mAZAQIbhQQSvqoAox8ZjaGHecqEp4WlFTCM3tcvxM4+qKVa8tQWjw5Jrk+t20uY9dYV81JSSj55jxA1kP7xEBT4W3VmEIRwOE34eRf2SJ9LpZ4ekByBYRReTJ2iNCxucgEWmNRD4zOx2X1kzhA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757486925; c=relaxed/simple; bh=Rz9tknUE4NjmlRHl6uqV8huqdEct8JTLO7RgmUrjkh8=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=CEi/ezPHoXEV5d0396QPW9jueqEEYuzn9D5yyYYkyBwOp1Sr53AH2QA6WG3uTxQW8ZxafMjhtiuH9imVJ7NvKDpnt3SCyUKB6oG9JODwDN4J8iJmUl8Pv9jCuEJ0/+l1E0QT5kr0VBa409lHkNEv2AP6Vk+lKE/ulooF+PQz6u4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=S9jCdub+; arc=fail smtp.client-ip=40.107.212.82 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="S9jCdub+" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hBlr9Fnb57n1Jcu/hO07bHGjEGgxNzNfMmoBagx9esRX79g5V2YrfC1Nr92jVkV5EkOu9SQJvdxmf+DdPft1wjJrnUMc9deIb2sKxnUTp9Ti21BmrFXuu9N7RD4Xr889R3HGcDCcHabWFXH9et7q4Ka/A9RxS65OR+mAfTLy+BJCNfy0sf4PAYn9oRic8xuOb4nrzeCtiOwypx4HwmNEJ+WxndRF4TY18QsOMHnvwYEPeMmLRRo6JdPTzsRU0Sm/aJAtEXfSarsp0tC/SFHiFG8Er9mcnb7f09XZlAzqVPH2PYfU49cxb2dgxSx9f3AF+CNHOhn7OQYAXGsNnFRJSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=50z5szLwyyOw3PyIfuP889MHb655Uqy5nEy1Dib5nf8=; b=GD9esRdnYESMEY9pne/go3MCGgPV1FS0uhqUdenj8z1BT4wD4BPijDk24QAG+pPLNCkJptir689q19nBxbD32MKm9k1o3vnfcKPtYlCVw6gi5+jLFoU60KxuUQldeSP4DldKtglCgBewYqV9mSPS/FCoK0GAb0TYilJ1HdF6pV9GESyOSJCMWhAk6a3nYr63f1HnWMSF9HMt/Z/hd6ANbIi7h18lvDLjG512iz5ZtwBXFQVEpJKU9bccAe3Efs/D+RQcPNjoipv+l0QG25JNdhlGV8FDaVKehTC2V8+5sEXutVEnvpjEuVu7KSMsOAwLlqr+ByNnSNBzXpLRbD2vxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=50z5szLwyyOw3PyIfuP889MHb655Uqy5nEy1Dib5nf8=; b=S9jCdub+PeuxF0hmBxD+ukrZJ0JUU78k1TS9cs/tVSPWRmh9GGZzbNwQRhS0w40N/W7SvZ7aEF1LEkoqV2cYgnfflEkXARc1KliaWvBds5SlkP+WBZscNAUurSDauXYUeqaJ/4RuqN21FcfzW+mxeEwyzK1ytO7u7n+pSZHNoer6pRJt83/YzQQUfmwthveRfdCrb25hQwpNwem6YSOnErwcT9qkTaDcIX1II+Q4ZzUavlOQAqgqKKghnXh+BNYIwCh9Gt9VNZs51kd4XbwMIJNRpsf3mg8qegTeB+d5nuNY6U/1m01qjX+OOD42QKgxezDpiLt4WLvs4Zz78/ZZIA== Received: from BN9P220CA0006.NAMP220.PROD.OUTLOOK.COM (2603:10b6:408:13e::11) by PH7PR12MB6586.namprd12.prod.outlook.com (2603:10b6:510:212::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9094.22; Wed, 10 Sep 2025 06:48:39 +0000 Received: from BL02EPF0001A0FC.namprd03.prod.outlook.com (2603:10b6:408:13e:cafe::f6) by BN9P220CA0006.outlook.office365.com (2603:10b6:408:13e::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9094.22 via Frontend Transport; Wed, 10 Sep 2025 06:48:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL02EPF0001A0FC.mail.protection.outlook.com (10.167.242.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9115.13 via Frontend Transport; Wed, 10 Sep 2025 06:48:38 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 9 Sep 2025 23:48:18 -0700 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 9 Sep 2025 23:48:17 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Tue, 9 Sep 2025 23:48:13 -0700 From: Tariq Toukan To: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" CC: Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Mark Bloch , "John Fastabend" , Sabrina Dubroca , , , , Gal Pressman , Boris Pismenny , Shahar Shitrit Subject: [PATCH net 2/3] net: tls: Cancel RX async resync request on rdc_delta overflow Date: Wed, 10 Sep 2025 09:47:40 +0300 Message-ID: <1757486861-542133-3-git-send-email-tariqt@nvidia.com> X-Mailer: git-send-email 2.8.0 In-Reply-To: <1757486861-542133-1-git-send-email-tariqt@nvidia.com> References: <1757486861-542133-1-git-send-email-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A0FC:EE_|PH7PR12MB6586:EE_ X-MS-Office365-Filtering-Correlation-Id: 57bea1f5-f8f8-4318-0a50-08ddf0361271 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|7416014|376014|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?zPn3uhjuvnT24FgpeBph4USO2gLyk3QKQTe9IMrYBZ6qjqlImR/L+AbFPphO?= =?us-ascii?Q?jLsA8967q87y1OVPt5Aqcs+HYHOqJy6turAgRv0NlE/qbonU+ezuJ7v9gzPv?= =?us-ascii?Q?6ZSW85q7uY4x5gs8YDdGNQnVyfaRRSjLGiFmgvfFxd2HSvyXlIoU9YudGcvy?= =?us-ascii?Q?Ly9WZVTNbOyX4mRo1yo0sKXAtMJlx/pUp4nZs9G6MVF4rSwTN4/Q6wDz8V97?= =?us-ascii?Q?jdJ2SYGIJiXqBTEo973ajSCgKj3F1g0Hu8Ozj48JTk/lhRhX33LQXlrFGZEO?= =?us-ascii?Q?LDkOCK/u9zBxCVfgTYq5P96bKehaWaekUL8VXCVrDdatFiTNwkW9q3CzOEc0?= =?us-ascii?Q?SnlNok2eDE8glR+xq+V/0FNpVCspJm7Er7cBnoC/H+2htUVMWjv9Y1DYf37o?= =?us-ascii?Q?9lgpGqOaGhuZJYU7tKfPVZbrRVHfcK7bpi1dKxGXY2FJQGAKTV++1Ksp1fVc?= =?us-ascii?Q?AFqNa3i9JcxRjNNJfDohoY75xWeSbQrHB3qYngNXzc5W0Q2XC38Dy41ne1Ti?= =?us-ascii?Q?mCit8RGIchTh5kcolFZTbdGGHbEKzzPJP/CRAVvTIYvFHESSA4DgP+ecT4U9?= =?us-ascii?Q?EfVc70d1ekHPv63CHm5K44lvGRrQo1SWgHpi1SstukYdTcm9Itrua9uYeszG?= =?us-ascii?Q?TLqIGN/yls7qxfbdFBt2noWAjcDSxhFo1nTTxtIbwXZLc8XMiGU+SOi+uKkf?= =?us-ascii?Q?YSBzbtgbiZ0xlvaPWC5MWSwqpOV7wD6V2QNfqwBON5NYrdFONw80yR5Oerwd?= =?us-ascii?Q?aIGBwttkc5d1gA0fvMh5EKWdHQN5yp5t4uk8rcndbUuh17O7/Ho4/KVGUYwX?= =?us-ascii?Q?5KaDxCDfstXOM2s+N+lmPvAwCoJQwCA8VR+d1VwTS0nnGJLUVSCZ3tDCPQpe?= =?us-ascii?Q?U5Np7lP1KWMkpyZjolY1cYuyFztICBc/jJ0jq5Z8trgtSlkzH5SBN21siYcW?= =?us-ascii?Q?2vjefsTHjOpEY6HU9+Sg2wIPjhI/LuUNGQXkffq70mvSypJ6llQaG5V7ytCU?= =?us-ascii?Q?YVnMLqHpwodgViaqaJIvBZ04Sr7JDPS+Dl/0G1ReyQiOqnvPD7V0saXkchnb?= =?us-ascii?Q?l8h8NCYqKY997zOo5HWCcEo/QwBePqigPCGJn/s6jwr6qe3tgZxVRxB51+3f?= =?us-ascii?Q?CludeHrhqVYkka1Y2VxFdv4P1myh4E55oK3WyedpIA2f61PkNW3UsvBLJwSE?= =?us-ascii?Q?ZNtpVa4bz9jDm/ZI8wj+L/QZBJZx8z/tDQ2ToBq0P2+gmhwPKwdxqg3HwtNb?= =?us-ascii?Q?eg3YumF3+gUJUw6pLxKAW4JLe4yUqviWTQDAGFFlkVwo2c9323VhYvCfbS2+?= =?us-ascii?Q?ZxZL8p59CLB27RliH6f9+Cx+bV172hyI+w5W4iUwtxRmk3UtGMmWYy0RP+55?= =?us-ascii?Q?mHDr6uRzsrkz+rCaDDsOBYC6xxWd8rS0HqZcVQfMUDDrKe9y+UUpz3b0dYlG?= =?us-ascii?Q?sHB4Qj09xAWwOXwKPfx6sdDBbLBwC9LoOQ+aGEZ7jXcJUMv3ROlDu33XVFEm?= =?us-ascii?Q?/q/ErBHa+ac49q6XhIqtNwkJdKyWqNygZo1K?= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(7416014)(376014)(1800799024)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2025 06:48:38.2968 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 57bea1f5-f8f8-4318-0a50-08ddf0361271 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A0FC.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6586 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Shahar Shitrit When a netdev issues an RX async resync request, the TLS module increments rcd_delta for each new record that arrives. This tracks how far the current record is from the point where synchronization was lost. When rcd_delta reaches its threshold, it indicates that the device response is either excessively delayed or unlikely to arrive at all (at that point, tcp_sn may have wrapped around, so a match would no longer be valid anyway). Previous patch introduced tls_offload_rx_resync_async_request_cancel() to explicitly cancel resync requests when a device response failure is detected. This patch adds a final safeguard: cancel the async resync request when rcd_delta crosses its threshold, as reaching this point implies that earlier cancellation did not occur. Signed-off-by: Shahar Shitrit Signed-off-by: Tariq Toukan --- net/tls/tls_device.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/tls/tls_device.c b/net/tls/tls_device.c index f672a62a9a52..56c14f1647a4 100644 --- a/net/tls/tls_device.c +++ b/net/tls/tls_device.c @@ -721,8 +721,11 @@ tls_device_rx_resync_async(struct tls_offload_resync_a= sync *resync_async, /* shouldn't get to wraparound: * too long in async stage, something bad happened */ - if (WARN_ON_ONCE(resync_async->rcd_delta =3D=3D USHRT_MAX)) + if (WARN_ON_ONCE(resync_async->rcd_delta =3D=3D USHRT_MAX)) { + /* cancel resync request */ + atomic64_set(&resync_async->req, 0); return false; + } =20 /* asynchronous stage: log all headers seq such that * req_seq <=3D seq <=3D end_seq, and wait for real resync request --=20 2.31.1 From nobody Thu Oct 2 22:40:28 2025 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2062.outbound.protection.outlook.com [40.107.223.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48D0E308F28; Wed, 10 Sep 2025 06:48:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.223.62 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757486932; cv=fail; b=OPCHS5F58LgmXdLWE6uAm1SmSHCtLZc7ELZ6Xg+ugwP7Se+M+hWqBGVwpqpUAVgNcZQQGPH2U9n2XnXBkQ/io1EtJAZmyriDeZ1D2WC89M/jTEvcHd9P5uZKDCrkz7/pfLgIbhv9euexZLYkSXNUyRrDBYkn0m89Trzx1eBg59c= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757486932; c=relaxed/simple; bh=HbvMwVADizVkTcy6pItOZ3pTESvMq4KzyhWvwn75YLg=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=q+K0fUedECG1Hmag8/iPojFApbSqv4d7cJGfqr5suyzYu7satJjM2pwGFD3xaJWdd7ESpfCeK5cJPJEUI3PQsmJRe6apxFATeJb4VgSPvQxwpwN3t9AsxIL+aBgFwkYlnYO/45VXTXTOcj+6MPGRgo5/CPfIMNBSmWl2/12rMXA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=eozHJ5zT; arc=fail smtp.client-ip=40.107.223.62 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="eozHJ5zT" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BOpRis2vT/JOi93XfOxSos/zDLpKGruVigHrpDn6TIMpqsVaLo7hEQIMRQT73y7v/xoBEx/Lhfxt8/BzzV21GcD45c38kJ4N2E/JEdVXRzf915fkzL4CSE9/LB5+DfyloYnHKMZVQ9Wb72yxtZAL96Br7Sq5M8psuLUgFTDMPNgU7E6vF316QX4Sc1MJxG5f95DvJHJ9mmTMkTEj9HFpeuz2g7GqGWIbwgDawrcK3VclcIqUuxNF1eo1KqkuKYa5GaOJgkLI4KfcuQI6eVDhi1r9MnaZiQLJja/VBpVoxA50P8WbSvWU7YDR25vn64DewI/X+Twf4XAWkqEMMHNOUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VkSrYlmwa+3/iARvgdDIqNlLm3X3CoMfAgB03picEgw=; b=CgALBf2Edqw6DdUH38FMz7a0UxPhnUvnu1+tBddHF6nL26rw2gGXoVdfDJC8+nXkuMqDNZW05iQOvV85VjSSic3h4t4XEGlZIDainSap6fzFDXYvqklJbwIXUreUFpDt5/HZl0h2UF1vbLSoutQqgMG7u6M3uy3GcAqw4lEn1AWG9u5bHuZNhw6ZAVhWY4l/H54knhOJoV/7dz27BrcszHKVPZ6FsCavWwLwr4oD6c2n0DEc73Y1kvL1zkiAWY5q9iEna4zVFTB4hpN61tAAImt9Yb51lT5NcZOt/hY+7oiJ51H3xsWVv5T7eK3bK/OlP1sPGn3/2rhFdjfMIa27JA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VkSrYlmwa+3/iARvgdDIqNlLm3X3CoMfAgB03picEgw=; b=eozHJ5zT5QLuSSoLwmyuUhwEXWwY5zoUJBsCnhYSJQiczJqkk46kHUB75QDQmm+GVpjh1AW8D4e90figfBl8CA00GSo6Y6Ufq9e9Hzd+wCTKfaOYQbscQdD65T6uESF4BsTXhkI/HaS+cc5W70fIpxq9y1LFs7tWtd6BFnHBBKO3AqnuspNI6eOEVwCWTAZf7pF7mdgJJG1E6BjLBwbFfGvAuKTgqvC6N1F0g8nsLWvq6Wglo3pcnFg1/P+yslahsVjeoQblkggTA+8SylW1yRTj0+cM4q/9bEKN359Kht0+XebGoUoPIInVGvQv9iXgBujgQpqjOyllqpUduOBKZQ== Received: from CH2PR19CA0029.namprd19.prod.outlook.com (2603:10b6:610:4d::39) by CH3PR12MB8934.namprd12.prod.outlook.com (2603:10b6:610:17a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9094.22; Wed, 10 Sep 2025 06:48:45 +0000 Received: from DS3PEPF000099DD.namprd04.prod.outlook.com (2603:10b6:610:4d:cafe::58) by CH2PR19CA0029.outlook.office365.com (2603:10b6:610:4d::39) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9115.15 via Frontend Transport; Wed, 10 Sep 2025 06:48:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DS3PEPF000099DD.mail.protection.outlook.com (10.167.17.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9115.13 via Frontend Transport; Wed, 10 Sep 2025 06:48:44 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 9 Sep 2025 23:48:23 -0700 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 9 Sep 2025 23:48:22 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Tue, 9 Sep 2025 23:48:18 -0700 From: Tariq Toukan To: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" CC: Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Mark Bloch , "John Fastabend" , Sabrina Dubroca , , , , Gal Pressman , Boris Pismenny , Shahar Shitrit Subject: [PATCH net 3/3] net/mlx5e: kTLS, cancel RX async resync request in error flows Date: Wed, 10 Sep 2025 09:47:41 +0300 Message-ID: <1757486861-542133-4-git-send-email-tariqt@nvidia.com> X-Mailer: git-send-email 2.8.0 In-Reply-To: <1757486861-542133-1-git-send-email-tariqt@nvidia.com> References: <1757486861-542133-1-git-send-email-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF000099DD:EE_|CH3PR12MB8934:EE_ X-MS-Office365-Filtering-Correlation-Id: aeae3a01-aef5-4f65-49db-08ddf0361618 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|36860700013|7416014|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?spBr2jbCbdHO8zgviWCcZvSbvmjUocrGsPM+ObpYkpGAnA6kYpOK0OnZFHqH?= =?us-ascii?Q?hIxJN/kD7RbH08dVPEmn7a4+TIKoa6MhB/dgZFjNNnmq0oUyDgLQQFv6UAft?= =?us-ascii?Q?CaZSy+t9oleFudPNy3DPebR/4mqfF0qKLxE82YRM1Rhz/QaE4L6W46TdzaUc?= =?us-ascii?Q?4fXRMD6j6Cc28gBak+GES5qY70Phoa+D7uaV6wBnhRusieQ5VomeR/mqujf+?= =?us-ascii?Q?Ig/JRjmVJJDu2NyKi1DtKeQtkX2+Ht0aBhGukql4So1QQE/51tn/QzHwg74n?= =?us-ascii?Q?8dl41o2PdHYPQyhNxNVJ4s1f90esW4FoVT3hq3OofgfjJIiVoR843U/UcCil?= =?us-ascii?Q?Lz5mE3hDNv1WVHXeaRLsxsC4kgzyfz7E9iAfyUOPLkeDZwLs5pc9DirEBRv8?= =?us-ascii?Q?cG2TJxdq2Kmn/d+O1EodM8aE/QvTGq1gxGgvTnZHZCelLObMa68gZr09pjMs?= =?us-ascii?Q?NUfLLOJoCBsrAtKpgUTBkF18hpgA+O0oYlzbbTvjmpG2LKD50XCxehMbKxNd?= =?us-ascii?Q?+409aCjjp+/vHcQSLApd02x9TDhn3mR8c3AvUM2OFkt95RatvA/yoOgPYLuq?= =?us-ascii?Q?op+wiRqopNifqcWdTvqriaNEjUlOsKqfV1Zg8SXHqXOLDGpVf7sZCAC9fhlf?= =?us-ascii?Q?hq0pv1oWkHQsFp7tBptyMK5b+P30K9FWgHVn9fb7KdUz/bFo3P0JRGRbHMqs?= =?us-ascii?Q?ONq+O9SG3tQFNZ7TE1BuGoQtcAFa+zLlmlImLON44XvkxK0HIg18aHQKZyCj?= =?us-ascii?Q?JMg5zquz20uJxTLgL9tdPXynPPEOlnLGYZtGS1Xz3WtL/r5Sqvb5Dr6wEfph?= =?us-ascii?Q?wNMoypOBS59qUp9iCHtRJzE/p2S/aVbvdcxxLh6peEp+Jhog+i/GBagfqcWI?= =?us-ascii?Q?4Yh/xx+FP3MRwEtUwvah9+YxhSIyyE9Ut/A6Y5DDRyoUIXa1fqwA5ODSrRts?= =?us-ascii?Q?UE1+EP3fuwOlBu8b4VvqmyXW/fwUJnl/x26BsNfLTitZwwSlWiaMei4lrl5h?= =?us-ascii?Q?sbkSMvSUTsvjxIAYuXCsUJG4W7N/BaspdiX+BFIScZqWi4gRqy5wMEHukTSa?= =?us-ascii?Q?1yks6h7PTqVyTYSGTcOPBhS++YykGX0h5OKjEk1LnPwPKDC0Erzw9YLp2XJV?= =?us-ascii?Q?NMIdWzgLTLijzrwz7xOmDYTdnJsw82+j1MqukbgkBdN19poS6VC4Cdwje2yP?= =?us-ascii?Q?Jz+TfbyLi3Mn90IWcXrdsGD9bWPRoytuqX4GP1F882SCffEeknQ81ESxUIc3?= =?us-ascii?Q?gEYKSzx7YxWhkZemnNsxHUa4Ml2JY7T/g+bzeLNbb36ZhBe9DyTjqKze3/tN?= =?us-ascii?Q?5zmSQxky5wkIB4IA3SjHx1qKkvsSOT6z+EcjQKjuoCqkdtTWR7NLrvHUQYSm?= =?us-ascii?Q?ztKiRx30aMGLIel9Dtr+I+Zn9bZqMy5xX/TR7jxzQJqLTKdVSi28HGayNcre?= =?us-ascii?Q?teAMoGAENS8Ey2xtoDrjLVaf4nMhzmUbFFKjA9N5bWcWuYA8scrHeVa8bHLC?= =?us-ascii?Q?nN864OwrmLzw5b7Wgn+REc1qv9INsquFzb34?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(1800799024)(36860700013)(7416014)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2025 06:48:44.4351 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: aeae3a01-aef5-4f65-49db-08ddf0361618 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF000099DD.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8934 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Shahar Shitrit When packets are lost and the device loses track of TLS records, the device attempts to resync by tracking TLS records and requests an async resync from software for this TLS connection. The TLS module handles such device RX resync requests by logging record headers and comparing them with the record tcp_sn when provided by the device. It also increments rcd_delta to track how far the current record tcp_sn is from the tcp_sn of the original resync request. If the device later responds with a matching tcp_sn, the TLS module approves the tcp_sn for resync. However, the device response may be delayed or never arrive, particularly due to traffic-related issues such as packet drops or reordering. In such cases, the TLS module remains unaware that resync will not complete, and continues performing unnecessary work by logging headers and incrementing rcd_delta, which can eventually exceed the threshold and trigger a WARN(). For example, this was observed when the device got out of tracking, causing mlx5e_ktls_handle_get_psv_completion() to fail and ultimately leading to the rcd_delta warning. To address this, call tls_offload_rx_resync_async_request_cancel() to cancel the resync request and stop resync tracking in such error cases. Also, increment the tls_resync_req_skip counter to track these cancellations. Signed-off-by: Shahar Shitrit Signed-off-by: Tariq Toukan --- .../mellanox/mlx5/core/en_accel/ktls_rx.c | 29 +++++++++++++++++-- .../mellanox/mlx5/core/en_accel/ktls_txrx.h | 4 +++ .../net/ethernet/mellanox/mlx5/core/en_rx.c | 4 +++ 3 files changed, 34 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_rx.c b/d= rivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_rx.c index 65ccb33edafb..ec9400de95c0 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_rx.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_rx.c @@ -339,14 +339,19 @@ static void resync_handle_work(struct work_struct *wo= rk) =20 if (unlikely(test_bit(MLX5E_PRIV_RX_FLAG_DELETING, priv_rx->flags))) { mlx5e_ktls_priv_rx_put(priv_rx); + priv_rx->rq_stats->tls_resync_req_skip++; + tls_offload_rx_resync_async_request_cancel(priv_rx->sk); return; } =20 c =3D resync->priv->channels.c[priv_rx->rxq]; sq =3D &c->async_icosq; =20 - if (resync_post_get_progress_params(sq, priv_rx)) + if (resync_post_get_progress_params(sq, priv_rx)) { + priv_rx->rq_stats->tls_resync_req_skip++; + tls_offload_rx_resync_async_request_cancel(priv_rx->sk); mlx5e_ktls_priv_rx_put(priv_rx); + } } =20 static void resync_init(struct mlx5e_ktls_rx_resync_ctx *resync, @@ -431,8 +436,11 @@ void mlx5e_ktls_handle_get_psv_completion(struct mlx5e= _icosq_wqe_info *wi, =20 priv_rx =3D buf->priv_rx; dev =3D mlx5_core_dma_dev(sq->channel->mdev); - if (unlikely(test_bit(MLX5E_PRIV_RX_FLAG_DELETING, priv_rx->flags))) + if (unlikely(test_bit(MLX5E_PRIV_RX_FLAG_DELETING, priv_rx->flags))) { + priv_rx->rq_stats->tls_resync_req_skip++; + tls_offload_rx_resync_async_request_cancel(priv_rx->sk); goto out; + } =20 dma_sync_single_for_cpu(dev, buf->dma_addr, PROGRESS_PARAMS_PADDED_SIZE, DMA_FROM_DEVICE); @@ -443,6 +451,7 @@ void mlx5e_ktls_handle_get_psv_completion(struct mlx5e_= icosq_wqe_info *wi, if (tracker_state !=3D MLX5E_TLS_PROGRESS_PARAMS_RECORD_TRACKER_STATE_TRA= CKING || auth_state !=3D MLX5E_TLS_PROGRESS_PARAMS_AUTH_STATE_NO_OFFLOAD) { priv_rx->rq_stats->tls_resync_req_skip++; + tls_offload_rx_resync_async_request_cancel(priv_rx->sk); goto out; } =20 @@ -472,8 +481,10 @@ static bool resync_queue_get_psv(struct sock *sk) =20 resync =3D &priv_rx->resync; mlx5e_ktls_priv_rx_get(priv_rx); - if (unlikely(!queue_work(resync->priv->tls->rx_wq, &resync->work))) + if (unlikely(!queue_work(resync->priv->tls->rx_wq, &resync->work))) { mlx5e_ktls_priv_rx_put(priv_rx); + return false; + } =20 return true; } @@ -557,6 +568,18 @@ void mlx5e_ktls_rx_resync(struct net_device *netdev, s= truct sock *sk, resync_handle_seq_match(priv_rx, c); } =20 +void +mlx5e_ktls_rx_resync_async_request_cancel(struct mlx5e_icosq_wqe_info *wi) +{ + struct mlx5e_ktls_offload_context_rx *priv_rx; + struct mlx5e_ktls_rx_resync_buf *buf; + + buf =3D wi->tls_get_params.buf; + priv_rx =3D buf->priv_rx; + priv_rx->rq_stats->tls_resync_req_skip++; + tls_offload_rx_resync_async_request_cancel(priv_rx->sk); +} + /* End of resync section */ =20 void mlx5e_ktls_handle_rx_skb(struct mlx5e_rq *rq, struct sk_buff *skb, diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_txrx.h b= /drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_txrx.h index f87b65c560ea..cb08799769ee 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_txrx.h +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_txrx.h @@ -29,6 +29,10 @@ void mlx5e_ktls_handle_get_psv_completion(struct mlx5e_i= cosq_wqe_info *wi, void mlx5e_ktls_tx_handle_resync_dump_comp(struct mlx5e_txqsq *sq, struct mlx5e_tx_wqe_info *wi, u32 *dma_fifo_cc); + +void +mlx5e_ktls_rx_resync_async_request_cancel(struct mlx5e_icosq_wqe_info *wi); + static inline bool mlx5e_ktls_tx_try_handle_resync_dump_comp(struct mlx5e_txqsq *sq, struct mlx5e_tx_wqe_info *wi, diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c b/drivers/net/= ethernet/mellanox/mlx5/core/en_rx.c index b8c609d91d11..c713e683ef1d 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c @@ -1035,6 +1035,10 @@ int mlx5e_poll_ico_cq(struct mlx5e_cq *cq) netdev_WARN_ONCE(cq->netdev, "Bad OP in ICOSQ CQE: 0x%x\n", get_cqe_opcode(cqe)); +#ifdef CONFIG_MLX5_EN_TLS + if (wi->wqe_type =3D=3D MLX5E_ICOSQ_WQE_GET_PSV_TLS) + mlx5e_ktls_rx_resync_async_request_cancel(wi); +#endif mlx5e_dump_error_cqe(&sq->cq, sq->sqn, (struct mlx5_err_cqe *)cqe); mlx5_wq_cyc_wqe_dump(&sq->wq, ci, wi->num_wqebbs); --=20 2.31.1