From nobody Fri Oct 3 03:16:14 2025 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2070.outbound.protection.outlook.com [40.107.243.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38AC42F6590; Mon, 8 Sep 2025 10:08:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.243.70 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757326090; cv=fail; b=pYuRQyI7aIe+0ALAB8SmUJpm+d4ZFz0RDVPxDLTPOCnQEZ46491qLOiJiYhDQJRJlFI02ZkpFGuGzOrO+XmLbY0NbY8lwfYhuLy23FMlw0laGs1HxGKg7YHwUVnsWQL1l/mrORs4oVFIrHBe2JZR2YOr33PaoQ61b54HSIqbHcs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757326090; c=relaxed/simple; bh=xVTMPZT2ppptE0D/2lE8CnMnjCBSeNeAKBjdicvrjn8=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=IRv5uChg4IGJFRP+5DqkrlZP/BANy8nljRH6fS4+4xAkrOlwx1p9cUWpRBZtEfhdAXmH8WAjE2ImMrT1wRNtuFJEYJPXutZIAb0TeCU5cX4OcPZFJEUibLE/AuzgGvtwtsEGwrkkYAyWDYbphPmnDLtVMF5Jpn1KiP+SBncteFc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=fh6IJ7pe; arc=fail smtp.client-ip=40.107.243.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="fh6IJ7pe" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=punk3S95CgFWATkkBed1yQHQK8iLubGcwxm1+gXOoknrwbVGRByAcSZvv69JBaA4/S8jp7sdQ5/PAl2tbC4i+6KTscD57mc+gslawCGEykjN72NgFVZdSyBUfqeMiDyO2O5qMMRN+Lozmu1RbLVvuPVlk6+qg32mwUOq67haiKEiiJ19f8fDdkAxxfw68u2TQOykxeolKVbg8pBYkVovMWV5p+nGoejuGUtcZhEjx4RpqI1snzkqOu6R3kWA6/5mJhpgoEBR0+vwzEaMC43o0Koy/F1WvAvDy57BBZmR2OBm0lp/E0RMSNLs6gd6mav+kQu9YjIxshOq+8B4iSfqqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Aar3LQzX+gT8itRDR4xmeGR9frS0rN0gnZHfQMBuJ84=; b=FPGIoWx43sEzfkpYxEZq6nY7oNjKYgktMbZB0ZsjmU9fcvTKf3IOHb0x2UvtgxR1AUAUTxbhY9FV9X3mYpsGL1+o39gpRjusxrmfUMBLlhu9GcoAN/WCpAQxIlyYiS9KvohU8lCzsaHgp4ttdn0K5czXlqRknYCAvQrnYkcVlihZmTtvFdAMgD9hQpRrSXX7FiLT3wdYLcvHPdRkhvfO79pavmA3jkdNtnE2Vuz/ViCWcXuWuO4AlMuuYIpu/Lax2j+gaJCRP5jX11DMbVoLrnmza9dLrsbRt7eHTSmXNF+0VyPIY/jL2aNGyIXOz06ybXO2p0npeeBRxRMpcQl/6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Aar3LQzX+gT8itRDR4xmeGR9frS0rN0gnZHfQMBuJ84=; b=fh6IJ7pelzyZn7iz2LvWDbIKhsiBkvD64IUcCsXZqySSKOHCaoEGlorvaIHsia/A76IiFBlMaLypH+rosFFmWlSYHLVPDWniWlfS4xdN4GGKYp93cuewuznWkiaCRNTV9ITyEsTG2X0MpJDMa9UdRHxoYuPf3j529/gNLpYJaIWMiV/t9b/tFbhggPTp8T5D4e6CT/4qNQeTE2EIjgzpv2nMNYhf/x0dW1VjILPR9ITUVuJWFUlOPEMVqSQE8cJ192PVc/s/SBNvW1Y5zCy7Lcawzp2Az5KgeZQrgPh9OgZe61Wb/BiRDXnXszPauAthgZTi1LVeBJGq6qYQXayi/Q== Received: from BYAPR06CA0046.namprd06.prod.outlook.com (2603:10b6:a03:14b::23) by MN2PR12MB4192.namprd12.prod.outlook.com (2603:10b6:208:1d5::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9094.19; Mon, 8 Sep 2025 10:08:06 +0000 Received: from CY4PEPF0000FCC0.namprd03.prod.outlook.com (2603:10b6:a03:14b:cafe::34) by BYAPR06CA0046.outlook.office365.com (2603:10b6:a03:14b::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9094.22 via Frontend Transport; Mon, 8 Sep 2025 10:08:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000FCC0.mail.protection.outlook.com (10.167.242.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9115.13 via Frontend Transport; Mon, 8 Sep 2025 10:08:04 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Mon, 8 Sep 2025 03:07:41 -0700 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Mon, 8 Sep 2025 03:07:38 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Mon, 8 Sep 2025 03:07:33 -0700 From: Tariq Toukan To: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" CC: Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Mark Bloch , , , , Gal Pressman , Lama Kayal , Jianbo Liu , Chris Mi Subject: [PATCH net 3/3] net/mlx5e: Add a miss level for ipsec crypto offload Date: Mon, 8 Sep 2025 13:07:06 +0300 Message-ID: <1757326026-536849-4-git-send-email-tariqt@nvidia.com> X-Mailer: git-send-email 2.8.0 In-Reply-To: <1757326026-536849-1-git-send-email-tariqt@nvidia.com> References: <1757326026-536849-1-git-send-email-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000FCC0:EE_|MN2PR12MB4192:EE_ X-MS-Office365-Filtering-Correlation-Id: 88f93849-2353-4de2-b077-08ddeebf9a56 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?KVYPWj9rUeJwsMd2Z5bvZDP1glOVtUpMuVILvRWwMQvHpgvAIGSX+MGMh9+/?= =?us-ascii?Q?IhBlHfDFKtnUgPcR/jAVDiJMo9hE/mNcehQ6ZVImE16qL6j3M/fUzf2vRyFa?= =?us-ascii?Q?KfXHvC7disyHV/G1jEEAUWagBL5xzSUuW53gelGsilHif50DprkyfEjFaW1R?= =?us-ascii?Q?vObJyEgvKClsmCN8Yt+fYMSLGVljEwn9jBjHLejH0jHHX/sIjtuWQ30UROdN?= =?us-ascii?Q?issNoEz4XU6ym1cybzAiUGlrQY0gSHdaGLJGTC7RwhxNfIrbeI2b1nvSvWiP?= =?us-ascii?Q?UP3aMQJeivazMJpHLrIo+iYt4hQTbWbzmnunJI/b+Z81IykuBdbSyfdECMdC?= =?us-ascii?Q?rOpuoLD87alyQ/RFA2Y+/e37FgMxbaZwAnNT9cmsdW7XsqDwlvET14jsapwj?= =?us-ascii?Q?mQMjOZNg+sijuYqQ8cjRN2yJTU0JK6LA+YPmJMPNXNArki9zXSc2EQkvpPnE?= =?us-ascii?Q?EwiMBixPtPDxODmjUNmTJq7/NG0pm6FJbl3CgDNIk1KbVYFRWim5v4b1hMOO?= =?us-ascii?Q?0EiHOUeXZgVhNeGhjuL+63HEou2sOk0iJgurRild/cmyxEnaZYWvmOX3lzUs?= =?us-ascii?Q?W1GRIbtiaEPtEebz7ZkHh/QFVVeW5dJgRQlWyHhTydxHVqocF7awR2uQuHZ9?= =?us-ascii?Q?ctjxA/kfhqKzAtf+ZTEw5y5Fvn1EWZWX1HjQsK0ke691rv0Gu9Eg9kZg+lNn?= =?us-ascii?Q?LMvu30m3pXMco3DtMvfWFLLYAzDriLCnsRsNEfhShQ6xst89MBrKtYVLUVhe?= =?us-ascii?Q?iYHjrU6SEL2m6nON5GvTvOC8ju2GzxFHHHU8WzNrEIIJQYWXwM7Pkm3It1nb?= =?us-ascii?Q?uon30i8kb7lWWjEUfZoGFStXVRJ0j5pcviWtq9WLG7yu19pILq40jgN96piZ?= =?us-ascii?Q?AMGv1J/FABZycNAv2704iAk9edeCUTfDvKvC6QDPKFsZLj+/zRZvgUxrnhnz?= =?us-ascii?Q?dhsga7R6SDKzBf+Qh8+pgTiOZa4X2gfraC0XCuNau3khSTm1ZPZdzjxU8bNu?= =?us-ascii?Q?KoQZnUpLbX/uf+wBcjUEyz8Xs61/MlNkgaLMeBsffWZmy6REBUIiwPDfZEI8?= =?us-ascii?Q?8sXs+6VvPi3tmbCiRl2E/UZDPQ/47zpGvRSZncTXAF8IMAF2tsbHJQw7av8z?= =?us-ascii?Q?bBL+vcXpFZb1Fy3uWgqen/I7KDpT/lUZnI/PhA2CKC2Edth+0D5X20z7iA5+?= =?us-ascii?Q?p0DVbJ9HEdSsQ11ZtegkTVsIguFiQELQcHzGA3LfRO6ZGsYPv68sktoyyZf+?= =?us-ascii?Q?EmS6zI3OumWjYOdVvLAvFvZHz9gy/tiUkGq0CINvPk+jNZrlDP373UCfGv1S?= =?us-ascii?Q?8gG8FK9ik7Bm+cZR/9vgLVvDOc5p2GrKY7UBFbXn/pSyivJPDn36nxBhYKLs?= =?us-ascii?Q?MGBCbYkRjyR4pMRhCrBRvRkasYpzcA+CGr3ykLfL62QJ3xDLYv65j83qm+mZ?= =?us-ascii?Q?gSUevpzNbU+SOb26nepu0mY+VMk48IQACh3xHF60XRR5IW/VBg41yFgs7jx7?= =?us-ascii?Q?KWqsTB7T5609foW4Z7VVUYgRsyzN9Qh1Ti8z?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(376014)(36860700013)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2025 10:08:04.8742 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 88f93849-2353-4de2-b077-08ddeebf9a56 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000FCC0.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4192 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lama Kayal The cited commit adds a miss table for switchdev mode. But it uses the same level as policy table. Will hit the following error when running command: # ip xfrm state add src 192.168.1.22 dst 192.168.1.21 proto \ esp spi 1001 reqid 10001 aead 'rfc4106(gcm(aes))' \ 0x3a189a7f9374955d3817886c8587f1da3df387ff 128 \ mode tunnel offload dev enp8s0f0 dir in Error: mlx5_core: Device failed to offload this state. The dmesg error is: mlx5_core 0000:03:00.0: ipsec_miss_create:578:(pid 311797): fail to create= IPsec miss_rule err=3D-22 Fix it by adding a new miss level to avoid the error. Fixes: 7d9e292ecd67 ("net/mlx5e: Move IPSec policy check after decryption") Signed-off-by: Jianbo Liu Signed-off-by: Chris Mi Signed-off-by: Lama Kayal Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/en/fs.h | 1 + drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.h | 1 + drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c | 3 ++- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 4 ++-- 4 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/fs.h b/drivers/net/= ethernet/mellanox/mlx5/core/en/fs.h index 9560fcba643f..ac65e3191480 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/fs.h +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/fs.h @@ -92,6 +92,7 @@ enum { MLX5E_ACCEL_FS_ESP_FT_LEVEL =3D MLX5E_INNER_TTC_FT_LEVEL + 1, MLX5E_ACCEL_FS_ESP_FT_ERR_LEVEL, MLX5E_ACCEL_FS_POL_FT_LEVEL, + MLX5E_ACCEL_FS_POL_MISS_FT_LEVEL, MLX5E_ACCEL_FS_ESP_FT_ROCE_LEVEL, #endif }; diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.h b/dri= vers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.h index ffcd0cdeb775..23703f28386a 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.h +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.h @@ -185,6 +185,7 @@ struct mlx5e_ipsec_rx_create_attr { u32 family; int prio; int pol_level; + int pol_miss_level; int sa_level; int status_level; enum mlx5_flow_namespace_type chains_ns; diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c b/= drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c index 98b6a3a623f9..65dc3529283b 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c @@ -747,6 +747,7 @@ static void ipsec_rx_create_attr_set(struct mlx5e_ipsec= *ipsec, attr->family =3D family; attr->prio =3D MLX5E_NIC_PRIO; attr->pol_level =3D MLX5E_ACCEL_FS_POL_FT_LEVEL; + attr->pol_miss_level =3D MLX5E_ACCEL_FS_POL_MISS_FT_LEVEL; attr->sa_level =3D MLX5E_ACCEL_FS_ESP_FT_LEVEL; attr->status_level =3D MLX5E_ACCEL_FS_ESP_FT_ERR_LEVEL; attr->chains_ns =3D MLX5_FLOW_NAMESPACE_KERNEL; @@ -833,7 +834,7 @@ static int ipsec_rx_chains_create_miss(struct mlx5e_ips= ec *ipsec, =20 ft_attr.max_fte =3D 1; ft_attr.autogroup.max_num_groups =3D 1; - ft_attr.level =3D attr->pol_level; + ft_attr.level =3D attr->pol_miss_level; ft_attr.prio =3D attr->prio; =20 ft =3D mlx5_create_auto_grouped_flow_table(attr->ns, &ft_attr); diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c b/drivers/ne= t/ethernet/mellanox/mlx5/core/fs_core.c index cb165085a4c1..db552c012b4f 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c @@ -114,9 +114,9 @@ #define ETHTOOL_NUM_PRIOS 11 #define ETHTOOL_MIN_LEVEL (KERNEL_MIN_LEVEL + ETHTOOL_NUM_PRIOS) /* Vlan, mac, ttc, inner ttc, {UDP/ANY/aRFS/accel/{esp, esp_err}}, IPsec p= olicy, - * {IPsec RoCE MPV,Alias table},IPsec RoCE policy + * IPsec policy miss, {IPsec RoCE MPV,Alias table},IPsec RoCE policy */ -#define KERNEL_NIC_PRIO_NUM_LEVELS 10 +#define KERNEL_NIC_PRIO_NUM_LEVELS 11 #define KERNEL_NIC_NUM_PRIOS 1 /* One more level for tc, and one more for promisc */ #define KERNEL_MIN_LEVEL (KERNEL_NIC_PRIO_NUM_LEVELS + 2) --=20 2.31.1