From nobody Mon Oct 6 12:02:05 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CF891607AC; Wed, 23 Jul 2025 01:31:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753234300; cv=none; b=hROWDD2Fz1v0wb5hBlFVQ+ScvDJc7auVCdw1rDyYkj7Wd2C9Ui8Sq8G1H5PJHfSDliCRry2L5iF4EE2++bv4NDuS8PfAU+RZ8VTD/KbgqMtw05fijf9tAYbh2mVem3JQ19lEXXC4xYNnMAywV+gHIoED1gQuM+z6HFMfb0+86Qw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753234300; c=relaxed/simple; bh=/MpxVUrHL2vIkvTz1clrqlGGpKYcjUtDZCwlt5gwSF8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Lpc53Gy5P+cuQViZNJcjpPXoQTgsyDFSCWPs8ePZZo2CQeTq8ZdbP5VdpSv5VRYcRXXpadgQLeaARdT7G+1q09nOfAah+OqxjGh8kV7CzhkO+RAKRGkEz7fSnsYAdxzTJjjY/U74/R9+ALyZtgKm9TsJHLjaRfcrT4uLTULiF8c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ej/aWAAx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ej/aWAAx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04899C4CEEB; Wed, 23 Jul 2025 01:31:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753234300; bh=/MpxVUrHL2vIkvTz1clrqlGGpKYcjUtDZCwlt5gwSF8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ej/aWAAxXencFbNlHIqCDwVhKaUJP8uwJ5O0r8V6P9vM9+RvE+dn5SWbK02nDx/Qm iymrdTxDSYwZ8E3YKJMcdEd6efwbuP7wHpVmTNUpeMqFGWFVrl0W8Xm+ba8vMpDPyD iCOJN2uW6NjmRNLFWhksurkH1f1iC8WwLueUIkCZdRuWZUbaFao88OiHX77BzcGJcV b38mynI2E/VEhKHtKWRq2ZBgOPn+O2naluOfJwCGdeR/HMBqedNc3frFbnr6UTZdIW egoUd4qtrxzrYaXsC2dqAjmWV0rEaYJ8XJsMl/+m4LJomXr4bJPVAkbviWeRblVzlQ ix56PshnR8FJg== From: "Masami Hiramatsu (Google)" To: Steven Rostedt , Masami Hiramatsu Cc: Mathieu Desnoyers , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: [PATCH v4 6/7] tracing: uprobe-event: Allocate string buffers from heap Date: Wed, 23 Jul 2025 10:31:36 +0900 Message-ID: <175323429593.57270.12369235525923902341.stgit@devnote2> X-Mailer: git-send-email 2.43.0 In-Reply-To: <175323423662.57270.14650807176845939538.stgit@devnote2> References: <175323423662.57270.14650807176845939538.stgit@devnote2> User-Agent: StGit/0.19 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Masami Hiramatsu (Google) Allocate temporary string buffers for parsing uprobe-events from heap instead of stack. Signed-off-by: Masami Hiramatsu (Google) Reviewed-by: Steven Rostedt (Google) --- Changes in v3: - Split #include sorting. Changes in v2: - Sort #include alphabetically. - Add fail_mem label for handling ENOMEM error. --- kernel/trace/trace_uprobe.c | 28 +++++++++++++++++++--------- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c index 872dce092e46..8b0bcc0d8f41 100644 --- a/kernel/trace/trace_uprobe.c +++ b/kernel/trace/trace_uprobe.c @@ -8,6 +8,7 @@ #define pr_fmt(fmt) "trace_uprobe: " fmt =20 #include +#include #include #include #include @@ -19,6 +20,7 @@ #include #include =20 +#include "trace.h" #include "trace_dynevent.h" #include "trace_probe.h" #include "trace_probe_tmpl.h" @@ -537,15 +539,15 @@ static int register_trace_uprobe(struct trace_uprobe = *tu) */ static int __trace_uprobe_create(int argc, const char **argv) { - struct trace_uprobe *tu; const char *event =3D NULL, *group =3D UPROBE_EVENT_SYSTEM; char *arg, *filename, *rctr, *rctr_end, *tmp; - char buf[MAX_EVENT_NAME_LEN]; - char gbuf[MAX_EVENT_NAME_LEN]; - enum probe_print_type ptype; - struct path path; unsigned long offset, ref_ctr_offset; + char *gbuf __free(kfree) =3D NULL; + char *buf __free(kfree) =3D NULL; + enum probe_print_type ptype; + struct trace_uprobe *tu; bool is_return =3D false; + struct path path; int i, ret; =20 ref_ctr_offset =3D 0; @@ -653,6 +655,10 @@ static int __trace_uprobe_create(int argc, const char = **argv) /* setup a probe */ trace_probe_log_set_index(0); if (event) { + gbuf =3D kmalloc(MAX_EVENT_NAME_LEN, GFP_KERNEL); + if (!gbuf) + goto fail_mem; + ret =3D traceprobe_parse_event_name(&event, &group, gbuf, event - argv[0]); if (ret) @@ -664,15 +670,16 @@ static int __trace_uprobe_create(int argc, const char= **argv) char *ptr; =20 tail =3D kstrdup(kbasename(filename), GFP_KERNEL); - if (!tail) { - ret =3D -ENOMEM; - goto fail_address_parse; - } + if (!tail) + goto fail_mem; =20 ptr =3D strpbrk(tail, ".-_"); if (ptr) *ptr =3D '\0'; =20 + buf =3D kmalloc(MAX_EVENT_NAME_LEN, GFP_KERNEL); + if (!buf) + goto fail_mem; snprintf(buf, MAX_EVENT_NAME_LEN, "%c_%s_0x%lx", 'p', tail, offset); event =3D buf; kfree(tail); @@ -724,6 +731,9 @@ static int __trace_uprobe_create(int argc, const char *= *argv) trace_probe_log_clear(); return ret; =20 +fail_mem: + ret =3D -ENOMEM; + fail_address_parse: trace_probe_log_clear(); path_put(&path);