From nobody Tue Oct 7 14:46:48 2025 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2054.outbound.protection.outlook.com [40.107.237.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EDA42459FE; Tue, 8 Jul 2025 21:17:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.237.54 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752009424; cv=fail; b=DOqRalhpuaBQgmQCA1aO9F3GIEdF02tUL51kHMTqiUaF5YzfSafgvinvLMabyKzwH2iahhPBWah+Qw6EVkCDRtqHxSnDNQ2RgysALXz9nfh8g7pIWvY/aigWpVqPFo9d9EhaYfSxY5aQt6wweiQfJ3QCLsBaP/1Ce6PrZ4GlU5U= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752009424; c=relaxed/simple; bh=dIKX6RhWt0WefI3xH1Sk6HcFysiMognnyKyjlBJwUKA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=HoXWQR2oQCeWC/UJL0YW57CliOto/0ZFRQeKUsJRiUruMOrnwdsupAiE4JdrvI+WiMANEx2Y1bUBU06c69IAjJ+5EmCaokveI85Z8++Rw8TsNkXzaafSgu6gGCoKfCtL02V0iJLwEc/FOeNGN4mMYp6OF/opaISKNUvfaLon8g0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=YVutNyZm; arc=fail smtp.client-ip=40.107.237.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="YVutNyZm" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XMe5ZH96PhEAKZ1MiGL1wDEMEONZMAfTWegg66Fm4Eiugb/YLRb2m+BS28+P5EXKeufRKAQArubvv6eNw0QoCWY6ygJaKv7dSAnWnyLQXI6Ytylpmdvz7jLw14KCLGVC8G7dzID+UWNjnyIfMZzNShzI/XoeDHGRJIO3fcUOB3y/VTj2Ow8zkGUxsxEKD1m5LNjYfYbTQQdE56rZZuos+i9QxK3KMaZiWO1dVMzra1qDyfVHCFuXDvsalxnF897geLpxk586CNvRFKTOccMgedIhXJ9ZYpBjtmTBD7/XSXweAhBse4WYYSJZQKKDBml7ti8nMCjMJTAScbpGNCdIfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KkrQKD/1G6qATt958DAzXTOPrksuF5cDyV17xju+P4Y=; b=afyL56NRrtNhvkGl2I88v4UW2i5BEbu2seYuWGYlrGmxk0N4CGSNDw6JH+RDiX4J+F7H52Nz4IVQ5jZvFpeGxZlviVc/cDY7NrkbKLFOim679L8okdzVpt0nNe404rlO/wNa81ExrCQD96vIn3H/rtK4C+RZGO5WwfFyAEBNZArsMb2XKq+aSzd9V6w/GngHp9zZEL4ulRpXzmJwJHX4AXvL10Qt9XZPljMBFZxcp2Fm4OXlSikMDDz6gpNNSHQfrLl0YAugjCrYJF57lx/eo5oZA+hJ4a3REMkt7j54hQgEVBgWVWWz2yozqhQqi35p84A0xtnrwrPot4uNh6HyLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KkrQKD/1G6qATt958DAzXTOPrksuF5cDyV17xju+P4Y=; b=YVutNyZm52g9AoLBHtCmxddBBptp27T+rso4bVlKt8MDE1zVaFxC487Xuppu4jevlpQ+zJvKnWtlKinm9ijXqxNDHvjUUmwAqF1zmKIDU5nk9jMoe+UFz8CYRBfqAfy5qWcqricEWjbbH7YWt8jbXTImrqHiEpvIFD0wOwOfDUBGFEdrPAm+ttqnGJ1c4A1eHyFhHIOiJkUfdoy3KrJ45yYW/+1z6rgj9T3KcLgW0YeueBEmzOtWVp9Jiu8qOEoHP2Lm1lTIrH/H+bvqdPAuME6O6CUcuUwUSPxFaOVJRwZvcsbLo5NxhaHqcjxS2bzYcg53JbCcyrgdmaxopDo1gA== Received: from PH7P222CA0012.NAMP222.PROD.OUTLOOK.COM (2603:10b6:510:33a::17) by SJ0PR12MB6807.namprd12.prod.outlook.com (2603:10b6:a03:479::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.27; Tue, 8 Jul 2025 21:16:57 +0000 Received: from SN1PEPF000397B5.namprd05.prod.outlook.com (2603:10b6:510:33a:cafe::87) by PH7P222CA0012.outlook.office365.com (2603:10b6:510:33a::17) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8922.21 via Frontend Transport; Tue, 8 Jul 2025 21:16:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by SN1PEPF000397B5.mail.protection.outlook.com (10.167.248.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.15 via Frontend Transport; Tue, 8 Jul 2025 21:16:56 +0000 Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 8 Jul 2025 14:16:41 -0700 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 8 Jul 2025 14:16:41 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Tue, 8 Jul 2025 14:16:38 -0700 From: Tariq Toukan To: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" CC: Saeed Mahameed , Gal Pressman , "Leon Romanovsky" , Saeed Mahameed , "Tariq Toukan" , Mark Bloch , , , , Carolina Jubran Subject: [PATCH net-next 1/5] net/mlx5e: Remove unused VLAN insertion logic in TX path Date: Wed, 9 Jul 2025 00:16:23 +0300 Message-ID: <1752009387-13300-2-git-send-email-tariqt@nvidia.com> X-Mailer: git-send-email 2.8.0 In-Reply-To: <1752009387-13300-1-git-send-email-tariqt@nvidia.com> References: <1752009387-13300-1-git-send-email-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF000397B5:EE_|SJ0PR12MB6807:EE_ X-MS-Office365-Filtering-Correlation-Id: a05d9993-bd63-48ef-10b6-08ddbe64c52e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|376014|82310400026|7416014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?GKyVyruuOwClxdqelatpbXVHhgd41pKaqAU2Yh4zQ7WQgUXdIXvFbyF5xOqi?= =?us-ascii?Q?9At7LL6bVhSt4KOW0nA4KkqDHGTJ6I28Htjqk5gYUwk2HwmC5tLXL2Y8Qn9C?= =?us-ascii?Q?kas74xTwIHvxtDqv3l1qJaUAtQSATWXgthPi+jbCzWZKuV5KcYzG68X7XKN/?= =?us-ascii?Q?EVua6t0GPxlmW2l2NcPE9Ri2Gq/i0j/srhwcMpOcpgQMnX6u3qhnYZ0APuIz?= =?us-ascii?Q?qmr8GzyyIiFD5rLevbdJJNQBGcgQNjrr3u4aUMHk1kPCkRxPTInRYgdIW0da?= =?us-ascii?Q?R/2Y81uGZqOMH/p6ji45dEUtwkJMnGi/BmQwafPVVPe4+KzalnWpsByn9WOO?= =?us-ascii?Q?RxqpejujtXmHYh91Us5tPwjTm9C4SnpgdDDyyZ79/XP6GNKySDGf8TLrDvTT?= =?us-ascii?Q?qSljaYleP8fyyjFahA7PnK7vjcWpnFVIa1tl6scUq+b6uoqKuyGZNx/L1p9Y?= =?us-ascii?Q?SbryxvfIcIJHanbFBYKMLQDpG1WgXC44i86qWqaa79CeSoesIHAaRSzcqSiI?= =?us-ascii?Q?zxw2KOz4P99BAgAUaNk5SztjydmWq957LvKE8gsMLfRnT8QgxPA4HvHi/chF?= =?us-ascii?Q?8HIB3UWgpbytHlOW9m+e3bNTQhy3ayv/OKCWhVmzbh6cCBSJaWMxzJM9aEWc?= =?us-ascii?Q?GkLRLC/pCDVkG7/hlbIUmICjpe5UnncYtLkq9bmU6bQZXOVKBgWSFjy2E90e?= =?us-ascii?Q?KAPELj9K1by/g+HK+RNMUa0EOpvKnyHt6aIOSAG4mQGTwhYifGW4CI4bPxTo?= =?us-ascii?Q?3m08laH5PQDw2HvcuqK4PpR/7i7Jcav1JvUwFhwd88S57uyyJdXYkbYFoeYU?= =?us-ascii?Q?lFls7smi0ie1v+HS2ATo+KxGH0/Wz2xfkhKdVCi6Ba05BzaA4T6mGSLexQEw?= =?us-ascii?Q?k7iKkTmB9tstKSbnf00bT8c5VbfiXPa+rEKTeAO8mi+uNFJG3aerAvnSXLeC?= =?us-ascii?Q?waBRMgrzjc7aBk3zZS7KoQh6rIaxrpPfGIUV+HYCKrwCTL+Fua6mq/AarPpV?= =?us-ascii?Q?9GKqz03bzrO2bLfoX1h8nvp9BR0DiOBSBt/RRHB/8a1WWkIaHW+ckbHaLmhf?= =?us-ascii?Q?u7IRX/0rqOGUzNppVWpkrZx5hU+E9btYQhPKEWV1/DbP2ph5Y7vJPnd9yvIx?= =?us-ascii?Q?zX0039z/gZL+Xa6K7pNrZZ3WJscg6ZuuVs60D4WL50qSq0U/tHHO47TfupEy?= =?us-ascii?Q?A8MoSQ0Sx4bgeykCs/c8kMStBxX6Ai5XalQGPUboFf4jbB/omz5y2uy+KFQL?= =?us-ascii?Q?DJah2KmxpfkenMGoXPN51J7m5djCvkcSeQ3oPsHGIJQAC1N0g6BKSTjhetr9?= =?us-ascii?Q?JCpgZHMViMH/sHACapaDl0kq16FeksAAdfm7VEkr4OwEuIK+gOH6oO5L4Rqi?= =?us-ascii?Q?qe+R6cbNtSaUpGoz5K0VLszsaxwzd+DB0dvuX4MJCf1PmoFsiCuKQC9oiLzl?= =?us-ascii?Q?27wsorqnpT5rM0J+ql4HInuyjVO9zyZWWBmUJnGwjlbQjC4ZbL3f673uPJuI?= =?us-ascii?Q?zBN8bt/RLGPqBqH/vM+wcFPxeA7mee6UKu5A?= X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(376014)(82310400026)(7416014);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2025 21:16:56.9150 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a05d9993-bd63-48ef-10b6-08ddbe64c52e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF000397B5.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6807 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Carolina Jubran The VLAN insertion capability (`wqe_vlan_insert`) was never enabled on all mlx5 devices. When VLAN TX offload is advertised but this capability is not supported, the driver uses inline headers to insert the VLAN tag. To support this, the driver used to set the `MLX5E_SQ_STATE_VLAN_NEED_L2_INLINE` bit to enforce L2 inline mode when `wqe_vlan_insert` was not supported. Since the capability is disabled on all devices, this logic was always active, and the SQ flag has become redundant. L2 inline is enforced unconditionally for VLAN-tagged packets. The `skb_vlan_tag_present()` check in the else-if block of `mlx5e_sq_xmit_wqe()` is never true by this point in the TX flow, as the VLAN tag has already been inserted by the driver using inline headers. As a result, this code is never executed. Remove the redundant SQ state, dead VLAN insertion code block, and related logic. Signed-off-by: Carolina Jubran Signed-off-by: Tariq Toukan Reviewed-by: Simon Horman --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 1 - drivers/net/ethernet/mellanox/mlx5/core/en/ptp.c | 2 -- drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c | 1 - drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 2 -- drivers/net/ethernet/mellanox/mlx5/core/en_tx.c | 9 +-------- 5 files changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en.h b/drivers/net/eth= ernet/mellanox/mlx5/core/en.h index 65a73913b9a2..64e69e616b1f 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en.h +++ b/drivers/net/ethernet/mellanox/mlx5/core/en.h @@ -383,7 +383,6 @@ enum { MLX5E_SQ_STATE_RECOVERING, MLX5E_SQ_STATE_IPSEC, MLX5E_SQ_STATE_DIM, - MLX5E_SQ_STATE_VLAN_NEED_L2_INLINE, MLX5E_SQ_STATE_PENDING_XSK_TX, MLX5E_SQ_STATE_PENDING_TLS_RX_RESYNC, MLX5E_NUM_SQ_STATES, /* Must be kept last */ diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/ptp.c b/drivers/net= /ethernet/mellanox/mlx5/core/en/ptp.c index 5d0014129a7e..391b4e9c9dc4 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/ptp.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/ptp.c @@ -340,8 +340,6 @@ static int mlx5e_ptp_alloc_txqsq(struct mlx5e_ptp *c, i= nt txq_ix, sq->stats =3D &c->priv->ptp_stats.sq[tc]; sq->ptpsq =3D ptpsq; INIT_WORK(&sq->recover_work, mlx5e_tx_err_cqe_work); - if (!MLX5_CAP_ETH(mdev, wqe_vlan_insert)) - set_bit(MLX5E_SQ_STATE_VLAN_NEED_L2_INLINE, &sq->state); sq->stop_room =3D param->stop_room; sq->ptp_cyc2time =3D mlx5_sq_ts_translator(mdev); =20 diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c b/dri= vers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c index c3bda4612fa9..bd96988e102c 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c @@ -13,7 +13,6 @@ static const char * const sq_sw_state_type_name[] =3D { [MLX5E_SQ_STATE_RECOVERING] =3D "recovering", [MLX5E_SQ_STATE_IPSEC] =3D "ipsec", [MLX5E_SQ_STATE_DIM] =3D "dim", - [MLX5E_SQ_STATE_VLAN_NEED_L2_INLINE] =3D "vlan_need_l2_inline", [MLX5E_SQ_STATE_PENDING_XSK_TX] =3D "pending_xsk_tx", [MLX5E_SQ_STATE_PENDING_TLS_RX_RESYNC] =3D "pending_tls_rx_resync", }; diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/ne= t/ethernet/mellanox/mlx5/core/en_main.c index e8e5b347f9b2..fee323ade522 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c @@ -1677,8 +1677,6 @@ static int mlx5e_alloc_txqsq(struct mlx5e_channel *c, sq->hw_mtu =3D MLX5E_SW2HW_MTU(params, params->sw_mtu); sq->max_sq_mpw_wqebbs =3D mlx5e_get_max_sq_aligned_wqebbs(mdev); INIT_WORK(&sq->recover_work, mlx5e_tx_err_cqe_work); - if (!MLX5_CAP_ETH(mdev, wqe_vlan_insert)) - set_bit(MLX5E_SQ_STATE_VLAN_NEED_L2_INLINE, &sq->state); if (mlx5_ipsec_device_caps(c->priv->mdev)) set_bit(MLX5E_SQ_STATE_IPSEC, &sq->state); if (param->is_mpw) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c b/drivers/net/= ethernet/mellanox/mlx5/core/en_tx.c index 55a8629f0792..e6a301ba3254 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c @@ -256,8 +256,7 @@ mlx5e_tx_wqe_inline_mode(struct mlx5e_txqsq *sq, struct= sk_buff *skb, =20 mode =3D sq->min_inline_mode; =20 - if (skb_vlan_tag_present(skb) && - test_bit(MLX5E_SQ_STATE_VLAN_NEED_L2_INLINE, &sq->state)) + if (skb_vlan_tag_present(skb)) mode =3D max_t(u8, MLX5_INLINE_MODE_L2, mode); =20 return mode; @@ -483,12 +482,6 @@ mlx5e_sq_xmit_wqe(struct mlx5e_txqsq *sq, struct sk_bu= ff *skb, } eseg->inline_hdr.sz |=3D cpu_to_be16(ihs); dseg +=3D wqe_attr->ds_cnt_inl; - } else if (skb_vlan_tag_present(skb)) { - eseg->insert.type =3D cpu_to_be16(MLX5_ETH_WQE_INSERT_VLAN); - if (skb->vlan_proto =3D=3D cpu_to_be16(ETH_P_8021AD)) - eseg->insert.type |=3D cpu_to_be16(MLX5_ETH_WQE_SVLAN); - eseg->insert.vlan_tci =3D cpu_to_be16(skb_vlan_tag_get(skb)); - stats->added_vlan_packets++; } =20 dseg +=3D wqe_attr->ds_cnt_ids; --=20 2.31.1 From nobody Tue Oct 7 14:46:48 2025 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2081.outbound.protection.outlook.com [40.107.223.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E227E24A049; Tue, 8 Jul 2025 21:17:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.223.81 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752009428; cv=fail; b=G775pF0oj1ou/1K0vLVJdu+hW2A7X4OVF0Q487sse000EJM4z2JkSufhk8eR6rN25p8nC5FLK9oBSIdqJeqaGsm9k0ULj+0Asy0tLwurxewul1TZbXFkfDO7pRhO9XR7Ox7kGM+tDni4MYoxE8OgCXJ9+T8M6T2TlJUMNfS8JeY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752009428; c=relaxed/simple; bh=tO67gcMgBlgm3G0CkGSTNSQxv3hTAkuj+qwjgGZ9yig=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rfLQITA/WQ5gH8rAvk+kt1fB8ILzU1GpwopRs6wCdtppx953PpE6hs2EGYW/TyLBjNu8yABjMor7uucF12qz1hH8SnMcGsacw7J9cqX/skYNYUwyoLSV4Bv6aFh2wa9dU9nv0gFaqstzFW23C3D2y5reiz/mf88RwEvPpp349IU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=qSVOOS/Y; arc=fail smtp.client-ip=40.107.223.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="qSVOOS/Y" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VJiyIeSTE/Z6jEEXwdhzvocfwfbFC2d3cmhGPNNMx/Im/cg35kkitpiAnjzFjhULf5EX8iwPN0NaphLZXPwdIWGaQQytjkH/LQKGoWRReAYVsPgBKuZ4Vix/+Pf3Q2LP8jNMULmkpFfhVam89DBV7UKEqYqElyPkqwSbh+jNwUNJ0IdQxDYIT2DZ4uDXyxwnVKBRStODJcYBC+R7pfMgJmBQVLXOil7mp6YS7fhVRHznRyHD3PNHU8cbel/VdBY0ZaVHozaInLWhAQ8hO+K8z1/bEf5VGXSRQTkmw6x+Aam3BeByskaTdqaoRUsotccdguuZo7ufwfh8XN4sZtJ4ZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IW2IuU/a7LM1HdZXHZo2LwtR0skoM+7tsOL3JyPCpJM=; b=eikJONnwSglmJtlQvf36DjDjeRAMeKvULYkaNS5Okm4TGvY3LaaU7o+ead33aa+RFf25L/LpZB9DZ2HbrS1/K+ir8nJdLw+ZhLrHRh5X1P6Zo6HGFDvdwlBbTtdp0Ul+pky/uYEmaIsO1HRt87xQGQfuN5rNuk5yu2jLyKKOwZ15/fnedNFCRLAIZKHaiDqafuhiTfag3Yu2vzMrQRYzk+Zmisj1WXTb/GM/jqzl/L6Vnf/SPwTDj1euP/tn0Jmv5Pxa2F9ExZ8bIoN0g4ZUjGXhJrGQvxzXmxIpANNbAMvI0InUAaqv+M4WciL5nWjldzeMKw2cWsbR3PURB267Aw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IW2IuU/a7LM1HdZXHZo2LwtR0skoM+7tsOL3JyPCpJM=; b=qSVOOS/YVrBN0mokRwN1kl8SjoaiFjLb8tbIw1chhsYr6jXIbGSS7uGQgqX8nliRyGPQTuGZkDTkJ/qR52qn5xd/y/fdRdqVA7QXnvn3aSV1AV9ZyHlVSYZF9HadZEZvzySZ0G8CSACeRxMQe5xUBqzqUpnZWA3iGE4rqCy5BFLcKjpfmi5Q6JIlFa92P7FyIEJoeeinRrtpQokFh2UNXwihFTL35hPxxP1lwedDJ1pF/05Hz59mxAfPvcmiJqw1fEnxsN65A76O8rDVeCkrNewWPhO2myuUYhO1sQa+J4nnUxuW7CxtGiNrz6fM4cgX4aubdao76yAPcVQlsyUSag== Received: from SN6PR2101CA0001.namprd21.prod.outlook.com (2603:10b6:805:106::11) by MW4PR12MB7333.namprd12.prod.outlook.com (2603:10b6:303:21b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.23; Tue, 8 Jul 2025 21:17:04 +0000 Received: from SN1PEPF000397AF.namprd05.prod.outlook.com (2603:10b6:805:106:cafe::a2) by SN6PR2101CA0001.outlook.office365.com (2603:10b6:805:106::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8943.5 via Frontend Transport; Tue, 8 Jul 2025 21:17:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by SN1PEPF000397AF.mail.protection.outlook.com (10.167.248.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.15 via Frontend Transport; Tue, 8 Jul 2025 21:17:03 +0000 Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 8 Jul 2025 14:16:45 -0700 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 8 Jul 2025 14:16:45 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Tue, 8 Jul 2025 14:16:41 -0700 From: Tariq Toukan To: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" CC: Saeed Mahameed , Gal Pressman , "Leon Romanovsky" , Saeed Mahameed , "Tariq Toukan" , Mark Bloch , , , , Cosmin Ratiu Subject: [PATCH net-next 2/5] net/mlx5e: CT: extract a memcmp from a spinlock section Date: Wed, 9 Jul 2025 00:16:24 +0300 Message-ID: <1752009387-13300-3-git-send-email-tariqt@nvidia.com> X-Mailer: git-send-email 2.8.0 In-Reply-To: <1752009387-13300-1-git-send-email-tariqt@nvidia.com> References: <1752009387-13300-1-git-send-email-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF000397AF:EE_|MW4PR12MB7333:EE_ X-MS-Office365-Filtering-Correlation-Id: 5501dc16-aff8-4c23-5676-08ddbe64c91b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|82310400026|376014|7416014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?wYVBS2CmkObccRyhdGF4RF2qBGH8B2zI9nOGWKfW0XQD3E0h80c1tD9nUNK+?= =?us-ascii?Q?8GIeoHItoZUJXHeiEyK9K4GXvc5XME1wg4eal1ZtiHtHru5Tp4EBFr6wfKtC?= =?us-ascii?Q?TtguK20Rk58xodXR4JeDCeH7liQyMiypSroEI0j4mT41G7wewYBM/51+BupB?= =?us-ascii?Q?l9/1egkXMkQ2ZbqATMq9Q3QRmLvr9kz+Dkrt7+pD3ib33a7p6T+wicwyoaeF?= =?us-ascii?Q?gCmjnw7WzOMqo3kG9hT3XpD83OY3cf9ywsLGjPhoiQbiXtp2EXnwvJ71NH55?= =?us-ascii?Q?gNWS2gcEMH0mMowW6y7W950RdsgWGTQMWVAsOcvzTBA6WHkZl9+piP+M0z54?= =?us-ascii?Q?u+tB6o0EUerXWC8jPopmyHsuSrfrBfeu2Wqk/yBlyC7HLCV/KYdwz5i3OCKT?= =?us-ascii?Q?QsFXQGt6K4FqdouqEh2ODhaLMPVwjG6myNMtc7I3QB8yQ8qOdnXkikLDiegY?= =?us-ascii?Q?v+8/ljz1Oxfai8JHb+yimJLqsHSeP0o5PmtSQhqtJh0TrBtbRD3gwm3+8ggh?= =?us-ascii?Q?6S5NGu1hAJC34QCRZ2bTvHXx3gZwxe+ocpS6tzfFI+GR++dVbJU3exSt+oxj?= =?us-ascii?Q?JLJTGvDqA+9Bk9vrDvwIZOx7r2fq7l0Udz0MZ5fdSgenf8/dwEsdoBYgKkJz?= =?us-ascii?Q?L7MNbnv4Gq2fSriT50pdE3Cj2hPHdOIyHh85kYlDU0qJtFlhB0P6RXhNuesI?= =?us-ascii?Q?TF5hnOPPTqjZ5n/ln0GG/jruusWodxw7YEhdHUsi4LPvf8McMOrvRBwW31BZ?= =?us-ascii?Q?LYzzBW35w+GzSentGE1Kply1UFbajLzEY+Ge5zMZc99Rjxni/cp5H6DuTE9g?= =?us-ascii?Q?UYVLweeYs29O0CQSipWFUZCPc0eNHExxWHs38SPce/vK4eRA6VXTLPLBu42P?= =?us-ascii?Q?EqpUlLGxC7ISdPM71mUTyPWSd3CAxkQDS0Vgb7zlJwAqZB2l6hfqxAX5YKdn?= =?us-ascii?Q?BB7qnvgzZLIFv/nWVoVbO0igvEGwFamWqMkChFH/zg+TziQ4Vy2soMxGloXp?= =?us-ascii?Q?eEgQNgvnQyvZmSxVB83MLzYcNqEiwlANg3Wi0F4oLHkxgrrJGlEfb/Q+RZPx?= =?us-ascii?Q?UTAT8EM5DwdF5h9yZKJuvbb8yKUlsegJ07LuFNmNJ3L64P0pqUFCdmF9rXRM?= =?us-ascii?Q?+8xkdDxTFQw3VkpIivfBpz3IkQyUmUFRJVtMKPNXhUQJ9huBdFksYX+aatk1?= =?us-ascii?Q?eJscxFU3vWI6B/PF60YNCwZDjFpgcVrwNwMopW7yt9OFKCHNCbGQyio5XhxR?= =?us-ascii?Q?oU8P4PGXBUFvHGNOXa1JELiiwOHqxaiUWUC8Y4qsoYGfDaRODucSDKEzK4cs?= =?us-ascii?Q?LsC9ytJTgFEJ/eaCOIO9zOGKaBFQ4KCfVe1YG9xb7ctKucy6oPZTKnrAHDf+?= =?us-ascii?Q?RpR08u7gU9gmyC28Ov3pbR2rtvTAqU+5eTRgot/jJUxUDcPtEROWoo3rQeg/?= =?us-ascii?Q?jZvPkevvPNLtzjYshXlXgR6ZCmuxFh5CRNRPW4aKdYcBY0tBzmAnQBfoBjyl?= =?us-ascii?Q?7EoDCaYqVJM+HZVd6gUTZB1hzlGIH9NAA8Sy?= X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(82310400026)(376014)(7416014);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2025 21:17:03.5149 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5501dc16-aff8-4c23-5676-08ddbe64c91b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF000397AF.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7333 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Cosmin Ratiu This reduces the time the lock is held and reduces contention. Signed-off-by: Cosmin Ratiu Reviewed-by: Dragos Tatulea Signed-off-by: Tariq Toukan Reviewed-by: Simon Horman --- drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c b/drivers/n= et/ethernet/mellanox/mlx5/core/en/tc_ct.c index 81332cd4a582..870d12364f99 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c @@ -1195,6 +1195,7 @@ mlx5_tc_ct_block_flow_offload_add(struct mlx5_ct_ft *= ft, struct flow_action_entry *meta_action; unsigned long cookie =3D flow->cookie; struct mlx5_ct_entry *entry; + bool has_nat; int err; =20 meta_action =3D mlx5_tc_ct_get_ct_metadata_action(flow_rule); @@ -1236,6 +1237,8 @@ mlx5_tc_ct_block_flow_offload_add(struct mlx5_ct_ft *= ft, err =3D mlx5_tc_ct_rule_to_tuple_nat(&entry->tuple_nat, flow_rule); if (err) goto err_set; + has_nat =3D memcmp(&entry->tuple, &entry->tuple_nat, + sizeof(entry->tuple)); =20 spin_lock_bh(&ct_priv->ht_lock); =20 @@ -1244,7 +1247,7 @@ mlx5_tc_ct_block_flow_offload_add(struct mlx5_ct_ft *= ft, if (err) goto err_entries; =20 - if (memcmp(&entry->tuple, &entry->tuple_nat, sizeof(entry->tuple))) { + if (has_nat) { err =3D rhashtable_lookup_insert_fast(&ct_priv->ct_tuples_nat_ht, &entry->tuple_nat_node, tuples_nat_ht_params); --=20 2.31.1 From nobody Tue Oct 7 14:46:48 2025 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2057.outbound.protection.outlook.com [40.107.220.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50188248F51; Tue, 8 Jul 2025 21:17:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.220.57 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752009434; cv=fail; b=I8hVZq88tI+l6r+4OYfmDxwHrRq27imy9U5iVOk+SzZX+E2C9YNYG3HTz88jlEUvuo0uR/5DNfkd5sde6n4oh8zudNllM15d0h6XHMj641gnoCIZpk+PDLcqtGgTjer650lvD4Af7CGroo902mNNDpXPzZckJVlxtQQBzK8wlP4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752009434; c=relaxed/simple; bh=o04aJwUG6N9O5xfb6bIop4m1HhkSzkKSHZvNUCFDwLk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cvIPS3Ixi4kZwBCgFcTSVvQ/PfOgpEsrAVtzsH3SftDWFNrDwwQJkd/hTCJg/GzyiJwc2doHxo7TzjkpvpoZhE6RwpvCI4USzGW3ZctWIyF9Gl1ZDIWdXbSLP4zbnJZsXRwHvStxucbS0OIYs/CyWQ+RDcesoZbrYTUedtDas7w= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=frPDSrf0; arc=fail smtp.client-ip=40.107.220.57 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="frPDSrf0" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nLaWnxAm6+cYXBPEsIuCojpL7RI18Ydq59qfCgtqpThHFOx1x4LjS6h/ZLdg4OwERzigmMur1s15Kxd0GnB03WVrzyr0PipAQ3Pk84wePslpDGPUaxak62Atq3unBucAEFfYUj/fA1j9evenZT//4PBlfSUjfRJfvw6zpZeyl7w4J61PKkSNS/jPvlXXWJjw0WnWU/2ZRVzqdRZpF1HfRstBy5CnG3S7aLHD6b3Kbhd2tiiSPRT9tiDbRaxEYaAu19WWc658sKMd5ureO1SgmVUPcx78vNGSSZecnvxh6wYucPhwzru9scEXym7qTe5ZCFGZrOBU2v76PkjqOB8GMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zqC3nJRfA3U1fbBzsw4eH5kcILbfNdkviuEi6eObJbI=; b=TKYvI1UQxfWFaSVvn24vM9nmvR0EmCS0LUHYAGwKBh4r8t0EdW2FPxAnBVQhqayMZWe7XDUDd5xCAhdfzMzobWjrp6n/kmOjOqBdR77uGcWPFblfidg0v2dKrUaf4Yuw6fYtO9KpMNFYno/dbvTkCGj7zYiwo/XrgAxnsPfsHPmI8GBNHAXpH40tvbz+pZZANk1T7RPZjpoZBM6/pdDLJjyVKjUcVtFE556wgT/QVd/dWU5ofOiWXOytJiD5OMHCCRiUA41hTcfIl/lhgSJ7FLmW5zsr/N1haiWCZv4hbhtYa4TRNyfa2bhCZ7IjJhQeE0gD8VnMbCAfGERdfNP02Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zqC3nJRfA3U1fbBzsw4eH5kcILbfNdkviuEi6eObJbI=; b=frPDSrf0tebI6W2QOSTceAzsfT17x7wD91mVTEBzv0lK43YqIjl7hadFgjL+J7+iFEchXcpXmh7AhUYFZGO/Avl2+BEG5lDS6JiUegpWp5bnD3ud8HEKhac39pouDnap9KtQ3nm8QIiHmREknG5hbJLtQ6zxNGN8MuxarH2kgq0A5ZKRlwelSEstIgoQpjdg1ZLp9nvVS+EQxpZIoy8K/tHQUoWb21eezgsji7qD5hdBOvVfi9w//jCR/aBcBw7D4Yi/kVNDrokZAPgMoZXYVqk5Gs5jsVmUNPaEjxUp5UVkQR6eMALsKqwWjXmokQhAS+Cg9AIuBnYsInZaKlnbng== Received: from PH7P222CA0017.NAMP222.PROD.OUTLOOK.COM (2603:10b6:510:33a::20) by DS7PR12MB8252.namprd12.prod.outlook.com (2603:10b6:8:ee::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.17; Tue, 8 Jul 2025 21:17:09 +0000 Received: from SN1PEPF000397B5.namprd05.prod.outlook.com (2603:10b6:510:33a:cafe::95) by PH7P222CA0017.outlook.office365.com (2603:10b6:510:33a::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8922.21 via Frontend Transport; Tue, 8 Jul 2025 21:17:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by SN1PEPF000397B5.mail.protection.outlook.com (10.167.248.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.15 via Frontend Transport; Tue, 8 Jul 2025 21:17:08 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 8 Jul 2025 14:16:49 -0700 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 8 Jul 2025 14:16:49 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Tue, 8 Jul 2025 14:16:45 -0700 From: Tariq Toukan To: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" CC: Saeed Mahameed , Gal Pressman , "Leon Romanovsky" , Saeed Mahameed , "Tariq Toukan" , Mark Bloch , , , Subject: [PATCH net-next 3/5] net/mlx5e: Replace recursive VLAN push handling with an iterative loop Date: Wed, 9 Jul 2025 00:16:25 +0300 Message-ID: <1752009387-13300-4-git-send-email-tariqt@nvidia.com> X-Mailer: git-send-email 2.8.0 In-Reply-To: <1752009387-13300-1-git-send-email-tariqt@nvidia.com> References: <1752009387-13300-1-git-send-email-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF000397B5:EE_|DS7PR12MB8252:EE_ X-MS-Office365-Filtering-Correlation-Id: 1a366568-165c-47c0-266f-08ddbe64cc18 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|82310400026|7416014|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?S8tlFdkXNzmEBlElplBdkBeZi/yoG4rE9rZcwcdxfkOTcneH4YYEFkl4162c?= =?us-ascii?Q?B3mnhvjhRxBgDQXxxYEV9WbWBpAljrsrdx2Yer3dyCNmZ2xUHIvtseYxYlau?= =?us-ascii?Q?Sx5+jNIwugjTvmKjlMETb+ubDPNnQqOmwILtfdtIzAbM42WtxuKDNbVs9y2a?= =?us-ascii?Q?j9VXHVXMOTLGXSPkAWfoit5bwaqGv34Tp4v+1Nk8V9TWbhvZKm40EmYPOy3r?= =?us-ascii?Q?a9HXgocl7AUQDlfQ0GB3jzebXhIEHdp9tTMXasYQ631BfcBylYgX49VN5M7g?= =?us-ascii?Q?3TUcCW/0ZPu9HTYzlUuKnLuB8IIyPmsiadi2kCf94tgfU/HQYO5JXVgIIslw?= =?us-ascii?Q?+8RcUeDXmyL2c/NXqgswVhVrgFIK7Vdx+OZgNKxWmfgAvlgeTjzMtCjvBp5l?= =?us-ascii?Q?1Oh5i+d/8vnhIqHRZYoWFoRVxygD/CUoEuaNxupE2qo3FtORmyotj9+WJCLY?= =?us-ascii?Q?hGJ8eiFGjfEoo8UdnnhhjcsP2sKqyw61yg8D5F8a2234oXK5NLpUUhKqK7Bo?= =?us-ascii?Q?cGlW3wFa8LjejMb9Ei4xTKUjrovgGzNSOrRDJEeP5A4+MAh0TWsG+cCqKq68?= =?us-ascii?Q?gYVlSyLtnYcl1H+Vtz5wMGr0jbQvBG3TKgPcqqZnWv472eMnAhH9lEsNspgn?= =?us-ascii?Q?S2gMSWtOt82aZtV/oOLpF6SZowkzk70SUOMUhnBOVg+qHC4IxVBzQhpyc1yE?= =?us-ascii?Q?V2XEYWBVhpma2dUVe2C25SxOukQ2XWkhE9sEzooh5os5p8hJURcyjjd+mBYd?= =?us-ascii?Q?hMv4CGRY+IaKpXPEblSp8RYTJzsyB/rNY2V1wmh746Hozzo35amu2Dx6TApJ?= =?us-ascii?Q?WTblRQ7NGrnZGQkP6GTG3StQlBinMGwb4Sx8ReB2Gy1T3ScmBiIcaCzwp07r?= =?us-ascii?Q?Fkw3gCC9r6kGFkNPzxo4XaH9+uuxHQgTDHVQz1yAa/xszrelCb9xDkXwGeeB?= =?us-ascii?Q?RwAZ4DmpDt5POoz7CmmR52rfK0Zb0KdsTHbIMZ6X2uLYktTrd2bc4/u8M27l?= =?us-ascii?Q?PyKHQRyIJG5oqU8AKKsxkOXccSzHh46RbMp9H66rYkTCqzjGr3pbhcy4dFz/?= =?us-ascii?Q?q+DuLC8ym4uGEum9H/dzu06Ms2h09NDA2A+ZN68Yz4V/NkzltZczx/Zf9+sJ?= =?us-ascii?Q?HTXdc6MF86vvOH5WHwFbs6n4+2YVGRZY5MrEVNGgVQ/HmqdB38DKaP0Nkq7S?= =?us-ascii?Q?WmN/xpPFGvo5DWpJuYknNMHBmeBAYAD7tjecrhYl8bPqau4IVswesF+i4FJD?= =?us-ascii?Q?oHCVv/5f1m5o7ztzi7YSkRt/u/BP/1pLrSvSj3agZNw6fFzoGHWhswmvuZf4?= =?us-ascii?Q?FsDH3AijOFBhsHRhCBiGdDp6S9GQUvdznc6/+ygVLzE6WRhtG/CS9LyfmYTK?= =?us-ascii?Q?NkVB0NmFW+L8bdEZwBj+a9cfONoL7sP7cVWSQw2Y4T1O2xumiiupUawx1Pmv?= =?us-ascii?Q?2rU1OVcHDWhuFgiF2rz1ORHj0gnoW4731TLz7nSYGIFiole/xz2XGSgfNpKN?= =?us-ascii?Q?7wanmr6BrlbxKe0lbXgqafz+VbDxG6ar0Mz5?= X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(82310400026)(7416014)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2025 21:17:08.5179 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1a366568-165c-47c0-266f-08ddbe64cc18 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF000397B5.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8252 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Gal Pressman mlx5e_tc_act_vlan_add_push_action() uses tail-recursion to walk through a stack of VLAN devices. There is no need for a complicated recursion with unnecessary stack consumption and less obvious code flow, rewrite the function so that it uses a do while loop instead. Signed-off-by: Gal Pressman Reviewed-by: Cosmin Ratiu Signed-off-by: Tariq Toukan Reviewed-by: Simon Horman --- .../mellanox/mlx5/core/en/tc/act/vlan.c | 43 ++++++++++--------- 1 file changed, 22 insertions(+), 21 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/vlan.c b/dri= vers/net/ethernet/mellanox/mlx5/core/en/tc/act/vlan.c index a13c5e707b83..9bdb5820c553 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/vlan.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/vlan.c @@ -94,29 +94,30 @@ mlx5e_tc_act_vlan_add_push_action(struct mlx5e_priv *pr= iv, struct net_device **out_dev, struct netlink_ext_ack *extack) { - struct net_device *vlan_dev =3D *out_dev; - struct flow_action_entry vlan_act =3D { - .id =3D FLOW_ACTION_VLAN_PUSH, - .vlan.vid =3D vlan_dev_vlan_id(vlan_dev), - .vlan.proto =3D vlan_dev_vlan_proto(vlan_dev), - .vlan.prio =3D 0, - }; - int err; - - err =3D parse_tc_vlan_action(priv, &vlan_act, attr->esw_attr, &attr->acti= on, extack, NULL); - if (err) - return err; - - rcu_read_lock(); - *out_dev =3D dev_get_by_index_rcu(dev_net(vlan_dev), dev_get_iflink(vlan_= dev)); - rcu_read_unlock(); - if (!*out_dev) - return -ENODEV; + do { + struct net_device *vlan_dev =3D *out_dev; + struct flow_action_entry vlan_act =3D { + .id =3D FLOW_ACTION_VLAN_PUSH, + .vlan.vid =3D vlan_dev_vlan_id(vlan_dev), + .vlan.proto =3D vlan_dev_vlan_proto(vlan_dev), + .vlan.prio =3D 0, + }; + int err; + + err =3D parse_tc_vlan_action(priv, &vlan_act, attr->esw_attr, + &attr->action, extack, NULL); + if (err) + return err; =20 - if (is_vlan_dev(*out_dev)) - err =3D mlx5e_tc_act_vlan_add_push_action(priv, attr, out_dev, extack); + rcu_read_lock(); + *out_dev =3D dev_get_by_index_rcu(dev_net(vlan_dev), + dev_get_iflink(vlan_dev)); + rcu_read_unlock(); + if (!*out_dev) + return -ENODEV; + } while (is_vlan_dev(*out_dev)); =20 - return err; + return 0; } =20 int --=20 2.31.1 From nobody Tue Oct 7 14:46:48 2025 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2062.outbound.protection.outlook.com [40.107.101.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF13F24290E; Tue, 8 Jul 2025 21:17:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.101.62 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752009436; cv=fail; b=GcIrvdPLaWqOCLJFSxxOmenINtm0PPiEL0l/Fp0SjbDipyH5dzXsbw44IZ5fWdhzEAf+oP4eSTZC7gWLyy5UiIU01TpZ+MOCHDQwyTSfGb6TOFSIYnfSnFg+dQq/TTIqiuB/r0gWjG8GIax49CmMcHz+V1uo08j9Zmjrv1MFEvM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752009436; c=relaxed/simple; bh=ZXvORc40euWtYzoM9RV7uqqsUSV8PPlrNfUh/vBWv/c=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ffl1RX6mo6rVV/XicZj9Uu5Hh6C6otdVNNXNEjQ7BSJ/8X40Q1fO1FMYxq6OA5duAcOOlJBm6p9d9CgzUFX51VboDueQfsec+L6GTnEJf86ZhZoa61S5wyo4CFNVa6Lk2fxVlau2fdBBM63QZsTEYh7sMkt0ydrctVopfZj1mCc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=EALHm7nD; arc=fail smtp.client-ip=40.107.101.62 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="EALHm7nD" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gB16TrENWwRu/KUYrSNtFmgO+JIN7Hu2kppTJ/WX4tAzAUMP+SLfPthx0OgHrjimA6UI36NGLtAANMO9yvvVDC0C5aXktDe6PEQvD160g0k13MXFcUcCd0L7P2ELE0kWYDaPeFmzuNuiZihjedtizFsZAc7vNAxeEX513iknmS7kDFHGvo9aaEXch7oGK7tUHKmYOp4PfC49to1/yLeuRRUlChkvm+/WecvyjxsCNrunH42eP8cuDplrGkZpVsxvVxSAvnUBEHPmBgZyqds8VZXG5bpyIfVgN0PBA9MUvv8lgXsXVl7//JqPcanQY2Nfcnt38JtqwJVjZ8LwArxOSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h6CuLR25B3OMon9JGm6TJlO4e5OoklkNXXy1q9LE3yg=; b=OIZI5avu+cmgvQ+1PIjNe+Q4HuHb7r4dqzrWR+vkDGJJ5FkpWLq4K2UJhSlPrwdqFNuUgdx3xGNARtSuODV5PZN/lutlOPUFWuQK9kde7pJYj6PNO8orixrdut1ULYkyLIXlpxvTd21cHpnoXtsuBT88DiHMGCpYuwGDYIpu+TqOfWdwCeY2n5+o7dyCk/uBuc18dq6y5k+RuCc4bogI93Rjgi5bskyo4h53buRMWooFCaoFk5wuwGstCw9QyfwTdIIOFRr0qEgah08dcoaDTpOrh7zgovdw8tVWDHTXOSNbzhRz0exYvKhVf+Lmm8roLAJjcZVx7gIup4B2O+xdog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h6CuLR25B3OMon9JGm6TJlO4e5OoklkNXXy1q9LE3yg=; b=EALHm7nDnjIj6rGKP4YOjddGNQ7TNkuJJB0GZ0P1NSRFAblaYltax/z4Hmf+MkZr8b6uHssPekxxdvBF+LHaxheTrpfTmDnz/xe1op8NqUWVmZyqEjXQPq8Mm1s92d2ivKD6O2/h6UItS73KV+2EMV0clZi2lsmlEaOZpb3BsID+nhiu3E30bY2ZyLJuqLBu6vO30h9sk3/3N1Y0xxAQwE4cLoIJv6TeD/pmW6FGO3Lrxb/jfVpuLV8BPTIpLB5HiM/w4A+2GxO24RSJVBvXjtEcbV/5c1oa7sh43LvM7CFOZe1MK2/xUz8vyTmwdOWXDnJ2MdwpoYwISo8yRB74jg== Received: from PH7P222CA0009.NAMP222.PROD.OUTLOOK.COM (2603:10b6:510:33a::23) by DM4PR12MB8474.namprd12.prod.outlook.com (2603:10b6:8:181::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.27; Tue, 8 Jul 2025 21:17:11 +0000 Received: from SN1PEPF000397B5.namprd05.prod.outlook.com (2603:10b6:510:33a:cafe::6a) by PH7P222CA0009.outlook.office365.com (2603:10b6:510:33a::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8922.20 via Frontend Transport; Tue, 8 Jul 2025 21:17:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by SN1PEPF000397B5.mail.protection.outlook.com (10.167.248.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.15 via Frontend Transport; Tue, 8 Jul 2025 21:17:11 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 8 Jul 2025 14:16:53 -0700 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 8 Jul 2025 14:16:53 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Tue, 8 Jul 2025 14:16:49 -0700 From: Tariq Toukan To: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" CC: Saeed Mahameed , Gal Pressman , "Leon Romanovsky" , Saeed Mahameed , "Tariq Toukan" , Mark Bloch , , , , Maor Gottlieb Subject: [PATCH net-next 4/5] net/mlx5: Warn when write combining is not supported Date: Wed, 9 Jul 2025 00:16:26 +0300 Message-ID: <1752009387-13300-5-git-send-email-tariqt@nvidia.com> X-Mailer: git-send-email 2.8.0 In-Reply-To: <1752009387-13300-1-git-send-email-tariqt@nvidia.com> References: <1752009387-13300-1-git-send-email-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF000397B5:EE_|DM4PR12MB8474:EE_ X-MS-Office365-Filtering-Correlation-Id: db0d4b39-b0f5-49d0-6d8d-08ddbe64cdc0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|7416014|376014|82310400026|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?6wOQqbp1eX/O2ZKY5Y0po2OwQWGYUBSamLGsHOwO476fCTojiiU0Nmidmuwo?= =?us-ascii?Q?CAhRAzKauU+bLiXkyPuuWJnh0eP96x5+aTgSZlmMLFtCwFpduQnXiQWORTEW?= =?us-ascii?Q?ylG6BjntU/i9yBOb86Sfk+hU3psUvBtZS//Hj0ORI0/I+L8fNGxxasgaECmo?= =?us-ascii?Q?uUmIaIKlxJ9gs4cNxV3IALl9dT1N2+xTR03d0Dq6mzdI9dYUHUI2feuY1hQ0?= =?us-ascii?Q?iznC2bBfvfxhEUAUnZE5YWJeQ8YBq51Ak8G51V7m8uGGSfIhvd0DRjzffBX5?= =?us-ascii?Q?kOF8PpZAVrTLvlt7ujE4ow2+vNsruB+DqCvxZFcWM5wWqtWhuAm7BzVPsHWi?= =?us-ascii?Q?PSb+fzvn5nDh0vpExquVf0f+MWekSZZynl6NwvmppGCpCROChd79gGc5ymOZ?= =?us-ascii?Q?4w2UCG0yj6ZAIJeZYnjzCKWn5mkE+IHwa/jRWzK+1IJFNOqxPFwJoUoQW/AQ?= =?us-ascii?Q?Lp5wBAljSWSF1bx+uwD3PJWA6uZO47CM3RVRsRMso+8ZU7RGd//nEGg0Jvjc?= =?us-ascii?Q?lcX6RBbFe7H44z3k0kgp+5A9WgEVY++2NgeRn187caocZRGieab2/SxuGO3X?= =?us-ascii?Q?/QZKAGptgDJv69o1Cw2pgWFk/n4pNfTSwLjqpdGpFzRbeYkE+hguyq1uFGYp?= =?us-ascii?Q?EJhe6JX2tB/vbfj0/lcBPojFsrAHUqNdLHgb9S6kk/SCpwByadUuc3KO7XRt?= =?us-ascii?Q?88N+PnwSq2gaBMDARCqCXdIEdq8He7kCOWBvKVp0UuIs/WGhJso/fF/zudLm?= =?us-ascii?Q?Ngg8XldbmJMkGjZcPyZuS95eB66Jv/IzLOImZI55KrGvOwbNKU6zf1ZsJM/Y?= =?us-ascii?Q?8Qqjy+bDzNivJnlr8YjZFdU8MC5CnZGCsHERQ/EZ4KyKrnJkr8wL8e4INsyM?= =?us-ascii?Q?Ap1oablNbXvFIf1BUnpQwGOKhFxqqAhuAvN3gCh2Mfr022U+84ggWHTJyHkG?= =?us-ascii?Q?qT1NsVDECMhw/wBjQPY215E4nWkvFB2rQqISbwOjeHNbAUk+Ady6L0PwqLf0?= =?us-ascii?Q?pmYRxKM14v3+JH0WSQFppBIYqdHBdnSZ86HQqR8RZkVcDJ5DE8+DIeLLeSZd?= =?us-ascii?Q?JJK6wFqk/wrZH6+EeYKCxJL82dArv3DzVg6iI+pN4NGGchbgwcUecItFqgDz?= =?us-ascii?Q?uXjIQxgA4bNV071/oxt1dOGhXr0T+H/lVV8DRHNzuOtb2O5hDwF761xojFNX?= =?us-ascii?Q?ZypXbWiS9tdETYp2P8v8mwdFEalWdLbNYSaJI24Wpd13CKSF+rfnJtJT1pN9?= =?us-ascii?Q?CcmsKdkWphVdYhOsl7uef3RcY5lRwEC5zpOSSwFlGcOpTSXS/XzLg9XD47pG?= =?us-ascii?Q?eD1vO/1JEb5IDNlGpMT+9cobF6VjLs3cKDA/y/rx7EnoPyHthnsrBHDc/AnN?= =?us-ascii?Q?zf5zcn1uFu0VvIcZCBcz58RWtor8hoEBxCAaymDpIEvxIZT5X5mjhCT81NPP?= =?us-ascii?Q?QSqcYR90wO8j2Wljr4UbRQKfWa7SiX4sN/9DsbbYytMKzoFX0FLnqoRieHiV?= =?us-ascii?Q?eBrWJxz0FGDOwK6W5TgRr4hNWSvr0YXDUx8I?= X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230040)(36860700013)(7416014)(376014)(82310400026)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2025 21:17:11.3364 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: db0d4b39-b0f5-49d0-6d8d-08ddbe64cdc0 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF000397B5.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB8474 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Maor Gottlieb Warn if write combining is not supported, as it can impact latency. Add the warning message to be printed only when the driver actually run the test and detect unsupported state, rather than when inheriting parent's result for SFs. Signed-off-by: Maor Gottlieb Reviewed-by: Michael Guralnik Signed-off-by: Tariq Toukan Reviewed-by: Simon Horman --- drivers/net/ethernet/mellanox/mlx5/core/wc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/wc.c b/drivers/net/eth= ernet/mellanox/mlx5/core/wc.c index 740b719e7072..2f0316616fa4 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/wc.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/wc.c @@ -378,6 +378,9 @@ static void mlx5_core_test_wc(struct mlx5_core_dev *mde= v) mlx5_free_bfreg(mdev, &sq->bfreg); err_alloc_bfreg: kfree(sq); + + if (mdev->wc_state =3D=3D MLX5_WC_STATE_UNSUPPORTED) + mlx5_core_warn(mdev, "Write combining is not supported\n"); } =20 bool mlx5_wc_support_get(struct mlx5_core_dev *mdev) --=20 2.31.1 From nobody Tue Oct 7 14:46:48 2025 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2054.outbound.protection.outlook.com [40.107.237.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C7EB251792; Tue, 8 Jul 2025 21:17:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.237.54 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752009437; cv=fail; b=EIdOhDXn0AwV/WxjwdrBibjt53mOBNoKlhcZ2q84rqHAV+OKw0b2v6k+VWIsKxFMM4/TQwrPs4/ddtTxgHJ7GZ48euRdbzdBqvAfb++svRq9HQ+OJn7FbhB/IPo80EFaIxqce0Hjn2RGSGpALRLwX9rKAuwHwbBzY7JyDX650yo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752009437; c=relaxed/simple; bh=M7gic7/nVeVa8CPTx/GVnTPTpA/kvQobUY0MX4+g8dE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cVFkrd9rHJEeLfMkD8fBZ/V80ArWhgkiroeF6LuJ+YnuF00bQB2iGVd9c0JvCyJQSqnL30tvD5QM/XLAWOcf9Z/3KTMDOyL8T0LleR4azXyqSysZ2cyf+wRKQUvv9AHy/aGSSkH/txoWgyR18gldpgHjzHdKLT1yJtc18aNljlM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=TWcmRgMC; arc=fail smtp.client-ip=40.107.237.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="TWcmRgMC" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Wi/opI3ENvWGxA+MdhP1/OCYbLUsDLDPcGtW/THSYtPmz1Jmz7//fTCLrO54E/ld+r7if8SqEyn65PAfIVf3X0pUr3vGMsBuCNCafkGtElhgrBp+q/RhmrynqVq/34nqsohIjE12Kl/ZPpS2tL7JtPdNfCEAPBDphr9TxowKgUCj6dND7/QBCTbTiQuAeZqLBUDK21VGV3AU80VmIw/JhGQ0AXjH7F+ub7RFvXamEdHeH8wqEFmupw3hpR6n+Lj7pz5CfWsfEv+8gs7kZwGyLkN11AcjCWa7fV3t0Eu1RvKSzjpzvJIv/CBS/c2wf8QrXzT664I+clZV1JZLtSg/mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dnxD2vJQ1xpim/Ofed8TCDALx6YRmKyfch4XJFCvv/8=; b=u8BQqllUcK41CiDRaDcatQhgj+hJplsXkQmeCnOTG/pKUcMg6CAc7ClpUxxZ+DuK9JKwSXBW0m7YjR2hwVmoInuPhsQl7xXKs0qCQ3u/b9jnQvTS1FBWqzgKcNSLK06dKs2DuKiAnOqZENzAGTA6NYQsqAiqVjKVTFixGH8Tc80MXGLe8X85gva6ToGC/rT0j7YMWmhz2CSYgEcg4bR48YCZov1A7XVai4Qd00xTxE29KW1AlLN7RSqDjUb6jDmxe3oDysJTGfMfOX+KEiLlDTpmyvDUyrdYcqfBQi1o6aKHYq+VrP5/teoT6JJ8dOf5O7bMYrU/fZzGJ4Jqjrt+NA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dnxD2vJQ1xpim/Ofed8TCDALx6YRmKyfch4XJFCvv/8=; b=TWcmRgMCctIiRhKYWW6Brfc/fvEF5xu09k69mr0z69P9U9mG1mLE4+2WBlU2+begt/0jSxEPVa5YTpYIK71TmNfbybaMUrL0gcYSjrIazRnp1g2fOZ7Fdw07a4+4zT0f20iUQU500nRnhbScaYUFgDd6/pkYkfitmOYnEqYJxgOQM8Rmc6uWAFSJXVD8uIX5En29n3qDp1uboPUGseYEPCRKytHgRhg9ep2ZqXNLX7yrGnrVdS7Q25ezbNt6mSyK+CmEYy/G2Cxc0eFFn8Nncq4CCRzIwm5TLZdguMJeror9GHCeuqu4D8QS2uvzy8s5bOQoeHZIK9jHF5xWq5d7ug== Received: from BN9P223CA0018.NAMP223.PROD.OUTLOOK.COM (2603:10b6:408:10b::23) by CH1PR12MB9647.namprd12.prod.outlook.com (2603:10b6:610:2b0::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.23; Tue, 8 Jul 2025 21:17:12 +0000 Received: from MN1PEPF0000F0DF.namprd04.prod.outlook.com (2603:10b6:408:10b:cafe::8f) by BN9P223CA0018.outlook.office365.com (2603:10b6:408:10b::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8922.20 via Frontend Transport; Tue, 8 Jul 2025 21:17:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by MN1PEPF0000F0DF.mail.protection.outlook.com (10.167.242.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.20 via Frontend Transport; Tue, 8 Jul 2025 21:17:12 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 8 Jul 2025 14:16:57 -0700 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 8 Jul 2025 14:16:56 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Tue, 8 Jul 2025 14:16:53 -0700 From: Tariq Toukan To: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" CC: Saeed Mahameed , Gal Pressman , "Leon Romanovsky" , Saeed Mahameed , "Tariq Toukan" , Mark Bloch , , , Subject: [PATCH net-next 5/5] net/mlx5e: RX, Remove unnecessary RQT redirects Date: Wed, 9 Jul 2025 00:16:27 +0300 Message-ID: <1752009387-13300-6-git-send-email-tariqt@nvidia.com> X-Mailer: git-send-email 2.8.0 In-Reply-To: <1752009387-13300-1-git-send-email-tariqt@nvidia.com> References: <1752009387-13300-1-git-send-email-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN1PEPF0000F0DF:EE_|CH1PR12MB9647:EE_ X-MS-Office365-Filtering-Correlation-Id: 2438859b-4462-44e7-1012-08ddbe64ce88 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700013|376014|7416014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?ymSnPN5Ke3LjpCk0KbNS8zg5pLuxdBTIBpnEhX4hWTH5WuINLYouzCOaphqt?= =?us-ascii?Q?RsG0lUr6JmHAtVC4hijOXGtgUuH3UokVb3I7k1cEV9BLTMbHSjkO5mqWzZ0I?= =?us-ascii?Q?rDA28MLqcTdgD7u/4d4NlXxARxNvBci3jnD1VfxsHctu5BlL03iHp0+JMj4U?= =?us-ascii?Q?wVxO51wKDfZsxigtVc9vdJikrgNl2/wUYnimhtnIE9C9JgK4bFU4v6umP2I6?= =?us-ascii?Q?keQ7Lj/JGp4uGwYY1nWTZ0ar1iDVUZ9RDRa4vo+DpRQOI/wCk9QGRe/sEpSL?= =?us-ascii?Q?23Sf4jDFG/485eoHggXSAZeG/o+iHzgmOBaHti1ELgYdZoP+FE7n6cgs3Pck?= =?us-ascii?Q?BF6TVLCOXuxINzks8ftuxVNLINuIn0lqkmBvY0jrdTclPNRrMtVPRrw0xcck?= =?us-ascii?Q?yWKSjpdQ5EcdRv7b2GqoI+QY2ofzwlor5oyQNws9nVGV4MlTgNBujiy3dbMV?= =?us-ascii?Q?SeXZBMAb9VzG5ZhiyYF5wM0hdA+Dj2MbNtdazpvFGagT5CuX87IYGYD8vpLG?= =?us-ascii?Q?7q8sREAZMLaCXUyo9EqV2BAv9Dw+X71+OIxK9b6BSEHRa6jooB0STwXXYoaa?= =?us-ascii?Q?hA9j+zQNKOyyOUUVwmDHxTrRdmJr5sieL4YjOOrIqS56OR/NCQTxiqqkazvO?= =?us-ascii?Q?HbauvkK6mHXGbin/ViXzKFNlBpO/eTVLtp3DQJG0idPCsUcUexr3k+eojXpy?= =?us-ascii?Q?qC2tjBZ1D7FGv0Rl6Ro0STEn9LH/fpIiE21D8QGsbgye70yHGCumQ58oj5Mj?= =?us-ascii?Q?XX3xCfw0XxSN4vVTuPRodhSsa756kou67+JIlsdvwRCK1KHYGVRcPGDv4etk?= =?us-ascii?Q?92QBgHz95dcbZR/FVTbOmznUv/4YViaiTfrJdDPs87UBKCYTQNJSFlm5BPs/?= =?us-ascii?Q?h09D3q29eObfHTFB1jc6w5UaUx3OfZCMXjLkLK/7c6cDDcVpCn43EsNm/RR7?= =?us-ascii?Q?ct07o5E/xdsFA925No1ymEOMtLy7Fpe7SLzzbV6er604bO9yvFTZ2eBfwxcS?= =?us-ascii?Q?YRw5hP99wn0DFTEc2x3ENpV4F4eP+0MMQAbZLXZWPyJcisxlZBByNdHWlR6f?= =?us-ascii?Q?9hT1Rzs6vdqRgzLn7TYR+cT9JCf3dWlTprrlhkxMyN6BK8ZJNLnPkKQiqKc2?= =?us-ascii?Q?Q1ymwuTQJxL58HJ0NrmOhDgJrD4Y6mhiBI+jNPnnb7kOKKGnkGaiuWPgIqjC?= =?us-ascii?Q?4ATk/oNwS984Y7RVNPhXJBzfQx+a2g5n2iz0GhRPKWQWfxDcAT+tR6vqvLCx?= =?us-ascii?Q?rwxJoiKRrtUmPy/RsMlW53ihOaBS6tM+wMbs0FZvB43MqJCU/94xGxeQTmDB?= =?us-ascii?Q?9cBwpEtenRq4gzKeSfR0G4RYgd3Ht8k0WrMlC28/X5F7fye68FX9SrJQHW7u?= =?us-ascii?Q?q10nsvDEPl3wZjAoTGlE5R42tLwjZ9ZaQNkpbg/H1JjREK0bkGNIISmfIWaE?= =?us-ascii?Q?z861XdySKZ5cTWAxG97VtuDLc17O9JlcuWO5wwkocU74mR7WqGwws4mGJEGL?= =?us-ascii?Q?C5NF359DsdD+RUWDpBT4VVggEuo6vAwc8c9N?= X-Forefront-Antispam-Report: CIP:216.228.118.232;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge1.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(36860700013)(376014)(7416014)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2025 21:17:12.5644 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2438859b-4462-44e7-1012-08ddbe64ce88 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: MN1PEPF0000F0DF.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH1PR12MB9647 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" RQTs (Receive Queue Table) should redirect traffic to the channels' RQs when they're active. Otherwise, redirect to the designated "drop RQ". RQTs are created in "inactive" state, pointing to the "drop RQ". In activate and de-activate flows, do not "deactivate" the rest of RQTs (beyond the num of channels), as they are already inactive. This cuts down unnecessary execution of FW commands (MODIFY_RQT), and improves the latency of open/close channels or configuration change. Perf: NIC: Connect-X7. Configuration: 1 combined channel, max num channels 248. Measure time for "interface up + interface down". Before: 0.313 sec After: 0.057 sec (5.5x faster) 247 MODIFY_RQT commands saved in interface up. 247 MODIFY_RQT commands saved in interface down. Signed-off-by: Tariq Toukan Reviewed-by: Dragos Tatulea Reviewed-by: Simon Horman --- drivers/net/ethernet/mellanox/mlx5/core/en/rx_res.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/rx_res.c b/drivers/= net/ethernet/mellanox/mlx5/core/en/rx_res.c index 5fcbe47337b0..b3fdb1afa1e6 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/rx_res.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/rx_res.c @@ -579,8 +579,6 @@ void mlx5e_rx_res_channels_activate(struct mlx5e_rx_res= *res, struct mlx5e_chann =20 for (ix =3D 0; ix < nch; ix++) mlx5e_rx_res_channel_activate_direct(res, chs, ix); - for (ix =3D nch; ix < res->max_nch; ix++) - mlx5e_rx_res_channel_deactivate_direct(res, ix); =20 if (res->features & MLX5E_RX_RES_FEATURE_PTP) { u32 rqn; @@ -603,7 +601,7 @@ void mlx5e_rx_res_channels_deactivate(struct mlx5e_rx_r= es *res) =20 mlx5e_rx_res_rss_disable(res); =20 - for (ix =3D 0; ix < res->max_nch; ix++) + for (ix =3D 0; ix < res->rss_nch; ix++) mlx5e_rx_res_channel_deactivate_direct(res, ix); =20 if (res->features & MLX5E_RX_RES_FEATURE_PTP) { --=20 2.31.1