From nobody Sun Feb 8 11:36:50 2026 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2081.outbound.protection.outlook.com [40.107.244.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3EE01F1301; Sun, 25 May 2025 11:15:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.244.81 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748171763; cv=fail; b=Dg7EDGPZtPs+XKaJX9fFq6Yy+M8+ohfvve7rpf3K1PRrZI4vS6moP3cUX3a95ATbHyaw5sB2tpXGnWXZWYXRCywVGbPL2uhyWFiDnKd4ckTQFqVQSdklb9geB1FlATzbOdgJp6c7VxNYVDwV39bdRoWP3FU7zoQOr8c8EAvyfZg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748171763; c=relaxed/simple; bh=an1w57jWoJfssYjefFFfHQRxL0eRV8ZP2hT0GFgadgs=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZhlCm3YH+9UZsqqrIjpTKNlF+YAn6eCXSlQCW0raNs/eI+Yrm1LSEGEsv85mRsWza9ISqweN+k34YuBG3jzdam2f6WBYjr4A3G0P63tRM/6uOuZVhP8jUCH+mRjlbTtVE03KU23XFm+7t7yD33GRQQ2BGeL0//81hLsibOs4Wr0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=YOSqRC18; arc=fail smtp.client-ip=40.107.244.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="YOSqRC18" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MnpNLsJLijjjcKblfiUZrGe+RKjAWvqpIw6GJNKky7YiBC0Oyo/gCZ94Kq6vSK1Kn2MYoZCTZfv7CvkQ3hLvAnki62uEYPjYh3IXIv2EOWUBeQRD7xQJftvsJK229qSCmnf1QBvu6bXbcLuTeYZl7d7Od6efhGkQsOX5eUcnVRbXUuHlPIz/5rUG660TXy4QmMfGF+ctfNwWrIzQxeB2yiQxuEUDFqEXsuYB6ZZpBZ3Oolc177cpUzjBxLvegpqy5YMdeFMExHMjf+/R/NIYXw7XqjcYPqJf3cpG0GyoMmGlcpopUiMPBXP2Eu8k0UZpunuzSV1KVkTwNmg8GQfViQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ROq0lbKmEBReeOeebbtCthxh1feHH1vYNiKBIN8chzk=; b=jTUBSlEncJK04sIw3aJe5mmK3QgOR6aNRIKpoypdzV+3n0qqNmaA1uOLRNGh7F9GMVIgRv+Sbp9emlWAsHeSXx+DC8HQST+uIjqoSsdzlpdhLdwQSu9A+OIpFM8FTC4HKGsB4yclaSmpinKD9xlUYr4l7fHpQmDoWlI0Lpd7Yuj3z/3e2KcH7OjW7i65rxOcKmpzDtwJVk+vz4Bm/S0RhOW0QtqyXxms600Pv6JRVDEQCE9oKZnrpstEu92+2yNQmY9WrAV+c0pyz/+G3CIceMSmFggLcnpXVXomIc3uT+PjCpxxCpHg87nf6lc5nerO/yNsisopQ7UhKqJEdVF5uQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=davemloft.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ROq0lbKmEBReeOeebbtCthxh1feHH1vYNiKBIN8chzk=; b=YOSqRC18b+Z9l01Q1z5ElM539bSOl2ZzrCdBSpXViehchtRL2xi06TsMctkSfVgVaHRSy58sXbPfZxSPxmvkHMhYulPeu2UeLzvzs0oR9pYOayzs+oVF2qXjjWHPC8X/nfDLL12eYg+nU/ROHZ++0hvHbJTr1FsWW+i4cuUNCdJH+4WCdliw6TulTWUXXzWI8evXfO1QsQy2duQBLYvBH5HkHCcwUdnAMMMtC9LM6TNdQlFQ4HYP930xMruAviHNvtJwu79zp4Vrd5dKb6xDBMYbDHyYGvRbY9aRFJH+2s7b3t+wLX1+KHH8KxndvfZHxgmn6VMM+swWxwKyxy8Mdg== Received: from DM6PR21CA0008.namprd21.prod.outlook.com (2603:10b6:5:174::18) by SA1PR12MB8918.namprd12.prod.outlook.com (2603:10b6:806:386::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8746.30; Sun, 25 May 2025 11:15:53 +0000 Received: from CY4PEPF0000E9D1.namprd03.prod.outlook.com (2603:10b6:5:174:cafe::8d) by DM6PR21CA0008.outlook.office365.com (2603:10b6:5:174::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8792.4 via Frontend Transport; Sun, 25 May 2025 11:15:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000E9D1.mail.protection.outlook.com (10.167.241.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.18 via Frontend Transport; Sun, 25 May 2025 11:15:52 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 25 May 2025 04:15:36 -0700 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Sun, 25 May 2025 04:15:35 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Sun, 25 May 2025 04:15:32 -0700 From: Tariq Toukan To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet , "Andrew Lunn" CC: Saeed Mahameed , Leon Romanovsky , Tariq Toukan , , , , Moshe Shemesh , Mark Bloch , Vlad Dogaru , Yevgeny Kliteynik , Gal Pressman Subject: [PATCH net-next 1/4] net/mlx5: HWS, fix missing ip_version handling in definer Date: Sun, 25 May 2025 14:15:07 +0300 Message-ID: <1748171710-1375837-2-git-send-email-tariqt@nvidia.com> X-Mailer: git-send-email 2.8.0 In-Reply-To: <1748171710-1375837-1-git-send-email-tariqt@nvidia.com> References: <1748171710-1375837-1-git-send-email-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D1:EE_|SA1PR12MB8918:EE_ X-MS-Office365-Filtering-Correlation-Id: 4d03e02b-9f9c-47be-7eb0-08dd9b7d82e3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|376014|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?fz1bVE3Lp2t9+cXvgBDgw1LBGdhFlgbYDDJmamJhWZ/+VFpSAn6y95MnTsTv?= =?us-ascii?Q?dpzF+nLGbl59UB4zqvNXEOycbxzU8UeDEuriBrAnh7eWPrI6AIpRP62oUfSR?= =?us-ascii?Q?xUDVhhqa5Ww6tzQ9RHwn0kBmnIs5EZGoRPVOc3HEF4upMt6Di+ntBmw32xQb?= =?us-ascii?Q?tZa4SjoGYVOUHaB5WoulV85FGUnA52HjKAgOw5Cm7ssMQwAkorO223pV/BHH?= =?us-ascii?Q?TIpF4Wam76YcRUDV/fakoXD05eij5ZS2D4zviH8PQ4yKeceIby2ZhAT1T0hI?= =?us-ascii?Q?HBloxtsS5b4WThDo/1EbsbuhMF8Fxl8WHvcusPUQ+j7mgSAPEnP0ssuyip65?= =?us-ascii?Q?87odXHSQR5eP4BDeSLXK2fjv4ojIbp8fScL37THzJMwntO1MFbWXfhsTrJF7?= =?us-ascii?Q?xDS+ogHw8s6JAPoeY/i83rD/CM497JdNk2zkwTkqBnI03Dbayv0al1y9xGI6?= =?us-ascii?Q?uwlImf8IoJCPUWvDnueEotp++BmJGCqIlpk50mElJpKAJ0c26lFGrOonkH07?= =?us-ascii?Q?q32vjDpGYWskfsxrRN7ZNKu4lq9HjQV+eAmByCHOnIri39bJ8/ppyqPUDm1Q?= =?us-ascii?Q?K2S0wnXuW0hJwhxyfGmDkLdbf6LJeBbUFbX7vU0vv++cgOKBoCLJnl5QpBe4?= =?us-ascii?Q?cvOlGZtlbO9XZS4K51iB3kkR1LOnBiAgnHxIeiRn+9qNFgOvZwcZ1zlRkl/E?= =?us-ascii?Q?o3eXozpTbWrnshRywH8+CzMQ64P2K8oNUkBk1LUAVN6Zpdp+0ekiXqomUA/u?= =?us-ascii?Q?YbhAJ+roak9ORcbdSTj1Ahig6lagCUifmJQp/fZn/jAIVog72d+uhfyi7d1J?= =?us-ascii?Q?WDKrmps6xumHYWEXMRhC1rRhc5zZlQAVqhDeEZpRgEP7hXJzyCqfZ/E+wyVN?= =?us-ascii?Q?WAm2p0tL6xh5/z4bgc1okOpx1wuLYM/+NHq7ewgJOF+4eWzN24x+LrPvCgtq?= =?us-ascii?Q?j3IRSHCp4m7pVJqqe5kQwOXG+I/vEyhwZpr2Lcuf5/GOaqgMU+Ls8xfnSw7e?= =?us-ascii?Q?Ueg/1QluNKoIDx8L6221iKccoscueOnpfCW4RPLdeX46l0/i5z+X8awpA4x+?= =?us-ascii?Q?+wEdKXIM6ed9Sr9s6bAZRi+a5f5vR90tCtkZNxcSKv6QsJjGqcqfManIzy6B?= =?us-ascii?Q?bJnuLjbWrcduoo23Xg7DFTHpjs+OeHat4QxIZGkPQ9jqBCOjGN+/b04NqbmQ?= =?us-ascii?Q?70CuuW0iuU0bcyXrrZ300YYuUf3LB6sOtK8O102/LzylFncm8RbzN3y/XV6V?= =?us-ascii?Q?QEmPRXzUIcMmGk2znfIxiDrZA9oPebt3dfCz6S+fglQn59HK+1ga1uY2L1Lk?= =?us-ascii?Q?0fbQltYptUSN6PVb/EFC/QTRIiKQieE+YpGsV+cEKx9Pjj9yIWI7T3Rm83b5?= =?us-ascii?Q?X1JV0hPBiP26dOgB1wH/UGfUxyKUGmP2RNC8l/nbAPxvY8mf2+GmtXepvzyW?= =?us-ascii?Q?Kzh+gK1shIwo4L7CTqQADqy+zQGRKwc3YWJZzJKmtoQRI1k4yTndvMSIX8OO?= =?us-ascii?Q?Asq6tFVVh+ik8Mr1FTDz22RTEMfM4/aWG+Av?= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(376014)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2025 11:15:52.4151 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4d03e02b-9f9c-47be-7eb0-08dd9b7d82e3 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D1.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8918 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Yevgeny Kliteynik Fix missing field handling in definer - outer IP version. Signed-off-by: Yevgeny Kliteynik Reviewed-by: Vlad Dogaru Reviewed-by: Mark Bloch Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/steering/hws/definer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/definer.c= b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/definer.c index 5cc0dc002ac1..d45e1145d197 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/definer.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/definer.c @@ -785,6 +785,9 @@ hws_definer_conv_outer(struct mlx5hws_definer_conv_data= *cd, HWS_SET_HDR(fc, match_param, IP_PROTOCOL_O, outer_headers.ip_protocol, eth_l3_outer.protocol_next_header); + HWS_SET_HDR(fc, match_param, IP_VERSION_O, + outer_headers.ip_version, + eth_l3_outer.ip_version); HWS_SET_HDR(fc, match_param, IP_TTL_O, outer_headers.ttl_hoplimit, eth_l3_outer.time_to_live_hop_limit); --=20 2.31.1 From nobody Sun Feb 8 11:36:50 2026 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2061.outbound.protection.outlook.com [40.107.94.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05024143748; Sun, 25 May 2025 11:16:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.94.61 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748171762; cv=fail; b=bD3jYhOSWYs5bKC4o/sAzbviif2+4oDDsfz3fcW3mp1hrvvYIWI2dKAneoTN+JjxlIqub0dph6XWCdNS3y8G2lrNOLiGzcGWi6LrzqOXeWQ1wylqcgQla+lvY4rdyDFIK+Ysbqq4XWbfsntjPJqmUDjvTHGZDMIs0vAq6j49Iy0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748171762; c=relaxed/simple; bh=+vukl64guUe/LsD1GE2O3pnn+1b/oJs7kZ5gaB8epqM=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pyoKjkQVMU/9mTfIgL+BM8msiInAaXXaRurrlkpqqgOfSvVNhG7/m9MtUFr4P/JdBEle0h8Eiqi9wGCxT06Hp8+K8sllBxlQ4AgCu+PL1TFY0Fj44slVVYLVJHC6nJkuRk2raH358Cb00rVqszfUxOnisF+1iE6+xaFdkcO56GA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Dw/1G9H5; arc=fail smtp.client-ip=40.107.94.61 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Dw/1G9H5" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jbr6HgkE35DAfhSS0RaFHg94C2oa+nPQ9RwZBb0QaSwVE6nN+QMHtAiB822SWCOik2wgWq8cdTGe9o+fpFNognjYQ66e/FgoGGbq0kFmpNld2ZNr4G3AHF8JPJcR7qj8DPLchMDMgGBOuLhA76piJblukkfRQGlbUeE81Ymx+vf9ts8ptFkpsC/7KYMcBwDeS/2HDX+nLlOOBYqNXhA9oU91XS5RhUYFqI+S3EW0lO8tX8stT+4A1hwBGCMIVzGaOveb1rWqidRpd0XQe6RBZFuWqKamosLIKwCVFjOayscRn4IRGtctq2PeP8yI0tx4xiaJIbbCsA9L5k7MVGefuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1iToxc6lcu52x2WmVEOw7VMc1QfJKN3uCmcvtWnfIRs=; b=TpgPVmXFMWVLddeaAwtQUfnsbm6RQDKLX3xmoOqojs1VzUqtHI47qeaZCngYqeWzWGpgcp00x0GeA3jg2MI2evminvpOokx8iC+qQbMbNHqUYmFW1k7OgKU1BQLh7YKKYFD7dC5IVJTzT/cHhLuYYoUK6wbR8BGu2lhgxfGjgALXC25RdBnQmRXpyfHp4D7rVxGo7rssgEKad2ShNFPcJ8HTjGuybxPZDi7iX4EOpKbkI7zbiUai0xr48/HsnIfxfjJch05FkhBBF4hteJIJkCf44xiOKkiGXqWRw63qlmMDNXvJac2cNHPfw//INU4OD2ZRS0Egeweadxx3jbu0kQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=davemloft.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1iToxc6lcu52x2WmVEOw7VMc1QfJKN3uCmcvtWnfIRs=; b=Dw/1G9H53DuPXD3khUO6euuX5mFzXvfXl0/Jrj1tOmgBjaH6UZ3/6d628obf6mAVTZTQ/xZ+FzaCzBE4wgsUnVnF5SEVNeTr9gSd6rUYULYXT1GRVFog9sorLxYc2Z1sN7TQUjWu4H6IzRXGOiHT3iv5mzszMq0jW+pUW6ysdAtijmPV6VtX8cRtpsv89KQlfOCmHvnucWdPz2CsnzEu1Om9uLd3lJbyfyaOu2ORQ2t4ofRL5Y/mIGm6ZOOXuSvkmWE3yqIQOFkMYwWYjfsIQhpEbtaL1gLMmPw4I90pcMyTXm9nTOxmDUNfjRtTo9DvtZOT65zGq6mfV8yFNbWzJA== Received: from DM6PR21CA0030.namprd21.prod.outlook.com (2603:10b6:5:174::40) by CH3PR12MB7547.namprd12.prod.outlook.com (2603:10b6:610:147::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.21; Sun, 25 May 2025 11:15:55 +0000 Received: from CY4PEPF0000E9D1.namprd03.prod.outlook.com (2603:10b6:5:174:cafe::26) by DM6PR21CA0030.outlook.office365.com (2603:10b6:5:174::40) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8792.8 via Frontend Transport; Sun, 25 May 2025 11:15:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000E9D1.mail.protection.outlook.com (10.167.241.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.18 via Frontend Transport; Sun, 25 May 2025 11:15:55 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 25 May 2025 04:15:40 -0700 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Sun, 25 May 2025 04:15:40 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Sun, 25 May 2025 04:15:36 -0700 From: Tariq Toukan To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet , "Andrew Lunn" CC: Saeed Mahameed , Leon Romanovsky , Tariq Toukan , , , , Moshe Shemesh , Mark Bloch , Vlad Dogaru , Yevgeny Kliteynik , Gal Pressman Subject: [PATCH net-next 2/4] net/mlx5: HWS, make sure the uplink is the last destination Date: Sun, 25 May 2025 14:15:08 +0300 Message-ID: <1748171710-1375837-3-git-send-email-tariqt@nvidia.com> X-Mailer: git-send-email 2.8.0 In-Reply-To: <1748171710-1375837-1-git-send-email-tariqt@nvidia.com> References: <1748171710-1375837-1-git-send-email-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D1:EE_|CH3PR12MB7547:EE_ X-MS-Office365-Filtering-Correlation-Id: ca98a4aa-ee0b-4825-12be-08dd9b7d848a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?aVDNh9pxVuNT4+cljuFxacy0aGH3ZP8HdomtnPnhjBmRBE2+snvc4asJKpGC?= =?us-ascii?Q?BGN7MqTGO93kMl0r0bLB68l8b5x6AEAN83XWaEG5U12JGEmfkiJtLv7pSYCC?= =?us-ascii?Q?XgE+JBA+UyEMrvVdFwyNfNyu8Qem9gfH3U7oE7tfTwOajiYCWxNLkRz+NKPI?= =?us-ascii?Q?RTDflZxIUkVxI8hDNALpm/LShIgv2OMM4vmNafSD4Z7qvs6sVBhah5Ii5OlF?= =?us-ascii?Q?0Ufa6xzDpRWjQma+/g2eENhXIcYt82Ntoj/7bl44wSnGjy7i7ZsssFEZxKqS?= =?us-ascii?Q?kyzc2tebWqF3e2ebU4Hy6g3A763BeEs9KnfBQMAaNaVfjq28jqHVo5eOvxf5?= =?us-ascii?Q?sZUXGBDlRo9/7twt9Fxem3NVQzcxubZc/ehntOeQfndz0Z7s7j+MA0B6A8+w?= =?us-ascii?Q?gKKrkqf2OdnMz5fjp3GnnjyiU9zIZUFf1+BcZ3TBLz/E81a1u7mX2OE43e6o?= =?us-ascii?Q?VsQ4hzc7s43vOGKbnhqAr2OD/Qa7Ed8HYNnaawhoMSs2LBi/sKMhWcxvgfjC?= =?us-ascii?Q?j6oFhg79p3f7seaurjITMIym6bFidlwRkakPNMmFchl10QL9QSDwTgoxqt+W?= =?us-ascii?Q?1I5UKn00WAolvhQ2q8cuET9oP/AZk2kuYkE+a+bzW2DtR6jNvTZBJ06tKgp0?= =?us-ascii?Q?RdaQbkyVI02jSptSKb4AKemqU3POP0oeclmWac8hDCi6Z1pbEQrDYMEnE3hT?= =?us-ascii?Q?Rr6NzihztUOmgwjPfYLy06bBfguN+7OJMXxf/tRMj4QctDExSNuer4zchqLM?= =?us-ascii?Q?PRd2FQwKLxDOSAgNxKDSE4vwE56oSSYUq89H5gIDIpoitZebAWk+Q1acbR24?= =?us-ascii?Q?mKBleECAp0AOG7ZNX0pK6wm79r6Y4+JW245fkMifXCrqAfQ8S0013FHAjl4i?= =?us-ascii?Q?f0yFJqrLXYRvxlFysF0DOl3FmIbGED63UlarH1wh133HKUk17HZmv38bJuqe?= =?us-ascii?Q?pcpk+uGdDEaNExaKJWF/cnAxBtgmEDXUaNk7e0R+/A0wiFj5ybmfJzvMm1VG?= =?us-ascii?Q?W2++0cfhX9WuNyN0zZeNmCUWw6pwTIbE5n5fYC1GxIW522ISWK5UOX9N9/pr?= =?us-ascii?Q?UR4BLe5CpRLhyqBLx+BvtFrjcsKbeW+HMQ9Ju5RstaizyJDFI+EPPrTsSwj6?= =?us-ascii?Q?3KvhCZJljYJyOpPC7Irn8aLq3I3MFOJNS8W8z/CsWcEICo3+Zhgj5Zc68LTv?= =?us-ascii?Q?J4qx9rbPiuNZ+7nvZLMObwDVBFRGzZb0vi41/33C2NZh1faLtLX6VKfyqETC?= =?us-ascii?Q?jDO7D0EkoC5j+iSDol450cr+VCFthmxvirSEH3atiYk7LOj7EIreA7+sBo41?= =?us-ascii?Q?iOuwJ0LddUe3rDZofq/xVpWI615ow2nDHzb4PtyPp5FR4/MR11LwaC5qp6AM?= =?us-ascii?Q?c543Z/yIJfu7FEKK3pC3cW/2yJBudvAelMUU8OPD6mI/aXi6S/YdtBCECGAD?= =?us-ascii?Q?KHRN8nYNyOtNx7X4N9MQxe92O+3rlQKOrNlwKU8dogaDSm6dSEyZUl5Fq3/T?= =?us-ascii?Q?yABQMYlk13IhZSGkAKfwan1/QQiCQWE2jXKU?= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(376014)(1800799024)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2025 11:15:55.2334 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ca98a4aa-ee0b-4825-12be-08dd9b7d848a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D1.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7547 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Vlad Dogaru If a destination array action contains a wire destination, it has to be the last one in the array. Replicate the check we had for software steering to avoid a firmware error. Signed-off-by: Vlad Dogaru Signed-off-by: Yevgeny Kliteynik Reviewed-by: Mark Bloch Signed-off-by: Tariq Toukan --- .../mellanox/mlx5/core/steering/hws/action.c | 19 ++++++++++++------- .../mellanox/mlx5/core/steering/hws/fs_hws.c | 3 +++ .../mellanox/mlx5/core/steering/hws/mlx5hws.h | 1 + 3 files changed, 16 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/action.c = b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/action.c index fb62f3bc4bd4..592f3a2ede2e 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/action.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/action.c @@ -1370,8 +1370,8 @@ mlx5hws_action_create_dest_array(struct mlx5hws_conte= xt *ctx, struct mlx5hws_cmd_set_fte_attr fte_attr =3D {0}; struct mlx5hws_cmd_forward_tbl *fw_island; struct mlx5hws_action *action; - u32 i /*, packet_reformat_id*/; - int ret; + int ret, last_dest_idx =3D -1; + u32 i; =20 if (num_dest <=3D 1) { mlx5hws_err(ctx, "Action must have multiple dests\n"); @@ -1401,11 +1401,8 @@ mlx5hws_action_create_dest_array(struct mlx5hws_cont= ext *ctx, dest_list[i].destination_id =3D dests[i].dest->dest_obj.obj_id; fte_attr.action_flags |=3D MLX5_FLOW_CONTEXT_ACTION_FWD_DEST; fte_attr.ignore_flow_level =3D ignore_flow_level; - /* ToDo: In SW steering we have a handling of 'go to WIRE' - * destination here by upper layer setting 'is_wire_ft' flag - * if the destination is wire. - * This is because uplink should be last dest in the list. - */ + if (dests[i].is_wire_ft) + last_dest_idx =3D i; break; case MLX5HWS_ACTION_TYP_VPORT: dest_list[i].destination_type =3D MLX5_FLOW_DESTINATION_TYPE_VPORT; @@ -1429,6 +1426,14 @@ mlx5hws_action_create_dest_array(struct mlx5hws_cont= ext *ctx, } } =20 + if (last_dest_idx !=3D -1) { + struct mlx5hws_cmd_set_fte_dest tmp; + + tmp =3D dest_list[last_dest_idx]; + dest_list[last_dest_idx] =3D dest_list[num_dest - 1]; + dest_list[num_dest - 1] =3D tmp; + } + fte_attr.dests_num =3D num_dest; fte_attr.dests =3D dest_list; =20 diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c = b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c index 9d1c0e4b224a..ab1a4c7f1813 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c @@ -966,6 +966,9 @@ static int mlx5_fs_fte_get_hws_actions(struct mlx5_flow= _root_namespace *ns, switch (attr->type) { case MLX5_FLOW_DESTINATION_TYPE_FLOW_TABLE: dest_action =3D mlx5_fs_get_dest_action_ft(fs_ctx, dst); + if (dst->dest_attr.ft->flags & + MLX5_FLOW_TABLE_UPLINK_VPORT) + dest_actions[num_dest_actions].is_wire_ft =3D true; break; case MLX5_FLOW_DESTINATION_TYPE_FLOW_TABLE_NUM: dest_action =3D mlx5_fs_get_dest_action_table_num(fs_ctx, diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws.h= b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws.h index 9bbadc4d8a0b..d8ac6c196211 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws.h +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws.h @@ -213,6 +213,7 @@ struct mlx5hws_action_dest_attr { struct mlx5hws_action *dest; /* Optional reformat action */ struct mlx5hws_action *reformat; + bool is_wire_ft; }; =20 /** --=20 2.31.1 From nobody Sun Feb 8 11:36:50 2026 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2067.outbound.protection.outlook.com [40.107.237.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 337581F4192; Sun, 25 May 2025 11:16:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.237.67 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748171767; cv=fail; b=if39wdQErP2ffa89Ohu8s1d69PsUOM5tu3zLViDrirzeTG+Aip4wcBl+ZVryx6uEjNWJ3U+AV+e2GKog4ZVdlRe26q8aFBLoGi1qxgM0OUfNrX914HO2K9F2+KNAmHkz0Teepz0bHgI9i+cuVezKQyi89VmafedeikNga+b2T6E= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748171767; c=relaxed/simple; bh=jJwpBTEeH7eDBO/zjbw7JJdFRsZZxb/EKb796iRDyco=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=MwvgqybfL+yUwqfRT+QfAR7d3lAHH6o/tqFC/4R9OMj28sz6FZXVeyCKzpnD9F5H+cagqRtTKU9oFaIv7lW55Y8sBL1/sQGOd2Gkrq5sfYDIlY2x9WmvcwJnNzU6/K37mVfQweCcePgRdLThQBbEVs1ZtfOs5k/L0GnxqmWl9Ug= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=NKSallNj; arc=fail smtp.client-ip=40.107.237.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="NKSallNj" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Uju6e8nGXZIz2xVOjNR2o/z8n+YZ7/Kf3YKO3paqNsWj2xnGCFg5insdIKJvUV6VM07Nh5p1QzcQBCg8cpmljhS+Fe5h+6t7zrdyueF/Oxbn+leXigWSpC5fy9dop+3zakoPMRVwF9vo/tB/ZsXJoQWUMnbIKRp4YEsMe8KriG37d21VekVVXuvCq/yKIelQaRRw1C7QsreXwMVBtSvvHNyC1b1OmnjO9VsZAFRyueusPdq5FKSuaFOZ2OlDM234yYM5CAbTNZUkx5jCOcFKSn988DjmhEWZstEAWXwYf7Jr5h5WFFH/JVdIquIiVCVopt3lH5Bxs9G8GdqsHS9qtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=syU71rpyRW9NjFFsz3CcLcN00vHZQIF7Xe7AwGhaaEc=; b=xbVBdVcnpxPN5sHZ51mKOjykCOWwYONedZAgE8WPUDwaRsEVzSGXx9ojxdoYW/+1Cwkvp5uNR/KgljvEWdtR0yUYihfQLXYbPq7D87teu4dP+Ave+KLR6aQjCsseD8xT+x+wGPr6MiJ9iyKWUegHkc6S5sxqd0LsRAGvCNW1HvZ0cmECs0/61gZyqzkrvGVnRLyoraxtDtB49ftXKaIenQZnmQ+IqnMJTTdLvzCKb25pufduuq2nWZyLzmk0uQw4btQ2YCl2JTPX4I+mG04lR/rQ4s+kR+LFGfH/DWupO6e/gUIEoCKuUgE83117F5lGzv487v7PUwQwiAR//ZFxcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=davemloft.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=syU71rpyRW9NjFFsz3CcLcN00vHZQIF7Xe7AwGhaaEc=; b=NKSallNjDj48UgUuaXqWLd5z2qxi7RTDqKy2oYbo5Cgqd5n0CvXgUx5We7OTufHdsNiWBlSsL0/U4BbCVI3V0jTeGo7kgLJrUmaQ0dsaXHzCyYzXi7iSWiV1NjjttHKLuXufY7YfFlk4dvtgw5nZzhlZMseN8L5Wa98hmopeMgVyHi5eF0q0VG0ky8+34V2XaszCstcShWuC0Yj6/E/xjXsJcD7LBFrgp9Bi7NhnSIR4lL88ArFWokHRwy5VzXTykPZSCR+xXQ8xLeenBEsZGmUpHvjzPJIl1UDYHoA6FyEXB1ApFMvBVYem3n7WkYWRt3wwxbkPtAOlZidOCuDmLg== Received: from MW4PR03CA0134.namprd03.prod.outlook.com (2603:10b6:303:8c::19) by SJ0PR12MB6855.namprd12.prod.outlook.com (2603:10b6:a03:47e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.21; Sun, 25 May 2025 11:16:00 +0000 Received: from SJ1PEPF0000231B.namprd03.prod.outlook.com (2603:10b6:303:8c:cafe::7c) by MW4PR03CA0134.outlook.office365.com (2603:10b6:303:8c::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8769.19 via Frontend Transport; Sun, 25 May 2025 11:16:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SJ1PEPF0000231B.mail.protection.outlook.com (10.167.242.232) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.18 via Frontend Transport; Sun, 25 May 2025 11:16:00 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 25 May 2025 04:15:45 -0700 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Sun, 25 May 2025 04:15:44 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Sun, 25 May 2025 04:15:40 -0700 From: Tariq Toukan To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet , "Andrew Lunn" CC: Saeed Mahameed , Leon Romanovsky , Tariq Toukan , , , , Moshe Shemesh , Mark Bloch , Vlad Dogaru , Yevgeny Kliteynik , Gal Pressman Subject: [PATCH net-next 3/4] net/mlx5: HWS, remove unused create_dest_array parameter Date: Sun, 25 May 2025 14:15:09 +0300 Message-ID: <1748171710-1375837-4-git-send-email-tariqt@nvidia.com> X-Mailer: git-send-email 2.8.0 In-Reply-To: <1748171710-1375837-1-git-send-email-tariqt@nvidia.com> References: <1748171710-1375837-1-git-send-email-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF0000231B:EE_|SJ0PR12MB6855:EE_ X-MS-Office365-Filtering-Correlation-Id: 15dd2f78-3412-4b02-d472-08dd9b7d87a0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?UtOn6BlWdW/JCnCYt7qeV1MvcX3GFhDtW2udl6NjsRkbjEBmks+N9sI2HgMM?= =?us-ascii?Q?TTWiLbgtvRKuTRrN27rVP+4zdBXkW9Wghf+ZS65v+NIE/jfkGobYCJ873x4P?= =?us-ascii?Q?5nefGAae/X8LZFJCctXI3WaU39JEKwhXYume56AJqEoNAmPEYCw9shK61R0Y?= =?us-ascii?Q?OWZFP5DMaTyNc1N/LMp0j7AgtlSNvRAMwUfyh1VB5Tb0CtoxfKCEoueOSZBL?= =?us-ascii?Q?Asv0Tm6gS16k8qyHyuGkObPlwKeBFiTFV0/3oLgEHVUu8CYjIlre8Ml3H8UA?= =?us-ascii?Q?9v+7FffRnfCRl1I1yhyErX9tIrryzIDh4GU0OF7lQyvmb3R+mIITWxTOkr/v?= =?us-ascii?Q?TEP6aqfTRYmuQbxZ6cZpkM+LgDLDUfFzrkWnspfk33/3dDH3tNM2HmDwdtBj?= =?us-ascii?Q?v75gCjOchrn4BeRiRgLxEj+hNZPFoHRzzgwdIFIBSDF0vi9mT+sR68mmqkAL?= =?us-ascii?Q?BxYW0IkdtGyCcNjHcQ71GaRTvommLJTrtab6Mrj6DzkDbRcZVHO1JwDDI1j1?= =?us-ascii?Q?Ce7NS9jLrkzgnzOiWaBIcZE/tsGi3X3KSXWmtYnRpGuqLXyHFLKsMd95AB9k?= =?us-ascii?Q?NI3ngI8c4h76rmUtamakg+iLP2jxTy4ezkynmPyw1hfGABfgfCEy2Vl7CnFA?= =?us-ascii?Q?+UDByf4E/UbAYJH7S63/hNtt+EP9QQXx/+HipAL6QZBpzKWB8spV07vDvBc7?= =?us-ascii?Q?/HAcmA6zOGWKOG30gKlxeyWtKB0ZRwhLLc/5jTJ+TtRAH9Pbx0JntbEOvWU8?= =?us-ascii?Q?xjjAEsNtsoKsA8Hv/5RJey0QVk+Mh4P4tQzlb34/SkbtoPgk+p97QiWm+Zo/?= =?us-ascii?Q?ogzyKvc8BxJcmcp8sCYzmVwK2wEVa2U6ruD1h2dksGYaNzaZQNGdCWLfSvao?= =?us-ascii?Q?SVW3gFkx8ekXltyydzk161HH01yQ+Syrtu0hR8KDo8BDAwzXB5T9iEgs9DIl?= =?us-ascii?Q?hvdVl8qZ5RvMcTfwbqDdAyOMtD3rclqH3ZgkL4XwgjYmqZt2AFCCKvfE9Jz6?= =?us-ascii?Q?FkS/LNGciAhP7ZSPvXGVLqzBr7m5dgVRIXlfk8fEVb7vJul9xTXdYQfQCqM3?= =?us-ascii?Q?vo7Jf/INX4c42ArLd7wz/zPSQekaKX1qc3gZSTuBDN9sy4exzPCNgBvBbyeP?= =?us-ascii?Q?d0OaTsJRvEGhh/2lVy8ogIYMxiaM7zpobVgazUo4x+nMfB/m0dqFofHhyM5k?= =?us-ascii?Q?6HB/N/LPwmhACJHQkEV7eKGye+jRJmzmCa9nrePmfSIs45djOLtsMclP54nN?= =?us-ascii?Q?eCPsWeM8M9tNzXuHpZmDSD/fhbSu8Ojpp+lBprSrpXYdzMcGB8joy2bzPW6q?= =?us-ascii?Q?6O4lWaUrfVVL7RgaZ0py6AX6g3h8TIDuQtPj24l58WfHw4u1nAXVBc5XgYn+?= =?us-ascii?Q?Cb7YylFL236gd4b9Pe7jq44Qfp4HY5yeqE5/9DTa3RspeEOcVl0bxL7LsVuZ?= =?us-ascii?Q?NhN3QjAgA8uozzqZ5vsDALvSrhQu0gyEZV3Emu/4eQfmau3BnAfRxc6F5A6z?= =?us-ascii?Q?JFEU56WpZ8jhD604AalPxDlAWb95qMMDooEL?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(1800799024)(36860700013)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2025 11:16:00.2975 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 15dd2f78-3412-4b02-d472-08dd9b7d87a0 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF0000231B.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6855 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Vlad Dogaru `flow_source` is not used anywhere in mlx5hws_action_create_dest_array. Signed-off-by: Vlad Dogaru Signed-off-by: Yevgeny Kliteynik Reviewed-by: Mark Bloch Signed-off-by: Tariq Toukan --- .../mellanox/mlx5/core/steering/hws/action.c | 7 ++----- .../mellanox/mlx5/core/steering/hws/fs_hws.c | 15 ++++++--------- .../mellanox/mlx5/core/steering/hws/mlx5hws.h | 8 ++------ 3 files changed, 10 insertions(+), 20 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/action.c = b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/action.c index 592f3a2ede2e..106dc416beec 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/action.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/action.c @@ -1358,12 +1358,9 @@ mlx5hws_action_create_modify_header(struct mlx5hws_c= ontext *ctx, } =20 struct mlx5hws_action * -mlx5hws_action_create_dest_array(struct mlx5hws_context *ctx, - size_t num_dest, +mlx5hws_action_create_dest_array(struct mlx5hws_context *ctx, size_t num_d= est, struct mlx5hws_action_dest_attr *dests, - bool ignore_flow_level, - u32 flow_source, - u32 flags) + bool ignore_flow_level, u32 flags) { struct mlx5hws_cmd_set_fte_dest *dest_list =3D NULL; struct mlx5hws_cmd_ft_create_attr ft_attr =3D {0}; diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c = b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c index ab1a4c7f1813..eb7802bec615 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c @@ -571,14 +571,12 @@ static void mlx5_fs_put_dest_action_sampler(struct ml= x5_fs_hws_context *fs_ctx, static struct mlx5hws_action * mlx5_fs_create_action_dest_array(struct mlx5hws_context *ctx, struct mlx5hws_action_dest_attr *dests, - u32 num_of_dests, bool ignore_flow_level, - u32 flow_source) + u32 num_of_dests, bool ignore_flow_level) { u32 flags =3D MLX5HWS_ACTION_FLAG_HWS_FDB | MLX5HWS_ACTION_FLAG_SHARED; =20 return mlx5hws_action_create_dest_array(ctx, num_of_dests, dests, - ignore_flow_level, - flow_source, flags); + ignore_flow_level, flags); } =20 static struct mlx5hws_action * @@ -1015,7 +1013,6 @@ static int mlx5_fs_fte_get_hws_actions(struct mlx5_fl= ow_root_namespace *ns, } (*ractions)[num_actions++].action =3D dest_actions->dest; } else if (num_dest_actions > 1) { - u32 flow_source =3D fte->act_dests.flow_context.flow_source; bool ignore_flow_level; =20 if (num_actions =3D=3D MLX5_FLOW_CONTEXT_ACTION_MAX || @@ -1025,10 +1022,10 @@ static int mlx5_fs_fte_get_hws_actions(struct mlx5_= flow_root_namespace *ns, } ignore_flow_level =3D !!(fte_action->flags & FLOW_ACT_IGNORE_FLOW_LEVEL); - tmp_action =3D mlx5_fs_create_action_dest_array(ctx, dest_actions, - num_dest_actions, - ignore_flow_level, - flow_source); + tmp_action =3D + mlx5_fs_create_action_dest_array(ctx, dest_actions, + num_dest_actions, + ignore_flow_level); if (!tmp_action) { err =3D -EOPNOTSUPP; goto free_actions; diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws.h= b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws.h index d8ac6c196211..a1295a311b70 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws.h +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws.h @@ -727,18 +727,14 @@ mlx5hws_action_create_push_vlan(struct mlx5hws_contex= t *ctx, u32 flags); * @dests: The destination array. Each contains a destination action and c= an * have additional actions. * @ignore_flow_level: Whether to turn on 'ignore_flow_level' for this des= t. - * @flow_source: Source port of the traffic for this actions. * @flags: Action creation flags (enum mlx5hws_action_flags). * * Return: pointer to mlx5hws_action on success NULL otherwise. */ struct mlx5hws_action * -mlx5hws_action_create_dest_array(struct mlx5hws_context *ctx, - size_t num_dest, +mlx5hws_action_create_dest_array(struct mlx5hws_context *ctx, size_t num_d= est, struct mlx5hws_action_dest_attr *dests, - bool ignore_flow_level, - u32 flow_source, - u32 flags); + bool ignore_flow_level, u32 flags); =20 /** * mlx5hws_action_create_insert_header - Create insert header action. --=20 2.31.1 From nobody Sun Feb 8 11:36:50 2026 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2082.outbound.protection.outlook.com [40.107.220.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16F711F1909; Sun, 25 May 2025 11:16:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.220.82 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748171768; cv=fail; b=r/g+95UxM6PsTvOosxjMk7wHu7iBkJY3ONCstuWpjlJAAVPKHdryOH0wPaivgFubYz2YxigOVm+P0T3RBeUQOSChm1okZwk3SfUy5O/DqLnhAtdPDWeOs4mjMSNv1bgY0w2n4uWh6EwLfqXHkbE6l1EdpsYYOvlry3Io1MXQ4Tg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748171768; c=relaxed/simple; bh=t2Re+fhIG9Vd11xpR5C+NQ60x1bVgpdcN15CB09WaII=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ddnVjGz82r2w+vwqQtaj/mdB5g4gs48wPqBV5d2RPZkZNkV0bPxq4BeiTHbB1O4fz1+9e+DFH7g/ZWlZYZe+jyo9+j/vs6PJGlUkCkKNFexFbmSrd3v3iK2AW7DUMN1PV+4VF61AQWkhqjKH7MCt7zvIKD5mnXm67txayyo+PRc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=t8Rt/0gK; arc=fail smtp.client-ip=40.107.220.82 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="t8Rt/0gK" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Kb5qpaCEqG5vc2JcQ4djW5Vq9Ao5wI9t+XmslxQDzWe386qziFjkIIZT8d27iBYelSjJcIP2sP+9oH47uDQ9mFv9uNty7LLbtTKF023LMm8brqVAV+8GSo33G+1789CaBt1ZioLkwyXjCv9C3rRHVLwt3TtyxQrDdf6OgkJv7n6SDsrcu0OcZMaF0ulGbDpVMbFQ7aWmaB8y0jhi8s4yqAE19GQlA/Yj1tkEYa22PbNG4U2VOLSRATEUHhYnDCtpu41Vfbl3MkAaWboQZArtTGgIFO0pAg4Ew+eBRmz8cfI9vkhuMmnXQ7CBQsHsScBAthDPFjWCiEmCu1M1aANZ9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5u3ILOtCcE65M/+t2HdomvIArdFCwRvSHHk7KFMhcS4=; b=jrzxWJs7yUnxgJLxv4iHq6myJT8UgVqhZU20jEVFwKsZb9xgcWmmBMSp9cF7zpldbAjKak0tIr9SbF3fBHYeyFCHkp7Wjb5RWDIoovEJsV01LSth3MoV5gVLOzXV8Udhih1Wg6IR54y+BEkSev48tf2bOjzh37nyUMJa6N550ndkEw0V2AQDL7mCi40yWHq8YM5tUT9p7CGvcshwYKyxNnTdnnaI0Njfv4m0VDvUTP8/qlh+8U2JfBF8TO3jrez/UtFECMFLNuTHLfxbUsVn7GlvknWzEdRfnySXkwNtQu7GGKd/F+tCJNiBtjAIeEiPFjsHf1k38DVyTAkMLSE0vA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=davemloft.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5u3ILOtCcE65M/+t2HdomvIArdFCwRvSHHk7KFMhcS4=; b=t8Rt/0gKzi4yGnrpwLJcCwKRJqOSFtbDRIzI3Mil0fnt1vRQEHi8B0pThc6WXUvhLwzs/dmzyOq10jdP8yY9desLjFcIgAA844WgbU+fUDTFgxGzpAPVrNBg0XDh688Ve/Cp8u6ZxgSCjPc35I1aAhmlBn5xWx7CUghOGy3O9wtmS2P5nt3bMeqz9thGph7fePv8kO4Uz8erzATs0ghu98LY0Q1PAv8FTmHFhl8KqRepHo94MDHNnbkpFOgMV2bH5UuvlNgarx7jQyZaT6tHW8G2CrLAtNA34ApTN7RKXFFPSsx45pfMUR9MvcFf+iCz60bLo2fUGSvXAtjBt7w0DQ== Received: from SJ0PR05CA0071.namprd05.prod.outlook.com (2603:10b6:a03:332::16) by DM4PR12MB5915.namprd12.prod.outlook.com (2603:10b6:8:68::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8699.26; Sun, 25 May 2025 11:16:01 +0000 Received: from CY4PEPF0000E9D3.namprd03.prod.outlook.com (2603:10b6:a03:332:cafe::86) by SJ0PR05CA0071.outlook.office365.com (2603:10b6:a03:332::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8769.18 via Frontend Transport; Sun, 25 May 2025 11:16:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000E9D3.mail.protection.outlook.com (10.167.241.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.18 via Frontend Transport; Sun, 25 May 2025 11:16:00 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 25 May 2025 04:15:49 -0700 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Sun, 25 May 2025 04:15:48 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Sun, 25 May 2025 04:15:45 -0700 From: Tariq Toukan To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet , "Andrew Lunn" CC: Saeed Mahameed , Leon Romanovsky , Tariq Toukan , , , , Moshe Shemesh , Mark Bloch , Vlad Dogaru , Yevgeny Kliteynik , Gal Pressman Subject: [PATCH net-next 4/4] net/mlx5: HWS, remove incorrect comment Date: Sun, 25 May 2025 14:15:10 +0300 Message-ID: <1748171710-1375837-5-git-send-email-tariqt@nvidia.com> X-Mailer: git-send-email 2.8.0 In-Reply-To: <1748171710-1375837-1-git-send-email-tariqt@nvidia.com> References: <1748171710-1375837-1-git-send-email-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D3:EE_|DM4PR12MB5915:EE_ X-MS-Office365-Filtering-Correlation-Id: c750357e-7c18-42c6-106b-08dd9b7d87d7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|30052699003|1800799024|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?M24HYhnlgYDcYBqBG6QrVNfsZ57IklNHiRdOOa7wPTzoCrGszKUjNR5tgNhG?= =?us-ascii?Q?GuQ55b25A43QuF6mkIlriqhylc2GG72kl3pNWDPs/3T/D3rWGM6OzPO91MHR?= =?us-ascii?Q?2cim4xM6AiWAyXUSbuIt4LzNzcQWZWJQ/ZRsjeCTj7M/VCzqBpwovCsGbM76?= =?us-ascii?Q?3KLrBcDzAtyJfQiI7PEbcvt0xaBGtBgcBp7rqFpLuarxO/Q9DjxvwedJxj4e?= =?us-ascii?Q?3MMakS5N5+klKmjELfKjTkerLivSuBWSEtQqLBKTj6lR/KH3L08rZF7M62/y?= =?us-ascii?Q?7V7Fbj3a0Ua/r+X6X/hhfJKcjDy/HaF4sim4i33LZcaHvWEIcUgp7D8Yh/oS?= =?us-ascii?Q?UPsjIkqZmLuwkoCyzRtsp2b1QekcxgsA8O0RvstYuwUFh1aNbtorSywgwDtw?= =?us-ascii?Q?71qnHz+PIxl/5g3DQELC5pM6kCY+Gp4Pj36v/bSZ0ONJY9hmzDQt4WOWhY8R?= =?us-ascii?Q?aluWyBt2x9pvYF/owivk8vFUB7+twKCs/xAjmxmg16Jt2EiF9pp1kYJK6mlw?= =?us-ascii?Q?qFssYAGcJ6RJQ2QFVHdm7Gw+Ei9qqpchOjfbf+Q5xAqX7KPKoidl81LaSuQh?= =?us-ascii?Q?mTOqcFDdNNFHFjbDDrMuWu5+2k3tWD0WyHaalD3J9XMfcZ8hxsLmpce0mcRN?= =?us-ascii?Q?2ZPlvTi17cyMtzRsIZTqraxo1vdvifyWrzV+s2z3OBLF3Whdgb71erUDWWMr?= =?us-ascii?Q?vKlc9m1sRp6GCoKVeEkqGirL+ebiYKlFtYoSZpDBezazuH5rGnVks9uAFwNL?= =?us-ascii?Q?goXk/TgCjC60h3GBGHdGlwnXkI3WUhkpaWk0Ah7aiEQSwKENuVU/i2Hsavyv?= =?us-ascii?Q?DCj7FYKKQP0m3/8mWPeFEjzI3C0Hm0p9gXx9O5f1lae7CuC8CWfA+z750SP5?= =?us-ascii?Q?CJvA50ic17g6JvPFQKWoq1DHR2eaLNHMPSawjaIGWIxQNpp1roRDq9D3IiAe?= =?us-ascii?Q?72qt0Bi4Gs8UbVT9yzjzQJAFxG9DR4FO8gj5HV0ep2nxi9lHPflS/WeLlrqs?= =?us-ascii?Q?iHTuhd9Ss+46YbJ3VVGxxefr8D0k2z5Sf2uKRw6rk0wN9Xr2wwdrW/KGUqug?= =?us-ascii?Q?32AMLyoE5IOvRWXvxwff7o6Mz4v+V8xuCKXcWuLs1pLQclFdh2P700KNBHcI?= =?us-ascii?Q?CuJiZmKdBAbRsZuwpS790fgGxtKGOQsoISECD/SyCO3TRol6yVDgdAqfRpeI?= =?us-ascii?Q?vAETfpX++ZZRqLBZrgWvZAOe9o5384Oa6j5oAw1g12ARdGRRJsdCpOy3EAn9?= =?us-ascii?Q?pUtI0HrDKAriJDcAoci1n7o0Ngf6DxNjY8ZVXL1IfLAfmWCgbc+ph3PDZnYp?= =?us-ascii?Q?NfK2lo48/hOf3aNJLci9GbXwxa11uuh1MpQ9nmpsUdlsk/bTrtciZ6+PYqel?= =?us-ascii?Q?PiZ8xDie7hcQTwpdh5cnXnSQnTSfaWUVLEJkdtCHuoi8PGny8JEsVPZO4N9l?= =?us-ascii?Q?Cg+17bZynNW9gdllrUs5AdBqmaPPy4WjHA6Po3E4JdR1X/l58nYw/2f+v2h8?= =?us-ascii?Q?jN3ctqCuXcjcFf1JqLfA181FXDwv3bG5eO9i?= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(30052699003)(1800799024)(36860700013)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2025 11:16:00.7249 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c750357e-7c18-42c6-106b-08dd9b7d87d7 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D3.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5915 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Yevgeny Kliteynik Removing incorrect comment section that is probably some copy-paste artifact. Signed-off-by: Yevgeny Kliteynik Reviewed-by: Vlad Dogaru Reviewed-by: Mark Bloch Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc.c b/d= rivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc.c index 9e057f808ea5..665e6e285db5 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc.c @@ -876,8 +876,6 @@ int mlx5hws_bwc_rule_create_simple(struct mlx5hws_bwc_r= ule *bwc_rule, =20 /* At this point the rule wasn't added. * It could be because there was collision, or some other problem. - * If we don't dive deeper than API, the only thing we know is that - * the status of completion is RTE_FLOW_OP_ERROR. * Try rehash by size and insert rule again - last chance. */ =20 --=20 2.31.1