From nobody Sun Feb 8 22:42:41 2026 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 494AD21CFFA; Wed, 21 May 2025 06:56:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747810604; cv=none; b=PxtfYXF1bxafLjUbG39ffR2MJpO6NLIxEtg9qZF+WIHoS0Lc56NnMpl3TkaYwWf9bbD/7dwHlXEf7cWbP1w7dQeMMiGYnpxrsAhEaDTPy3voQeOnXPx3jkQQx99amz7KiHAZqDsjXsGPppBKStT67UrzzkoJazDj7ZPFLKjZGlg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747810604; c=relaxed/simple; bh=F3uEABgfR1+DkLbPYcAfXvhGvJq3EQGGdZgGUi1GdVM=; h=Date:From:To:Subject:Cc:In-Reply-To:References:MIME-Version: Message-ID:Content-Type; b=M9uSnAYDLVuxjOrqSUKcqw2O2PKnAIqgCCkPXdrloQeSm/kXWJ8vGySX2di7dSuzVnQmwwEPe9JwYa9SaANoSE966IKZ7gj+Ug/ps3FZSIWb8QCdYkO7XgsVoRtT+eqpZTiA2YBrwa+kqhLVxfX5GIY660G+VA7WdhBYizxFQa4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=lLKDkpLs; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=xm9St06R; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="lLKDkpLs"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="xm9St06R" Date: Wed, 21 May 2025 06:56:40 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1747810601; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/JZggDRh9VVMymbY9g3QDIHxu0xR+YS4bx4xyJb/nSo=; b=lLKDkpLsVB6Oo0lyokO2MdcVybPWUOHU9pGqY6emtPU4oyWwKLRVR2Js8xLbrvgRiS9KB5 5cEvt6uh0XjzafwIstjQRcmfuA//Tq3S9jPGtdmJqJ2ssGhdgTTYu0f+mc+xn0vcNDfox9 nOJDow8DmoclQ56aIaiv8K2k0BiufOGSdv+EGD1xJ4K88X16n65P5WyJnwnzpSwrs/lDbO BH5oGMnn2doWZ03dDUiY3ENshaIsMloUpLahK7MKlGDD6IjSpDLjUPHotwVATg17fjGyKC Zm3A2DO+Li5m9bXK9x+tRmpzBSbK8iK4fO17jHODdGG+KuLnhujZYN57Z2HqLw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1747810601; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/JZggDRh9VVMymbY9g3QDIHxu0xR+YS4bx4xyJb/nSo=; b=xm9St06RjS/Zwj2OuBqGICl2ryWzJqU8lo7SRx1K3V+diY28pXxhTLv3Mbey+GarJItfVJ YuCLOU3Il16eg0DA== From: "tip-bot2 for Xin Li (Intel)" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: x86/core] x86/xen/msr: Fix uninitialized variable 'err' Cc: Dan Carpenter , "Xin Li (Intel)" , Ingo Molnar , Juergen Gross , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20250517165713.935384-1-xin@zytor.com> References: <20250517165713.935384-1-xin@zytor.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <174781060040.406.8154038959914617178.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Precedence: bulk Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The following commit has been merged into the x86/core branch of tip: Commit-ID: e95534e107d2e9e136aa4d7cbededb3827e80074 Gitweb: https://git.kernel.org/tip/e95534e107d2e9e136aa4d7cbededb382= 7e80074 Author: Xin Li (Intel) AuthorDate: Sat, 17 May 2025 09:57:12 -07:00 Committer: Ingo Molnar CommitterDate: Wed, 21 May 2025 08:44:31 +02:00 x86/xen/msr: Fix uninitialized variable 'err' xen_read_msr_safe() currently passes an uninitialized argument 'err' to xen_do_read_msr(). But as xen_do_read_msr() may not set the argument, xen_read_msr_safe() could return err with an unpredictable value. To ensure correctness, initialize err to 0 (representing success) in xen_read_msr_safe(). Do the same in xen_read_msr(), even err is not used after being passed to xen_do_read_msr(). Closes: https://lore.kernel.org/xen-devel/aBxNI_Q0-MhtBSZG@stanley.mountain/ Reported-by: Dan Carpenter Signed-off-by: Xin Li (Intel) Signed-off-by: Ingo Molnar Reviewed-by: Juergen Gross Cc: H. Peter Anvin Link: https://lore.kernel.org/r/20250517165713.935384-1-xin@zytor.com --- arch/x86/xen/enlighten_pv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c index 7f9ded1..26bbaf4 100644 --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c @@ -1162,7 +1162,7 @@ static void xen_do_write_msr(u32 msr, u64 val, int *e= rr) =20 static int xen_read_msr_safe(u32 msr, u64 *val) { - int err; + int err =3D 0; =20 *val =3D xen_do_read_msr(msr, &err); return err; @@ -1179,7 +1179,7 @@ static int xen_write_msr_safe(u32 msr, u64 val) =20 static u64 xen_read_msr(u32 msr) { - int err; + int err =3D 0; =20 return xen_do_read_msr(msr, xen_msr_safe ? &err : NULL); }