From nobody Fri Dec 19 21:30:33 2025 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90FD11C3BEE; Tue, 1 Apr 2025 07:15:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743491721; cv=none; b=Mmb15OFmRQ4sZvyvZutTFJe/AgRAFdr2CGj0Uv9rliVlnRaLryOJVYxugMVet0nNhmiVwurI6ViVLH5/jIUn9B2YxduKY96IzeUPxYwRlO5uDUXENqge1qaORH92ryfy+d0GhoVIFJLfQg0Lfv7lhc3ovxsziPjFgUi4maNdIjo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743491721; c=relaxed/simple; bh=NaVq7T5DmQjSEXSqCGXJ8Chfgy+8jpXv+92rtMXTAuc=; h=Date:From:To:Subject:Cc:In-Reply-To:References:MIME-Version: Message-ID:Content-Type; b=XmHNRpR2ojvoP4e+wLy6TZ2zokwSdR2651d43Tfj7nQCadFqC9iUEA1yO07pQ/Bs1nk/G84nFyrEbqaJ0wbVDIEOKbqRnITceMeI+CodHDebqvQIMqvPoKH7XnOo0d00miU1phPq6wPS5oqK6WNBKUwG/CngrYYHovL6XF/O2oo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=zZYru2tF; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=EA5qfOaM; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="zZYru2tF"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="EA5qfOaM" Date: Tue, 01 Apr 2025 07:15:17 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1743491717; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=69fIK0yHvgU+HXvgqzW1IA6EniJRCfM0IuI6vt0Degg=; b=zZYru2tFpaOJRsdcRC4uA30pgmvnD60tnHVqzDpkB2tZVsgvHiCfOhhuAAJOiqZCWO2l56 DNIa2CZQnTVvbKAbgoBg5C1nwKE7yJycyNsKNvOdpXc8V0VKbI/xpBuDho9ma2a40aexDC xgMjTcFRK/I+TJOO1cZigTYfcnKe+LkjIgY4efxnOLAKYl8TbvIbGjYMwhf7wGCaHv8nhs ALEMzpiFflH9lLHdNnBeKTrgaOVowd+qbHxPZn0qTg+6tDeQlNDGjja8ct7jXFE97TyzE3 L8a7MmsQaqj0IJugFbYS9cZZoo6rsSLHIL1ZNbXIhChrl4R5nBvK63lTN/uWsw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1743491717; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=69fIK0yHvgU+HXvgqzW1IA6EniJRCfM0IuI6vt0Degg=; b=EA5qfOaM6Ix4TseDboXiZdxHttkSr1jS4vMXu+xImUvckT8pdFWTYVYPPYUHGQY3bS4IWZ RemhIUunUeOuMODA== From: "tip-bot2 for David Laight" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: objtool/urgent] objtool: Fix verbose disassembly if CROSS_COMPILE isn't set Cc: David Laight , Josh Poimboeuf , Ingo Molnar , Linus Torvalds , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <174349171719.14745.7357908740148554493.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Precedence: bulk Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The following commit has been merged into the objtool/urgent branch of tip: Commit-ID: e77956e4e5c11218e60a1fe8cdbccd02476f2e56 Gitweb: https://git.kernel.org/tip/e77956e4e5c11218e60a1fe8cdbccd024= 76f2e56 Author: David Laight AuthorDate: Mon, 31 Mar 2025 21:26:42 -07:00 Committer: Ingo Molnar CommitterDate: Tue, 01 Apr 2025 09:07:13 +02:00 objtool: Fix verbose disassembly if CROSS_COMPILE isn't set In verbose mode, when printing the disassembly of affected functions, if CROSS_COMPILE isn't set, the objdump command string gets prefixed with "(null)". Somehow this worked before. Maybe some versions of glibc return an empty string instead of NULL. Fix it regardless. [ jpoimboe: Rewrite commit log. ] Fixes: ca653464dd097 ("objtool: Add verbose option for disassembling affect= ed functions") Signed-off-by: David Laight Signed-off-by: Josh Poimboeuf Signed-off-by: Ingo Molnar Cc: Linus Torvalds Link: https://lore.kernel.org/r/20250215142321.14081-1-david.laight.linux@g= mail.com Link: https://lore.kernel.org/r/b931a4786bc0127aa4c94e8b35ed617dcbd3d3da.17= 43481539.git.jpoimboe@kernel.org --- tools/objtool/check.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/objtool/check.c b/tools/objtool/check.c index ff83be1..4a1f6c3 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -4523,6 +4523,8 @@ static void disas_funcs(const char *funcs) char *cmd; =20 cross_compile =3D getenv("CROSS_COMPILE"); + if (!cross_compile) + cross_compile =3D ""; =20 objdump_str =3D "%sobjdump -wdr %s | gawk -M -v _funcs=3D'%s' '" "BEGIN { split(_funcs, funcs); }"